/srv/irclogs.ubuntu.com/2013/04/17/#launchpad-dev.txt

wgrantlifeless: Upgrading from fixtures 0.3.10 to 0.3.11 generates some garbage. Any ideas why?02:57
wgrantTests generated new (2) garbage:02:58
wgrant[<io.TextIOWrapper object at 0x12781bec>, <io.BytesIO object at 0x1185392c>]02:58
StevenKwgrant: You've really been on an upgrade kick ...02:58
wgrantStevenK: Well, we're 3-4 years behind on most things02:59
wgrantLast week we upgraded Zope and YUI, this week I'm upgrading everything else.02:59
StevenKWe weren't that far behind on YUI02:59
StevenKMaybe we need to downgrade to 2 or something02:59
=== cyclicflux is now known as Guest39382
=== Guest39382 is now known as CyclicFlux
=== jam1 is now known as jam
StevenKcontaining_div_node.addClass('yui3-skin-sam');06:43
StevenKWhich doesn't help06:43
StevenKCalendar, you're beginning to annoy me06:43
lifelesswgrant: garbage?07:03
wgrantlifeless: gc.garbage that remains after a gc.collect()07:13
wgrantPresumably due to reference cycles07:13
lifelessI don't know why that isn't collected, TextIOWrapper -> BytesIO is a one way ref.07:13
wgrantYeah, that's what it looks like :/07:14
wgrantMaybe the TextIOWrapper is referenced elsewhere07:14
wgrantBut then it shouldn't be garbage07:15
czajkowskiGooooooood morning07:16
wgrantMorning czajkowski07:17
lifelesswgrant: so the Q is can you reproduce it.07:29
lifelessGnight.07:29
wgrantlifeless: It's easy to reproduce as part of a particular LP test, but I was going to check if you knew anything before isolating.07:32
wgrantWill do so07:32
czajkowskicjwatson: when you're about can you give me a shout please, I seem to have broken something on my machine and in need of your assitance, for this I shall send you cake and biscuits :)07:34
cjwatsonczajkowski: Hi08:28
cjwatsonwgrant: So, I think I ended up not using fmt:link here because an earlier version rendered a link for primary archives as well (and I've reverted to that version per your feedback) and there's no link implementation for Archives other than PPAs08:29
cjwatsonwgrant: And as a result the TAL ended up being annoyingly cumbersome with fmt:link, rather than simpler as it's meant to be08:30
wgrantcjwatson: Oh, it just leaves primary archives unlinked?08:30
wgrantAnd copy archives too?08:30
czajkowskicjwatson: shall move to kernel and fill you in there08:31
czajkowskior is foundation better?08:31
cjwatsonczajkowski: What's it about?08:31
cjwatsonThere's no foundations channel, intentionally08:31
czajkowskiahh08:31
cjwatsonAnd I'm not a kernel developer, so I doubt that's appropriate :)08:31
czajkowskicjwatson: on start up this morning I'm http://ubuntuone.com/1REKSBU0jU7XITkpfBK0RQ08:31
cjwatsonwgrant: Trying to use fmt:link on a primary archive raises NotImplementedError08:32
wgrantcjwatson: Well that's a bit crap.08:32
cjwatsonwgrant: Maybe I should add a generic link implementation for archives that does <a class="sprite distribution" etc>?08:32
wgrantYet easily fixed, and it probably makes sense08:32
wgrantYeah08:32
wgrantCopy archives should probably use the PPA icon, but primary/partner can use the distro one08:33
cjwatsonAnd we can use that for all other archives, and probably delete some insane TAL elsewhere08:33
wgrantThey could even link directly to the distro08:33
cjwatsonczajkowski: Nothing wrong with that - you might get the menu when you don't normally if a previous boot failed08:33
cjwatsonBut just press Enter and carry on08:34
czajkowskicjwatson: aye I did then I went to ubuntu advanced and moved down to recovery kernel. but no matter how many reboots I still up at that screen :/08:34
cjwatsonrecovery kernel won't count as a successful boot08:34
cjwatsonthe point of this is to show the menu when people seem to be having trouble08:35
cjwatsonnow, if you see it after a non-recovery boot, that's a bit odd and we can investigate in #ubuntu-devel08:36
czajkowskiahhhh08:37
czajkowskicheers cjwatson  :)08:37
cjwatsonwgrant: Do <adapter /> directives in lib/lp/app/browser/configure.zcml magically pick the closest match somehow, or do I need to take inheritance into account?08:45
cjwatsonAlso, I happened to notice that https://bazaar.launchpad.net/~launchpad/+junk/dbpatches/view/head:/allocated.txt seems to be missing 2209-43-008:46
wgrantcjwatson: It should pick the closest adapter08:47
wgrantSo an IPPA adapter will override one for IArchive for PPAs08:48
cjwatsonOK.  Though, hmm, I wonder how "closest" is defined given that IPPA is only done by alsoProvides08:51
wgrantOh, true08:52
wgrantThat's a good question...08:52
cjwatsonMaybe it'd be clearer to turn PPAFormatterAPI into ArchiveFormatterAPI and do the checks explicitly08:52
wgrantQuite likely.08:53
cjwatsonwgrant: Copy archive icon - using the PPA icon would be inconsistent with ArchiveImageDisplayAPI.icon ("ArchivePurpose.COPY: '/@@/distribution'").  Do you want that changed?09:03
wgrantcjwatson: I'd forgotten there was precedent, so go with that.09:08
cjwatsonwgrant: Is there any precedent anywhere for what to do when trying to render a copy from an inaccessible private PPA?  The current version is 'Sync from <tal:archive content="source_archive/displayname" />, ...'; if I do the na├»ve thing and replace that with 'Sync from <a tal:replace="structure source_archive/fmt:link" />, ...', I end up with "Sync from , ..." in the output which is less than ideal10:03
cjwatsonI guess something like SourcePublishingRecordView.linkify_source_archive10:22
wgrantcjwatson: For private teams we say <redacted>, IIRC10:43
wgrantShould probably do a similar thing here.10:43
cjwatsonAt the moment I think we must show the archive displayname10:43
cjwatsonBut I suppose arguably that's wrong10:44
cjwatsonPerhaps also "Building private job" as precedent10:45
wgrantYeah, maybe10:45
cjwatsonSo it's tempting to say "Sync from private archive"10:45
wgrantIndeed10:46
cjwatsonwgrant: OK, would you mind re-reviewing https://code.launchpad.net/~cjwatson/launchpad/queue-copy-archive-links/+merge/159250 ?  I know you approved already, but the changes are fairly substantial.11:06
cjwatsonI suspect I'll have some doctest damage, which I'll let EC2 catch11:07
wgrantcjwatson: That looks fine. Thanks.11:19
cjwatsonNow, I wonder why my EC2 setup is busted ... http://paste.ubuntu.com/5715669/11:25
wgrantcjwatson: Seems to be a change in python-boto. http://paste.ubuntu.com/5715687/ seems to fix it11:37
cjwatsonHm, the python-boto package hasn't changed since last May11:37
cjwatsonI wonder if it's an EC2 change tickling an existing bug11:38
wgrantCould be11:38
wgrantI use it so infrequently that I didn't bother to do more than hack it to work.11:38
cjwatsonwgrant: Much better, thanks11:51
=== cjohnston_ is now known as cjohnston
=== wedgwood_away is now known as wedgwood
=== wedgwood is now known as Guest86505
=== wedgwood_ is now known as wedgwood
=== BradCrittenden is now known as bac
cjwatsonGrr, these failures didn't show up in ec2, probably because the test runner there apparently hung :-/16:11
cjwatsonOh well, should be easy enough to fix16:12
cjwatsonhttps://code.launchpad.net/~cjwatson/launchpad/queue-copy-archive-links-testfix/+merge/159442 - test fixes, could use a review16:48
=== deryck is now known as deryck[lunch]
=== olli_ is now known as olli
=== deryck[lunch] is now known as deryck
=== wedgwood is now known as wedgwood_away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!