StevenKwallyworld_, wgrant: http://wedontsleep.org/~steven/new-calendar-2.jpg01:33
wallyworld_so close01:33
wallyworld_pity is has to be inside the overlay though01:33
wgrantI think that time thing is in a yui3-g without being inside a yui3-u01:33
wallyworld_is there no way it can just be a calendar without needing the overlay?01:34
StevenKwallyworld_: The calendar doesn't handle hiding and such, it is designed to be shown in a page01:35
StevenKwgrant: I should set the class of the time div to yui3-u?01:36
wallyworld_ok. pity. yui's fault i guess01:36
StevenKwallyworld_: The docs for Y.Calendar say that popup functionality will be added later01:36
wgrantStevenK: Right, if it's inside a yui3-g it needs to be wrapped in a yui3-u (or yui3-u variant)01:36
wallyworld_ah ok01:36
wgrantyui3-g changes text spacing to make the grid bits fit together better01:37
wgrantyui3-u resets it to actually be sane for text01:37
StevenKThat looks much better01:37
StevenKThe only thing left on my list is the overlay is too wide01:38
StevenKSetting a width below about 415px is ignored01:38
wgrantYou also really want to remove the calendar outline and background01:38
wgrantAnd centre it in the overlay01:38
StevenKwgrant: That's done by a yui3-calendar-content div, can I select it and remove it?01:40
StevenKWith its children being re-parented, that is01:40
wgrantStevenK: Or override the skin01:41
StevenKwgrant: For that one div?01:42
wgrantStevenK: Probably.01:57
wgrantStevenK: I forgot how much is the skin and how much is core01:57
wgrantIt may be worth just not using the skin at all01:58
StevenKwgrant: Removing the skin from the containing div seems to have little effect02:00
wgrantStevenK: What do you mean "removing the skin"?02:01
StevenKdiv class="yui3-g" rather than "yui3-skin-sam yui3-g"02:02
wgrantIsn't the yui3-skin-sam class on the <body>?02:02
StevenKwgrant: There is one on the body as well, yes02:05
StevenKThat may impact far more than just the calendar02:05
wgrantStevenK: Didn't you just add it to the body?02:06
wgrantOr was it there originally?02:06
wgrantStevenK: Removing it from the div won't do anything if it's on the body.02:07
wgrantAny ancestor counts02:07
StevenKwgrant: I didn't add it to the body, no02:07
wgrantAh, right, a few of our widgets and the accordion use it02:08
wgrantStevenK: Perhaps just add some rules to override the border away02:08
wgrantStevenK: https://code.launchpad.net/~wgrant/launchpad/sharing-icon-fix/+merge/15975104:21
StevenKwgrant: The grantee_row.one means it would only find the first and not act on the others?04:23
wgrantStevenK: Right. And unlike Storm's .one(), it won't crash if there's more than one.04:23
StevenKwgrant: I thought the +sharing stuff had fairly good JS tests, can haz?04:24
StevenKwgrant: I am a bad person. "Y.one('.yui3-calendar-content').removeClass(04:32
wgrantStevenK: Won't that completely destyle it?04:33
wgrantI'd prefer just adding some LP CSS rules to override the styles04:33
StevenKwgrant: No? http://wedontsleep.org/~steven/new-calendar-3.jpg04:35
wgrantAh, I guess the other styles must be on yui3-calendar-header and the like04:36
wgrantStevenK: Even so, that's far more evil than just overriding the style04:36
StevenKBut it's evil that works!04:36
StevenKwgrant: And I suspect due to the way we are putting the CSS in the METAL macro the calendar CSS is loaded after combo.css04:37
wgrantStevenK: You could limit the selector to calendars within an overlay04:40
wgrantThat both makes sense and should increase the specificity04:41
wgrantSo your rule overrides even though it's earlier04:41
StevenKwgrant: .yui3-pretty-overlay.yui3-calendar-content { ... ?04:45
wgrantStevenK: They're not on the same element, are they?04:49
StevenKwgrant: No04:49
wgrantStevenK: Then that doesn't make sense04:54
wgrantYou at least need a space :)04:54
StevenK".yui3-pretty-overlay .yui3-calendar-content {04:57
StevenKThat gets listed second and as overridden by firebug04:57
wgrantStevenK: What's the selector on the rule that overrides it?04:58
StevenK.yui3-skin-sam .yui3-calendar-content {04:59
wgrantAdd .yui3-skin-sam and it will work04:59
StevenKStill convinced CSS is black magic05:00
StevenKwgrant: Indeed, looks great05:01
wgrantA style attribute always wins. After that, basically a tuple of (number of ID references, number of class references, number of element references) is generated for each selector, and the greatest one wins.05:01
wgrantSo #foo > .foo bar.baz > .foo .baz > .foo > bar05:02
StevenKwgrant: Right, so in this case, my background: none, border: none win out, and the selector from calendar-base isn't applied since it would trump a higher rule?05:02
wgrantStevenK: The grouping of rules wihin a single selector doesn't matter.05:03
wgrantThe winner is calculated on a per-attribute basis.05:03
StevenKwgrant: Now we just need to center the calendar and I think we're good05:04
wgrantSo if I have "a {text-align: left; font-weight: bold}; a.normal {font-weight: normal};", an <a class="normal"> will get text-align: left; font-weight: normal;05:04
wgrantStevenK: Indeed05:05
wgrantA margin: auto; somewhere should do the trick.05:05
StevenKstyle="text-align:center" on the enclosing div?05:05
wgrantI'd avoid text-align here, probably.05:05
wgrantBut it might work.05:05
wgrantI haven't looked at the structure created by the calendar widget.05:05
wgrantBut text-align might work if the container is an inline-block05:05
StevenKI'll try margin: auto; on the overlay's body div05:06
=== almaisan-away is now known as al-maisan
StevenKwgrant: margin: auto; does not help05:08
wgrantStevenK: Are you sure that's on the right element?05:09
wgrantIt needs to be the top-level uncentered element, and it needs to be a block inside a block05:09
StevenKIt's the container, which has the calender inside it05:10
StevenKThe container is then the bodyContent for the overlay05:10
StevenKwgrant: Clear as mud?05:12
wgrantPoke around and see what works :)05:13
=== al-maisan is now known as almaisan-away
StevenKwgrant: In terms of margin: auto, nothing05:24
StevenKI've put it on the calendar div itself, the container div, the yui3-overlay-bd div and the yui3-pretty-overlay-content div05:24
wgrantStevenK: I've pushed up a test (and fixed an existing test which would have always passed)06:11
wgrantStevenK: Thanks.06:23
StevenKwgrant: Sorry, got distracted by a phone call, but it did get marked as approve?06:23
StevenKRight, excellent06:24
=== olli__ is now known as olli
=== wedgwood_away is now known as wedgwood
=== yofel_ is now known as yofel
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== almaisan-away is now known as al-maisan
=== wedgwood is now known as wedgwood_away
=== wedgwood_away is now known as wedgwood
=== Ursinha is now known as Ursinha-afk
* cjwatson tries to understand https://launchpad.net/ubuntu/raring/i386/ubuntuone-couch23:14
cjwatsonWas that a change-override accident or something?23:15
=== al-maisan is now known as almaisan-away
=== wedgwood is now known as wedgwood_away
=== almaisan-away is now known as al-maisan

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!