[01:33] wallyworld_, wgrant: http://wedontsleep.org/~steven/new-calendar-2.jpg [01:33] so close [01:33] pity is has to be inside the overlay though [01:33] I think that time thing is in a yui3-g without being inside a yui3-u [01:34] is there no way it can just be a calendar without needing the overlay? [01:35] wallyworld_: The calendar doesn't handle hiding and such, it is designed to be shown in a page [01:36] wgrant: I should set the class of the time div to yui3-u? [01:36] ok. pity. yui's fault i guess [01:36] wallyworld_: The docs for Y.Calendar say that popup functionality will be added later [01:36] StevenK: Right, if it's inside a yui3-g it needs to be wrapped in a yui3-u (or yui3-u variant) [01:36] ah ok [01:37] yui3-g changes text spacing to make the grid bits fit together better [01:37] yui3-u resets it to actually be sane for text [01:37] That looks much better [01:38] The only thing left on my list is the overlay is too wide [01:38] Setting a width below about 415px is ignored [01:38] You also really want to remove the calendar outline and background [01:38] And centre it in the overlay [01:40] wgrant: That's done by a yui3-calendar-content div, can I select it and remove it? [01:40] With its children being re-parented, that is [01:41] StevenK: Or override the skin [01:42] wgrant: For that one div? [01:57] StevenK: Probably. [01:57] StevenK: I forgot how much is the skin and how much is core [01:58] It may be worth just not using the skin at all [02:00] wgrant: Removing the skin from the containing div seems to have little effect [02:01] StevenK: What do you mean "removing the skin"? [02:02] div class="yui3-g" rather than "yui3-skin-sam yui3-g" [02:02] Isn't the yui3-skin-sam class on the ? [02:05] wgrant: There is one on the body as well, yes [02:05] That may impact far more than just the calendar [02:06] StevenK: Didn't you just add it to the body? [02:06] Or was it there originally? [02:07] StevenK: Removing it from the div won't do anything if it's on the body. [02:07] Any ancestor counts [02:07] wgrant: I didn't add it to the body, no [02:08] Ah, right, a few of our widgets and the accordion use it [02:08] StevenK: Perhaps just add some rules to override the border away [04:21] StevenK: https://code.launchpad.net/~wgrant/launchpad/sharing-icon-fix/+merge/159751 [04:23] wgrant: The grantee_row.one means it would only find the first and not act on the others? [04:23] StevenK: Right. And unlike Storm's .one(), it won't crash if there's more than one. [04:24] Right [04:24] wgrant: I thought the +sharing stuff had fairly good JS tests, can haz? [04:32] wgrant: I am a bad person. "Y.one('.yui3-calendar-content').removeClass( [04:32] 'yui3-calendar-content'); [04:33] StevenK: Won't that completely destyle it? [04:33] I'd prefer just adding some LP CSS rules to override the styles [04:35] wgrant: No? http://wedontsleep.org/~steven/new-calendar-3.jpg [04:36] Ah, I guess the other styles must be on yui3-calendar-header and the like [04:36] Yeah [04:36] StevenK: Even so, that's far more evil than just overriding the style [04:36] But it's evil that works! [04:37] wgrant: And I suspect due to the way we are putting the CSS in the METAL macro the calendar CSS is loaded after combo.css [04:40] StevenK: You could limit the selector to calendars within an overlay [04:41] That both makes sense and should increase the specificity [04:41] So your rule overrides even though it's earlier [04:45] wgrant: .yui3-pretty-overlay.yui3-calendar-content { ... ? [04:49] StevenK: They're not on the same element, are they? [04:49] wgrant: No [04:54] StevenK: Then that doesn't make sense [04:54] You at least need a space :) [04:57] ".yui3-pretty-overlay .yui3-calendar-content { [04:57] That gets listed second and as overridden by firebug [04:58] StevenK: What's the selector on the rule that overrides it? [04:59] .yui3-skin-sam .yui3-calendar-content { [04:59] Ah [04:59] Add .yui3-skin-sam and it will work [05:00] Still convinced CSS is black magic [05:01] wgrant: Indeed, looks great [05:01] A style attribute always wins. After that, basically a tuple of (number of ID references, number of class references, number of element references) is generated for each selector, and the greatest one wins. [05:02] So #foo > .foo bar.baz > .foo .baz > .foo > bar [05:02] wgrant: Right, so in this case, my background: none, border: none win out, and the selector from calendar-base isn't applied since it would trump a higher rule? [05:03] StevenK: The grouping of rules wihin a single selector doesn't matter. [05:03] The winner is calculated on a per-attribute basis. [05:03] Right [05:04] wgrant: Now we just need to center the calendar and I think we're good [05:04] So if I have "a {text-align: left; font-weight: bold}; a.normal {font-weight: normal};", an will get text-align: left; font-weight: normal; [05:05] StevenK: Indeed [05:05] A margin: auto; somewhere should do the trick. [05:05] style="text-align:center" on the enclosing div? [05:05] I'd avoid text-align here, probably. [05:05] But it might work. [05:05] I haven't looked at the structure created by the calendar widget. [05:05] But text-align might work if the container is an inline-block [05:06] I'll try margin: auto; on the overlay's body div === almaisan-away is now known as al-maisan [05:08] wgrant: margin: auto; does not help [05:09] StevenK: Are you sure that's on the right element? [05:09] It needs to be the top-level uncentered element, and it needs to be a block inside a block [05:10] It's the container, which has the calender inside it [05:10] The container is then the bodyContent for the overlay [05:12] wgrant: Clear as mud? [05:13] Poke around and see what works :) === al-maisan is now known as almaisan-away [05:24] wgrant: In terms of margin: auto, nothing [05:24] I've put it on the calendar div itself, the container div, the yui3-overlay-bd div and the yui3-pretty-overlay-content div [06:11] StevenK: I've pushed up a test (and fixed an existing test which would have always passed) [06:23] StevenK: Thanks. [06:23] wgrant: Sorry, got distracted by a phone call, but it did get marked as approve? [06:24] Yep [06:24] Right, excellent === olli__ is now known as olli === wedgwood_away is now known as wedgwood === yofel_ is now known as yofel === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === almaisan-away is now known as al-maisan === wedgwood is now known as wedgwood_away === wedgwood_away is now known as wedgwood === Ursinha is now known as Ursinha-afk [23:14] * cjwatson tries to understand https://launchpad.net/ubuntu/raring/i386/ubuntuone-couch [23:15] Was that a change-override accident or something? === al-maisan is now known as almaisan-away === wedgwood is now known as wedgwood_away === almaisan-away is now known as al-maisan