[01:33] <StevenK> wallyworld_, wgrant: http://wedontsleep.org/~steven/new-calendar-2.jpg
[01:33] <wallyworld_> so close
[01:33] <wallyworld_> pity is has to be inside the overlay though
[01:33] <wgrant> I think that time thing is in a yui3-g without being inside a yui3-u
[01:34] <wallyworld_> is there no way it can just be a calendar without needing the overlay?
[01:35] <StevenK> wallyworld_: The calendar doesn't handle hiding and such, it is designed to be shown in a page
[01:36] <StevenK> wgrant: I should set the class of the time div to yui3-u?
[01:36] <wallyworld_> ok. pity. yui's fault i guess
[01:36] <StevenK> wallyworld_: The docs for Y.Calendar say that popup functionality will be added later
[01:36] <wgrant> StevenK: Right, if it's inside a yui3-g it needs to be wrapped in a yui3-u (or yui3-u variant)
[01:36] <wallyworld_> ah ok
[01:37] <wgrant> yui3-g changes text spacing to make the grid bits fit together better
[01:37] <wgrant> yui3-u resets it to actually be sane for text
[01:37] <StevenK> That looks much better
[01:38] <StevenK> The only thing left on my list is the overlay is too wide
[01:38] <StevenK> Setting a width below about 415px is ignored
[01:38] <wgrant> You also really want to remove the calendar outline and background
[01:38] <wgrant> And centre it in the overlay
[01:40] <StevenK> wgrant: That's done by a yui3-calendar-content div, can I select it and remove it?
[01:40] <StevenK> With its children being re-parented, that is
[01:41] <wgrant> StevenK: Or override the skin
[01:42] <StevenK> wgrant: For that one div?
[01:57] <wgrant> StevenK: Probably.
[01:57] <wgrant> StevenK: I forgot how much is the skin and how much is core
[01:58] <wgrant> It may be worth just not using the skin at all
[02:00] <StevenK> wgrant: Removing the skin from the containing div seems to have little effect
[02:01] <wgrant> StevenK: What do you mean "removing the skin"?
[02:02] <StevenK> div class="yui3-g" rather than "yui3-skin-sam yui3-g"
[02:02] <wgrant> Isn't the yui3-skin-sam class on the <body>?
[02:05] <StevenK> wgrant: There is one on the body as well, yes
[02:05] <StevenK> That may impact far more than just the calendar
[02:06] <wgrant> StevenK: Didn't you just add it to the body?
[02:06] <wgrant> Or was it there originally?
[02:07] <wgrant> StevenK: Removing it from the div won't do anything if it's on the body.
[02:07] <wgrant> Any ancestor counts
[02:07] <StevenK> wgrant: I didn't add it to the body, no
[02:08] <wgrant> Ah, right, a few of our widgets and the accordion use it
[02:08] <wgrant> StevenK: Perhaps just add some rules to override the border away
[04:21] <wgrant> StevenK: https://code.launchpad.net/~wgrant/launchpad/sharing-icon-fix/+merge/159751
[04:23] <StevenK> wgrant: The grantee_row.one means it would only find the first and not act on the others?
[04:23] <wgrant> StevenK: Right. And unlike Storm's .one(), it won't crash if there's more than one.
[04:24] <StevenK> Right
[04:24] <StevenK> wgrant: I thought the +sharing stuff had fairly good JS tests, can haz?
[04:32] <StevenK> wgrant: I am a bad person. "Y.one('.yui3-calendar-content').removeClass(
[04:32] <StevenK> 'yui3-calendar-content');
[04:33] <wgrant> StevenK: Won't that completely destyle it?
[04:33] <wgrant> I'd prefer just adding some LP CSS rules to override the styles
[04:35] <StevenK> wgrant: No? http://wedontsleep.org/~steven/new-calendar-3.jpg
[04:36] <wgrant> Ah, I guess the other styles must be on yui3-calendar-header and the like
[04:36] <StevenK> Yeah
[04:36] <wgrant> StevenK: Even so, that's far more evil than just overriding the style
[04:36] <StevenK> But it's evil that works!
[04:37] <StevenK> wgrant: And I suspect due to the way we are putting the CSS in the METAL macro the calendar CSS is loaded after combo.css
[04:40] <wgrant> StevenK: You could limit the selector to calendars within an overlay
[04:41] <wgrant> That both makes sense and should increase the specificity
[04:41] <wgrant> So your rule overrides even though it's earlier
[04:45] <StevenK> wgrant: .yui3-pretty-overlay.yui3-calendar-content { ... ?
[04:49] <wgrant> StevenK: They're not on the same element, are they?
[04:49] <StevenK> wgrant: No
[04:54] <wgrant> StevenK: Then that doesn't make sense
[04:54] <wgrant> You at least need a space :)
[04:57] <StevenK> ".yui3-pretty-overlay .yui3-calendar-content {
[04:57] <StevenK> That gets listed second and as overridden by firebug
[04:58] <wgrant> StevenK: What's the selector on the rule that overrides it?
[04:59] <StevenK> .yui3-skin-sam .yui3-calendar-content {
[04:59] <wgrant> Ah
[04:59] <wgrant> Add .yui3-skin-sam and it will work
[05:00] <StevenK> Still convinced CSS is black magic
[05:01] <StevenK> wgrant: Indeed, looks great
[05:01] <wgrant> A style attribute always wins. After that, basically a tuple of (number of ID references, number of class references, number of element references) is generated for each selector, and the greatest one wins.
[05:02] <wgrant> So #foo > .foo bar.baz > .foo .baz > .foo > bar
[05:02] <StevenK> wgrant: Right, so in this case, my background: none, border: none win out, and the selector from calendar-base isn't applied since it would trump a higher rule?
[05:03] <wgrant> StevenK: The grouping of rules wihin a single selector doesn't matter.
[05:03] <wgrant> The winner is calculated on a per-attribute basis.
[05:03] <StevenK> Right
[05:04] <StevenK> wgrant: Now we just need to center the calendar and I think we're good
[05:04] <wgrant> So if I have "a {text-align: left; font-weight: bold}; a.normal {font-weight: normal};", an <a class="normal"> will get text-align: left; font-weight: normal;
[05:05] <wgrant> StevenK: Indeed
[05:05] <wgrant> A margin: auto; somewhere should do the trick.
[05:05] <StevenK> style="text-align:center" on the enclosing div?
[05:05] <wgrant> I'd avoid text-align here, probably.
[05:05] <wgrant> But it might work.
[05:05] <wgrant> I haven't looked at the structure created by the calendar widget.
[05:05] <wgrant> But text-align might work if the container is an inline-block
[05:06] <StevenK> I'll try margin: auto; on the overlay's body div
[05:08] <StevenK> wgrant: margin: auto; does not help
[05:09] <wgrant> StevenK: Are you sure that's on the right element?
[05:09] <wgrant> It needs to be the top-level uncentered element, and it needs to be a block inside a block
[05:10] <StevenK> It's the container, which has the calender inside it
[05:10] <StevenK> The container is then the bodyContent for the overlay
[05:12] <StevenK> wgrant: Clear as mud?
[05:13] <wgrant> Poke around and see what works :)
[05:24] <StevenK> wgrant: In terms of margin: auto, nothing
[05:24] <StevenK> I've put it on the calendar div itself, the container div, the yui3-overlay-bd div and the yui3-pretty-overlay-content div
[06:11] <wgrant> StevenK: I've pushed up a test (and fixed an existing test which would have always passed)
[06:23] <wgrant> StevenK: Thanks.
[06:23] <StevenK> wgrant: Sorry, got distracted by a phone call, but it did get marked as approve?
[06:24] <wgrant> Yep
[06:24] <StevenK> Right, excellent
[23:14]  * cjwatson tries to understand https://launchpad.net/ubuntu/raring/i386/ubuntuone-couch
[23:15] <cjwatson> Was that a change-override accident or something?