| didrocks | hey Mirv, how was your week-end? | 07:01 |
|---|---|---|
| Mirv | didrocks: hello, very relaxing thank you | 07:39 |
| didrocks | nice! I hope the weather is better than what's I'm seeing here :) | 07:40 |
| didrocks | hey sil2100! nice week-end as well? | 07:40 |
| Mirv | pretty good today, spring if finally arriving | 07:41 |
| didrocks | lucky you :-) | 07:41 |
| didrocks | Mirv: did you get some progressed on autopilot vs sdk package? | 07:41 |
| Mirv | didrocks: yes, I managed to fix all the tests eventually, in addition to adding the separate autopilot package. waiting for my merge proposal to be accepted, after which I'll contact Francis to start running the tests. | 07:45 |
| didrocks | Mirv: oh, you don't need to contact him, we can add them to our generic autopilot job for daily release :) | 07:46 |
| didrocks | Mirv: awesome news! good job :) | 07:46 |
| Mirv | didrocks: ah, ok. thanks. | 07:47 |
| didrocks | Mirv: do you mind updating this spreadsheet please: https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AuDk72Lpx8U5dFVVX1BOYm1qdUtyX2xUNmdwWlhTS0E#gid=0 | 07:47 |
| didrocks | Mirv: with the command to run and so on :) | 07:47 |
| didrocks | I think you already did it :) | 07:47 |
| didrocks | (just double checking) | 07:47 |
| Mirv | didrocks: yes, I did :) | 07:47 |
| didrocks | excellent ;) | 07:48 |
| didrocks | Mirv: do you have time to check with in the daily-build-next ppa, we have a lot of unity stack failures? (not the touch stack, only the unity one) | 07:50 |
| Mirv | didrocks: not right away, but I can take a look in the afternoon | 07:51 |
| didrocks | thanks :) | 07:51 |
| dednick | Saviq: ping | 07:53 |
| Saviq | dednick, pong | 07:53 |
| dednick | Saviq: do you know if there's something wrong with the qmluitest jenkins build? keeps failing. http://s-jenkins:8080/job/unity-phablet-qmluitests/493/console | 07:53 |
| dednick | all i can see is that it can't connect to dbus, but dont know if that is the root of problem | 07:54 |
| Saviq | dednick, nah, the problem is "QXcbConnection: XCB error: 148 (Unknown), sequence: 148, resource id: 0, major code: 140 (Unknown), minor code: 20" | 07:54 |
| Saviq | dednick, unfortunately we don't have a solution for that yet | 07:55 |
| Saviq | dednick, we just restart the job and hope for the best... | 07:55 |
| dednick | Saviq: i c. ok | 07:55 |
| Saviq | mzanetti, anything to add ^? | 07:55 |
| sil2100 | didrocks: hi! A very busy weekend sadly, but oh well! How about you? | 07:56 |
| didrocks | sil2100: was uninteresting, stayed at home most of the time due to the bad weather | 07:56 |
| sil2100 | Bad weather? Oh my, here in Poland we had sunny sunshine almost all the time | 07:57 |
| sil2100 | 'almost' | 07:57 |
| sil2100 | ;) | 07:57 |
| didrocks | waow, lucky, here since Friday, the weather isn't really nice… | 07:57 |
| dednick | Saviq: can i restart jobs? all i see in the "build again" page is "publish again". is that the same? | 07:57 |
| Saviq | dednick, you need to log in to s-jenkins | 07:58 |
| dednick | Saviq: nevermind. yeah, i realised i wasn't logged in | 07:58 |
| didrocks | sil2100: how busy are you today? we are going to switch the new HUD after the finale touch quantal image is in (today normally) | 07:58 |
| didrocks | sil2100: I wonder if meanwhile you can look at the touch-related build failures in the ppa | 07:58 |
| dednick | Cimi: ping | 07:59 |
| sil2100 | didrocks: ok, will look - in the daily-next PPA, yes? | 07:59 |
| didrocks | sil2100: right! thanks :) | 07:59 |
| Saviq | tsdgeos, do you know of a way for automoc to play nice with headers kept separately from source files? | 07:59 |
| tsdgeos | Saviq: have never found myself in need of that | 08:00 |
| tsdgeos | so nope | 08:00 |
| tsdgeos | Saviq: what's the rationale for such a split? | 08:15 |
| Saviq | tsdgeos, better structure, really, but I'm not convinced, either | 08:17 |
| tsdgeos | to me it seems worse structure | 08:17 |
| tsdgeos | won't be able to find a header by just doing s/.cpp/.h | 08:17 |
| tsdgeos | that's always confused the hell out of me | 08:18 |
| Saviq | dednick, commit message missing https://code.launchpad.net/~nick-dedekind/unity/phablet-greeter-indicators/+merge/157330 | 08:25 |
| Saviq | tsdgeos, yeah I actually agree, I'd just put actual includes in /include | 08:25 |
| dednick | Saviq: thanks. done | 08:25 |
| mhr3 | dednick, using ff or chrome? | 08:26 |
| dednick | mhr3: chrome | 08:26 |
| mhr3 | dednick, http://userscripts.org/scripts/show/139081 ;) | 08:26 |
| dednick | mhr3: normally. | 08:26 |
| mhr3 | > Also adds a warning if there's no commit message specified for the merge proposal. | 08:26 |
| Saviq | ;) | 08:27 |
| Saviq | tsdgeos, where only files that others might want to include, live | 08:27 |
| dednick | mhr3: cool. thanks :) | 08:27 |
| tsdgeos | Saviq: you mean for public vs private includes? | 08:28 |
| Saviq | tsdgeos, yeah | 08:28 |
| tsdgeos | personally i like the .h/_p.h that Qt uses | 08:28 |
| tsdgeos | but don't have any strong opinion either | 08:28 |
| tsdgeos | mzanetti: easy one https://code.launchpad.net/~aacid/unity/filtergrid_test_findChild/+merge/160034 | 08:48 |
| tsdgeos | mzanetti: sadly we still need one of the __testing properties | 08:49 |
| tsdgeos | since behaviours are not part of children of a item | 08:49 |
| tsdgeos | so there's some stuff we can't get to even if we give an objectName :/ | 08:49 |
| tsdgeos | maybe in the C++ side we can? | 08:49 |
| mzanetti | tsdgeos: same with Timers btw | 08:55 |
| mzanetti | tsdgeos: would be awesome to have something where we could get them... but so far I couldn't come up with anything (didn't invest too much time tho) | 08:55 |
| tsdgeos | tried using C++ QObject::children() ? | 08:56 |
| mzanetti | tsdgeos: nope | 08:56 |
| Cimi | dednick, hi nick | 09:24 |
| tsdgeos | mzanetti: might work | 09:32 |
| tsdgeos | back in a sec, my X froze and now it's doing weird stuff | 09:34 |
| Saviq | MacSlow, you might need to resubmit your renderer MP, LP seems to have gotten confused and has not included the latest changes (still shows conflicts) | 09:39 |
| MacSlow | Saviq, argl... hm... ok | 09:40 |
| Saviq | MacSlow, also, I'd like to get rid of the print()s | 09:40 |
| Saviq | MacSlow, I'd convert them into a signal clicked(string) | 09:41 |
| Saviq | MacSlow, so that you can then test that they got clicked (or not) in the tests | 09:41 |
| Saviq | MacSlow, you'll need a signal clicked(string) on both Notification and Notifications | 09:41 |
| Saviq | MacSlow, and in Notifications' delegate you'll forward that signal up | 09:42 |
| Saviq | MacSlow, and then in the tests use SignalSpy component to check if you can actually click on the actions | 09:43 |
| Saviq | mzanetti, can you please have a quick look through https://code.launchpad.net/~macslow/unity/phablet-notification-renderer/+merge/155512 | 09:43 |
| mzanetti | Saviq: ack | 09:43 |
| Saviq | mzanetti, and see if you come up with anything else that makes sense testing | 09:43 |
| Saviq | mzanetti, read up, too | 09:43 |
| mzanetti | ack | 09:43 |
| Saviq | mzanetti, thanks | 09:43 |
| MacSlow | Saviq, ok | 09:44 |
| sil2100 | didrocks: ok, so: | 09:48 |
| sil2100 | didrocks: https://code.launchpad.net/~sil2100/indicator-messages/fix_ftbfs_deprecated_func/+merge/160038 <- for the indicator-messages FTBFS | 09:49 |
| sil2100 | didrocks: I also have a branch for the gallery-app FTBFS but still waiting for a PPA test build | 09:49 |
| didrocks | sil2100: excellent! thanks :) | 09:50 |
| tsdgeos | Saviq: how does https://code.launchpad.net/~aacid/unity/filtergrid_remove_itemY/+merge/160050 look for the itemY function removal? | 09:52 |
| Saviq | tsdgeos, we don't want to pass delegates around | 09:52 |
| tsdgeos | Saviq: why not? | 09:53 |
| Saviq | tsdgeos, they get destroyed when you're not looking ;) | 09:53 |
| tsdgeos | sure, the only thing you have to do is not store them :D | 09:53 |
| Saviq | mzanetti, ^ ;) | 09:53 |
| Saviq | fight! | 09:54 |
| tsdgeos | Saviq: well, i can pass up the "y" that's the only thing i need from the delegate | 09:54 |
| tsdgeos | but note the carousel is already passing the delegate up | 09:55 |
| tsdgeos | maybe not in the listview version, let me check | 09:55 |
| tsdgeos | nope, still there | 09:55 |
| mzanetti | tsdgeos: in my experience using delegates inevitably leads to bad code... I do know that there are cases where its not harmful. But so far in my experience once you do that you start introducing work arounds in future revisions. | 09:56 |
| Saviq | tsdgeos, my thinking was to pass up a Qt.rect() | 09:56 |
| mzanetti | best example: notes-app | 09:56 |
| Saviq | tsdgeos, that should get parented to the Qt global object anyway | 09:56 |
| Saviq | tsdgeos, but then we need to make sure to delete it afterwards | 09:56 |
| mzanetti | was a listView and they were using the currentItem outside of the listview. next MP changed it to be a Column + Repeater because it was crashing sometimes with the listview... | 09:57 |
| Saviq | tsdgeos, and would give us all we need (i.e. in People on phone the split is _after_ the clicked item, not before it) | 09:57 |
| tsdgeos | mzanetti: but that's like forbidding pointers because using them wrongly will make you crash :D | 09:57 |
| tsdgeos | Saviq: sure the rect is enough, but as said also the Y is enough | 09:58 |
| mzanetti | tsdgeos: hmm.. I think its different... you don't realize its a pointer in QML while you do in C++. | 09:58 |
| Saviq | tsdgeos, sure, here y is enough | 09:58 |
| tsdgeos | mzanetti: you don't realize because you have no clue of QML (not you as you but you as general you) | 09:58 |
| mzanetti | tsdgeos: yes... that might be true | 09:58 |
| Saviq | tsdgeos, in people y and height are needed | 09:58 |
| tsdgeos | Saviq: well, it's using peopleGrid.cellHeight so "not really" | 09:59 |
| Saviq | tsdgeos, right | 09:59 |
| mzanetti | anyways, if possible to avoid using delegates I'd vote for that. I won't cut off your head if you do so tho... | 09:59 |
| tsdgeos | ok, i'll pass up the Y then, no need to care about creating new objects and doesn't invalidate the delegates are evil "rule" | 10:03 |
| dednick | does anyone know why when i try load Shell.qml with qmlscene, it segfaults in the Unity plugin export? http://pastebin.ubuntu.com/5592114/ | 10:09 |
| dednick | I expanded out the QT_MOC_EXPORT_PLUGIN def and it seems to be popping creating object on stack. | 10:11 |
| tsdgeos | aaaaaaaaa | 10:11 |
| * tsdgeos shouts at bazar again | 10:11 | |
| tsdgeos | sorry :D | 10:12 |
| sil2100 | didrocks: is there someone already looking at the unity amd64 failure? | 10:12 |
| tsdgeos | dednick: no idea here | 10:12 |
| didrocks | sil2100: I asked Mirv to have a look if he has time, if you have any, that would be appreciated. Did you finish with the powerpc failures? is it transient? | 10:12 |
| tsdgeos | mzanetti: autolanding 228 and 229 are of the same branch+rev? | 10:23 |
| * mzanetti checks | 10:24 | |
| Saviq | mzanetti, btw, any idea why the drop in line coverage http://s-jenkins:8080/job/unity-phablet-autolanding/ ? | 10:25 |
| mzanetti | tsdgeos: indeed. no idea how that happened | 10:26 |
| tsdgeos | oki | 10:27 |
| mzanetti | Saviq: seems we added lots of new lines of code. biggest part caused by: obj-x86_64-linux-gnu.tests.mocks.Ubuntu.Application | 10:29 |
| Saviq | mzanetti, yeah, that's what I thought | 10:30 |
| Saviq | mzanetti, but then should we not ignore tests for coverage? | 10:30 |
| mzanetti | Saviq: yes. this is collected by the c++ coverage run. | 10:30 |
| tsdgeos | mzanetti: can you reapprove https://code.launchpad.net/~aacid/unity/filtergrid_test_findChild/+merge/160034 i needed to merge with trunk for it to pass | 10:30 |
| mzanetti | Saviq: would need to find out how to exclude the mock dirs | 10:30 |
| Saviq | mzanetti, k | 10:31 |
| tsdgeos | oh too late, autolanding already :D | 10:31 |
| tsdgeos | it'll fail now | 10:31 |
| Mirv | sil2100: feel free to start looking at that build failure. this afternoon looks to be becoming busier all the time | 10:32 |
| sil2100 | didrocks: it seems to have been caused by the same little issue we had some time ago - a rebuild should help theoretically, but LP still didn't start rebuilding when I asked him to ;p | 10:33 |
| sil2100 | Mirv: ok ;) | 10:33 |
| MacSlow | Saviq, "Unity.Test" needs a UnityTestQml... were is that meant to be coming from? | 10:33 |
| sil2100 | What is this? It's still | 10:33 |
| sil2100 | I mean, it's still "Start in 1 minute" since 30 minutes | 10:33 |
| Mirv | sil2100: I've seen that often | 10:34 |
| didrocks | sil2100: yeah, in fact, it's "start in 1 minute after the next build finish" | 10:34 |
| didrocks | next/current* | 10:34 |
| sil2100 | Ok, so that's confusing | 10:35 |
| Saviq | MacSlow, Unity.Test is in tests/qmltests/utils/ | 10:35 |
| Saviq | MacSlow, along with the qml file | 10:35 |
| didrocks | Saviq: indeed :) | 10:35 |
| didrocks | sil2100: ^ | 10:35 |
| sil2100 | But some of the timers are anyway broken - on some other LP package build I started I have 'Starts in 1 hour' for an hour already | 10:36 |
| tsdgeos | mzanetti: well, that UT thing is what Saviq used, i just copied it :D | 10:36 |
| sil2100 | Useless..! | 10:36 |
| mzanetti | still don't like it :P | 10:36 |
| tsdgeos | mzanetti: may as well change them all in one go | 10:36 |
| tsdgeos | sure | 10:36 |
| tsdgeos | i'm was jsut being consistent | 10:36 |
| mzanetti | :) | 10:37 |
| Saviq | tsdgeos, mzanetti, if we want more explicit named import, we can, but I'm not sure I want "UnityTest.UnityTestCase" | 10:37 |
| mzanetti | Saviq: whats wrong with Unity.Test? | 10:37 |
| Saviq | mzanetti, it's polluting the global namespace if you don't do named imports | 10:38 |
| Saviq | mzanetti, and it's less obvious where it comes from | 10:38 |
| Saviq | mzanetti, actually we should probably s/UnityTestCase/TestCase/ | 10:38 |
| Saviq | mzanetti, and use UT.TestCase or whatever | 10:38 |
| mzanetti | Saviq: well in that case we would need the named import, yes | 10:39 |
| Saviq | mzanetti, we want named imports to be used more, btw | 10:39 |
| mzanetti | do we... | 10:39 |
| Saviq | I do | 10:39 |
| Saviq | :P | 10:39 |
| mzanetti | well then... | 10:39 |
| Saviq | it's namespaces | 10:39 |
| Saviq | they're useful | 10:39 |
| Saviq | more so than "MyCustomNameToAvoidConflictsTestCase" | 10:40 |
| mzanetti | I know... they're useful - but annoying when overused | 10:40 |
| mzanetti | for example writing QML in Plasma is disgusting | 10:40 |
| Saviq | mzanetti, I'm good with changing the import name, but I'd rather keep the named import in | 10:49 |
| Cimi | tsdgeos, you sure there's a conflict here? https://code.launchpad.net/~unity-team/unity/phablet.test_LensView_new/+merge/159643 | 11:00 |
| Cimi | tsdgeos, just merged trunk and seems fine | 11:00 |
| tsdgeos | Cimi: it's what all the CI stuff complained about | 11:02 |
| === MacSlow is now known as MacSlow|lunch | ||
| tsdgeos | Cimi: is that test testing anything from listview? | 11:19 |
| Cimi | no | 11:20 |
| tsdgeos | so what's the point? :D | 11:21 |
| Cimi | tsdgeos, it's lensview | 11:23 |
| Cimi | tsdgeos, not listview | 11:23 |
| tsdgeos | er | 11:23 |
| tsdgeos | sorry | 11:23 |
| tsdgeos | Cimi: is that test testing anything from lensview? | 11:23 |
| Cimi | tsdgeos, yes, searchquery | 11:23 |
| Cimi | tsdgeos, I don't think there is else to test | 11:23 |
| nic-doffay | Saviq, could you take a look at this branch for me? https://code.launchpad.net/~nicolas-doffay/unity/infographics | 11:24 |
| tsdgeos | Cimi: it searchquery is in lens | 11:24 |
| tsdgeos | and the lens you're using there is the fakeone | 11:24 |
| tsdgeos | onTriggered: lens.searchQuery = "" | 11:24 |
| nic-doffay | In particular the Sequential Animation. The property action for the visibility doesn't work, I'm clueless as to why. http://bazaar.launchpad.net/~nicolas-doffay/unity/infographics/revision/563#Greeter/Dot.qml | 11:24 |
| tsdgeos | may be worth testing | 11:24 |
| tsdgeos | you you're not testing that either | 11:24 |
| Cimi | tsdgeos, I'm testing that | 11:28 |
| Cimi | tsdgeos, the timer gets triggered when lens changes | 11:28 |
| Cimi | look at the test | 11:28 |
| tsdgeos | i know | 11:28 |
| tsdgeos | but the timer takes 2 secs | 11:28 |
| tsdgeos | and the tests does | 11:28 |
| tsdgeos | change + compare | 11:28 |
| tsdgeos | how does that work? | 11:28 |
| tsdgeos | it doesn't | 11:29 |
| Cimi | mmm so I should to tryCompare | 11:29 |
| tsdgeos | no | 11:29 |
| tsdgeos | the thing is | 11:29 |
| tsdgeos | it's working because of something else | 11:29 |
| Cimi | tsdgeos, on triggered changes | 11:29 |
| Cimi | it's istant | 11:29 |
| tsdgeos | Cimi: i put a console.log("EEEE", lens.searchQuery) on that timer triggered | 11:29 |
| tsdgeos | got nothing | 11:29 |
| tsdgeos | why would it be instant if the timer is 2 seconds? | 11:30 |
| Cimi | timer.restart doesn't trigger the timer? | 11:31 |
| tsdgeos | it starts the timer | 11:32 |
| tsdgeos | it will take 2 seconds to trigger | 11:32 |
| Cimi | ok | 11:32 |
| Cimi | tsdgeos, I see | 11:33 |
| tsdgeos | what you want is something like this actually | 11:33 |
| tsdgeos | http://paste.kde.org/~tsdgeos/729968/ | 11:33 |
| Cimi | tsdgeos, searchQuery is per lens | 11:33 |
| tsdgeos | but this fails | 11:33 |
| Cimi | tsdgeos, so if you change lens | 11:33 |
| Cimi | tsdgeos, the new lens has empty searchQuery | 11:33 |
| tsdgeos | then adding the tryCompare to the second one will exercise the timer probbly | 11:33 |
| Cimi | because I previously set searchQuery for another lens | 11:33 |
| tsdgeos | right | 11:34 |
| Cimi | I should ideally go back to the initial lens where I set searchQuery and wait for the timer | 11:34 |
| tsdgeos | yep | 11:34 |
| tsdgeos | that's what my paste does | 11:34 |
| Cimi | just saw your paste :) | 11:34 |
| Cimi | tsdgeos, that? http://paste.ubuntu.com/5592300/ | 11:38 |
| Cimi | might remove the first compare actually | 11:38 |
| tsdgeos | yeah, first compare may not make sense | 11:42 |
| Cimi | ok pushed | 11:43 |
| Saviq | nic-doffay, yeah, looking | 11:46 |
| tsdgeos | Cimi: do we need the "Component.onCompleted: lens = lenses.get(0)" ? | 11:47 |
| Cimi | tsdgeos, not really if we have the init() | 11:47 |
| tsdgeos | Cimi: kill it then :-) | 11:47 |
| Cimi | tsdgeos, was just to set up the lensview | 11:47 |
| Cimi | as it is used elsewhere | 11:48 |
| Saviq | dandrader, now there's a conflict in your close from dash branch | 11:48 |
| tsdgeos | Cimi: but doesn't init do that already? | 11:49 |
| Saviq | nic-doffay, you need to merge trunk in your branch | 11:49 |
| nic-doffay | Will do now Saviq | 11:51 |
| sil2100 | Ah ha\ | 11:54 |
| mzanetti | Saviq: https://code.launchpad.net/~mzanetti/unity/phablet-unload-far-away-images/+merge/160083 | 11:58 |
| Saviq | mzanetti, nice | 11:58 |
| === MacSlow|lunch is now known as MacSlow | ||
| === dednick is now known as dednick|lunch | ||
| === ritz__ is now known as ritz | ||
| mzanetti | Saviq: greyback is currently working on fixing LVWPH, right? (when he's not on vacation) | 12:34 |
| Saviq | mzanetti, yes | 12:34 |
| mzanetti | Saviq: will it be changed so that only visible content is loaded? | 12:35 |
| Saviq | mzanetti, yes, that's the idea | 12:35 |
| mzanetti | ok. thanks. I've commented on my own MP with some thoughts on this | 12:35 |
| mzanetti | Saviq: ^ | 12:35 |
| Saviq | mzanetti, once we get rid of cacheBuffer there, we will unload the whole categories | 12:36 |
| Saviq | mzanetti, but then there's People :/ | 12:36 |
| Saviq | mzanetti, where we have an unlimited list of entries | 12:37 |
| Saviq | in a ListView that really behaves like a Column + Repeater | 12:37 |
| Saviq | because it doesn't know if it's offscreen or not | 12:37 |
| mzanetti | Saviq: yeah... that's exactly what I would call the LVWPH issue | 12:38 |
| === seb128_ is now known as seb128 | ||
| Saviq | mzanetti, tsdgeos, dandrader I'd like you to have a look at https://code.launchpad.net/~saviq/+junk/interface-tests and say what's understood, what is not, do you see anything added there etc. | 12:39 |
| dandrader | Saviq, ok | 12:39 |
| Saviq | mzanetti, tsdgeos, dandrader, it's something of a mine field for the interface tests | 12:39 |
| mzanetti | Saviq: for things like test_type() I'd use _data() methods. If one fails we get better reports which type failed etc | 12:52 |
| mzanetti | Saviq: test_creation() could also test for !creation of uncreatableTypes? | 12:52 |
| Saviq | mzanetti, I don't think we want that, if they're creatable, nothing breaks | 12:53 |
| mzanetti | Saviq: ok | 12:53 |
| Saviq | mzanetti, same for writable | 12:53 |
| Saviq | I initially tested for !writable | 12:53 |
| Saviq | but then thought it doesn't make sense | 12:53 |
| dandrader | Saviq, I didn't get tst_TestInterface.qml:17. Where that TestCase comes from? | 12:54 |
| mzanetti | Saviq: verifyProperty(): there could be properties that are CONSTANT and for thus don't have a NOTIFY signal. If this is intended to be a generic template for such tests it should reagard that | 12:55 |
| mzanetti | dandrader: that's not a testcase but a helper function for other cases | 12:56 |
| Saviq | mzanetti, right | 12:57 |
| Saviq | dandrader, that TestCase comes from the Util module | 12:57 |
| Saviq | dandrader, (that's gonna be moved to the Unity.Test module when we deem it complete) | 12:58 |
| Saviq | dandrader, but for now this is just an example set | 12:58 |
| dandrader | Saviq, because I didn't see it being defined in the Util module itself | 12:59 |
| Saviq | dandrader, qmldir | 12:59 |
| Saviq | dandrader, it's a qml file | 12:59 |
| dandrader | ah | 13:00 |
| mzanetti | oh... I seem to have another diff with different line numbers... sorry for the noise dandrader | 13:00 |
| dandrader | I see it now | 13:00 |
| mzanetti | Saviq: there could be a signalspy attached to verifyProperty() in case its writable | 13:04 |
| Saviq | mzanetti, yeah, I thought of that (and forgot) | 13:04 |
| mzanetti | Saviq: I think the rest looks good. can't think of anything else right now | 13:04 |
| Saviq | mzanetti, but then the actual signal might be delayed | 13:04 |
| Saviq | mzanetti, depending on the implementation | 13:04 |
| mzanetti | Saviq: hmm... it shouldn't | 13:05 |
| Saviq | right, it shouldn't indeed | 13:05 |
| mzanetti | Saviq: hmm. that could be the case indeed... | 13:05 |
| mzanetti | Saviq: but you could use a signalSpy.wait(). more than 5 secs delay is definitely not ok | 13:06 |
| Saviq | mzanetti, yeah probably | 13:06 |
| mzanetti | Saviq: I'm thinking of remote control apps, where a setVolume might need the RTT until it reflects that change | 13:06 |
| Saviq | tsdgeos, gotta run to the tax office, might not make it back for the standup, you're in charge | 13:07 |
| Saviq | mzanetti, it's tests, they won't be ran against an actual service | 13:07 |
| dandrader | Saviq, about naming: Int QtTest "verify" is used for checking that a boolean expression is true, whereas "compare" is used to compare that an actual value matches the expected one. I think we should keep that convention | 13:07 |
| mzanetti | Saviq: right... in that case... I'd add a spy | 13:08 |
| dandrader | so verify() is like an assert() | 13:08 |
| mzanetti | yes | 13:10 |
| tsdgeos | Saviq: actaully i am in a meeting, not sure it'll make it either | 13:12 |
| mzanetti | hehe... MacSlow can't make it either... it'll be a quick one today :) | 13:15 |
| mzanetti | anyways, I'll take care of it | 13:15 |
| dandrader | Saviq, for the sake of readability I would consider splitting verifyProperty into two separate functions (it has too many arguments). One for checking the existence of the property and its type and another for trying to write to it. | 13:15 |
| dandrader | Saviq, or maybe having a read-only and read-and-write versions of it | 13:16 |
| Cimi | dednick|lunch, planning on add anything here? https://code.launchpad.net/~unity-team/unity/phablet.fake-unity-plugin_categories/+merge/159629 | 13:18 |
| === dednick|lunch is now known as dednick | ||
| dednick | Cimi: nope. it's done. Can you check your lensview branch against it? | 13:23 |
| Cimi | will do | 13:23 |
| Cimi | dednick, because it segfaults without | 13:23 |
| dednick | Cimi: eh? what segfaults? | 13:24 |
| Cimi | lensview tests... | 13:24 |
| dednick | ah | 13:24 |
| Cimi | http://s-jenkins:8080/job/unity-phablet-qmluitests/513/console | 13:25 |
| Cimi | doesn't segfault on the pc | 13:25 |
| Cimi | but does on CI | 13:25 |
| tsdgeos | mzanetti: Cimi: guys won't make it to the standup, can you guys drive it? | 13:31 |
| Cimi | tsdgeos, ok | 13:31 |
| Cimi | dednick, nic-doffay you guys joining the standup today? | 13:32 |
| nic-doffay | Yeah one sec. | 13:32 |
| dandrader | dednick, as for the fake ApplicationManager issue when running with qmlscene. you could replace it with a very simple qml/js implementation | 13:45 |
| dandrader | dednick, This is done, if I'm not mistaken, in the Stage test | 13:45 |
| dednick | dandrader: since all the files reference ApplicationManager directly, it might be quite hard to do | 13:47 |
| dednick | dandrader: i dont actually know where the ApplicationManager is created tbh. | 13:47 |
| dandrader | dednick, or you could improve the fake ApplicationManager to make it work with qmlscene | 13:48 |
| dandrader | dednick, tests/mocks/Ubuntu/Application/ApplicationManager.cpp | 13:48 |
| dednick | dednick: yup. thats the idea :) | 13:49 |
| dednick | lol. talking to myseld | 13:49 |
| dandrader | dednick, the code is making some assumptions that seem to not hold when run from qmlscene | 13:49 |
| dednick | dandrader: thats the idea :) got it working, but dont know if it's a good solution or not | 13:49 |
| dandrader | dednick, it should be easy to spot those places | 13:50 |
| dednick | dandrader: thanks. | 13:50 |
| dandrader | in the code | 13:50 |
| ChrisTownsend | mhr3: Hi | 13:50 |
| dandrader | dednick, I actually added comments abou tit | 13:50 |
| dandrader | about it | 13:50 |
| dednick | dandrader: yup, i've seen them :) | 13:50 |
| dandrader | mzanetti, it's in lp:~dandrader/unity/phablet_close_apps_from_dash_WIP | 13:54 |
| dandrader | mzanetti, UnityTestCase::onCalendarLongPressed() is not getting called on the second "press and hold" | 13:54 |
| Saviq | mzanetti, thanks | 13:55 |
| Saviq | dandrader, re verify vs. compare, which function did you have in mind? | 13:55 |
| dandrader | Saviq, all of them, | 13:56 |
| Saviq | dandrader, I'm not sure, it's not just about comparing two values | 13:57 |
| dandrader | Saviq, I mean oll of the verifyFoo(..., actual, expected) | 13:57 |
| dandrader | s/oll/all | 13:57 |
| dandrader | Saviq, hmm, right | 13:58 |
| === dandrader is now known as dandrader|brb | ||
| tsdgeos | mzanetti: Cimi: standup still running? | 14:02 |
| === mmrazik is now known as mmrazik|otp | ||
| mzanetti | tsdgeos: no | 14:03 |
| tsdgeos | oka | 14:03 |
| didrocks | sil2100: seems the build relaunch worked \o/ | 14:08 |
| didrocks | sil2100: camera-app still have the python dep missing, isn't it? | 14:08 |
| sil2100 | didrocks: the thing is, it has the python dep in it :| | 14:09 |
| didrocks | sil2100: do you reproduce in a pbuilder? | 14:09 |
| sil2100 | didrocks: and python2.7 along with stdlib is installed correctly - and I was unable to reproduce it locally here | 14:10 |
| sil2100 | Also, the ap CMakeLists.txt code is the same as in gallery-app and phone-app, and it works fine there | 14:10 |
| tsdgeos | Cimi: why did you make https://code.launchpad.net/~unity-team/unity/phablet.test_LensView_new/+merge/160108 depend on the categories one? | 14:10 |
| sil2100 | Doing some testing on PPA's but it's hm taking a while | 14:10 |
| didrocks | sil2100: you didn't enable a pbuilder on your machine, do you need help for that? | 14:11 |
| sil2100 | didrocks: I use pbuild | 14:11 |
| sil2100 | I think that's almost the same, just with some wrappers around it | 14:12 |
| didrocks | sil2100: ok ;) you did notice some other errors in term of source package name in the media stack as well? | 14:12 |
| Cimi | tsdgeos, because I thought the segfault was due to the missing categories | 14:13 |
| Cimi | tsdgeos, in reality is on the opengl | 14:13 |
| Cimi | tsdgeos, but the categories is still ready for review so I suppose we can review that first so it doesn't have the warning too | 14:14 |
| tsdgeos | sure | 14:14 |
| sil2100 | didrocks: those, ah! Will push a merge now ;) | 14:15 |
| === dandrader|brb is now known as dandrader | ||
| tsdgeos | Cimi: you reviewing https://code.launchpad.net/~unity-team/unity/phablet.fake-unity-plugin_categories/+merge/159629 or want me to take a shot at it? | 14:15 |
| didrocks | thanks sil2100 ;) | 14:15 |
| === mmrazik|otp is now known as mmrazik | ||
| Saviq | dandrader, re: simplyfing verifyType | 14:18 |
| tsdgeos | Cimi: oh wait you proposed it, so you can't review it :D i'll have a look | 14:19 |
| Saviq | dandrader, I'm thinking of creating a custom class that you would create and pass the object and its readable name to | 14:19 |
| Saviq | s/verifyType/verifyProperty/g | 14:19 |
| Saviq | dandrader, and then call verifyProperty() with the reduced set of args | 14:20 |
| dandrader | Saviq, sounds promising | 14:23 |
| Cimi | xD | 14:24 |
| Saviq | nic-doffay, you might want to have a look at lp:~saviq/+junk/interface-tests | 14:25 |
| Saviq | nic-doffay, it's not complete and I will have some changes to it, but should be a good start | 14:25 |
| nic-doffay | Thanks Saviq | 14:26 |
| mzanetti | nic-doffay: so...back from the QA meeting. hit me | 14:29 |
| Cimi | when genericLensView is used? | 14:29 |
| Cimi | apparently it's a property in DashContent | 14:29 |
| Cimi | a string | 14:30 |
| Cimi | oh used as delegate nevermind | 14:31 |
| Cimi | not used currently | 14:31 |
| nic-doffay | mzanetti, check this out quickly http://bazaar.launchpad.net/~nicolas-doffay/unity/infographics_transitions/revision/617#Greeter/Dot.qml | 14:31 |
| nic-doffay | PropertyAction on line 38. | 14:31 |
| nic-doffay | It's supposed to do something very simple. | 14:31 |
| nic-doffay | Here's the branch link if you'd like. https://code.launchpad.net/~nicolas-doffay/unity/infographics_transitions | 14:32 |
| mzanetti | nic-doffay: just to be clear... line 38 does not have a PropertyAction. but I suppose you mean line 39, right? | 14:33 |
| Saviq | nic-doffay, Pause, Action 1, Action 2 << that means Action 1 simply won't have any effect, 'cause it's overwritten by Action 2 straight away | 14:34 |
| mzanetti | right... yeah. Saviq is right | 14:35 |
| mzanetti | of course he is | 14:35 |
| mzanetti | :P | 14:35 |
| nic-doffay | hehe | 14:35 |
| nic-doffay | So a pause or an animation is best then? | 14:35 |
| mzanetti | Saviq: no... actually, its different properties | 14:35 |
| Saviq | is it? | 14:36 |
| sil2100 | didrocks: https://code.launchpad.net/~sil2100/qtubuntu-camera/rename_source/+merge/160125 | 14:36 |
| sil2100 | didrocks: https://code.launchpad.net/~sil2100/qtubuntu-cameraplugin-fake/rename_source/+merge/160128 | 14:36 |
| Saviq | mzanetti, ah... /me hides | 14:36 |
| Saviq | mzanetti, in mtg, can't really focus | 14:37 |
| sil2100 | didrocks: one of them has also adding the bootstrapping commit | 14:37 |
| mzanetti | no worries | 14:37 |
| mzanetti | nic-doffay: how to test this? | 14:37 |
| mzanetti | clicking the infographic like crazy doesn't seem to do anything | 14:38 |
| nic-doffay | You mean nothing is visible mzanetti ? | 14:39 |
| mzanetti | nic-doffay: I think this is not used in the Greeter yet, is it? Anyways, I've run Infographics.qml in qmlscene and its just black | 14:40 |
| nic-doffay | mzanetti, that's why I was after some assistance because the PropertyAction isn't enabling the visibility. | 14:41 |
| mzanetti | nic-doffay: right... got it | 14:41 |
| nic-doffay | mzanetti, would the best be to use an animation or a pause between the action and the next animation? | 14:41 |
| mzanetti | nic-doffay: not really sure I understand the question. but I've a solution to your first issue | 14:42 |
| mzanetti | nic-doffay: sprite.visible == false => all its childs will be invisible too | 14:43 |
| mzanetti | nic-doffay: I've sett visible: true and now clicking somewhere makes the dots start changing appearance | 14:44 |
| nic-doffay | mzanetti, yes. | 14:44 |
| mzanetti | nic-doffay: is that what it should be or am I missing something? | 14:44 |
| nic-doffay | mzanetti, I don't think I explained this well enough from the get go. | 14:44 |
| nic-doffay | What needs to happen is the following: | 14:44 |
| nic-doffay | Everything is invisible. | 14:45 |
| dandrader | mzanetti, did you get to try my branch? I'm still clueless | 14:45 |
| nic-doffay | Open a click (or something else in future) the dot in question becomes visible then changes it's state. | 14:45 |
| mzanetti | dandrader: I branched and compiled already... | 14:45 |
| nic-doffay | *Upon. | 14:45 |
| === alan_g is now known as alan_g|afk | ||
| mzanetti | nic-doffay: so what you want is to change sprite.visible to true upon the click? | 14:48 |
| didrocks | sil2100: thanks! :) | 14:49 |
| nic-doffay | mzanetti, or the dot. I figured it wouldn't make a difference since the sprite is a child of the dot. | 14:49 |
| mzanetti | nic-doffay: well, it does make a difference in a sense that changing a parents visiblity changes ALL the childs too | 14:50 |
| mzanetti | nic-doffay: so if you only want one (or some) dot to become visible, you can't use the sprite | 14:50 |
| nic-doffay | mzanetti, I know. In this case it doesn't matter. | 14:51 |
| nic-doffay | Nothing should be visible. | 14:51 |
| tsdgeos | Saviq: you doing https://code.launchpad.net/~aacid/unity/filtergrid_remove_itemY/+merge/160050 or want me to find someone else? | 14:51 |
| Saviq | tsdgeos, in mtg, try someone else :) | 14:52 |
| mzanetti | nic-doffay: if you move the visble: false from the sprite up to the dot. is it then what it shoul be? | 14:52 |
| tsdgeos | Saviq: okidoki | 14:52 |
| nic-doffay | mzanetti, doh! I just noticed that. | 14:53 |
| tsdgeos | mzanetti: since you oposed to the one using the delegates can you do https://code.launchpad.net/~aacid/unity/filtergrid_remove_itemY/+merge/160050 ? | 14:53 |
| mzanetti | tsdgeos: hehe, sure. | 14:53 |
| mzanetti | but need to checkout dandrader's issue first | 14:53 |
| nic-doffay | mzanetti, sorted, thanks for the extra pair of eyes :) | 14:53 |
| mzanetti | nic-doffay: ok, great | 14:53 |
| mzanetti | dandrader: how do you launch this? | 14:54 |
| mzanetti | I always get Ubuntu.Application 0.1 is not installed | 14:54 |
| dandrader | mzanetti, make testRunningApplicationsGrid | 14:54 |
| mzanetti | dandrader: in qmlscene | 14:55 |
| dandrader | mzanetti, You have to pass the built tests/mocks dir as an import path | 14:55 |
| dandrader | with -I | 14:56 |
| * mzanetti is a bit lost with the too many plugins dirs in tests | 14:56 | |
| mzanetti | did I suggest this? | 14:56 |
| * mzanetti beats himself | 14:56 | |
| dandrader | mzanetti, ask Saviq :) | 14:56 |
| kgunn | Saviq: we ok to switch https://code.launchpad.net/~macslow/unity/phablet-notification-renderer/+merge/155512 to "Needs Review" ?? | 14:57 |
| Cimi | mzanetti, what is good to be tested for genericlensview? | 14:58 |
| Saviq | kgunn, yeah | 14:58 |
| kgunn | MacSlow: ^ | 14:58 |
| Saviq | kgunn, after we have the action tests we can get it in | 14:58 |
| mzanetti | Cimi: I'll come back to you in a bit | 14:58 |
| Cimi | ok thx | 14:58 |
| === alan_g|afk is now known as alan_g | ||
| kgunn | MacSlow: might want to poke loicm on the alpha adoption for the icon | 15:00 |
| kgunn | MacSlow: maybe just a missing capability we might have to add ? | 15:00 |
| MacSlow | kgunn, the question is... is it just a very special use-case for notifications (-> use priv. Component) or could other apps use it too (-> extend UbuntuShape) | 15:02 |
| mzanetti | dandrader: hmm... I might be wrong, but I think this line 144 should be "tryCompareFunction(checkSwitchToActivationModeAfterLongPress, false)" | 15:02 |
| MacSlow | kgunn, I'll email loicm about it | 15:02 |
| mzanetti | dandrader: I can't see any problem about the longpress not happening. it works manually and in the test I too get the debug print "test_enterTerminationMode() long pressed tile!!!" | 15:03 |
| dandrader | mzanetti, on, it should be true. the problem is that onCalendarLongPressed() is not getting called on the second long press | 15:03 |
| dandrader | s/on/no | 15:03 |
| dandrader | mzanetti, the long press happens twice, yes, but on the second time UnityTestCase::onCalendarLongPressed() doens't get called | 15:04 |
| dandrader | mzanetti, and I have no idea why | 15:04 |
| mzanetti | dandrader: so the issue is that this "calendarTile.onPressAndHold.connect(onCalendarLongPressed)" stops working after the first time it gets fired, right? | 15:05 |
| dandrader | mzanetti, yes | 15:05 |
| dandrader | mzanetti, I was using a signalspy before and switched to this approach thinking that the issue might have been in the SignalSpy itself | 15:05 |
| kgunn | MacSlow: exactly, was thinking...it might be a common desired effect | 15:05 |
| dandrader | mzanetti, but both approaches show the same problem | 15:05 |
| kgunn | worth asking | 15:06 |
| mzanetti | dandrader: ok | 15:06 |
| dandrader | mzanetti, also, if I make this connection only before the second long-press, it still doesn't get called | 15:06 |
| MacSlow | kgunn, visual polish-wise I'm +1 for extending UbuntuShapre there | 15:06 |
| Cimi | mzanetti, I only tested isCurrent resetting the searchQuery lp:~unity-team/unity/phablet.test_GenericLensView | 15:07 |
| === _salem is now known as salem_ | ||
| Saviq | kgunn, MacSlow yeah, I wanted to mention that it should be UbuntuShape that "disables" itself if the image has alpha | 15:11 |
| Saviq | MacSlow, can you pick that up with the SDK guys - file a bug against ubuntu-ui-toolkit | 15:11 |
| MacSlow | Saviq, just CC'ing you and kgunn on the email I'm just writing | 15:11 |
| mzanetti | dandrader: first click: long pressed tile!!! RunningApplicationTile_QMLTYPE_7(0x113b470, "runningAppTile Calendar") | 15:12 |
| mzanetti | dandrader: second click: long pressed tile!!! RunningApplicationTile_QMLTYPE_7(0x10f9cf0, "runningAppTile Phone") | 15:12 |
| mzanetti | dandrader: could that be the issue? seems the second click goes to the Phone tile | 15:12 |
| dandrader | ah, stupid dandrader! nothing like a second pair of eyes to spot what the code author overlooked!! | 15:13 |
| dandrader | mzanetti, thanks! | 15:13 |
| mzanetti | dandrader: no problem. you're welcome | 15:13 |
| Saviq | mzanetti, dandrader, types = [plugins, modules, imports]; we need $types, tests for $types, $types for tests, tests for $types for tests | 15:13 |
| Saviq | mzanetti, dandrader, and then differentiate between mocks and utils | 15:13 |
| mzanetti | Saviq: yeah... I guess it does make sense | 15:14 |
| Saviq | mzanetti, dandrader, I'm good with simplifying the tree, but I can't think of a good way | 15:15 |
| tsdgeos | mzanetti: is jenkins syncinc broken or just slow? i.e. i just got an email pointing to https://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/710/console but it 404s | 15:15 |
| mzanetti | Saviq: need to use it for a day to tell if its good or not | 15:15 |
| Saviq | tsdgeos, I _think_ it's slow | 15:15 |
| mzanetti | tsdgeos: I think Saviq has seen this last week too. in that case it was slowness | 15:16 |
| tsdgeos | oki | 15:16 |
| Saviq | but that's new anyway | 15:16 |
| mzanetti | Saviq: tsdgeos: ok. I'll bring it up in QA | 15:16 |
| Saviq | mzanetti, thanks | 15:16 |
| mzanetti | i.e. when mmrazik comes back online :D | 15:16 |
| dandrader | Saviq, well, I don't have any suggestions at the moment myself | 15:16 |
| mhall119 | didrocks: is the pre-validation PPA still being updated? | 15:16 |
| mhall119 | because after a reboot, I no longer have Unity :( | 15:17 |
| kgunn | nic-doffay: ping | 15:17 |
| nic-doffay | kgunn, what's up | 15:17 |
| didrocks | mhall119: remember I told to not using the pre-validation ppa but the certified one? :) | 15:18 |
| didrocks | mhall119: you can end up in a partial upgrade situation in this one, of with a bug that prevent unity starting | 15:18 |
| mhall119 | no, I don't recall that | 15:18 |
| mhall119 | so do I need to purge that ppa? and lose all my wonderful smart scopes? | 15:19 |
| didrocks | mhall119: you should use the certified ppa :) | 15:20 |
| mhall119 | that sounds boring | 15:20 |
| didrocks | https://launchpad.net/~ubuntu-unity/+archive/experimental-certified | 15:20 |
| didrocks | boring == less risky? :) | 15:20 |
| mhall119 | yeah | 15:20 |
| didrocks | however, you need to install ubuntu-unity-experimental-certified | 15:20 |
| didrocks | from it | 15:20 |
| mhall119 | that's a package? | 15:20 |
| didrocks | to force to even downgrade some packages to always have things from that ppa | 15:20 |
| didrocks | yep :) | 15:20 |
| didrocks | you won't live on edge, but you will be safe :) | 15:21 |
| mhall119 | didrocks: is it worth it? Or should I just drop back to default Unity until I can switch to Unity Next? | 15:21 |
| mzanetti | Cimi: your turn. | 15:24 |
| Cimi | mzanetti, :D | 15:24 |
| mhr3 | mhall119, did noone tell you to not do dist-upgrades when they want to remove unity? :) | 15:24 |
| mhr3 | mhall119, but the ppa is clean atm, not sure why you can't run it | 15:25 |
| mzanetti | Cimi: first of all, it doesn't really add much except the thing you've tested already. so that's ok | 15:26 |
| mzanetti | Cimi: I'm thinking if it would be possible to run LVWPH tests on it | 15:26 |
| mhall119 | mhr3: I have unity installed, and running it from the command line doesn't show any errors, it just doesn't show up | 15:27 |
| mzanetti | Cimi: just the exact same tests, but as input use the GenericLensView instead of LVWPH directly | 15:27 |
| mzanetti | Cimi: and/or LensView tests | 15:27 |
| mhr3 | mhall119, tried restarting? maybe driver bug | 15:28 |
| mhall119 | yeah | 15:28 |
| mhr3 | weird then | 15:28 |
| Cimi | mzanetti, mmm | 15:28 |
| Cimi | mzanetti, gerry was working on LVWPH No? | 15:29 |
| mzanetti | Cimi: yeah. its merged already | 15:29 |
| Cimi | ok | 15:29 |
| mzanetti | Cimi: in a first step I would just use that file and exchange the input component with the GenericLensView | 15:29 |
| mzanetti | Cimi: if that should work we can think of a clever way so we don't need to copy/paste all the tests | 15:29 |
| mzanetti | Cimi: if it does not work I think there's not much more to test in there... | 15:30 |
| Cimi | mzanetti, why we need to test lvwph? | 15:32 |
| Cimi | it's already tested | 15:32 |
| tsdgeos | Cimi: what does "we can't import the original unity plugin" mean? | 15:33 |
| mzanetti | Cimi: yeah... just thinking: The genericLensView is basically a LVWPH. it extends it just a little bit. but in that extension it could also break things. So if we could re-use just the same tests as for the LVWPH to make sure it still works in GenericLensView it would be awesome | 15:33 |
| Cimi | tsdgeos, categories are in unity plugin | 15:33 |
| tsdgeos | ah | 15:33 |
| tsdgeos | sure, i didn't say you use the unity plugin | 15:34 |
| tsdgeos | i did say why you're not using the categories code | 15:34 |
| Cimi | tsdgeos, well it uses dee and other things... | 15:34 |
| Cimi | tsdgeos, we can have something simpler | 15:34 |
| tsdgeos | but it's not simpler | 15:34 |
| === racarr_ is now known as racarr | ||
| tsdgeos | your doing lots of code | 15:34 |
| kgunn | mzanetti: ping | 15:35 |
| mzanetti | kgunn: hey | 15:35 |
| tsdgeos | you have your own ::Data implementation | 15:35 |
| tsdgeos | Cimi: who's going to keep that in sync with the real one? | 15:35 |
| Cimi | tsdgeos, just the api, no? | 15:36 |
| Cimi | tsdgeos, dednick wrote that code though, he know better then me :) | 15:36 |
| tsdgeos | ok | 15:36 |
| tsdgeos | dednick: why you not using the real categories code? | 15:36 |
| dednick | tsdgeos: because it's dee. | 15:36 |
| tsdgeos | dednick: so? | 15:37 |
| dednick | we'd have to model it anyway | 15:37 |
| dednick | and keep it in sync | 15:37 |
| === dandrader is now known as dandrader|lunch | ||
| tsdgeos | dednick: well, one thing is creating a fake dee model | 15:37 |
| tsdgeos | the other is building a totally different categories code | 15:37 |
| dednick | tsdgeos: what's creating a fake dee model? | 15:37 |
| mhall119 | didrocks: mhr3: can not open /usr/lib/compiz/libcore.so | 15:39 |
| tsdgeos | dednick: something like what i do in hud_client_query_get_results_model in ./tests/qmltests/plugins/HudClient/fake_libhud_client.cpp | 15:39 |
| tsdgeos | you can always create a local dee model | 15:39 |
| tsdgeos | and use that in Categories | 15:39 |
| tsdgeos | without reimplementing the whole lot of the Categories class | 15:40 |
| dednick | tsdgeos: yeah, but then you're testing the categories, not the qml. | 15:40 |
| tsdgeos | ? | 15:40 |
| tsdgeos | why? | 15:40 |
| mhr3 | mhall119, we don't even have compiz in the ppa, the distro one is used | 15:40 |
| tsdgeos | dednick: why are you not testing the qml if you do that? | 15:41 |
| dednick | tsdgeos: i | 15:41 |
| dednick | sorry | 15:41 |
| dednick | tsdgeos: i guess you're right. i remember thinking about doing that originally, but must have forgot about it. | 15:42 |
| dednick | or found a reason for not | 15:43 |
| tsdgeos | i'd really like if you could to try | 15:43 |
| tsdgeos | the less glue cpp code we have the better | 15:43 |
| Cimi | mzanetti, some works, I'm working on it | 15:44 |
| nic-doffay | mzanetti, another quick probably obvious question for you. I've been trying to centre a child using it's parent's anchors like this: anchors.verticalCenter: parent.Center | 15:45 |
| nic-doffay | It doesn't affect a change though. | 15:46 |
| Cimi | mmm no, lots of fail | 15:46 |
| mzanetti | anchors.verticalCenter: parent.verticalCenter | 15:46 |
| mzanetti | nic-doffay: ^ | 15:46 |
| nic-doffay | mzanetti, sorted :) | 15:46 |
| mzanetti | Cimi: ok... just leave it then | 15:46 |
| mzanetti | Cimi: its a nice theoretical idea but I am well aware in practice this can be tricky | 15:47 |
| sil2100 | didrocks: hm, did you or anyone else redeploy the phone stack by any chance ;)? | 15:47 |
| Cimi | mzanetti, I copied the unitytestcase over | 15:47 |
| Cimi | from lvwph | 15:47 |
| sil2100 | didrocks: since it seems the old one is still being build (failures related extra packages) | 15:47 |
| Cimi | mzanetti, and added property var pageHeader: findChild(genericLensView, "pageHeader") | 15:47 |
| Cimi | property var listView: findChild(genericLensView, "listView") | 15:47 |
| mzanetti | Cimi: and then it starts working? | 15:48 |
| Cimi | not really, some pass some don't | 15:48 |
| ChrisTownsend | mhr3: Hi, I have a question about your review of https://code.launchpad.net/~townsend/libunity/fix-search-hint-localization/+merge/156420 | 15:48 |
| mzanetti | Cimi: ok... just try a little bit to find out why they fail (e.g. its just too different to be tested in the same way vs. oh, its real bugs found already) | 15:49 |
| didrocks | sil2100: it should be, let me try again :) | 15:49 |
| mzanetti | Cimi: but you don't have to make it happen by any means | 15:49 |
| mhr3 | ChrisTownsend, ah thx, see you need to ping people :) | 15:50 |
| ChrisTownsend | mhr3: Yep:) I had actually forgotten about that MP, hence, no ping. | 15:51 |
| Cimi | mzanetti, might be related to the different model used... | 15:54 |
| mhall119 | mhr3: /usr/lib/compiz/libcore.so doesn't exist on my filesystem, and apt-file isn't finding it in any package either | 15:54 |
| mzanetti | Cimi: right.. yeah the input data would need to be the same, yes | 15:54 |
| mhr3 | mhall119, sounds like you broke your config then? | 15:55 |
| mhall119 | :( | 15:56 |
| Cimi | mzanetti, that won't work | 15:56 |
| didrocks | mhall119: indeed, there is no libcore.so… what did you install? | 15:56 |
| Cimi | mzanetti, because GenericLensView uses the categories model | 15:56 |
| mzanetti | Cimi: ah ok... | 15:56 |
| didrocks | mhall119: the core plugin is /usr/lib/libcompiz_core.so normally | 15:57 |
| mzanetti | Cimi: ok then... I'd say its fine what you already have then | 15:57 |
| mhall119 | didrocks: I just ppa-purged the prevalidation PPA, and tried to run Unity | 15:57 |
| didrocks | mhall119: can you pastebin a little bit more of your .xsession-errors? or what you see exactly once starting Unity? | 15:58 |
| kgunn | tsdgeos: ping | 15:59 |
| tsdgeos | kgunn: hi | 15:59 |
| mhall119 | didrocks: in a call atm | 16:07 |
| mhall119 | running gnome-shell | 16:07 |
| mhall119 | but I'll get you that when I'm done | 16:07 |
| === jasoncwarner__ is now known as jasoncwarner | ||
| didrocks | ok | 16:07 |
| ChrisTownsend | mhr3: I assume you see my question in that MP, right? | 16:08 |
| mhr3 | ChrisTownsend, yea, will re in a sec, discussing other stuff now | 16:08 |
| ChrisTownsend | mhr3: Ok, whenever you have a moment. Just wanted to make sure we were on the same page. Thanks! | 16:09 |
| sil2100 | geeh | 16:33 |
| Saviq | dandrader|lunch, I've updated lp:~saviq/+junk/interface-tests | 16:37 |
| sil2100 | didrocks: https://code.launchpad.net/~sil2100/camera-app/modify_python_dep/+merge/160154 <- btw. I think this would be the fix for this issue | 16:41 |
| smspillaz | didrocks: mzanetti: libcompiz_core isn't hte core plugin | 16:42 |
| smspillaz | well ... it is ... kinda. Its just not dlopened )_ | 16:42 |
| mzanetti | smspillaz: huh? | 16:42 |
| smspillaz | usually when compiz complains of a missing core plugin its trying to open some other plugin that has a mismatched core abi | 16:42 |
| sil2100 | I checked in my local PPA and it helps, at least it seems to | 16:42 |
| mzanetti | smspillaz: you sure you meant me? | 16:42 |
| smspillaz | mzanetti: nope, I meant mhall119 :) | 16:43 |
| didrocks | smspillaz: ok, makes sense, I think you need python-minimal | 16:43 |
| smspillaz | now I'm confused | 16:43 |
| didrocks | urgh | 16:43 |
| didrocks | sil2100: ^ | 16:43 |
| smspillaz | XD | 16:43 |
| didrocks | stop talking people, too many s! :p | 16:43 |
| === smspillaz is now known as notsmspillaz | ||
| mzanetti | lol | 16:43 |
| notsmspillaz | does this help ? | 16:43 |
| didrocks | let's do a criss-crossed talk ;) | 16:44 |
| didrocks | thanks notsmspillaz ;) | 16:44 |
| === notsmspillaz is now known as smspillaz | ||
| smspillaz | mhall119: in any case it sounds like you have an abi break somewhere | 16:44 |
| sil2100 | ;) | 16:45 |
| tedg | mpt, So I'm looking at networking, and I'm curious if the icon shouldn't match the precise percentage. i.e < 10 should show up as none, but >75 should show up as full. | 16:45 |
| tedg | mpt, Perhaps we should be a bit optimistic on the icon? | 16:45 |
| tedg | "Ubuntu is so great, it gets strong wireless connections everywhere!" | 16:46 |
| tedg | :-) | 16:46 |
| === dandrader|lunch is now known as dandrader | ||
| Saviq | mzanetti, lp:~saviq/+junk/interface-tests updated for you, too | 16:48 |
| Saviq | mzanetti, the signalspy is TODO still, though - tomorrow | 16:48 |
| Saviq | mzanetti, I might make _singletons and _roles into _data()-driven, too, tomorrow | 16:49 |
| Saviq | not yet sure whether I want to | 16:49 |
| mzanetti | Saviq: ok... can I move this to tomorrow? | 16:50 |
| Saviq | mzanetti, yeah of course | 16:51 |
| mzanetti | Saviq: I still have two reviews in the queue | 16:51 |
| Saviq | mzanetti, you didn't think I meant "I can't be bothered to do the remaining changes today after my EOD, but you go on, review it NOW!", did you | 16:51 |
| mzanetti | hehe... not really | 16:52 |
| sil2100 | didrocks: ping! https://code.launchpad.net/~sil2100/webbrowser-app/bootstrap/+merge/160157 | 16:53 |
| mhall119 | didrocks: mhr3: xsession-errors: http://ubuntuone.com/1C5UYgKDI0UtHynnOOFdrK | 16:53 |
| sil2100 | didrocks: since the Apps stack script was segfaulting because of lack of bootstrapping it seems ;p | 16:53 |
| mhall119 | didrocks: mhr3: unity -vvvv output: http://ubuntuone.com/0b239apKA7DuivwjLfP480 | 16:53 |
| didrocks | sil2100: the version should be 0.20-0ubuntu1 | 16:54 |
| tedg | larsu, charles, is any indicator using on/off switches and GMenu yet? | 16:54 |
| sil2100 | Ooooh | 16:54 |
| sil2100 | Typooo | 16:54 |
| charles | tedg: no, I don't think so | 16:54 |
| mhr3 | mhall119, reset your compiz plugin list? | 16:55 |
| tedg | Hmm, okay. | 16:55 |
| mhall119 | mhr3: how? | 16:55 |
| sil2100 | didrocks: pushed | 16:55 |
| mhr3 | mhall119, dconf | 16:55 |
| mhall119 | mhr3: got a handy-dandy command string I can copy/paste? | 16:55 |
| mhr3 | i dont know the exact key sorry | 16:56 |
| smspillaz | mhall119: compiz (core) - Info: Unity is not supported by your hardware. Enabling software rendering instead (slow). | 16:59 |
| smspillaz | compiz (core) - Info: Unity is not supported by your hardware. Enabling software rendering instead (slow). | 16:59 |
| smspillaz | do a dist upgrade lately ? | 16:59 |
| smspillaz | (don't worry about the "failed to load plugin ... blah blah blah" errors on --debug, its just complaining every time it tries to open something in ~/.compiz-1/plugins and nothing is there | 16:59 |
| smspillaz | mhall119: though curiously, it says its supported later | 17:01 |
| smspillaz | mhall119: in any case, looks like you're not loading unity shell. Have look at the value for gsettings get org.compiz.core:/org/compiz/profiles/unity/core/ active-plugins | 17:02 |
| === alan_g_ is now known as alan_g | ||
| Marlinc | Did Unity really improve that much since 12.10 performance wise? How can it be so fast now? Because it the same codebase as Unity Touch and that that is optimized for phones now? | 17:03 |
| mhall119 | smspillaz: yeah, I did a dist-upgrade | 17:03 |
| mhall119 | it's supported hardware, decent but boring Intel GPU | 17:03 |
| smspillaz | Marlinc: its the same codebase as 12.10 | 17:03 |
| smspillaz | mhall119: just minor changes here and there | 17:03 |
| dednick | Cimi: i've removed the categories in favour of dee models | 17:03 |
| smspillaz | ARGH | 17:04 |
| smspillaz | Marlinc: just minor changes here and there | 17:04 |
| Marlinc | Nice | 17:04 |
| Marlinc | So it really is faster? | 17:04 |
| smspillaz | there are too many "d"'s "m"'s and "s"'s in this channel | 17:04 |
| smspillaz | Marlinc: *shrug* see for yourself | 17:04 |
| bschaefer | smspillaz, haha | 17:04 |
| Marlinc | I'll wait till it is released but I hear the development is very stable | 17:04 |
| mhall119 | smspillaz: should 'core' be in the listof active-plugins? | 17:05 |
| bschaefer | I found someone who has like 4-5 prefix as someone elses name...i kept pinging the wrong person | 17:05 |
| smspillaz | mhall119: yes | 17:05 |
| Cimi | dednick, you sure it works? | 17:05 |
| smspillaz | mhall119: though it should be more than just that | 17:07 |
| nic-doffay | mzanetti, another question. This gives me the results I expect, but it's giving an error on compile. | 17:07 |
| nic-doffay | property real value: parent.x + parent.horizontalCenter | 17:08 |
| smspillaz | mhall119: ah, I knew I had typoed it | 17:09 |
| smspillaz | gsettings get org.compiz.core:/org/compiz/profiles/unity/plugins/core/ active-plugins | 17:09 |
| smspillaz | (note the extra /plugins/) | 17:09 |
| mhall119 | smspillaz: I used dconf-editor to reset it to default, still isn't working though | 17:10 |
| smspillaz | mhall119: resetting it to the default won't work the way you expect | 17:10 |
| mhall119 | smspillaz: ['core', 'ccp', 'composite', 'opengl', 'copytex', 'compiztoolbox', 'decor', 'imgpng', 'place', 'gnomecompat', 'snap', 'grid', 'resize', 'regex', 'animation', 'expo', 'vpswitch', 'move', 'mousepoll', 'session', 'workarounds', 'wall', 'ezoom', 'fade', 'scale'] | 17:10 |
| mhall119 | that's what it currenly has | 17:11 |
| smspillaz | mhall119: append 'unityshell' to the end | 17:11 |
| mzanetti | nic-doffay: what error message? | 17:11 |
| Saviq | nic-doffay, horizontalCenter isn't a real value | 17:11 |
| Saviq | nic-doffay, it's an AnchorLine | 17:11 |
| nic-doffay | Saviq, the thing is it does what I thought it would do. | 17:12 |
| nic-doffay | But I'm getting this error: Unable to assign QString to double (obviously due to what you said) | 17:12 |
| mzanetti | which is the weird thing... | 17:12 |
| mzanetti | QString... even better :D | 17:12 |
| Saviq | nic-doffay, but it shouldn't be used like that ;) | 17:12 |
| Saviq | mzanetti, yeah, JS | 17:12 |
| nic-doffay | Saviq, what should I use instead? | 17:12 |
| mhall119 | smspillaz: that did it! I could kiss you | 17:12 |
| Saviq | nic-doffay, width / 2 | 17:12 |
| smspillaz | mhall119: I feel like that would be a bad idea | 17:12 |
| smspillaz | :p | 17:13 |
| nic-doffay | Saviq, I tried that, assuming it would give me the same result. | 17:13 |
| nic-doffay | It didn't. | 17:13 |
| Saviq | nic-doffay, so it sounds like the approach you're taking now indeed is not giving the right result | 17:13 |
| Saviq | nic-doffay, what's your use case? | 17:14 |
| nic-doffay | Saviq, it's a bit complicated. | 17:14 |
| Saviq | nic-doffay, ok, regardless - if you're looking for a center of something, most often anchors is the way to go | 17:15 |
| Saviq | nic-doffay, but also remember x and y are local values in a hierarchy of objects | 17:16 |
| Saviq | nic-doffay, which means you might need mapToItem / mapFromItem, depending on what you're doing | 17:16 |
| nic-doffay | I'm assuming that converts x & y values from node spaces. | 17:17 |
| nic-doffay | But that's not really what I need. | 17:17 |
| Saviq | nic-doffay, if you expected horizontalCenter to be half of width, then your equation should be: parent.x + (parent.width / 2) | 17:18 |
| * Saviq never remembers which is horizontal and vertical in QML... | 17:19 | |
| nic-doffay | Saviq, yeah that's obvious, but like I said, I attempted that. | 17:19 |
| nic-doffay | I'll have to dig deeper, this doesn't seem like a simple issue to solve. | 17:19 |
| Saviq | nic-doffay, « onValueChanged: console.debug(value) » to print out the value it gets | 17:19 |
| nic-doffay | Cool thanks Saviq that will help a lot. | 17:20 |
| dandrader | Saviq, lp:~saviq/+junk/interface-tests is looking good. | 17:24 |
| Saviq | dandrader, I didn't want for Verifier to subclass TestCase initially... but then nothing was left in there and having a separate Verifier type would just mean you'd have to pass references to it here and there | 17:28 |
| dednick | Cimi: yup, all working | 17:28 |
| dednick | just confirmed all Dash/DashContent & LensView tests working. Plus there is a test scene in Unity/categories which gives a view on all the categories of a lens. | 17:29 |
| dednick | s/categories/category results | 17:29 |
| Saviq | dandrader, so I'll leave it like that for now and if we decide it's bad we'll refactor | 17:30 |
| === boiko_ is now known as boiko | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| mterry | fginther, where is the config for the generic-mediumtests autopilot test stored? It seems to not have ppa:ubuntu-unity/daily-build-next in its sources.list, but it should | 18:40 |
| fginther | mterry, It's just a jenkins job. The ppa hook scripts are passed in from the parent job | 18:44 |
| dobey | hey all, are there instructions for how to run unity-next on ubuntu 13.04 anywhere? (not how to flash to a phone, but how to run stuff locally) | 18:44 |
| fginther | mterry, so it's the upstream job that would need to be configured to use that ppa | 18:44 |
| mterry | fginther, from the CI job then? OK. You were working on adding that PPA to the jobs, right? Any luck? | 18:45 |
| mterry | fginther, also, still getting some 404 errors, like with: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/584/console | 18:46 |
| fginther | mterry, yes that work now, but I had only deployed it for a few projects so far. | 18:46 |
| fginther | mterry, do you know the -ci job? i can be sure it's updated | 18:47 |
| mterry | fginther, http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/708/ | 18:47 |
| mterry | fginther, oh wait | 18:47 |
| mterry | fginther, for the PPA issue? let me get some | 18:47 |
| fginther | mterry, hmm. it may just be easier to re-deploy all the stacks? | 18:48 |
| mterry | fginther, for the PPA issue, I'm looking at the various -app packages like phone-app, gallery-app etc | 18:48 |
| mterry | fginther, for the 404 issue, http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/708/ is the -ci job, from this merge: https://code.launchpad.net/~mterry/unity/phablet-greeter-lightdm/+merge/159846 | 18:48 |
| fginther | mterry, ack. I'll make sure those are deployed and then update the other stacks | 18:49 |
| fginther | mterry, I know that jenkins.qa.ubuntu.com is being excessively slow to publish results. I've tried to find out why, but no luck yet | 18:54 |
| === seb128_ is now known as seb128 | ||
| mhr3 | andyrock, did you restart all the scopes after installing my branch? | 22:21 |
| andyrock | mhr3, yeah i did logout/login too... | 22:22 |
| andyrock | does it work there? | 22:22 |
| mhr3 | yep | 22:22 |
| andyrock | let me try again | 22:23 |
| andyrock | mhr3, nope can't make it work | 22:34 |
| andyrock | i'm doing something wrong | 22:34 |
| andyrock | anyway it's late in Europe ;) | 22:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!