| hatch | rick_h_: are you around? | 01:32 |
|---|---|---|
| rick_h_ | hatch: yea, what's up? | 01:35 |
| hatch | questions about your proposed branch | 01:35 |
| hatch | is that for the little tab to open the store? | 01:35 |
| rick_h_ | hatch: shoot | 01:35 |
| rick_h_ | right | 01:35 |
| rick_h_ | that opens/closes | 01:35 |
| hatch | so why couldn't you have a simple css based tab with a open/close method on the subapp ? | 01:35 |
| hatch | it looks like that's all it's doing but with way more code | 01:36 |
| rick_h_ | hatch: no, because it needs to be state, back button enabled, urlable, etc | 01:36 |
| hatch | well doesn't it only have two states? shown and not? | 01:37 |
| hatch | and it's shown if the other two are closed | 01:37 |
| rick_h_ | hatch: maybe I'm not following. So there's three 'states' to the browser. minmized, fullscreen, or sidebar view. And tomorrow I have ot add a hidden state as well | 01:38 |
| hatch | wana guichat it? | 01:38 |
| rick_h_ | hatch: and I was going to ask to pair up on that because whenever we're on the juju-gui interior views, we have to get the sidebar to go to a hidden state and make sure the back button pops it back to the old state/etc | 01:38 |
| rick_h_ | hatch: can we setup first thing tomorrow? I've only got 20min left here at the coffee shop | 01:38 |
| hatch | oh yeah sure np | 01:39 |
| rick_h_ | hatch: cool, let me konw when you get in tomorrow morning and we can chat as I wanted to grab your time on the hidden state stuff as well. | 01:39 |
| hatch | going out tonight so it definitely wont' be before my usual time (8am) :) | 01:39 |
| rick_h_ | hatch: rgr, have fun | 01:40 |
| hatch | currently 7:40pm | 01:40 |
| rick_h_ | yea, add 2hrs here | 01:40 |
| huwshimi | rick_h_: In fact the minimised sidebar needs to remember its state so that when you open it again it remains the same as it was before you minimised it | 01:43 |
| rick_h_ | huwshimi: right, so it should. It pushes a new state and doesn't change anything like charmids, search input, etc | 01:45 |
| rick_h_ | huwshimi: so when you open it, it reloads. When we get the cache into place it'll avoid that reload as well | 01:45 |
| rick_h_ | huwshimi: but that cache state stuff will be later on. For insance we can cache the interesting charm list and search results from fullscreen/sidebar and such | 01:45 |
| huwshimi | rick_h_: Ah I see your branch actually does that, but shouldn't it just be the real sidebar there that is just moved over? | 01:46 |
| huwshimi | (Although I don't know how that should be handled when you were in full-screen mode) | 01:46 |
| rick_h_ | huwshimi: so yes/no. Yes, but that'll be harder since we'll have this state change but moving it over while this took me 2hrs tonight to add | 01:46 |
| rick_h_ | huwshimi: so going with this for a first pass that does what it should and we can look closer at how to do it with sidebar/fullscreen/animation/etc as a later improvement | 01:47 |
| huwshimi | rick_h_: Yeah, fair enough, that makes sense | 01:47 |
| hatch | rick_h_: btw- 3.10 doesn't make any apreciable difference in speed in the tests :( | 01:48 |
| hatch | appreciable | 01:48 |
| rick_h_ | hatch: :( | 01:49 |
| hatch | yeah....oh well | 01:49 |
| hatch | here's hoping 3.11 | 01:49 |
| hatch | :) | 01:49 |
| * hatch out! | 01:49 | |
| rick_h_ | hatch: we'll just have to fix our crap and make it faster :P | 01:50 |
| hatch | haha | 01:50 |
| * hatch really out! | 01:50 | |
| === matsubara is now known as matsubara-afk | ||
| === rogpeppe1 is now known as rogpeppe | ||
| gary_poster | uh-oh, new version of nodejs.... | 12:08 |
| rick_h_ | lol, run for the hills! | 12:09 |
| gary_poster | :-) | 12:09 |
| gary_poster | ugh, that's a lot of fonts to download. Did you do a comparison on the download size rick_h_ ? I'm fine with that landing, but I may want to negotiate with UX if this is a big increase | 12:10 |
| rick_h_ | gary_poster: yea, I'm looking at it qa'ing it now | 12:11 |
| gary_poster | cool thanks | 12:11 |
| rick_h_ | gary_poster: 482B gzip | 12:11 |
| rick_h_ | gary_poster: well that's the css | 12:11 |
| gary_poster | B? | 12:11 |
| rick_h_ | gary_poster: there we go, 164KB in fonts | 12:11 |
| gary_poster | heh | 12:11 |
| rick_h_ | for the woff font in chrome | 12:12 |
| gary_poster | what was it before do you know? | 12:12 |
| rick_h_ | I'm checking aganist uistage | 12:12 |
| gary_poster | cool | 12:12 |
| rick_h_ | gary_poster: 164? what it says but wtf | 12:13 |
| gary_poster | uh | 12:13 |
| gary_poster | ooooh kay | 12:13 |
| gary_poster | :-) | 12:13 |
| gary_poster | maybe the different weights are done programmatically? | 12:14 |
| rick_h_ | checking in FF. Havnig a hard time buying it | 12:14 |
| gary_poster | thx | 12:14 |
| bac | oops, i forgot to wear my raring t-shirt today. /me changes | 12:19 |
| gary_poster | :-) | 12:19 |
| rick_h_ | gary_poster: oh, so that's the old value. my local instance didn't pick up the change to index.html so it's still loading the old size | 12:20 |
| * bac much better | 12:20 | |
| rick_h_ | gary_poster: so the update isn't much bigger 205KB, but it's 5 files :/ | 12:21 |
| gary_poster | :-/ | 12:21 |
| gary_poster | rick_h_, was how many before? 1? | 12:22 |
| rick_h_ | gary_poster: yea, one request out. Trying to see why it changed to 5. Not used the google webfonts much beyond "I want this font, load" | 12:22 |
| gary_poster | yeah, me too. | 12:22 |
| rick_h_ | ah, css at least seems to have a diff url for each font/weight | 12:23 |
| gary_poster | ah that makes sense | 12:23 |
| rick_h_ | well, but had hoped google would combine. Almost wonder if it'll to all of the ubuntu font in one request but larger size that's cached | 12:24 |
| rick_h_ | gary_poster: ok, so I dropped the Book 300. Not sure if we need that one. Got it down to 4 requests. but yea, I'm not sure how to drop it down more without getting UX to agree to limit fonts combo/italics | 12:32 |
| rick_h_ | http://www.google.com/fonts/#UsePlace:use/Collection:Ubuntu+Mono:400,700,400italic,700italic|Ubuntu:400,500,700,400italic,500italic,700italic | 12:32 |
| gary_poster | rick_h_, ok, thank you. I'd love to have your research saved someplace for later discussion... | 12:33 |
| * gary_poster thinks | 12:33 | |
| gary_poster | jujugui blog? I can put it there or give you posting privs | 12:34 |
| rick_h_ | gary_poster: yea, I'll put this up for review if that's ok and move forward, but file a bug/card to talk with UX on it. | 12:34 |
| gary_poster | ok perfect thanks rick_h_ | 12:34 |
| rick_h_ | gary_poster: sure, I can post something there. | 12:34 |
| gary_poster | your choice rick_h_ . I'll go ahead and give you privs, and then you do whichever you prefer | 12:34 |
| rick_h_ | gary_poster: ok, changed my mind. Did some more tweaking, posted to the blog. Thanks for access | 12:56 |
| rick_h_ | gary_poster: if you get a sec, can you +1 the changes since you've peeked at it and we've had the chat? | 12:57 |
| gary_poster | rick_h_, will do. thanks for blog post and for the further imporvements you talk about | 12:58 |
| gary_poster | rick_h_, LGTM done | 12:59 |
| rick_h_ | ty much | 12:59 |
| hatch | morning! | 13:01 |
| rick_h_ | morn | 13:01 |
| hatch | rick_h_: looks like I made it an hour early | 13:01 |
| hatch | lol | 13:01 |
| * hatch isn't here | 13:01 | |
| rick_h_ | hatch: :P yea, I need a sec to swap out hard drives so come back later | 13:02 |
| * gary_poster looks around, sure he just heard hatch somewhere,,, | 13:02 | |
| hatch | haha | 13:02 |
| rick_h_ | my backup of my backup of my NAS finished after I started work so finally can swap the second drive out | 13:02 |
| * benji sees a hatch-shaped ghost fly through the wall. | 13:02 | |
| * rick_h_ sees some green goo left behind on the wall and hopes he doesn't have to clean it up :) | 13:03 | |
| hatch | do we have any beer connoisseurs? | 13:03 |
| rick_h_ | wine? | 13:03 |
| hatch | http://www.ratebeer.com/beer/westmalle-dubbel/2205/ | 13:04 |
| hatch | taists like cherry chocolate :) | 13:04 |
| === Makyo|out is now known as Makyo | ||
| gary_poster | ugh | 13:55 |
| gary_poster | anyone remember where the pyjuju logs are? | 13:55 |
| gary_poster | on the machines | 13:55 |
| gary_poster | jujugui ^^ | 13:56 |
| bac | gary_poster: /var/lib/juju/units/.../charm.log ? | 13:57 |
| bac | i'm not sure about the exact path but you should be able to follow from /var/lib/juju | 13:57 |
| gary_poster | bac that's it! thank you | 13:58 |
| gary_poster | hatch, probelm in CI is that make distfile is failing with this: http://pastebin.ubuntu.com/5601096/ | 14:01 |
| hatch | oh awesome you were able to log in | 14:01 |
| hatch | looking... | 14:01 |
| gary_poster | I assume we can dupe after a make clean-all | 14:01 |
| hatch | ugh not that again | 14:01 |
| gary_poster | hatch, what is that? | 14:01 |
| hatch | it's a versioning issue | 14:02 |
| hatch | something between imagemagik and spritegen if I remember correctly | 14:03 |
| gary_poster | ah | 14:04 |
| hatch | this happened right after we switched node to 10.x right? | 14:04 |
| gary_poster | so what was the resolution before? (and why is it failing only in Canonistack, I wonder?) | 14:04 |
| gary_poster | yes hatch | 14:04 |
| hatch | can you do a version check on node, npm and the depdendencies so we can compare them to the working local versions | 14:05 |
| hatch | maybe for some reason it's getting a different version? | 14:05 |
| rick_h_ | hatch: ready to chat whenever you are | 14:05 |
| hatch | I can help look through the dependency list if you like as it's pretty large | 14:06 |
| rick_h_ | luca_: so I'm using https://chrome.google.com/webstore/detail/whatfont/jabopobgcpjmedljpbcaablpmlmfcogm?hl=en to check the fonts and only the readme is incorrect. One suggestion would be to launch a private browsing session so that it should break appcache/js cache and view the page? http://uistage.jujucharms.com:8080/bws/fullscreen/precise/cassandra-2/ | 14:08 |
| gary_poster | hatch, http://pastebin.ubuntu.com/5601114/ . Shouldn't the dependencies be the same because of the shrinkwrap? | 14:08 |
| hatch | yeah they should be | 14:09 |
| hatch | but outside of the versioning I don't know what else could cause this error | 14:10 |
| gary_poster | I'm looking to see what version of ImageMagick is on a working precise instance | 14:12 |
| gary_poster | I'm also thereby running make distfile there | 14:13 |
| gary_poster | it may be that we don't see this normally because we don't normally start the charm form a branch, and we are just broken on Precise | 14:13 |
| hatch | ohh that's possible | 14:16 |
| hatch | let me know if you want me to look into it more | 14:17 |
| hatch | rick_h_: guichat? | 14:20 |
| rick_h_ | hatch: sure | 14:20 |
| abentley | rick_h_, alejandraobregon, luca_, jovan2: I've fixed staging, so uistage should also be fixed. | 14:21 |
| rick_h_ | abentley: thanks! what was up? some charm bomb things out? | 14:22 |
| abentley | rick_h_: mongodb and elasticsearch had config-changed errors, but I don't know why because the debug logs are jammed up back to April 19. | 14:23 |
| luca_ | rick_h_: I sent you an email of what I see in my chrome | 14:23 |
| luca_ | rick_h_: the Ubuntu font isn't showing on the headers | 14:23 |
| luca_ | rick_h_: but it shows in the body copy | 14:24 |
| rick_h_ | luca_: k, otp | 14:24 |
| hatch | gary_poster: I'm going to get back on this service details stuff, but before I do that did you want me to look into this error or do you have it? | 14:32 |
| rick_h_ | luca_: after this call can we do a hangout on your machine and try to use screen sharing/etc to walk through checking it out? | 14:32 |
| gary_poster | hatch, problem is in charm making distfile | 14:33 |
| gary_poster | hatch, if you change juju-gui-source=lp:juju-gui | 14:33 |
| gary_poster | then you can dupe | 14:33 |
| gary_poster | hatch, so simplest solution is to just revert the change | 14:34 |
| gary_poster | hatch I'd like to keep teknico's doc changes | 14:34 |
| hatch | yeah reverting to node 8.x is a quick fix - just need to change to the legacy ppa | 14:36 |
| hatch | although that's not going to be available forever | 14:36 |
| rick_h_ | hatch: can you look over that branch please? | 14:36 |
| hatch | sure | 14:36 |
| rick_h_ | hatch: ty much kind sir | 14:36 |
| gary_poster | hatch we can make our own PPA, as I proposed (on call, sorry) | 14:40 |
| hatch | oh right - yeah that should really help solve a lot of our issues....assuming that making our own PPA isn't a huge PITA (I have no idea how that's done) | 14:41 |
| gary_poster | very easy | 14:41 |
| hatch | ohh ok well in that case....maybe I Should do it so I can learn how ;) | 14:48 |
| Makyo | Black magic going on in this dumb zoom code. | 15:05 |
| hatch | rick_h_: after I reviewed your branch I had an idea about the url stuff re minimized, lemme know when you have a second | 15:08 |
| rick_h_ | hatch: yea, I need a few please. Trying to multi task around calls has me in cirlces atm | 15:09 |
| hatch | no rush whenever you have time | 15:09 |
| hatch | but I would really like some starbucks | 15:09 |
| hatch | hmmm..... | 15:09 |
| rick_h_ | hatch: guichat? | 15:13 |
| hatch | sure | 15:13 |
| gary_poster | hatch I'd like to get the charm fixed up ASAP so I can send a juju-core announcement | 15:26 |
| gary_poster | hatch, talk through it when you are available? you may be on another call now | 15:27 |
| hatch | sorry on call with rick_h_ | 15:27 |
| gary_poster | ack | 15:29 |
| gary_poster | bcsaller, hey. I'd like to talk over your current card with you when you get a chance, please | 15:35 |
| hatch | gary_poster: done - did you want to chat? | 15:43 |
| gary_poster | hatch sure | 15:43 |
| gary_poster | guichat | 15:43 |
| bcsaller | gary_poster: I'm around to chat after that | 15:45 |
| gary_poster | thanks bcsaller | 15:45 |
| gary_poster | will ping | 15:45 |
| rick_h_ | luca_: ping, still around? | 15:49 |
| gary_poster | jujugui please update kanban | 15:50 |
| === matsubara-afk is now known as matsubara | ||
| luca_ | rick_h_: I'm available now, are you? | 15:57 |
| gary_poster | jujugui call in 2 | 15:58 |
| luca_ | rick_h_: https://plus.google.com/hangouts/_/cf491220dfb7736cee2876baf29110eeb52f5997 | 15:58 |
| rick_h_ | luca_: one sec | 16:02 |
| luca_ | rick_h_: np | 16:03 |
| hatch | oh yay they dropped off our curbside recycling bin.....just what I always wanted...to pay for things I already do now for free | 16:31 |
| hatch | crap, I pushed to the wrong branch and now lbox thinks that's the one it should push to | 16:43 |
| hatch | anyone run into this before? | 16:43 |
| benji | hatch: I think you can do a bzr push with --remember to the right branch and lbox will use it from then on | 16:47 |
| hatch | ahh ok - I just deleted it and started over | 16:47 |
| hatch | but I'll remember that next time | 16:47 |
| hatch | gary_poster: bcsaller https://codereview.appspot.com/8631048/ plz | 16:48 |
| hatch | rick_h_: is the router approach working? | 16:50 |
| rick_h_ | hatch: no idea yet. Been sidetracked in calls for a bit | 16:51 |
| hatch | gotcha np | 16:51 |
| hatch | oh I gota push this to a trunk branch for it to be able to work | 17:05 |
| hatch | poop | 17:05 |
| hatch | I forgot about that issue | 17:05 |
| rick_h_ | jovan2: looks like luca ran away. Can you verify that the fonts are all ubuntu for you on staging now please? http://uistage.jujucharms.com:8080/bws/sidebar/precise/ceph-7/ | 17:06 |
| jovan2 | rick_h_ will do | 17:07 |
| jovan2 | rick_h_ looking good :) | 17:08 |
| rick_h_ | jovan2: yay! | 17:08 |
| benji | gary_poster: did you ever figure out where pyjuju puts the logs? I'd like to look at the gui charm log output. | 17:11 |
| gary_poster | benji /var/lib/juju/units/.../charm.log. | 17:12 |
| rick_h_ | jovan2: questions posted on https://bugs.launchpad.net/juju-gui/+bug/1172790 | 17:12 |
| _mup_ | Bug #1172790: Lots of empty space below charm details <charmbrowser> <juju-gui:New> <https://launchpad.net/bugs/1172790> | 17:12 |
| jovan2 | rick_h_ will send charm icons to you in a mo... | 17:12 |
| benji | thanks | 17:12 |
| rick_h_ | jovan2: cool, for the featured charms? Those really go to jcastro and arosales | 17:12 |
| rick_h_ | jovan2: I can't get those in | 17:13 |
| jovan2 | rick_h_ yeah but you're being copied in ;) | 17:13 |
| rick_h_ | jovan2: ah ok thanks | 17:13 |
| arosales | rick_h_, I'll work with my team on getting some merge requests for the icons into charms if I don't have time myself today. | 17:29 |
| rick_h_ | arosales: thanks! I'm working on getting manage.jujucharms.com up and to the latest release so we can get them marked as featured and add QA to somem of them as well | 17:29 |
| rick_h_ | arosales: that'll probably be tomorrow | 17:29 |
| arosales | rick_h_, sounds good | 17:31 |
| rick_h_ | oh yay, the browser toggle branch landed on staging as well jovan...who left | 17:32 |
| * rick_h_ hits toggle over and over bwuhahaha | 17:32 | |
| hatch | lol | 17:36 |
| hatch | the node downgrade appears to be deploying properly on EC2 once it completes all the tests I'll land that branch and get our CI back on track | 17:49 |
| hatch | but for now I'm going to grab lunch | 17:50 |
| rick_h_ | does JS regex not support /^\/(charms|unit)/ ? for matching a set? | 17:50 |
| gary_poster | rick_h_, yeah, that would match /charms or /unit or /charmskumquat or /charms/kumquat and so on. :-) | 18:01 |
| rick_h_ | gary_poster: hmm, regex tester fails only matching charms. I'll mess with it some more | 18:01 |
| rick_h_ | I think I'm doomed anyway since I see there's no way to negate that in JS | 18:02 |
| gary_poster | rick_h_, http://pastebin.ubuntu.com/5601849/ wfm <shrug> | 18:03 |
| rick_h_ | gary_poster: cool thanks | 18:03 |
| === matsubara is now known as matsubara-afk | ||
| hatch | rick_h_: oh yeah regex tester has some odd issues, it claims to work with everything js regexy but I've found a number of issues, I usually just try it in the console | 18:41 |
| hatch | gary_poster: I read charmskumquat as charmsqat lol | 18:41 |
| gary_poster | :-) | 18:41 |
| hatch | tests all passed and the branch has been submitted | 18:42 |
| hatch | so CI should be back on track now | 18:43 |
| rick_h_ | hatch: so I've got a working prototype here but I'm worried if this will always hold true: http://paste.mitechie.com/show/949/ | 18:45 |
| hatch | ok looking | 18:46 |
| hatch | why would it always hold true? | 18:46 |
| rick_h_ | I'm worried will :gui: always be in the url? | 18:46 |
| hatch | unless it's on / | 18:47 |
| hatch | at which point that should be false, and then show the browser | 18:47 |
| rick_h_ | hatch: not that i'll always be true, but that this regex will always catch the internal views. Does :gui: every go out of the url? | 18:47 |
| rick_h_ | hatch: ok, cool then | 18:47 |
| hatch | if /service /unit or /charms are in the url, it will be under the :gui: namespace | 18:47 |
| hatch | at least unless something else changes of course | 18:47 |
| hatch | anyone have any idea why `this.get('env')` in serviceList will return an array of undefined values equal to the number of services in the environment? | 19:09 |
| hatch | I'm pretty baffled, the envChange event is being fired with an undefined event facade | 19:12 |
| hatch | O K now I'm bonified confused because it's working now lol | 19:15 |
| rick_h_ | hatch: hmm, login/logout view? | 19:15 |
| hatch | imho it should be hidden and so should the little toggle button | 19:16 |
| hatch | but I don't know how much say I have in that decision :D | 19:16 |
| rick_h_ | hatch: yea, but there's no url to check on those | 19:17 |
| rick_h_ | it's determined mid-request processing it looks like? | 19:17 |
| hatch | { path: '/logout/', callbacks: 'logout'} | 19:17 |
| hatch | ? | 19:17 |
| rick_h_ | hatch: oh hmm, didn't see it in the browser when I did it | 19:17 |
| rick_h_ | and was checknig for login :) | 19:17 |
| hatch | but you are right there is no login | 19:18 |
| hatch | see check_user_credentials | 19:18 |
| hatch | method | 19:18 |
| hatch | so we might need manual fn calls in there | 19:19 |
| hatch | darn! | 19:19 |
| rick_h_ | hatch: checking, so logout I do have a url. And logout shows the login at the same time without another request | 19:19 |
| rick_h_ | so that just works as is, check for that in the url as well | 19:20 |
| rick_h_ | can you get to just login? there's no url for it | 19:20 |
| gary_poster | benji, would 40 minutes from now work for you? | 19:20 |
| hatch | if there are no credentials then it shows the login page | 19:20 |
| hatch | it should redirect to /login | 19:20 |
| hatch | I've been meaning to bring that up | 19:20 |
| * hatch creates card | 19:20 | |
| hatch | rick_h_: in the meantime you'll need to call the callback manually in the check_user_credentials method | 19:20 |
| rick_h_ | hatch: does it auto log you in though? I'm logging myself out and then I see a login screen. When I reload, I get the main site | 19:21 |
| rick_h_ | hatch: k, looking for that method | 19:21 |
| hatch | yeah that's in the config.js | 19:21 |
| hatch | config-debug.js | 19:21 |
| hatch | has user: and password: properties | 19:21 |
| hatch | set those to undefined to land on a login page | 19:21 |
| rick_h_ | hmm, but if I check user credentials it shows the login. I don't want to check it again | 19:21 |
| rick_h_ | ah, but it cancels any other routes so I should be good | 19:22 |
| rick_h_ | it'll show the login and kill dispatch so never hit my stuff | 19:22 |
| hatch | you want to put your callback call on line 682, right after this.show_login(); | 19:23 |
| hatch | that way if there are no credentials and it's showing the login then hide ths browser | 19:23 |
| hatch | at least it makes sense in my head | 19:24 |
| hatch | which has been wrong from time to time ;) | 19:24 |
| rick_h_ | it seems dirty and another edge case for me to cover. Shouldn't subapps get killed on the login? | 19:24 |
| rick_h_ | it seems crazy to need to call another method to force hidden in another corner case. | 19:24 |
| hatch | well your routes shouldn't be called if there are no credentials | 19:25 |
| hatch | so.... | 19:25 |
| hatch | yeah | 19:25 |
| hatch | ignore me | 19:25 |
| rick_h_ | right, that's what I was thinking | 19:25 |
| rick_h_ | cool, I'm happier now | 19:26 |
| hatch | and I feel dumber | 19:26 |
| hatch | THANKS!!! | 19:26 |
| hatch | haha | 19:26 |
| rick_h_ | :P | 19:26 |
| benji | gary_poster: my internet connection is back from its brief hiatus | 19:31 |
| gary_poster | hey benji cool. I asked earlier when I didn't realize that you were gone of we could postpone a half hour from the usual time. that work? | 19:32 |
| gary_poster | *if | 19:32 |
| benji | gary_poster: yep, that's fine | 19:32 |
| gary_poster | ok thanks benji | 19:32 |
| rick_h_ | hatch: https://codereview.appspot.com/8937046 | 19:47 |
| gary_poster | bac I lost you | 19:47 |
| hatch | rick_h_: cool, does it work? ;) | 19:49 |
| rick_h_ | hatch: :) | 19:49 |
| rick_h_ | hatch: seems to work fine. Do wish multi-dispatch would run away as it hits it 10 times but works | 19:49 |
| hatch | lol.....working on it | 19:50 |
| rick_h_ | hatch: if you get a sec for review appreciate it. | 19:50 |
| hatch | yup doing it right now | 19:52 |
| rick_h_ | hatch: ty | 19:52 |
| rick_h_ | gary_poster: did you email luca over the landscape stuff from https://bugs.launchpad.net/juju-gui/+bug/1171531 ? | 19:55 |
| _mup_ | Bug #1171531: Zoom control <charmbrowser> <juju-gui:New> <https://launchpad.net/bugs/1171531> | 19:55 |
| gary_poster | rick_h_, I talked to jovan about it. He said to put the zoom control in the center. sorry for not updating bug. would you mind? :-P | 19:56 |
| rick_h_ | not at all, will add note about moving zoom control to the center then. Thanks | 19:57 |
| hatch | rick_h_: review done | 20:00 |
| rick_h_ | hatch: thanks, looking. | 20:01 |
| === matsubara-afk is now known as matsubara | ||
| Makyo | jujugui: can I get one more review on https://codereview.appspot.com/8961044/ to help clear a card? | 20:12 |
| * hatch will do it | 20:12 | |
| Makyo | \o/ | 20:13 |
| hatch | Makyo: done like dinnah | 20:16 |
| gary_poster | ok benji, sorry, joining | 20:20 |
| bac | hi hatch can i chat with you for a bit? | 20:20 |
| * benji looks up the URL | 20:20 | |
| hatch | bac: sure, couple mins, just need to get the dogs in | 20:22 |
| bac | ok | 20:22 |
| hatch | ok guichat | 20:24 |
| hatch | ^ bac | 20:25 |
| hatch | gary_poster: bac: here was the tiny RTE I was talking about http://mindmup.github.io/bootstrap-wysiwyg/ | 21:07 |
| hatch | I/we could likely convert that to YUI pretty easily | 21:08 |
| hatch | gary_poster: bac: There is also https://github.com/smugmug/yui-gallery/tree/master/src/sm-editor which is based on Y.Editor | 21:10 |
| hatch | demo if it http://jsbin.com/abaqiq/2 | 21:11 |
| rick_h_ | hatch: some replies sent your way. Will work on adding a functional test. Was having a hard time finding a good home for it/how to get at it but working on it | 21:22 |
| hatch | thanks - yeah functional tests are hard but I wanted to avoid the case where we release the app and noone noticed that breaking :) | 21:22 |
| rick_h_ | hatch: no, you're right. I did look around but test_app seemed bare and tried to sneak by :P | 21:23 |
| hatch | haha - nobody lets me sneak by so I'm just passing on the love rofl | 21:23 |
| rick_h_ | hatch: ok, actually found an easy way to test yay. So code going through lbox now :) | 21:34 |
| hatch | awesome | 21:35 |
| hatch | ! | 21:35 |
| rick_h_ | hatch: if you can get a second to look over before EOD so I can get it through that'd be great please | 21:35 |
| hatch | yep as soon as it updates I'll do it | 21:35 |
| rick_h_ | doh, linter fail | 21:35 |
| rick_h_ | thanks, clears the way for me to work on making it the default after this :) | 21:36 |
| hatch | haha - I have started to lint and make all tests pass before final commit so I don't get the last commit being "f'n linter" ;) | 21:37 |
| hatch | rick_h_: you're gona be irritated but you forgot to destroy app in your new test :) | 21:42 |
| rick_h_ | hatch: lol, well crap. I was trying to use makeApp at first which auto destroyed | 21:42 |
| rick_h_ | but it's nto in this closure so swapped out but missed that my bad | 21:42 |
| rick_h_ | oh wtf, the tests before it app.destroy first? | 21:43 |
| hatch | afterEach has an app.destroy() | 21:44 |
| rick_h_ | oh hatch there's an ap.destroy in afterEach | 21:44 |
| hatch | but you created it with var | 21:44 |
| hatch | :) | 21:44 |
| rick_h_ | ok, I can remove that :P | 21:44 |
| hatch | haha - it's been LGTM'd | 21:44 |
| hatch | charmstore is sure gona look good once it has some icons with some color | 21:45 |
| hatch | like in the mockups | 21:45 |
| rick_h_ | hatch: yea, they got some 10 icons in today but not through injest yet | 21:45 |
| rick_h_ | hopefully tomorrow they'll start to show up | 21:45 |
| rick_h_ | thanks for helping me out with this one today hatch | 21:45 |
| hatch | anytime | 21:46 |
| hatch | thanks for the implementation :) | 21:46 |
| rick_h_ | ah crap, test-prod failure now? wtf | 21:58 |
| hatch | can anyone tell me why charm provides and requires would be undefined in a charm = db.charms.add() | 22:31 |
| hatch | ahh nm got it....newly introduced byg | 22:45 |
| hatch | bug | 22:45 |
| hatch | arg so close to finishing this | 22:59 |
| gary_poster | hey hatch. we explicitly don't want a RTE AFAIK, but I imagine bac already said that to you. | 23:53 |
| gary_poster | Is Rick's recent branch supposed to fix the CI failure? | 23:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!