* StevenK stabs BulkUpdate | 01:54 | |
StevenK | wgrant: http://pastebin.ubuntu.com/5603182/ First bit is the query I wrote, second bit is my attempt to convert it into BulkUpdate, third bit is what BulkUpdate thinks of it | 02:49 |
---|---|---|
mwhudson | StevenK: what do you expect dict([PreviewDiff.merge_proposal_id, BranchMergeProposal.id]) to do? | 02:51 |
StevenK | I was wanting that bit to expand to the SET bit in the query, but I'm not clear on what BulkUpdate actually wants there. | 02:52 |
wgrant | That's not valid dict syntax | 02:52 |
wgrant | dict() takes a sequence of pairs | 02:52 |
wgrant | IIRC that wants to be a mapping of columns to expressions | 02:52 |
wgrant | So dict([(PreviewDiff.merge_proposal_id, BranchMergeProposal.id)]), perhaps | 02:53 |
wgrant | But it's been a while since I wrote BulkUpdate | 02:53 |
wgrant | StevenK: And you might need to use values= to include BMP | 02:57 |
wgrant | And you want table=PreviewDiff, not table=BranchMergeProposal | 02:57 |
StevenK | wgrant: Yeah, I've just fixed it | 02:57 |
StevenK | Worked those bits out myself | 02:58 |
StevenK | But thanks | 02:58 |
StevenK | The query it's generating looks good | 02:58 |
wgrant | StevenK: r16467 | 02:58 |
wgrant | This is similar to my BFJ flattening stuff | 02:59 |
wgrant | But if you've already got it working.. | 02:59 |
StevenK | I have a permission error, but what it's excuting from the query log looks great | 02:59 |
StevenK | wgrant: So I think I might land the YUI2 destruction branch | 04:09 |
wgrant | StevenK: Sounds good | 04:10 |
StevenK | wgrant: So my garbo job works, now you want me to keep going and drop BMP.merge_diff before proposing? | 04:18 |
wgrant | StevenK: There's a sequence of branches that end with the dropping of BMP.merge_diff. I wouldn't land any of them until you've got the last branch working, so you don't land anything that won't actually work. | 04:19 |
wgrant | StevenK: https://lpstats.canonical.com/graphs/CodeImports/20130426/20130427/ is what all that codeimport spam was about, btw | 05:11 |
StevenK | Hmmm | 06:43 |
StevenK | How did this code ever work | 06:43 |
nigelb | StevenK: Second phase of debugging. | 07:06 |
=== yofel_ is now known as yofel | ||
=== olli__ is now known as olli | ||
=== wedgwood_away is now known as wedgwood | ||
=== gary_poster is now known as gary_poster|away | ||
=== gary_poster|away is now known as gary_poster | ||
=== gary_poster is now known as gary_poster|away | ||
=== gary_poster|away is now known as gary_poster | ||
=== wedgwood is now known as wedgwood_away |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!