/srv/irclogs.ubuntu.com/2013/05/08/#launchpad-dev.txt

StevenKwgrant: The removal of self.log(self._output.output) is needed?00:46
StevenK(From lp-dev-utils)00:46
wgrantStevenK: I'm not sure what the real fix is, I just quickly deleted the line in the traceback to get ec2 to work.00:58
StevenKI have another change to make, so I'll ignore that removal for now01:00
StevenK[2013-05-08 00:58:14,724: INFO/PoolWorker-3] Job resulted in OOPS: OOPS-f707f73e2b097961847648306d15565401:06
StevenKInternalError: current transaction is aborted, commands ignored until end of transaction block01:06
wgrantThere was an earlier OOPS01:07
StevenKNot that I can see in the log01:07
StevenKwgrant: So, unscan-branch or delete and repush?01:11
=== tasdomas is now known as tasdomas_afk
=== tasdomas_afk is now known as tasdomas
wgrantflacoste: Are you using Chromium to get those librarian 404s?01:49
=== tasdomas is now known as tasdomas_afk
wgrantStevenK: What's the new DB MP?02:23
StevenKI had to delete them because sync-pipeline completly lost its mind02:26
StevenKwgrant: Right, all six MPs are up, all with diffs.02:28
wgrantStevenK: Only six? I'm disappointed.02:28
wgrantWill look soon02:28
wgrantStevenK: 350+ def findBranchMergeProposalIDs(self):03:15
wgrant351+ return self.store.find(03:15
wgrant352+ (BranchMergeProposal.id),03:15
wgrantThat doesn't do what you think it does03:15
wgrant() is an empty tuple, but (foo) is just foo03:15
StevenKwgrant: The garbo job actually works, though ...03:36
wgrantStevenK: But the code still doesn't mean what you intended, so probably best to drop the parens.03:38
StevenKwgrant: Right.03:38
StevenKwgrant: Killing yui_3.3.0.zip from sourcedeps, should yui_3.5.1.zip also meet its demise?03:39
wgrantStevenK: Might as well03:39
StevenKwgrant: Fix for http://pastebin.ubuntu.com/5643581/ landing/landed.03:46
StevenKwgrant: Your comment about removing merge_proposal_id is on the right MP?03:55
StevenKOh03:58
StevenKWhy?03:58
wgrantStevenK: Why not?03:59
wgrantIt was added just for garbo03:59
wgrantAnd now garbo is gone03:59
StevenKIt was not.03:59
wgrantWasn't it?03:59
StevenKYou should read switch-bmp-to-previewdiff-merge_proposal carefully.03:59
wgrantAh, so you're leaving it for a reference that only appears in a later branch?04:00
StevenKPretty much04:00
wgrantThat's OK, then.04:00
StevenKWe really can't use it in the code until it's populated04:00
StevenK371 + @property04:00
StevenK372 def branch_merge_proposal(self):04:00
StevenKWhy does this still exist?04:00
StevenKwgrant: Because it's exported :-(04:01
wgrantStevenK: Hm, can you just call the property that, then?04:01
wgrantRather than having merge_proposal separate04:01
wgrantJust call it branch_merge_proposal04:01
StevenKSo the merge_diff madness continues04:02
wgrantHm?04:02
StevenKmerge_proposal_id / branch_merge_proposal probably isn't going to make you like me04:02
wgrantNo, that's illegal.04:03
StevenKWhich means we have branch_merge_proposal = Int(name='merge_proposal')04:03
wgrantOr you rename the DB column04:03
wgrantThis sort of thing is why you don't land DB patches early. Makes them easy to revise in context :)04:03
* StevenK twitches at having to rename it in six branches04:04
StevenKWell, five04:04
wgrantStevenK: Also, have you considered pruning?04:17
wgrantUntil we have pruning, bmp.preview_diffs may grow without bound04:17
StevenKI was thinking about that yesterday, but I'm not sure about the prune condition, since PreviewDiff.branch_merge_proposal is NOT NULL04:18
wgrantWe want to prune unreferenced ones. At the moment that probably just means everything except the latest.04:18
wgrantBut that will change once we start tying comments to a particular diff version04:18
StevenKwgrant: Compound index?05:38
wgrantStevenK: So we can efficiently answer "what is the current diff for this merge proposal?"05:42
StevenKwgrant: Sure, I'm not sure what that index looks like, and if we need the current index in the patch05:44
wgrantStevenK: (branch_merge_proposal, date_created)05:44
wgrant(branch_merge_proposal) lets me quickly identify the diffs for the merge proposal, but without the additional sort of date_created I'd have to examine all of them to find the newest.05:45
stubwgrant: how many diffs are you expecting to be attached to a MP?05:58
stubIf it is normally one or two and we never have thousands, I don't think the extra maintenance of the index is worth it.05:59
wgrantstub: date_created will never change, and the index will always be appended to, so is that significant?06:00
wgrantIt should rarely be more than a dozen, but in pathological cases it may be.06:01
wgrantAnd I don't see the expense of the additional index column as being particularly significant.06:01
stubAn extra index to keep hot, extra writes on insert, fatter index vs thin index and extra row loading...06:02
stubAnd the overhead of all the extra typing in the db patch ;)06:02
wgrantIt's not an extra index, just a wider one.06:02
stuboh right, new column.06:03
wgrantWe need one with branch_merge_proposal at the start either way06:03
stubyup. I'm not fussed one way or t'other.06:04
=== bigjools_ is now known as bigjools
wgrantIf it were a larger table then I would be concerned about the wider index, but I don't think it's an issue here.06:05
=== tasdomas_afk is now known as tasdomas
=== jamesh_ is now known as jamesh
=== broder_ is now known as broder
wgrantStevenK: https://code.launchpad.net/~wgrant/launchpad/dont-overrideFromAncestry/+merge/16293306:29
StevenKwgrant: r=me06:42
wgrantStevenK: Thanks.06:42
StevenKwgrant: Glance at the six again?06:55
=== tasdomas is now known as tasdomas_afk
=== _mup__ is now known as _mup_
=== jelmer_ is now known as jelmer
=== tasdomas_afk is now known as tasdomas
=== tasdomas is now known as tasdomas_afk
=== tasdomas_afk is now known as tasdomas
=== tasdomas is now known as tasdomas_afk
=== tasdomas_afk is now known as tasdomas
=== wedgwoodz is now known as wedgwood_away
=== tasdomas is now known as tasdomas_afk
=== wedgwood_away is now known as wedgwood
=== tasdomas_afk is now known as tasdomas
=== tasdomas is now known as tasdomas_afk
=== wedgwood is now known as wedgwood_away
StevenKwgrant: When you're done with <redacted>, can you peer at the six MPs again?23:42
wgrantStevenK: Sure23:45

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!