| hazmat | goyaml seems to have some issues with go 1.1 http://paste.ubuntu.com/5663122/ | 01:45 |
|---|---|---|
| hazmat | argh... nevermind some sort of GOPATH wierdness was picking up a GOROOT value | 01:52 |
| hazmat | re goyaml | 01:52 |
| === racedo` is now known as racedo | ||
| rogpeppe | yay! internet is finally back on! | 08:14 |
| teknico | they don't want to delay the propagation of Go 1.1 ;-) | 08:18 |
| mattyw | rogpeppe, how much experience do you have running benchmarks in gocheck? | 09:46 |
| rogpeppe | mattyw: i've done a few | 09:47 |
| mattyw | rogpeppe, I've got two packages with benchmarks in them, but I don't seem to be able to run all of them at once (in one command) | 09:48 |
| rogpeppe | mattyw: go test -gocheck.b should do it | 09:48 |
| mattyw | rogpeppe, it doesn't seem to, although it's just occured to me that it might be my tree that's causing it. I've got benchmarks in juju/ws/ws_test.go and juju/api/api_test.go but no tests in juju | 09:50 |
| rogpeppe | mattyw: what directory are you running the tests in? | 09:50 |
| mattyw | rogpeppe, well I have to be in juju/api or juju/ws as there aren't any tests higher up | 09:51 |
| rogpeppe | mattyw: what do you see if you do go test -gocheck.b -gocheck.v ? | 09:51 |
| mattyw | rogpeppe, it's only running the api test if I'm in the api package when I run the command | 09:52 |
| mattyw | rogpeppe, I guess this sort of makes sense | 09:53 |
| rogpeppe | mattyw: go test only tests the package in the current directory by default | 09:55 |
| rogpeppe | mattyw: you can give it a list of packages if you want | 09:55 |
| rogpeppe | mattyw: or a wildcard (see "go help packages" for some docs on that) | 09:55 |
| mattyw | rogpeppe, but if I'm supplying -gocheck.b I need to do that from within a package wich has a gocheck test it looks like | 09:57 |
| rogpeppe | mattyw: yes | 09:57 |
| rogpeppe | mattyw: most packages do, but not quite all unfortunately | 09:57 |
| mattyw | rogpeppe, so if I wanted to run all the benchmarks in my codebase by doing go test -gocheck.b launchpad.net/thing/foo/... launchpad.net/thing/bar/... I need to have a gocheck package in my current dir? | 09:59 |
| rogpeppe | mattyw: no | 09:59 |
| mattyw | rogpeppe, (jet lag is probably causing me to not be making much sense) | 09:59 |
| rogpeppe | mattyw: just in the packages that you're testing | 09:59 |
| rogpeppe | mattyw: you can see which packages match by using go list | 09:59 |
| mattyw | rogpeppe, would a quick hangout be possible? might be quicker for you to see what I'm talking about | 10:00 |
| rogpeppe | mattyw: sure | 10:00 |
| mattyw | rogpeppe, thanks very much https://plus.google.com/hangouts/_/6fabced08041ffc4a35b6ebdd200962be8e826ba | 10:00 |
| === wedgwood_away is now known as wedgwood | ||
| === marcoceppi_ is now known as marcoceppi | ||
| === meetingology` is now known as meetingology | ||
| === _mup__ is now known as _mup_ | ||
| hazmat | rogpeppe2, the provider port opening for the api is generic or is it per provider? | 14:54 |
| rogpeppe2 | hazmat: in the api, it's generic (it just sets the flag in the state). the firewaller agent is responsible for acting on that state change, and each provider implements port opening privately. | 14:55 |
| hazmat | rogpeppe2, i've been seeing some issues with client connectivity to the api in openstack environments, just trying to debug.. it works on localhost but remotely it generates an http 400 server error | 14:56 |
| hazmat | i suspect its something to do with the origin header on the websocket | 14:57 |
| hazmat | works ootb on ec2 | 14:57 |
| rogpeppe2 | hazmat: hmm odd. | 14:57 |
| rogpeppe2 | hazmat: could it be something to do with limited public ip address space? | 14:58 |
| hazmat | rogpeppe2, its happened on canonistack and hpcloud | 14:59 |
| rogpeppe2 | hazmat: you're getting a 400 server error from the API? or from the service you've deployed? | 14:59 |
| hazmat | in the canonistack case the user had sshuttle setup as transparent proxy | 14:59 |
| hazmat | rogpeppe2, api server | 14:59 |
| rogpeppe2 | hazmat: through the GUI or direct? | 15:00 |
| hazmat | rogpeppe2, direct | 15:00 |
| rogpeppe2 | hazmat: what's the full body of the error? | 15:00 |
| hazmat | rogpeppe2, nothing in the juju logs, its silent.. looks like pre login nothing gets logged there | 15:01 |
| rogpeppe2 | hazmat: i meant of the 400 error. | 15:01 |
| hazmat | rogpeppe2, empty body | 15:01 |
| rogpeppe2 | hazmat: i'm wondering if the error is coming from the API server or something else | 15:01 |
| rogpeppe2 | hazmat: and "400 server error" is the whole text of the error? | 15:01 |
| * hazmat setups a reproduce csae | 15:02 | |
| hazmat | rogpeppe2, so this is out of the box on hpcloud.. generates a 403.. http://pastebin.ubuntu.com/5664742/ | 15:06 |
| rogpeppe2 | hazmat: ah, "forbidden". hmm. | 15:06 |
| hazmat | rogpeppe2, if i setup the client on the localhost there i can get it to work | 15:07 |
| rogpeppe2 | hazmat: is that a public ip address i could try ? | 15:07 |
| hazmat | rogpeppe2, that is a public ip address | 15:07 |
| hazmat | rogpeppe2, i'll import your key | 15:07 |
| hazmat | rogpeppe2, you can ssh into the instance as well / u=ubuntu | 15:08 |
| hazmat | rogpeppe2, the agent logs are useless since there isn't anything logged till post login afaics | 15:10 |
| hazmat | rogpeppe2, i suspect its something in go.net websocket lib that's barfing | 15:10 |
| rogpeppe2 | hazmat: it may be. i'm just writing a little bit of test code. | 15:10 |
| rogpeppe2 | hazmat: i'm wondering if it's something to do with the "localhost" in this line: | 15:11 |
| rogpeppe2 | cfg, err := websocket.NewConfig("wss://"+info.Addrs[0]+"/", "http://localhost/") | 15:11 |
| hazmat | rogpeppe2, the odd bit, is that there is no '403' in that package | 15:11 |
| hazmat | hmm | 15:11 |
| hazmat | yes | 15:11 |
| hazmat | that might be it | 15:11 |
| rogpeppe2 | but no | 15:12 |
| hazmat | but we use the address that the instance thinks it has so ... | 15:12 |
| rogpeppe2 | hazmat: that's the client-side code | 15:12 |
| hazmat | oh, not likely relevant then | 15:13 |
| hazmat | rogpeppe2, got it... | 15:13 |
| hazmat | its the go.net websocket server.go around the handshake | 15:13 |
| hazmat | line 41-43 | 15:14 |
| rogpeppe2 | hazmat: hmm, my line 41 says "config.Protocol = nil" | 15:15 |
| hazmat | rogpeppe2, revision 49? of go.net | 15:16 |
| hazmat | rogpeppe2, of websocket/server.go ? | 15:17 |
| rogpeppe2 | hazmat: ah, i'm on r48 | 15:17 |
| rogpeppe2 | hazmat: it's changed quite a bi | 15:18 |
| rogpeppe2 | t | 15:18 |
| rogpeppe2 | pity it discards the actual text of the error | 15:19 |
| hazmat | rogpeppe2, so it looks like its the checkOrigin func of the handler | 15:20 |
| hazmat | but that's a guess | 15:21 |
| rogpeppe2 | hazmat: yes it looks like that | 15:22 |
| hazmat | rogpeppe2, 2013/05/14 15:01:32 INFO environs/openstack: closed ports in security group juju-hp-0: [tcp:17070] | 15:22 |
| hazmat | probably not relevant | 15:22 |
| hazmat | the env group port is still open | 15:23 |
| hazmat | that was juju correcting my manual changes | 15:23 |
| rogpeppe2 | hazmat: hmm, it might have been rev 49 that broke it - it's a recent change with some relevant looking stuff | 15:25 |
| rogpeppe2 | hazmat: are you using the release version of juju? | 15:27 |
| hazmat | rogpeppe2, no.. there are other issues with that | 15:27 |
| rogpeppe2 | hazmat: can you try with r48 of websocket? | 15:27 |
| hazmat | rogpeppe2, i just see it re-jigging the origin parsing | 15:27 |
| hazmat | rogpeppe2, but as per the content dump its present in the request | 15:28 |
| hazmat | rogpeppe2, i'll add some debugging prints and redeploy it | 15:28 |
| rogpeppe2 | hazmat: it looks like you'd get that result if the origin couldn't be parsed | 15:29 |
| hazmat | rogpeppe2, hmm that could be it | 15:29 |
| hazmat | rogpeppe2, yeah its the port number there | 15:29 |
| hazmat | and the delta between 48/49 on origin parsing | 15:30 |
| rogpeppe2 | hazmat: there's a port number in the origin? | 15:30 |
| hazmat | rogpeppe2, per my pastebin yes | 15:30 |
| hazmat | let me modify the client and see what happens | 15:31 |
| rogpeppe2 | hazmat: ah! | 15:31 |
| rogpeppe2 | hazmat: so it's all your fault :-) | 15:31 |
| hazmat | rogpeppe2, debatable :-) | 15:31 |
| hazmat | rogpeppe2, as in this case i didn't write the websocket client lib, and it did previously work against juju-core | 15:32 |
| hazmat | and its still not identified as the actual bug | 15:33 |
| rogpeppe2 | hazmat: oh yes | 15:33 |
| rogpeppe2 | hazmat: Origin should be a url | 15:34 |
| hazmat | rogpeppe2, its not the issue | 15:34 |
| rogpeppe2 | hazmat: it's nothing to do with the port number | 15:34 |
| * hazmat plays around with url.Parse | 15:35 | |
| rogpeppe2 | jeeze this is inpenetrable http://tools.ietf.org/id/draft-abarth-origin-03.html | 15:36 |
| rogpeppe2 | hazmat: here's a start: http://paste.ubuntu.com/5664817/ | 15:36 |
| hazmat | rogpeppe2, do you get an err with that? | 15:37 |
| rogpeppe2 | hazmat: yes | 15:37 |
| hazmat | i just switched out to 1.1 | 15:37 |
| hazmat | rogpeppe2, this might be a delta with go 1.0 | 15:37 |
| rogpeppe2 | hazmat: i doubt it | 15:38 |
| rogpeppe2 | hazmat: looks like that websocket update to me | 15:38 |
| hazmat | rogpeppe2, ah yes.. ic | 15:38 |
| hazmat | previously it only parsed with url if didn't match 13 or 8 on websocket protocol | 15:39 |
| rogpeppe2 | by my shallow reading of http://tools.ietf.org/id/draft-abarth-origin-03.html it looks like your client is wrong | 15:40 |
| rogpeppe2 | serialized-origin = scheme "://" host [ ":" port ] | 15:41 |
| hazmat | rogpeppe2, depends .. looking at the websocket spec.. its not clear that's it meaningful.. the client can fake whatever they want.. so the server checking here is mostly just of the obnoxious broken sort. | 15:43 |
| hazmat | http://learnitcorrect.com/blog/websocket-is-great-but-not-the-origin-policy.html | 15:43 |
| rogpeppe2 | hazmat: i'm with you that the origin header is fundamentally weird and probably broken | 15:43 |
| rogpeppe2 | hazmat: but that doesn't mean that the websocket code isn't correct to check it for syntactic correctness | 15:44 |
| hazmat | rogpeppe2, the checking is also optional | 15:44 |
| hazmat | what broke is the changing from optional to required | 15:44 |
| rogpeppe2 | hazmat: yeah | 15:46 |
| rogpeppe2 | hazmat: looks like i can get around it easily though | 15:46 |
| hazmat | rogpeppe2, thanks for debugging with me | 15:46 |
| hazmat | i'll workaround in the client | 15:46 |
| rogpeppe2 | hazmat: by creating websocket.Server rather than using websocket.Handler directly | 15:46 |
| rogpeppe2 | hazmat: and using a nil handshake function | 15:47 |
| hazmat | rogpeppe2, yeah.. i was wondering why you were doing it that way.. ie not using most of the stuff in the server.go | 15:47 |
| rogpeppe2 | hazmat: all that stuff is new | 15:47 |
| hazmat | ah | 15:47 |
| rogpeppe2 | hazmat: with r48 | 15:47 |
| rogpeppe2 | hazmat: sorry, 49 | 15:47 |
| rogpeppe2 | hazmat: i wonder if the default is wrong. who gives a f*** about Origin? | 15:48 |
| hazmat | rogpeppe2, or more to the point, it looks like its there as a policy hook point for people that provider custom handshakes that do care.. just to avoid them having to do the origin parse themselves, as is its mostly useless though | 15:49 |
| rogpeppe2 | hazmat: yeah. it's a pity that the default is to do a meaningless check on a header that noone cares about though. | 15:50 |
| hazmat | rogpeppe2, revno 51.. summary: go.net/websocket: fix handshake error. | 15:50 |
| hazmat | rogpeppe2, agreed | 15:51 |
| hazmat | rogpeppe2, or even if they cared about is trivially faked | 15:51 |
| rogpeppe2 | hazmat: i'm not sure r51 fixes the issue we're seeing here. | 15:51 |
| hazmat | rogpeppe2, it doesn't | 15:51 |
| rogpeppe2 | hazmat: i think the point is to avoid hoaxing people using normal browsers | 15:52 |
| rogpeppe2 | hazmat: because you can't fake it from js | 15:52 |
| rogpeppe2 | hazmat: i may be wrong though. it always seemed odd to me. | 15:52 |
| hazmat | rogpeppe2, released new client versions w/ workaround/proper origin, thanks again | 16:05 |
| rogpeppe2 | hazmat: np. i learned something new :-) | 16:05 |
| rogpeppe2 | hazmat: i think i'll change the server to ignore the origin explicitly | 16:06 |
| mramm | Anybody going to the virtual UDS Juju Core session at 19:05 UTC? | 17:06 |
| mramm | http://summit.ubuntu.com/uds-1305/meeting/21818/juju-core-development/ | 17:06 |
| mramm | I will be there, but would appreciate help from anybody from core or blue that can attend. | 17:06 |
| rogpeppe2 | mramm: i'm out i'm afraid | 17:20 |
| rogpeppe2 | mramm: just leaving now | 17:20 |
| mramm | rogpeppe2: understood | 17:20 |
| mramm | just putting it out there ;) | 17:20 |
| rogpeppe2 | mramm: i finally have internet back BTW | 17:20 |
| mramm | rogpeppe2: awesome! | 17:21 |
| rogpeppe2 | mramm: lots of ancient lead wiring replaced apparently | 17:21 |
| rogpeppe2 | mramm: so my connection may get faster | 17:21 |
| rogpeppe2 | mramm: (takes 5-6 days to ramp up they said) | 17:21 |
| mramm | rogpeppe2: that is interesting | 17:22 |
| mramm | rogpeppe2: strange but interesting | 17:23 |
| rogpeppe2 | mramm: apparently there *is* a button they can push to say "we know we just replaced the cable, so try the faster speed now" but they're not allowed to use it. | 17:23 |
| mramm | rogpeppe2: interesting | 17:24 |
| rogpeppe2 | g'night all | 17:25 |
| === deryck is now known as deryck[lunch] | ||
| dpb1 | Hi -- is this a known issue? Am I doing something wrong? var/lib/go/src/launchpad.net/juju-core/environs/openstack/provider.go:547: undefined: identity.AuthKeyPair (during go install -v launchpad.net/juju-core/...) | 18:32 |
| mramm | dpb1: I have not seen it, but perhaps davecheney will know more than me | 18:33 |
| mramm | seems like a version mismatch between juju-core and goose (the openstack API library) | 18:37 |
| * davecheney pricks up his ears | 18:47 | |
| davecheney | i'm not really here (waiting for a flight) | 18:47 |
| davecheney | but I can try to help | 18:47 |
| dpb1 | davecheney, mramm: if you need me to try something out, let me know | 18:54 |
| === deryck[lunch] is now known as deryck | ||
| dpb1 | interesting... go get is pulling in old bits for goose. /me looks into why | 19:00 |
| davecheney | dpb1: the simplest way to fix this is | 19:01 |
| davecheney | rm -rf $GOPATH/src/launchpad.net/goose | 19:01 |
| dpb1 | ok. | 19:01 |
| davecheney | go get -u -v launchpad.net/juju-core/.... | 19:01 |
| davecheney | there are more complicated explanations | 19:02 |
| davecheney | but this one will get you going | 19:02 |
| * dpb1 tries | 19:02 | |
| dpb1 | davecheney: awesome. that is working. I see the parent branch changed locations. I guess go doesn't better deal with that? | 19:06 |
| davecheney | the support for bzr in the go tool is best effort | 19:09 |
| davecheney | we've moved the bloody project that many times | 19:09 |
| davecheney | maybe it would be easier to update the instructions to not use the go tool, and just tell people which packages to branch | 19:09 |
| dpb1 | davecheney: it is nice to bootstrap. about as dead simple as I have ever seen a project. :) | 19:11 |
| davecheney | i don't think we (at canonical) are paying enough attention to what happens when we move projects around | 19:12 |
| davecheney | i'll add some words to the README | 19:12 |
| dpb1 | k | 19:12 |
| dpb1 | thx, enjoy your flight. :) | 19:12 |
| davecheney | dpb1: email me, david.cheney@canonical.com if you get stuck again | 19:13 |
| dpb1 | davecheney: sure thing | 19:14 |
| === wedgwood is now known as wedgwood_away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!