[00:06] Ursinha: if there is anything we can do to help please let us know [00:07] wgrant, cjohnston , that page is only used by summit? [00:07] AFAIK [00:08] Ursinha: Yes [00:09] and who maintains summit? [00:09] * cjohnston points to mhall119 [00:09] * cjohnston hopes wgrant doesn't point at cjohnston [00:09] lol [00:10] I ask because if we change launchpad and that causes summit to go crazy, that wouldnt be a launchpad problem :) [00:10] Ursinha: its me [00:10] and yes [00:10] :-) [00:10] given that summit people are aware and so [00:10] ah, good then [01:27] wgrant: I might have to fix the garbo job to use memcache. Or we deploy it and then cowboy disable it until the next NDT [01:32] StevenK: Why? [01:33] Oh, you mean to stop it running more than once? [01:35] wgrant: Yeah. [01:36] StevenK: Depending on timing we'll want to run it at least twice anyway [01:36] wgrant: Really? [01:36] I'd personally have used a feature flag to just run it once when we wanted to [01:36] But it doesn't really matter [01:36] StevenK: Because it's possible that garbo will start before everything that creates previewdiffs has the new code. [01:37] Ah, true [01:37] eg. code deploys to ackee, garbo runs and updates MP 1234, taotie updates MP 1234's diff with the old code, then taotie gets the new code === Ursinha is now known as Ursinha-zzz [04:56] wgrant: https://code.launchpad.net/~stevenk/launchpad/deny-ddeb-deletion/+merge/163633 or shall I refactor out and have the same thing for changeOverride() ? [04:59] StevenK: I'd consider explaining that you should delete the deb instead, but otherwise fine [05:02] wgrant: "Cannot delete debug publications directly, please delete the publication" doesn't sound right either [05:03] "Cannot delete ddeb publications directly; delete the corresponding deb instead."? [05:05] wgrant: http://pastebin.ubuntu.com/5663470/ [05:07] StevenK: right [05:12] wgrant: I'll land it with --incremental, since the bug also mentions changeOverride() [05:12] StevenK: Yep [05:12] StevenK: Or do changeOverride in the same branch [05:12] Because it's like two lines [05:12] + a test [05:13] So 12 [05:13] Won't quite be over the limit :) [05:13] And I have like 35k LOC credit [05:18] Hmmm, how do you pass kwargs through assertRaisesWithContent [05:18] TypeError: assertRaisesWithContent() got an unexpected keyword argument 'new_phased_update_percentage' [05:36] wgrant: changeOverride() now complains too [05:38] StevenK: 50 + AssertionError, "Cannot override debug publications directly; " [05:38] 51 + "please override the publication." [05:39] wgrant: Hmmmm? [05:40] StevenK: That's the old message [05:40] You used the old message in changeOverride [05:44] wgrant: PopulatePreviewDiffMergeProposal is done on prod, landing the branch to drop it [05:44] StevenK: Do run a query to confirm that it worked first, pls. [05:51] wgrant: The ddeb MP has updated [06:20] wgrant: Can haz +1? [06:26] StevenK: Should that be OverrideError rather than AssertionError? Otherwise +1 [06:27] Oh, I didn't realize there was an OverrideError === joeyfreenode is now known as joey === wedgwood_away is now known as wedgwood === marcoceppi_ is now known as marcoceppi === olli__ is now known as olli === jamestunnicliff_ is now known as jamestunnicliffe === Ursinha-zzz is now known as Ursinha === _mup__ is now known as _mup_ === cody-somerville_ is now known as cody-somerville === yofel_ is now known as yofel === james_w` is now known as james_w === deryck is now known as deryck[lunch] === deryck[lunch] is now known as deryck === wedgwood is now known as wedgwood_away === wgrant_ is now known as wgrant [23:55] Bah, MPJs can't really run on qas either [23:55] But they're run under cron