jtv | mgz: hi — would you be a good person to ask about the Tag model code in MAAS? | 12:52 |
---|---|---|
mgz | yeah | 12:53 |
jtv | Excellent. I was wondering why TagManager.get_nodes essentially duplicates NodeManager.get_nodes. Was there a performance problem with the ordering of SQL "WHERE" constraints or something? | 12:54 |
mgz | not that I recall, probably just we weren't sure which would be more useful and ended up with both | 12:56 |
jtv | I suppose there would have been a comment if there were some compelling nonobvious reason... I think I'll just eliminate the redundancy then. Thanks. | 12:56 |
jtv | Could also be that it was written without a good "feel" for how filtering in this particular ORM works. | 12:57 |
mgz | I'd certainly expect tag getting nodes and getting nodes filtered on tag to generate equivalently performing sql | 12:58 |
jtv | Yes, ultimately the DB back-end ought to transform past any such ordering dependencies. | 12:59 |
=== kentb is now known as kentb-out |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!