[12:03] <Laney> jodh: http://people.canonical.com/~laney/patch-dump/msva-upstart.debdiff WDYT?
[12:03] <Laney> seems to work here
[14:00] <stgraber> Laney: you don't appear to have a way to stop the msva
[14:01] <Laney> hmm? 'stop' works
[14:03] <SpamapS> Laney: +description "Job which does nothing other than block the session start until monkeysphere-validation-agent is finished" .. that is going to appear in a log...
[14:03] <Laney> ah, didn't know that
[14:04] <Laney> it can easily be condensed, of course
[14:04] <SpamapS> should be
[14:04] <SpamapS> its meant for user display
[14:04] <SpamapS> document weirdness in comments :)
[14:04] <Laney> don't think I've ever seen those in logs
[14:04] <Laney> otherwise I would have known
[14:04] <SpamapS> Laney: for system jobs they appear in the console.
[14:05] <SpamapS> Laney: I have to believe at some point the same desire for visibility will seep into user sessions that seeped into the boot
[15:56] <Laney> SpamapS: Do you think the rest of it looks alright?
[16:00] <SpamapS> Laney: I have almost zero idea how xsession-init works (and almost zero care.. ;)  .. so I can't evaluate 'start on starting xsession-init' beyond "this will block xsession-init from starting" ..
[16:00] <Laney> heh
[16:00] <Laney> well, it all seems to work here
[16:00] <Laney> might JFDI
[16:01] <SpamapS> Laney: is there no need for a stop on in user sessions?
[16:01] <Laney> I guess they all get torn down when the session ends - there is a session-end signal though
[16:02] <SpamapS> Laney: so, I think its a bit over-engineered..
[16:02] <Laney> In /usr/share/upstart/sessions/ most of the jobs don't have a stop on
[16:02] <SpamapS> Laney: how does monkeysphere-validation-agent use that first argument?
[16:03] <SpamapS> Laney: is that meant to be "fork and exec this when you are ready to serve user needs?"
[16:03] <Laney> Spawns it, with MONKEYSPHERE_VALIDATION_AGENT_SOCKET in its environment and exits when it does
[16:03] <SpamapS> +initctl set-env --global MONKEYSPHERE_VALIDATION_AGENT_SOCKET=$MONKEYSPHERE_VALIDATION_AGENT_SOCKET
[16:03] <SpamapS> and set-env --global is appropriate ?
[16:05] <SpamapS> Laney: because IIRC, not using --global, xsession-init will still get it..
[16:05] <SpamapS> hm maybe not
[16:06] <SpamapS> Ok yeah you need --global
[16:06] <Laney> yeah I think so too
[16:06] <SpamapS> Laney: my very untrained eye says it is all fine.
[16:06] <Laney> possibly the weirdest unexplained part is the pre-start script, but that's robbed from the old Xsession.d script :-)
[16:07] <Laney> thanks for the review