[12:03] jodh: http://people.canonical.com/~laney/patch-dump/msva-upstart.debdiff WDYT? [12:03] seems to work here [14:00] Laney: you don't appear to have a way to stop the msva [14:01] hmm? 'stop' works [14:03] Laney: +description "Job which does nothing other than block the session start until monkeysphere-validation-agent is finished" .. that is going to appear in a log... [14:03] ah, didn't know that [14:04] it can easily be condensed, of course [14:04] should be [14:04] its meant for user display [14:04] document weirdness in comments :) [14:04] don't think I've ever seen those in logs [14:04] otherwise I would have known [14:04] Laney: for system jobs they appear in the console. [14:05] Laney: I have to believe at some point the same desire for visibility will seep into user sessions that seeped into the boot [15:56] SpamapS: Do you think the rest of it looks alright? [16:00] Laney: I have almost zero idea how xsession-init works (and almost zero care.. ;) .. so I can't evaluate 'start on starting xsession-init' beyond "this will block xsession-init from starting" .. [16:00] heh [16:00] well, it all seems to work here [16:00] might JFDI [16:01] Laney: is there no need for a stop on in user sessions? [16:01] I guess they all get torn down when the session ends - there is a session-end signal though [16:02] Laney: so, I think its a bit over-engineered.. [16:02] In /usr/share/upstart/sessions/ most of the jobs don't have a stop on [16:02] Laney: how does monkeysphere-validation-agent use that first argument? [16:03] Laney: is that meant to be "fork and exec this when you are ready to serve user needs?" [16:03] Spawns it, with MONKEYSPHERE_VALIDATION_AGENT_SOCKET in its environment and exits when it does [16:03] +initctl set-env --global MONKEYSPHERE_VALIDATION_AGENT_SOCKET=$MONKEYSPHERE_VALIDATION_AGENT_SOCKET [16:03] and set-env --global is appropriate ? [16:05] Laney: because IIRC, not using --global, xsession-init will still get it.. [16:05] hm maybe not [16:06] Ok yeah you need --global [16:06] yeah I think so too [16:06] Laney: my very untrained eye says it is all fine. [16:06] possibly the weirdest unexplained part is the pre-start script, but that's robbed from the old Xsession.d script :-) [16:07] thanks for the review === robotfuel is now known as ChrisGagnon === ChrisGagnon is now known as robotfuel