| === chriadam|away is now known as chriadam | ||
| Mirv | morning | 04:31 |
|---|---|---|
| Mirv | I'm thinking of writing to the mailing list about removing the 'qt5-default' dependency from those apps who only use it to have /usr/bin/qmlscene neatly available, but I may need to re-read the text a couple of times more.. | 04:39 |
| om26er | gusch, hey! | 07:54 |
| gusch | om26er: hi | 07:55 |
| om26er | gusch, the branch is ready, and now the test seem to pass as well. | 07:55 |
| om26er | gusch, https://code.launchpad.net/~om26er/gallery-app/fix-failing-test-jenkins/+merge/165201 | 07:55 |
| gusch | om26er: not as readable as I would like it, but ok | 08:00 |
| gusch | om26er: I will approve it | 08:01 |
| om26er | gusch, things got quite complex fixing that bug, so took this approach. | 08:01 |
| om26er | s/bug/test | 08:02 |
| gusch | om26er: can't you call "lambda: self.album_view.number_of_photos()" in the assert? | 08:03 |
| gusch | om26er: hmmm - I'll write a comment (and not approve right away) | 08:06 |
| om26er | gusch, yeah so i have found things to not work reliably with that, as number_of_photos() gives a number which is returned wrong on very slow systems like jenkins | 08:06 |
| om26er | let me try that again | 08:06 |
| gusch | om26er: commented | 08:09 |
| om26er | thanks, working on it. | 08:11 |
| gusch | om26er: approved | 08:58 |
| om26er | gusch, thanks | 08:58 |
| om26er | renato_, Hi! | 09:05 |
| om26er | renato_, so the branch you approved yesterday for the tests, there is a failing test that I disabled. | 09:05 |
| om26er | the test fails on touch because it pulls out the launcher there, on desktops its also not reliable as it fails on different screen resolutions | 09:06 |
| om26er | https://code.launchpad.net/~om26er/mediaplayer-app/fix_on_touch/+merge/165230 | 09:06 |
| timp | zsombi: I'll work on this bug https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1167232 but I'll create a general solution by adding property action to AbstractButton | 09:46 |
| ubot2 | Ubuntu bug 1167232 in Ubuntu UI Toolkit "[toolbar] Toolbar using buttons behaves different for the back button" [High,Confirmed] | 09:46 |
| zsombi | timp: ok, so remember to fill all relevant fields (i.e. button's label) when an action is specified. I'd say actions should override previous values of button.text. Also don't forget triggering action's signal from clicked() | 09:48 |
| zsombi | timp: then the next step perhaps would be to add action to every component | 09:50 |
| timp | zsombi: I'll just change the default text: action ? action.text : "" instead of the current "". Setting text explicitly will override the action's properties. | 09:50 |
| zsombi | timp: so you want to handle the action data with lower priority as the component' sown properties? | 09:50 |
| timp | yes | 09:52 |
| zsombi | that also makes sense... | 09:52 |
| timp | oSoMoN: when you have time, can you have a look at https://code.launchpad.net/~tpeeters/ubuntu-calendar-app/monthViewHeight/+merge/165189 ? | 10:05 |
| om26er | gusch, please review this when you have the time: https://code.launchpad.net/~om26er/gallery-app/fix_touch_failing_ap_tests/+merge/165327 | 10:17 |
| gusch | om26er: ok | 10:17 |
| om26er | fixes all tests on touch, except for the one we talked yesterday. | 10:17 |
| oSoMoN | timp: approved | 10:24 |
| timp | oSoMoN: great, thanks! | 10:24 |
| timp | oSoMoN: will it be merged automatically? | 10:24 |
| oSoMoN | timp: yes, it should | 10:24 |
| timp | okay. | 10:25 |
| oSoMoN | gusch: is the autopilot failure in https://code.launchpad.net/~schwann/gallery-app/gallery-translations/+merge/165179 related to the changes introduced by the MR ? | 10:26 |
| gusch | oSoMoN: let me check ... | 10:26 |
| gusch | oSoMoN: no, not realated to the changes in the MR, but gallery seems to have lots of randomly failing tests lately :( | 10:29 |
| gusch | om26er: can you take a look at that issue? ^ | 10:29 |
| oSoMoN | gusch: I approved the MR, feel free to top-approve yourself once the autopilot tests pass | 10:31 |
| om26er | gusch, oSoMoN its again a timing issue with jenkins, this time its not able to click on the edit item due to slowness in jenkins. I bet a re-run will pass it. | 10:33 |
| om26er | I am looking at how to fix this one, my other branch also fixes a bunch of timing issues | 10:33 |
| gusch | om26er: I commented on https://code.launchpad.net/~om26er/gallery-app/fix_touch_failing_ap_tests/+merge/165327 | 10:34 |
| gusch | oSoMoN: thx - I hope we can resolve the test issues quickly | 10:36 |
| zsombi | Saviq: hei, can you check whether is this still valid for you? https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1166127 | 10:42 |
| ubot2 | Ubuntu bug 1166127 in Ubuntu UI Toolkit "InverseMouseArea without sensingArea doesn't work" [High,Confirmed] | 10:42 |
| Saviq | zsombi, valid on device | 10:49 |
| Saviq | zsombi, trying to upgrade now | 10:49 |
| Saviq | zsombi, no upgrades to be seen, so yeah, still valid on the device for me | 10:50 |
| Saviq | zsombi, btw, we'll need an InverseTouchArea, too | 10:50 |
| zsombi | Saviq: gotcha... most likely you need to add a wish item to SDK then :) | 10:51 |
| Saviq | zsombi, yeah, will do | 10:51 |
| Saviq | zsombi, I'll try a new image, too | 10:52 |
| timp | maybe we need an InverseItem | 10:52 |
| zsombi | Saviq: I guess you'd need it for undefined touch points, right? | 10:52 |
| timp | and then the MouseArea can anchors.fill: inverseItem | 10:52 |
| zsombi | timp: Saviq: asking the IMA problem as I cannot see it anymore on the desktop... | 10:53 |
| Saviq | zsombi, we're starting to distinguish between touch and mouse interaction | 10:53 |
| Saviq | zsombi, yeah, it's fine on the desktop, not so on deviec | 10:53 |
| zsombi | Saviq: kewl...:) | 10:53 |
| Saviq | zsombi, so we need to look at distinguishing in Inverse*, too | 10:54 |
| zsombi | Saviq: that's also weird... as the rootObject is getting updated once the QQuickVoiew statusChanged() is triggered... | 10:54 |
| Saviq | zsombi, it's fine in image 133 | 11:30 |
| zsombi | Saviq: so there was some "dust" in between then? weird... | 11:31 |
| Saviq | zsombi, I must've not had the most recent toolkit on my device | 11:31 |
| Saviq | zsombi, aaargh, wrong | 11:32 |
| Saviq | zsombi, still bad | 11:32 |
| zsombi | Saviq: hmm... weird... still doesn't get the sensingArea? | 11:32 |
| Saviq | zsombi, yup, null | 11:33 |
| Saviq | zsombi, http://pastebin.ubuntu.com/5693414/ | 11:33 |
| Saviq | zsombi, prints null | 11:34 |
| Saviq | zsombi, and then some ++++++++ when you tap | 11:34 |
| Saviq | no ------------ | 11:34 |
| zsombi | damn!... | 11:35 |
| zsombi | Saviq: weird... I have the code from the pastebin in the test case (with not having sensingArea set at all) and the test passes... | 12:46 |
| zsombi | Saviq: on the device, with 133 + my branch, which is nothing more than the trunk + test case | 12:46 |
| Saviq | zsombi, did you try simply with qmlscene on the device? | 13:03 |
| zsombi | Saviq: I'm on that now, however with the test case it doesn't fail... | 13:03 |
| === gusch is now known as gusch|brb | ||
| === chriadam is now known as chriadam|away | ||
| === gusch|brb is now known as gusch | ||
| coder2 | any python quickly developer here? | 20:14 |
| coder2 | how to add a filechooser to a menu item using glade | 20:15 |
| === francisco is now known as Guest84395 | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!