/srv/irclogs.ubuntu.com/2013/05/24/#ubuntu-app-devel.txt

=== chriadam|away is now known as chriadam
Mirvmorning03:59
=== chriadam is now known as chriadam|away
guschoSoMoN: are you up for a review? (orientation)  https://code.launchpad.net/~schwann/gallery-app/gallery-orientation-suppot/+merge/16431408:08
oSoMoNgusch: will take a look in a moment08:22
guschthx08:22
oSoMoNgusch: approved, but please read my comment09:22
guschoSoMoN: hmmm - ok - didin't test cropping09:23
zsombioSoMoN: I have good news for U ;)09:52
timpzsombi: do you have time for the button actions review? https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/buttonAction/+merge/16556310:05
timpzsombi: I think it is done, but I am installing a new image on my phone and then testing it there. I will post the results in the MR.10:06
zsombitimp: ok, will check it soon. I also have IMA in Window to test on the device10:06
timpok10:10
zsombitimp: unit test :)10:15
timp?10:19
timpah for the action10:19
zsombitimp: yes :)10:20
zsombioSoMoN: https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/ima-in-window/+merge/16556710:20
zsombitimp: ^ one for you to review too10:20
oSoMoNzsombi: excellent, I’ll have a look at it right away10:31
zsombioSoMoN: +110:32
timpzsombi: do you know of a way to check for a context property in qml (no cpp)?10:33
zsombitimp: hmm... try-catch?10:34
timpzsombi: phone-app was completely broken yesterday. Had to revert one JS file from r50110:40
zsombitimpÉ which one_10:41
zsombiwhich one?10:41
timpwhere you made the js-files stateless10:41
timpPageWrapperUtils10:41
timpthe reason is that inside their pages they assume they have a mainView object.10:41
zsombiyes... and what's the problem there?10:42
timpbut items created inside a stateless js (PageWrapperUtils, when stack.push("SomePage.qml") is used doesn't have a context10:42
timpsee lp:~tpeeters/+junk/contextTest10:42
timpand run that one.10:42
timpits a simplification of what went wrong10:42
timpzsombi: no worries it is fixed now, but maybe you find it an interesting issue. And we should avoid using that construction10:43
zsombitimp: checking...10:44
timpKaleo: lp:~tpeeters/+junk/contextTest <-- to clear up yesterday's issue.10:44
timpthey kind of assume in phone-app that their root item can be used like a global variable, but it is not always the case when the js is stateless10:45
oSoMoNzsombi: I commented on your MR10:45
makarahi. I'm trying to compile the OCR package Tesseract from source. When I enter command './configure' I get error 'configure: error: C++ compiler cannot create executables'10:46
timpmakara: sudo apt-get install build-essential10:48
timpand try again10:48
timpzsombi: is your MR urgent to review, or can I work on my unit tests first?10:49
zsombitimp: semi-urgent :) oSoMoN: i swaiting for it, so he drives its urgency ;)10:50
timpdpm: on https://developer.ubuntu.com/ there is a big banner with "get started" in it that links to http://developer.ubuntu.com/get-started/gomobile/10:50
timpdpm: but there also is the (1) get started, under that which links to a different page10:51
timpdpm: both give quite different suggestions for how to get started. Should we recommend only one of them instead? I like the first one :)10:51
zsombioSoMoN: checking your comment...10:51
oSoMoNtimp: medium urgency10:51
timpzsombi, oSoMoN ok I'll do the review first10:52
oSoMoNKaleo: could you please give me comment rights on https://docs.google.com/a/canonical.com/document/d/1sfGFVOGiGdLziEl-PUyAa7gKJb-GFcJWj0ajkW2-LC4/edit ?10:53
dpmtimp, indeed, it's on my list. See the 4th work item on https://blueprints.launchpad.net/ubuntu/+spec/appdev-1305-developer-site-gomobile :)10:57
timpdpm: ok, great :)11:01
makaratimp, thanks. works now11:03
Kaleohiya11:04
timpKaleo and others: this is the test program for yesterday's issue: lp:~tpeeters/+junk/contextTest11:14
timpbzoltan: if you have interesting findings, can you document them? maybe here https://docs.google.com/a/canonical.com/document/d/1eZNS0jl32XQ-4tUXVCmQlft829gE_3IRNxzPQVTaXrk/edit#11:19
zsombioSoMoN: commented back...11:21
Kaleokalikiana: https://codereview.qt-project.org/#patch,all,56875,111:21
Kaleokalikiana: _awesome_11:21
Kaleokalikiana: no need for the values property anymore11:22
KaleooSoMoN: done11:22
Kaleotimp: nice11:22
kalikianaKaleo, woot11:23
Kaleokalikiana: mardy did it :)11:23
* kalikiana hugs mardy 11:23
* mardy can't breathe11:24
oSoMoNzsombi: commented back11:24
* Kaleo hugs mardy11:24
oSoMoNKaleo: thanks, I have a couple of comments to add11:24
KaleooSoMoN: nice11:24
oSoMoN(sorry for the late review btw, it kept being pushed back by priority tasks)11:24
mardyKaleo: however, I think that having a "values" property wouldn't be bad anyway11:24
mardyKaleo: in order to avoid name collisions11:24
mardyKaleo: think for instance of having a GCconf key named "keys"11:25
Kaleomardy: party pooper11:26
zsombioSoMoN: the rootItem() supposed to work on non-visual items too11:26
mardy:-)11:27
makaratimp, i can do 'make' but not 'make install'. Get error '/usr/bin/install: cannot create regular file '/usr/local/lib/liblept.so.3.0.0': Permission denied'11:28
Kaleotimp: sounds like a bug in qt no?11:28
oSoMoNzsombi: ok11:30
oSoMoNKaleo: commented11:31
timpKaleo: I don't like referring to global/context properties for which you have no guarantee they are there. I wouldn't call this a bug.11:31
timpKaleo: how can you assume a property in the context inside a context-free library?11:31
timpmakara: for 'make install' you'll need to use 'sudo' because it will write to system files11:32
makaratimp, ok11:32
timpKaleo: just before you joined the standup, zsombi proposed to use something like rootItem from our quickutils11:34
timpKaleo, zsombi not sure about the exact function name since it is going to change (right?)11:34
timpKaleo: better would be to pass a reference to the mainView to the newly created pages11:35
timpin phone-app11:35
zsombitimp: Kaleo: QuickUtils.rootItem(object) - it's in the MR timp is reviewing :)11:35
timpbrb.11:36
KaleooSoMoN: replied11:38
Kaleotimp: well, it's a bug because the behaviour is not consistent11:38
Kaleotimp: also your example code has something wrong11:39
Kaleotimp: the inline component does not try to access root11:39
Kaleotimp: also the inline component should be defined in another QML file11:40
Kaleotimp: to be closer to the actual usage11:40
Kaleozsombi: I don't want to expose that to app devs11:40
zsombiKaleo: at the moment is not documented - so in a sense it is not "exposed"11:41
zsombiKaleo: like the whole QuickUtils is internal11:42
Kaleozsombi: let's keep it so11:42
Kaleokalikiana: I'm out of ideas for the unicode failure11:45
Kaleokalikiana: and it's really slow to test here11:45
zsombioSoMoN: in Qt 5.0.1 we had the problem that when QQuickView::rootObject() returned a valid object, its size was invalid... Now seems that once we reach the topmost window, we get a valid size... So the implementation gets simplier11:47
oSoMoNcool11:49
kalikianaKaleo, let me have another look over it a bit later if I can think of anything11:49
makaraWhy would I get "tesseract: error while loading shared libraries: libtesseract.so.3: cannot open shared object file: No such file or directory" when I can see the file at "/usr/local/lib/libtesseract.so.3"?11:50
KaleoMirv: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/115378711:50
ubot2Ubuntu bug 1153787 in Ubuntu UI Toolkit "qmlscene depends on qtlocation5-dev" [Undecided,New]11:50
zsombioSoMoN: hold on.. some of the test cases still report invalid root object size... :(11:51
timpKaleo: the contents of the inline component is in another QML file, and that one tries to access root11:55
zsombioSoMoN: yep, as I sensed: the Window's QQuickRootItem size holds a valid size, but the QQuickView's QQuickRootItem doesn't11:55
timpKaleo: the one that fails has the same structure as the one that failed in phone-app11:56
MirvKaleo: answered, both raring + the new saucy one12:00
KaleoMirv: thx12:01
dpmhey Kaleo, clock alarm design call?12:01
zsombioSoMoN: so, I guess we need to leave it as is now :(12:03
makaraI notice /usr/local/lib/ is not in my path. I never had this problem before I installed Ubuntu 13.04. What's the most high level way of adding library directories to the system path?12:05
Kaleomakara: try running with $LD_LIBRARY_PATH=/usr/local/lib/12:09
Kaleomakara: try running with LD_LIBRARY_PATH=/usr/local/lib/12:09
makaraKaleo, what's a solution that will stick12:15
Kaleomakara: not sure12:15
Kaleotimp: contextTest is a bug in Qt, can you report it?12:33
timpKaleo: if you create an object from a stateless library, then it is logical that you don't have some property in the context, so I don't see it as a bug12:37
Kaleotimp: and why does it work in 1 case then?12:37
Kaleotimp: cas C12:38
Kaleocase*12:38
Kaleotimp: the fact that it works in case C and not D is the bug12:38
timpok12:39
timpI'll report it.12:39
timpyou're right :)12:39
Kaleotimp: if you could add it in our js file PageWrapperUtils or whatever it was12:39
Kaleotimp: so that we don't foget12:39
Kaleo+r12:39
timpsure12:40
timpis anyone running qt 5.1.0?12:42
zsombioSoMoN: I think I made it ;)12:42
timpMirv: ^12:42
Mirvtimp: not even me, although it you want qtwebkit 5.1.0 beta1 it's available for saucy on qt5-beta-proper :)12:43
Mirvbut I heard it's not enough to start the DPR work alone, ie. needs all the rest of the modules as well.12:43
timpno, I'm looking for someone to quickly run lp:~tpeeters/+junk/contextTest on 5.1.0 and tell me what it says12:43
KaleoMirv: what dpr work?12:43
timpit doesn't have any configuration or dependencies besides qtquick212:43
KaleoMirv: you should not do anything12:43
KaleoMirv: just remove the patches we had12:44
MirvKaleo: I'm not doing anything, but I guess some others will make use of the new upstream features12:44
Kaleotimp: it says the same as it did for you12:44
KaleoMirv: I am12:44
KaleoMirv:  :)12:44
MirvKaleo: yes :)12:44
timpKaleo: ok, thanks!12:44
KaleoMirv: need qtcore12:44
KaleoMirv: and qtdeclarative would be great :)12:45
MirvKaleo: yep, it starts from qtbase. it may be some of the other dependencies don't want to play with qtbase unless they are also updated, but let's see12:45
Kaleok12:48
zsombitimp: oSoMoN: last update from wme on the MR (https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/ima-in-window/+merge/165567)12:52
zsombitimp: I checked the apps, noone uses the QuickUtils.rootObject property12:52
timpzsombi: ok. I'm not reviewing yet, I'll do that after lunch.12:53
zsombitimp: ok, if you see something nasty, we can handle it on Monday... I'll be stepping out soon...12:54
timpzsombi: lately if I check apps I add the results as a comment in the MR to have everything in one place12:54
timpzsombi: okay.12:54
timpKaleo: bug reported https://bugreports.qt-project.org/browse/QTBUG-3134713:46
Kaleotimp: thx13:47
timpKaleo: tiny MR for you: https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/commentStateBug/+merge/16562113:52
Kaleotimp: thank you13:52
timpKaleo: thanks for approving13:54
guschrenato_: can you review this? https://code.launchpad.net/~schwann/gallery-app/gallery-sharing-bug/+merge/16559213:58
odraHello14:20
om26erboiko, hey!14:20
boikohi om26er14:20
om26erboiko, so the phone does not play a tone when a sms arrives, is that something to be fixed in the phone-app side?14:21
boikoom26er: it does play, it is just not loud enough14:21
om26erboiko, can I change the tone somehow?14:22
boikoom26er: https://bugs.launchpad.net/phone-app/+bug/118165014:22
ubot2Ubuntu bug 1181650 in phone-app "SMS recieve sound is not loud enough, even when on full volume" [Medium,New]14:22
om26erthats a blocker #1 for me, re: Dogfooding14:22
boikoom26er: so right now it is hardcoded, but the sound was not proposed by anyone, I just picked one from ubuntu-sounds14:22
boikoom26er: let me point you to the code14:22
boikoom26er: http://bazaar.launchpad.net/~phablet-team/phone-app/trunk/view/head:/libphoneapp/ringtone.cpp#L6314:23
om26erboiko, cool thanks14:24
boikoom26er: np14:24
odraHey about recent files14:30
odraIf you can navigate through files in a folder, should you add to the recent files every file you navigated to or only the first file the user opened? :/14:30
oSoMoNgusch, renato_, boiko: anyone up for a review? that’s a bug fix for the browser: https://code.launchpad.net/~osomon/webbrowser-app/panel-inside-loader/+merge/16565115:38
guschoSoMoN: sure15:39
oSoMoNthx15:39
guschoSoMoN: looking goos - waiting for jenkins16:01
guschoSoMoN: looking good - waiting for jenkins16:01
oSoMoNgusch: thanks16:07
dpmoSoMoN, do you happen to know if the camera app has an API for other apps to use the camera, or if there is any plan to implement something along those lines?16:10
oSoMoNdpm: I don’t think there’s such an API today, and I haven’t heard of any plans, but maybe gusch knows more16:11
dpme.g. a scanner app using the camera to read a barcode or a QR code16:11
dpmok, thanks oSoMoN16:11
guschdpm: using the camera is easy: http://qt-project.org/doc/qt-5.0/qtmultimedia/qml-qtmultimedia5-camera.html16:12
dpmah, I see, thanks for the pointer gusch16:12
guschoSoMoN: maybe it was a good idea to wait for jenkins - failed :(16:13
oSoMoNgusch: let me have a look16:14
oSoMoNgusch: ok, that’s a totally unrelated failure, another example of test not designed for really slow jenkins instances :/16:21
oSoMoNgusch: I’ll fix it separately, in the meantime I’ll request a re-run, with a bit of luck it will pass this time16:22
=== odra is now known as odraencode
guschoSoMoN: ok16:28
oSoMoNgusch: https://code.launchpad.net/~osomon/webbrowser-app/type_in_addressbar-helper/+merge/165670 should make autopilot tests more reliable, would you mind giving it a quick review?16:58
guschoSoMoN: looking at it17:06
oSoMoNgusch: thanks17:08
guschoSoMoN: I approved (but not top approved)17:14
guschoSoMoN: I have to go now - so please top approve once jenkins is ok17:15
Kaleokalikiana: good!17:36
Kaleokalikiana: I can reproduce the unicode bug17:36
Kaleokalikiana: I was also able to find out that the unicode codes between the expected value and the actual value were different17:37
Kaleokalikiana: I just have to go step by step back into the code to find out where the unexepected transformation happens17:37
KaleooSoMoN: were you satisfied with the answers from your comments?17:41
Kaleokalikiana: ah ah, failure seems to be on the way I set the command line in the tests17:51
=== francisco is now known as Guest60367
oSoMoNKaleo: yes, thanks17:53
jduHi, anyone around that might be able to help with an issue with GtkCssProvider in Python?19:37
asomethingjdu, maybe... what's the issue?19:46
jduWell, I'm doign a load_from_data(), and even though the docs say ID based sleectors shoudl work I can't seem to get to them to, i.e. trying to apply a style to a widget via #wdiget_name {... } doesn't work, but applying styles via GtkEventBox {...} works.19:49
jdusorry, typed too fast there, mucho bad grammar19:49
jduand spelling19:49
jduThe docs say that the name assigned to the widget in glade should be used as the id which I'm doing but it's just not working for me.19:50
jduHere's a paste of what the code looks like,  http://pastebin.com/W6FdLfXA19:52
asomethingI'll take a look... I don't think I've ever used ID based selectors but I've definitely used Class based ones19:53
jduThe top-level ones seem to work, I can do things like GtkEventBox {...} and style it, it just seems like the ID based selectors are getting ignored.19:54
jduI haven't tried classes, can see if that works19:54
jduHmmm, so my I'm getting th style_context from the window, when I apply the css via add_provider, does it only make the CSS available to the Window widget and not cascade it down to all it's child widgets and containers, etc...?20:04
jduBecause it seems like I can apply CSS to the Window itself but none of the items within the window get the styles20:04
asomethingstrange...20:08
asomethingI though .add_provider is supposed to take precedence, but maybe try .add_provider_for_screen20:09
asomethingscreen = Gdk.Screen.get_default()20:09
asomethingstyle_context.add_provider_for_screen(screen, css, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION)20:09
jduThat's done it! Man this has been driving me nuts for over an hour!20:10
jduThank you so much, pulling what's left of my hair out hah.20:11
asomethingha! I love being able to answer questions when I can't explain why that would work!20:12
jduAh well, it works! Thanks.20:13

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!