StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/plus-queue-errors/+merge/166164 | 02:39 |
---|---|---|
wgrant | StevenK: What if you just use addErrorNotification? | 02:46 |
wgrant | Rather than having separate error styling | 02:46 |
StevenK | wgrant: Because the code wants to bail out early from the POSTed method | 02:49 |
wgrant | StevenK: addErrorNotification and return? | 02:50 |
wgrant | Anyway, lunching, bbs | 02:50 |
StevenK | wgrant: addErrorNotification and return results in no effect | 02:53 |
StevenK | wgrant: addErrorNotification, redirecting and then returning does work, but will probably result in you murdering me. | 03:48 |
wgrant | StevenK: Ah, because the request only picks up notifications at the start, I guess. | 04:11 |
wgrant | StevenK: The existing MP is OK then, I guess. | 04:12 |
StevenK | wgrant: +1 it, I shall land and then we can finally deploy | 04:13 |
StevenK | Which will probably have to wait | 04:13 |
wgrant | StevenK: scan | 04:16 |
StevenK | Oh, damn. span? | 04:16 |
StevenK | - <scan tal:content="error"></scan> | 04:17 |
StevenK | + <span tal:content="error"></span> | 04:17 |
wgrant | That's more plausible, unless HTML5 is innovating | 04:17 |
StevenK | It's like the <video> tag | 04:17 |
StevenK | Except it involves instruments of evil. | 04:18 |
StevenK | wgrant: The MP has updated. | 04:27 |
StevenK | Ah, indeed | 04:27 |
* StevenK lands | 04:27 | |
=== tasdomas_afk is now known as tasdomas | ||
wgrant | StevenK: https://code.launchpad.net/~wgrant/launchpad/ddeb-copy-overrides/+merge/166188 | 07:44 |
wgrant | I've done reasonably extensive testing locally, and I think this is the last LP-side bit | 07:44 |
StevenK | wgrant: Sorry, looking. | 08:11 |
=== Gwaihir_ is now known as Gwaihir | ||
StevenK | wgrant: r=me. I'm landing the garbo deletion and the use of permit_obsolete_series now. | 08:13 |
=== wedgwood_away is now known as wedgwood | ||
wgrant | StevenK: Thanks | 08:28 |
=== wedgwood is now known as wedgwood_away | ||
=== wedgwood_away is now known as wedgwood | ||
=== tasdomas is now known as tasdomas_afk | ||
=== deryck is now known as deryck[lunch] | ||
=== nigelb_ is now known as nigelb | ||
=== wedgwood is now known as wedgwood_away | ||
=== deryck[lunch] is now known as deryck | ||
=== BradCrittenden is now known as bac________ | ||
=== bac________ is now known as bac |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!