=== _salem is now known as salem_ [03:00] veebers: I'm here. [03:01] elopio: oh sorry I had an issue getting setup, I've since sorted it :-) I'm just sorting out another bug at the moment so nothing to report sorry [03:03] veebers: ok, don't worry. Let me know if you get a chance to look it. I'll still be around for some hours. [03:04] elopio: coolio will do, cheers === salem_ is now known as _salem [05:19] thomi: answered [05:19] thomi: if you agree, can we then move on? [05:23] didrocks: I'm sorry - I still don't understand why having a circular dependency between two packages is bad. mterry and I looked into this, and concluded that we were not going to run into the one case that might cause us problems (maintainer scripts that rely on package installation order). [05:23] So either this change is largely for cosmetic purposes (which is fine, but I'd just like to know), or there's a genuine problem, which I don't understand, and that I'd like to understand [05:24] thomi: see https://code.launchpad.net/~didrocks/autopilot/remove-circular-dep/+merge/165873/comments/368138 [05:25] thomi: it's to prevent issues in the near future [05:27] didrocks: right, that looks like exactly what we read in oakland before merging the original change. [05:27] I'm fine to change it again, but let's not suggest that this is anything other than some proactive cleanup to maybe avoid problems in the future [05:27] thomi: this is just good packaging practice, because one day, that issue will happen [05:28] talking about experience, so this is why I see it as broken :) [05:28] didrocks: sure. Perhaps it would be a good idea to make sure that everyone on the distro team has a common set of expectations in this regard [05:28] otherwise we get inconsistent standards between packages / teams [05:29] thomi: welcome to Debian world :) [05:29] thomi: well, normally, those are blocked in binary NEW [05:29] archives admins are quite aligned on those [05:29] thomi: this team: https://launchpad.net/~ubuntu-archive/+members#active [05:33] thanks thomi [05:33] no worries [08:30] Saviq: just curious. What's the reason for this? https://code.launchpad.net/~aacid/unity/doNotAnimateFilterGrid/+merge/165886 [08:30] err... tsdgeos^ [08:30] mzanetti, it's unused [08:30] mzanetti, and was supposed to help tsdgeos with fixing the LVWPH [08:30] which to be honest it didn't really help much [08:30] we can discard it if you prefer [08:31] ah... I thought thats the expanding animation we see at startup [08:31] mzanetti, we shouldn't be seeing it at startup ;) [08:31] so I was curious if thats disabled because of some issues or because of design doesn't liking it [08:32] mzanetti, it was never meant to be like this (remember you're unlikely to see the startup at all) [08:33] mzanetti, the behavior was only there for when we expanded the categories, and we were doing it wrong anyway [08:33] Saviq: understood. thanks [08:33] mzanetti, this still valid https://code.launchpad.net/~mzanetti/unity/phablet-fix-ap-on-device/+merge/166084 ? [08:34] Saviq: yes [08:34] mzanetti, k, testing [08:34] Saviq: just because of this, tests still won't pass [08:34] Saviq: you also need dandraders autopilot_touch thingie [08:35] mzanetti, yup, k [08:35] Saviq: and your test run is likely to be interrupted by the screen going off [08:35] Saviq: bug for autopilot is opened [08:35] mzanetti, yeah, read that yesterday [08:43] mzanetti, https://code.launchpad.net/~saviq/unity/phablet.fix-run-device/+merge/166194 [08:44] \o/ [08:45] that separation was useless [08:45] yah [08:48] * mzanetti fixes phablet-run-tests [08:54] mzanetti, where do I get python-ubuntu-platform-api from? [08:55] Saviq: hmm... should be in our repo, isn't it? [08:55] Saviq: at least I didn't have to install it manually [08:55] Saviq: oh... maybe the autopilot ppa. I've added that one [08:55] mzanetti, k [08:56] mzanetti, yaeh [08:58] mzanetti, "/dev/uinput" cannot be opened for writing? [09:00] Saviq: oh yeah... need to chmod 666 it for now [09:01] mzanetti, k [09:05] mzanetti, shouldn't launch_test_local have app_type="qt", too? [09:05] Saviq: hmm... I don't know exactly why this is needed at all in the first place [09:06] Saviq: seems on the phone AP has troubles to detect its a qml app or somehting [09:06] Saviq: works fine on the desktop without it [09:06] mzanetti, I can't "make autopilot" on the device, fwiw [09:06] without that [09:06] Saviq: oh... right... didn't try that [09:06] Saviq: ok, in that case I'll add it [09:09] mzanetti, also, I'm not sure that -mousetouch is needed after all, /me checks [09:16] mzanetti, yeah, we should be able to get rid of -mousetouch for autopilot, let's wait what dandrader has to say [09:18] ok === alan_g is now known as alan_g|tea === alan_g|tea is now known as alan_g === mmrazik is now known as mmrazik|lunch [10:17] * mzanetti http://nooooooooooooooo.com/ [10:17] found tons of .po file changes somewhere in the middle of my last 10 commits [10:36] mzanetti, that's happened to me before too === tvoss is now known as tvoss|afk === MacSlow is now known as MacSlow|lunch === mmrazik|lunch is now known as mmrazik === dednick is now known as dednick|lunch === alan_g is now known as alan_g|afk [11:06] didn't paulliu's msgmerge thing get merged already? === alan_g|afk is now known as alan_g [11:20] tsdgeos, yeah, it did [11:21] tsdgeos, but mzanetti committed it earlier (because we're not using git :P) [11:21] ah :D [11:32] # Fatal error in Evacuation [11:32] # Allocation failed - process out of memory [11:32] huh? [11:42] mzanetti, where? [11:42] Saviq: I ran ./run_on_device and suddenly the phone turned off... I booted it again, ran it again and the shell crashed with this message [11:43] mzanetti, yikes [11:43] Saviq: then I ran it again and watched memory consumption => everything seems back to normal [11:43] mzanetti, sounds like something went wrong on the android side, I'd say [11:44] hmm... might be... not really sure how to reproduce [11:52] Saviq, """ Please go "wrap-and-sort" in the source tree while you're at it. """ <- what's that about? [11:52] dandrader, just execute wrap-and-sort [11:52] dandrader, it's a script that will wrap and sort debian/* [11:52] dandrader, it's in devscripts [11:52] if you don't have it already [11:54] Saviq, you sure you want this? http://paste.ubuntu.com/5713125/ [11:55] dandrader, interesting, it doesn't do that much here [11:56] dandrader, actually it does, just put python-evdev before "qml-phone-shell", then [11:56] Saviq, ok [11:56] and we'll run wrap-and-sort in a separate MR to clean it up [11:59] Will be back later. Have an appointment with an osteopath. === tvoss|afk is now known as tvoss [12:04] mzanetti, you might want to merge lp:~dandrader/unity/phablet_autopilotTouchOnly into your branch [12:04] Saviq: which one? the autopilot fix? [12:04] mzanetti, yes === alan_g is now known as alan_g|lunch [12:10] 1 [12:10] argghg, this new version of byobu... [12:11] anyhow - stacking bug in Windows - though it might be an entertaining read: http://randomascii.wordpress.com/2013/05/28/alttab-bug-worsened-by-ie-10-but-fix-found/ [12:41] Saviq: I fear the InputFilterArea is broken :/ [12:41] mzanetti, why's that? [12:42] Saviq: open the phone-app, then drag the launcher in and tap on a launcher item. the phone-app will the press too [12:42] Saviq: even though there is a InputFilterArea in between [12:42] Saviq: could it be that the IFA only filters MouseEvents but we're working with touchEvents now? [12:42] mzanetti, works fine here on image 138? [12:43] * mzanetti restores the factory image [12:43] mzanetti, we were always working with touch input, they're converted to mouse events inside Qt, if needed [12:44] brb [12:45] Saviq: works fine in image 140 too... broken with current trunk [12:49] mzanetti, this stuck or just started late 'cause of queues? http://s-jenkins:8080/job/unity-phablet-ci/1063/ ? [12:49] * mzanetti checks [12:49] mzanetti, I never know with the mediumtests runner http://s-jenkins:8080/job/generic-mediumtests-runner/1723/console [12:50] Saviq: mediumtests don't get stuck [12:50] (famous last words) [12:50] mzanetti, :D [12:50] Saviq: but no... this is normal... when writing results to xml file nothing is printed [12:50] mzanetti, k === jhodapp is now known as jhodapp|brb [12:52] Saviq: and finished [12:53] Saviq: anyways... IFA is indeed broken with latest trunk (not released yet) [12:53] mzanetti, /me checks === _salem is now known as salem_ === MacSlow|lunch is now known as MacSlow === mmrazik is now known as mmrazik|afk [13:06] mzanetti, I can't reproduce [13:07] Saviq: hmm... I just use run_on_device on current trunk and then open the phone-app and click on a launcher button that is on top of a dialer button of the phone-app [13:07] mzanetti, yes, nothing happens in the phone app for me [13:08] * mzanetti does a clean checkout of trunk to test [13:10] Saviq: I still can reproduce... using image 140 + trunk... maybe some combination with something that changed between 138 and 140 [13:10] mzanetti, ah, image 140, /me checks [13:10] mzanetti, might be that platform-api failed (there was some refactoring there) [13:11] Saviq: BUT: image 140 with the released shell does not show the issue... it must be the combination [13:11] mzanetti, in the mean time, just put an IFA to cover the whole screen, check if you can interact with the apps at all [13:12] Saviq: yeah.. I did already colored the IFA blue and tested explicitly in the blue area... === jhodapp|brb is now known as jhodapp [13:30] mzanetti, I just flashed 140, run_on_device and everything works fine here... === alan_g|lunch is now known as alan_g [13:32] Saviq: mzanetti you are right, if I have the greeter locked and the phone app in, all the events just go through [13:32] Saviq: mzanetti so I can dial a number blindly ;-) [13:32] mzanetti, with http://pastebin.ubuntu.com/5713374/ I can't interact with the app at all [13:32] sergiusens, through the greeter? [13:32] Saviq: works for me (as in: its broken) [13:33] Saviq: yeah, make sure the phone-app is on top, lock, and then just tap on the greeter [13:34] Saviq: mzanetti given that the greeter is not that useful (security wise), I am going to approve the release and log a bug for it... is that ok? [13:35] sergiusens: when interacting with the launcher it causes weirdness... not sure want to release that? === mmrazik|afk is now known as mmrazik [13:36] sergiusens, mzanetti, I can confirm through greeter [13:37] sergiusens, mzanetti but that's the same on stock 140 [13:37] sergiusens, mzanetti not specific to current trunk [13:38] mzanetti: well if its as Saviq says, it's already there [13:38] let me pull out another device [13:38] mzanetti: it's not a regression when compared to what already being delivered [13:40] sergiusens, a more important test: open phone app, pull launcher in, tap on gallery (near the right launcher edge) [13:41] sergiusens, do you get "7" entered? [13:41] sergiusens, that's what mzanetti reports, I can't reproduce [13:41] sergiusens, greeter is a 5 line fix [13:43] Saviq: want me to wait? We are getting into a mega release thing where we might never release [13:43] Saviq: if you can block all other happroves, I'll wait [13:44] Saviq: can reproduce you test on maguro [13:45] sergiusens, meaning you get the "7" entered? [13:47] Saviq: nope... but the launcher is a bit further from the 7 [13:47] Saviq: or my touch surface with my finger is too small :-) [13:47] sergiusens, yeah, you'd know [13:48] mzanetti: http://qt-project.org/wiki/Qt_Quick_Carousel#70b4903abcb62ace84264ad0443ae759 [13:48] sergiusens, must be something weird with mzanetti's device [13:48] mzanetti: I'm reading this. But if you have a better and easier workaround. [13:48] paulliu: https://gitorious.org/xbmcremote/xbmcremote/blobs/master/apps/harmattan/qml/MainPage.qml [13:48] line 88 [13:48] mzanetti: Please teach me that. [13:48] sergiusens, and yeah, I have a branch already, pushing [13:49] Saviq: ok, let's wait for that then [13:50] mzanetti: ok..thanks. [13:50] paulliu: basically what you do is not to add the string property to the ListElement but instead add some ID [13:50] mzanetti: ok. [13:50] paulliu: then, when you use it in your delegate, you not just call the role, but call model.translatedString(index) [13:51] Saviq: can you try my branch then? if that works for you I'm fine :D [13:51] mzanetti, your launcher branch? [13:51] Saviq: yes [13:51] mzanetti, will do in a sec, I'm in clean-flash-everything frenzy [13:52] Saviq: ok... linner is ready... bbiab [13:52] linner? ;) [13:52] I'm sure that's in the urban dict too === mzanetti is now known as mzanetti|food [13:56] sergiusens, btw, does -b clear /data already? or do I need phablet-tools from somewhere? [13:57] Saviq: -b clears everything [13:57] sergiusens, doesn't, here :/ [13:57] sergiusens, but maybe I don't have the most recent tools? [13:57] 0.13daily13.05.10ubuntu.unity.next-0ubuntu1 [13:58] Saviq: make sure you have the ppa enabled [13:58] sergiusens, which one :D [13:58] Saviq: ppa:phablet-team/tools [13:58] sergiusens, thanks [14:00] Saviq: I created bug #1185443 just in case [14:00] bug 1185443 in touch-preview-images "Events pass through when the greeter is locked" [Undecided,New] https://launchpad.net/bugs/1185443 [14:00] sergiusens, cheers [14:00] Saviq: I'll be waiting for the fix :-) [14:00] Saviq: my intention is to do an image build as soon as this lands [14:01] sergiusens, https://code.launchpad.net/~saviq/unity/phablet.greeter-filter/+merge/166262 [14:05] mzanetti|food, https://code.launchpad.net/~saviq/unity/phablet.greeter-filter/+merge/166262 when you're back [14:05] or anyone else, if they want it ^ [14:08] Saviq: I'll take it, want a distraction [14:09] greyback, please try and break it, i.e. make sure it doesn't regress [14:09] greyback, and also please check: start phone app, drag launcher in, tap on gallery - see if "7" is typed into the dialer [14:09] greyback, i.e. check if InputFilterArea works [14:10] Saviq: ok [14:13] kgunn, ping [14:13] Saviq: pong === salem_ is now known as _salem === _salem is now known as salem_ [14:15] sergiusens, phablet-flash is sideloading now? instead of pushing to the sd card? [14:15] Saviq: nope, it's pushing to the sdcard [14:15] Saviq: only happens after the wipe ;-) === mzanetti|food is now known as mzanetti [14:16] sergiusens, why does it block on "Deploying Ubuntu" then? [14:16] sergiusens, just waiting for adb to show up again? [14:17] Saviq: what version do you have installed? [14:17] sergiusens, 0.14-0ubuntu1~raring [14:19] hmmm... I'll need to check this... not supposed to be like that [14:25] sergiusens, problem - phablet-flash -b seems to have failed, so I'm left with just recovery on the device, there's no system zip anymore, how do I flash it now? [14:26] Saviq: how did it fail? [14:27] sergiusens, http://pastebin.ubuntu.com/5713540/ [14:28] * greyback needs a reboot, bbiab [14:28] Saviq: if you are in the recovery image [14:29] Saviq: then do adb push /home/michal/Pobrane/phablet-flash/140/raring-preinstalled-phablet-armhf.zip /sdcard/autodeploy.zip [14:29] Saviq: then adb reboot recovery [14:31] sergiusens, k thanks, no android side flashing anymore? [14:31] not through .zip at least? [14:33] Saviq: with -b it uses the .img files created for the android side [14:33] sergiusens, and we now have some smarts to update the android side (like hybris and friends?) another way? [14:34] Saviq: waiting for container flip [14:34] sergiusens, yeah, that's gonna help a lot [14:34] Saviq: going to be packaged === alan_g is now known as alan_g|tea [14:36] didrocks: "schedule: 0 2 * * 1-7" in cupstream2distro-config means that at 2am UTC a snapshot is taken and the stuff is dputed into the ppa defined in the stack? [14:36] bregma: just remembered actually - I don't think distro likes having UNRELEASED; in debian/changelog [14:36] bregma: shall I just make a new entry for saucy? [14:37] sergiusens, any reason why it would get stuck at "< waiting for device >"? other than no root privileges? [14:37] smspillaz, there some new magic about setting the changelog ot UNRELEASED for the autolander to do its thing [14:37] if things stayed the same, it would get unexciting [14:37] bregma: what's the magic that the autolander does with UNRELEASED ? [14:37] does it just prevent autolanding for a little bit ? [14:38] well, if I could explain it it would not appear as magic [14:38] it's documented here: https://wiki.ubuntu.com/DailyRelease/FAQ [14:38] bregma: so we don't know what it does, but we want it ? [14:38] ah [14:39] smspillaz, that change has an API change that will also break the Unity builds, so we'll want to coordinate taht [14:39] mzanetti, your branch is broken! [14:39] mmrazik: right [14:39] Saviq: define broken [14:39] mzanetti, launcher is transparent to input [14:39] didrocks: thanks [14:40] Saviq: but it happens with trunk too... at least here [14:40] mzanetti, checking right now, just reverted the merge [14:41] yw [14:42] mzanetti, nope, only in your branch [14:43] impossible [14:43] bregma: ah right, so the version needs to be bumped in debian/changelog and UNRELEASED; added [14:43] gotcha [14:43] Saviq: when doing what? [14:44] bregma: should be able to get that done within the next few days then, thanks for the tip [14:44] Saviq: I'm thinking you probably didn't update android-tools-adb and android-tools-fastboot [14:44] sergiusens, with -b [14:44] sergiusens, everything up to date here [14:44] (things got a bit messy on dist upgrade to saucy so I haven't been able to really focus on fixing that while I have some other uni stuff due) [14:45] Saviq: there's a bug in adb where the wait-for-device logic fails, hadn't tracked it down yet [14:45] sergiusens, k, that's fine, got my device back anyway, thanks a lot [14:46] Saviq: the version you are using of phablet-tools was prone to that... not sure why the latest wasn't picked up :-/ [14:49] mzanetti, http://pastebin.ubuntu.com/5713599/ [14:49] mzanetti, your IFA is 0-width [14:50] Saviq: but no joking... I can reproduce it with trunk too [14:50] anyways... lemme check your paste === alan_g|tea is now known as alan_g [14:52] mzanetti, with trunk + paste I get ======= blockInput: true width: 162 [14:52] Saviq: oh right... my local branch has the IFA fixed [14:52] mzanetti, and everything works [14:52] Saviq: thats how I noticed the issue in the first place... while fixing my branch [14:52] let me push [14:52] mzanetti, do [14:52] Saviq: done [14:55] mzanetti, your branch works finfe [14:55] fie [14:55] fine [14:55] even [14:55] mzanetti, bar for the fact that the launcher doesn't go away automagically [14:56] Saviq: right [14:56] * mzanetti fixes... then I guess the first round is ready for review [14:57] mzanetti, and please merge dandrader's TouchOnly into your ap fix [14:58] ack [15:00] mzanetti, is there supposed to be content in your phablet-pinlock branch? [15:00] mterry: oh... I moved it over to ~unity-team to enable nic to add blur stuff (which we gave up for now) [15:00] ah [15:01] mzanetti, I might want to steal some of your PAMification of the single-user case for another branch [15:02] mterry: feel free... btw. its ready for review (except everything blur related) so feel free to start making me fix things [15:03] Saviq: merged [15:08] mzanetti, cheers [15:08] MacSlow: pmcgowan was just double checking if notification bootstrap can go into the build....i can't see any reason of concern...you? [15:09] kgunn, no, it's fine, it's not used atm [15:09] kgunn, I'm still busy with GIconProvider and the expansion-test failing... [15:09] Saviq: thanks....that's what i understood [15:09] kgunn, so no news unfortunately on that front [15:10] MacSlow: Saviq he was mentioning some "old" discussion/concern on dependencies [15:10] MacSlow: ack...but that's snap decisions right? (e.g. round 2) [15:15] Saviq: apt-get update and get a new phablet-tools [15:15] sergiusens, cheers [15:16] mzanetti, if I were you, I'd try ppa:phablet-team/tools and go for a -b flash [15:17] mzanetti, it really feels like something's not flashed properly on your device [15:17] Saviq: ok... now that syncevo works I can do :D [15:17] mzanetti, ;) [15:17] sergiusens: btw... how far is the sync app? [15:17] mzanetti, yeah, didn't work for me on the N9 with DAViCal :/ [15:18] mzanetti, didn't try to fix yet [15:18] Saviq: hmm... I just used it with owncloud yet... but that claims to be standard CardDav [15:18] mzanetti: zero work yesterday... need to pick it up today [15:18] mzanetti, yeah, in theory davical should be same (been using it for CalDAV for a while now) [15:19] mzanetti: will have plenty of time tonight (it's sort of out of band) [15:19] mzanetti, but it failed on HTTP PUT from syncevo, so I'm expecting a failure on davical's side [15:19] mzanetti: but a nice excuse to familiarize myself with QML and the sdk [15:20] Saviq: might be... yes [15:20] sergiusens: awesome. keep me posted === jhodapp is now known as jhodapp|lunch [15:41] sil2100, ping [15:42] pong [15:43] sil2100, hey, have you had a chance to test that XIM ppa? [15:43] fginther, when ci_defaults change for a stack, do you need to do something special to get autolanding and CI tests to see the changes? [15:43] Not yet, but let me repoke you later, ok? [15:43] i changed raring to saucy for the friends stack and redeployed, but CI is using raring still [15:43] kenvandine, yes. we need to re-generate the jenkins jobs manually [15:43] sil2100, will do, thanks! [15:44] fginther, ah, can you please do that for friends? [15:44] kenvandine, will do [15:44] fginther, thanks [15:48] kenvandine, done [15:48] fginther, thx === mmrazik is now known as mmrazik|afk [16:02] sergiusens, we should be good to release after https://code.launchpad.net/~saviq/unity/phablet.greeter-filter/+merge/166262 lands [16:03] sergiusens, should be some 20mins tet [16:03] yet [16:18] paulliu: Saviq: FYI, I commented on this one: https://code.launchpad.net/~paulliu/unity/i18n/+merge/166287 [16:19] mzanetti, yeah, that's throw-away anyway [16:19] mzanetti, the strings need to come already translated from the backend [16:19] right... I just thought I share the possible ways of doing it... I'm sure you will need this again at some point [16:21] mzanetti, OTOH I assumed there was a problem with the "generate the model at runtime" [16:21] mzanetti, thought that's what you discussed with paulliu before [16:21] Saviq: might be... in that case I'd use the index approach [16:21] Saviq: no... the issue was that you can't use qsTr() in a ListElement at all [16:22] mzanetti, ah, read it properly now [16:33] Saviq: is it just me or does run_on_device build slower with ninja? [16:33] Saviq: I mean the initial build [16:34] mzanetti: I'm not sure how to get that index. Because it is section. [16:34] paulliu: oh... I see... [16:34] mzanetti: It goes into the ListView, and then come back. [16:35] paulliu: well... as Saviq said, its temporary... so fine with me... [16:35] mzanetti: ok [16:35] paulliu: note that its a "Comment", not a "Needs fixing" :) [16:37] Saviq: -b fixed my launcher \o/ === alan_g is now known as alan_g|dance === salem_ is now known as _salem === _salem is now known as salem_ === salem_ is now known as _salem === _salem is now known as salem_ === jhodapp|lunch is now known as jhodapp [18:03] mzanetti, good [18:22] Saviq: ok. ready: https://code.launchpad.net/~mzanetti/unity/phablet-folding-launcher/+merge/166000 [18:22] I'm off now. [18:42] sil2100: ping? [18:42] sil2100: https://code.launchpad.net/~mathieu-tl/cupstream2distro-config/saucy-misc-to-archive/+merge/166355 [18:54] cyphermox: looking in a moment! [19:09] sil2100: thx... anyway, I'm still largely on phone stuff [19:11] mzanetti, nice and round MR number :) === salem_ is now known as _salem [20:38] Saviq: I can't build unity 8's trunk [20:38] [ 56%] Building CXX object tests/qmltests/plugins/Unity/CMakeFiles/FakeUnityQml.dir/FakeUnityQml_automoc.cpp.o [20:38] [ 56%] Built target qml-phone-shell [20:38] that's all the error message I get [20:39] Linking CXX shared module libFakeUnityQml.so [20:39] [ 56%] Built target FakeUnityQml [20:39] make: *** [all] Error 2 [20:39] I ran ./build -s, then ./build, which is where I got this error [20:39] parent branch: bzr+ssh://bazaar.launchpad.net/+branch/unity/phablet/ [20:40] mhall119, try ./build -c to build from scratch [20:40] mhall119, or just drop builddir [20:40] mhall119, and the actual error is further up [20:40] -c got it past 56% anyway [20:41] 100% \o/ [20:43] Saviq: is there any way to run an app inside of unity running via ./run ? [20:43] mhall119, no, no support for X apps [20:44] mhall119, only possible on android atm, Mir support is in progress [20:44] ok === _salem is now known as salem_ === salem_ is now known as _salem === _salem is now known as salem_