| === thumper-afk is now known as thumper | ||
| thumper | wallyworld_: finally got the logging branch passing all the tests. | 01:38 |
|---|---|---|
| wallyworld_ | \o/ | 01:39 |
| thumper | last failures with the uniter tests where it is watching log messages and using a regex to match | 01:40 |
| thumper | to make sure hooks run | 01:40 |
| thumper | had me cringing on the inside | 01:40 |
| wallyworld_ | ah yes, i ran into that too | 01:41 |
| wallyworld_ | very hard to figure out the test failures | 01:41 |
| thumper | heh | 01:41 |
| thumper | yeah | 01:41 |
| thumper | https://code.launchpad.net/~thumper/juju-core/use-loggo/+merge/166611 is the work in progress, i'm just going to go through the diff and clean up anything that needs tweaking | 01:41 |
| thumper | wallyworld_: I see it is "land it friday" for your branches | 01:42 |
| wallyworld_ | yeah, 2 more to go if i can get the issues sorted | 01:42 |
| wallyworld_ | thumper: a quick read of the code - looks nice, what i would expect to see for logging. now, if only we had logger.Trace(....) and devs could juju set-env tracelevel to turn it on/off etc :-) | 01:46 |
| thumper | wallyworld_: we do have logger.Trace | 01:46 |
| thumper | and we should do a set-env | 01:47 |
| wallyworld_ | ah ok, sorry. didn;t see it in my quick look | 01:47 |
| thumper | wallyworld_: it is in launchpad.net/loggo | 01:47 |
| * wallyworld_ nods | 01:47 | |
| thumper | wallyworld_: we have loggo.ConfigureLogging | 01:47 |
| thumper | or | 01:47 |
| thumper | logger := loggo.GetLogger("juju.uniter.foo") | 01:48 |
| thumper | logger.SetLogLevel(loggo.TRACE) | 01:48 |
| thumper | INFO, DEBUG, WARNING, ERROR | 01:48 |
| wallyworld_ | cool | 01:48 |
| wallyworld_ | travel levels would be nice :-) | 01:48 |
| wallyworld_ | trace | 01:48 |
| wallyworld_ | not travel | 01:48 |
| * thumper nods | 01:48 | |
| thumper | we have them | 01:48 |
| thumper | by default not set though | 01:48 |
| thumper | and --debug | 01:48 |
| thumper | only sets juju to DEBUG | 01:49 |
| thumper | you'd need to use the configure logging to get trace | 01:49 |
| thumper | juju --log-config juju=TRACE magic | 01:49 |
| wallyworld_ | that's fine. i think trace is a set-env thing anyway | 01:49 |
| wallyworld_ | perhaps | 01:49 |
| wallyworld_ | thumper: hangout? | 01:54 |
| thumper | sure | 01:54 |
| * wallyworld_ starts one | 01:55 | |
| wallyworld_ | https://plus.google.com/hangouts/_/d3f48db1cccf0d24b0573a02f3a46f709af109a6 | 01:55 |
| bigjools | thumper: it's good to see you used loggo :) | 02:05 |
| thumper | bigjools: yeah, after both you and jam suggested it, i changed it | 02:19 |
| === tasdomas_afk is now known as tasdomas | ||
| === ChanServ changed the topic of #juju-dev to: https://juju.ubuntu.com | On-call reviewer: - | Bugs: 8 Critical, 71 High - https://bugs.launchpad.net/juju-core/ | ||
| dimitern | morning | 06:15 |
| fwereade | hey guys, guess what I did? dropped laura at school without her lunch :/ | 07:23 |
| fwereade | bbiab | 07:23 |
| === wedgwood_away is now known as wedgwood | ||
| === alexlist` is now known as alexlist | ||
| fwereade | ok, I can no longer kid myself I'm not sick, I'm going to sleep and hope it gives me strength enough to collect laura this pm (cath's worse :/) | 08:49 |
| fwereade | I'll probably drop by every so often 'cos I'm obsessive like that, but don;t count on it | 08:49 |
| TheMue | fwereade: ok. so get well soon and recharge yourself. | 08:54 |
| dimitern | fwereade: get well soon, both of you | 09:03 |
| dimitern | fwereade: ping | 11:38 |
| === wedgwood is now known as wedgwood_away | ||
| === wedgwood_away is now known as wedgwood | ||
| dimitern | jam: (if you're actually here) Thanks for the review! | 13:11 |
| dimitern | jam: very good suggestions, I'll update the proposal | 13:12 |
| TheMue | dimitern: will also take a look as i now need to have to take a step back from the provisioner stuff | 13:15 |
| dimitern | TheMue: cheers, I'll be updating it shortly with jam's suggestions | 13:15 |
| TheMue | dimitern: ok | 13:17 |
| teknico | marcoceppi_: hi, is this enough to propagate the DISPLAY env var in juju-test? http://pastebin.ubuntu.com/5719876/ | 13:29 |
| * TheMue grumps | 13:44 | |
| ahasenack | how can I get a help from the juju tools? Like relation-get --help? | 13:44 |
| TheMue | Whashing machine and daughters bike defect. | 13:44 |
| ahasenack | since they are not part of the juju package | 13:44 |
| ahasenack | and there is no manpage | 13:44 |
| dimitern | ahasenack: you can look in the code perhaps: worker/uniter/jujuc/relation-set.go | 13:47 |
| TheMue | dimitern, ahasenack: just wanted to give the same advice ;) | 13:47 |
| dimitern | TheMue: :) | 13:48 |
| ahasenack | ok | 13:48 |
| ahasenack | dimitern: that tip doesn't work for relation-list | 14:01 |
| ahasenack | worker/uniter/jujuc/relation-list.go doesn't help much | 14:02 |
| ahasenack | actually | 14:02 |
| ahasenack | it's the same | 14:02 |
| dimitern | ahasenack: oh? | 14:02 |
| ahasenack | there is no simple text template to copy from | 14:02 |
| ahasenack | have to look at flags and stuff | 14:02 |
| dimitern | mramm: kanban? | 14:02 |
| dimitern | ahasenack: --smart and -r are supported | 14:03 |
| === wedgwood is now known as wedgwood_away | ||
| === wedgwood_away is now known as wedgwood | ||
| * TheMue has to leave, will step in later again | 14:38 | |
| === tasdomas is now known as tasdomas_afk | ||
| === wedgwood is now known as wedgwood_away | ||
| === sidnei` is now known as sidnei | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!