| rick_h__ | alejandraobregon: ping, got a few min? | 11:49 |
|---|---|---|
| benji | morning all; I could use another review on this small branch that adds a copyright linter: https://codereview.appspot.com/10045046 | 11:54 |
| rick_h__ | benji: looking | 11:55 |
| rick_h__ | benji: why are some /** turned into /*? I thought /** was the rule? It's done in a few places not throughout. | 11:56 |
| benji | rick_h__: /** means "this is a yuidoc comment", many of those were (reflexively, I assume) marked as yuidoc when they were in fact just regular comments | 11:57 |
| rick_h__ | benji: oh, I didn't realize we were distinguishing a doc block vs a yuidoc. | 11:57 |
| rick_h__ | that sucks :/ | 11:57 |
| benji | (I just realized that that branch is about yuidoc linting, not copyright linting, but that's ok) | 11:58 |
| rick_h__ | yea, I was going to ask next about copyright :) | 11:58 |
| benji | rick_h__: well, it's more that yuidoc distingushes | 11:58 |
| rick_h__ | benji: forgive my comment there. Honestly, I just learned something new today. I never realized there was any YUIdoc diff between /** and /*. Honestly couldn't recall seeing /* used before | 12:41 |
| rick_h__ | benji: but it appears it's something always been supported, just I've never used and didn't realize was there. | 12:41 |
| rick_h__ | benji: never thought to distringuish 'types' of comments other than blocks/single line and caught me before my coffee today :) | 12:42 |
| benji | rick_h__: no worries | 12:42 |
| benji | heh | 12:42 |
| rick_h__ | /** type comments goes all the way back to my PHP days years and years :) | 12:43 |
| benji | I was out of coffee so I actually got up an hour before work to drive to the store to get coffee and heavy cream (which I have come to love in my coffee). | 12:43 |
| * rick_h__ revisits bcsaller's branch from last night as I think I ding'd him on some /* that might be legit after all | 12:44 | |
| benji | :) | 12:44 |
| benji | It goes to show just how diverse the programming world is that people with years of widely varried experience can still see things new. I guess it's one of the cool things about what we do. That and the arguments about naming things. ;P | 12:46 |
| jcsackett | jujugui: is uistage loading for anyone? i'm getting endless "connecting to environment". | 13:23 |
| * benji looks | 13:24 | |
| frankban | gary_poster: ready for the call when you want, no rush | 13:24 |
| gary_poster | thanks frankban, was in the depths of reviewing the UX stuff. about to join | 13:24 |
| benji | jcsackett: I see the same behavior as you. There is an error in the console that looks suspect: Uncaught TypeError: Cannot read property 'browser_enabled' of undefined | 13:25 |
| bac | jcsackett: i see 19ws://uistage.jujucharms.com:8081/wsWebSocket network error: The operation couldn’t be completed. Connection refused | 13:25 |
| gary_poster | bac, you on it? | 13:25 |
| bac | i. am. on. it. | 13:26 |
| bac | like stink on rice | 13:26 |
| rick_h__ | heh, who flipped sandbox in their commit :P | 13:26 |
| * rick_h__ hopes it wasn't him after that | 13:26 | |
| gary_poster | :-) | 13:29 |
| gary_poster | frankban, I | 13:29 |
| gary_poster | am looking at you :-) | 13:29 |
| frankban | gary_poster: rejoining | 13:30 |
| gary_poster | frankban, uh oh I can hear you | 13:30 |
| gary_poster | but nothing on my side | 13:31 |
| gary_poster | will try restarting, frankban | 13:31 |
| frankban | gary_poster: ok | 13:31 |
| BradCrittenden | benji: so uistage should be running against rapi, no? | 13:33 |
| === BradCrittenden is now known as bac | ||
| bac | i don't see where the rapi process is started | 13:34 |
| benji | bac: I think so | 13:34 |
| bac | and it sure ain't running. | 13:34 |
| benji | that could be it | 13:34 |
| bac | i'll start it by hand and hope | 13:34 |
| benji | there is probably a reason we don't run it in sandbox mode, but I don't know what that reason is :) | 13:34 |
| === gary_poster|away is now known as gary_poster | ||
| bac | hazmat: uistage was just down b/c there was no improv running. is there an init script for it? i've started it by hand for now. | 13:37 |
| bac | jcsackett: uistage should be good now | 13:41 |
| jcsackett | bac: you're my hero | 13:41 |
| bac | wow, low bar | 13:42 |
| teknico | bac: you're my hero too! ;-) | 13:42 |
| teknico | bac: I'd like your eyes on https://codereview.appspot.com/10020044/ , short'n'sweet | 13:42 |
| bac | http://www.youtube.com/watch?v=JsWgG5v7A3A | 13:43 |
| bac | teknico: did | 13:46 |
| gary_poster | "wow, low bar": lol | 13:47 |
| teknico | bac: thanks | 13:48 |
| hatch | morning | 13:50 |
| jcsackett | orangesquad: one sec, hangouts completely crashed this time. | 13:53 |
| benji | gary_poster: I have put the finishing touches on the vitals edit. Let me know when/if you want to discuss. | 13:53 |
| benji | I loved that show. | 13:54 |
| hazmat | bac, probably not | 13:54 |
| gary_poster | benji, ack thanks, will put something on cal so I don't forget | 13:55 |
| benji | k | 13:55 |
| === rogpeppe3 is now known as rogpeppe | ||
| * benji adds tags to reviews that people forgot to tag, with as little passive-aggressiveness as he can muster. | 14:03 | |
| gary_poster | :-) go for aggressive-aggressive. call out our names! you! there! in the blue shirt! | 14:04 |
| rick_h__ | I'm wearing grey today | 14:04 |
| benji | you know I'll do it | 14:04 |
| gary_poster | lol | 14:04 |
| benji | :) | 14:04 |
| teknico | it's blue but it's not a shirt, nice try :-P | 14:05 |
| gary_poster | heh | 14:05 |
| gary_poster | oh, and speaking of teknico | 14:06 |
| gary_poster | look, I'm late for our one on one! | 14:06 |
| teknico | right :-) | 14:06 |
| * gary_poster should just join when the alarm goes off | 14:06 | |
| * benji admires teknico's blue kilt. | 14:06 | |
| teknico | :-) | 14:06 |
| benji | I want a utilikilt: http://www.flickr.com/photos/7474015@N08/2439813854/ | 14:09 |
| rick_h__ | love that it's the guy with the beard wearing it | 14:10 |
| benji | :) | 14:13 |
| benji | gary_poster: when you get off your call I could use a reminder what the "scenarios" card is about. | 14:35 |
| gary_poster | benji, off call. which one? should we just go to guichat directly? :-) | 14:36 |
| benji | gary_poster: guichat it is | 14:37 |
| bac | gary_poster: did you see i added you to the GA account yesterday? | 14:53 |
| gary_poster | bac, yes thank you very much. have not logged ibn. should I? | 14:53 |
| gary_poster | in | 14:53 |
| bac | gary_poster: only if you're curious | 14:54 |
| gary_poster | cool | 14:54 |
| gary_poster | oh bac did you see the link jeff gave yesterday? | 14:54 |
| gary_poster | looking | 14:54 |
| bac | gary_poster: i've added some custom events to my local branch. unfortunately GA divides reports into basic things it shows in 'real time' and other stuff that lags but 12-24 hours. i think the events are in the latter. | 14:54 |
| bac | gary_poster: so it may take a while to get feedback to whether i'm doing it right or not | 14:55 |
| bac | gary_poster: i do recall jeff's link but didn't read it as i was addled | 14:55 |
| bac | will find it now | 14:55 |
| gary_poster | thanks | 14:55 |
| hatch | if you can't find it I should have it in my history | 14:56 |
| BradCrittenden | hatch: irclogs.ubuntu.com ftw | 14:57 |
| === BradCrittenden is now known as bac_ | ||
| hatch | aww man this is logged.... /me stops talking | 14:57 |
| hatch | I do well enough of making of an idiot of myself in person, I don't need help by irc logs lol | 14:58 |
| sinzui | abentley, do you have time review https://code.launchpad.net/~sinzui/charmworld/use-charm-model/+merge/167771 | 14:59 |
| abentley | sinzui: sure. | 15:00 |
| rick_h__ | jcsackett: hold off on anything else on that black bar please. I think I have some work with it here in my branch that might help once I figure it out | 15:03 |
| jcsackett | rick_h__: dig. i'll continue on search goofiness then. | 15:03 |
| rick_h__ | jcsackett: I'll verify 100% in a bit here, but I'm having problems with the active tab because of multi-dispatch and finding that the charm details gets drawn/destroyed/drawn again in a single page load | 15:03 |
| jcsackett | rick_h__: that jives with what i've seen, and is *very* likely the cause. | 15:04 |
| abentley | sinzui: the options property returns a dict, but in some cases, this is a permanent dict and in other cases it is temporary. This means that assignment (charm.options['foo']='bar') has undefined behaviour. Perhaps it would be better to create the options dict if it doesn't exist? | 15:04 |
| rick_h__ | jcsackett: yea, and I've got to fix that to get this tab loading to work as well. Hopefully two birds/one stone | 15:04 |
| jcsackett | rick_h__: i'm leaving the card on kanban in next as high/blocked. we'll delete it if you're work fixes it, and link your branch to the bug. | 15:05 |
| rick_h__ | jcsackett: rgr | 15:05 |
| sinzui | abentley, ! absolutely | 15:05 |
| sinzui | abentley, the model is read-only at this point and I don't see anything assigning to it in the code. I was expecting to allow changes when I make adjustments for ingest | 15:07 |
| abentley | sinzui: Sure, it's fine to address in a follow-up. | 15:08 |
| hatch | bcsaller: in yet? | 15:08 |
| bcsaller | hatch: almost | 15:09 |
| hatch | I see that your bind method takes a viewlet || array - when would I pass an array of viewlets in? | 15:09 |
| hatch | or do you want me to that? | 15:09 |
| hatch | (whenever you get in) | 15:10 |
| abentley | sinzui: what is the stringification at 136 doing? | 15:10 |
| sinzui | abentley, "lp:%s" % self.branch_spec | 15:11 |
| abentley | sinzui: My 136 is " 'revision': str(charm.last_change['revno'])," | 15:11 |
| sinzui | sorry, I am incompetent | 15:12 |
| abentley | sinzui: nm, the original is the same, so we can ignore it. | 15:12 |
| sinzui | it is just a accessor to the underlying dict | 15:13 |
| bac_ | hatch: thanks for the link. that is very cool. | 15:13 |
| hatch | no problemo sir | 15:13 |
| === bac_ is now known as bac | ||
| abentley | sinzui: Oh, it's because revno is an integer. | 15:15 |
| sinzui | that is right. | 15:15 |
| sinzui | abentley, we could always treat it as a string. We never use it as an int in ingest or views | 15:17 |
| abentley | sinzui: Maybe, but I hate to make a specific value more vague. | 15:18 |
| sinzui | abentley, I think this is the only case where we explicitly cast the revno to a str to ensure the json encoding delivers a string | 15:19 |
| abentley | sinzui: I think it's something we might fix in a future version of the API. | 15:20 |
| abentley | sinzui: r=me. | 15:21 |
| sinzui | thank you abentley | 15:22 |
| bcsaller | hatch: if changes to the model update more than one viewlet you can pass them all in. For example service overview, service config, service constraints are 3 viewlets bound to a single service, when it changes they have the potential to update. If however nothing in the services change event touched any of the bindings in one of those viewlets nothing should happen on its behalf | 15:22 |
| hatch | ok that's an excellent idea | 15:25 |
| * hatch refactors....again | 15:25 | |
| hatch | :P | 15:25 |
| bcsaller | hatch: if you need any adjustments let me know, I'm responding to the other review feedback now | 15:30 |
| hatch | bcsaller: I think that's the only one that "caught me off guard" | 15:30 |
| teknico | Makyo: ping | 15:33 |
| Makyo | teknico, Hey. | 15:33 |
| teknico | Makyo: time for a few questions in chat? | 15:34 |
| Makyo | teknico, Sure | 15:34 |
| gary_poster | rick_h__, are you planning to actually provide an official review of bcsaller's branch? Should he be waiting on an LGTM from you? | 15:37 |
| rick_h__ | gary_poster: yes, I was going to see if that was ok and helpful. I had two big questions if I recall. /me remembers last night | 15:38 |
| rick_h__ | and maybe they're just "rick doesn't get it" things | 15:38 |
| gary_poster | benji, I hadn't committed to be a true reviewer of ben's branch yet, which was why I had not signed up. I think maybe rick felt the same way. I am ok with being official reviewer now, though, so all's good :-) rick_h__ +1 on you being reviewer | 15:39 |
| benji | okk | 15:39 |
| rick_h__ | the polling on the polyfill, the key in the comment but not method arg, test passing in a node vs an object | 15:40 |
| teknico | bac: time for a quick hangout before the call? | 15:46 |
| bac | teknico: yes, give me a minute | 15:46 |
| teknico | bac: sure | 15:46 |
| rick_h__ | bcsaller: if you get a few min I'd appreciate a chat on routing with this issue I'm trying to get working. | 15:47 |
| bcsaller | rick_h__: I can hop on chat | 15:48 |
| rick_h__ | bcsaller: cool /me checks if guichat is clear | 15:48 |
| teknico | bac: https://plus.google.com/hangouts/_/02bb45411739e441fe107c9f66e2a8cc36ba4ba7?authuser=0&hl=en | 15:49 |
| teknico | (guichat is busy) | 15:49 |
| gary_poster | jujugui call in 10. kanban now please | 15:50 |
| bac | teknico: you're not there? | 15:50 |
| teknico | oops | 15:51 |
| teknico | I am now :-) | 15:51 |
| gary_poster | jujugui call in 1 | 15:59 |
| gary_poster | bcsaller, starting without you | 16:01 |
| BradCrittenden | i mean to mention: US-based people, tomorrow is free donut day at Krispy Kreme. (Offer not valid in CT or PR) :( | 16:14 |
| === BradCrittenden is now known as bac | ||
| gary_poster | lol | 16:16 |
| hatch | jcsackett: want to chat now? | 16:18 |
| hatch | it was camp day at Tim Hortons yesterday (where the $ goes to childrens camps) and some guy raged at the drive through people for asking for a donation | 16:19 |
| hatch | those people in the drivethrough were people from one of the radio stations | 16:20 |
| hatch | I bet you can figure what happened next :) | 16:20 |
| hatch | the worst part of refactoring is fixing the tests...I'm convinced | 16:34 |
| sinzui | orangesquad regarding bug 1187855, We are waiting for webops to deploy the new ES 0.90.0.release package. I think the beta package is below average | 16:57 |
| * hatch votes to fix the template compiler to --watch files for changes | 17:03 | |
| rick_h__ | hatch: thought it did. Which template isn't getting picked up? | 17:03 |
| hatch | my new one | 17:04 |
| hatch | I have to shut down the server and restart it | 17:04 |
| rick_h__ | hatch: what dir is it in? | 17:04 |
| hatch | the same as the rest of the templates | 17:04 |
| rick_h__ | ah, it lists the files to watch. a new one isn't in the list | 17:04 |
| hatch | ohh damn I missed that | 17:04 |
| rick_h__ | a single restart thogh to have it picked up should work | 17:04 |
| gary_poster | bcsaller, would you rather reply to my questions in rietveld or a call? | 17:04 |
| hatch | rick_h__: where is this list? | 17:05 |
| gary_poster | or do as much as possible in rietveld and then decide if a call is necessary? :-) | 17:05 |
| bcsaller | gary_poster: I was just getting to one that really could use a call, do you have a sec now? | 17:05 |
| gary_poster | sure bcsaller . trying jujugui | 17:05 |
| gary_poster | sorry everyone | 17:05 |
| gary_poster | I meant trying guichat | 17:06 |
| hatch | haha ^5 | 17:06 |
| rick_h__ | hatch: look at tempalte_dirs in config.js and how it's used in lib/templates.js | 17:06 |
| gary_poster | :-P | 17:06 |
| hatch | rick_h__: well the file was there | 17:07 |
| hatch | so it would have picked it up when it first started | 17:07 |
| sinzui | rick_h__, I updated the ES ticket explaining our need to get the new package soon. | 17:07 |
| hatch | but any changes required a serverrestart | 17:07 |
| rick_h__ | hatch: so line 207 there does the watching I believe | 17:08 |
| rick_h__ | sinzui: cool | 17:08 |
| hatch | rick_h__: yeah there is something wrong there | 17:08 |
| hatch | will have to investigate | 17:08 |
| hatch | when I have free time | 17:10 |
| rick_h__ | hatch: just imagine the time savings when you don't ahve to kill/restart :P | 17:10 |
| hatch | damn rights! | 17:10 |
| rick_h__ | hatch: so in looking at that code, it uses ifValidFile to determine if it should restart and that's only for files checked into bzr | 17:12 |
| rick_h__ | hatch: so make sure you bzr add the tempalte? | 17:12 |
| hatch | yeah it's in there...iunno I'll investigate later | 17:13 |
| rick_h__ | hatch: ok | 17:13 |
| hatch | I just wasted some time assuming that it was regening properly | 17:13 |
| jcsackett | hatch: you have a moment to chat? | 17:16 |
| hatch | I dew | 17:16 |
| hatch | guichat is busy sec | 17:17 |
| rick_h__ | hatch: http://paste.mitechie.com/show/962/ | 17:24 |
| hatch | hahaha | 17:24 |
| rick_h__ | hatch: I could have sworn I fixed that weeks ago, but that should fix it | 17:24 |
| hatch | annnnd fixed - thanks for taking the time :) | 17:25 |
| hatch | bcsaller: I am documenting the viewlets now - is the format for binding [ { name: 'modelFieldName', target: 'querySelectorString' } ] ? | 17:26 |
| bcsaller | hatch: I've added some docs around that to the binding engine, I can push the change in a second, but yes, the addition is that target can also be an array of selectors | 17:31 |
| hatch | alright I'll update my docs | 17:32 |
| benji | so many scenarios | 17:48 |
| hatch | does anyone know the jslint command to shut off this error... | 17:50 |
| hatch | The body of a for in should be wrapped in an if statement to filter unwanted properties from the prototype. | 17:50 |
| rick_h__ | hatch: heh, I broke down and put an if in there | 17:51 |
| hatch | ugh | 17:51 |
| hatch | to the googles! | 17:51 |
| rick_h__ | /*jshint -W089 */ | 17:51 |
| rick_h__ | hatch: http://jslinterrors.com/the-body-of-a-for-in-should-be-wrapped-in-an-if-statement/ | 17:51 |
| hatch | /*jshint forin: false */ | 17:52 |
| hatch | oh that didn't work | 17:52 |
| hatch | lol | 17:52 |
| rick_h__ | :P | 17:52 |
| hatch | unforunately the W089 didn't either | 17:54 |
| rick_h__ | hatch: try jshint --verbose xxx.js and see what code it spits out | 17:55 |
| hatch | app/views/view-container.js: line 252, col 16, Bad option. | 17:55 |
| hatch | /*jshint -W089 */ | 17:55 |
| rick_h__ | jshint --version? | 17:55 |
| rick_h__ | that's for 1.0+ | 17:55 |
| rick_h__ | hatch: and I've got 2.+ installed right now so assume it should work | 17:56 |
| hatch | lol | 17:56 |
| hatch | jslint --version $0.9.1 | 17:56 |
| hatch | er | 17:56 |
| rick_h__ | hatch: ah, this is jshint | 17:56 |
| hatch | jshint --version $0.9.1 | 17:56 |
| rick_h__ | ah, well upgrade that sucker :P | 17:56 |
| hatch | how the heck was it so old! | 17:57 |
| rick_h__ | hatch: with your computer...who knows :P | 17:58 |
| hatch | lol | 17:58 |
| hatch | hey I fixerd the 0.0.0.0 thing didn't I? :P | 17:58 |
| rick_h__ | lol, yay | 17:58 |
| hatch | aww crap it's still throwing that error | 17:59 |
| rick_h__ | you sure you're using the one that's upgraded? | 17:59 |
| rick_h__ | global install vs local install and all that? | 17:59 |
| rick_h__ | which jshint for instance | 17:59 |
| rick_h__ | `which jshint` that is | 17:59 |
| hatch | ahh | 17:59 |
| hatch | jshint is installed locally as well | 17:59 |
| hatch | and is locked to version 0.9.1 | 17:59 |
| hatch | "jshint": "0.9.1", | 17:59 |
| rick_h__ | ah, well then carry on the fight | 18:00 |
| hatch | ugh it refuses to install the new version | 18:05 |
| sinzui | rick_h__, your category info fix is now in production | 18:05 |
| rick_h__ | sinzui: very cool | 18:05 |
| rick_h__ | http://uistage.jujucharms.com/fullscreen/:flags:/browser_enabled/ to see it, open up some of the charm containers | 18:06 |
| rick_h__ | ha-proxy at least on the front page | 18:06 |
| rick_h__ | jcsackett: ping, got a sec? | 18:08 |
| jcsackett | rick_h__: sure. | 18:08 |
| * hatch crys .... I just want to commit my code! | 18:08 | |
| rick_h__ | hatch: then put the if in there :P | 18:08 |
| rick_h__ | jcsackett: invite on the way | 18:08 |
| hatch | rick_h__: hah I'd rather get it to install the proper jshint | 18:11 |
| bac | gary_poster: i just sent you an email showing a custom event | 18:17 |
| rick_h__ | jcsackett: http://paste.mitechie.com/show/963/ | 18:18 |
| hatch | I am getting a number of console logs saying "cannot create simulator" while running the tests | 18:28 |
| hatch | they still pass but I'm guessing those shouldn't be there? | 18:28 |
| hatch | ^ bcsaller | 18:28 |
| bcsaller | hatch: IIRC it tries to start on but would have failed on the 'sandbox' check, I think we can remove the warning now that we always try to make the object | 18:30 |
| hatch | alright | 18:31 |
| hatch | today is just not my day, now I can't even diff trunk from my branch t | 18:32 |
| hatch | benji: I can't seem to find my notes about the secret flag you told me about to create a proper diff | 18:35 |
| hatch | do you happen to remember what that was? | 18:35 |
| bcsaller | bzr diff -r ancestor:../trunk | 18:39 |
| bcsaller | hatch: ^ | 18:39 |
| hatch | that's it | 18:39 |
| hatch | thanks | 18:39 |
| hatch | ImportError: No module named tornado.ioloop | 18:42 |
| hatch | make: *** [test-misc] Error 1 | 18:42 |
| hatch | anyone seen that before? | 18:42 |
| rick_h__ | hatch: yes, check the hacking docs | 18:42 |
| rick_h__ | hatch: welcome to trunk :) | 18:43 |
| hatch | you're going to have to be more specific | 18:43 |
| hatch | :) | 18:43 |
| rick_h__ | bzr grep tornado | 18:43 |
| rick_h__ | :) | 18:43 |
| rick_h__ | teach a man to fish... | 18:43 |
| hatch | bzr doesn't have a grep command! | 18:44 |
| hatch | silly kid | 18:44 |
| rick_h__ | :/ | 18:44 |
| hatch | lol | 18:44 |
| rick_h__ | did I install that as a plugin? | 18:44 |
| hatch | you must have :) | 18:44 |
| rick_h__ | oh, guess I did | 18:44 |
| rick_h__ | handy bugger | 18:44 |
| rick_h__ | hatch: bzr branch lp:bzr-grep ~/.bazaar/plugins/grep | 18:45 |
| hatch | hmm | 18:46 |
| hatch | can't find anything in the docs | 18:46 |
| rick_h__ | it's in HACKING on trunk | 18:46 |
| rick_h__ | after you install the grep plugin you can bzr grep tornado to find all occurances of the word in the project which is darn helpful in finding things | 18:47 |
| hatch | I am just reinstalling python-tornado, see if that fixes it | 18:47 |
| bcsaller | gary_poster: on the GUI work spreadsheet where is the new canvas UX? Is that just under inspectors or is that later? | 18:49 |
| hatch | rick_h__ I must need to do a hard update on the repo - the only tornado stuff I have is it in the install docs in HACKING | 18:49 |
| gary_poster | bcsaller, "environment power tools" | 18:49 |
| hatch | sounds exciting :) | 18:49 |
| bcsaller | ah ha, that wasn't clear to me, I thought that was about debug logs and such | 18:50 |
| hatch | I was hoping for hammer drills and the like | 18:50 |
| gary_poster | bcsaller, https://blueprints.launchpad.net/juju-gui/+spec/servercloud-s-juju-gui-environment-power-tools fwiw | 18:51 |
| benji | sorry, hatch; I was lunching, but it seems you were taken care of | 18:51 |
| bcsaller | gary_poster: thanks, sorry to bother about it | 18:51 |
| gary_poster | np | 18:52 |
| hatch | benji: np :) thanks anyways | 18:52 |
| hatch | 2013/06/06 12:52:13 error: Failed to send patch set to codereview: diff is empty | 18:52 |
| hatch | *sigh* lol | 18:52 |
| hatch | doh | 18:53 |
| rick_h__ | hatch: right, ti's a new dep that was added and you have to apt-get install it per the hacking docs. | 18:57 |
| hatch | yeah I already did, but something must have messed up | 18:57 |
| hatch | thats why I was confused I was looking for some additional docs | 18:58 |
| hatch | haha | 18:58 |
| hatch | LF review https://codereview.appspot.com/10090045/ | 18:58 |
| rick_h__ | abentley: conflicts in your MP | 18:59 |
| abentley | rick_h__: I'm fixing them now. | 18:59 |
| hatch | rick_h__: have you picked up any games since you got your new machine? | 19:14 |
| rick_h__ | hatch: only been playing Left4Dead2 | 19:15 |
| rick_h__ | picked up HL2 but not messed with it | 19:15 |
| jcastro | HL2 ftw. | 19:15 |
| hatch | http://store.steampowered.com/app/237430/ looks like it might be good | 19:17 |
| hatch | and it's avail for linux | 19:17 |
| jcastro | I just got: http://store.steampowered.com/app/58610 | 19:20 |
| jcastro | it's pretty fun | 19:20 |
| hatch | cool | 19:21 |
| hatch | I hope that more people choose ubuntu for gaming - more gaming, more people, more quality apps | 19:21 |
| hatch | and boy do we need quality apps | 19:21 |
| rick_h__ | I've been really surprised how many people in my l4d2 games have been running linux | 19:22 |
| hatch | yeah? that's great | 19:23 |
| hatch | rick_h__: thx for the review...replying | 19:23 |
| hatch | at least I'm attempting to... | 19:24 |
| rick_h__ | hatch: cool, I guess would be nice at first glance to see what's the API vs what's over writeable vs what required to be set | 19:24 |
| rick_h__ | jcastro: that looks cool | 19:24 |
| hatch | rick_h__: you didn't happen to delete your comments? They were here....now it shows that there are comments but none are shown... | 19:25 |
| rick_h__ | hatch: not that I'm aware of :/ | 19:25 |
| rick_h__ | hatch: in the email I guess? | 19:25 |
| rick_h__ | wtf..where did it go? | 19:25 |
| hatch | oh good it's not there for you too | 19:26 |
| hatch | heh I thought I was going mad | 19:26 |
| rick_h__ | ok, wtf. tried to LGTM again and no go | 19:26 |
| hatch | hmm ok well maybe I'll take lunch now and hopefully it'll fix itself | 19:27 |
| rick_h__ | hatch: ok, so if I click the link in the email it loads correctly | 19:27 |
| rick_h__ | hatch: k, I'm going to EOD, have fun and hope it fixes itself as well :) | 19:27 |
| hatch | alrighty, have a good night | 19:27 |
| rick_h__ | lawn mowing time yay me | 19:28 |
| gary_poster | weird | 19:28 |
| hatch | yay! | 19:28 |
| gary_poster | comments in reviews not working for me either | 19:28 |
| gary_poster | bcsaller, only important one lost so far: | 19:28 |
| gary_poster | 92 if (typeof binding === 'string') { | 19:28 |
| gary_poster | 93 binding.target = [binding.target]; | 19:28 |
| gary_poster | 94 } | 19:28 |
| gary_poster | 92 should be binding.target I suspect | 19:28 |
| rick_h__ | and boom https://twitter.com/mjg59/status/342720383897718784 | 19:29 |
| * rick_h__ runs away after bomb dropping | 19:29 | |
| bcsaller | ahh, thanks, added back in better base class checking around model/modellist as well | 19:29 |
| * benji opens his arms and embraces the shockwave. | 19:30 | |
| hatch | tl;dr; | 19:30 |
| hatch | it wouldn't be the first time someone got something wrong in a paper :P | 19:31 |
| benji | snake_case (as the ruby guys call it) is easier to read | 19:31 |
| hatch | harder to type | 19:31 |
| benji | hatch: have you seen the meta study that shows that 50% of published medical results are not reproducable; kinda scary | 19:32 |
| hatch | haha I have not...but wow | 19:32 |
| abentley | orangesquad: Could you please review https://code.launchpad.net/~abentley/charmworld/api-2-maybe/+merge/167830 ? | 19:53 |
| * sinzui looks | 19:54 | |
| sinzui | abentley, on line 81 I see | 20:20 |
| sinzui | self._charm_result(charm, None, None) | 20:20 |
| abentley | sinzui: Right. API2 reimplements charm_result so that it doesn't retrieve provides/requires, which API2 doesn't need. | 20:21 |
| sinzui | I think (from the diff) that API2._charm_result() has no call sites that use the second and third arg. Shouldn't the method just accept a charm? | 20:21 |
| abentley | sinzui: It would be harder to test if API2._charm_result and API1._charm_result had different call signatures. | 20:22 |
| sinzui | ah! | 20:22 |
| sinzui | thank you. I put too much thought into this. I should have asked you sooner | 20:23 |
| abentley | sinzui: I could make them optional parameters for API2. | 20:23 |
| sinzui | abentley, please do. That is my only request. The tests were clear | 20:24 |
| BradCrittenden | gary_poster: if you look at the real-time events, there are now a bunch of them. i left a browser open with the event simulator running, so it pumped out a bunch. | 20:26 |
| === BradCrittenden is now known as bac | ||
| gary_poster | cool bac, looking | 20:26 |
| abentley | sinzui: Thanks for the review. | 20:28 |
| gary_poster | bac, but still no way to see the data we want to see till tomorrow, right? | 20:28 |
| bac | i think not | 20:28 |
| hatch | bcsaller: I was under the impression that show/hide set the visibility style not the display style | 20:36 |
| * bcsaller checks | 20:37 | |
| hatch | nope looks like you were correct | 20:37 |
| hatch | bcsaller: so is your branch ready to merge in? | 20:46 |
| hatch | or do you need another review? | 20:46 |
| bcsaller | I think so, but I don't have the +2 I need | 20:46 |
| bcsaller | gary_poster: ^^? :) | 20:47 |
| gary_poster | bcsaller, working on it. sorry, wife left me home with children to take cat to vet | 20:47 |
| bcsaller | gary_poster: ahh, no pressure. I'd suggest you make sure you're on the current rev in any case | 20:49 |
| gary_poster | will look in a sec. almost done bcsaller | 20:49 |
| hatch | gary_poster: you need some of these http://4.bp.blogspot.com/_li5GG5WIrnA/TReO3oBwivI/AAAAAAAACRE/Zl_IGQ6TdgI/s400/Playgro-Child-Harness-Wrist-Strap_lij9ph.jpg | 20:49 |
| hatch | :D | 20:49 |
| gary_poster | hatch :-P wouldn't help :-) | 20:50 |
| hatch | lol | 20:50 |
| hatch | annnnd submitting | 20:58 |
| gary_poster | bcsaller, lgtm thank you | 21:05 |
| abentley | rick_h__: Is http://staging.jujucharms.com/api/2/charms/interesting fast enough? | 21:05 |
| hatch | niiiiice | 21:08 |
| hatch | sure beats the 7s it was before eh? ;) | 21:08 |
| hatch | has anyone see the jenkins error? | 21:09 |
| hatch | looks like another one was auto started again | 21:12 |
| hatch | i'll keep an eye on it | 21:14 |
| hatch | O K so what's next | 21:24 |
| hatch | we should probably merge them together | 21:25 |
| rick_h__ | abentley: cool, 1.5s and less in checking it out | 21:26 |
| abentley | rick_h__: Cool. I'll move "charms/interesting takes too long to retrieve" into Deployment/Ready. | 21:29 |
| rick_h__ | abentley: rgr, do we still have a card for looking into caching? I still think we can cache it for the 15min import cycle and get that way down sub 1s | 21:29 |
| rick_h__ | abentley: but that's icing on the cake at this point | 21:30 |
| abentley | rick_h__: No, we have a card for "it's not fast enough". If it's not fast enough, then I'll move the card back to Next. | 21:30 |
| hatch | bcsaller: we should probably chat to plan the next step | 21:34 |
| bcsaller | hatch: agreed, just submitted databindings | 21:35 |
| bcsaller | well... its still running | 21:35 |
| hatch | guichat? | 21:35 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
