| === lifeless_ is now known as lifeless | ||
| === Guest63061 is now known as StevenK | ||
| lifeless | so, whos up for kicking bug mangler Tobias B ? | 02:21 |
|---|---|---|
| wgrant | I've fixed those and emailed him | 02:27 |
| wgrant | If he continues, a suspension will swiftly follow. | 02:27 |
| StevenK | wgrant: I'm confused. The test that fails is actually firing an event which ends up tossing an exception that is caught and then returns false. That code path for the event framework is not called for 3.10.2, so there is no exception, therefore the function returns true. | 02:58 |
| wgrant | StevenK: Have you traced through it in both versions? | 03:01 |
| StevenK | There is a maze of event functions, but I set a breakpoint on the line that causes the exception in 3.9.1, and it doesn't get hit in 3.10.2 | 03:03 |
| StevenK | wgrant: The fire() function in 3.10.2 looks very very different -- in 3.10.2, the call to getSiblings() (which is what dies horribly in 3.9.1) is guarded by this._hasSiblings | 03:17 |
| wgrant | StevenK: You'll probably want to step through it and work out what's going wrong. | 03:22 |
| StevenK | http://pastebin.ubuntu.com/5737687/ fixes it in 3.10.2 | 03:22 |
| wgrant | What does it mean? | 03:24 |
| wgrant | Shouldn't the response always have an event_key? | 03:24 |
| StevenK | Ah, but this test is for malformed data | 03:25 |
| StevenK | Which only has { something: 6 } and no event_key | 03:25 |
| wgrant | Y.fire behaves differently in the face of undefined? | 03:26 |
| StevenK | Yes, it fails to find silblings in 3.9.1, hence tosses an error | 03:28 |
| StevenK | It doesn't look for silblings in 3.10.2 and so behaves | 03:28 |
| wgrant | Can you see the rationale for the change? | 03:31 |
| StevenK | wgrant: Based on a quick Googling, it is make fire() more performant | 03:47 |
| wgrant | StevenK: What's the intent of the test? | 03:49 |
| StevenK | wgrant: That manager.sucessPoll() with that responseText returns false | 03:51 |
| wgrant | StevenK: Oh, so it catches the exception, right. That diff sounds OK, then | 03:53 |
| StevenK | Well, in fact it fires a namespace.longpoll_fail_event with the exception, so maybe mine should do the same too | 03:54 |
| StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/add-yui-3.10.2/+merge/167689 | 05:49 |
| wgrant | StevenK: Can you remove the try/except? | 05:51 |
| wgrant | Surely that check will work for 3.9.2 as well | 05:51 |
| wgrant | Or are there other potential errors? | 05:51 |
| wgrant | 3.9.1 | 05:51 |
| StevenK | wgrant: Just in case there are other errors, like failure to decode | 05:51 |
| wgrant | StevenK: Would it be better to just throw an exception rather than duplicating the failure firing? | 05:52 |
| StevenK | Oh | 05:53 |
| StevenK | Could do that | 05:53 |
| StevenK | wgrant: http://pastebin.ubuntu.com/5737890/ | 05:57 |
| wgrant | StevenK: Do we prefer to throw strings or objects (eg. Error)? | 06:09 |
| StevenK | wgrant: I see evidence of both, even in the same JS files | 06:11 |
| wgrant | Yay | 06:11 |
| StevenK | lib/lp/registry/javascript/timeline.js: throw new Error("resize_frame must not be empty."); | 06:11 |
| StevenK | lib/lp/registry/javascript/timeline.js: throw "Invalid y_align argument: " + y_align; | 06:11 |
| wgrant | Yayer | 06:12 |
| StevenK | 38 for Error and kin, 11 for bare strings | 06:13 |
| StevenK | wgrant: Diff updated | 06:23 |
| wgrant | StevenK: k | 06:26 |
| StevenK | wgrant: So, launchpad.Edit for DAS. | 06:27 |
| StevenK | wgrant: Shall I use launchpad.Moderate or so then? | 06:28 |
| wgrant | Moderate might work indeed | 06:28 |
| wgrant | In other news, person has too many FKs referencing it. | 06:28 |
| StevenK | News at 11 | 06:29 |
| wgrant | Somewhere around 200 | 06:29 |
| StevenK | wgrant: http://pastebin.ubuntu.com/5737952/ | 06:37 |
| wgrant | StevenK: Sounds reasonable | 06:40 |
| === tasdomas_afk is now known as tasdomas | ||
| StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/das-setchroot-api/+merge/167464 | 06:47 |
| wgrant | StevenK: That docstring is not good. "Set the chroot tarball used for builds in this architecture. The SHA-1 checksum must match the chroot file.", maybe. | 06:50 |
| wgrant | That even lets you format the docstring legally. | 06:51 |
| wgrant | Otherwise that looks OK, except for the file upload bits, but not much we can do about that because lazr.restful and Zope. | 06:51 |
| StevenK | Oh, do you want the XXX there like the other callsites to that horrible method that I will hopefully pay for in blood one day? | 06:52 |
| wgrant | That would be nice. | 06:54 |
| StevenK | wgrant: ... That I add the XXX, or pay in blood for that horrible method? Both? | 06:55 |
| wgrant | Both would be ideal. | 06:55 |
| StevenK | http://pastebin.ubuntu.com/5737987/ | 06:57 |
| wgrant | Docstring should be formatted correctly. | 06:57 |
| StevenK | wgrant: http://pastebin.ubuntu.com/5737994/ | 06:59 |
| wgrant | Right. | 06:59 |
| StevenK | wgrant: Diff updated | 07:06 |
| wgrant | StevenK: r=me | 07:08 |
| StevenK | wgrant: Thanks | 07:10 |
| === Guest60046 is now known as mars | ||
| === BradCrittenden is now known as bac | ||
| === gary_poster|away is now known as gary_poster | ||
| === wedgwood_away is now known as wedgwood | ||
| === BradCrittenden is now known as bac_ | ||
| === bac_ is now known as bac | ||
| === BradCrittenden is now known as bac | ||
| === tasdomas is now known as tasdomas_afk | ||
| === daker_ is now known as daker | ||
| === BradCrittenden is now known as bac | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === wedgwood is now known as wedgwood_away | ||
| === wedgwood_away is now known as wedgwood | ||
| === wedgwood is now known as wedgwood_away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!