| === chriadam_ is now known as chriadam | ||
| zsombi | good morning folks! | 05:48 |
|---|---|---|
| === davidcalle_ is now known as davidcalle | ||
| om26er | gusch, Hi! | 07:40 |
| gusch | om26er: hi | 07:40 |
| om26er | gusch, how do I run the unit tests of the gallery ? | 07:41 |
| gusch | om26er: one way is to run "make test" | 07:41 |
| om26er | gusch, and the other way ? | 07:42 |
| gusch | om26er: or you can run then individually, by just calling the executables in tests/unittests/*/ | 07:42 |
| === chriadam is now known as chriadam|away | ||
| oSoMoN | gusch: I have addressed all your comments in my MR, would you mind having a second look? | 09:28 |
| gusch | oSoMoN: ok | 09:28 |
| gusch | oSoMoN: I approved - waiting for jenkins for top approving | 09:33 |
| oSoMoN | gusch: thanks | 09:35 |
| oSoMoN | gusch: note that because of a bug in the CI job, the tests that are run are those from the latest package in the daily PPA, not those from the branch being reviewed, which is pointless… | 09:41 |
| oSoMoN | gusch: I’m trying to resolve that | 09:42 |
| oSoMoN | gusch: in the meantime, if you could run the autopilot tests for my branch locally, just to confirm that they pass, it’d be nice | 09:42 |
| gusch | oSoMoN: ok | 09:42 |
| gusch | oSoMoN: the tests run fine - you can top approve once you fixed the jenkins issue | 09:48 |
| oSoMoN | gusch: ok, thanks | 09:48 |
| oSoMoN | om26er: just sent you an e-mail with a rather urgent matter, can you please have a look at it some time today? | 09:56 |
| om26er | oSoMoN, read the email, I am looking into that | 09:57 |
| oSoMoN | om26er: thanks | 09:58 |
| oSoMoN | gusch: considering that I don’t know when the jenkins issue will be fixed (afaict the issue has been around for quite some time, affecting all incoming MRs), and that both you and me verified that autopilot tests pass locally, I’m very tempted to top approve now, would you object to it? | 10:11 |
| gusch | oSoMoN: I'm fine with that | 10:11 |
| gusch | oSoMoN: jenkins will anyway object if something is wrong ;) | 10:11 |
| oSoMoN | gusch: thanks, I’m going ahead then | 10:14 |
| kalikiana | Mirv, do we have an eta for qt 5.1? there's a bug fix very relevant for u1db-qt in there | 10:52 |
| Mirv | kalikiana: 5.1 beta1 is available at qt5-beta-proper PPA, but the current plan is not to upgrade to 5.1 very soon since it might involve all kinds of regressions. I'd recommend filing a bug against the component and backporting the bug fix to 5.0.2 - there's already a lot of patches in eg. qtdeclarative from 5.1 | 10:57 |
| Mirv | possibly | 10:58 |
| Mirv | the 5.1.1 release timeframe would be about the time to consider switching | 10:58 |
| Mirv | if 5.1 is needed for developing new features or such, the PPA can be used to develop those in a branch | 10:59 |
| kalikiana | Mirv, there's a bug already and a qt review with the patch, should I assign that to you to have a look? | 11:03 |
| Mirv | kalikiana: yes, please | 11:08 |
| Mirv | or just a link | 11:08 |
| kalikiana | Mirv, https://bugs.launchpad.net/u1db-qt/+bug/1181359 | 11:09 |
| ubot2` | Ubuntu bug 1181359 in U1DB Qt/ QML "Documents: Integers are getting corrupted" [Undecided,Confirmed] | 11:09 |
| kalikiana | and https://codereview.qt-project.org/#change,56072 (also referenced in the qt bug) | 11:09 |
| === MacSlow is now known as MacSlow|lunch | ||
| Mirv | kalikiana: thanks, looking | 11:21 |
| === odra is now known as odraencode | ||
| gusch | https://code.launchpad.net/~schwann/gallery-app/gallery-remove-directory-includes/+merge/167702 | 11:35 |
| gusch | https://code.launchpad.net/~schwann/gallery-app/gallery-medialoader/+merge/167722 | 11:35 |
| gusch | https://code.launchpad.net/~schwann/gallery-app/gallery-photo-dependency-reduce/+merge/167741 | 11:36 |
| gusch | pending MRs ^ oSoMoN tmoenicke (where is renato?) | 11:36 |
| oSoMoN | gusch: I guess he’ll be online soon | 11:38 |
| oSoMoN | gusch: what’s the rationale behind removing the directory includes in favour of adding those directories to the include paths? | 11:40 |
| gusch | oSoMoN: to make the dependencies more visible | 11:43 |
| gusch | oSoMoN: there is a total dependency hell inside of gallery atm - that makes it hard to add new stuff (video) | 11:43 |
| oSoMoN | gusch: I’m skeptical that this will help, but I don’t have a strong opinion against it either, so I’ll verify that it doesn’t break anything, and I’ll approve | 11:45 |
| gusch | oSoMoN: thx | 11:49 |
| gusch | oSoMoN: and it did help already in MR 2 and 3 ;) | 11:49 |
| Kaleo | sorry folks, emergency called | 12:04 |
| zsombi | Kaleo: sorry dude, 10th of June is not good for me I'm "OoO" that day.. would it be possible to schedule it for some other day? | 12:18 |
| Kaleo | you are going to ask the organizer | 12:20 |
| zsombi | Kaleo: ouh, I thought it was you, I got it from you... | 12:21 |
| Kaleo | zsombi: I only added you to the invite | 12:21 |
| Kaleo | :) | 12:21 |
| zsombi | Kaleo: ehh, stupid gugel... :) | 12:22 |
| Kaleo | loicm: hi | 12:26 |
| === MacSlow|lunch is now known as MacSlow | ||
| === greyback is now known as greyback|food | ||
| loicm | Kaleo: hey | 12:42 |
| odraencode | Hey people :D | 12:42 |
| oSoMoN | gusch: when you build the gallery app locally, you do it out of source, right? | 13:01 |
| gusch | oSoMoN: mostly - only at the end for autopilto I compile it in source | 13:02 |
| gusch | oSoMoN: you mean I should update the .bzrignore? that's on my list ... | 13:02 |
| oSoMoN | gusch: not, that’s not what I meant, I only wanted to test in a different way than the one you usually do, to ensure no regressions in both cases | 13:09 |
| oSoMoN | gusch: although updating the .bzrignore list would also be nice :) | 13:09 |
| === hatchetation_ is now known as hatchetation | ||
| === schwann is now known as gusch | ||
| oSoMoN | gusch: man, I hadn’t realized there was so much C++ code in the gallery :/ | 13:30 |
| oSoMoN | gusch: I made two comments on your MR | 13:30 |
| gusch | oSoMoN: 42 cpp files in src ;) | 13:30 |
| gusch | oSoMoN: ok - thx I'll have a look | 13:30 |
| === greyback|food is now known as greyback | ||
| === mardy_ is now known as mardy | ||
| oSoMoN | gusch_: do you have a plan to get rid of circular dependencies in the gallery app? | 14:08 |
| gusch_ | oSoMoN: slowly I want to reduce them - one by one | 14:09 |
| gusch_ | oSoMoN: will take a while and several iterations | 14:09 |
| oSoMoN | gusch_: good, no rush, but definitely something to keep on the radar | 14:09 |
| oSoMoN | gusch_: got a MR for you to review when you have a moment (making webbrowser autopilot tests more robust): https://code.launchpad.net/~osomon/webbrowser-app/autopilot-more-robust/+merge/167770 | 14:31 |
| gusch_ | oSoMoN: ok | 14:32 |
| seb128 | hey | 15:38 |
| seb128 | does any of the current list items allow to have an item with 2 labels, one aligned on the left and one on the right? | 15:39 |
| seb128 | I looked at http://developer.ubuntu.com/api/ubuntu-12.10/qml/mobile/overview-ubuntu-sdk.html#list-items and it doesn't seem so (out of putting custom widgets in a Base one) | 15:39 |
| seb128 | would that make sense as a standard item? | 15:40 |
| seb128 | or rather that 2 labels, 2 widgets, or a label and one widget | 15:41 |
| seb128 | that comes often enough in the design of the settings app, e.g https://wiki.ubuntu.com/AboutThisDevice#Phone the Serial/IEMI/OS lines | 15:42 |
| seb128 | or https://wiki.ubuntu.com/Networking#phone-wifi | 15:42 |
| seb128 | the wifi on/off | 15:42 |
| seb128 | or https://wiki.ubuntu.com/Sound#Phone the Ringtone line which is "Ringtone ...... <name of the sound>" | 15:43 |
| kalikiana | seb128, check the ui toolkit gallery/ list items/ value selector | 15:45 |
| kalikiana | that looks maybe like what you need? | 15:45 |
| kalikiana | in ubuntu-ui-toolkit-examples if you don't have it installed | 15:46 |
| seb128 | kalikiana, looking to the documentation that seems to have a list of value and select one, with an expander | 15:48 |
| seb128 | which is not especially what I want | 15:48 |
| seb128 | some items are just like | 15:48 |
| seb128 | |Version: 1.0| | 15:48 |
| seb128 | where Version is left aligned and 1.0 right aligned | 15:48 |
| kalikiana | seb128, taking the ringtone example you would pick out of a choice of tunes wouldn't you? | 15:52 |
| seb128 | kalikiana, the design is that clicking on it should pop another page | 15:52 |
| seb128 | not open a subsection inline | 15:52 |
| seb128 | pop->push rather | 15:52 |
| seb128 | kalikiana, sorry, got disconnected | 15:57 |
| seb128 | the value selector doesn't seem to do what I need | 15:57 |
| seb128 | well there are several cases there | 15:57 |
| kalikiana | seb128, so basically it has the looks but you'd need a property like "page: myTuneSelection" | 15:58 |
| seb128 | there is "label ...... value" "label ...... value >" "label ...... <switch>" | 15:58 |
| seb128 | those are the 3 I can see | 15:58 |
| seb128 | seems like they could fit in a label + widget + status progression: true/false | 15:59 |
| seb128 | kalikiana, doing the page push on click is not the issue ... in fact I've no issue, I can do those just fine with packging stuff in a ListItem.Base | 16:00 |
| seb128 | but I was wondering if that's a common enough case to justify a toolkit widget rather than a custom | 16:01 |
| odraencode | Hey | 16:03 |
| odraencode | Why nobody ever says hi to me? | 16:04 |
| kalikiana | seb128, the main reason I would consider it would be that I think you need some arbitrary tweaks to get the looks right, valueselector is more than subclassing and adding the expanding | 16:04 |
| kalikiana | seb128, so if it's 10 apps doing those same tweaks and using magic values consistency is about gone | 16:05 |
| seb128 | why would app need to tweak the look of those more that the one of other list items in the toolkit? | 16:06 |
| kalikiana | seb128, at a glance I saw that valueselector uses an image and some internals | 16:08 |
| kalikiana | feel free to prove me wrong :-) | 16:08 |
| kalikiana | if that's not strictly needed I'd just do it in the app | 16:08 |
| seb128 | ok, I'm happy to do it in the app | 16:08 |
| seb128 | it's just that Kaleo said at the oakland sprint to talk to the SDK teams when we have common patterns/widgets | 16:09 |
| seb128 | to see if those should be the toolkit | 16:09 |
| seb128 | so that's what I was doing | 16:09 |
| seb128 | seems like it doesn't interest you guys in this case, fine enough, I will keep packaging my 2 labels in a ListItemBase and tweak the anchors | 16:09 |
| kalikiana | seb128, well, certainly I'm not the linus of the uitk ;-) I have no idea how many apps may need this exact same component | 16:11 |
| kalikiana | can't hurt to file a feature suggestion once you have written it, which you will do anyway | 16:12 |
| kalikiana | suggesting existing new widgets is always useful | 16:12 |
| gusch_ | oSoMoN: I fixed your comment - only waiting for jenkins | 16:25 |
| gusch_ | renato__: would you mind reviewing this? https://code.launchpad.net/~schwann/gallery-app/gallery-medialoader/+merge/167722 | 16:27 |
| oSoMoN | gusch_: approved | 16:37 |
| * oSoMoN EOD | 16:38 | |
| gusch_ | renato__ tmoenicke would you mind reviewing this? https://code.launchpad.net/~schwann/gallery-app/gallery-medialoader/+merge/167722 and or https://code.launchpad.net/~schwann/gallery-app/gallery-photo-dependency-reduce/+merge/167741 | 16:45 |
| Kaleo | seb128: you should check with the design team | 17:16 |
| Kaleo | seb128: in the person of calum | 17:16 |
| Kaleo | seb128: he will tell you if a) the design you were given is justifiably not using an existing pattern b) or if the existing pattern should in fact be adjusted for your case c) or if your case should be adjusted to using the pattern | 17:18 |
| Kaleo | pattern == widget | 17:18 |
| odraencode | :/ | 17:19 |
| odraencode | Srsly, nobody says hi to me? | 17:19 |
| Kaleo | hi odraencode ! | 17:20 |
| odraencode | FINALLY! | 17:20 |
| odraencode | Hello there Kaleo | 17:20 |
| Kaleo | odraencode: people are probably deep in there codfe :) | 17:20 |
| Kaleo | code* | 17:20 |
| odraencode | Kaleo: I have been here for six hours waiting someoen to say hi | 17:20 |
| Kaleo | odraencode: I hope you did other things in the meantime | 17:21 |
| odraencode | Kaleo: Yes. I made a few videos of my project :u | 17:21 |
| odraencode | Kaleo: And linked them to random people on IRC | 17:21 |
| odraencode | Kaleo: I like to think that was productive. | 17:21 |
| Kaleo | odraencode: good | 17:21 |
| Kaleo | odraencode: is it Ubuntu apps related? | 17:21 |
| Kaleo | seb128: calum = ckpringle btw | 17:22 |
| odraencode | Kaleo: It is an app running on Ubuntu. Maybe it is an Ubuntu app! | 17:22 |
| Kaleo | odraencode: cool! | 17:22 |
| Kaleo | odraencode: link? | 17:22 |
| odraencode | Kaleo: To what? The videos? | 17:22 |
| Kaleo | odraencode: yes | 17:23 |
| odraencode | Kaleo: http://youtu.be/x4ppo1t_f1M | 17:23 |
| odraencode | Kaleo: http://youtu.be/LgfsXFD683E | 17:23 |
| odraencode | Kaleo: http://youtu.be/QsCuhqEnsbM | 17:24 |
| seb128 | Kaleo, thanks | 17:28 |
| Kaleo | odraencode: cool! is it QML? | 17:30 |
| timp | seb128: have a look at this http://developer.ubuntu.com/api/ubuntu-12.10/qml/mobile/qml-ubuntu-components-listitems0-singlevalue.html | 17:38 |
| timp | seb128: the second label is the value | 17:38 |
| timp | seb128: for a label and a single "widget", use this one http://developer.ubuntu.com/api/ubuntu-12.10/qml/mobile/qml-ubuntu-components-listitems0-singlecontrol.html | 17:42 |
| seb128 | timp, thanks, I was looking at that and it covers one of my usecase ... do you know if there is a way to set another widget as a "value"? (e.g a switch) | 17:42 |
| seb128 | timp, ah, that looks useful, thanks again (I think I tried but didn't know you could position the control as you wanted, the example on that page is useful ;-) | 17:43 |
| odraencode | Kaleo: QML? | 17:44 |
| odraencode | Kaleo: what is QML? | 17:44 |
| timp | seb128: oh wait... with SingleControl, the control fills the list item. So you don't have a label there. | 17:46 |
| timp | seb128: for label left and control right, you can use http://developer.ubuntu.com/api/ubuntu-12.10/qml/mobile/qml-ubuntu-components-listitems0-standard.html | 17:46 |
| timp | seb128: set the control property of ListItems.Standard | 17:46 |
| seb128 | timp, great ;-) | 17:55 |
| === daker_ is now known as daker | ||
| nik90 | odraencode: QML is the language we use for the upcoming Ubuntu Touch platform | 17:57 |
| nik90 | odraencode: it would be nice if your app uses it so that it will work on the desktop, mobile and tablet | 17:57 |
| odraencode | nik90: Hmm, it is written in python3/Gtk3, not QML | 17:57 |
| odraencode | nik90: Besides I don't really know about ubuntu touch, sorry. I just made an image viewer for desktop | 17:58 |
| nik90 | odraencode: yeah I realised | 17:58 |
| nik90 | odraencode: no worries | 17:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!