| hatch | bcsaller: back | 00:00 |
|---|---|---|
| bcsaller | hatch: let me push what I have but I know its your EOD | 00:01 |
| hatch | cool - I'm just about to make some supper then I can take a longer look at it | 00:01 |
| bcsaller | hatch: lp:~bcsaller/juju-gui/service_inspector behind :flags:/serviceInspector/ | 00:07 |
| * bcsaller takes a break | 00:07 | |
| hatch | bcsaller: I think I have c9 setup but need someone to try it out with.... | 00:56 |
| bcsaller | hatch: got a link on what I need to do? | 01:02 |
| hatch | well you need to sign up | 01:02 |
| hatch | which is very easy | 01:02 |
| hatch | then I need your username to grant you permissions | 01:02 |
| bcsaller | hatch: its bcsaller | 01:03 |
| hatch | ok now to find out how to add you | 01:03 |
| hatch | :) | 01:03 |
| hatch | https://c9.io/hatched/juju-gui | 01:03 |
| hatch | there is the url | 01:03 |
| hatch | ok granted you read/write access | 01:04 |
| hatch | open the COPYING file | 01:05 |
| bcsaller | seems to be working though I don't seem to have an indicator of what you have open and are editing | 01:06 |
| hatch | I Just typed under Preamble in COPYING | 01:07 |
| hatch | hmm | 01:07 |
| hatch | I just highlighted the to paragraph of the COPYING file....can you see that? | 01:09 |
| hatch | according to the vids this should 'just work' | 01:09 |
| bcsaller | hatch: doesn't seem to be showing edits | 01:09 |
| hatch | well that's lame | 01:10 |
| bcsaller | does the chat work on the right? | 01:10 |
| bcsaller | going to get back to debugging the rendering | 01:18 |
| hatch | alrighty | 01:19 |
| hatch | :) | 01:19 |
| bcsaller | you know we could easily parse data-bind="name" out of rendered DOM, but we'd lose the easy programatic config | 01:19 |
| bcsaller | well, not lose, be at odds with | 01:19 |
| hatch | yeah I had that in one of my refactors | 01:19 |
| hatch | but I was torn | 01:19 |
| hatch | and reverted :) | 01:19 |
| bcsaller | yeah | 01:19 |
| * hatch goes to delete the c9 account | 01:20 | |
| hatch | thx for the help | 01:22 |
| gary_poster | bac, looks like we have some stats. now the question is. how do we read them :-) | 12:15 |
| gary_poster | mysql-bac has average value of 14.72, mysql-x has average of 7.56, service (?) has average of 7.39 | 12:16 |
| gary_poster | bac, looks like we have some stats. now the question is. how do we read them :-) mysql-bac has average value of 14.72, mysql-x has average of 7.56, service (?) has average of 7.39 | 12:16 |
| bac | oh interesting. | 12:17 |
| bac | gary_poster: sadly i'm not a good scientist as for this round i didn't keep records. i recall setting one to 15 units, so that would correspond with mysql-bac | 12:17 |
| gary_poster | ok | 12:18 |
| bac | gary_poster: and there was the simulator perturbing the data | 12:18 |
| gary_poster | rt | 12:19 |
| gary_poster | rogpeppe, hi. I'd like to get your replies to the "Juju GUI API addresses handling" email thread (William said you had some plans in that regard) and to the "Juju core tasks for GUI project" thread (William and I both would like your thoughts on a reasonable way forward with the restricted mode that I mentioned and you prototyped. Do you have a chance of replying to those this afternoon? If not, np. Those two ar | 12:40 |
| gary_poster | e not immediately pressing, though I want us to agree on our way forward. I have a "ping Roger" to do item that I can fire off again next week sometime to try and get your thoughts :-) | 12:40 |
| rogpeppe | gary_poster: yes, i should be able to do that | 12:41 |
| gary_poster | thanks rogpeppe :-) | 12:41 |
| gary_poster | fwereade__, thank you very much for your replies to us about the gui needs. The set unit work would would ideally be implemented first of our juju core bits, but did I understand correctly that, even were we to decide to try to implement it ourselves, we need to wait for the same changes (a major version upgrade mechanism and/or moving the DB entirely behind API) that core would be waiting on? that is, it is not m | 12:44 |
| gary_poster | erely a matter of bandwidth but also technological infrastucture? | 12:44 |
| bac | teknico: ping (or are you gone today?) | 12:44 |
| bac | gary_poster: ^^ ?? | 12:45 |
| fwereade__ | gary_poster, I'd like to chat to someone about that | 12:45 |
| fwereade__ | gary_poster, I had a suggestion that might not involve a schema change, and might make for a useful model | 12:45 |
| gary_poster | involving SetMinimumUnits? | 12:45 |
| fwereade__ | gary_poster, yeah | 12:45 |
| gary_poster | bac I think he is here today. out wednesday this week only | 12:46 |
| bac | ok | 12:46 |
| bac | no rush | 12:46 |
| fwereade__ | gary_poster, can't chat today though, I'm afraid, just driving by | 12:46 |
| gary_poster | fwereade__, ok, maybe I can try to get a meeting with you, me, and frankban sometime next week? I'll propose on calendar? | 12:46 |
| fwereade__ | gary_poster, perfect, early monday is fine by me, I'm really keen to unblock you | 12:47 |
| gary_poster | fantastic, thanks fwereade__ . ttyl | 12:47 |
| fwereade__ | gary_poster, but whenever works :) | 12:47 |
| fwereade__ | gary_poster, cheers | 12:47 |
| gary_poster | frankban, do you mind helping out with analysis of the concurrent set unit discussion Monday at 1430 UTC? It might lead to you leading that implementation eventually, so be warned. :-) | 12:51 |
| frankban | gary_poster: I am definitely interested :-) | 12:53 |
| gary_poster | cool thanks frankban :-) | 12:53 |
| rick_h__ | jcsackett: morning, I'm still working on getting tests into the branch, but if you get a second can you QA it and make sure it does solve the black bar problem you saw? https://code.launchpad.net/~rharding/juju-gui/details-double-dispatch/+merge/168053 | 13:07 |
| rick_h__ | jcsackett: I don't see it, but I want to make sure I'm doing the exact steps you did to find the issue. | 13:08 |
| jcsackett | rick_h__: looking. | 13:09 |
| jcsackett | rick_h__: it doesn't. | 13:10 |
| teknico | bac: I'm back from lunch, what's up? | 13:10 |
| jcsackett | rick_h__: going to this url http://jujugui.local:8888/fullscreen/search/precise/juju-gui-61/:flags:/browser_enabled/?series=precise&text=gui&type=approved still causes black bar horror. | 13:11 |
| bac | teknico: not much, i was just wondering about the spelling for the config setting to disable GA. i'm writing some docs | 13:11 |
| bac | teknico: and my thoughts about exposing it in the charm were truly cracktastic. please ignore. | 13:12 |
| jcsackett | rick_h__: oddly though, if i move the ":flags:" bit to be the first bit (which i think is correct) no black bar. | 13:12 |
| teknico | bac: the idea was to use "use-analytics: true|false" | 13:12 |
| jcsackett | rick_h__: the latter url was the one i was actually using yesterday. so partial success at least. the flags thing may not be an issue, since i think flags are supposed to be the first component of a url anyway? | 13:13 |
| bac | teknico: ok. that works | 13:13 |
| rick_h__ | jcsackett: k, looking | 13:16 |
| gary_poster | hey sinzui, I went to http://tinyurl.com/orange-standup but hangouts said the party was over. what's the new daily url? | 13:21 |
| rick_h__ | gary_poster: https://plus.google.com/hangouts/_/cf491220dfb7736cee2876baf29110eeb52f5997?authuser=1 | 13:23 |
| gary_poster | thank you rick_h__ | 13:24 |
| sinzui | I think that old URL is from deryck's days time with orange. | 13:25 |
| * sinzui deletes the url | 13:25 | |
| === BradCrittenden is now known as bac | ||
| hatch | mornin | 13:48 |
| bac | gary_poster: who is that hairy man kissing karen on facebook? | 13:50 |
| gary_poster | bac, I dunno, but he's in some big trouble. | 13:50 |
| benji | gary_poster: so, zooming in and out should be on the basis of a service, eh? | 13:50 |
| bac | gary_poster: h.a. | 13:50 |
| gary_poster | :-) | 13:51 |
| gary_poster | benji, something like that, yeah. Maybe scrolling should be on the basis of the center of the viewport instead? | 13:53 |
| gary_poster | benji, goal is to handle case of services way out from to pleft origin | 13:53 |
| gary_poster | benji, current zoom is always from top left | 13:53 |
| gary_poster | which doesn't work well in some cases | 13:54 |
| benji | gary_poster: it has always felt wierd to me that zooming wasn't centered on the mouse cursor | 13:54 |
| gary_poster | benji, I suggest having a pre-imp with Makyo when he is available, if you want to tackle it | 13:54 |
| benji | gary_poster: ok (the card said you or Ben, and he out timezone-manuvered you) | 13:55 |
| benji | [I need to learn to spell one day.] | 13:55 |
| gary_poster | benji, heh, you talked with me to get the goal of the card (make env work better in that case, which is what happens with silly people on uistage | 13:55 |
| jcsackett | hey hatch, do you recall where/what causes the second dispatch? | 13:56 |
| hatch | deltas | 13:57 |
| hatch | every time a delta comes in it will dispatch | 13:57 |
| benji | Makyo: yo | 13:57 |
| jcsackett | so if i just load '/', there's always a second dispatch. where in the code might i find the event handler (or whatever) that is doing the delta dispatching? | 13:58 |
| hatch | grep for dispatch | 14:00 |
| hatch | its in a method called on_delta_something_something | 14:00 |
| hatch | it's similar to the "something_something_dark_side" method | 14:00 |
| * jcsackett laughs | 14:01 | |
| jcsackett | thanks. | 14:01 |
| hatch | :D np | 14:01 |
| rick_h__ | alejandraobregon: ping, any chance your around and available? | 14:05 |
| alejandraobregon | hey rick, soo sorry, been flat out! | 14:07 |
| alejandraobregon | rick_h__: will ping you when am out of my meetings | 14:07 |
| rick_h__ | alejandraobregon: np, I'd be great if we can just schedule something? | 14:07 |
| rick_h__ | alejandraobregon: ok, yea just want to let sinzui know what time table I'm looking at on the branch. | 14:07 |
| rick_h__ | alejandraobregon: have fun with your meetings :) | 14:07 |
| Makyo | benji, yo. | 14:08 |
| benji | Makyo: hi, can we have a pre-imp call about the "zooming in and out should be on the basis of a service" card | 14:09 |
| Makyo | benji, sure, guichat's free. | 14:10 |
| benji | sounds good | 14:10 |
| teknico | Makyo: ping me when you're done? | 14:18 |
| Makyo | teknico, ping. :) | 14:18 |
| benji | gary_poster: it seems that zooming happens relative to the mouse cursor already so Makyo and I are not able to determine what the card is about (there is a bug that means that if the cursor is over a service no zooming happens, I could work on that) | 14:19 |
| teknico | Makyo: guichat? | 14:19 |
| Makyo | teknico, yep | 14:19 |
| frankban | gary_poster: could you please review my juju-test branch? https://codereview.appspot.com/9874050 | 14:20 |
| gary_poster | benji frankban on call will ping | 14:20 |
| benji | thanks | 14:20 |
| frankban | gary_poster: ok thanks | 14:20 |
| gary_poster | benji, Makyo, what happens if you use the zoom controls on the bottom of the page? | 14:32 |
| benji | good question; trying now | 14:32 |
| jcsackett | rick_h__: is it valid for a url to have both '#' and '?' | 14:33 |
| jcsackett | and if so, is ordering of those two important/specified? | 14:33 |
| jcsackett | hoping you can save me a trip to URI specification docs. :-P | 14:33 |
| rick_h__ | jcsackett: yes | 14:34 |
| rick_h__ | jcsackett: no, I think usually the ? is first ,the # is second. JS makes location.hash available for the # part | 14:34 |
| jcsackett | rick_h__: cool. thanks. | 14:34 |
| rick_h__ | jcsackett: sorry, other way aroud on the order | 14:35 |
| Makyo | gary_poster, that's set to zoom around (0, 0), zooming around the center of the current view would be easier, but would rely on code from my branch. | 14:35 |
| rick_h__ | #someanchor?query=true | 14:35 |
| jcsackett | rick_h__: yeah, was just writing a sample url the wrong way and thought, "this doesn't seem right". :-P | 14:35 |
| gary_poster | Makyo, cool, thought it was 0,0. +1 on zooming around center of current view. Is that something you should slip into your current branch, ir that benji should work on as a follow on to your branch, or...? | 14:37 |
| gary_poster | s/ir/or/ | 14:37 |
| Makyo | gary_poster, I can do that in my branch, once I get the scale stuff working properly. There's still the issue of zoom events not bubbling | 14:38 |
| gary_poster | Makyo, ok thanks. benji ^^ s'ok with you? | 14:38 |
| benji | yep | 14:39 |
| gary_poster | thanks benji. Makyo, benji, I'll combine text of benji's card with Makyo's and then delete card. :-P | 14:39 |
| benji | Makyo: it shure looks like it zooms around the center when using the zoom slider | 14:39 |
| benji | k | 14:39 |
| Makyo | Cheers. | 14:39 |
| teknico | Makyo: deleting all cookies wasn't a great idea :-) | 14:39 |
| Makyo | teknico, oops :) | 14:40 |
| Makyo | teknico, I found you can delete them from the console in the resources tab. | 14:40 |
| gary_poster | benji, on uistage, zoom out. drag canvas to left so services are just to the left of where you can see them. zoom in. | 14:41 |
| bcsaller | hatch: around? | 14:41 |
| hatch | you bet | 14:41 |
| hatch | just reading your branch | 14:41 |
| bcsaller | hatch: and you got those emails last night? | 14:41 |
| bcsaller | from last night :) | 14:42 |
| hatch | yup | 14:42 |
| bcsaller | ok cool | 14:42 |
| gary_poster | frankban, fwiw, I don't have a lot of time. I will review code but will not have time for qa till later today or Monday | 14:43 |
| gary_poster | let me know how much you want me to do | 14:43 |
| benji | gary_poster: (ui stage isn't working for me, but I used a local server) I'm not sure what that is supposed to prove. If it zooms to the center of the visible part of the canvas (the current behavior and a good one, IMO) then if you follow those steps you will not be able to see any services, but that's not unexpected | 14:43 |
| gary_poster | benji, want me to show you on guichat? :-) | 14:44 |
| benji | gary_poster: sure | 14:44 |
| gary_poster | benji oops it is busy | 14:44 |
| gary_poster | 1 sec | 14:44 |
| benji | heh, yeah I just noticed | 14:45 |
| hatch | bcsaller: yeah I see the issue here | 14:45 |
| hatch | we can get together after the calls | 14:46 |
| bcsaller | hatch: sounds good | 14:46 |
| hatch | we definitely need a flag to stop people from opening multiple of the same inspector | 14:46 |
| bcsaller | hatch: we can do that with the tracking map in the env view, but I think we might want a better fix than just that | 14:48 |
| frankban | gary_poster: code review would be great, but please don't worry if you don't have time. | 14:54 |
| gary_poster | cool | 14:54 |
| gary_poster | jujugui call in 6 | 14:54 |
| gary_poster | kanban now | 14:55 |
| * benji opens up the branch start check list. | 14:55 | |
| gary_poster | jujgui call in 1 | 14:59 |
| gary_poster | jujugui | 14:59 |
| rick_h__ | jcsackett: ok, try to break please lp:~rharding/juju-gui/details-double-dispatch :) | 15:00 |
| jcsackett | rick_h__: works! | 15:02 |
| rick_h__ | jcsackett: party, now how the $#@#@ to test it all... | 15:03 |
| rick_h__ | hah, all existing tests pass...just lp-submit now in a hurry :P | 15:03 |
| alejandraobregon | rick_h__: hi! | 15:28 |
| alejandraobregon | rick_h__: so sorry, crazy day! | 15:28 |
| alejandraobregon | hang out now? | 15:28 |
| rick_h__ | alejandraobregon: give me 3min (hopefully) in the middle of submitting another branch before I can switch over to dmeo | 15:29 |
| alejandraobregon | rick_h__: no problem | 15:29 |
| jcastro | rick_h__: do you have a live thing like uisearch but with trunk handy? | 15:30 |
| rick_h__ | jcastro: http://uistage.jujucharms.com/:flags:/browser_enabled/ ? | 15:31 |
| rick_h__ | alejandraobregon: invite coming in a sec | 15:32 |
| rick_h__ | alejandraobregon: https://plus.google.com/hangouts/_/129fd072762c185e15013cb63d854c7e87c68cd4?hl=en | 15:35 |
| alejandraobregon | rick_h__: sorry couldn't understand what you were saying... | 15:38 |
| alejandraobregon | rick_h__: i have to leave shortly to pick up my 1YO from nursery... | 15:43 |
| alejandraobregon | rick_h__: can we cover it in ten mins? | 15:43 |
| rick_h__ | alejandraobregon: yep, moved to my home connection sorry | 15:47 |
| rick_h__ | alejandraobregon: starting up a quick hangout, should take just a couple of min | 15:47 |
| alejandraobregon | rick_h__: ah, there you are! | 15:47 |
| alejandraobregon | cool! | 15:47 |
| rick_h__ | sinzui: gary_poster so we have the ok to land the quality tab changes for now with agreement to re-evaluate/discuss it with luca upon his return. | 16:02 |
| sinzui | rick_h__, +1 | 16:02 |
| rick_h__ | sinzui: gary_poster and if there's a meeting I'd be happy to sit in and present what we did and why I think it makes sense. | 16:02 |
| gary_poster | yay, rick_h__ . thank you to you and alejandraobregon . rick_h__ would it be relatively quick to write up an email to juju-gui with the reasoning? then we can see if we can luca agrees with basic idea without a meeting? | 16:03 |
| rick_h__ | gary_poster: I can, is everyone on that list then? | 16:04 |
| gary_poster | rick_h__, yeah pretty sure. cc luca and ale just to be sure | 16:04 |
| rick_h__ | gary_poster: do you have a direct list then? /me does't see ~juju-gui with a list | 16:04 |
| gary_poster | oh! yeah | 16:05 |
| gary_poster | pretty sure you are on it but could be wrong | 16:05 |
| gary_poster | rick_h__, Juju GUI Developer List <juju-gui@lists.ubuntu.com> | 16:05 |
| * rick_h__ checks list membership | 16:05 | |
| gary_poster | rick_h__, it is an Ubuntu-style list, not LP | 16:05 |
| rick_h__ | gary_poster: ah, gotcha. | 16:06 |
| hatch | teknico: in guichat | 16:07 |
| rick_h__ | jcsackett: sinzui hatch bcsaller or anyone else that's intersted, can I get a couple reviews to defeat the great tabs-induced black bar of doom once and for all? https://codereview.appspot.com/10086045 referring to bug #1175019 | 16:13 |
| _mup_ | Bug #1175019: staging has issue with black bar at top of fullscreen charm details <charmbrowser> <juju-gui:In Progress by rharding> <https://launchpad.net/bugs/1175019> | 16:13 |
| benji | jsPlumb looks pretty cool | 16:13 |
| jcsackett | rick_h__: looking. | 16:14 |
| bcsaller | rick_h__: looking as well | 16:15 |
| rick_h__ | thanks guys | 16:15 |
| * rick_h__ fetches remote food for lunch today | 16:25 | |
| hatch | trunk is broken with make prod | 16:33 |
| hatch | oh wait | 16:41 |
| hatch | ignore me :) | 16:42 |
| Makyo | hatch, Done and done. | 16:42 |
| hatch | :P | 16:42 |
| Makyo | I kid, I kid :) | 16:42 |
| hatch | bcsaller: shall we chat? | 16:42 |
| bcsaller | hatch: joining | 16:43 |
| frankban | gary_poster: thanks for the review! | 16:51 |
| rogpeppe | gary_poster: aargh, i realise i totally haven't replied to your request and i've reached eod. i will try to do it monday morning - please hit me over the head if i don't! | 17:19 |
| hatch | gary_poster: do we have our call in 9? | 17:21 |
| gary_poster | rogpeppe, :-) np thanks. have a good weekend | 17:22 |
| gary_poster | hatch yes | 17:22 |
| hatch | great I didn't forget this time :) | 17:25 |
| sinzui | abentley, rick_h__, the charmworld deploy script does not get the current charmworld charm, and since it is tainting the charm, the versions will never be synced. I am working to get the correct version of the charm installed now | 17:36 |
| rick_h__ | sinzui: interesting. So we need a long term solution for this then as we update the charm? | 17:41 |
| sinzui | we do | 17:42 |
| sinzui | I am currentl;y discussing branch tags to compare version | 17:43 |
| rick_h__ | gary_poster: email away to the list now that uistage is updated. | 17:44 |
| gary_poster | yay thanks rick_h__ | 17:44 |
| rick_h__ | gary_poster: also heads up that the black bar issue is closing up. Should hopefully unblock some. | 17:44 |
| bcsaller | hatch: currently we are not limited to a single panel, we should think about how we want to handle that. I'm tempted to add the YUI drag handler to the panels on creation so we can just move them around for testing | 17:46 |
| gary_poster | yay rick_h__ ! ripping out charmbrowser flag today or next week? | 17:48 |
| rick_h__ | gary_poster: not sure, I don't know what the current checklist is for that. | 17:48 |
| rick_h__ | jcsackett: ping, how goes it? Want to chat now that I've got this stuff landed? | 17:49 |
| gary_poster | rick_h__, I think the checklist has been checked. black bar, bad typing experience of -, and quality tab | 17:49 |
| rick_h__ | " bad typing experience of -" ? | 17:49 |
| jcsackett | rick_h__: we can chat. i found the problem just before grabbing food. | 17:50 |
| rick_h__ | jcsackett: k | 17:50 |
| jcsackett | rick_h__: but i would love to chat about best solution. :-P | 17:50 |
| rick_h__ | jcsackett: why don't you invite away | 17:50 |
| hatch | bcsaller: yeah I see no issue in that, you should be able to just add it to the view-container template | 17:54 |
| sinzui | rick_h__, I think your dash bug is fixed in production: https://manage.jujucharms.com/api/1/charms?categories=app-servers&series=precise&text=&type=approved | 17:56 |
| hatch | bcsaller: mind if I grab some lunch and then we can get back at it? | 17:59 |
| bcsaller | hatch: go for it | 17:59 |
| hatch | cool - i'll be here so just ping if ya need | 17:59 |
| Makyo | jujugui Is uistage's improv down again? | 18:03 |
| gary_poster | Makyo, not for me | 18:03 |
| Makyo | gary_poster, Huh, will try again. Getting "websocket is closed before connection is establised" | 18:04 |
| Makyo | only spelled right. | 18:04 |
| hazmat | looks okay on the server | 18:04 |
| bcsaller | Makyo: w/o the :8080 wfm, the objects are off the canvas by default | 18:04 |
| gary_poster | :-) | 18:04 |
| Makyo | bcsaller, oh, derp. Forgot we removed the :8080 | 18:04 |
| gary_poster | 8080 wfm too | 18:04 |
| Makyo | gary_poster, I get the error only on :8080. | 18:05 |
| gary_poster | <shrug> wfm. just did a hard reload | 18:05 |
| jcsackett | hatch: need to grab you for a quick chat when you're back from lunch. | 18:06 |
| rick_h__ | sinzui: yay! | 18:06 |
| rick_h__ | sinzui: so maybe you can get with gary_poster on the un-feature flagging of the browser. | 18:06 |
| rick_h__ | sinzui: sounds like we're darn close and might be able to monday or tues. | 18:06 |
| gary_poster | +1 | 18:07 |
| sinzui | yes | 18:07 |
| rick_h__ | sinzui: I'll add a card to the board to remind me to bring it up monday then. Should be a short 3 or 4 line change | 18:07 |
| rick_h__ | sinzui: so jcsackett is working through our routing/url dropping QS and #xxx issues. I'm giong to move on to api2 then for now and wait for his work to fall through if that's ok | 18:08 |
| sinzui | +1 rick_h__ | 18:09 |
| bcsaller | hatch: give it a try when you get back, you can have multiple open bound draggable panels now | 18:38 |
| hatch | will do | 18:50 |
| hatch | bcsaller: awesomer | 18:53 |
| bcsaller | hatch: what do you think about adding tabs for the viewlets next and then a second one? | 18:54 |
| hatch | sure - just for prototype though right? UX will probably have something specific in mind | 18:55 |
| bcsaller | yes | 18:59 |
| hatch | ""Regenerated Templates"" haha friggen finally! | 19:10 |
| hatch | I don't think I have EVER seen that before - that must have been broken forever | 19:10 |
| hatch | bcsaller: w00t tabs work :) | 19:19 |
| hatch | that was easy.... | 19:19 |
| hatch | lol | 19:19 |
| hatch | mesa thinks all that planning made the coding a lot easier :) | 19:19 |
| jcsackett | hatch: skip on needing to chat; can you look at https://codereview.appspot.com/10119043 | 19:22 |
| hatch | jcsackett: we needed to chat? | 19:22 |
| hatch | oops sorry :) I missed the ping | 19:22 |
| jcsackett | i pinged you earlier about talking when you got back from lunch. it's all good. :-) | 19:22 |
| jcsackett | i' | 19:22 |
| jcsackett | i'm not sure we actually needed to. | 19:23 |
| hatch | reviewing | 19:23 |
| hatch | jcsackett: guichat? | 19:27 |
| jcsackett | sure | 19:27 |
| bcsaller | hatch: you have a branch link I can merge? | 19:30 |
| hatch | bcsaller: is this good enough? can bzr 'apply' diffs? https://gist.github.com/hatched/4bedc5bd0e9dceb96f32 | 19:32 |
| bcsaller | hatch: bzr push lp:~hatch/juju-gui/service_inspector and then I can merge it | 19:33 |
| hatch | cool one sec | 19:33 |
| hatch | bcsaller: done | 19:35 |
| hatch | jcsackett: lgtm'd with comment as per the hangout | 19:36 |
| jcsackett | thanks! | 19:36 |
| bcsaller | hatch: cool, thanks | 19:36 |
| hatch | bcsaller: I used data-attrs for the tabs as you can see - figured i'd follow the same convention as with the mappings | 19:38 |
| bcsaller | hatch: yes, I think that makes sense | 19:40 |
| bcsaller | I improved the styling, changed it to inline-block | 19:41 |
| hatch | yeah I just hacked some inline css in there haha | 19:42 |
| hatch | so next step is to add some inputs to see if we can get the updating to work | 19:43 |
| bcsaller | hatch: should work out of the box | 19:43 |
| bcsaller | but I can change the template now | 19:43 |
| hatch | sorry I meant with the units side | 19:44 |
| bcsaller | hatch: chat? | 19:45 |
| hatch | yup | 19:45 |
| abentley | orangesquad: Could you please review https://code.launchpad.net/~abentley/charmworld/hide-same-series/+merge/168167 ? | 19:46 |
| * sinzui looks | 19:46 | |
| jcsackett | bcsaller: can you look at https://codereview.appspot.com/10119043/ ? | 19:59 |
| abentley | orangesquad: could you please review https://code.launchpad.net/~abentley/charmworld/migrations-tests/+merge/168170 ? | 20:05 |
| jcsackett | abentley: sure. | 20:05 |
| sinzui | abentley, jcsackett sorry, it was r=me | 20:05 |
| abentley | sinzui: No, that's a second branch that jcsackett agreed to review. | 20:06 |
| sinzui | oh, sorry. nm | 20:06 |
| jcsackett | abentley: r=me. | 20:07 |
| abentley | jcsackett: Thanks. | 20:07 |
| arosales | folks saw ubuntu.com today right :-) | 20:20 |
| hatch | OOoooo look at that | 20:26 |
| gary_poster | hah! cool :-) | 20:26 |
| hatch | gary_poster: is there a reason why we don't have units as part of a service model? | 20:27 |
| hatch | just wondering if there was a big architectural reason I'm missing | 20:27 |
| gary_poster | hatch, probably because that's how they are modeled in juju. Probably also because it is a bit relational-db-like the way it is. Maybe because there's no guarantee that we will hear about a service before we hear about one of its units? Maybe there is a guarantee like that.... Anyway, it was a decision from before my time, but I don't have an argument against it. Do you? :-) | 20:30 |
| hatch | I do! :) | 20:30 |
| hatch | but I think I have a workaround | 20:31 |
| gary_poster | heh | 20:31 |
| gary_poster | ok | 20:31 |
| hatch | just an issue we are running into with the bindings | 20:31 |
| gary_poster | feel free to send an email or make a card | 20:31 |
| hatch | yeah will wait to run my idea past ben when he gets back | 20:31 |
| hatch | *I will | 20:32 |
| gary_poster | cool | 20:33 |
| bcsaller | jcsackett: it seems like you could just put that code on nsRouter.split and it should work, no? I assume you tried that and hit an issue? | 20:34 |
| bcsaller | hatch: back, btw | 20:35 |
| hatch | that was quick | 20:35 |
| hatch | guichat? | 20:35 |
| bcsaller | there | 20:35 |
| * gary_poster running | 20:43 | |
| gary_poster | have a great weekend | 20:43 |
| hatch | you too cya! | 20:43 |
| jcsackett | bcsaller: it's more that .split is implicated in more places and i'm cautious about what i modify without any understanding of this code. | 20:47 |
| BradCrittenden | ok, benji your sphinx checks have bitten me trying to propose my branch. hope you're happy. :) | 21:01 |
| benji | heh | 21:01 |
| === BradCrittenden is now known as bac____ | ||
| hatch | bcsaller: the events object in the view container should probably be user defined | 21:14 |
| hatch | or....do we want people to subclass view-container instead of init directly? | 21:14 |
| hatch | events and var viewletContainer = container.one('.viewlet-container'); should be user defined IMHO so that it can match the templates | 21:15 |
| hatch | and view-container can then be a general use wrapper | 21:15 |
| bcsaller | hatch: are events even used/needed here? | 21:15 |
| hatch | well it's the view container which houses the navigation | 21:15 |
| hatch | so we should really be subclassing the view-container | 21:17 |
| hatch | which is probably overkill :) | 21:17 |
| bcsaller | hatch: agreed, at this time I dont' see the need either. The controller should configure that layer I think | 21:20 |
| hatch | ok so I should make the events object user configurable? | 21:22 |
| hatch | and the viewlet-container element | 21:22 |
| rick_h__ | hatch: I'd think the container element should be ok to be hard coded. Provides consistancy and you can always drop in your own node inside of it. | 21:23 |
| rick_h__ | hatch: nvm, I was reading that as the container itself, but you're talking about the node inside the container already | 21:24 |
| hatch | :) | 21:24 |
| bcsaller | hatch: it works and its pretty cool, pushing. | 21:34 |
| hatch | awesome - I'm just finishing up my changes to view-container and it's tests | 21:34 |
| bcsaller | all pushed | 21:36 |
| bcsaller | you can watch the inspectors of multiple panels update the unit viewlets with the simulator running | 21:36 |
| hatch | excellent - lp:~hatch/juju-gui/service_inspector was updated | 21:37 |
| hatch | so you can pull those changes | 21:38 |
| hatch | I think my simulator is broken | 21:41 |
| hatch | oh nm there it goes | 21:41 |
| hatch | right on | 21:41 |
| hatch | :) | 21:41 |
| hatch | this is pretty damn cool | 21:42 |
| bcsaller | yeah | 21:42 |
| bcsaller | like I want other people to see this already :) | 21:43 |
| hatch | haha | 21:43 |
| * hatch ships a bunch of redbul to UX | 21:43 | |
| bcsaller | ha | 21:44 |
| hatch | excellent I'm glad that idea worked out | 21:44 |
| bcsaller | yeah, I thought you meant creating them on the fly at first and I was opposed, but I keep them up to date in the delta stream | 21:45 |
| bcsaller | extended process_delta to be able to handle this case | 21:45 |
| bcsaller | I'd get rid of the global list now :) | 21:46 |
| hatch | I wasn't sure if that was being used anywhere | 21:46 |
| bcsaller | only to select the subset by service | 21:46 |
| bcsaller | we need a close button on these inspectors | 21:47 |
| hatch | yup | 21:48 |
| hatch | I can do that | 21:48 |
| hatch | did you merge in my changes? | 21:48 |
| bcsaller | yes | 21:49 |
| hatch | ok I'll blow this branch out and pull down a new one | 21:49 |
| hatch | and then add that | 21:49 |
| bcsaller | you can just merge mine back in and keep going | 21:49 |
| hatch | ahh ok that'll be faster | 21:50 |
| bcsaller | yeah, just pushed again | 21:51 |
| hatch | cool - this is going to take a few minutes | 21:54 |
| hatch | then I'll write the tests for it | 21:54 |
| hatch | almost done | 22:06 |
| bcsaller | aggregated status is computed and doesn't fire a change event. might make sense to aggregate as status_error: {Number}, etc so the binding will work with it | 22:07 |
| bcsaller | directly on the service as attrs I mean | 22:07 |
| hatch | bcsaller: lp:~hatch/juju-gui/service_inspector | 22:08 |
| hatch | close button - I am pretty sure I removed it from the collection object properly | 22:08 |
| hatch | feel free to modify | 22:08 |
| bcsaller | hatch: I think it will be ok, setPanel should clean up in the overwrite case so for now this might leave an inspector in the env view index w/o a DOM unless I'm not seeing something else you did | 22:12 |
| bcsaller | hatch: did you merge back my changes as well? | 22:13 |
| bcsaller | hatch: I think next I'd like to make the overview viewlet interactive in the sense that it applies mutation. To do that I think it would be good to take the exposed toggle slider and embed it, see how well things handle that | 22:14 |
| hatch | I haven't merged your changes yet | 22:18 |
| hatch | I modified the setInspector method to add a remove functionality | 22:18 |
| hatch | did you see that? | 22:18 |
| hatch | and modified the show_service method in topology/service.js | 22:18 |
| hatch | "exposed toggle slider" ? | 22:19 |
| bcsaller | hatch: yeah, found it later | 22:24 |
| bcsaller | hatch: on the normal service view there is a toggle for exposed | 22:24 |
| bcsaller | hatch: I think you can see it w/o the feature flag | 22:25 |
| bcsaller | hatch: top right | 22:25 |
| hatch | ohh right right | 22:26 |
| hatch | so is there anything I should be doing right now wrt the panels or shall I keep on the docs? | 22:31 |
| bcsaller | hatch: I think the docs are going to be very valuable | 22:38 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!