| === rogpeppe1 is now known as rogpeppe | ||
| benji | interesting, it looks like the Ubuntu One team is working on a statsd client and server: https://launchpad.net/pystatsd (project registered 11 hours ago) | 12:21 |
|---|---|---|
| rick_h__ | benji: fork/copy of https://github.com/sivy/py-statsd it looks like | 12:22 |
| rick_h__ | peeked at that before | 12:22 |
| benji | thanks for the link, rick_h__ | 12:23 |
| gary_poster | Is there an Ubuntu One team at this point? Or is just Sidnei? | 12:23 |
| bac | Sidnei is a Team of One, like the US Army. | 12:26 |
| bac | frankban: i'm available to QA your branch if it is still needed | 12:26 |
| gary_poster | :-) | 12:26 |
| bac | i need two reviews of https://codereview.appspot.com/10024046 if anyone has some time. | 12:27 |
| rick_h__ | bac: done | 12:31 |
| bac | thx | 12:37 |
| benji | bac: I'll do a review | 12:38 |
| * benji tags the card. | 12:38 | |
| gary_poster | hey luca__, you have a good visit? | 12:38 |
| luca__ | gary_poster: I did thanks, how are things? | 12:38 |
| gary_poster | luca__, I'm glad. had a good weekend, but would be nice if it were longer. also somewhat worried for my wife's sanity starting tomorrow, because our boys will then be out of school for the summer. :-P | 12:40 |
| gary_poster | luca__, call about scenarios looks good. I assume you mean right after the standup? | 12:40 |
| luca__ | gary_poster: hehe that doesn't sound too good :P | 12:40 |
| luca__ | gary_poster: yeah | 12:40 |
| gary_poster | cool | 12:41 |
| luca__ | gary_poster: I'm not sure how long we need to discuss them but we can talk more tomorrow if needed, just wanted to start working through them as soon as. | 12:41 |
| gary_poster | luca__, I started on doc on Thursday to brainstorm stories. I never got it to where I wanted it | 12:42 |
| gary_poster | luca__, https://docs.google.com/a/canonical.com/document/d/1YTOmCCwSGMpZSXCQ_aRZz5UHXx6Tm4hr8X32Zz9iogw/edit#heading=h.y144flj0cwx4 | 12:42 |
| bac | rick_h__: making the GA id configurable is interesting but seems counter to our goals. | 12:42 |
| luca__ | gary_poster: fantastic, I'll give it a read over and we can talk about it later :) | 12:42 |
| bac | rick_h__: the point, as i understand it, is for us to be able to gather usage patterns for anyone deploying the gui. giving an easy way to subvert that seems counterproductive. | 12:43 |
| bac | but it is an interesting thing for us to discuss | 12:44 |
| gary_poster | luca__, cool. I forget where I was going to take the last "Building an environment" discussion right now, but I know part of it was going to be that I like what you had in your story. I think I was going to brainstorm different users/scenarios for when you might build from charms (experimenting, small use case, or building a bundle for the future) and when you might build from a deployer file/bundle (duplicating d | 12:45 |
| gary_poster | ev or prod environment, deploying known good config from charm store and then tweaking, ...) | 12:45 |
| luca__ | gary_poster: I see, sound good :) | 12:46 |
| frankban | bac: I am back. It would be great if we can take a look at the error you reported. It's weird. The usual chat seems open. | 12:49 |
| gary_poster | rick_h__, hey. When does sinzui usually start his day? | 12:51 |
| gary_poster | bac benji frankban teknico, any of you interested in attending a call about grid units/making the gui friendly to mobile/responsive web design (I used to know this as "flexible web design" but now it seems to also refer to different form factors)? It is in 4 minutes. I'll attend. It's not a good time for Ben Matt or Jeff or I would have invited them. | 12:57 |
| gary_poster | 3 minutes :-P | 12:57 |
| benji | not especially, but I'll be glad to drop in if no one else will take the bullet | 12:58 |
| teknico | gary_poster: yep, pass the link | 12:58 |
| gary_poster | teknico, priv msg | 12:58 |
| rick_h__ | gary_poster: usually between now and our 9:30 standup | 12:58 |
| gary_poster | ok rick_h__. I would have asked him to ask you the question above :-) | 12:59 |
| gary_poster | jcsackett, too | 12:59 |
| rick_h__ | gary_poster: heh, responsive means using media queries in the css, so just an extra layer on flexible | 12:59 |
| rick_h__ | gary_poster: sure, I'll attend | 13:00 |
| gary_poster | rick_h__, gotcha. cool, will privmsg | 13:00 |
| gary_poster | luca__, responsive call is now, yeah? Rick and I are here. | 13:01 |
| luca__ | gary_poster: coming! | 13:01 |
| rick_h__ | bac: yea, but will most production deploys agree to share that info? and it solves the jujucharms.cmo case for my needs :) | 13:01 |
| gary_poster | :-) | 13:01 |
| bac | rick_h__: on a call so i can't think. :) | 13:02 |
| rick_h__ | bac: I think a cool default would help but allow people to use it as they might find handy :) | 13:02 |
| bac | benji: i like this "The looks good." i think i'll adopt it as a reviewer catch phrase. | 13:12 |
| benji | The looks, they are good, yes? | 13:12 |
| bac | Time to fail for the "As seen on TV" self-shrinking garden hose I got for my birthday: 10 days. | 13:14 |
| BradCrittenden | frankban: tests finished. http://paste.ubuntu.com/5751661/ | 13:33 |
| === BradCrittenden is now known as bac_ | ||
| frankban | bac: intersting, does that file exist? | 13:34 |
| bac_ | frankban: you mean /dev/null? | 13:35 |
| frankban | bac: /home/bac/charms/precise/juju-gui/tests/.venv/local/lib/python2.7/site-packages/xvfbwrapper/xvfbwrapper.py | 13:36 |
| Makyo | Anyone up for another review/QA? https://codereview.appspot.com/10048043/ | 14:02 |
| rick_h__ | bac_: my call is done if you want to continue discussion of the GA id as config? | 14:02 |
| Makyo | Note that that includes a comment WRT a deferred task. Card is already created and assigned. | 14:02 |
| * gary_poster had to actually google to discover what bac's hose could possibly be. http://windo.en.alibaba.com/product/636728871-214175883/2012_Shrinking_Garden_Hose_As_Seen_On_TV.html for those with similar interest | 14:04 | |
| bac_ | gary_poster: it wasn't really an endorsement | 14:05 |
| bac_ | although those were some of the most fun 10 days of watering | 14:05 |
| bac_ | hi rick_h__ | 14:06 |
| bac_ | sure | 14:06 |
| Makyo | Man, I love watering. | 14:06 |
| hatch | morning all | 14:07 |
| rick_h__ | bac_: so I'm not up on the back story of the feature. I assume that it's defaulted to on, allow users to turn it off, and used mainly for helpful reporting of usage to make life better for all users | 14:07 |
| rick_h__ | bac_: my argument is that, allowing users to do their own reporting is a nice cool feature that our team would love to have in the charm, and doesn't adversely effect the original goal since most users won't change the default config | 14:07 |
| rick_h__ | the users that go into the config to chage the GA id are likely to be the same that would just turn it off anyway. | 14:08 |
| bac_ | rick_h__: which deployment are you specifically talking about? | 14:08 |
| bac_ | uistage? | 14:08 |
| bac_ | rick_h__: wanna chat? | 14:09 |
| rick_h__ | bac_: sure | 14:09 |
| gary_poster | luca__, thank you for organizing that mtg. was great to have. would be thrilled to share more across teams | 14:12 |
| luca__ | gary_poster: thanks Gary :) I was really hoping it would be worth everyones time. | 14:13 |
| sinzui | orangesquad: I created an mp for a mid-implementation review: My branch is 2 days old, now and there are a few issues I am not sure about: https://code.launchpad.net/~sinzui/charmworld/charm-model-fixes-views/+merge/168175 | 14:14 |
| abentley | sinzui: Oh, good grief. I assumed "optional" mean "may be none", but it appears to mean "may not be present": http://docs.mongodb.org/manual/reference/gridfs/#gridfs-files-collection | 14:17 |
| sinzui | abentley, If you mean "aliases" then I too think the value is None. | 14:20 |
| sinzui | abentley, This is the dict problem we have with charms isn't it? | 14:21 |
| abentley | sinzui: I meant files.contentType | 14:21 |
| sinzui | yep, it is listed about aliases as optional. We both think the value can be None, but the apparent use is the key may not be present | 14:22 |
| abentley | sinzui: That's okay with a dict, but optional attributes on an instance are a PITA. | 14:23 |
| rick_h__ | luca__: yea, thanks. I'm bouncing off walls at the idea of a shared CSS lib. | 14:27 |
| abentley | orangesquad: could you please review https://code.launchpad.net/~abentley/charmworld/same-name-related/+merge/168190 | 14:28 |
| * sinzui looks | 14:28 | |
| luca__ | rick_h__: haha, glad it was helpful :) | 14:28 |
| * rick_h__ looks forward to the day when he doesn't have to look up the #-code for "ubuntu orange" | 14:30 | |
| gary_poster | rick_h__, sinzui in prep for meeting, https://bugs.launchpad.net/juju-gui/+bug/1186299 is done right? | 14:30 |
| _mup_ | Bug #1186299: The charm browser quality tab does not have data <charmbrowser> <juju-gui:In Progress by rharding> <https://launchpad.net/bugs/1186299> | 14:30 |
| rick_h__ | gary_poster: yes, I'll close up and link to the branch. Sorry I missed it | 14:30 |
| rick_h__ | gary_poster: reminds me, luca__ did you see my email about the quality tab and get a chance to peek at it? | 14:31 |
| rick_h__ | luca__: kind of a 'proposed' solution and would love feedback. | 14:31 |
| gary_poster | rick_h__, great thank you. when will charm browser default land? that was another goal for today | 14:31 |
| rick_h__ | gary_poster: jcsackett is working on it now I believe | 14:31 |
| gary_poster | cool rick_h__ thanks | 14:31 |
| abentley | sinzui: Is anyone chasing down the Tarmac issue today? | 14:31 |
| sinzui | abentley, r=me, matsubara fell out of the channel the moment I tab completed him | 14:32 |
| rick_h__ | fastest review evar! on that branch | 14:32 |
| abentley | sinzui: ! | 14:32 |
| sinzui | abentley, we are thinking the same I think :) | 14:32 |
| sinzui | I will follow up with matsubara | 14:32 |
| hatch | rick_h__: can I set up some sort of config to open a tmux window with a certain window split every time? | 14:47 |
| rick_h__ | hatch: see pm | 14:48 |
| hatch | thx | 14:51 |
| bac_ | gary_poster: rick_h__ makes the good point that until the GA opt in/out is easily available via the charm we should have the default for useAnalytics set to false. i agree and would like to land this initial branch with it turned off. a-ok? | 14:56 |
| gary_poster | bac +1 | 14:57 |
| bac_ | gary_poster: he also suggests a chat with jcastro to brief from a community perspective, which i'm also +1 and will be happy to do | 14:57 |
| gary_poster | thank you bac_ , cool | 14:58 |
| jcastro | we have a sync call in 2 minutes anyway! | 14:58 |
| gary_poster | :-) | 14:58 |
| gary_poster | y | 14:58 |
| rick_h__ | sinzui: can we ask for an update to mjc to get v2 api available on there? | 15:13 |
| sinzui | I will after this meeting, you you can ask | 15:13 |
| rick_h__ | sinzui: k, I'll bug you post-meeting. I thuoght we needed to file an RT and wanted to check on the process. | 15:14 |
| sinzui | rick_h__, we do, and then we prod webops. We know the deploy will fail so hand holding is needed | 15:16 |
| hatch | man I can never remember the syntax for linking with rst | 15:16 |
| rick_h__ | .. _something: google.com | 15:17 |
| hatch | ...something something something....dark side | 15:17 |
| rick_h__ | lol | 15:17 |
| hatch | rick_h__: https://twitter.com/FromAnEgg/status/344111810431049728 :) | 15:20 |
| rick_h__ | hatch: :P http://www.webupd8.org/2012/03/retext-30-released-text-editor-for.html | 15:21 |
| hatch | sure but that's another app :) | 15:21 |
| hatch | maybe there is a sublime plugin | 15:21 |
| rick_h__ | I think there's a few editors that do live viewing | 15:21 |
| rick_h__ | hatch: yea, but it's live so you don't have to type/save/type/save/etc | 15:22 |
| hatch | oh kewl | 15:22 |
| hatch | rick_h__: why did you say // THIS IS BAD!!!!!!!!! on ln 1000 of app.js? | 15:33 |
| hatch | it's not bad, the router is just broken :) | 15:33 |
| hatch | although Ben fixed it this weekend I think | 15:34 |
| rick_h__ | hatch: oh crap was that in there? | 15:34 |
| hatch | lol | 15:34 |
| rick_h__ | hatch: I was walking through the issue with jcsackett in a call and just marked out the line as we talked | 15:34 |
| rick_h__ | completely missed that in the diff, thought I reverted when I switched colo-branch | 15:34 |
| rick_h__ | hatch: lmao, thanks for catching. Mechanical whatever I guess... | 15:35 |
| hatch | store/charm.js ln 164 "charmworldj" | 15:35 |
| rick_h__ | wtf, it's not in my local branch | 15:36 |
| hatch | man it's a good thing I'm going through this :P | 15:36 |
| * rick_h__ is so confused | 15:36 | |
| hatch | bad merge? | 15:36 |
| rick_h__ | must be, both of those aren't in my local code | 15:37 |
| * rick_h__ does a re-propose | 15:37 | |
| hatch | doesn't look like codereview lets you do a self review - it doesn't turn your comment green | 15:40 |
| hatch | this made me laugh this morning http://xkcd.com/742/ | 15:40 |
| rick_h__ | hatch: cool, thanks for peeking at it. Yea, looks like a mess up from when I did a bzr switch between branches | 15:42 |
| hatch | is that a bzr issue when switching branches like that? Or did you mess something up? (curious) | 15:43 |
| rick_h__ | so I don't know exactly what I typed/did but I had uncommitted changes in a branch I didn't want. I created a new one and went to work and it carried over the uncommitted changes I think | 15:43 |
| hatch | ahhh yeah I noticed it does that | 15:44 |
| hatch | found that odd | 15:44 |
| hatch | but I suppose git does something similar | 15:44 |
| sinzui | orangesquad. We want to deploy, but we know migrations will fail. I propose landing a branch that makes migration 7 a no-op so that the deploy works without intervention. I am preparing a script that walks through the charms and generate a report to discover which charms have circular references. | 15:48 |
| abentley | sinzui: Makes sense. | 15:49 |
| gary_poster | jujugui call in 10. kanban now | 15:50 |
| sinzui | abentley, matsubara is working on the ssh-to-Lp problem. I don't expect tarmac to work today | 15:50 |
| abentley | sinzui: Okay. | 15:51 |
| gary_poster | jujugui call now | 16:00 |
| Makyo | Welp. | 16:02 |
| sinzui | abentley, do you have a moment to bless or curse this merge: https://code.launchpad.net/~sinzui/charmworld/disable-migration/+merge/168482 | 16:05 |
| abentley | sinzui: I am confused about whether we still follow Launchpad policies. If so, https://dev.launchpad.net/PolicyandProcess/XXXPolicy would dictate a bug number. | 16:07 |
| sinzui | abentley, yeah, I sould have one since I have a card on the board for it | 16:08 |
| sinzui | abentley, I updated the comment and reported bug 1189531 | 16:13 |
| abentley | sinzui: r=me | 16:14 |
| sinzui | thank you | 16:14 |
| gary_poster | luca__, alejandraobregon shall we meet in guichat or somewhere else? | 16:15 |
| luca__ | guichat is fine gary_poster | 16:15 |
| === deryck is now known as deryck[lunch] | ||
| * hatch needs a break from docs | 17:08 | |
| benji | is there some reason errors are thrown with this format? "INVALID_STATE_ERR : Connection is open to another client." | 17:11 |
| benji | specifically, the space before the colon; that seems like a weird thing to do in English | 17:11 |
| hatch | English has consistent grammar rules? | 17:12 |
| hatch | since when? | 17:12 |
| hatch | :P | 17:12 |
| hatch | gary_poster: I'm at a place with the documentation where I'd like to get some input from Ben before moving forward so should I move on to the ghost config with the view controller or did you have something else in mind? | 17:45 |
| gary_poster | hatch, ...could you (a) land bcsaller's nsrouter branch and (b) work on replacing the alerts dropdown bootstrap stuff? | 17:47 |
| rick_h__ | hatch: on the ns-router lines I've changed it in my local copy, just have getHash do return window.location.hash; | 17:48 |
| rick_h__ | hatch: please take a peek before landing it as it is still broken for our needs in getting the active tab support landed | 17:48 |
| hatch | gary_poster: can do | 17:50 |
| gary_poster | thank you hatch | 17:50 |
| hatch | no problemo | 17:52 |
| === deryck[lunch] is now known as deryck | ||
| hatch | rick_h__: guichat? | 17:54 |
| rick_h__ | hatch: sure thing | 17:54 |
| abentley | orangesquad: could you please review https://code.launchpad.net/~abentley/charmworld/file-etags/+merge/168497 | 18:04 |
| * sinzui looks | 18:05 | |
| * hatch lunching | 18:07 | |
| bac | first they steal 'launchpad' and now 'mavericks' (sic) | 18:11 |
| hatch | pourquoi? | 18:12 |
| * hatch used the wrong word | 18:12 | |
| rick_h__ | hatch: you're not up on your apple-fu | 18:12 |
| hatch | sorry I've been WORKING today instead of reading blogs :P | 18:13 |
| rick_h__ | hatch: you need more screens :P | 18:13 |
| hatch | I know! | 18:13 |
| rick_h__ | maybe now you can upgrade that laptop and get 3 thunderbolt displays on it so you can work with news on the side and know what bac knows :) | 18:13 |
| hatch | damn shared video ram on a mac mini | 18:13 |
| rick_h__ | lol | 18:13 |
| hatch | damn rights! | 18:13 |
| bac | man i wish i had an external monitor | 18:14 |
| hatch | xbox one $500? small price to pay for an invasion of privacy! | 18:14 |
| rick_h__ | hatch: come on, you get that for free with your gmail, twitter account, and ISP | 18:14 |
| hatch | what is lacking with that is a camera and microphone in my livingroom | 18:15 |
| hatch | glad MS is planning on filling that void | 18:17 |
| sinzui | abentley, r=me | 18:17 |
| abentley | sinzui: Thanks! | 18:17 |
| Makyo | jujugui Another call for reviews: https://codereview.appspot.com/10048043/ Just need one more :) | 18:17 |
| hatch | rick_h__: sorry I just don't trust MS enough to place an always-on video camera and microphone into my livingroom | 18:19 |
| jcsackett | s/MS/anyone/ | 18:21 |
| jcsackett | jujugui: i too must ask for reviews https://codereview.appspot.com/10156043 | 18:21 |
| rick_h__ | jcsackett: I'll peek in a second | 18:21 |
| hatch | jcsackett: hah truth! Although if it was OSS then at least people could look into the source to find the inevitable bugs | 18:22 |
| Makyo | jcsackett, on it. | 18:22 |
| rick_h__ | jcsackett: couple of notes while I look into the test regex part | 18:26 |
| hatch | rick_h__: the sad thing is that I actually want the new xbox but not with the kinect | 18:33 |
| rick_h__ | jcsackett: I see what's up with the test issue, I'm working on some code to help it out. Will be a few min. | 18:42 |
| Makyo | How long until people figure out you can just put the xbox in a well-lit diorama of your livingroom with the proper number of people painted on the couch? | 18:45 |
| rick_h__ | jcsackett: check out lp:~rharding/juju-gui/sanity-check-default please and let me know how that looks | 18:48 |
| sinzui | abentley, This is the script to look for errors in charm data. Dev and staging are fine as I expect. Do you have any additions to the script? http://pastebin.ubuntu.com/5752622/ | 19:04 |
| abentley | sinzui: No, it looks good to me. | 19:07 |
| sinzui | fab | 19:07 |
| hatch | Makyo: lol! | 19:07 |
| gary_poster | hey hazmat. May I schedule 30 minutes with you tomorrow to talk about bundles/deployer stuff? Almost certainly will need more later, and with other people, but this can get things rolling again | 19:13 |
| gary_poster | arosales, hey. In https://docs.google.com/a/canonical.com/document/d/1FU29PCI2I2a-PUKCMHvt9jK6Jr1TcfyvUFDypHOQ_ic/edit# does ecosystems need to do anything to have test results ready on time or are they already ready to go? | 19:15 |
| gary_poster | on the ecosystems side I mean | 19:15 |
| hatch | Makyo: do I have to re-review your branch? | 19:16 |
| Makyo | hatch, Don't think so, though you're welcome to. | 19:17 |
| arosales | gary_poster, they should be ready to go | 19:21 |
| hatch | Makyo: didn't we decide that we weren't going to fire events on other classes? re topology/panzoom.js ln 181 | 19:21 |
| arosales | if orange run into any issues on the parsing of test results though please let me and marco know | 19:22 |
| gary_poster | great thanks arosales, so that deliverable is all on UX and GUI (Orange). I'll call that out explicitly on list | 19:22 |
| Makyo | hatch, I don't remember any such decision, but I do recall us deciding that Topology was it's on special sort of madness. | 19:23 |
| hatch | yeah I remember that part haha | 19:24 |
| hazmat | gary_poster, sure | 19:24 |
| hatch | Maybe we just discussed it but didn't make any decisions | 19:24 |
| hatch | anyways, my LGTM stands :) | 19:24 |
| arosales | gary_poster, aiui that testing data from jenkins was in a consumable form. So yes next actions for testing are on orange and UI. | 19:25 |
| arosales | s/ui/design | 19:25 |
| gary_poster | thanks hazmat . created event. gave you edit power if you need to move it, but it worked with your calendar as it is now | 19:26 |
| gary_poster | arosales, cool, thanks. sinzui, do you all already have a plan for slurping up the jenkins data? does it go in m.j.c and then the GUI gets it from there? | 19:27 |
| sinzui | We have been slurping data since before orange took control | 19:28 |
| gary_poster | cool sinzui, so this is entirely simply a matter of exposing something in the GUI? The data already is moving to the GUI? | 19:28 |
| sinzui | we also know know then data format changes because it breaks staging and production 15 minutes later | 19:28 |
| sinzui | that's right | 19:28 |
| arosales | gary_poster, np. | 19:29 |
| hazmat | gary_poster, thanks, done. | 19:29 |
| arosales | sinzui, let us (me and marco) know if you run into any issues slupring the testing jenkins data | 19:29 |
| gary_poster | sinzui, data format changes: ok. what's the status of that for long term m.j.c happiness? | 19:30 |
| gary_poster | is that call-worthy? | 19:30 |
| sinzui | arosales, we will :). All has been good for that last 6 weeks. | 19:30 |
| arosales | sinzui, thanks, and good to know :-) | 19:30 |
| sinzui | gary_poster, Its in the long-term charmworld stability blueprint | 19:31 |
| gary_poster | ok sinzui thanks will see that when I get there then | 19:31 |
| abentley | sinzui: I would like to discuss bug #1176452 with you. | 19:40 |
| _mup_ | Bug #1176452: ElasticHttpError:NumberFormatException[For input string: "yes" <elasticsearch> <ingest> <oops> <charmworld:Triaged> <https://launchpad.net/bugs/1176452> | 19:40 |
| sinzui | in a few minutes abentley, otp with dan | 19:41 |
| abentley | sinzui: ack | 19:41 |
| hatch | I always thought otp = on the potty | 19:41 |
| hatch | but it makes a lot more sense thaat it means on the phone | 19:42 |
| hatch | lol | 19:42 |
| BradCrittenden | benji: do you need to re-review the test i added? 'lbox propose' is running now and 'lbox submit' is on hit heels. | 19:45 |
| * BradCrittenden hates his droppy internet | 19:45 | |
| === BradCrittenden is now known as bac | ||
| benji | bac: nah, if you're happy with it then I'm fine | 19:46 |
| bac | benji: i'm ecstatic | 19:46 |
| * benji throws confetti | 19:46 | |
| sinzui | orangesquad, tarmac is back. We were blacklisted for hammering bazaar.lp.net | 20:07 |
| abentley | sinzui: Ah. | 20:08 |
| bac | hatch: did you qa teknico's branch? | 20:16 |
| hatch | bac: I did - I didn't LGTM it though | 20:17 |
| bac | hatch: i changed useAnalytics to true and ran it but don't see the banner. am i missing something obvious? | 20:18 |
| hatch | I think you need to be on sandbox: false with rapi running | 20:18 |
| bac | really? huh. | 20:19 |
| hatch | oh wait - no that was just for prod | 20:20 |
| hatch | nm | 20:20 |
| hatch | bac: I think app.js line 1217 is the issue | 20:21 |
| sinzui | abentley, sorry for the delay. I an talk now | 20:21 |
| hatch | I am not sure if that is being set | 20:21 |
| abentley | sinzui: Cool. | 20:22 |
| sinzui | abentley, I can talk now | 20:22 |
| abentley | sinzui: Your microwave may not be wi-fi compatible :-) | 20:24 |
| sinzui | abentley, i just got kicked out | 20:24 |
| abentley | sinzui: I have reinvited you, but it's just ringing and ringing and finally said "It looks like Curtis Hovey isn't available." | 20:25 |
| bac | gary_poster: thoughts on GA on uistage? leave it in or rip it out for now? | 20:25 |
| hatch | bac: oh nm it appears to be being set | 20:25 |
| bac | hatch: well i can't get it to work | 20:26 |
| hatch | hmm sorry I'm not sure - I can look into it further if you would like but I have a few other things in front of it atm | 20:26 |
| bac | hatch: nope, don't bother | 20:26 |
| gary_poster | bac we have to have it as the cornerstone of everywhere else for GA to work, I thought. wrong? | 20:26 |
| gary_poster | s/of/for/ | 20:26 |
| hatch | bac: alright - imho it needs a bit more work before it's landable anyways | 20:26 |
| gary_poster | or something... | 20:26 |
| bac | gary_poster: on uistage i manually inserted the snippet into index.html. my branch has now landed that has it for real, but with the config turned off. | 20:27 |
| bac | gary_poster: i propose reverting uistage to not be divergent | 20:27 |
| gary_poster | oic. +1 bac | 20:27 |
| bac | gary_poster: but that will disable GA for now | 20:27 |
| gary_poster | bac will that screw up GA for other sites? | 20:27 |
| bac | gary_poster: other sites? other deployments will not have it turned on by default and i assume no one is going to hack it in | 20:28 |
| gary_poster | bac, if so, I suggest reverting index.html but changing config to turn it on | 20:28 |
| bac | er.... | 20:28 |
| gary_poster | bac, :-) | 20:28 |
| bac | gary_poster: what other sites are you referring to? | 20:28 |
| gary_poster | bac, I mean for when we turn this on in the charm | 20:29 |
| bac | oh | 20:29 |
| gary_poster | if we turn this on in the charm, GA needs to already be happy | 20:29 |
| bac | the jujucharms must be on stuff | 20:29 |
| bac | yeah, well, i don't know how that'll work since it has been seen once. | 20:29 |
| gary_poster | bac, I vote to leave it turned on in uistage, assuming that the cookies warning is working | 20:30 |
| gary_poster | wdyt | 20:30 |
| bac | gary_poster: so for uistage, revert index.html to the branch version and then set config-prod: useAnalytics true. seems like a good plan | 20:30 |
| gary_poster | exactly | 20:30 |
| gary_poster | cool, thank you | 20:30 |
| bac | the cookie warning will not land until tomorrow at earliest | 20:30 |
| gary_poster | oh | 20:30 |
| gary_poster | ok | 20:30 |
| bac | lots of work from review | 20:30 |
| gary_poster | mm | 20:30 |
| gary_poster | then useAnalytics false bac, till that lands | 20:31 |
| bac | ok | 20:31 |
| hatch | no new MBP yet :( guess that's good for my credit card balance :) | 20:32 |
| bac | gary_poster: done | 20:39 |
| gary_poster | thanks bac. | 20:39 |
| gary_poster | yeah hatch, was disappointed too :-) | 20:39 |
| hatch | other sites are claming September which is quite a ways away for those who are in the market.. | 20:40 |
| * hatch <---- this guy | 20:40 | |
| gary_poster | huh. it's 364 days since last update, which is most in their history (http://buyersguide.macrumors.com/#MacBook_Pro) | 20:41 |
| gary_poster | oh wait | 20:41 |
| gary_poster | never mind | 20:42 |
| gary_poster | http://buyersguide.macrumors.com/#Retina_MacBook_Pro | 20:42 |
| hatch | yeah it's definitely not been a long time....but haswell! | 20:42 |
| gary_poster | I know | 20:42 |
| gary_poster | completely with you | 20:42 |
| bac | to make up for my negative review this morning, i heartily endorse this product: http://www.amazon.com/dp/B00008GS96/ref=tsm_1_fb_lk | 20:45 |
| hatch | bac: lol nice comment in the review :P | 20:45 |
| hatch | bac: here the bugs aren't big enough for those :( but what they lack in size they make up for in quantity | 20:45 |
| bac | we have one upstairs and down | 20:46 |
| bac | they make up by transmitting deadly disease | 20:46 |
| bac | i mean, ours are tiny but awful | 20:46 |
| hatch | that's unfortunate - ours are mostly disease free (as far as I know) but the ticks apparently aren't the cleanest | 20:50 |
| * bac walks dogs, jojo + 2 little white things who spend 90% of the time tangled up in the leash | 20:51 | |
| hatch | lol | 20:52 |
| Makyo | Dogwalk. Eyes need a break;. | 20:58 |
| rick_h__ | jcsackett: still around? | 21:12 |
| jcsackett | rick_h__: yup. | 21:12 |
| rick_h__ | jcsackett: so looking at the changes, was there something to not moving the browser subapp up into the original subApplications def vs a push in init? | 21:13 |
| jcsackett | rick_h__: i don't follow. | 21:13 |
| rick_h__ | jcsackett: and the problem is that when the browser isn't FF'd it always tries to run and at least show the sidebar. There's no store though. | 21:13 |
| jcsackett | rick_h__: i know that part; but the phantom parsing of "test" is still not sorted. | 21:14 |
| rick_h__ | jcsackett: line 55 can have the subapp vs line 355 | 21:14 |
| jcsackett | as to the push, i have no preference. i whacked the flag and then hunted down test errors. | 21:14 |
| rick_h__ | jcsackett: ok, right, my first pass I mentioned that there's no need to have the subapp in the init and the extra call to push it | 21:14 |
| jcsackett | rick_h__: i don't think i saw that. | 21:14 |
| * jcsackett looks | 21:14 | |
| rick_h__ | jcsackett: so the 'test' is that someone is testing urls that are just /something/test and it caused the code in the subapp browser to check it as an id | 21:15 |
| rick_h__ | jcsackett: so adding it to the id ignore was just a lucky 'ignore what someone decided to use in a test' vs a real fix to not try to run browser code when it's not intended | 21:15 |
| rick_h__ | jcsackett: so LGTM after moving the browser subapp def back to the top of the class per https://codereview.appspot.com/10156043/diff/1/app/app.js#newcode355 | 21:17 |
| jcsackett | rick_h__: huh; i grepped for that in the test file but didn't see anything to that effect. | 21:17 |
| rick_h__ | jcsackett: it was in other tests | 21:17 |
| jcsackett | ah, and we have nothing for test isolation. right. | 21:17 |
| * rick_h__ goes to look if he has the failures | 21:17 | |
| rick_h__ | jcsackett: right, all tests around the App() will hit browser the subapp since it's part of it now that it's not FF'd | 21:17 |
| rick_h__ | jcsackett: so the 'hack' is that other tests won't set a charmworld.url as part of their setup. | 21:18 |
| rick_h__ | jcsackett: so the browser subapp just ignores things if there's not a valid store. Browsing makes no sense without it. | 21:18 |
| jcsackett | right; i like the store check as a fix. | 21:18 |
| jcsackett | it was the phantom url that was irking me. | 21:18 |
| rick_h__ | might as well be a "isTesting" flag, but it's a bit more specific | 21:18 |
| rick_h__ | test/test_charm_running.py: self.load('/test/') | 21:19 |
| rick_h__ | might have been teh cause | 21:19 |
| rick_h__ | just a quick grep, but anyway. Changes look good to me | 21:19 |
| rick_h__ | jcsackett: thanks for the update and un-FF'ing the browser. Look forward to not needed :flags:/ :) | 21:20 |
| hatch | rick_h__: I think I have it #.[^?/]*[$]? | 21:29 |
| rick_h__ | hatch: why the [$]? | 21:29 |
| rick_h__ | hatch: you should be able to remove that part | 21:29 |
| hatch | ahh yes I can | 21:29 |
| hatch | thx | 21:29 |
| rick_h__ | hatch: np | 21:29 |
| hatch | turns out to be exactly what you said all along | 21:30 |
| hatch | I was thrown by the wako results in regexpal | 21:30 |
| rick_h__ | once in a while I get lucky :) | 21:30 |
| hatch | needed to revert to the console | 21:30 |
| rick_h__ | yea, tests or bust! | 21:31 |
| hatch | regex pal for some reason highlights http: as well | 21:31 |
| rick_h__ | oh hmm, strange. | 21:31 |
| hatch | the console results are correct though | 21:32 |
| hatch | ohh the regex is slightly off | 21:34 |
| hatch | it should drop the first # | 21:34 |
| rick_h__ | hatch: ah, well the regex is only matching. In the match you can split/slice/trim to get rid of it. | 21:35 |
| rick_h__ | hatch: I think there's some rtrim/etc functions available in there /me isn't at his desktop atm | 21:35 |
| hatch | yep but the regex should only return the proper data | 21:35 |
| hatch | why take another step when you don't have to | 21:35 |
| rick_h__ | hatch: well, you're asking it to match. It's going to match the character. I tried once to do a #(xxx) type of things but didn't see a good way to get at the () part | 21:36 |
| hatch | ahh ok | 21:36 |
| rick_h__ | hatch: well, if you find a good way let me know, but I've manually trimmed/etc in my use. You know it'll be there because it's part of the match so it'll always be there | 21:36 |
| hatch | rick_h__: ([#])(.[^?/]*)? | 21:41 |
| hatch | use this url: http://gui:8888/sidebar/precise/ceph-9/:flags:/browser_enabled/#bws-configuration=foobar&stuff=awesome?query=charms | 21:41 |
| hatch | the 3rd match.... | 21:41 |
| hatch | pretty sure this isn't ideal | 21:41 |
| hatch | haha | 21:41 |
| hatch | can drop the [] in the first parens I guess | 21:42 |
| rick_h__ | hatch: this is nicer than just url.match(/#[^?/]/).replace('#', ''); ? | 21:44 |
| rick_h__ | sorry | 21:44 |
| rick_h__ | hatch: this is nicer than just url.match(/#.[^?/]*/).replace('#', ''); ? | 21:44 |
| hatch | it's a lot harder to understand so yes | 21:44 |
| hatch | :P | 21:44 |
| rick_h__ | lol | 21:44 |
| hatch | rick_h__: did you want to pull down my branch to test? | 21:48 |
| rick_h__ | hatch: not atm, I'm EOD and on the tablet. | 21:48 |
| hatch | ahh ok jcsackett still around? | 21:48 |
| rick_h__ | hatch: my branch if up if you want to test it out 100%, but if that urls passes I'm good | 21:48 |
| rick_h__ | hatch: go ahead with it and I'll pull the update down into my branch tomorrow | 21:49 |
| hatch | here is the diff, look good? http://bazaar.launchpad.net/~hatch/juju-gui/routing-hash-query/revision/714 | 21:49 |
| rick_h__ | https://code.launchpad.net/~rharding/juju-gui/direct-2-tab is my branch | 21:50 |
| rick_h__ | hatch: looks ok from here | 21:51 |
| hatch | I figured you could just see the tests to see that it appears to cover all of the use cases we need | 21:51 |
| hatch | urls are the epitome of edge cases | 21:51 |
| rick_h__ | hatch: yea, don't need to get 100% atm, but having tests and getting the - we know we need will help :) | 21:52 |
| hatch | rick_h__: so I can't propose this because lint is giving me an odd error | 22:05 |
| hatch | var match = url.match(/(#)(.[^?\/]*)?/); | 22:05 |
| rick_h__ | hatch: is it because of the /? | 22:05 |
| hatch | line 111, col 34, Insecure '.' | 22:05 |
| rick_h__ | ah, yea | 22:05 |
| rick_h__ | hatch so change the start and end / to " | 22:05 |
| hatch | quote a regex? I thought that was a nono | 22:05 |
| rick_h__ | the start/end chars can be anything I believe | 22:06 |
| rick_h__ | making them " makes the liter shush | 22:06 |
| rick_h__ | so actually ' since the litner will fuss over " vs ' | 22:06 |
| hatch | yah - that's odd | 22:06 |
| hatch | I wonder it's reasoning | 22:06 |
| rick_h__ | hatch: yea, I gave up trying to understand and just bend to the will of the linter | 22:07 |
| hatch | hehe | 22:07 |
| rick_h__ | trying to change it in the case of a regex like that just seems like it'd be a pita to detect the exception | 22:08 |
| rick_h__ | hatch: I think the warning is that . matches any character and can be a case of 'getting more than you wish for' when it comes to regex | 22:09 |
| rick_h__ | hatch: so I *think* it's a warning because of that, but it's messier to add ignore/etc clauses around the code than to just ' vs / | 22:09 |
| hatch | true true | 22:09 |
| hatch | I really need to figure out why phantomjs keeps crashing | 22:10 |
| hatch | it crashes probably 50% of the time :/ | 22:10 |
| rick_h__ | :/ | 22:10 |
| rick_h__ | that sucks, not here | 22:10 |
| rick_h__ | trying to use it more and more since it's a chunk faster than even chrome in test runs | 22:10 |
| hatch | oh yeah it should be way faster because it doesn't have to do any DOM updates | 22:11 |
| hatch | and I think they are both V8 aren't they? | 22:11 |
| rick_h__ | yea | 22:12 |
| rick_h__ | hah, did bcsaller just submit an update while you've been working on this :( | 22:13 |
| rick_h__ | hatch: heh, so bcsaller updated the branch, but I think the regex is a little nicer and fewer calls. Compare notes I guess with each other and I'll pull down which ever survives the night for my needs | 22:14 |
| hatch | heh | 22:14 |
| hatch | clearly you should pick mine | 22:15 |
| bcsaller | yeah, sorry about that | 22:15 |
| bcsaller | just trying to help | 22:15 |
| hatch | pfft | 22:15 |
| hatch | ;) | 22:15 |
| hatch | so how will we settle this? | 22:16 |
| hatch | put both branches in a url parsing test to see who's wins? | 22:16 |
| hatch | :P | 22:16 |
| bcsaller | well, I didn't add a test for the new case so if you have that you win :) | 22:16 |
| rick_h__ | implementation fight! go go go! | 22:16 |
| hatch | I did! | 22:16 |
| hatch | yusss | 22:16 |
| rick_h__ | I want to see timeit results! | 22:16 |
| hatch | lol | 22:17 |
| hatch | regex vs two indexof and a slice call | 22:17 |
| hatch | oo it would be a close one | 22:17 |
| hatch | micro optomization ftw | 22:17 |
| rick_h__ | thanks bcsaller, appreciate the update | 22:19 |
| * hatch is going to land his branch if he can get some reviews | 22:19 | |
| hatch | https://codereview.appspot.com/10176043/ | 22:19 |
| hatch | as soon as I ask for a review it goes quiet in here..... | 22:21 |
| hatch | lol | 22:21 |
| rick_h__ | hatch: heh, well it's hard to multi-task and use the code review site on a tablet | 22:26 |
| rick_h__ | every touch to the screen brings up a comment box and moves code around, most annoying | 22:26 |
| hatch | haha yeah it's probably not under active development | 22:31 |
| hatch | not really sure what to do re your comment rick_h__ | 22:32 |
| rick_h__ | hatch: yea, me either, but if we're going to add a TODO seems there should be something to make sure it does get done one day, be it bug, card, etc | 22:34 |
| hatch | yeah a bug probably | 22:35 |
| hatch | I don't really understand what it's saying though so maybe we can leave that one for bcsaller to make | 22:35 |
| bcsaller | hatch: already resolved by line 314 | 22:37 |
| hatch | bcsaller: so that comment can be removed? | 22:37 |
| bcsaller | yes | 22:37 |
| hatch | kewl | 22:37 |
| hatch | I'm going to land after removing that comment as it's like a pair programming at this point :) | 22:37 |
| bcsaller | otherwise those could appear as namespaces, but they are non-enum props on Routes objects | 22:38 |
| hatch | ahh I understand now | 22:38 |
| hatch | ok changing and submitting | 22:38 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!