[06:59] <oSoMoN> good morning gusch
[06:59] <gusch> oSoMoN: hi
[06:59] <oSoMoN> gusch: would you be available for a short review?
[07:00] <gusch> oSoMoN: sure
[07:00] <oSoMoN> gusch: https://code.launchpad.net/~osomon/webbrowser-app/open-blank-in-new-tab-from-frame/+merge/168131 thanks!
[07:12] <gusch> oSoMoN: approved
[07:12] <oSoMoN> gusch: thanks!
[07:58]  * Mirv uploads qt quick control / layouts 5.1 beta into a PPA for anyone interested in that new module
[08:19] <nerochiaro> oSoMoN: hi, do you know why in webbroser-app you have tests/unittests/tst_QmlTests.cpp that doesn't seem to have any test code in it ?
[08:22] <oSoMoN> nerochiaro: read http://qt-project.org/doc/qt-5.0/qtquick/qtquick2-qtquick-qtquicktest.html#running-tests
[08:23] <nerochiaro> oSoMoN: got it, thanks
[08:44] <oSoMoN> nerochiaro: has seb128 pinged you about licensing issues in notes-app?
[08:45] <nerochiaro> oSoMoN: not yet
[08:47] <oSoMoN> nerochiaro: then please ping him about it, iirc it was rather urgent, there are mixed license headers that need to be made consistent across the app
[08:47] <nerochiaro> oSoMoN: ok
[08:55] <gusch> oSoMoN nerochiaro can you do a (lengthy) MR? https://code.launchpad.net/~schwann/gallery-app/gallery-initial-video-class/+merge/168139
[08:57] <oSoMoN> gusch: sure
[08:57] <gusch> oSoMoN: thx
[09:31] <om26er> gusch, so it seems I fixed the jenkins failure "Statenotfounderror". by initiating the variables everywhere. I am in talk with autopilot developers for suggestions about handling that error better.
[09:31] <om26er> https://code.launchpad.net/~om26er/gallery-app/fix_jenkins_failure/+merge/168062
[09:32] <om26er> Now the test is finally passing on the Nexus 7
[09:35] <gusch> om26er: cool - approved
[10:43] <AskUbuntu> How to call several time a DefaultSheet | http://askubuntu.com/q/306408
[11:31] <oSoMoN> gusch: I commented on your MR
[11:32] <gusch> oSoMoN: ok - thx - working on it
[11:34] <oSoMoN> gusch: also, when you have a moment, could you please take a look at https://code.launchpad.net/~osomon/webbrowser-app/escape-regex/+merge/168408 ?
[11:34] <gusch> oSoMoN: sure
[11:35] <nerochiaro> oSoMoN: i'm running into some issues in setting up both unit and autopilot tests for the browser plugin, and i was wondering if you had a bit of time to give me some advice
[11:35] <oSoMoN> nerochiaro: sure
[11:38] <nerochiaro> oSoMoN: pushing the branch, one minute. for unit tests i don't understand why they fail when running under debuild but they are passing otherwise. for autopilot i don't understand why most fail (and i know some of these tests need to stay in webbrowser-app)
[11:38] <nerochiaro> oSoMoN: lp:~amanzi-team/ubuntu-ui-extras/ubuntu-ui-extras-initial
[11:48] <oSoMoN> nerochiaro: will have a look after lunch
[11:49] <nerochiaro> oSoMoN: ok, i'm taking care of these copyright headers in the meantime
[11:56] <gusch> oSoMoN: works for me - approved (not yet top approved)
[12:40] <nerochiaro> timp: hi, do you know if zsombi will be around today ?
[12:40] <timp> nerochiaro: no, he is off today. should be back tomorrow
[12:40] <nerochiaro> timp: ok,thanks
[12:46] <oSoMoN> nerochiaro: trying your branch, when I cd into tests/autopilot and then run "autopilot list browser", I’m getting lots of import errors, trivial to fix
[12:46] <nerochiaro> oSoMoN: ok,that's strange. when i do the same i just get the list of tests. let me try from a fresh checkout
[12:47] <oSoMoN> nerochiaro: maybe because you have built a package and installed it?
[12:48] <nerochiaro> oSoMoN: i don't think so, but let me double check that
[12:48] <nerochiaro> oSoMoN: nope, no package installed
[12:49] <nerochiaro> oSoMoN: ok, confirm the errors you see on a fresh checkout. i'm looking into them
[12:50] <nerochiaro> oSoMoN: in the meantime the unit tests have issues too
[12:50] <nerochiaro> oSoMoN: when run under debuild
[12:52] <oSoMoN> nerochiaro: what sorts of issues, do you have logs?
[12:53] <nerochiaro> oSoMoN: it basically can't import the component, while if i run it with ctest manually it finds it. i can sure get you logs but it's probably quicker if you just run debuild -uc -us -b on the branch
[13:00] <oSoMoN> nerochiaro: the solution to your problem is at line 20 of bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/Ubuntu/Browser/CMakeLists.txt
[13:08] <oSoMoN> renato_: hey, has seb128 pinged you already about license headers in the mediaplayer app?
[13:10] <renato_> oSoMoN, not yet
[13:10] <renato_> oSoMoN, what is the problem?
[13:11] <oSoMoN> renato_: apparently there are some inconsistencies in the copyright/license headers that prevent the inclusion in the archive, please ping him to get it sorted out asap
[13:11] <renato_> oSoMoN, ok thanks
[13:14] <nerochiaro> oSoMoN: what you mean by that is that the files are not getting copied to the right place ?
[13:16] <oSoMoN> nerochiaro: yes, it seems like you omitted copying this piece of the CMakeLists.txt when porting to your new structure
[13:19] <gusch> oSoMoN: all your comment are fine now and jenkins approved https://code.launchpad.net/~schwann/gallery-app/gallery-initial-video-class/+merge/168139
[13:21] <oSoMoN> gusch: let me see
[13:23] <oSoMoN> gusch: added one comment, but take it as a suggestion only, as far as I’m concerned it’s approved
[13:25] <gusch> oSoMoN: I'm used to use QCOMPARE only - that was the policy in my last team ;)
[13:25] <nerochiaro> oSoMoN: ok, so for unit tests we're good, your suggestion fixed it
[13:26] <gusch> oSoMoN: I'll top approve it then, ok?
[13:27] <oSoMoN> gusch: sure -- weird policy though, but yeah, go ahead
[13:31] <gusch> nerochiaro oSoMoN renato_ anyone up for a review? https://code.launchpad.net/~schwann/gallery-app/gallery-util-qt-style/+merge/168348
[13:33] <gusch> boiko: ^
[13:35] <boiko> gusch: well, as I just came back my system is upgrading, so it might take some time for me to review this one, but I can take it if it is not urgent
[13:36] <gusch> boiko: well - this is the first in a long list of MR - they are long, but include (more or less) only renaming of functions/variables
[13:39] <gusch> https://code.launchpad.net/~schwann/gallery-app/gallery-util-qt-style/+merge/168348
[13:39] <gusch> https://code.launchpad.net/~schwann/gallery-app/gallery-core-qt-style/+merge/168352
[13:39] <gusch> https://code.launchpad.net/~schwann/gallery-app/gallery-medialoader-qt-style/+merge/168355
[13:39] <gusch> https://code.launchpad.net/~schwann/gallery-app/gallery-media-qt-style/+merge/168357
[13:39] <gusch> https://code.launchpad.net/~schwann/gallery-app/gallery-album-qt-style/+merge/168367
[13:39] <gusch> https://code.launchpad.net/~schwann/gallery-app/gallery-database-qt-style/+merge/168372
[13:39] <gusch> https://code.launchpad.net/~schwann/gallery-app/gallery-event-qt-style/+merge/168373
[13:39] <gusch> https://code.launchpad.net/~schwann/gallery-app/gallery-photo-qt-style/+merge/168374
[13:39] <gusch> https://code.launchpad.net/~schwann/gallery-app/gallery-qml-qt-style/+merge/168376
[13:39] <gusch> https://code.launchpad.net/~schwann/gallery-app/gallery-src-qt-style/+merge/168379
[13:40] <gusch> boiko oSoMoN nerochiaro renato_ this is the list of my MRs
[13:40] <boiko> gusch: wow, that's really a long list of MRs :)
[13:40] <gusch> the are long, but simple (renaming only)
[13:40] <gusch> at least I tried to split it up a bit ;)
[13:40] <boiko> gusch: are they dependent on each other?
[13:40] <gusch> boiko: yep
[13:41] <boiko> gusch: ah ok, so maybe someone else can pick the first one and then I pick the next
[13:41] <gusch> boiko: approvals can be done in any order - jenkisn will take care of that
[13:42] <boiko> gusch: ah ok, so you set the dependencies correctly, ok, I will review the first one then
[13:42] <gusch> boiko: thx
[13:42] <oSoMoN> gusch: I’ll get some of them, just not right now, I’ll ping you when I have some spare time
[13:44] <gusch> oSoMoN: I guess I have to wait a bit, to get them all done ;)
[13:44] <gusch> oSoMoN: it's renaming only - but afterwards gallery will have one coding style only (instead of 3 or 4)
[13:44] <victorp> Kaleo, ping
[13:44] <gusch> that drives me crazy ...
[13:45] <oSoMoN> ack, one coding style to rule them all…
[13:48] <Kaleo> victorp: im off today, anytginh urgent?
[13:48] <victorp> Kaleo, bzoltan1 -not urgent,  just to let you know that the "torch" component in multimedia is not working and neither is the Camera.FlashTorch mode..
[13:49] <Kaleo> victorp: can u check with nerochiaro I thought he was using that
[13:49] <gusch> victorp: how did you test it?
[13:50] <nerochiaro> victorp: camera is using FlashTorch mode
[13:50] <gusch> Kaleo victorp Qt camera plugin was done by me ...
[13:50] <victorp> I created an app and added a torch component and didnt work :)
[13:51] <gusch> victorp: can you send me your code/project (I'm lazy ;)
[13:51] <victorp> gusch https://code.launchpad.net/~vtuson/+junk/torchapp
[13:51] <victorp> I could only get it to work using
[13:52] <gusch> victorp: thx - which device / image?
[13:52] <victorp> a camera component with Camera.FlashVideoLight
[13:52] <victorp> I am using Galaxy nexus
[13:52] <victorp> image is fridays
[14:00] <gusch> victorp: ok - I'm looking at it (torch works for the camera app)
[14:01] <victorp> gusch, torch flash setting or torch component
[14:01] <victorp> can you point me to the code ?
[14:01] <gusch> victorp: the setting
[14:04] <victorp> ok
[14:04] <victorp> looking at https://code.launchpad.net/~phablet-team/camera-app/trunk
[14:04] <gusch> victorp: http://bazaar.launchpad.net/~phablet-team/camera-app/trunk/view/head:/Toolbar.qml
[14:05] <victorp>  if (torchMode) {
[14:05] <victorp>                     camera.flash.mode = (flashState == "on") ?
[14:05] <victorp>                                         Camera.FlashOff : Camera.FlashVideoLight;
[14:05] <victorp> which is how I got my app to work
[14:08] <victorp> looking at http://qt-project.org/doc/qt-5.0/qtmultimedia/qml-qtmultimedia5-cameraflash.html
[14:08] <victorp> that option is not even in the standard enumeration gusch
[14:09] <victorp> IMHO should be Camera.FlashTorch
[14:09] <gusch> victorp: hmm - seems like they remove it from the final Qt5 (documentation)
[14:09] <victorp> nerochiaro, ^^
[14:10] <victorp> yeap, the documentation implies that for viedo you should use Camera.FlashTorch
[14:10] <victorp> I dont think it matters for the camera apps
[14:11] <victorp> I think the problem is that using Camera.FlashTorch you get nothing, which I guess is why Torch component doesnt work either
[14:11] <victorp> gusch, ^
[14:11] <gusch> victorp: what torch component? But I guess yes
[14:13] <victorp> gusch, this torch component http://qt-project.org/doc/qt-5.0/qtmultimedia/qml-qtmultimedia5-torch.html
[14:14] <victorp> gusch, can we just map  Camera.FlashTorch to the same value to Camera.FlashVideoLight ?
[14:14] <gusch> victorp: I guess that's what I'll do - just checking ...
[14:16] <gusch> victorp: yes, the component uses the FlashTorch
[14:16] <gusch> victorp: I'll fix that
[14:16] <victorp> gusch, ok, I leave it with ya.. do you want me to open a bug?
[14:16] <gusch> victorp: not really needed - I'll do a MR in a few minutes ;)
[14:17] <victorp> okey dokey
[14:17] <victorp> thnx
[14:17] <victorp> gusch,  I will leave my app using  Camera.FlashVideoLight anyhow
[14:19] <oSoMoN> nerochiaro: hey, when you have a moment, could you please confirm bug #1189483 ?
[14:19] <ubot2`> Launchpad bug 1189483 in webbrowser-app "Error sheet still visible after closing tab" [Undecided,New] https://launchpad.net/bugs/1189483
[14:21] <gusch> victorp: I till do a MR for fixing this in a few minutes - so I don't think we need a bug report
[14:21] <gusch> us said that already ...
[14:21] <gusch> ups said that already ...
[14:22] <victorp> oks
[14:23] <nerochiaro> oSoMoN: ok, looking into it. regarding the autopilot tests, i fixed & pushed the trivial erorrs on imports (sorry about that, last moment rename of the package). but now if you run pretty much any test, you will see there's some issue with the dimensions of the window, i am not really sure why it's getting the values that it's getting.
[14:24] <nerochiaro> oSoMoN: basically what I do is to just run in qmlscene a simple qmlfile that imports the browser component and instantiates it as the root
[14:24] <nerochiaro> oSoMoN: and modified main_window.py to get the browser component itself as the root instead of QQuickView
[14:24] <oSoMoN> nerochiaro: I’ll look into it in a moment
[14:38] <oSoMoN> nerochiaro: the autopilot tests that I’ve tried running fail because they expect that the browser will be opened with an initial URL, and it’s not, so there’s something that’s not working either with the component itself, or with the tests initialization
[14:46] <nerochiaro> oSoMoN: was the browser autoloading an address something internal to the component ?
[14:47] <oSoMoN> nerochiaro: no, that’s specific to the app, but then the tests need to be adapted
[14:49] <nerochiaro> oSoMoN: ok, i'll look into that
[14:50] <nerochiaro> oSoMoN: i just noticed that the fix for unit tests didn't actually fix it. or at least not after i fully cleaned the tree. revision 9 is the fix i copied from the webbrowser-app branch
[14:50] <oSoMoN> nerochiaro: looking
[14:51] <gusch> victorp: I have an MR (but have trouble testing it at the device atm) https://code.launchpad.net/~schwann/qtubuntu-camera/camera-torch-support/+merge/168468
[14:53] <nerochiaro> oSoMoN: hold on that,  i spotted my mistake i think
[14:57] <oSoMoN> nerochiaro: there’s no revision 9 to pull anyway…
[15:11] <om26er> mhall119, have a autopilot structure branch for the terminal-app pending there for a few days. can you get the developers to look into that ? https://code.launchpad.net/~om26er/ubuntu-terminal-app/initial_autopilot
[15:14] <gusch> victorp: are you willing to test and approve my MR?
[15:15]  * om26er is fascinated a total of 82lines is the torch app.
[15:17] <victorp> gusch, i can look at it but not right now, sorry
[15:17] <gusch> victorp: that's ok - no hurry there ;)
[15:20] <victorp> gusch, :)
[15:20] <victorp> gusch,  is there a test image I can use? how do I test it?
[15:21] <gusch> victorp: jenkins will produce a dep file (link in the MR)
[15:21] <gusch> victorp: install it on the phone (and hope camera won't break - but there is a chance it will)
[15:22] <mhall119> om26er: sure, he's been out for a bit but he's back again today
[16:16] <kalikiana> somebody with a phone who could quickly run a test qml file?
[16:17] <kalikiana> I'd like to check something but my device is between me and a lot of sea and land mass :-]
[16:18] <kalikiana> http://paste.ubuntu.com/5752154/
[17:02] <om26er> boiko, hey!
[17:03] <om26er> boiko, the phone-app hangs for a few seconds on startup if we have a large number of contacts
[17:03] <boiko> om26er: really? weird, it shouldn't
[17:04] <boiko> om26er: but anyway, the code that is in there is going to be replaced by renato_'s new contact service
[17:04] <om26er> boiko, sounds good
[17:04] <boiko> om26er: the new service supports paginated results so we can better balance the load between keeping the UI responsive and load contacts
[17:05] <om26er> boiko, also for doing things more efficient we could get a bit help from the opensource android apps like the contacts
[17:05] <boiko> om26er: help like what?
[17:06] <boiko> om26er: the new service uses some concepts from the way android does things, but it is mapped to our context and technologies
[17:06] <om26er> boiko, dealing with long lists of data or loading of thumbnails in gallery etc
[17:06] <om26er> right
[17:07] <boiko> om26er: if you want to check, I can point you to the documents where we have discussed the service renato_ is implementing
[17:07] <om26er> boiko, yeah, do share
[17:07] <boiko> om26er: let me find that
[17:08] <om26er> boiko, this service is going to be open for third party apps as well ?
[17:08] <boiko> renato_: do you have the link to the document around? I have to dig here to find it
[17:09] <boiko> om26er: probably yes
[17:10] <boiko> om26er: found this one: https://wiki.ubuntu.com/Touch/Specs/ContactsService
[17:10] <om26er> boiko, thanks
[17:11] <renato_> boiko, which document?
[17:12] <boiko> renato_: the ones about the contacts service
[17:12] <boiko> renato_: or is everything already in that ubuntu wiki page?
[17:17] <renato_> I think the ubuntu wiki is the official one, the other doc that I have is the API
[17:19] <boiko> renato_: ok, thanks
[17:27] <om26er> nerochiaro, Hey! so the notes-app not working well is a bug in the SDK ? can you point me to a bug report for the sdk bug ?
[18:00] <nerochiaro> om26er: i haven't filed one yet, need to speak a little bit more with zsombor but he's out today
[18:03] <om26er> nerochiaro, i'll ping you about that tomorrow then ;)
[18:49] <nik90> does anyone know how to get the current UTC time in qml?
[18:49] <nik90> At the moment, I am getting the locale time using new Date()
[19:23] <AskUbuntu> Where can a beginner learn ubuntu game development? | http://askubuntu.com/q/306575