| === matsubara is now known as matsubara-lunch | ||
| * frankban lunches | 12:11 | |
| gary_poster | ugh | 12:12 |
|---|---|---|
| gary_poster | if we could actually land Makyo's zoom-to-service branch that would be fab. uistage still has silly people | 12:12 |
| rick_h__ | review request bribing time: https://codereview.appspot.com/10140047 please orangesquad or hatch who's not here yet or anyone else that loves tabs in the browser. | 12:53 |
| === teknico1 is now known as tekNico | ||
| tekNico | gary_poster: thanks for assigning that card to me, I got distracted | 13:13 |
| gary_poster | tekNico, np :-) | 13:13 |
| jcsackett | rick_h__: looking. | 13:25 |
| tekNico | gary_poster: I'm assuming that adding the AGPL to the charm means adding the license file itself, and the header to all source files. Anything else? | 13:26 |
| gary_poster | tekNico, there's a Canonical-specific list to follow. that might be everything. Let me try to find it again... | 13:27 |
| gary_poster | tekNico, see https://sites.google.com/a/canonical.com/legal-services/software-ip | 13:29 |
| tekNico | gary_poster: thanks | 13:29 |
| gary_poster | Makyo, hi. If you are around and can make it, I scheduled you on Tuesdays for the Juju core kanban review (check your calendar). If you can't make it today because of the short notice, np | 13:47 |
| gary_poster | frankban, hi. I saw that jcsackett's branch failed in jenkins only on the two test_charm_deploy tests. It doesn't look like the error tells us much, but do you have any deep suggestions? | 13:50 |
| gary_poster | non-deep suggestions: jcsackett runs the tests locally and sees how they do :-) | 13:51 |
| jcsackett | gary_poster: they pass. | 13:51 |
| gary_poster | jcsackett, that's the charm deploy tests too? | 13:51 |
| gary_poster | I figured the unit tests did :-) | 13:51 |
| jcsackett | gary_poster that's test-misc, right? | 13:52 |
| gary_poster | uh. I don't *think* so. looking. | 13:52 |
| frankban | jcsackett: no, that's bin/test-charm | 13:52 |
| jcsackett | frankban: ah. | 13:53 |
| gary_poster | yeah, that's what I thought :-) | 13:53 |
| frankban | jcsackett: instructions on how to run local ci tests are in docs/continuous-integration.rst | 13:54 |
| jcsackett | frankban, gary_poster: Invalid environment 'juju-gui-testing' | 13:54 |
| frankban | jcsackett: see docs/continuous-integration.rst ^^^ | 13:55 |
| gary_poster | jcsackett, yeah frankban gave you the doc to try. FWIW, this is entirely something that jenkins is supposed to catch, and that you didn't need to run beforehand. May I ask this? (1) you try to get the local ci tests running. Assuming you do, (2) verify that they pass for you. Assuming they do, (3) toss it to me and forget about it yourself. | 13:56 |
| gary_poster | jcsackett, you may skip to step 3 at any point if you get too fed up :-) | 13:56 |
| === teknico1 is now known as tekNico | ||
| frankban | jcsackett, gary_poster: it seems selenium wants to click the deploy button while it's still not visible, taking a look locally seems reasonable. oh... is the charm panel still there? if not, we have to rewrite the deploy tests | 13:57 |
| jcsackett | gary_poster: sure, i can poke at them locally. | 13:58 |
| gary_poster | thanks jcsackett . frankban charm panel still there I think | 13:59 |
| gary_poster | upcoming branch removes it | 13:59 |
| hatch | rick_h__: still need that review? | 13:59 |
| hatch | and morning | 13:59 |
| rick_h__ | hatch: yes please, and morning to you to | 14:00 |
| hatch | tekNico: sorry I didn't realize that the cookie code was given to you :) | 14:01 |
| tekNico | hatch: yeah, I changed it anyway, can change it some more :-) | 14:02 |
| frankban | gary_poster: this is probably unrelated, but I am not able to deploy appflower (and other charms) in uistage | 14:03 |
| jcsackett | gary_poster: to make sure i am understanding this right, "local" is a bit of misnomer, as i need to run this out to canonistack or ec2? | 14:03 |
| * jcsackett is reading docs, as this is all new. | 14:04 | |
| gary_poster | frankban, it works if you give it a unique name | 14:05 |
| tekNico | hatch: what's the best time for a follow-up hangout for you? | 14:05 |
| gary_poster | frankban, some people think it is amusing to drag everything off to the right | 14:05 |
| gary_poster | I think they might even have scripted it | 14:06 |
| frankban | gary_poster: oh :-( | 14:06 |
| tekNico | it's a weird kind of QA :-) | 14:06 |
| hatch | tekNico: pretty soon, I'm just reviewing ricks' branch first | 14:08 |
| tekNico | hatch: ok, thanks | 14:08 |
| hatch | rick_h__: can you pull in the hash branch I landed last night and use the parsed hash? | 14:09 |
| rick_h__ | hatch: it should have it since it landed in trunk | 14:09 |
| * rick_h__ goes to check diff... | 14:09 | |
| hatch | I'm just asking because in browser.js you use window.location.hash | 14:09 |
| gary_poster | jujugui I just switch uistage to sandbox. Too annoyed at the script kiddies | 14:09 |
| hatch | yay | 14:10 |
| frankban | cool | 14:10 |
| rick_h__ | hatch: heh, yea I've pulled your changes in the routing code, but in the browser subapp I just grab it from the browser. | 14:10 |
| hatch | :) | 14:11 |
| rick_h__ | hatch: is the router adding the hash to the req in the app callables? | 14:11 |
| rick_h__ | hatch: the router updates keep it from losing the hash and re-routing, but didn't see it provide it down into the app somewhere. | 14:12 |
| hatch | I thought that the hash was available in there | 14:13 |
| hatch | regardless | 14:13 |
| hatch | just booting one up to check | 14:13 |
| rick_h__ | hatch: I don't think it's part of the yui parsed request object passed in | 14:14 |
| hatch | hmm looks like you are right, maybe you should use nsRouter.parse(url).hash | 14:17 |
| hatch | not entirely sure it's necessary however | 14:17 |
| rick_h__ | hatch: yea, the goal was just to not have the router blow the hash away from window.location.hash. I don't see any harm in me reading it from there in the actual request handling bit. | 14:18 |
| hatch | yeah | 14:18 |
| rick_h__ | hatch: it's r/o | 14:18 |
| hatch | r/o ? | 14:18 |
| rick_h__ | read-only | 14:18 |
| abentley | orangesquad: could you please review https://code.launchpad.net/~abentley/charmworld/missing-content-type/+merge/168672 ? | 14:18 |
| rick_h__ | abentley: looking | 14:19 |
| rick_h__ | abentley: r=me | 14:19 |
| abentley | rick_h__: Thanks! | 14:20 |
| hatch | rick_h__: review done | 14:23 |
| rick_h__ | hatch: reply inbound | 14:24 |
| rick_h__ | jcsackett: if you get a second can you peek at my reply/update for the second +1 please | 14:25 |
| hatch | rick_h__: cool | 14:26 |
| hatch | tekNico: guichat? | 14:30 |
| tekNico | hatch: I'm doing a review myself now :-) a few minutes and I'm done, ok | 14:30 |
| hatch | okee sure np | 14:31 |
| tekNico | hatch: don't start another review yourself though ;-) | 14:31 |
| hatch | haha nope | 14:31 |
| jcsackett | hatch: do you have a second to chat? | 14:32 |
| hatch | lets do it | 14:32 |
| hatch | guichat | 14:32 |
| jcsackett | }"?cccccc | 14:32 |
| hatch | lol wth | 14:32 |
| jcsackett | dog knocked over my computer, yubikey hit couch. | 14:32 |
| hatch | haha | 14:32 |
| jcsackett | hey, this is better than it was a week ago; then i would just accidentally whack it myself. | 14:33 |
| gary_poster | orangesquad, hey. hazmat pointed out that if you go to http://uistage.jujucharms.com:8080/fullscreen/ and click on a category on right you get an error | 14:35 |
| gary_poster | known? | 14:35 |
| gary_poster | known fix? | 14:35 |
| rick_h__ | gary_poster: looking. We had another bug with that fixed. Looks like a new one was hiding underneath | 14:36 |
| gary_poster | thx | 14:36 |
| rick_h__ | gary_poster: filing a bug now and will get it on the board to look at. | 14:37 |
| abentley | rick_h__: The URL is wacky-- it has ? where it should have & | 14:37 |
| rick_h__ | abentley: yea, and series is in there several times | 14:38 |
| rick_h__ | abentley: will look into it right now as I've not gotten into the other card much yet, landing yesterday's stuff | 14:38 |
| tekNico | hatch: hangout? https://plus.google.com/hangouts/_/02bb45411739e441fe107c9f66e2a8cc36ba4ba7?authuser=0&hl=en | 14:41 |
| hatch | tekNico: sorry in a hangout now :) | 14:41 |
| tekNico | oh wow :-) | 14:42 |
| jcsackett | frankban: so, i've read through the docs, i'm unsure how to debug this test locally. how does one do that? | 14:42 |
| hatch | we need to update the CI docs with instructions on how to do it locally from start to finish | 14:43 |
| hatch | tekNico: guichat? | 14:46 |
| tekNico | hatch: yep! | 14:46 |
| jcsackett | gary_poster: i think i may be jumping to option 3 here, as i cannot see how to do this locally on my machine, and if local actually means "running on ec2" i don't have any of that setup since having to reinstall and probably don't have the time/bandwidth to get that set up today. | 14:47 |
| gary_poster | jcsackett, ack but on call | 14:48 |
| jcsackett | dig. | 14:48 |
| frankban | jcsackett: I suggest configuring the juju-gui-testing env with the ec2 provider and then running NO_DESTROY=1 JUJU_GUI_TEST_BROWSERS="local-firefox" bin/test-charm. | 14:48 |
| frankban | jcsackett: later you can repeat the tests without boostrapping the env again with APP_URL="http://ec2-xxx-yyy.example.com" bin/test-charm | 14:49 |
| frankban | this way the tests will be run in your local firefox, and you can debug/pdb as usual | 14:49 |
| abentley | rick_h__: To properly fix bug #1176452, we think we need to change the JSON stored by mongo and elasticsearch. That will change the json emitted by the original API (e.g. http://staging.jujucharms.com/charms/precise/mysql/json). Do we know of anything still using that API? | 14:53 |
| _mup_ | Bug #1176452: ElasticHttpError:NumberFormatException[For input string: "yes" <elasticsearch> <ingest> <oops> <charmworld:Triaged> <https://launchpad.net/bugs/1176452> | 14:53 |
| rick_h__ | abentley: looking | 14:53 |
| rick_h__ | abentley: yes, until the branch that removes the old browser lands it's using and calling that and might throw errors since it auto loads results on init | 14:53 |
| rick_h__ | abentley: we should chat with sinzui about getting the old browser code out of there soon now that we're landing browser by default. | 14:54 |
| abentley | sinzui, rick_h__: I'm up for a chat anytime. | 14:54 |
| rick_h__ | gary_poster: you had mentioned there was a branch for removing the old browser already? Or did I mis-read that? | 14:55 |
| gary_poster | rick_h__, misread | 14:55 |
| rick_h__ | gary_poster: ok, cool. | 14:55 |
| sinzui | abentley, jcsackett and are about to have our our weekly call. We will be done about 30 minutes from now | 14:56 |
| rick_h__ | sinzui: rgr | 14:56 |
| abentley | sinzui: Cool. | 14:56 |
| gary_poster | jcsackett, are you trying frankban's instructions or do you still want step 3? | 15:07 |
| hatch | I don't think he had juju environments and ec2 set up | 15:08 |
| hatch | and I wasn't sure how to run it all locally | 15:08 |
| gary_poster | jujugui ci is failing. could someone volunteer to investigate as critical task please? | 15:25 |
| hatch | gary_poster: sure | 15:27 |
| hatch | if the alert can wait :) | 15:27 |
| gary_poster | hatch alert is high priority too. frankban do you have half hour to investigate first? | 15:28 |
| gary_poster | or tekNico | 15:28 |
| tekNico | gary_poster: I'm juggling two things already... | 15:28 |
| gary_poster | tekNico, then not you :-) | 15:29 |
| gary_poster | tekNico, what's your non-GPL thing? | 15:29 |
| tekNico | gary_poster: the cookies warning, hatch just revolutionized it :-) | 15:30 |
| gary_poster | tekNico, heh oh ok | 15:30 |
| tekNico | (is that a verb?) | 15:30 |
| hatch | it can be :) | 15:30 |
| gary_poster | uh, not sure | 15:30 |
| gary_poster | yeah | 15:30 |
| gary_poster | it is | 15:30 |
| tekNico | ok, thanks :-) | 15:30 |
| hatch | the rules of English were made to be broken | 15:31 |
| gary_poster | hatch revolutionized the cookies industry! | 15:31 |
| hatch | lol | 15:31 |
| gary_poster | we're Americans. We like verbing things. | 15:31 |
| hatch | and forgetting u's | 15:31 |
| hatch | ie) colour | 15:31 |
| gary_poster | yeah. Canadians do that too, yeah? | 15:31 |
| hatch | nope we love our u's | 15:31 |
| gary_poster | oh. stinky u's. :-) | 15:32 |
| hatch | favour | 15:32 |
| hatch | lol | 15:32 |
| tekNico | (actually three things, I'm also qa'ing a branch by frankban) | 15:34 |
| hatch | is there a UX bug for the width of the sidebar? | 15:36 |
| hatch | ^ luca__ | 15:37 |
| jcsackett | gary_poster: sorry, was OTP. looks like you've already implemented step 3? | 15:37 |
| frankban | gary_poster: taking a look with local firefox. | 15:37 |
| gary_poster | jcsackett, frankban is looking. maybe worth working with his instructions for the future though? | 15:38 |
| gary_poster | thank you frankban | 15:38 |
| hatch | rick_h__: is the browser sidebar set to min-width 350px on purpose? It should probably be max-width? | 15:38 |
| luca__ | hatch: what is the bug with the side bar? | 15:39 |
| rick_h__ | hatch: yea, it's on purpose | 15:39 |
| jcsackett | gary_poster: i've copied his instructions and when i next have slack i'll make sure i can follow them. | 15:39 |
| hatch | luca__: oh - well it looks 'wrong' on my monitor because it has a min-width of 350px not a max-width | 15:39 |
| gary_poster | ack thanks jcsackett | 15:39 |
| hatch | so there is just a bunch of whitespace beside everything that looks off | 15:40 |
| rick_h__ | hatch: screenshot? | 15:40 |
| hatch | one moment | 15:40 |
| luca__ | hatch: screenshot! :D | 15:41 |
| hatch | lol | 15:41 |
| hatch | https://www.evernote.com/shard/s219/sh/073fa338-306e-4fca-bb80-8f954e549add/f6d7b3c935bd8b66934bf7506262f081/res/e4ba1ae1-0155-4c09-af8e-5b15dff3b7a7/skitch.png | 15:41 |
| hatch | ^ rick_h__ luca__ | 15:41 |
| rick_h__ | hatch: heh, well don't view it fullscreen on 1920px :P | 15:41 |
| rick_h__ | hatch: there's talk about making things more responsive and dealing with 'grid units' but it's not in the immediate future | 15:42 |
| hatch | hah I'm nowhere near fullscreen on my monitor :) | 15:42 |
| luca__ | rick_h__: can you explain what the issue is? o.O | 15:42 |
| hatch | it looks proper if we change the min-width to max-width | 15:42 |
| rick_h__ | hatch: well I did say 1920px | 15:42 |
| gary_poster | rogpeppe, gentle reminder to reply to the two gui-related emails from william :-) | 15:43 |
| hatch | well...really just 'width' :) | 15:43 |
| rick_h__ | luca__: so he's complaining about the wasted space to the right of the charm-tokens because it's seto to 25% and he's viewing it on a giant screen | 15:43 |
| hatch | that | 15:43 |
| luca__ | rick_h__: I see, good spot hatch :P | 15:44 |
| rogpeppe | gary_poster: will do, thanks for the poke | 15:45 |
| hatch | if you're ok with it being set to a fixed width of 350px instead of a min width it's a one line and 4character fix :) | 15:45 |
| gary_poster | thanks rogpeppe :-) | 15:45 |
| hatch | are failures in the simulator not supposed to trigger alerts? | 15:48 |
| hatch | jujugui call in 3 ;) | 15:57 |
| gary_poster | ugh thanks hatch | 15:57 |
| hatch | haha np | 15:57 |
| Makyo | ---> https://codereview.appspot.com/10048043/ <--- | 16:06 |
| jcsackett | frankban: link? | 16:14 |
| frankban | jcsackett: https://codereview.appspot.com/9714047 | 16:14 |
| abentley | orangesquad: Could you please review https://code.launchpad.net/~abentley/charmworld/factory-uses-process-charm/+merge/168724 ? | 16:15 |
| * sinzui looks | 16:15 | |
| tekNico | Makyo: don't you have two reviews already for your "zoom to service" branch? | 16:17 |
| sinzui | abentley, r=me | 16:17 |
| Makyo | tekNico, no second LGTM, and Ben's out this week. | 16:17 |
| tekNico | Makyo: ok, I'll do it | 16:17 |
| Makyo | tekNico, thanks! | 16:18 |
| frankban | guihelp: does anyone have info about the "failed to load editorial content" notification? | 16:29 |
| gary_poster | rick_h__, ^^^ | 16:30 |
| hatch | frankban: I could be wrong with this - but I think that happens when the request to the jujucharms.com fails | 16:35 |
| frankban | hatch: ok thanks | 16:36 |
| rick_h__ | frankban: looking | 16:39 |
| rick_h__ | frankban: yea, I'll need the network info from the debug tools. Right now we know we've got a problem with the new routing code and searches which use query strings | 16:40 |
| rick_h__ | frankban: I'm not aware of anything ootb right now on interesting loading | 16:40 |
| frankban | rick_h__: ack, just investigating CI failures, and that notification captured my attention | 16:42 |
| rick_h__ | hatch: so yea, but the question would be what failed and why | 16:42 |
| rick_h__ | frankban: definitely. If it's just in tests then it should be ok, but if you see it in use we need to figure out why it's failing. | 16:43 |
| hatch | rick_h__: there is no why, there is only do | 16:43 |
| hatch | *hatchisms* | 16:43 |
| rick_h__ | hah | 16:43 |
| frankban | rick_h__: I am actually seeing those in a ec2 deployed GUI (used by CI tests) -> http://ec2-107-20-106-2.compute-1.amazonaws.com/ | 16:47 |
| rick_h__ | frankban: ok, config issue. The url needs to end in a trailing / | 16:47 |
| rick_h__ | frankban: both config-debug and config-prod have it, not sure where the config is from in the charm where it doesn't have it | 16:48 |
| frankban | rick_h__: you mean charmworldURL: "https://manage.jujucharms.com" ? | 16:48 |
| rick_h__ | frankban: rgr | 16:48 |
| hatch | removing bootstrap from the page actually breaks damn near everything :/ | 16:48 |
| rick_h__ | frankban: I mean 'roger' or yes | 16:48 |
| rick_h__ | hatch: yea, why we left it for you :P | 16:49 |
| rick_h__ | hatch: we took a peek at that back when we first started with design/huw in march | 16:49 |
| hatch | it's not just the alert button that huw had mentioned but everything | 16:49 |
| frankban | rick_h__: so the default value in the charm config is invalid. however, since this is something the user can change (providing a customized juju --config) I'd prefer the trailing slash to be handled by the GUI code... thoughts? | 16:50 |
| rick_h__ | frankban: yes, we can add a bug to check for a /$ and add it if it's not there. | 16:51 |
| rick_h__ | frankban: I'll add it now | 16:51 |
| frankban | rick_h__: thank you | 16:51 |
| frankban | rick_h__: in the meanwhile, I'll quickly fix the default value in the charm | 16:55 |
| rick_h__ | frankban: thanks | 16:58 |
| hatch | gary_poster: so I have now extracted and replaced all of the bootstrap styles effecting the alerts button and made steps to gradually move away from bootstrap. But bootstrap still cannot be removed as other parts of the app rely on it | 17:44 |
| hatch | how far down this rabbit hole should I go? | 17:44 |
| hatch | frankban: was the CI failure caused by a missing trailing / ? | 17:46 |
| frankban | hatch: still investigating | 17:47 |
| hatch | ohh, I saw your commit and wondered if that was the fix | 17:47 |
| frankban | hatch: it can be related | 17:47 |
| rick_h__ | hatch: jcsackett have any opinions on this tiny patch? https://codereview.appspot.com/10193043 | 17:55 |
| rick_h__ | honestly about to self-review, but give you all a chance at it :) | 17:55 |
| rick_h__ | hmm, actually yea I'm missing a line of removal still. doh! | 17:55 |
| hatch | combine now handles that, yes? | 17:56 |
| rick_h__ | hatch: right | 17:56 |
| rick_h__ | hatch: so it was double adding the qs and cauing issues later down the pipe | 17:57 |
| hatch | well then....guess you know what I'm going to ask for next :P | 17:57 |
| rick_h__ | hatch: a pie? | 17:57 |
| hatch | a test!!! | 17:57 |
| hatch | weeeee tests! | 17:57 |
| rick_h__ | hah, thought about it. but I'm testing that code that's no longer there no longer functions | 17:57 |
| rick_h__ | :/ | 17:58 |
| hatch | hahaha | 17:58 |
| hatch | is there a test that checks to make sure the combine works properly? | 17:58 |
| rick_h__ | hatch: correct, what was missing was a test that navigate had a query string on it, but now that navigate doesn't add a query string that test makes no sense | 17:58 |
| rick_h__ | and by navigate I mean _navigate | 17:59 |
| hatch | sure okee | 17:59 |
| hatch | LGTM | 17:59 |
| sinzui | abentley, I think search is broken/missing from staging? Any insights | 17:59 |
| rick_h__ | ty | 17:59 |
| hatch | once you remove the line creating qes | 17:59 |
| rick_h__ | hatch: yea, that's pushed up. Hit refresh | 17:59 |
| hatch | qa I mean | 17:59 |
| hatch | ARG | 17:59 |
| rick_h__ | lol | 17:59 |
| hatch | qs | 17:59 |
| * sinzui can see that the staging logs are dominated by KeyError: 'branch_deleted' | 17:59 | |
| rick_h__ | log domination ftw! | 17:59 |
| rick_h__ | ...or not | 17:59 |
| jcsackett | rick_h__: if i'm understanding this, you've found a path wherein the QS was preserved, and then parsed out and added again, yes? | 17:59 |
| abentley | sinzui: Oh, that sounds like a problem. | 18:00 |
| rick_h__ | jcsackett: no, I found a path that had a url witha valid query string, and then...reappended a query string again | 18:00 |
| jcsackett | you just said what i said with different words. or at least what i was intending to say. | 18:00 |
| jcsackett | :-P | 18:00 |
| rick_h__ | if it had removed it, it might have worked :) | 18:00 |
| rick_h__ | "parsed out" or whatever | 18:01 |
| jcsackett | e.g. the nsRouter stuff now preserves QS, the code you deleted parsed the QS from the URL, then appended...but it was already there. | 18:01 |
| jcsackett | right. | 18:01 |
| jcsackett | anyway, kill it. | 18:01 |
| rick_h__ | jcsackett: I follow ya, yea. | 18:01 |
| jcsackett | i can LGTM if you want, or you can self review. | 18:01 |
| rick_h__ | jcsackett: LGTM please so I can say I was all official and people looked over my shoulders :) | 18:01 |
| abentley | sinzui: I believe abel's branch is broken and only works for new charms that have branch_deleted set. | 18:05 |
| abentley | sinzui: IOW a catch-22 | 18:05 |
| sinzui | abentley, yep | 18:05 |
| sinzui | I reported the bug. easy fix. | 18:06 |
| abentley | sinzui: Sorry I didn't notice this in the review. | 18:06 |
| abentley | sinzui: I can take it if you like. Just started on another bug. | 18:06 |
| sinzui | abentley, okay. https://bugs.launchpad.net/charmworld/+bug/1190002 | 18:06 |
| _mup_ | Bug #1190002: KeyError branch_deleted <ingest> <charmworld:Triaged> <https://launchpad.net/bugs/1190002> | 18:06 |
| sinzui | your choice of defensive coding or update and use the model. | 18:07 |
| rick_h__ | gary_poster: so heads up, bug on the categories link that hazmat brought up is landing now. Small regression from last night to today so hopefully short lived and no pain. | 18:07 |
| gary_poster | cool thank you very much rick_h__ | 18:08 |
| rick_h__ | next bug! /me is declaring it bug fixing day | 18:08 |
| gary_poster | :_) | 18:08 |
| hatch | gary_poster: did you see my q above? | 18:09 |
| gary_poster | hatch, no looking | 18:09 |
| gary_poster | hatch, only as far as we need today for header. thank you. if you've done any extra, great, but no need for more | 18:10 |
| hatch | honestly I'm not exactly sure what needs to be done - this is to change things for the grey header? | 18:10 |
| abentley | sinzui: Odd, branch_deleted gets set by the lp scan. I don't know how it's missing. | 18:11 |
| gary_poster | sorry hatch I meant the notifications thing | 18:11 |
| abentley | sinzui: Unless the branch *just* landed. | 18:11 |
| gary_poster | hatch, huw doesn't want to have to deal with bootstrap AIUI. I think he also wants to have YUI style css control over the notifications panel | 18:12 |
| sinzui | abentley, ~zulcss/oneiric/nagios looks very old | 18:12 |
| hatch | well that's simply not going to happen without a new UI, the bootstrap styles controlling the notifications is ~150lns | 18:12 |
| frankban | gary_poster: retrying a CI run now. This is just to test if the problem was the error notification appearing due to an invalid config option in the charm defaults, and preventing the charm panel link to be clicked. If that's not the case, I'll continue tomorrow morning if not solved before. Created a critical card in Maintenance. | 18:13 |
| hatch | but I separated them out for him so they are easy to modify now at least | 18:13 |
| abentley | sinzui: No, I mean unless abel's branch *just* landed. Which I can see it didn't. | 18:13 |
| gary_poster | thank you frankban | 18:13 |
| sinzui | abentley, right, it was merge by tarmac about 24 hours ago | 18:14 |
| sinzui | abentley, the first error is 2013-06-11 08:58:07 | 18:14 |
| gary_poster | frankban I will ask someone else to run with it this afternoon if not fixed | 18:15 |
| gary_poster | hatch, uh. | 18:15 |
| frankban | gary_poster: cool, thanks | 18:15 |
| abentley | sinzui: But the last error is 2013-06-11 09:00:05 | 18:15 |
| gary_poster | hatch, I honestly have no idea what Huw's concern is tbh. I don't see why he can't change the top header without changing the notifications panel | 18:15 |
| sinzui | ah | 18:16 |
| gary_poster | rick_h__, do you have any insight into above, maybe? | 18:16 |
| hatch | gary_poster: yeah - I'll propose my branch so you can see what I have done for him - see if it's what you had in mind | 18:16 |
| gary_poster | ok thanks hatch | 18:16 |
| abentley | sinzui: I think the problem was that the queued data didn't match the new code. | 18:16 |
| abentley | sinzui: And therefore it's no longer an issue. Which leaves the other problem mysterious. | 18:17 |
| gary_poster | hatch, how trivial is it to disable and remove the top search? | 18:17 |
| gary_poster | do you know off hand? | 18:17 |
| sinzui | abentley, I see that ingest errors is current and nasty | 18:18 |
| hatch | umm - if I remember fairly trivial | 18:18 |
| hatch | not sure what the side effects would ne | 18:18 |
| hatch | be* | 18:18 |
| hatch | we could remove the html though really easy :) | 18:18 |
| abentley | sinzui: Where do you see it? I can't see a recent example in app.log or ingest-errors.log | 18:19 |
| sinzui | abentley, ingest-lp.log | 18:19 |
| gary_poster | hatch, heh | 18:20 |
| abentley | sinzui: AttributeError: 'MongoQueue' object has no attribute 'charms'? Yes, that looks bad. | 18:20 |
| hatch | we would also need to remove the charms dropdown button | 18:20 |
| gary_poster | yes | 18:20 |
| hatch | one minute I'll look deeper | 18:21 |
| gary_poster | thank you | 18:21 |
| abentley | sinzui: bin/enqueue exhibits the error locally. | 18:22 |
| hatch | gary_poster: so I'd like to say that it would simply be removing things from the instance creation constructor but should probably allow......4h? JIC | 18:23 |
| gary_poster | hatch ok | 18:23 |
| gary_poster | hatch, are you up for this or would you like me to find someone else? This is more immediately pressing than the inspector work, but I really want that to proceed as well. If you'd rather not do this right now, lemme know | 18:24 |
| hatch | sure I can | 18:24 |
| sinzui | abentley, shall we consider the script to remove ObjectId charms? Ot was run on staging 4 hours ago, and production in the last 15 minutes | 18:24 |
| hatch | this will definitely be a - diff :) | 18:24 |
| abentley | sinzui: What should we consider about the script? | 18:25 |
| gary_poster | :-) thanks hatch | 18:25 |
| sinzui | abentley, I don't think the remove() call could cause the queue to loose charms, but maybe on second glance it is bad...http://pastebin.ubuntu.com/5755316/ | 18:26 |
| hatch | gary_poster: np! I'm going to move bens controller card into daily to free up space if that's alright? | 18:26 |
| sinzui | abentley, this is the report from the production run...look good to me: https://pastebin.canonical.com/92568/ | 18:26 |
| abentley | sinzui: I don't think the script is implicated. | 18:27 |
| abentley | sinzui: I think that ingest is broken, and all the current charms are in a bad state because of the last ingest. | 18:27 |
| sinzui | fab, then production probably wont go blank | 18:27 |
| gary_poster | hatch, how 'bout this | 18:27 |
| abentley | sinzui: For example, http://staging.jujucharms.com/charms/precise/apache2/json has an 'errors' member. I bet all branches do. | 18:28 |
| gary_poster | (1) propose your/ben's current branch. use Ben's card for that | 18:28 |
| abentley | s/branches/charms | 18:28 |
| sinzui | abentley, yes, that is what I thought at first when I saw the branch_deleted, but the | 18:28 |
| sinzui | AttributeError: 'MongoQueue' object has no attribute 'charms' | 18:28 |
| gary_poster | (2) hopefully you 'll have reviews for your alerts dropdown by then and can land | 18:28 |
| sinzui | confuses me | 18:28 |
| gary_poster | (3) then you'll have room :-) | 18:28 |
| abentley | sinzui: I get that locally when I run bin/enqueue. I've never run your script. I think abel never tested locally. | 18:29 |
| hatch | hah sure - `recess` is throwing an error but doesn't tell me what the error is :/ | 18:29 |
| sinzui | abentley, we have two branches found by interfaces...and one is ~chilicuil that we discussed before | 18:30 |
| abentley | sinzui: Also, the API lists only two charms. | 18:32 |
| abentley | http://staging.jujucharms.com/api/2/charms | 18:32 |
| sinzui | abentley, yep, those two. We can added a defensive check to the code. | 18:33 |
| abentley | sinzui: Sorry, I forget what context they were relevant to. Are they potentially deleted? | 18:34 |
| hatch | hmm | 18:34 |
| abentley | sinzui: bzr certainly thinks they aren't branches. | 18:34 |
| sinzui | abentley, ~chilicuil is my Cthulhu example form a few days about charms without branches that dominate the error logs | 18:35 |
| sinzui | the recent change inverts the case where good charms error and dominate the logs | 18:36 |
| abentley | sinzui: It | 18:36 |
| abentley | sinzui: It is the charm that had no contentType earlier, suggesting a deleted branch. | 18:36 |
| sinzui | yeah | 18:37 |
| abentley | sinzui: Anyhow, once we fix this MongoQueue error, I expect the non-missing branches to be fixed. | 18:38 |
| * hatch wants to remove recess from our build | 18:41 | |
| abentley | sinzui: It appears to be a one-line fix: http://pastebin.ubuntu.com/5755825/ | 18:43 |
| sinzui | :) | 18:43 |
| abentley | sinzui: Could you please review https://code.launchpad.net/~abentley/charmworld/enqueue-broken/+merge/168788 ? | 18:49 |
| abentley | sinzui: I've successfully run enque and ingest-queued. | 18:50 |
| sinzui | r=me | 18:50 |
| abentley | sinzui: I wonder whether we should drain the queues as part of a source code upgrade? | 18:53 |
| sinzui | abentley, I think we should. | 19:00 |
| sinzui | abentley, do you have time for https://code.launchpad.net/~sinzui/charmworld/enable-migration/+merge/168791 | 19:00 |
| abentley | sinzui: looking. | 19:00 |
| abentley | sinzui: I think production thinks it's already on version 7, so you need to rename version 7 to version 8. | 19:01 |
| sinzui | abentley, production is not on 7, it failed to migrate | 19:05 |
| abentley | sinzui: Even after you made the 7 migration a no-op? Are you sure? | 19:05 |
| sinzui | oh! | 19:06 |
| sinzui | abentley, you are correct. | 19:06 |
| * sinzui copies and renames | 19:06 | |
| gary_poster | benji hijacked you into call tomorrow of potential juju core task. let me know if you'd rather have a tooth pulled :-) | 19:09 |
| benji | heh | 19:09 |
| benji | what time? | 19:09 |
| gary_poster | benji 1500 utc. on your calendar | 19:10 |
| * benji takes out his UTC to Faux-Eastern slide rule. | 19:10 | |
| gary_poster | heh, 11 for me benji | 19:10 |
| rick_h__ | hatch: can you give me a ping when you get a sec? | 19:13 |
| rick_h__ | I need someone to second my build issue isn't just me | 19:14 |
| hatch | what's up? just eating lunch | 19:14 |
| rick_h__ | hatch: so can you check out trunk, make clean-all && make | 19:14 |
| rick_h__ | and try to run the tests? | 19:14 |
| rick_h__ | in a browser, test-server, not test-debug | 19:14 |
| hatch | sure, | 19:14 |
| sinzui | abentley, I push my update: https://code.launchpad.net/~sinzui/charmworld/enable-migration/+merge/168791 | 19:16 |
| abentley | sinzui: Also rename TestMigration007 to TestMigration008 and you're good to land. | 19:17 |
| sinzui | doh | 19:18 |
| hatch | rick_h__: broke broke | 19:19 |
| rick_h__ | hatch: k | 19:19 |
| rick_h__ | hatch: now do me another favor | 19:19 |
| hatch | browser_charm_view "does not blow up when the scores from the api is null" | 19:19 |
| hatch | does blow up :) | 19:19 |
| rick_h__ | hatch: yea, I've fixed that but now hitting other stuff :( | 19:20 |
| rick_h__ | cascade fail | 19:20 |
| hatch | it takes forever to run the build when kerbal is also running haha | 19:28 |
| abentley | sinzui: I am in the middle of a forced ingest, and things seem to be returning to normal. | 19:29 |
| sinzui | abentley, rock! | 19:29 |
| Makyo | Swapping routers again :S | 19:30 |
| hatch | wow throttle control makes a huge difference in how much bang for your buck you get in kerbal | 19:34 |
| === makyo_ is now known as Makyo | ||
| rick_h__ | hatch: I'm trying to manually fire an event in a test but having trouble. any hints for me? http://paste.mitechie.com/show/964/ | 19:37 |
| abentley | sinzui: ingest complete. | 19:37 |
| hatch | rick_h__: I"m assuming that tabview is the proper object? | 19:38 |
| hatch | you don't need to pass in a new eventfacade you can just fire it with an object | 19:38 |
| hatch | {newVal: 'Quality'} | 19:39 |
| rick_h__ | hatch: yes, verified tab == view.tabview | 19:39 |
| rick_h__ | hatch: the trouble is that it's not getting into the 'after' callback at all | 19:39 |
| hatch | oh | 19:39 |
| hatch | that's because selection is an attribute? | 19:39 |
| rick_h__ | ah! gotcha | 19:39 |
| rick_h__ | hatch: still fail, anything else jump out at you from this then? http://paste.mitechie.com/show/965/ | 19:53 |
| hatch | checking | 19:55 |
| rick_h__ | hatch: nvm, hmm the selection isn't the link but the tab content. So I'm mixing it up a bit | 19:55 |
| hatch | alrighty | 19:56 |
| rick_h__ | it should still fire the event though, the attr was changed but it didn't take. ugh this is annoying | 19:56 |
| hatch | the event will only fire if the value is different | 19:57 |
| rick_h__ | yea, so now the wonder why it didn't take | 19:57 |
| hatch | try just setting it to 'foo' | 19:58 |
| hatch | so it's totally different | 19:58 |
| sinzui | thank you very much abentley | 19:58 |
| hatch | rick_h__: oh | 19:59 |
| abentley | sinzui: You're welcome. | 19:59 |
| hatch | rick_h__: selection is readonly | 19:59 |
| rick_h__ | hatch: bah! | 19:59 |
| rick_h__ | screw it, bye bye test. | 20:01 |
| rick_h__ | this is so much fun, now that routing is fixed to not ignore QS and anchor tags the tests won't pass | 20:03 |
| rick_h__ | frankban was doomed from the start | 20:03 |
| rick_h__ | it's alive! | 20:14 |
| hatch | :) | 20:14 |
| rick_h__ | guess what standup I'll be on tomorrow :P | 20:14 |
| hatch | what was the issue? | 20:15 |
| rick_h__ | so now that routing is un-borked any test that adds a #hash to the url causes everyone else's json loads to fail since they're relative | 20:16 |
| hatch | ahhh | 20:16 |
| hatch | yeah that's not good testing to modify the url at all | 20:16 |
| rick_h__ | yea, so I removed my one test that did it because it had so since I can't simulate the underlying selectionChange event to clean up the test | 20:17 |
| rick_h__ | all the stuff in test_service_view that does it I just moved to the last tests to run period | 20:17 |
| hatch | well you could change the selection :) | 20:17 |
| rick_h__ | someone that knows how that works will have to adjust the test to not mess withthe url | 20:17 |
| rick_h__ | hatch: right, but I can't seem to force it other than clicking on the link...that triggers the url change | 20:17 |
| hatch | tabview.selectChild() | 20:18 |
| rick_h__ | oh wtf...now test errors in test-debug when it didn't fail on this anyway | 20:18 |
| hatch | I think selectChild does | 20:18 |
| hatch | I could be wrong though | 20:18 |
| rick_h__ | selectChild is about the widget child I believe | 20:18 |
| hatch | ahhh | 20:18 |
| hatch | ok ok | 20:18 |
| hatch | ugh this recess thing is irritating me | 20:20 |
| rick_h__ | what was recess? the css minification stuff? | 20:20 |
| * rick_h__ had to look it up before and is refusing to again :P | 20:21 | |
| hatch | it's a css linter that fails on bootstrap code | 20:21 |
| rick_h__ | ah, that's right | 20:21 |
| hatch | (made by twitter) | 20:21 |
| hatch | there is absolutely nothing wrong with the style in question | 20:21 |
| hatch | and it doesn't give me a way to turn it off for a block of css | 20:21 |
| hatch | as far as I can find in the source or docs | 20:21 |
| rick_h__ | oh crap, ran the wrong command *sigh* | 20:34 |
| rick_h__ | what a freaking day | 20:34 |
| hatch | haha | 20:35 |
| hatch | anyone available for a review? https://codereview.appspot.com/10197043/ | 20:35 |
| rick_h__ | hatch: jcsackett can I get an emergency call please? | 20:35 |
| hatch | it's a simple css restructuring one | 20:35 |
| hatch | sure | 20:35 |
| hatch | loading guichat | 20:35 |
| rick_h__ | guichat please | 20:35 |
| gary_poster | Makyo do you have time for quick review of hatch's https://codereview.appspot.com/10197043/ ? | 20:38 |
| gary_poster | it's fast :-) | 20:38 |
| Makyo | Sure. | 20:38 |
| gary_poster | ty | 20:39 |
| hatch | thanks | 20:39 |
| jcsackett | ccccccbljtrvvbvviujehkvllefelhuffjgggvjnvgve | 20:40 |
| gary_poster | uh-huh, sure | 20:40 |
| hatch | jcsackett: lol | 20:40 |
| hatch | again | 20:40 |
| gary_poster | sorry, my comment was ambiguous but intended to be directed at Jon | 20:40 |
| hatch | gary_poster: sorry I committed the config :/ | 20:41 |
| gary_poster | hatch np, easy to fix :-) | 20:41 |
| rick_h__ | jcsackett: https://code.launchpad.net/~rharding/juju-gui/trailing-slash-1189973/+merge/168803 | 20:42 |
| jcsackett | man...i'm building a little cover that hooks onto the yubikey. | 20:44 |
| hatch | lol | 20:47 |
| gary_poster | rick_h__, jcsackett fwiw the only big usability issue I have in charm browser right now is the lack of a back arrow sort of thing, or at least the ability to get back to the home page. true back arrow doesn't work reliably either. Is any of that slated to come up soon? | 20:48 |
| gary_poster | (navigating to categories are example of true back arrow not working) | 20:49 |
| jcsackett | gary_poster: i don't know that any of that is scheduled; back arrows are sporadically included in design, and i think true back not working is a new bug. | 20:50 |
| gary_poster | jcsackett, ok thanks, I will raise to UX then | 20:51 |
| jcsackett | true back arrow not working sounds like something we can bring up in standup tomorrow as a high priority, but i'll have more info for you post-standup. | 20:51 |
| gary_poster | cool thanks jcsackett | 20:51 |
| jcsackett | sinzui: ^ | 20:52 |
| jcsackett | i've added a card to the next lane. probably worth more discussion tomorrow, since everyone is EoDing or close to doing so now. | 20:52 |
| rick_h__ | gary_poster: so back button shuold work. The 'return to home' is a known UX issue that luca's had on their plate for a while tbh | 20:52 |
| gary_poster | rick_h__, ack, thanks. I'll send something casual to him then | 20:53 |
| sinzui | gary_poster, rick_h__ speaks the truth | 20:53 |
| gary_poster | :-) | 20:53 |
| gary_poster | should I file a bug for category back arror thing? | 20:53 |
| gary_poster | arrow | 20:53 |
| rick_h__ | gary_poster: did you see ^^ about tests and CI? | 20:53 |
| sinzui | I would love a 'return to home' feature | 20:54 |
| rick_h__ | gary_poster: I'll come on the stand up tomorrow, but the browser based tests are a bit fubar with the routing changes recently I think. I've landed a branch that should help, but does dirty tricks | 20:54 |
| gary_poster | rick_h__, I saw that there was a crazy slash thing that broke things somehow, and frankban fixed it in charm and you fixed it gui. I haven't seen test runs since | 20:54 |
| gary_poster | ok thanks rick_h__, sounds good (or sending an email would be good, but verbal is faster) | 20:55 |
| rick_h__ | sorry, EOD and juggling sick toddler. | 20:57 |
| gary_poster | hope toddler feels better soon | 20:58 |
| gary_poster | for the sake of all involved :-) | 20:58 |
| rick_h__ | gary_poster: ok, I guess there's some question as to the right way to fix permanently, but wanted to toss a heads up. phantomjs let things pass that FF/chrome would not have | 20:58 |
| gary_poster | ah-hah :-/ | 20:58 |
| rick_h__ | so just a general heads up that the / wasn't even close to CI's big issue, but hopefully it's better now than this morning | 20:58 |
| gary_poster | CI's big issue being the diff between phantom and FF/chrome? | 20:59 |
| gary_poster | or something you will discuss tomorrow? | 20:59 |
| rick_h__ | gary_poster: yea, it was either hitting that or about to once the other issue was unblocked | 20:59 |
| rick_h__ | I had hatch verify that tsets failed for him in trunk big time before my branch | 20:59 |
| gary_poster | ugh, wow | 21:00 |
| gary_poster | ok | 21:00 |
| hatch | yeah....gota love FE development :) | 21:00 |
| gary_poster | well, on the bright side tarmac will make that better | 21:00 |
| gary_poster | where's matsubara, anyway! :-) | 21:00 |
| Makyo | Dogwalkination. Back in a bit. | 21:00 |
| gary_poster | k | 21:01 |
| gary_poster | uh, hatch? I think something fell over: http://uistage.jujucharms.com/ | 21:06 |
| hatch | i'd say | 21:06 |
| hatch | that's what happens when bootstrap isn't on the page | 21:06 |
| hatch | now why isn't it... | 21:06 |
| gary_poster | I'm trying make | 21:06 |
| gary_poster | on uistage | 21:07 |
| hatch | hmm it is loaded | 21:07 |
| hatch | the bootstrap styles aren't being replied | 21:08 |
| hatch | applied | 21:08 |
| gary_poster | hatch, do you want me to do anthing on uistage | 21:09 |
| hatch | yeah... | 21:10 |
| hatch | the bootstrap and juju-bootstrap files are returning the index file | 21:10 |
| gary_poster | well, this is on prod | 21:11 |
| gary_poster | so it should be compressed, yeah? | 21:11 |
| hatch | can't compress it, recess throws an error | 21:11 |
| hatch | and there is no way to tell it to ignore the line | 21:11 |
| hatch | oh but I suppose we could merge them | 21:12 |
| hatch | ok going to go do that - I explicitly removed them from the merge so that they would stand out | 21:12 |
| hatch | but that's not working :) | 21:12 |
| gary_poster | Lesson: reviewers should always qa :-/ | 21:13 |
| gary_poster | on prod | 21:13 |
| hatch | should be fixed soon | 21:15 |
| gary_poster | thanks | 21:15 |
| hatch | sorry :*) | 21:17 |
| gary_poster | s'ok, was my fault too | 21:18 |
| hatch | Yeah!! that's right it was! | 21:18 |
| hatch | lol | 21:18 |
| gary_poster | :-) | 21:18 |
| hatch | proposing | 21:19 |
| hatch | gary_poster: https://codereview.appspot.com/10197043 mind a qa please :) | 21:22 |
| gary_poster | hatch :-) on it | 21:22 |
| gary_poster | LGTM ship it! | 21:27 |
| hatch | submitting! | 21:28 |
| gary_poster | hatch, go ahead and submit, but then, in charm browser, was change log broken in charms before you landed the bootstrap change? | 21:29 |
| gary_poster | will try reverting to check | 21:29 |
| gary_poster | right now it takes up all vertical space even when collapsed | 21:29 |
| gary_poster | which pushes tabs down down down way down | 21:29 |
| hatch | gary_poster: yeah it's because it's using the .hidden class which sets visibility to hidden | 21:30 |
| gary_poster | hatch, ok, you on it? | 21:31 |
| hatch | I'm not sure what other side effects there are with that change though | 21:32 |
| gary_poster | hatch, so...this is a bootstrap thing though, right? | 21:32 |
| hatch | stylesheet.less line 115 | 21:32 |
| hatch | nope | 21:32 |
| gary_poster | oh | 21:32 |
| gary_poster | so not introduced by you hatch? | 21:32 |
| hatch | i'll revert trunk to see but I am almost certain no | 21:33 |
| hatch | will report in 5 | 21:33 |
| gary_poster | ok thanks | 21:33 |
| hatch | ahh | 21:39 |
| hatch | yes it was caused by me | 21:39 |
| gary_poster | easy to fix? | 21:39 |
| hatch | one liner yup | 21:39 |
| hatch | will fix and submit | 21:39 |
| gary_poster | cool thanks | 21:39 |
| hatch | gary_poster: can you make on uistage plz? | 21:48 |
| gary_poster | on it | 21:48 |
| gary_poster | lib/views/stylesheet.less is not working in Makefile to trigger css rebuild. did make clean && make. | 21:50 |
| gary_poster | fixed. thanks hatch! | 21:51 |
| hatch | awesome | 21:51 |
| hatch | our css is a mess | 21:51 |
| hatch | hopfully with huw we can now clean it up | 21:51 |
| gary_poster | yup | 21:51 |
| hatch | ok now to merge ben and my branch | 21:53 |
| hatch | Makyo: thought you might like this song http://www.youtube.com/watch?v=4ZYm0anhvLg it sounds better if you change the quality to 1080HD :) | 21:56 |
| hatch | yuidoc linter is throwing an error but I have no idea what it means....who added this? | 22:11 |
| hatch | looks like I got it | 22:15 |
| hatch | arg | 22:17 |
| hatch | gary_poster: https://codereview.appspot.com/10019050/ the databinding branch | 22:39 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
