| hatch | rick_h__: you around? | 03:46 |
|---|---|---|
| rick_h__ | hatch: heh, yea | 03:46 |
| rick_h__ | hatch: but barely | 03:46 |
| hatch | heh sucker | 03:46 |
| hatch | :P | 03:46 |
| hatch | https://codereview.appspot.com/10019050/diff/1/app/views/databinding.js I don't know what you meant with the top comment | 03:46 |
| rick_h__ | loading | 03:47 |
| rick_h__ | hatch: just spacing around the { | 03:47 |
| rick_h__ | you have { return | 03:47 |
| rick_h__ | but );} | 03:47 |
| rick_h__ | the asymetrical-ness of it got my attention :P | 03:47 |
| hatch | ohh - yeah ben wrote that, that might be his style, I've noticed it a few places :) | 03:47 |
| rick_h__ | hatch: so yea, let me know if we need to do a hangout or something on my comments tomorrow | 03:48 |
| rick_h__ | hatch: I wasn't clear on some parts and maybe I'm not getting it. | 03:49 |
| hatch | sure - this is still under development so it's very likely some will change | 03:49 |
| hatch | it's gone through a few iterations already | 03:49 |
| rick_h__ | cool, yea. After going through it maybe I just need to get told to hold on and wait and put my LGTM on there for now | 03:49 |
| rick_h__ | but figured I'd do my best to bring 'fresh' eyes to it | 03:50 |
| rick_h__ | since I'm not in all the meetings/discussions and just approaching it as a dude that can read some JS | 03:50 |
| rick_h__ | and with that it's way past my bedtime after a LUG meeting night. Check ya tomorrow | 03:51 |
| hatch | :) have a good night thx for the review | 03:52 |
| gary_poster | If anyone is interested in leading the charge of switching us from canonistack to ec2, please do. this is not cool, and will be untenable with tarmac | 12:34 |
| rick_h__ | gary_poster: so I'm looking at hatch's branch he put up and some of the things I comment on are "yea, that's not ideal and will get worked on more in the future". So should reviews kind of be "well, point this out" and let it ride as things shake out then? | 12:36 |
| rick_h__ | gary_poster: I don't want to hold up things, but wonder which things to say "yea this should be tweaked" vs 'ok, pinky promise this won't hang around forever' | 12:36 |
| gary_poster | rick_h__, for this effort, behind a feature flag, yes. For instance, it would be fine to say "please mark this with an XXX and a bug. I'm fine with it landing behind the feature flag, but not with it staying." Other variants/ideas welcome. I want them to feel like they can merge incremental work to trunk for larger efforts like this. | 12:38 |
| gary_poster | larger exploratory efforts | 12:38 |
| rick_h__ | gary_poster: k, cool. | 12:39 |
| gary_poster | thanks | 12:39 |
| gary_poster | rick_h__, I can't get the serviceInspector flag to work, can you? | 12:43 |
| rick_h__ | gary_poster: not tried, sec | 12:44 |
| gary_poster | k | 12:44 |
| rick_h__ | gary_poster: yea, works here | 12:47 |
| gary_poster | huh | 12:47 |
| gary_poster | ok | 12:47 |
| rick_h__ | http://127.0.0.1:8888/sidebar/:flags:/serviceInspector/ is the final url after I added a service and confirmed it | 12:47 |
| gary_poster | rick_h__, using sandbox? | 12:47 |
| rick_h__ | gary_poster: yea | 12:48 |
| gary_poster | k trying again | 12:48 |
| gary_poster | still not | 12:48 |
| gary_poster | will try make clean? | 12:48 |
| gary_poster | nope | 12:50 |
| rick_h__ | gary_poster: yea, not sure. I just grabbed trunk, updated it, colo-branches, merged jeff's branch and make devel and it worked | 12:50 |
| gary_poster | sounds exactly the same | 12:50 |
| gary_poster | rick_h__, and you add a service (I added mysql), confirm (ugh I keep forgetting to ask someone to fix the cancel button css), and then click on the service, click view, and...get taken to the old page | 12:51 |
| gary_poster | no, you get the right thing at the end :-) | 12:51 |
| gary_poster | http://localhost:8888/sidebar/:flags:/serviceInspector/ is my final url.. | 12:53 |
| rick_h__ | gary_poster: right, I added ceph, top of my sidebar list. Added it, confirmed, clicked on it and hit 'view' and got this floating panel up | 12:53 |
| gary_poster | :-/ ok thanks rick_h__ . bztr status shows all the right stuff too. | 12:54 |
| gary_poster | I have call soon so will return to that later | 12:54 |
| frankban | gary_poster: it seems that suddenly ie is not able to click on DOM elements without disconnecting the webdriver :-/ | 13:02 |
| gary_poster | frankban, :-( so not canonistack? | 13:03 |
| gary_poster | frankban, on call will check in with you after | 13:03 |
| frankban | gary_poster: I see that behavior in ec2. thanks | 13:03 |
| benji | Has anyone else seen this? I'm getting this error on a full test run, but not when the set of tests is run on its own: http://paste.ubuntu.com/5758147/ | 13:09 |
| rick_h__ | benji: is this updated trunk? | 13:15 |
| benji | rick_h__: it is on a branch, which hasn't been updated recently | 13:15 |
| rick_h__ | benji: I fixed up some failing tests in trunk yesterday in browsers that didn't show in phantomjs. This looks like phantomjs though | 13:15 |
| benji | this is Chromium | 13:16 |
| rick_h__ | benji: ah, check out trunk. With CI not going we had things land that broke tests in FF/chrome but ran in phantomjs so they landed | 13:16 |
| benji | thanks, I'll take a look | 13:17 |
| benji | rick_h__: no change in test; thanks for the hint though | 13:29 |
| rick_h__ | benji: :( ok nvm then. Not seen that directly then. | 13:30 |
| benji | I really wish we had a decent test runner; doing things like running a subset of the tests is painful. | 13:30 |
| rick_h__ | benji: +1 | 13:32 |
| rick_h__ | benji: so looking at your error again I see it's in browser_charm_view and with us removing the browser subapp feature flag I wonder if this is a side effect? I thought I had gotten all that squared away with yesterday's tests updates though. | 13:36 |
| rick_h__ | benji: so let me know if it doesn't clear up and I can help look at hte branch and peek at it | 13:36 |
| benji | maybe, but the tests pass on trunk and that set of tests pass when run independently; I suspect dirty global state | 13:36 |
| benji | thanks | 13:36 |
| rick_h__ | benji: completely possible. There's still fun with that these days. since the browser subapp isn't FF'd it's always in every App() instance and causes side effects sometimes. We've been working on minimizing that. | 13:37 |
| gary_poster | frankban, hi. off call. | 13:44 |
| gary_poster | so...yuck. | 13:44 |
| gary_poster | frankban, so that means IE CI is completely broken until this is fixed, which is completely out of our control? Maybe we simply need to move it to the end of the CI list? That would mean that we would still see the effects | 13:45 |
| gary_poster | and tests would still fail :-( | 13:45 |
| gary_poster | but FF and chrome would still have a chance to run | 13:46 |
| gary_poster | and hopefully pass | 13:46 |
| sinzui | orangesquad: Do you have a few minutes to review https://code.launchpad.net/~sinzui/charmworld/charm-model-updates/+merge/168812 | 13:46 |
| frankban | gary_poster: I might have a workaround, testing now. Anyway, I was not able to find a specific ie driver bug, only a number of people complaining about weird behaviors in ie click(), more or less similar to this one | 13:46 |
| gary_poster | huh | 13:46 |
| gary_poster | ok thanks frankban | 13:47 |
| abentley | sinzui: sure. | 13:47 |
| frankban | gary_poster: I also saw that the tests output in Jenkins is confusing, maybe stderr is printed before stdout? I am thinking about printing our messages (e.g. restarting API backend, etc..) to stderr | 13:48 |
| gary_poster | huh | 13:48 |
| gary_poster | probably fine | 13:49 |
| frankban | ok, I'll try that | 13:49 |
| hatch | morning | 13:57 |
| gary_poster | morning hatch. trying to finish up the rollup review. can't get the demo to work, but rick did, so it's PEBKAC somehow | 13:58 |
| hatch | hmm that's concerning | 13:59 |
| hatch | any errors? | 13:59 |
| rick_h__ | hatch: morning, thanks for some of the updates. I noticed that some of them in https://codereview.appspot.com/10019050/diff/1/app/views/service.js didn't have a reply so not sure if we're set or want to chat more? | 13:59 |
| gary_poster | no errors hatch | 13:59 |
| hatch | rick_h__: oh right sorry - I didn't comment on those other ones because that whole block is a prototype and will change a lot | 14:00 |
| rick_h__ | hatch: gotcha, ok. | 14:00 |
| rick_h__ | sinzui: invite on the way | 14:01 |
| hatch | gary_poster: hmm that's very odd I'll have to step through it to see if there is somewhere where something could happen | 14:01 |
| * gary_poster liked that code | 14:01 | |
| gary_poster | hatch will ping in a few and we can try it out together in hangout? | 14:02 |
| abentley | sinzui: r=me with some suggestions in the comment. | 14:02 |
| hatch | gary_poster: sure can you give me 10? morning routine around here is still going on so it's a little hectic :) | 14:02 |
| gary_poster | hatch, np, still reviewing :-) | 14:02 |
| hatch | looking at the comments | 14:16 |
| gary_poster | hatch, I have another call in 29. Will try to get your demo working again for a few. if you are up for hangout lemme know, but no pressure. | 14:31 |
| hatch | sure just replying to the last comment | 14:32 |
| gary_poster | cool | 14:32 |
| hatch | ok done that | 14:33 |
| hatch | guichat? | 14:33 |
| gary_poster | ok | 14:33 |
| gary_poster | thx | 14:33 |
| hatch | rick_h__: I'll add XXX's to the codebase | 14:34 |
| rick_h__ | hatch: yea cool. I know it's all balancing between moving forward with ideas vs making sure we don't leave things that could be better behind for later people to fix up/complain about :) | 14:35 |
| rick_h__ | hatch: so take my feedback with a grain of salt and all that. | 14:35 |
| rick_h__ | this is kind of cool, missed this annoucement. https://plus.google.com/+GoogleChromeDevelopers/posts/644qQuBKZeL | 14:40 |
| rick_h__ | editing files directly from the chrome dev tools should be kind of neat, especially with css/etc | 14:40 |
| frankban | guihelp: could you please review https://codereview.appspot.com/10049046 ? This is my attempt to fix CI failures, thanks | 14:41 |
| rick_h__ | http://opensas.wordpress.com/2013/06/12/live-hot-code-reloading-with-chromium-browser-on-linux/ for chromium notes on enabling it | 14:42 |
| Makyo | frankban, taking a look. | 14:42 |
| frankban | thanks | 14:43 |
| adeuring | orangesquad: could one of you have a look at this MP: https://code.launchpad.net/~adeuring/charmworld/1163544-es-error-monkey-search/+merge/168971 ? | 14:55 |
| * sinzui looks | 14:55 | |
| hatch | rick_h__: definitely thanks for the review - normally I would want everything perfect before landing but in this case it's still a WIP | 15:01 |
| hatch | :) | 15:01 |
| hatch | rick_h__: there is also a regression when deploying services from the browser - the ghost config doesn't show all the options | 15:02 |
| hatch | can you get to this this morning? | 15:02 |
| rick_h__ | hatch: looking | 15:12 |
| sinzui | adeuring, I replied with a question? I don't see the unbalanced quote case tested | 15:12 |
| rick_h__ | hatch: did that get fixed before? /me doesn't remember what ever happened with that. | 15:13 |
| adeuring | sinzui: it is tested like the other characters: 'foo %s bar' % '"' | 15:13 |
| hatch | rick_h__: yeah I was sure someone fixed it before | 15:13 |
| rick_h__ | hatch: k, filing a new bug/card. Will see. | 15:13 |
| sinzui | ah! | 15:14 |
| hatch | it must have gotten overridden in a merge or something | 15:14 |
| sinzui | sorry adeuring | 15:14 |
| adeuring | sinzui: no problem ;) | 15:14 |
| sinzui | adeuring, r=m with my suggestion to represent the the special chars as all-caps constants. | 15:14 |
| adeuring | sinzui: thanks | 15:15 |
| rick_h__ | hatch: files as #1190265 | 15:15 |
| _mup_ | Bug #1190265: adding a service does not load all config <charmbrowser> <juju-gui:Triaged> <https://launchpad.net/bugs/1190265> | 15:15 |
| hatch | thanks rick_h__ | 15:30 |
| hatch | I have a spare (rather powerful) server hanging around doing nothing, I wonder if I can instlal openstack on it and run local juju instances | 15:39 |
| hatch | can I run openstack on a single machine? | 15:39 |
| rick_h__ | hatch: I think they're working on that but it's not there yet | 15:43 |
| rick_h__ | hatch: but don't quote me on it | 15:44 |
| hatch | I don't really want to spend to much time on it, so if I can't `apt-get install openstack` I'm not really interested :) | 15:44 |
| gary_poster | benji oops! | 15:47 |
| gary_poster | coming back :-) | 15:48 |
| benji | control-shift-T | 15:48 |
| sinzui | adeuring, did you manually merge? I am looking at jenkins | 15:53 |
| adeuring | sinzui: no, I did not. | 15:54 |
| sinzui | okay, thank you. We are going to wait and see if tarmac does its job | 15:54 |
| gary_poster | jujugui call in 6 | 15:54 |
| gary_poster | kanban now | 15:54 |
| gary_poster | frankban gave you a second LGTM | 15:58 |
| frankban | gary_poster: thanks, submitting | 15:59 |
| gary_poster | jujugui call in 1 | 15:59 |
| gary_poster | benji starting without you (teknico got your message) | 16:01 |
| sinzui | adeuring, I QAed your fix while verifying tarmac was up | 16:14 |
| adeuring | sinzui: thank you | 16:14 |
| rick_h__ | orangesquad, hatch, Makyo anyone up for some review of a nice small one please? https://codereview.appspot.com/10227045 | 16:16 |
| rick_h__ | orangesquad: heads up that kanban is acting nuts. I'm taking the bug #1190063 card next but kanban won't shot it atm. | 16:18 |
| _mup_ | Bug #1190063: going into a category and then hitting back does not re-render the editorial <charmbrowser> <juju-gui:In Progress by rharding> <https://launchpad.net/bugs/1190063> | 16:18 |
| rick_h__ | /shot/show | 16:19 |
| Makyo | rick_h__, looking. | 16:22 |
| rick_h__ | Makyo: ty | 16:22 |
| hatch | rick_h__: looking | 16:25 |
| * gary_poster feels embarrassed he didn't know about bitnami | 16:26 | |
| hatch | rick_h__: done, just one q | 16:27 |
| hatch | I didn't know about it either :) | 16:28 |
| hatch | looks pretty cool on the surface | 16:29 |
| gary_poster | and like the primary closed source and pre-existing competitor to juju | 16:29 |
| hatch | yeah although it appears to be taking a different approach | 16:30 |
| hatch | to the same problem | 16:30 |
| gary_poster | yeah | 16:30 |
| hatch | once we have bundles done I think our approach is better | 16:31 |
| gary_poster | stacks in particular | 16:31 |
| hatch | er yeah, stacks | 16:31 |
| hatch | I get the two mixed up :) | 16:31 |
| gary_poster | :-) yeah | 16:32 |
| * gary_poster runs to lunch for a bit... | 16:32 | |
| rick_h__ | hatch: replied | 16:32 |
| rick_h__ | hatch: basically hasStateChanged is a question, not mutating | 16:32 |
| hatch | gotcha thx | 16:33 |
| teknico | hatch: fixed tests in devel and debug, still the same "not a constructor" error in prod :-/ lp:~teknico/juju-gui/add-cookies-usage-banner | 16:43 |
| hatch | but it works in devel? | 16:43 |
| teknico | yes, under "make test-server" and " make debug" | 16:43 |
| hatch | ok looking | 16:44 |
| teknico | thanks | 16:44 |
| rick_h__ | so something isn't making it into the combined js file :/ | 16:44 |
| teknico | yeah | 16:45 |
| hatch | teknico: ahh it's missing from the bin/merge-files ln89 | 16:45 |
| teknico | hatch: ooh, right | 16:46 |
| hatch | try that out - if that doesn't work then I'll dig further | 16:46 |
| teknico | too many moving parts :-P | 16:46 |
| hatch | ""jenkins is back to normal"" yay! | 16:46 |
| hatch | yeah our build process is too complex | 16:46 |
| teknico | hatch: now it doesn't find Y.Cookie?!? | 16:47 |
| hatch | looking | 16:48 |
| teknico | hatch: does it have to be added to the list on line 74? | 16:48 |
| teknico | yeah, that did it :-P | 16:49 |
| hatch | :/ I really don't understand that | 16:49 |
| teknico | me neither :-/ | 16:49 |
| hatch | those scripts should not need to be manually added into the reqs | 16:49 |
| hatch | what if you add 'cookies' into app.js as a requires | 16:50 |
| hatch | (curious to see if that works) | 16:50 |
| teknico | hatch: do you mean "cookie", and without adding the line "reqs.push('cookie');" to merge-files? | 16:51 |
| hatch | yeah | 16:51 |
| hatch | sorry | 16:51 |
| teknico | hatch: yep, it works | 16:52 |
| teknico | which one is better? | 16:52 |
| hatch | the latter (in app.js) imho | 16:52 |
| teknico | deal | 16:53 |
| hatch | that means that our parsing script is not working properly | 16:53 |
| gary_poster | I think those problems are because the YUI loader isn't designed to be used this way | 17:01 |
| gary_poster | Maybe we could find some nice improvements if we reviewed it though | 17:01 |
| gary_poster | frankban, thank you very much for Jenkins fix! yay! | 17:02 |
| frankban | \o/ | 17:02 |
| teknico | lint fixes, merge from trunk, test again, propose, yadda yadda :-) | 17:04 |
| teknico | hatch: proposed again, how about another review? :-) https://codereview.appspot.com/9967044 | 17:06 |
| teknico | thanks for all the fish, btw :-) | 17:06 |
| hatch | sure give me a few minutes and I can get on it | 17:06 |
| teknico | no hurry | 17:06 |
| hatch | jcastro: is the idea to replace askubuntu with discourse? | 17:13 |
| jcastro | no | 17:14 |
| jcastro | AU is for q+a | 17:14 |
| jcastro | discourse is for watercooling | 17:14 |
| jcastro | "How do I configure Juju to do foo?" goes on AU. "I like Juju let's talk about it." goes on Discourse | 17:15 |
| jcastro | theoretically | 17:15 |
| hatch | ahh gotcha - I wonder if the two can be integrated at all | 17:17 |
| hatch | link from one to the other for example | 17:17 |
| jcastro | yeah I have some ideas | 17:17 |
| jcastro | for oneboxing and making it more seamless, as I'm sure there will/is confusion | 17:17 |
| hatch | discourse confuses me to start with but I'm sure I'll get used to it :) | 17:18 |
| jcastro | it's a fresh start. Brave new world. | 17:18 |
| jcastro | burning of ships. | 17:18 |
| hatch | I don't like new things... | 17:18 |
| * hatch goes back to sit on his porch yelling at the neighbour kids | 17:18 | |
| hatch | lol | 17:18 |
| jcastro | <rick_h> Even I like it, and I hate everything | 17:18 |
| hatch | jk | 17:18 |
| hatch | hahahaha | 17:18 |
| teknico | burning of RAM and CPU, more than anything... | 17:18 |
| rick_h__ | jcastro: :P | 17:19 |
| hatch | btw rick_h__ what's with all the underscores? | 17:19 |
| rick_h__ | hatch: must have been reconnecting at some point | 17:19 |
| === rick_h__ is now known as rick_h | ||
| jcastro | rick_h: we should finish up your blog post | 17:22 |
| rick_h | jcastro: yea, good call. I'll poke at it tonight at CHC | 17:22 |
| hatch | teknico: review done with a few comments (LGTM'd) | 17:27 |
| sinzui | Does anyone on orangesquad have time to review https://code.launchpad.net/~sinzui/charmworld/charm-model-fixes-views/+merge/168175 | 17:30 |
| sinzui | I think kanban is on read-only mode | 17:35 |
| rick_h | sinzui: yea, it's borked. Yellow had issues on their call today as well | 17:36 |
| gary_poster | I don't even get that far | 17:36 |
| sinzui | yeah, I get loading errors sometimes | 17:36 |
| rick_h | ah, loads but as soon as I *do* something it undoes it and yells at me | 17:36 |
| hatch | gary_poster: so is your only issue with trello that it doesn't do wip limits? | 17:37 |
| rick_h | hatch: and you've not written lp-trello to replace lp-kanban | 17:37 |
| * rick_h does use trello for outside of work stuff though heh | 17:37 | |
| hatch | do we need lp-kanban? It was down for the longest time and I didn't even notice :) | 17:38 |
| gary_poster | hatch, no, I also want greater flexibility in arranging the swim lanes than trello provides. | 17:38 |
| hatch | rick_h: yeah so do I haha | 17:38 |
| gary_poster | lp2kanban is less important as we use fewer LP bugs | 17:38 |
| hatch | gary_poster: ahh ok - I'm a +0 in the matter anyways but just curious | 17:39 |
| gary_poster | hatch I looked up WIP limits in trello earlier. whatzizname the big blogger who is part of the company that makes it says that wip should be social anyway. It is social, but don't agree that this means that visually highlighting WIP is unimportant | 17:40 |
| gary_poster | somebody has a chrome plugin I think | 17:40 |
| hatch | https://chrome.google.com/webstore/detail/kanban-wip-for-trello/oekefjibcnongmmmmkdiofgeppfkmdii | 17:41 |
| hatch | that one? :) | 17:41 |
| hatch | yeah - that response sounds like an arrogant one | 17:41 |
| gary_poster | probably. didn't look closely | 17:41 |
| hatch | "we aren't going to add a counter.....because I don't believe in it....yeah that's it" | 17:41 |
| hatch | https://trello.com/card/wip-limits/50e0afbecc2e335d2e000da3/23 | 17:42 |
| hatch | according to this it's done? | 17:42 |
| gary_poster | hatch stared at that but couldn't make much sense of it. Looked for wip before. https://trello.com/board/trello-development/4d5ea62fd76aa1136000000c is trello dev board | 17:45 |
| hatch | yeah the comments are....out there... but it was in the 'done' category heh | 17:45 |
| sinzui | hatch, I agree with gary_poster that WIP limits are fundamental to the intent of kanban. I am glad to see a rival to leankanban though | 17:46 |
| gary_poster | but of what board, hatch? does that actually have anything to do with trello dev? I don't see any wip-style config in "list actions" | 17:46 |
| hatch | on the trello-development board under 'Live' there is (5/31) possible WIP limit? | 17:49 |
| hatch | I agree, I don't see it in the config either | 17:49 |
| hatch | oh that's probably a date | 17:51 |
| hatch | haha | 17:51 |
| hatch | gary_poster: I think here is the feed you were taking about https://twitter.com/spolsky/status/306719908245417984 | 17:53 |
| gary_poster | hatch, yup, that's it. | 17:54 |
| gary_poster | hatch, where's that "possible WIP limit" thing? don't see it in https://trello.com/board/trello-development/4d5ea62fd76aa1136000000c | 17:54 |
| hatch | yeah I don't either | 17:54 |
| hatch | I'm not sure what that other thing was from then | 17:54 |
| gary_poster | ah ok | 17:55 |
| hatch | I'm going to take off for lunch, bbl | 18:03 |
| jcsackett | sinzui: got a moment to chat? | 18:07 |
| sinzui | I do | 18:09 |
| sinzui | jcsackett, ^ | 18:12 |
| jcsackett | cool. | 18:12 |
| jcsackett | ccccccbljtrvgrbjhhhbvihigrddbeglevvfgnevhttk | 18:18 |
| gary_poster | OTOH, if leankit doesn't get their act together, I will be tempted to find other alternatives :-/ | 18:35 |
| benji | debug prints (that raise exceptions) left in tests make Benji cry | 18:50 |
| jcastro | gary_poster: I am in the process of rating a bunch of charms | 18:55 |
| gary_poster | yay! thanks jcastro :-) | 18:55 |
| gary_poster | jujugui, orangesquad, ding dong the witch is dead, or something. leankit appears to be back. | 18:56 |
| sinzui | \o/ | 18:57 |
| Makyo | Undead..? | 18:57 |
| gary_poster | :-) | 18:57 |
| sinzui | thank you for your diligence gary_poster | 18:57 |
| rick_h | jcastro: comming on your MP, I think there's a wire crossed | 18:57 |
| gary_poster | lol, I can reload web pages with the best of 'em | 18:57 |
| jcastro | rick_h: what do you mean? | 18:58 |
| rick_h | sorry, jcsackett ^^ not jcastro | 18:58 |
| rick_h | jcastro: you carry on, rate away kthx :)( | 18:58 |
| gary_poster | heh | 18:58 |
| jcastro | I like how you guys made you guys not landing ratings now blocking on us instead of you guys | 18:58 |
| jcastro | well done sir. | 18:58 |
| * rick_h goes to look for anything else we can shove off on someone else | 18:59 | |
| jcsackett | rick_h: my understanding was we used icon internally, and had the link used by clients of the API. | 18:59 |
| gary_poster | jcastro, :-P :-) | 18:59 |
| rick_h | jcsackett: I thought icon was gone. it's no longer an attribute | 18:59 |
| rick_h | or was going away, abentley can you verify? | 18:59 |
| * benji read that as "shave off of" | 18:59 | |
| rick_h | jcsackett: I thought sinzui was removing it from the model because it had no use | 18:59 |
| jcsackett | rick_h: could be; i missed that, if that's the case. | 19:00 |
| rick_h | benji: I've got my merkur safety razor ready and willing | 19:00 |
| sinzui | icon is gone from staging charm data and will be gone from production data in the next deploy | 19:00 |
| benji | :) | 19:00 |
| rick_h | jcsackett: ^^ | 19:00 |
| jcsackett | sinzui: i'm running off a fresh ingest, so icon is still being brought in somewhere. | 19:01 |
| sinzui | jcsackett, migration 7 cleanup devs and staging, migration 8 cleans up production | 19:01 |
| jcsackett | and by fresh, i mean: i had no data before running this ingest this morning. | 19:01 |
| * gary_poster crosses fingers and toes on Makyo's behalf | 19:01 | |
| Makyo | Crossing everything, over here. Fingers, toes, the dogs' tails.. | 19:02 |
| jcastro | rick_h: hey something to think about wrt. bundles | 19:02 |
| jcastro | so I want to rate "logstash" | 19:02 |
| jcastro | but it's a series of like 4 charms | 19:03 |
| jcastro | maybe we should think about rating the entire thing as a whole | 19:03 |
| jcastro | I think people will want a general view of quality of the entire service, not just the indexer, the webfront end, etc. | 19:03 |
| rick_h | jcastro: hmm, not sure what's up with bundles at this point. I know we talked about forming a 'meta charm' format and getting it into the store like others and you'd just rat the 'meta charm' | 19:03 |
| jcastro | oh ok | 19:04 |
| rick_h | jcastro: so it would work just like it does now for you if that goes through, but I don't think we're doing that any more so not sure what the story is | 19:04 |
| jcastro | well whatever we call them | 19:04 |
| rick_h | jcastro: maybe gary_poster or sinzui can better fill you in what checklist to toss that onto | 19:04 |
| sinzui | jcsackett, charmworld/charmworld/ingest only knows two things about icons. 1 ICON_FILENAME which can be removed (it is unused) and a test verifying icon is not in the charm data | 19:04 |
| gary_poster | jcastro I'll be sending an email out to juju-dev about bundles in the next few days | 19:05 |
| gary_poster | jcastro, I'll include that use case | 19:06 |
| benji | the beginings of Go sandbox branch is up for review: https://codereview.appspot.com/10235045 | 19:06 |
| gary_poster | and you can follow on as you think makes sense. Does that sound good? | 19:06 |
| jcastro | gary_poster: excellent, I will chime in as necessary | 19:06 |
| gary_poster | thanks jcastro | 19:06 |
| jcastro | I hadn't thought about it until I started rating | 19:06 |
| jcastro | then it's like, who cares about the logstash-indexer charm outside of it's stack | 19:07 |
| gary_poster | yeah | 19:07 |
| rick_h | jcastro: yea, I know we talked about it from a charmworld POV in oakland | 19:07 |
| benji | I should have taken a vacation day tomorrow. I'm getting a new mixing board and I can't wait to play with it. | 19:07 |
| rick_h | benji: woot, what did you get? | 19:07 |
| gary_poster | heh | 19:07 |
| benji | Behringer x32 (http://www.youtube.com/watch?v=A5v-JnAvipw) | 19:09 |
| rick_h | whoa, nice | 19:09 |
| Makyo | I have a Behringer Xenyx 1222. Love it :) | 19:11 |
| Makyo | Boy howdy is that one nice, though, benji | 19:11 |
| rick_h | yea, I was thinking like a little 8input board but that's crazy | 19:11 |
| abentley | jcsackett: by "icon is still being brought in", you mean the base64-encoded contents of the icon? That should be impossible. We don't even import base64 anymore. | 19:13 |
| benji | I have 22 inputs but only a 16 channel board now, so the 40 inputs of that guy will be very nice to have; plus I get compression and a nice parametric EQ on each channel and 8 FX slots, so I can stop using over half of the stuff in my rack | 19:14 |
| jcsackett | abentley: i mean right now, i can do img src="data+xml/svg,{$charm ... }" to get an image in a template. | 19:14 |
| jcsackett | abentley: but it doesn't matter. i'll take it on faith that i've got something unusual going on and i'm going to change the branch. | 19:14 |
| abentley | jcsackett: You can look at the contents of the charm by accessing /charms/precise/wordpress/json . If there's a member named "icon" in there, I don't believe that was fresh ingest. | 19:19 |
| abentley | at least not with trunk r245 or a descendant. | 19:20 |
| hatch | benji: cool mixer :) I just got back from lunch....bought a new kiteboard lol | 19:28 |
| hatch | went out for lunch, forgot about lunch, bought a kiteboard....how does that work? | 19:28 |
| benji | distracting hobbies are distracting | 19:28 |
| gary_poster | heh | 19:28 |
| hatch | haha yup | 19:29 |
| hatch | r u in a band? | 19:29 |
| gary_poster | you've heard of zz top? | 19:30 |
| gary_poster | he has a beard wig | 19:30 |
| hatch | lol | 19:30 |
| hatch | it's called 'benji top' and it's a cover band? | 19:30 |
| benji | heh | 19:30 |
| benji | hatch: I am the tech director (and primary mixer) for my church: 2 guitarists, keys, piano, drummer, and five vocalists | 19:31 |
| hatch | coolio! | 19:31 |
| benji | (the base player will be back in the fall; mission trips, the bane of church music programs ;P) | 19:32 |
| hatch | haha | 19:32 |
| benji | [wow, misspelling "bass" is a new low, even for me] | 19:33 |
| gary_poster | ba-dum-dum | 19:33 |
| hatch | it's alright I figured he wasn't the guy everyone stood on :P | 19:33 |
| gary_poster | "bass," "new low," get it? get it? | 19:33 |
| hatch | lol! | 19:34 |
| hatch | *rimshot* | 19:34 |
| gary_poster | :-) | 19:34 |
| benji | heh | 19:34 |
| hatch | interesting email on ubuntu tech about git | 19:35 |
| hatch | and I mean't canonical tech | 19:35 |
| gary_poster | benji lgtm with questions | 19:35 |
| hatch | :) | 19:35 |
| * benji looks at questions. | 19:35 | |
| hatch | oo I think I have finished this panel removal | 19:37 |
| hatch | annnnnd I spoke to soon | 19:38 |
| hatch | who needs tests anyways! | 19:38 |
| hatch | these tests are driving me bonkers | 19:47 |
| rick_h | jcsackett: ping, just a double check. Did you make sure that hasIcon isn't dumped in the API and might cause front end issues? | 20:32 |
| hatch | does anyone know off the top of their head what causes the ghost services to be removed on cancel? | 20:32 |
| hatch | oh hmm | 20:32 |
| hatch | with my new iteration on canceling a deployment the ghost sticks around until the next delta | 20:33 |
| gary_poster | hatch, I think I knew at one point. Makyo should know. | 20:33 |
| Makyo | One sec. | 20:33 |
| hatch | thanks | 20:33 |
| Makyo | hatch, When the charm configuration panel is removed. | 20:34 |
| hatch | ohhh I forgot to fire 'update' | 20:35 |
| Makyo | Okay. | 20:35 |
| hatch | thanks :) | 20:35 |
| hatch | I just needed that 'click' I guess heh | 20:36 |
| hatch | Makyo: the ghost placement is a little odd though | 20:36 |
| hatch | once deployed it bounces to the proper place though | 20:36 |
| hatch | known issue? | 20:36 |
| Makyo | hatch, That was a content-free statement :) What's 'odd' mean? | 20:36 |
| sinzui | orangesquad I have another branch of for review. This one is a drive-by fix: https://code.launchpad.net/~sinzui/charmworld/complete-promulgated-queries/+merge/169052 | 20:37 |
| hatch | it's about 6" to the right of where it 'bounces' to after deploying | 20:37 |
| Makyo | hatch, new as of yesterday *shrug* Was fine when I landed my branch. | 20:37 |
| gary_poster | I've seen it for awhile actually | 20:37 |
| gary_poster | didn't bother me too much | 20:38 |
| abentley | sinzui: looking | 20:38 |
| gary_poster | happy to have a bug, but bigger fish to fry atm | 20:38 |
| Makyo | ?? | 20:38 |
| Makyo | Will look. Maybe it's quick. | 20:38 |
| hatch | Makyo: it does it on uistage | 20:38 |
| Makyo | That code hasn't changed since it was written, really. | 20:38 |
| hatch | when deploying from the charm browser | 20:38 |
| hatch | yeah it may have done this forever, I just noticed it today though :) | 20:39 |
| Makyo | Works locally, will check uistage. | 20:40 |
| Makyo | Works on uistage, too. | 20:41 |
| Makyo | So...I don't know? | 20:41 |
| hatch | lol that's odd...so it doesn't jump to a different place than the ghost on deploy? | 20:42 |
| gary_poster | Makyo, to be clear, it works but it jumps briefly. So, you make a ghost, you drag it somewhere, and then you press confirm. After that, placement changes briefly but it bounces back | 20:42 |
| gary_poster | to where you had dragged it | 20:42 |
| gary_poster | hatch or I can demo | 20:42 |
| gary_poster | but also, I didn't raise it because it was not a high priority for me. basic behavior is good enough for now | 20:43 |
| abentley | sinzui: r=me. Maybe we don't need to worry about searchTasks, if as you say, being subscribed is enough. | 20:43 |
| Makyo | Oh, that's from turning on transitions. | 20:43 |
| Makyo | gary_poster, ^^^ | 20:43 |
| gary_poster | ah! | 20:43 |
| gary_poster | ok | 20:43 |
| Makyo | The x/y coords aren't set until it gets the annotations. | 20:43 |
| Makyo | And when they're set, it jumps. | 20:43 |
| gary_poster | Can we manually set x/y, maybe? | 20:43 |
| gary_poster | before annotations really come in? | 20:44 |
| gary_poster | so, manually set annotations? | 20:44 |
| Makyo | Maybe? I mean, the code is the same code that moves the service if another client drags it, so that you have a visual cue to see that something moved. | 20:44 |
| Makyo | I can poke around at it sometime, I'm sure. We have the pending flag, so we can have conditional code. | 20:45 |
| gary_poster | right cool. also my idea was that we already know what the annotations are supposed to be | 20:45 |
| gary_poster | Makyo, somewhat relatedly, at some point if you have any thoughts on this, we will need multiple ghosts simultaneously soon, for bundles as well as other use cases. If you had any deep thoughts on that I'd love to pick your brain. If not np. We will figure it out | 20:46 |
| hatch | sorry I wasn't bringing this up to have it fixed now... :) it was more of a 'didjaknow?' :D | 20:46 |
| Makyo | gary_poster, Sure, I'll think about it, though I'm sure it'll be trivial; they're stored in the DB with the same data that will be stored server-side, so multiple services can have pending flags. | 20:47 |
| sinzui | thank you abentley | 20:47 |
| Makyo | hatch, no worries, I was just missing the drag part. | 20:47 |
| Makyo | If you start with one service, it looks okay :D | 20:47 |
| gary_poster | cool Makyo thx | 20:47 |
| hatch | removal of the right charm search panel is proposing now | 20:48 |
| gary_poster | thx hatch, lemme know when ready and I'll jump on it. Would be great to have for Huw. | 20:49 |
| hatch | I've noticed that proposing/submitting seems to be taking longer than usual | 20:50 |
| hatch | I wonder if our tests are hitting that critial mass where my mini is just not fast enough :) | 20:50 |
| Makyo | It's the new usual, hatch \o/ | 20:50 |
| hatch | haha ok so it's not just me then? | 20:51 |
| Makyo | I dunno, I was mostly joking. last propose was in core-land. | 20:52 |
| hatch | oh I bet those take forever | 20:52 |
| Makyo | They're reasonably fast, since they don't depend on tests running, but the tests do take quite a while, and lock up my ocmputer in the process. | 20:53 |
| hatch | I bet they use a multi threaded test system don't they? :) | 20:53 |
| hatch | gary_poster: https://codereview.appspot.com/10241043/ qa please :) | 20:54 |
| Makyo | Hah, I have no idea. I joked before that testing was "go build ./... && go test ./... && go get a cup of coffee and maybe a snack" | 20:54 |
| hatch | -1000ln diff!! w000t | 20:54 |
| hatch | haha | 20:54 |
| hatch | Makyo: if you wouldn't mind I'll need another review of the above link :) | 20:55 |
| Makyo | hatch, sure. | 20:55 |
| hatch | thank yas | 20:56 |
| hatch | rick_h: I see you are working on the configuration issue - It's past your EOD now? | 21:07 |
| gary_poster | oh | 21:08 |
| gary_poster | the jump to place does not work with improv at all anymore | 21:08 |
| gary_poster | at least with large | 21:09 |
| gary_poster | hatch, placement of the service is broken in improv in your branch | 21:11 |
| gary_poster | IOW, | 21:11 |
| hatch | hmm | 21:11 |
| gary_poster | if you start with improv (I used large fwiw) | 21:11 |
| gary_poster | and then deploy a charm | 21:11 |
| hatch | ok let me see | 21:11 |
| gary_poster | the ghost will go one place | 21:11 |
| gary_poster | but the new confirmed service will go someplace else | 21:11 |
| gary_poster | (works properly in trunk) | 21:12 |
| gary_poster | notifications work well | 21:13 |
| gary_poster | so that's the only qa issue I found | 21:13 |
| gary_poster | (I'm a bit worried about the configuration issue in this context; I hope this does not confuse rick's issue too much) | 21:13 |
| gary_poster | Hopefully it will be easy enough to work out | 21:14 |
| hatch | yeah... | 21:14 |
| hatch | hmm this placement thing is a little odd | 21:14 |
| hatch | I'm not sure how my removal of code could have messed that up | 21:14 |
| hatch | will look into it | 21:14 |
| gary_poster | thank you | 21:16 |
| hatch | benji: review done see comments :) | 21:16 |
| Makyo | hatch, The notifications icon is now white with white text. Is that a known thing? | 21:16 |
| hatch | Makyo: yeah it's only like that when there are no alerts | 21:16 |
| gary_poster | hatch, that's only if there are no errors, right? | 21:16 |
| hatch | yup | 21:17 |
| gary_poster | :-) | 21:17 |
| hatch | it turns red when there are | 21:17 |
| Makyo | hatch, alright. Doesn't show connection status anymore? | 21:17 |
| hatch | I didn't know that it did... | 21:17 |
| Makyo | Blue was connected, yellow disconnected. | 21:17 |
| gary_poster | ah yes | 21:18 |
| hatch | yes....that's a bug | 21:18 |
| hatch | nice catch! | 21:18 |
| gary_poster | that is a regression, but not from this branch | 21:18 |
| gary_poster | but also | 21:18 |
| hatch | inadvertent issue caused by my bootstrap changes | 21:18 |
| hatch | I can fix that | 21:18 |
| gary_poster | the next branch in this path is to re-style the top | 21:18 |
| gary_poster | but cool, if it is easy that is great | 21:18 |
| hatch | yeah it should be | 21:18 |
| Makyo | Yeah, it can go wherever! Just a useful indication sometimes. | 21:19 |
| hatch | honestly I had no idea haha | 21:19 |
| hatch | I've never seen it yellow | 21:19 |
| Makyo | LGTM with Gary's positioning item, though. | 21:19 |
| hatch | hmm It acts the same on uistage for me (positioning) | 21:20 |
| hatch | it bounces to the 'middle' then back again after deploy | 21:20 |
| Makyo | uistage isn't running improv though, right? | 21:21 |
| hatch | oh I thought it was | 21:21 |
| gary_poster | hatch, I would try trunk with large. I can probably dupe with uistage with enough instructions | 21:21 |
| gary_poster | it used to be running improv | 21:21 |
| gary_poster | I disabled it because of the script kiddies | 21:21 |
| gary_poster | yesterday, I think | 21:21 |
| hatch | I get identical 'bouncing' but because the deltas are longer on improv it takes longer | 21:23 |
| hatch | sure this is caused by my branch? | 21:23 |
| hatch | will try on trunk | 21:23 |
| gary_poster | hatch, I don't think you see what I'm trying to show. one sec, getting different instructions | 21:23 |
| hatch | ok sorry :) | 21:24 |
| gary_poster | np! was not clear | 21:24 |
| hatch | oh I don't get the bouncyness on trunk | 21:26 |
| hatch | it deploys right to where I drop the ghost | 21:26 |
| hatch | umm | 21:27 |
| hatch | ok something is right messed up :/ | 21:27 |
| gary_poster | yeah | 21:27 |
| hatch | the layout is different on trunk than on my branch | 21:27 |
| hatch | with identical rapi setup | 21:27 |
| gary_poster | on trunk it is different but also messed up :-( | 21:27 |
| gary_poster | ah ok | 21:27 |
| gary_poster | that's not good | 21:27 |
| gary_poster | I have a different problem | 21:27 |
| gary_poster | ah! but it is not in your branch. some kind of horrible race condition | 21:28 |
| * Makyo dogwalks quickly. | 21:28 | |
| hatch | guichat? | 21:28 |
| hatch | I'm a little confused here | 21:28 |
| gary_poster | let me see if it happens using the old charm adder | 21:29 |
| hatch | I don't understand how the layouts could be different | 21:29 |
| gary_poster | ok | 21:29 |
| gary_poster | nope still hosed in old adder | 21:31 |
| gary_poster | Makyo, when you get back, I see a problem in trunk (can dupe on uistage) that you can dupe by adding four services in a row | 21:51 |
| Makyo | gary_poster, just got back. | 21:51 |
| gary_poster | cool thanks | 21:51 |
| gary_poster | the first three go to the right place | 21:51 |
| gary_poster | the fourth ghost never appears | 21:51 |
| gary_poster | and then when you confirm it goes in the center of the canvas rather than where the ghost would have gone | 21:52 |
| Makyo | Can't reproduce in hatch's current branch. Which browser and any speed requirements? | 21:53 |
| Makyo | Got it on uistage. | 21:54 |
| hatch | in trunk on sandbox, can't reproduce the 4th ghost issue now.... | 21:55 |
| gary_poster | I did have race conditiony experiences in here somewhere | 21:56 |
| hatch | ahah | 21:56 |
| hatch | Uncaught TypeError: Cannot read property 'index' of undefined d3.v2.min.js:4 | 21:57 |
| hatch | when it doesn't show....that error is in the console | 21:57 |
| gary_poster | ah ok | 21:57 |
| hatch | traceback https://gist.github.com/hatched/0bdebc1a94512730c54e | 21:57 |
| Makyo | I hate having minimized code in development. | 22:02 |
| Makyo | Minified, whatever. | 22:03 |
| hatch | gary_poster: when I use my branch on rapi-large I get an error in the rapi console logs on reploying the new wordpress | 22:03 |
| hatch | CharmStateNotFound | 22:03 |
| gary_poster | hatch...no idea. sure this is not trunk? | 22:04 |
| hatch | then when I delete I get another error | 22:04 |
| hatch | 2013-06-12 16:03:54,828 juju.rapi.delta:ERROR An error occurred 'result' | 22:04 |
| hatch | I'll compare with trunk | 22:04 |
| hatch | oh I get the same failurs in trunk they just don't make the same representation in the UI | 22:06 |
| Makyo | d3.geom.hull fails when vertices form a line. | 22:09 |
| gary_poster | heh | 22:10 |
| gary_poster | silly geometry | 22:11 |
| gary_poster | hey hazmat, could you make ~juju-gui a member of https://launchpad.net/~charming-devs, and whatever else is necessary so that I can be an editor and approver of https://blueprints.launchpad.net/charmworld/+spec/s-cloud-jujucharms-site-authors-api please? | 22:15 |
| Makyo | gary_poster, hatch http://pastebin.ubuntu.com/5759656/ fixes it | 22:16 |
| hatch | the 4th ghost bug? | 22:17 |
| Makyo | yeah | 22:17 |
| gary_poster | cool Makyo thanks. hatch, can you fit that in? | 22:17 |
| hatch | certainly thanks | 22:17 |
| gary_poster | cool thank you | 22:17 |
| hatch | I still can't figure out what my other bug is caused by | 22:17 |
| hatch | wht is 'defaultSeries' ? | 22:17 |
| hatch | what* | 22:18 |
| hatch | this.charmPanel.setDefaultSeries(this.env.get('defaultSeries')); | 22:18 |
| Makyo | hatch, ie: precise, quantal, etc. | 22:18 |
| hatch | ohh | 22:18 |
| hatch | ok nope that's not it | 22:18 |
| rick_h | hatch: yes, past my EOD. Will try to get a fix in tomorrow. | 22:45 |
| gary_poster | how goes it hatch | 23:44 |
| hatch | oh I gave up | 23:45 |
| hatch | I'll be back at it later on | 23:45 |
| gary_poster | :-) ok | 23:45 |
| hatch | fresh mind, fresh eyes :) | 23:45 |
| gary_poster | hey huwshimi. I might have a chance to talk briefly later, or might not | 23:45 |
| gary_poster | hatch has a branch that rips out the right hand side | 23:46 |
| gary_poster | it has one qa issue that he is trying to resolve | 23:46 |
| huwshimi | gary_poster: Ah great | 23:46 |
| gary_poster | but it would not affect the header | 23:46 |
| huwshimi | gary_poster: Should I base my branch off that then? | 23:46 |
| gary_poster | so you could in theory use it as a base for your work if you had time and you thought that would work | 23:46 |
| gary_poster | yeah | 23:46 |
| gary_poster | finding | 23:46 |
| huwshimi | cheers | 23:47 |
| gary_poster | huwshimi, lp:~hatch/juju-gui/remove-charmsearch | 23:47 |
| gary_poster | we discovered two qa issues | 23:48 |
| gary_poster | first, on trunk and in the branch, if you add four services in a row and don't drag them, the fourth ghost doesn't show up. http://pastebin.ubuntu.com/5759656/ from Matt fixes, and Jeff will include it in his branch | 23:49 |
| gary_poster | second, when you add a new ghost and confirm, the real service position is wrong | 23:49 |
| gary_poster | until the annotation comes back | 23:50 |
| gary_poster | that's what he is going to fix later | 23:50 |
| gary_poster | otherwise, the alerts are still as broken as before | 23:50 |
| gary_poster | but the unneeded stuff on the right is gone | 23:50 |
| gary_poster | ok, need to go read books to children | 23:51 |
| gary_poster | maybe back later :-) | 23:51 |
| huwshimi | gary_poster: OK thanks. What do you mean by alerts are still broken? | 23:51 |
| huwshimi | (I'm guessing you mean that you can't open the alerts panel...) | 23:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!