[06:01] <Mirv> the shortlived qmlrunner could be removed now.. https://code.launchpad.net/~timo-jyrinki/ubuntu-ui-toolkit/remove_qmlrunner/+merge/168851
[06:27] <dholbach> good morning
[06:58] <dpm> good morning everyone!
[07:10] <gusch> oSoMoN: ping
[07:11] <oSoMoN> gusch: pong
[07:12] <gusch> oSoMoN: how's the translation of the .desktop files supposed to work?
[07:12] <gusch> oSoMoN: I thought the .dekstop file would then contain all the translations
[07:12] <oSoMoN> gusch: no, not in ubuntu
[07:12] <gusch> oSoMoN: but I don't see them in the generated .desktop file
[07:13] <oSoMoN> gusch: in ubuntu, we have a patch to glib that dynamically loads translations for desktop files from langpacks
[07:14] <oSoMoN> gusch: as long as the desktop file has X-Ubuntu-Gettext-Domain defined, and that the strings to be translated are present in the langpack, then it will just work
[07:16] <gusch> oSoMoN: ah - the X-Ubuntu-Gettext-Domain is the trick
[07:17] <oSoMoN> gusch: yup, if you don’t know about it it really looks like magic…
[07:20] <gusch> oSoMoN: this is the translation for gallery then https://code.launchpad.net/~schwann/gallery-app/gallery-translate-desktop/+merge/168718
[07:21] <oSoMoN> gusch: I’m on it, thanks
[07:21] <oSoMoN> gusch: in the meantime, would you mind having a look at https://code.launchpad.net/~osomon/webbrowser-app/models-in-plugin/+merge/168861 ? it’s some long overdue refactoring
[07:22] <gusch> oSoMoN: on it
[07:22] <oSoMoN> thx
[07:39] <oSoMoN> gusch: added one comment to address, otherwise looks good to me
[07:47] <gusch> oSoMoN: your's looks good, but I found an issue when I try switching tabs
[07:47] <oSoMoN> gusch: interesting, what issue?
[07:48] <gusch> oSoMoN: when clicking on the "upper" part of a tab, i seems to click on the (invisible) suggestion bar
[07:48] <gusch> oSoMoN: clicking on the "lower part" where the toolbar is, it works
[07:48] <oSoMoN> gusch: known bug, already fixed in trunk :)
[07:48] <gusch> oSoMoN: is this known?
[07:48] <gusch> oSoMoN: ah - I thought so, I had one review like this
[07:49] <gusch> oSoMoN: ok - I approve your's
[07:49] <oSoMoN> gusch: yep, you actually approved it :)
[07:49] <oSoMoN> gusch: looking at why I thought your pot file wasn’t up-to-date
[07:49] <gusch> oSoMoN: I thought that's included in th current MR already - so I better asked
[07:50] <gusch> oSoMoN: maybe because nothing changed (except the desktop stuff)
[07:51] <oSoMoN> gusch: when I merge your branch, if I then run "cmake ." and then "make gallery-app.pot", this is the diff I’m getting: http://pastebin.ubuntu.com/5757415/
[07:56] <danz> .
[07:57] <oSoMoN_> gusch: did I miss something? I got disconnected for 4mins
[07:57] <gusch> oSoMoN_: no - just looking
[07:57] <oSoMoN_> ok
[07:58] <gusch> oSoMoN: I'll merge trunk, have a look (I removed the sorting, so there are less changes)
[08:00] <oSoMoN> gusch: if I were you I’d keep the sorting, it’s going to introduce quite a few changes now, but it will keep the file more stable in the future
[08:00] <gusch> oSoMoN: hmmm - ok - then the changes now
[08:01] <gusch> oSoMoN: but even after merging trunk, my pot file does not change (except for the date)
[08:02] <oSoMoN> gusch: that’s weird indeed, let me check if my trunk isn’t up-to-date, by any chance
[08:02] <gusch> oSoMoN: the qml files didn't change for quite a while - so I'm confused
[08:03] <gusch> oSoMoN: maybe on your computer the sorting is different? So sorting the files in cmake will fix that?
[08:04] <oSoMoN> gusch: I don’t see how it could be different, we both use western european locales
[08:05] <gusch> oSoMoN: I pushed an update for sorting the files
[08:05] <oSoMoN> gusch: right, I just compared your CMakeLists.txt and the one in the browser, and in the browser I’m sorting the list of files in cmake indeed, hence the difference
[08:06] <gusch> oSoMoN: ok - is then with my update :)
[08:07] <oSoMoN> gusch: yup, it now works, I’ll approve
[08:07] <gusch> \o/
[08:28] <JamesTait> Good morning all, happy Day Against Child Labour and happy Loving Day! :-D
[09:24] <Laney> ah, finally got crossfading working
[09:57] <gusch> tmoenicke: are you up for a review? https://code.launchpad.net/~schwann/gallery-app/gallery-show-video/+merge/168884
[10:19] <dpm> kalikiana, ant managed to fix the order of the breadcrumbs via CSS, but it seems on some pages there are still extra breadcrumbs, such as the "Basic QML Types" on this page. Is this something that can be fixed (i.e. removing extra breadcrumbs)?
[10:19] <dpm> kalikiana, http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/resolution-independence.html
[10:21] <dpm> The breadcrumbs are ok on the theming page, though: http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/theming-components.html
[10:21] <kalikiana> dpm, yes, that can be removed, it was on purpose as a way to navigate between the different topics
[10:21] <kalikiana> though they aren't strctly related
[10:23] <kalikiana> dpm, if you can give me the CSS needed I'll bring it all together along with fixing the overview
[10:24] <dpm> kalikiana, it's on the e-mail ant sent us
[10:24] <dpm> the scratch.css attachment
[10:24] <kalikiana> oh, my bad, found it
[10:25] <dpm> np, you can simply replace the existing scratch.css with that one
[10:25] <dpm> let me know when the branch is updated, and I'll put the docs online for a final test
[10:25] <kalikiana> awesome, I'm on it right away
[10:28] <dpm> \o/
[10:32] <kalikiana> dpm, sadly the css doesn't work on component pages, eg http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/qml-ubuntu-components0-action.html
[10:35] <dpm> kalikiana, yeah, you're right. Let's get the branch updated first and then we can ask ant if he can have a look at it.
[10:36] <dpm> kalikiana, can the breadcrumb to the root page be added to http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/qml-ubuntu-components0-action.html too, or is qdoc playing tricks there too?
[10:39] <kalikiana> I'll push the branch shortly, I already made some commits
[10:39] <kalikiana> I'm taking a look at that case now
[10:44] <kalikiana> dpm, I just realize the problem with the navigation to QML Items on individual components. qdoc hard-codes the page name, we can't actually pick one there
[10:45] <kalikiana> I can try to do a search-and-replace to make it use the toolkit page instead
[10:45] <kalikiana> I'll let you know shortly if that's possible
[10:47] <dpm> great, thanks kalikiana
[10:53] <kalikiana> dpm, pushed
[10:57] <dpm> kalikiana, and docs updated: http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/overview-ubuntu-sdk.html
[11:01] <dpm> kalikiana, ok, after looking at the docs, I think the only remaining issue that I see now are the still reversed breadcrumbs on http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/qml-ubuntu-components0-button.html - I'll forward that to ant. Have you spotted anything else?
[11:02] <t1mp> gusch: I have gallery-app on desktop, I commented out HUD stuff in GalleryApplication and some FORM_FACTOR references, and when I start it from qtcreator, I do not get past the Loading screen
[11:02] <t1mp> gusch: any ideas?
[11:05] <t1mp> gusch: ok I needed to remove more HUD stuff and then it runs from commandline (not qtc)
[11:05] <om26er> gusch, Hi! I fixed switching to albums tab in autopilot tests for the phone. https://code.launchpad.net/~om26er/gallery-app/fix_tests_on_phones/+merge/168907
[11:09] <kalikiana> dpm, I think it's looking good apart from the reversed bread crumbs
[11:09] <gusch> t1mp: so works now?
[11:09] <gusch> om26er: ok - looking at it
[11:10] <dpm> kalikiana, excellent. I've asked ant if he could have a look. I think once that is fixed we should be good to go
[11:10] <t1mp> gusch: yes it works now
[11:10] <gusch> ok
[11:25] <om26er> oSoMoN, hey!
[11:26] <t1mp> gusch: I'm making some changes in the implementation of ToolbarActions in the UITK, and I have a question about its use in gallery-app
[11:27] <t1mp> gusch: in a few places you define properties like property ActionList overviewTools: PhotosToolbarActions {... }
[11:27] <oSoMoN> om26er: hey
[11:27] <t1mp> gusch: is there a reason that the property is of type ActionList, and not ToolbarActions (the superclass of PhotosToolbarActions)?
[11:27] <om26er> oSoMoN, sometimes many of the autopilot tests for the webbrowser would fail with this http://paste.ubuntu.com/5757909/
[11:28] <oSoMoN> om26er: that’s because one previous test run didn’t terminate cleanly
[11:28] <gusch> t1mp: not that I know of - that's more or less still your code I think ;)
[11:28] <t1mp> gusch: ToolbarActions is currently a subclass of ActionList, but I may be changing that
[11:28] <oSoMoN> om26er: killing the process of the previous test run should fix it
[11:29] <om26er> oSoMoN, yeah, that probably happened
[11:29] <t1mp> gusch: okay, good. If I change the type to ToolbarActions, it works with my experimental UITK branch. Doesn't seem to cause problems, so probably I will propose a small MR for gallery to be compatible with my new implementation
[11:29] <gusch> t1mp: ok - tell when I should the review
[11:29] <t1mp> gusch: do you have daily builds for gallery-app that are automatically included in the newest phone image?
[11:30] <gusch> t1mp: well - currently not, becauso of saucy
[11:30] <gusch> t1mp: but in theory there should be a daily release afaik
[11:30] <t1mp> gusch: how do I ensure that my proposed changes in gallery-app go in the next image? I need it there before updating the UITK (gallery with changes will work with both old and new UITK implementation)
[11:31] <t1mp> gusch: okay. I'll propose an MR for gallery-app today, and before applying the changes in UITK I will check that it works with gallery-app in the latest phone image.
[11:32] <gusch> om26er: I reduced the size of the gallery (40x30 gu size), not it hangs when trying to switch tabs
[11:34] <om26er> gusch, how can I try that ?
[11:34] <om26er> the hang probably means it was not able to switch the tab
[11:35] <gusch> om26er: might be that it hangs when trying to switch to photos - so the same mechanism is needed there
[11:36] <gusch> om26er: I was setting the size in src/gallery-applicaion.cpp (form_factors_ in constructore, and view_.setMinimumSize() in create_view)
[11:36] <om26er> gusch, how can I reduce the size of the app window? directly in code or is there a way to start the app with a given geometry
[11:36] <om26er> aha
[11:44] <t1mp> gusch: the MR is ready: https://code.launchpad.net/~tpeeters/gallery-app/newTools/+merge/168923
[11:44] <gusch> t1mp: ok checking it
[11:44] <t1mp> gusch: thanks!
[12:20] <t1mp> gusch: thanks for the approve. will it be merged automatically?
[12:21] <gusch> t1mp: yes, once jenkins approves as well
[12:21] <t1mp> gusch: great, thanks.
[12:22] <gusch> t1mp: but no idea when it's gonna be released
[12:22] <t1mp> gusch: ok. before merging the changes in UITK I test it with the then-current image so I'll notice whether it is ready
[12:37] <gusch> oSoMoN renato_ tmoenicke review? https://code.launchpad.net/~schwann/gallery-app/gallery-show-video/+merge/168884
[13:05] <oSoMoN> gusch: I can take it, but later this afternoon
[13:06] <gusch> oSoMoN: thx
[13:10] <renato_> gusch, oSoMoN I can take this now :D
[13:11] <gusch> renato_: even better :)
[13:11] <oSoMoN> renato_: be my guest! thanks
[13:15] <renato_> gusch, how do you get the thumbnail for videos?
[13:15] <renato_> gusch, because I created a image provider on mediaplayer application and I think this can be usefull for you
[13:15] <gusch> renato_: atm it's just one dummy image
[13:16] <gusch> renato_: you are my man!
[13:16] <renato_> gusch, basically you do : Image { src: image://thumbnail/<video-file>:<time>
[13:16] <gusch> renato_: but there are at least 2 more steps to take before ...
[13:17] <gusch> renato_: hehe - now in C++ please ;)
[13:18] <renato_> gusch, are you returning a QImage to qml? how do you show the thumbnail?
[13:18] <renato_> gusch, just return the thumbnail url as: "image://thumbnail/<video-file>:<time>"
[13:18] <renato_> the QML will knows how to handle that
[13:19] <gusch> renato_: that would create the thumbnail everey time - not so nice
[13:19] <gusch> renato_: but anyway - that's something for a later MR
[13:19] <dpm> oSoMoN, when you've got a minute, could you give me a hand reviewing https://code.launchpad.net/~dpm/ubuntu-weather-app/desktop-file-i18n/+merge/168946 ? I've figured out how to extract strings from a qmake-based project, but I'm not an expert in qmake syntax and it'd be good to have some sanity checking
[13:19] <dpm> sorry, I meant how to extract *desktop file* strings from a qmake-based project
[13:20] <renato_> gusch, yeah right now my image provider creates the thumbnail every time, but we can change it to create cache on disk this will be good for media-player too
[13:20] <oSoMoN> dpm: I’m not fluent in qmake either, but I’ll sure have a look
[13:20] <dpm> excellent, thanks oSoMoN
[13:21] <renato_> gusch, why your function name is: "isCameraVideo" only videos from camera will appear on the gallery?
[13:22] <gusch> renato_: yes
[13:47] <om26er> gusch, could you approve that albums tab fix, I'll make another branch later for the 'Photos' case
[13:48] <gusch> om26er: ok
[15:19] <lool> dholbach: Did a pass on the fat packages topic
[15:19] <lool> dholbach: (see list)
[15:20] <dholbach> perfect
[15:30] <renato_> oSoMoN, I have updated the share-app translation MR,
[15:30] <renato_> I tested on the device and works nice
[15:31] <oSoMoN> renato_: cool, I’ll review it now
[15:35] <oSoMoN> renato_: that’s a detail, but the pot file should be regenerated, since the qml file changed, line numbers are not matching anymore
[15:35] <oSoMoN> renato_: just run "cmake . && make share-app.pot" and then bzr commit
[15:37] <oSoMoN> renato_: otherwise it looks good to me
[15:38] <renato_> oSoMoN, ok
[15:38] <oSoMoN> renato_: let me know once that’s done, I’ll approve then
[15:41] <kalikiana> oSoMoN, line numbers are not relevant to localization
[15:41] <kalikiana> just to avoid misconceptions
[15:42] <oSoMoN> kalikiana: I know they aren’t
[15:42] <oSoMoN> kalikiana: still, it’s a good practice to update the pot file when source files change
[15:43] <kalikiana> oSoMoN, well personally I find it a flaw in launchpad to require manual maintenance of the pot file in general
[15:43] <kalikiana> it is a generated file
[15:43] <kalikiana> it's not general practise in the gettext world
[15:44] <kalikiana> well, you might agure one more commit doesn't add to the overall ton of noise
[15:45] <oSoMoN> kalikiana: with what we’re setting up for apps, manual maintenance won’t be required any more, we’re integrating with dh_translations that should take care of regenerating the pot file when creating langpacks
[15:48] <kalikiana> oSoMoN, I'd love to see that. imho too many people take it for granted to update it by hand which wastes hours doing that same thing
[15:49] <oSoMoN> kalikiana: yeah, well it’s being implemented in all apps as we speak
[15:55] <oSoMoN> renato_: nevermind, that was really minor, I just approved to speed up the process
[16:07] <renato_> oSoMoN, I am trying to generate the new po file but is not working, the strings inside the desktop file are ignored
[16:09] <oSoMoN> renato_: how do you generate it?
[16:10] <renato_> make share-app.pot
[16:10] <renato_> oSoMoN, first I fixed a problem that the files inised of debian dir was getting translated :D
[16:11] <oSoMoN> huh?
[16:12] <renato_> oSoMoN, if you build the package the qml files are copied to debian and the glob_recursive was listing this files
[16:12] <renato_> oSoMoN, the command that cmake is using is that:
[16:12] <renato_> cd /home/renato/Projects/phablet/share-app-i18n/build/po && /usr/bin/xgettext -o /home/renato/Projects/phablet/share-app-i18n/po/share-app.pot -D /home/renato/Projects/phablet/share-app-i18n --from-code=UTF-8 --c++ --qt --add-comments=TRANSLATORS --keyword=tr --keyword=tr:1,2 --package-name=share-app --copyright-holder='Canonical Ltd.' main.qml share-app.desktop.in
[16:13] <renato_> humm I think I now the problem
[16:14] <oSoMoN> renato_: so it’s parsing only main.qml share-app.desktop.in, there shouldn’t be a problem
[16:15] <renato_> oSoMoN, this was after my fix
[16:16] <renato_> oSoMoN, another thing that I discovery I was already using in the mediaplayer-app is the flag "-s" which already sort the output
[16:16] <renato_> we do not need to sort the files on cmake
[16:17] <renato_> oSoMoN, Fixed
[16:17] <oSoMoN> renato_: nope, that would be the -F flag
[16:17] <oSoMoN> renato_: feel free to replace the sort in cmake by the -F flag, but do not remove it altogether
[16:21] <renato_> oSoMoN, I have pushed the changes
[16:21] <renato_> oSoMoN, I change the mr state to "needs review"
[16:21] <oSoMoN> renato_: ok, let me check
[16:25] <oSoMoN> renato_: I really don’t understand why you need this regexp to exclude files from the list of sources
[16:26] <oSoMoN> renato_: could it be that you ran the make share-app.pot target on an unclean tree?
[16:26] <renato_> oSoMoN, for example, if you run dpkg-builpackage, this will make copy of you installable files
[16:26] <renato_> inside of debian dir
[16:27] <renato_> after that if you try to run make share-app.pot this will get these files
[16:27] <oSoMoN> renato_: d’oh, you shouldn’t run the target on the branch when it’s not clean, you’re working around a non-problem
[16:28] <oSoMoN> renato_: just ensure the tree is clean before running the target, and done
[16:28] <renato_> oSoMoN, this is a problem for me
[16:28] <oSoMoN> renato_: running "bzr clean-tree" is a problem?
[16:28] <renato_> oSoMoN, this does not make sense :D
[16:28] <renato_> why we can not avoid this kind of re-work?
[16:29] <oSoMoN> renato_: I don’t understand, what kind of re-work?
[16:29] <renato_> in the media-player you can run make mediaplayer-app.pot at any moment even if you work dir is not clean
[16:29] <oSoMoN> renato_: on a related note, if you check the pot file, you’ll see that the strings are not sorted by file
[16:29] <renato_> oSoMoN, they are sorted by alphabetical
[16:30] <renato_> like the media-player
[16:30] <oSoMoN> renato_: nope, there is main.qml, then the desktop file, then strings belonging to main.qml again
[16:30] <renato_> which make sense for translator
[16:30] <oSoMoN> ah, right
[16:30] <oSoMoN> sorry, I didn’t notice
[16:31] <oSoMoN> makes more sense to me to have them sorted by file, but ok, it’s a personal preference
[16:31] <oSoMoN> renato_: please remove the hack to exclude files from debian/ though, this is ugly and useless
[16:31] <renato_> oSoMoN, ok
[16:31] <oSoMoN> renato_: you also left over a message(…) log, please remove it
[16:34] <renato_> oSoMoN, done
[16:35] <oSoMoN> thanks, checking
[16:40] <oSoMoN> renato_: I’m running make share-app.pot, and I’m getting the following error:
[16:40] <oSoMoN> make share-app.pot
[16:40] <oSoMoN> /usr/bin/xgettext: --sort-output and --sort-by-file are mutually exclusive
[16:41] <renato_> oSoMoN, sorry, let me fix it
[16:43] <renato_> oSoMoN, done
[16:50] <oSoMoN> renato_: approved, feel free to top-approve yourself once the CI job is successful
[16:50] <renato_> oSoMoN, thanks
[16:52] <Laney> who's involved with the gallery app?
[16:53] <oSoMoN> Laney: gusch is
[16:53] <Laney> I'd like to know if it includes any externally usable QML API for accessing the data
[16:53] <Laney> from poking at the source I can't see that it does
[16:54] <gusch> Laney: in GalleryApplication several Types are exposed to QML
[16:55] <Laney> gusch: ah
[16:55] <Laney> do you know of any example?
[16:56] <gusch> Laney: example for what?
[16:57] <Laney> Something external to gallery-app which is reading its data
[16:57] <gusch> Laney: how to use "extend" QML with custom C++ types?
[16:58] <gusch> Laney: hmmm - not sure what you mean - reading what data?
[16:58] <Laney> Let's say I want to display a list of albums
[17:01] <gusch> Laney: see in rc/qml/AlbumOverview.qml - the the custom item "AlbumCollectionModel" is used as model
[17:02] <gusch> Laney: you could assign this to a ListView.model, and a delegate then read the albums data (title)
[17:03] <gusch> Laney: in gallery in the end a GridView (inside Checkerboard) is used to display the albums for example
[17:04] <Laney> gusch: Yeah I can see it. I think my failure is knowing how to get at it from my code. I'm knew to QML so I don't really know how the module/import system works yet.
[17:05] <Laney> I managed to ascertain that qmldir files have something to do with this but gallery-app doesn't have one of those
[17:05] <gusch> Laney: in case of gallery no module (plugin) is imported. QML knows the datatypes because of GalleryApplication::registerQML() registeres the types
[17:10] <gusch> Laney: what are you trying to do? maybe I can help?
[17:12] <Laney> gusch: Got to go now - I'll get back to you tomorrow
[17:13] <Laney> thanks for your help so far :-)
[17:13] <gusch> Laney: ok