[06:01] the shortlived qmlrunner could be removed now.. https://code.launchpad.net/~timo-jyrinki/ubuntu-ui-toolkit/remove_qmlrunner/+merge/168851 [06:27] good morning [06:58] good morning everyone! [07:10] oSoMoN: ping [07:11] gusch: pong [07:12] oSoMoN: how's the translation of the .desktop files supposed to work? [07:12] oSoMoN: I thought the .dekstop file would then contain all the translations [07:12] gusch: no, not in ubuntu [07:12] oSoMoN: but I don't see them in the generated .desktop file [07:13] gusch: in ubuntu, we have a patch to glib that dynamically loads translations for desktop files from langpacks [07:14] gusch: as long as the desktop file has X-Ubuntu-Gettext-Domain defined, and that the strings to be translated are present in the langpack, then it will just work [07:16] oSoMoN: ah - the X-Ubuntu-Gettext-Domain is the trick [07:17] gusch: yup, if you don’t know about it it really looks like magic… [07:20] oSoMoN: this is the translation for gallery then https://code.launchpad.net/~schwann/gallery-app/gallery-translate-desktop/+merge/168718 [07:21] gusch: I’m on it, thanks [07:21] gusch: in the meantime, would you mind having a look at https://code.launchpad.net/~osomon/webbrowser-app/models-in-plugin/+merge/168861 ? it’s some long overdue refactoring [07:22] oSoMoN: on it [07:22] thx [07:39] gusch: added one comment to address, otherwise looks good to me [07:47] oSoMoN: your's looks good, but I found an issue when I try switching tabs [07:47] gusch: interesting, what issue? [07:48] oSoMoN: when clicking on the "upper" part of a tab, i seems to click on the (invisible) suggestion bar [07:48] oSoMoN: clicking on the "lower part" where the toolbar is, it works [07:48] gusch: known bug, already fixed in trunk :) [07:48] oSoMoN: is this known? [07:48] oSoMoN: ah - I thought so, I had one review like this [07:49] oSoMoN: ok - I approve your's [07:49] gusch: yep, you actually approved it :) [07:49] gusch: looking at why I thought your pot file wasn’t up-to-date [07:49] oSoMoN: I thought that's included in th current MR already - so I better asked [07:50] oSoMoN: maybe because nothing changed (except the desktop stuff) [07:51] gusch: when I merge your branch, if I then run "cmake ." and then "make gallery-app.pot", this is the diff I’m getting: http://pastebin.ubuntu.com/5757415/ [07:56] . [07:57] gusch: did I miss something? I got disconnected for 4mins [07:57] oSoMoN_: no - just looking [07:57] ok === oSoMoN_ is now known as oSoMoN [07:58] oSoMoN: I'll merge trunk, have a look (I removed the sorting, so there are less changes) [08:00] gusch: if I were you I’d keep the sorting, it’s going to introduce quite a few changes now, but it will keep the file more stable in the future [08:00] oSoMoN: hmmm - ok - then the changes now [08:01] oSoMoN: but even after merging trunk, my pot file does not change (except for the date) [08:02] gusch: that’s weird indeed, let me check if my trunk isn’t up-to-date, by any chance [08:02] oSoMoN: the qml files didn't change for quite a while - so I'm confused [08:03] oSoMoN: maybe on your computer the sorting is different? So sorting the files in cmake will fix that? [08:04] gusch: I don’t see how it could be different, we both use western european locales [08:05] oSoMoN: I pushed an update for sorting the files [08:05] gusch: right, I just compared your CMakeLists.txt and the one in the browser, and in the browser I’m sorting the list of files in cmake indeed, hence the difference [08:06] oSoMoN: ok - is then with my update :) [08:07] gusch: yup, it now works, I’ll approve [08:07] \o/ [08:28] Good morning all, happy Day Against Child Labour and happy Loving Day! :-D [09:24] ah, finally got crossfading working === oSoMoN is now known as oSoMoN|afk === gusch_ is now known as gusch [09:57] tmoenicke: are you up for a review? https://code.launchpad.net/~schwann/gallery-app/gallery-show-video/+merge/168884 === chriadam is now known as chriadam|away [10:19] kalikiana, ant managed to fix the order of the breadcrumbs via CSS, but it seems on some pages there are still extra breadcrumbs, such as the "Basic QML Types" on this page. Is this something that can be fixed (i.e. removing extra breadcrumbs)? [10:19] kalikiana, http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/resolution-independence.html [10:21] The breadcrumbs are ok on the theming page, though: http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/theming-components.html [10:21] dpm, yes, that can be removed, it was on purpose as a way to navigate between the different topics [10:21] though they aren't strctly related [10:23] dpm, if you can give me the CSS needed I'll bring it all together along with fixing the overview [10:24] kalikiana, it's on the e-mail ant sent us [10:24] the scratch.css attachment [10:24] oh, my bad, found it [10:25] np, you can simply replace the existing scratch.css with that one [10:25] let me know when the branch is updated, and I'll put the docs online for a final test [10:25] awesome, I'm on it right away [10:28] \o/ [10:32] dpm, sadly the css doesn't work on component pages, eg http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/qml-ubuntu-components0-action.html [10:35] kalikiana, yeah, you're right. Let's get the branch updated first and then we can ask ant if he can have a look at it. [10:36] kalikiana, can the breadcrumb to the root page be added to http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/qml-ubuntu-components0-action.html too, or is qdoc playing tricks there too? [10:39] I'll push the branch shortly, I already made some commits [10:39] I'm taking a look at that case now === oSoMoN|afk is now known as oSoMoN [10:44] dpm, I just realize the problem with the navigation to QML Items on individual components. qdoc hard-codes the page name, we can't actually pick one there [10:45] I can try to do a search-and-replace to make it use the toolkit page instead [10:45] I'll let you know shortly if that's possible [10:47] great, thanks kalikiana [10:53] dpm, pushed [10:57] kalikiana, and docs updated: http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/overview-ubuntu-sdk.html [11:01] kalikiana, ok, after looking at the docs, I think the only remaining issue that I see now are the still reversed breadcrumbs on http://people.canonical.com/~dpm/sdk-docs/breadcrumbs-fixed/qml-ubuntu-components0-button.html - I'll forward that to ant. Have you spotted anything else? [11:02] gusch: I have gallery-app on desktop, I commented out HUD stuff in GalleryApplication and some FORM_FACTOR references, and when I start it from qtcreator, I do not get past the Loading screen [11:02] gusch: any ideas? [11:05] gusch: ok I needed to remove more HUD stuff and then it runs from commandline (not qtc) [11:05] gusch, Hi! I fixed switching to albums tab in autopilot tests for the phone. https://code.launchpad.net/~om26er/gallery-app/fix_tests_on_phones/+merge/168907 [11:09] dpm, I think it's looking good apart from the reversed bread crumbs [11:09] t1mp: so works now? [11:09] om26er: ok - looking at it [11:10] kalikiana, excellent. I've asked ant if he could have a look. I think once that is fixed we should be good to go [11:10] gusch: yes it works now [11:10] ok === MacSlow is now known as MacSlow|lunch [11:25] oSoMoN, hey! [11:26] gusch: I'm making some changes in the implementation of ToolbarActions in the UITK, and I have a question about its use in gallery-app [11:27] gusch: in a few places you define properties like property ActionList overviewTools: PhotosToolbarActions {... } [11:27] om26er: hey [11:27] gusch: is there a reason that the property is of type ActionList, and not ToolbarActions (the superclass of PhotosToolbarActions)? [11:27] oSoMoN, sometimes many of the autopilot tests for the webbrowser would fail with this http://paste.ubuntu.com/5757909/ [11:28] om26er: that’s because one previous test run didn’t terminate cleanly [11:28] t1mp: not that I know of - that's more or less still your code I think ;) [11:28] gusch: ToolbarActions is currently a subclass of ActionList, but I may be changing that [11:28] om26er: killing the process of the previous test run should fix it [11:29] oSoMoN, yeah, that probably happened [11:29] gusch: okay, good. If I change the type to ToolbarActions, it works with my experimental UITK branch. Doesn't seem to cause problems, so probably I will propose a small MR for gallery to be compatible with my new implementation [11:29] t1mp: ok - tell when I should the review [11:29] gusch: do you have daily builds for gallery-app that are automatically included in the newest phone image? [11:30] t1mp: well - currently not, becauso of saucy [11:30] t1mp: but in theory there should be a daily release afaik [11:30] gusch: how do I ensure that my proposed changes in gallery-app go in the next image? I need it there before updating the UITK (gallery with changes will work with both old and new UITK implementation) [11:31] gusch: okay. I'll propose an MR for gallery-app today, and before applying the changes in UITK I will check that it works with gallery-app in the latest phone image. [11:32] om26er: I reduced the size of the gallery (40x30 gu size), not it hangs when trying to switch tabs [11:34] gusch, how can I try that ? [11:34] the hang probably means it was not able to switch the tab [11:35] om26er: might be that it hangs when trying to switch to photos - so the same mechanism is needed there [11:36] om26er: I was setting the size in src/gallery-applicaion.cpp (form_factors_ in constructore, and view_.setMinimumSize() in create_view) [11:36] gusch, how can I reduce the size of the app window? directly in code or is there a way to start the app with a given geometry [11:36] aha [11:44] gusch: the MR is ready: https://code.launchpad.net/~tpeeters/gallery-app/newTools/+merge/168923 [11:44] t1mp: ok checking it [11:44] gusch: thanks! === MacSlow|lunch is now known as MacSlow [12:20] gusch: thanks for the approve. will it be merged automatically? [12:21] t1mp: yes, once jenkins approves as well [12:21] gusch: great, thanks. [12:22] t1mp: but no idea when it's gonna be released [12:22] gusch: ok. before merging the changes in UITK I test it with the then-current image so I'll notice whether it is ready [12:37] oSoMoN renato_ tmoenicke review? https://code.launchpad.net/~schwann/gallery-app/gallery-show-video/+merge/168884 [13:05] gusch: I can take it, but later this afternoon [13:06] oSoMoN: thx [13:10] gusch, oSoMoN I can take this now :D [13:11] renato_: even better :) [13:11] renato_: be my guest! thanks [13:15] gusch, how do you get the thumbnail for videos? [13:15] gusch, because I created a image provider on mediaplayer application and I think this can be usefull for you [13:15] renato_: atm it's just one dummy image [13:16] renato_: you are my man! [13:16] gusch, basically you do : Image { src: image://thumbnail/: