| hatch | it opens | 00:13 |
|---|---|---|
| hatch | you can't open it? | 00:13 |
| hatch | ^ huwshimi | 00:13 |
| huwshimi | hatch: I had to add a charm first | 00:19 |
| hatch | huwshimi: so how's it going? Are you wroking now? I have no idea what your hours are :) | 02:54 |
| huwshimi | hatch: Hey, yeah I start my day at the end of yours (well, depending on what hours you work :)) | 03:15 |
| hatch | i'm UTC-6 | 03:15 |
| huwshimi | hatch: I'm UTC+10 | 03:16 |
| hatch | 16h difference? | 03:16 |
| hatch | crazy | 03:17 |
| gary_poster | matsubara, hey! how goes tarmac? | 12:45 |
| gary_poster | hey hazmat, could you make ~juju-gui a member of https://launchpad.net/~charming-devs, and/or whatever else is necessary so that I can be an editor and approver of https://blueprints.launchpad.net/charmworld/+spec/s-cloud-jujucharms-site-authors-api (and add my own blueprints there) please? | 12:46 |
| matsubara | gary_poster, hey I think it's ready to switch on. I'd like to make a test run. do you have a mp ready so I can test? | 12:47 |
| gary_poster | matsubara, awesome! lemme see | 12:47 |
| gary_poster | matsubara, benji's mp looks like it will be ready Real Soon Now | 12:49 |
| gary_poster | yeah benji? | 12:49 |
| * benji frantically hits ctrl-c | 12:49 | |
| benji | I was submitting it. | 12:49 |
| gary_poster | lol | 12:49 |
| gary_poster | matsubara, https://code.launchpad.net/~benji/juju-gui/go-sandbox/+merge/169036 if benji was able to stop the submission in time :-) | 12:50 |
| benji | https://code.launchpad.net/~benji/juju-gui/go-sandbox/+merge/169036 | 12:50 |
| benji | yep | 12:50 |
| gary_poster | cool! | 12:50 |
| benji | thank goodness for long test runs | 12:50 |
| matsubara | haha | 12:50 |
| gary_poster | thanks benji. have at it with our thanks matsubara :-) | 12:50 |
| benji | The best thing I've read this week: "On FedEx vehicle for delivery" | 12:51 |
| gary_poster | heh | 12:51 |
| gary_poster | I never looked at that video | 12:51 |
| gary_poster | I'll go look | 12:51 |
| gary_poster | heh, wow | 12:53 |
| gary_poster | very nice benji :-) | 12:55 |
| benji | I'm very excited. :) | 12:56 |
| rick_h | jcsackett: ping, got a sec? | 13:01 |
| gary_poster | morning sinzui. If you have some time in the next hour to talk blueprints, I'd like to run some things past you and ask some questions | 13:02 |
| sinzui | gary_poster, I do after 10. | 13:02 |
| gary_poster | sinzui, you mean 10 minutes or 10AM? | 13:03 |
| sinzui | 10AM | 13:03 |
| gary_poster | sinzui, ack. I'm booked after 10 until the afternoon, and was hoping to catch up with you in the morning. If I have a free moment I'll check with you, and otherwise will try you in the afternoon. thanks | 13:04 |
| matsubara | gary_poster, benji: that MP is still in needs review and no commit message set | 13:04 |
| benji | oh, I guess that's something the new lpsubmit will do; I'll hand-edit the MP now | 13:05 |
| gary_poster | thanks benji | 13:05 |
| gary_poster | (and yes, it does that) | 13:05 |
| benji | matsubara: you should be good to go | 13:06 |
| matsubara | benji, looks like it picked the MP while you're still editing the commit message but had changed the status to approved | 13:09 |
| matsubara | it's a good sign that tarmac is working heh | 13:09 |
| benji | heh | 13:09 |
| gary_poster | :-) | 13:09 |
| benji | yeah, I guess I should have done that in the other order | 13:10 |
| matsubara | I'm re-running it. Tarmac picked it up and should start the jenkins job soon | 13:11 |
| teknico | gary_poster: we can move our call up if it helps | 13:15 |
| matsubara | gary_poster, benji: voting criteria not met. A member of juju-gui hackers needs to approve the MP (I claimed the review and approved it and am re-running the tests) | 13:15 |
| benji | matsubara: I approved it, is self-approval not allowed? | 13:16 |
| gary_poster | teknico, thank you, great idea. maybe in 14? sinzui, then we'd be able to talk at 10 | 13:16 |
| matsubara | benji, yes, it's allowed. the thing tarmac complained is that there were no review approvals | 13:17 |
| teknico | gary_poster: deal | 13:17 |
| benji | ah | 13:17 |
| gary_poster | thanks teknico | 13:17 |
| gary_poster | matsubara, we need >= 0 | 13:17 |
| matsubara | benji, it needs the reviewer approval and the global status approved | 13:17 |
| matsubara | ah ok | 13:17 |
| matsubara | I'll change that | 13:17 |
| gary_poster | thanks | 13:17 |
| gary_poster | otherwise the rietveld workflow doesn't work, unfortunately | 13:18 |
| matsubara | gary_poster, well I guess then it's just a matter of disabling the voting plugin from tarmac, right? | 13:18 |
| rick_h | gary_poster: I thought abentley's tool would copy the LGTM as 'approved' and would make that work | 13:19 |
| matsubara | since once there's a MP on LP, means it's approved from the rietveld side | 13:19 |
| gary_poster | matsubara, makes sense. we might want it later but not now | 13:19 |
| matsubara | cool | 13:19 |
| abentley | rick_h: No, my tool ignores reitveldt entirely, since all the necessary info is on Launchpad. | 13:19 |
| rick_h | abentley: ok, so it doesn't make the LGTM comments copied into LP a "approve" state? | 13:19 |
| abentley | rick_h: No. It's a user script. You'd have to be an admin to change someone else's vote. | 13:20 |
| rick_h | abentley: ah, nvm then. oh well | 13:20 |
| matsubara | gary_poster, benji: http://10.189.74.2:8080/view/CE/job/jujugui-merger-trunk/7/console | 13:21 |
| gary_poster | rick_h, abentley's script looks at reitveld LGTM and adds that to the commit message | 13:21 |
| matsubara | it's running the tests, could you look at the output and see if looks sane? | 13:21 |
| gary_poster | matsubara, so far so good! | 13:21 |
| rick_h | gary_poster: gotcha, I misunderstood. I thought it would change the type of comment to an approval as well | 13:21 |
| benji | it wouldn't be too hard to make it do so. All rietveld does is look for the string "LGTM" | 13:22 |
| gary_poster | benji, per Aaron's comment, the problem there is that the script is running as a user | 13:23 |
| abentley | benji: It wouldn't be hard to impersonate someone else on Launchpad and change their vote? | 13:23 |
| gary_poster | rt | 13:23 |
| benji | ah, foiled by security | 13:23 |
| gary_poster | matsubara, where is the merge of benji's branch in there? | 13:23 |
| matsubara | gary_poster, take a look at: http://10.189.74.2:8080/view/CE/job/jujugui-merger-trunk/configure I had to change slightly the command so tarmac can work. | 13:25 |
| matsubara | gary_poster, tarmac merges benji's branch on /tmp/tmpOz9IkX/ then the builder machine copies that dir over and runs the tests on top of it. | 13:26 |
| matsubara | gary_poster, one thing though, when jenkins run: bin/test-charm --origin $JUJU_BRANCH --charm $JUJU_CHARM, what does the --origin mean in that context? | 13:27 |
| abentley | orangesquad: Could you please review https://code.launchpad.net/~abentley/charmworld/no-docs/+merge/169202 ? | 13:28 |
| rick_h | abentley: looking | 13:28 |
| gary_poster | benji, any chance you could help matsubara on the above? I need to do some other call-y bits, and I know you knew a previous incarnation of test-charm :-) | 13:30 |
| gary_poster | benji, hatch will also know where bodies are buried when he is around | 13:30 |
| * benji looks | 13:30 | |
| matsubara | let me get a diff of the changes, it'll be easier | 13:31 |
| benji | matsubara: "origin" is where to get the source code | 13:33 |
| matsubara | benji, https://pastebin.canonical.com/92720/ | 13:33 |
| matsubara | err | 13:33 |
| matsubara | clearly pasted the wrong thing | 13:33 |
| benji | and I don't have my phone on me to log into that thing anyway | 13:34 |
| * benji goes to find his phone. | 13:34 | |
| matsubara | https://pastebin.canonical.com/92721/ | 13:34 |
| matsubara | benji, http://pastebin.ubuntu.com/5761464/ | 13:35 |
| benji | thanks matsubara. what am I looking at? | 13:38 |
| matsubara | benji, so these are the changes to make tarmac work. Tarmac creates a tmp dir with lp:juju-gui + the approved MP branch. The jenkins jobs then copies that tmp dir from tarmac machine and runs the test on top of it. I think what's missing is tarmac to send $JUJU_BRANCH to the job and use that as the --origin | 13:43 |
| benji | matsubara: cool; I still don't quite understand what (if anything) you're asking me to do though :) | 13:45 |
| sinzui | orangesquad, gary_poster, all the charms are being re-indexed...search has not charms at this time | 13:49 |
| sinzui | I expect them to be back in 15 minutes | 13:50 |
| abentley | sinzui: Hmm. Shouldn't work that way. The new index is supposed to become active after the copy is complete. | 13:50 |
| sinzui | abentley, isn't this the stale queue issue with branch_deleted? | 13:50 |
| abentley | sinzui: Are we talking about reindexing or ingest? | 13:50 |
| sinzui | abentley, ingest really | 13:51 |
| abentley | sinzui: Oh, then yes we probably hit the same branch_deleted issue. | 13:51 |
| sinzui | I see charms re-appearing now | 13:52 |
| sinzui | I see 75% of the charms now | 13:54 |
| hatch | morning | 13:55 |
| hatch | gary_poster: benji no bodies in CI , it's stable as a rock... | 13:56 |
| hatch | bahahaha | 13:56 |
| gary_poster | hatch, :-) | 13:56 |
| * benji doesn't understand but guesses that is a good thing. | 13:56 | |
| gary_poster | sinzui, is this something that might need to happen again? | 13:56 |
| hatch | gary_poster: last night I fixed the jumping service issue, waiting for Makyo to tell me why it's doing what it's doing (hoping he knows) | 13:57 |
| Makyo | Yoooou raaaaaang? | 13:57 |
| gary_poster | lol! | 13:57 |
| hatch | oh haha, I thought you didn't start for another hour | 13:57 |
| gary_poster | hatch, great! huwshimi has lp:~huwshimi/juju-gui/header-design | 13:58 |
| gary_poster | based on your branch | 13:58 |
| gary_poster | I've been trying to catch a few minutes to look at it | 13:58 |
| Makyo | Nah, 8 my time. | 13:58 |
| Makyo | So 2 minutes. Let me make another coffee. | 13:58 |
| sinzui | gary_poster, yes....We think we want to empty the ingest queue after each deploy of code to ensure the ingest/indexing process is knows exactly what it will find in the queue | 13:58 |
| hatch | Makyo: oh so we must be on the same tz right now | 13:58 |
| gary_poster | sinzui, ah ok. this strikes me as a significant usability issue if it means that no-one can search for charms from jujucharms.com and the GUI everytime we roll out | 13:59 |
| hatch | gary_poster: cool, am I supposed to merge it into my branch? | 13:59 |
| sinzui | gary_poster, It dosen't happen every time, but I think the next time we change the definition of charm data, we must ensure there is a mechanism to clear the queue | 13:59 |
| gary_poster | hatch, not supposed to. Would be nice to have it land today. Separately probably makes sense | 14:00 |
| gary_poster | hatch, you or I can try to get it reviewed and landed once your branch is in | 14:00 |
| sinzui | gary_poster, I take the loss of search as down-time and we don't ever want to be down more than a few seconds | 14:00 |
| hatch | alrighty | 14:00 |
| * hatch grabs coffee | 14:00 | |
| gary_poster | sinzui, k. you available now for call? can talk about this also then | 14:01 |
| sinzui | 5 minutes? I need to find coffee | 14:01 |
| gary_poster | cool sinzui | 14:01 |
| gary_poster | benji, hatch, matsubara goal of conversation with matsubara is to review what he has set up with tarmac so we can sanity check it. Also matsubara had one specific question: | 14:02 |
| gary_poster | matsubara> gary_poster, one thing though, when jenkins run: bin/test-charm --origin $JUJU_BRANCH --charm $JUJU_CHARM, what does the --origin mean in that context? | 14:02 |
| hatch | matsubara: gary_poster it's the origin to pull the gui source from | 14:03 |
| gary_poster | hatch, so does that mean the branch that is being tested? | 14:03 |
| hatch | correct | 14:03 |
| gary_poster | I am afraid that the config that matsubara has might still be testing the trunk, rather than the merged branch from tarmac | 14:04 |
| gary_poster | so that's what I'd review | 14:04 |
| gary_poster | in particular | 14:04 |
| hatch | see lib/deploy_charm_for_testing.py:188 | 14:04 |
| matsubara | gary_poster, hatch, I think I have enough to continue. I'll have to change the jenkins tarmac plugin to send the $JUJU_BRANCH as well. | 14:06 |
| matsubara | while bin/test-charm is being run from trunk + mp's approved branch | 14:06 |
| sinzui | gary_poster, ready | 14:07 |
| Makyo | Alright, hatch. What's up? | 14:10 |
| gary_poster | cool matsubara thanks | 14:10 |
| hatch | Makyo: ok in onCharmDeployClicked in views/charm-panel.js there is a call to env.update_annotations() | 14:10 |
| hatch | in that call it updates the gui-x and gui-y which work as planned | 14:11 |
| hatch | then in the callback it removes the x and y attributes from the ghost | 14:11 |
| hatch | it's this removal which is causing the jumping in my branch and not in trunk | 14:11 |
| hatch | it appears to have no side effect if I comment those out | 14:11 |
| hatch | so the issue is that when, in the following lines, it setAttrs() there is no x, y so it places it in the middle | 14:12 |
| Makyo | Alright, I see what you mean. I think that's left over from there potentially not being annotations to set, which changed when we added the branch for new service placement. | 14:15 |
| Makyo | I think those are safe to remove, now. | 14:15 |
| hatch | excellent - I really dont know why it breaks in my branch and not in trunk however | 14:16 |
| hatch | I just found the sollution, around 1am I called it quits hah | 14:16 |
| Makyo | Yeah. I don't necessarily know why, either, but I don't see a problem with the solution. | 14:17 |
| Makyo | Would take some digging. Worth QAing extra. | 14:17 |
| hatch | cool - will work on cleaning up the mess I made of this branch tracking that down then land this | 14:18 |
| hatch | thanks for the sanity check | 14:18 |
| Makyo | Oh, hey, neat: http://www.google.com/trends/hottrends/visualize?nrow=15&ncol=15 | 14:23 |
| sinzui | adeuring, Let's consider https://bugs.launchpad.net/charmworld/+bug/1190627 as a part of the feature you are working on. We don't want charms to disappear temporarily. In this case, the unavailable service is our queue because it contains stale data | 14:46 |
| _mup_ | Bug #1190627: Charms can disappear when code is deployed with a stale queue <deployment> <ingest> <charmworld:Triaged> <https://launchpad.net/bugs/1190627> | 14:46 |
| adeuring | sinzui: right | 14:46 |
| hatch | Makyo: what am I looking at? | 14:49 |
| Makyo | Search trends in real time. | 14:49 |
| hatch | ohh - I thought it was Google making fun of Windows 8 tiles | 14:50 |
| hatch | lol | 14:50 |
| Makyo | Hah :D | 14:50 |
| hatch | ohhh Makyo one other thing | 14:52 |
| Makyo | Shoot. | 14:52 |
| hatch | trunk is broken wrt service layout | 14:52 |
| hatch | on rapi large, take note of the layout | 14:52 |
| hatch | add a service, wait for it to become 'alive' | 14:52 |
| hatch | then refresh | 14:52 |
| hatch | your other services will have moved | 14:52 |
| hatch | sometimes only a little, sometimes a lot depending on their orientation | 14:53 |
| Makyo | hatch, that's by design because default layout doesn't imply annotations have been set, nor does it set them. They are set when a new service is added, though. | 14:53 |
| hatch | ok so if I move all services then that shouldn't happen? | 14:53 |
| Makyo | Correct. In reality, it will likely be one of two cases: the IS case, in which annotations will never be set because the GUI is effectively read-only, and the deploying case, where annotations will always be set because they were deployed from the GUI. The intermediate case you're dealing with is possible, but the default layout encourages dragging; if we come up with a more intelligent default layout scheme, we can start setting annotati | 14:55 |
| Makyo | ons by default. | 14:55 |
| abentley | sinzui: pre-imp re: 1176901 ? | 14:56 |
| hatch | kewl I see that now, thanks for clearing that up | 14:56 |
| sinzui | abentley, in a few minutes, just finishing a meeting | 14:56 |
| sinzui | abentley, I am ready | 15:02 |
| benji | matsubara: are you still working with my branch or should I land it the old-fashioned way? | 15:09 |
| matsubara | benji, sorry, running tarmac again. If it doesn't work this time, I'll re-enable the old jenkins job and you can land in the old way | 15:15 |
| benji | cool, thanks | 15:15 |
| abentley | sinzui: We could avoid spamming the store in the case of multiple jobs for a charm using rate-limiting. We could store the last-updated-from-store time, and skip retrieving that data if we used the store too recently. | 15:33 |
| hatch | orangesquad: do you already have a bug for a request to https://manage.jujucharms.com/api/2/charm/login when logging out of the GUI ? | 15:35 |
| rick_h | hatch: not that I know of. Can you file something with instructions for duplicating? | 15:35 |
| hatch | definitely, do the bugs just go on juju-gui? Do I tag it with anything for you guys? | 15:36 |
| rick_h | hatch: yes, tag it charmbrowser | 15:36 |
| hatch | cando! | 15:36 |
| rick_h | hatch: though I'm confused, is this on manage.jujucharms.com? | 15:36 |
| * rick_h is confused, what logout did you hit to get an api url? | 15:36 | |
| hatch | on trunk running rapi | 15:36 |
| hatch | clicked the logout button | 15:36 |
| rick_h | hatch: k, yea then tag charmbrowser under the juju-gui I guess | 15:36 |
| hatch | actually it does it on sandbox as well | 15:37 |
| hatch | ok making ticket | 15:37 |
| hatch | hey it looks like the tarmac is working | 15:38 |
| hatch | matsubara: any way we can get the codereview link in the comment like before? | 15:38 |
| benji | nice: "Status: Approved => Merged" | 15:39 |
| matsubara | hatch, what do you mean? | 15:40 |
| hatch | matsubara: https://code.launchpad.net/~juju-gui/juju-gui/trunk see 728 vs 727 | 15:40 |
| benji | hatch: right now the commit message is hand-rafted | 15:40 |
| hatch | it's not a huge deal, I have just found myself using it before | 15:40 |
| benji | or "crafted" even | 15:40 |
| * benji invents the new sport of "hand rafting"; very dangerous. | 15:41 | |
| benji | in other words, I didn't copy that bit into the text box | 15:41 |
| hatch | benji: well I think it was inserted into there by something automatically | 15:45 |
| hatch | I like having that and the reviewers in there so when something breaks you know who to talk to and any review comments easily at hand | 15:46 |
| benji | hatch: lbox submit does it, but since I wasn't using lbox to land the MP, I had to do it | 15:46 |
| hatch | ohh ok so it's something we can add back in at a later time | 15:46 |
| hatch | ? | 15:46 |
| benji | right, I assume lpsubmit will do the same thing | 15:46 |
| hatch | rick_h: here you go https://bugs.launchpad.net/juju-gui/+bug/1190653 | 15:48 |
| _mup_ | Bug #1190653: Clicking logout makes request to manage.jujucharms.com <charmbrowser> <juju-gui:Triaged> <https://launchpad.net/bugs/1190653> | 15:48 |
| hatch | benji: ahh cool | 15:48 |
| rick_h | hatch: thanks, adding to the board | 15:48 |
| hatch | it's a pretty odd issue | 15:49 |
| gary_poster | jujugui call in 8 | 15:52 |
| abentley | hatch: you can look up a merge proposal with lp-find-proposal, e.g. bzr lp-find-proposal -r 728:lp:~juju-gui/juju-gui/trunk | 15:52 |
| gary_poster | kanban now | 15:52 |
| hatch | abentley: lol I can't even remember the proper bzr diff syntax half the time I'll definitely never remember that ;) | 15:54 |
| abentley | hatch: If you're in a trunk branch, lp-find-proposal -r 728 will work. | 15:54 |
| hatch | oh that I can remember :) | 15:55 |
| abentley | hatch: In fact, after you run log, any revno you see will work as long as you don't switch branches. | 15:55 |
| hatch | bzr has much saner defaults than git I find but I have no idea why I can't remember the syntax | 15:55 |
| gary_poster | jujgui call in 2 | 15:58 |
| teknico | jujugui ^^ :-) | 15:59 |
| gary_poster | heh thanks | 15:59 |
| gary_poster | matsubara, is tarmac ready to go for us, then? | 16:03 |
| gary_poster | luca__, hey. any news on google docs form and user form link design? | 16:05 |
| luca__ | gary_poster: it's in progress, I imagine It'll be finished tomorrow | 16:05 |
| gary_poster | great thanks luca__ ! | 16:06 |
| luca__ | gary_poster: no problem :) | 16:06 |
| matsubara | gary_poster, nope. it can land stuff but still needs to be modified to send the JUJU_BRANCH | 16:06 |
| gary_poster | ok thanks matsubara let us know | 16:06 |
| matsubara | gary_poster, I'll re-enable the old job for now and let you know when I can test again | 16:06 |
| gary_poster | thanks :-) | 16:06 |
| benji | gary_poster: sent to juju-gui-peeps (I hope that is still active) | 16:14 |
| gary_poster | it is thanks benji | 16:14 |
| hatch | I got it | 16:15 |
| hatch | thanks | 16:15 |
| hatch | gary_poster: the remove-charmsearch branch is re-proposing now | 16:15 |
| gary_poster | hatch, cool. you need re-review or re-qa | 16:17 |
| gary_poster | ? | 16:17 |
| hatch | re-review probably isn't necessary but feel free to take a peek at the changes https://codereview.appspot.com/10241043 but I would like a fairly indepth qa if possible :) | 16:18 |
| gary_poster | heh | 16:18 |
| hatch | Haswell, 16GB ram, SSD mini pc :) http://www.engadget.com/2013/06/12/asus-vivopc-specs/ | 16:19 |
| rick_h | orangesquad hatch review help please? short/sweet in the end https://codereview.appspot.com/10246044/ | 16:20 |
| hatch | on it | 16:20 |
| hatch | done | 16:21 |
| rick_h | hatch: ty much sir | 16:22 |
| gary_poster | rick_h, hatch, code looks good. hatch did you do qa on rick's branch? if so will lgtm myself | 16:26 |
| hatch | gary_poster: not yet, | 16:26 |
| gary_poster | k | 16:26 |
| hatch | was just about to pull it down | 16:26 |
| gary_poster | thanks | 16:26 |
| gary_poster | hatch, looks like the panel config scroll is broken again. also fixed in rick's branch? | 16:27 |
| rick_h | gary_poster: no, actually now that I look on a charm with enough config that's not fixed here | 16:27 |
| gary_poster | darn | 16:28 |
| gary_poster | can do it separately | 16:28 |
| gary_poster | but needs to be done urgently also | 16:28 |
| hatch | huw's changes make the ui look awesome - a little...chrome heavy imho but awesome :) | 16:28 |
| rick_h | is that something we broke or is that bootstrap related? | 16:28 |
| gary_poster | hatch, rick_h one of you look at that? | 16:28 |
| gary_poster | rick_h, not you I don't think | 16:28 |
| gary_poster | hatch agreed | 16:29 |
| rick_h | gary_poster: ah ok. I'm going to look at the logout issue that's us. If hatch can follow up on the config panel that'd be great | 16:29 |
| gary_poster | on awesome and a bit chrome heavy | 16:29 |
| gary_poster | rick_h, +1 thx | 16:29 |
| hatch | gary_poster: I have that fixed in one of my proto branches, so I can dig that fix up in a followup | 16:29 |
| gary_poster | yay! | 16:29 |
| gary_poster | thanks | 16:29 |
| hatch | gary_poster: just qa'd ricks branch and it shows all of the config properties now | 16:29 |
| gary_poster | yay! | 16:29 |
| hatch | will just test to make sure it saves them | 16:29 |
| hatch | heh | 16:29 |
| rick_h | hatch: heh, I just have to get your a model, not save it :P | 16:30 |
| hatch | the ;tooltips cover the inputs :/ | 16:30 |
| hatch | oh nm | 16:30 |
| hatch | screwup with my browser plugins | 16:30 |
| rick_h | hatch: ok yea I'm not seeing that | 16:30 |
| gary_poster | hatch your branch is looking great so far--that change even fixed the jumpy bit | 16:30 |
| hatch | rick_h: +1 on a QA, gtg :) | 16:31 |
| hatch | gary_poster: yeah it's pretty awesome :) | 16:31 |
| rick_h | hatch: gary_poster ty much for the reviews. Will hop into the logout next and see if I can't clean up our last little bits of trouble | 16:31 |
| gary_poster | great! | 16:32 |
| gary_poster | hatch, found another weird issue with logout but not related to your changes | 16:32 |
| gary_poster | and not as urgent | 16:32 |
| gary_poster | at least with sandbox if you create services, log out, and log in | 16:32 |
| gary_poster | then services don't show | 16:33 |
| gary_poster | but exist (you can't add services with same name) | 16:33 |
| hatch | oh yeah I thought ben and I fixed that | 16:33 |
| hatch | in fact, I know we did | 16:33 |
| hatch | *regression* | 16:33 |
| gary_poster | hatch, not your problem, so can make a card, but if you have another fix in your bag of tricks then yay | 16:33 |
| gary_poster | hatch your branch LGTM in qa and code | 16:34 |
| hatch | eggcelent | 16:34 |
| teknico | rick_h: I'm working on the card "loadFixture should be able to exclude/ignore hashes when it generates urls" | 16:34 |
| teknico | rick_h: I can't reproduce the problem, do you know how to make it show up? | 16:35 |
| rick_h | teknico: move the test_service_view.js and test_service_config_view in test/index.html back up into the middle of the test suite | 16:35 |
| rick_h | teknico: I moved them to the very end to work around the issue for the moment | 16:35 |
| rick_h | teknico: if you still can't dupe let me know and we can hangout and I can shot you what's going on exactly | 16:36 |
| teknico | rick_h: thanks, I'll better dupe it by myself, I don't want to be shot ;-) | 16:36 |
| rick_h | teknico: the actual error ends up showing up as something about invalid chars or something because it's trying to json parse something it can't. | 16:36 |
| rick_h | bah, /shot/show | 16:37 |
| teknico | of course :-) | 16:37 |
| hatch | damnit rick_h you submitted at the same time I did and now I have to restart lol | 16:39 |
| rick_h | bwuhahaha my computer is faster :-P | 16:40 |
| hatch | lol | 16:40 |
| hatch | I'm just glad that it was smart enough to reject the merge instead of just forcing it haha | 16:41 |
| hatch | that would have been a mess | 16:42 |
| rick_h | how much conflict could there have been? | 16:42 |
| hatch | well it would have just been missing code without any reasoning as to why | 16:42 |
| hatch | I worked on a project that used some custom svn workflow that you would have to notify everyone you were committing so you didn't do that | 16:43 |
| teknico | rick_h: weird, if I place those two tests right before test_model_controller.js, then I have an error in the latter | 16:43 |
| hatch | that was irritating | 16:43 |
| teknico | rick_h: where were they placed exactly? | 16:44 |
| rick_h | teknico: hmm, don't recall where they were. I think just alphabetically | 16:44 |
| gary_poster | jcsackett, gave you second LGTM on showIcon, with trivial/ignorable suggestion | 16:44 |
| rick_h | teknico: https://code.launchpad.net/~rharding/juju-gui/trailing-slash-1189973/+merge/168803 | 16:45 |
| teknico | rick_h: right | 16:45 |
| hatch | ugh mosquito bite on my foot....the worst! | 16:47 |
| hatch | alllright merged | 16:48 |
| teknico | rick_h: ok, got it, thanks | 16:48 |
| rick_h | teknico: yay! ...well not really | 16:49 |
| teknico | :-) | 16:49 |
| hatch | gary_poster: so huw's branch looks great, but the UX for the right panel does not match at all heh | 16:55 |
| hatch | gary_poster: oh, and when I add services/log out/in on sandbox, the services stay there on the (new) trunk | 16:56 |
| benji | I expect you're on a call, gary_poster. If so, say nothing for 60 seconds. GO! | 17:13 |
| gary_poster | benji boo | 17:14 |
| benji | heh | 17:14 |
| benji | gary_poster: so, either this card was very easy or I misunderstood; guichat? | 17:14 |
| gary_poster | hatch: (A) I know. if you want to try a quick CSS to the old inspector you are welcome, but otherwise oh well, it's incremental, and I think we can have the new inspector no later than end of next week | 17:15 |
| gary_poster | (B) great! | 17:16 |
| gary_poster | dunno what I saw then | 17:16 |
| gary_poster | benji, ok joining | 17:16 |
| benji | hatch: hi, I'm trying to recall/understand the motivation behind the "Propose download-cache style solution for our node files using existing machinery" card we created during last Friday's meeting. | 17:23 |
| benji | hatch: I think you were one of the progenitors of it so I wanted to check with you about what problem(s) you were hoping would be addressed. | 17:23 |
| hatch | benji: well there are two things 1) npm can and does go down causing work on new branches to stop and 2) making 100 http requests takes a lot longer than if we could just cache/extract a single file | 17:25 |
| benji | hatch: will you try something for me? apply this diff http://paste.ubuntu.com/5762093/ and do a "make clean-all" and then a "make" and you should get no HTTP requests | 17:26 |
| gary_poster | hatch, the jenkins failure is real and reasonable: the tests use the old load panel | 17:26 |
| rick_h | benji: that originally started with me there. | 17:27 |
| gary_poster | if this were tarmac, your branch would have been kicked out. :-P so...looking at that for a sec... | 17:27 |
| benji | rick_h: maybe you will test it out for me too then :) | 17:27 |
| rick_h | benji: yep, peeking at the diff as well :) | 17:28 |
| benji | don't blink or you'll miss it | 17:28 |
| rick_h | yea, I see that | 17:28 |
| hatch | gary_poster: ok so that's a python test failure? Sorry I didn't even think of looking in the selenium tests | 17:31 |
| gary_poster | hatch no apologies needed. we are supposed to have tarmac for this | 17:31 |
| gary_poster | hatch, yeah, so we need to rewrite that deploy function. are you up for that, or would you prefer to call "Python!" and I'll ask benji to switch and/or pair with you? | 17:33 |
| hatch | this is deploy on 109 of test_charm_running.py? | 17:34 |
| hatch | ahh yes this needs to point to the charmbrowser now | 17:35 |
| gary_poster | 112 for me but yes (me does another pull) | 17:35 |
| gary_poster | still 112 for me <shrug> :-) | 17:35 |
| hatch | I 'think' I can do this | 17:35 |
| gary_poster | :-) cool | 17:35 |
| hatch | is ther a way I can test it locally? | 17:35 |
| gary_poster | if you change your mind call for help | 17:35 |
| gary_poster | yes | 17:35 |
| gary_poster | hatch, open your hymnal to docs/continuous-integration.rst and read with me...as I try to remember the details. | 17:36 |
| rick_h | lol, read that as "open your hy-yaml" and went wtf? | 17:37 |
| gary_poster | lol | 17:37 |
| hatch | I don't even know what a hymnal is | 17:37 |
| hatch | to google! | 17:37 |
| hatch | ohh | 17:37 |
| * rick_h is rolling on the floor | 17:37 | |
| hatch | hym-nal | 17:38 |
| hatch | now I get it | 17:38 |
| hatch | :) | 17:38 |
| gary_poster | lol | 17:38 |
| gary_poster | ...so anyway... | 17:38 |
| hatch | haha | 17:38 |
| hatch | doesn't look like the CI docs contain instructions on running selenium locally | 17:38 |
| gary_poster | hatch, look for the section that begins here | 17:38 |
| gary_poster | Combining NO_DESTROY and APP_URL could help while debugging CI tests, and it | 17:38 |
| gary_poster | allows for running the suite multiple times using the same Juju environment. | 17:38 |
| gary_poster | A typical workflow follows:: | 17:38 |
| hatch | ohh yeah that part | 17:39 |
| hatch | but I still need EC2 for that | 17:39 |
| gary_poster | mm | 17:39 |
| hatch | I know about doing THAT much ;) | 17:39 |
| hatch | I assumed frankban didn't hammer on EC2 when fixing things and ran it locally somehow | 17:40 |
| gary_poster | well, one other thing to check, one sec | 17:40 |
| hatch | I could have been assuming incorrectly | 17:40 |
| gary_poster | hatch, yeah ec2. fwiw, http://irclogs.ubuntu.com/2013/06/11/%23juju-gui.html and look for "I suggest configuring the juju-gui-testing env with the ec2 provider" | 17:42 |
| hatch | yup already have that setup | 17:43 |
| hatch | ok to ec2 it is! | 17:43 |
| gary_poster | k | 17:43 |
| gary_poster | :-) | 17:43 |
| hatch | sorry for the confusion | 17:44 |
| gary_poster | I'm sorry for the confusion about the confusion. Can we have a third? | 17:44 |
| hatch | haha | 17:44 |
| hatch | def deploy(self, charm_name): is `self` a special param? all calls are simply self.deploy('appflower') which is the charm_name | 17:48 |
| benji | hatch: yep, the object itself is added as the first argument in any method calls | 17:49 |
| gary_poster | hatch, self == js this. in python it is exlicit | 17:49 |
| gary_poster | you could call in kumquat too. not advised. | 17:49 |
| hatch | not sure if typo was 'elicit' or 'explicit' ;) | 17:49 |
| gary_poster | explicit :-) | 17:50 |
| hatch | got it thanks | 17:50 |
| gary_poster | hatch, have trivial css suggestion for right hand side. will pastebin in a sec | 17:50 |
| hatch | already done | 17:50 |
| gary_poster | re huw's branch | 17:50 |
| gary_poster | hatch ok cool nm then :-) | 17:50 |
| hatch | haha well I 'll see yours too | 17:51 |
| gary_poster | heh, ok | 17:51 |
| hatch | I will have a feeling our changes will be similar :) | 17:51 |
| * gary_poster agrees | 17:51 | |
| * hatch not sure if like python or think stupid | 17:52 | |
| hatch | it's actually pretty easy to read :) | 17:53 |
| gary_poster | heh | 17:53 |
| gary_poster | @charm-panel-configure-color: #404040; | 17:53 |
| gary_poster | @charm-panel-configure-title-color: #FFFFFF; | 17:53 |
| gary_poster | @charm-panel-configure-name-color: #FFFFFF; | 17:54 |
| gary_poster | hatch ^^ | 17:54 |
| hatch | oo we actually did it differently! | 17:55 |
| gary_poster | lol | 17:55 |
| gary_poster | choose whichever you prefer hatch | 17:55 |
| hatch | yeah I'll throw these in after I finish this ci error | 17:56 |
| hatch | probably end up combining | 17:56 |
| gary_poster | k | 17:56 |
| hatch | I use indentation to make prototyping code stand out....that technique does NOT work in python | 17:57 |
| hatch | heh | 17:57 |
| rick_h | hatch: lol, use comments | 17:57 |
| rick_h | """ PROTOTYPE HERE """ and make that a macro :P | 17:57 |
| hatch | and 'remove all semicolons on save' | 17:58 |
| hatch | lol!! | 17:58 |
| rick_h | yea, that one gets me all the time these days | 17:58 |
| rick_h | orangesquad and hatch review request please? Small one to fix the last bug before I can get back to working on related charms! https://codereview.appspot.com/10253049 | 18:01 |
| rick_h | stop finding bugs now :P | 18:01 |
| * sinzui looks | 18:02 | |
| hatch | on it | 18:02 |
| sinzui | rick_h, you have my LGTM | 18:05 |
| rick_h | sinzui: ty much | 18:06 |
| * benji takes a late lunch while screaming "it's here! it's here!" | 18:07 | |
| hatch | haha | 18:08 |
| hatch | rick_h: donezos | 18:08 |
| gary_poster | lol | 18:08 |
| * rick_h wonders if benji's internet is about to get yanked out of the wall | 18:08 | |
| hatch | then tommorow he says "sorry I coudln't work, no internet" | 18:08 |
| hatch | any pythonites want to look at this before I fire up EC2? https://gist.github.com/hatched/f2f5ba90519d126c8328 | 18:13 |
| hatch | just want to make sure it's syntax is correct | 18:14 |
| * gary_poster looks | 18:14 | |
| gary_poster | hatch, charm_panel_loaded is called repeatedly. is the click there really what you want? | 18:15 |
| hatch | oh that's what the wait_for does | 18:15 |
| gary_poster | I think you want to click outside of that function, and then wait for (whatever it is) to show up | 18:15 |
| hatch | then no | 18:15 |
| hatch | yes | 18:15 |
| hatch | thanks | 18:15 |
| gary_poster | sure | 18:15 |
| gary_poster | silly Python niggle: only one space after return on line 10 | 18:16 |
| gary_poster | hatch, you may need two wait_fors | 18:17 |
| gary_poster | one waits for the charm_token | 18:17 |
| gary_poster | then you click | 18:17 |
| hatch | yeah rewriting that method now | 18:17 |
| gary_poster | then the other wait_fors the add_button, and you click | 18:17 |
| gary_poster | iok | 18:17 |
| gary_poster | ok | 18:17 |
| gary_poster | hatch line 19, charm_panel is not defined | 18:18 |
| gary_poster | may want to wait_for that too, dunno | 18:18 |
| gary_poster | hatch otherwise looks good | 18:19 |
| hatch | aww darn the wait_for function doesn't look like it'll accept extra params | 18:20 |
| gary_poster | doesn't need to | 18:20 |
| hatch | sok I'll just make extra methods | 18:20 |
| gary_poster | if you are defining functions as you go then you are writing closures | 18:20 |
| gary_poster | so previous vars are available | 18:21 |
| hatch | gary_poster: updated gist https://gist.github.com/hatched/f2f5ba90519d126c8328 | 18:28 |
| * gary_poster looks | 18:28 | |
| gary_poster | hatch, trivial but lines 19, 23 and 27 should ideally be < 80 chars. I suggest a newline after the open paren. Otherwise good | 18:31 |
| hatch | oh yeah woops, I just did that to make it easier to follow for my needing curly bracket js eyes :) | 18:32 |
| hatch | ok running, see how this goes | 18:33 |
| hatch | is it meta to be writing python in sublime ....that's written in python | 18:33 |
| gary_poster | if it is, it's old hat meta. :-) lisp in emacs has us beat by decades | 18:34 |
| hatch | haha | 18:34 |
| hatch | the new macbook air gets 12:51 battery life....wow!! http://www.engadget.com/2013/06/13/macbook-air-review | 19:15 |
| benji | hatch: did you have a chance to try that diff? | 19:19 |
| hatch | sorry I haven't | 19:19 |
| hatch | won't that only help with make clean-all ? | 19:20 |
| hatch | so won't keep the cache cross branches | 19:21 |
| benji | hatch: npm keeps a cache in ~/.npm. That cache is always used, the new setting just says not to try to see if there is a newer version of the cached file available | 19:27 |
| benji | so we save time by not making lots of (not very wise) HTTP requests but we don't save any time installing packages (each new branch will have to install them) | 19:27 |
| hatch | ahhhh ok, then in that case I have always missunderstood that cache | 19:28 |
| hatch | hah woops | 19:28 |
| * hatch fail | 19:28 | |
| hatch | ok trying that diff | 19:29 |
| hatch | benji: muuuuuch better | 19:30 |
| hatch | wish people would update their pacakges for the new npm though | 19:30 |
| hatch | benji: we should also include with that a way to update the cache | 19:31 |
| benji | hatch: "npm cache clean" will kill them all | 19:32 |
| benji | or you could just run "npm install" if you wanted to check to see if a new version of a file is available | 19:32 |
| benji | but really, that should never happen; uploading a new archive for version X of a library is evil | 19:33 |
| hatch | yeah true true | 19:33 |
| hatch | well while my new ci tests run I'm going to grab some lunch | 19:33 |
| * benji plays while he waits. | 19:35 | |
| hatch | hmm I can't seem to get the tests to pass | 20:18 |
| hatch | all of the selenium tests fail with an error BadStatusLine: '' | 20:18 |
| hatch | has anyone seen that before? | 20:19 |
| hatch | all selenium tests fail with that error | 20:23 |
| hatch | but I can't see how my changes caused it | 20:23 |
| gary_poster | BadStatusLine IME is usually indicative of insanity around you hatch, yeah. It blame it on canonistack I think. THis is on ec2, though? | 20:28 |
| hatch | yeah EC2 | 20:29 |
| hatch | should I not be able to run the selenium tests by running test_charm_running.py from the source dir on the charm? | 20:34 |
| hatch | it's saying selenium doesn't exist | 20:34 |
| hatch | I suppose that makes sense | 20:37 |
| hatch | will fire off another run maybe that was a glitch | 20:37 |
| gary_poster | hatch, if you are waiting on something or other, +1 on releasing frustration by just getting Huw's branch out there for reviews :-P I can also try to dupe what you are doing if you like, though I need to go soon | 20:42 |
| hatch | ahh yes I can do that | 20:43 |
| hatch | yeah no point in wasting your time. If I get that error again I will need some help however | 20:43 |
| hatch | so will wait and see | 20:43 |
| gary_poster | ok understood | 20:43 |
| gary_poster | hazmat, hi. you around? if so, could you give me privs in charmworld so I can do blueprint work there, please? | 20:53 |
| hatch | man ec2 feels slower than it used to be | 20:54 |
| benji | hmm: "Failed to start mocha: Init timeout" | 21:00 |
| hatch | yeahok the TestAuthentication tests are failing on my branch | 21:01 |
| hatch | I must be doing something wrong, I don't see how they could fail from my changes | 21:02 |
| hatch | benji: ming taking a peek http://bazaar.launchpad.net/~hatch/juju-gui/remove-charmsearch/revision/728 | 21:02 |
| hatch | is there anything wrong with that ? | 21:02 |
| * benji becomes Ming the Merciless and looks. | 21:03 | |
| benji | hatch: the indentation goes wonky on line 126 | 21:04 |
| benji | oh, wait! it doesn't | 21:04 |
| benji | it's just functions being defined inside a method | 21:04 |
| hatch | I'm allowed to indent after the paren like that right? | 21:05 |
| hatch | 128, 132, 138 | 21:05 |
| benji | yep | 21:06 |
| benji | hatch: it looks good to me (other than the extra newline on line 124 :) one newline is enough inside a function | 21:06 |
| hatch | 124 isn't in a function | 21:07 |
| hatch | at least it's not supposed to be | 21:07 |
| hatch | does that mean that 127 is too? | 21:08 |
| hatch | 127 should be in deploy() | 21:08 |
| gary_poster | hatch, your whitespace is fine functionally. 124 is inside the deploy method, as is 127. one newline is enough inside a function or method. | 21:14 |
| gary_poster | so you can delete one of lines 124 and 125 | 21:15 |
| gary_poster | hatch, once things are working on ec2, and it sounds like they are now, you can change your tests and rerun them, at least, yeah? | 21:16 |
| hatch | ohh I see what you're saying | 21:16 |
| hatch | nope the TestAuthentication tests ERROR | 21:16 |
| gary_poster | but other tests pass right hatch? | 21:17 |
| hatch | the deploy tests fail with the badstatusline error | 21:17 |
| gary_poster | so you can do the trick to make things go faster from the doc | 21:17 |
| gary_poster | without restarting ec2 | 21:18 |
| hatch | the testauthentication tests fail by just sitting there for ....5min each? | 21:27 |
| hatch | I'm going to guess that it's the same error that gets involved with the process_path() method | 21:28 |
| hatch | ARG now I can't propose the huw branch + changes because of the stupid json error in phantom | 21:29 |
| hatch | there is little more frustrating than build tool failures impeding productivity | 21:31 |
| gary_poster | what is the json error in phantom hatch? | 21:58 |
| hatch | TypeError: JSON.stringify cannot serialize cyclic structures. | 21:59 |
| gary_poster | huh, have not seen | 21:59 |
| hatch | and the branch which broke it...has nothing to do with json | 21:59 |
| hatch | s/branch/commit | 21:59 |
| hatch | FINALLY found the cause | 22:02 |
| hatch | Victory! | 22:02 |
| gary_poster | yay! | 22:03 |
| hatch | ok now to blog this... | 22:03 |
| gary_poster | that's for the phantom thing? | 22:03 |
| hatch | if you see (above error) look for console logs of complex objects | 22:03 |
| hatch | or instances | 22:03 |
| gary_poster | I think we ought to land Huw's branch immediately. I'll give it the fastest LGTM ever, and you already blessed it. | 22:03 |
| gary_poster | I mean, assuming you killed the wabbit. :-) | 22:04 |
| hatch | that thing is dead | 22:04 |
| gary_poster | yay :-) | 22:04 |
| hatch | it's proposing now *crosses fingers* | 22:04 |
| hatch | oh I fixed the height issue too | 22:04 |
| gary_poster | great! | 22:04 |
| hatch | but it's kind of a kludge | 22:05 |
| hatch | I didn't fix the cause, just put a bandaid on it | 22:05 |
| hatch | :) | 22:05 |
| gary_poster | heh | 22:05 |
| gary_poster | ok | 22:05 |
| hatch | oh and I ended up using your css changes plus mine :) | 22:05 |
| gary_poster | if you want to give me the branch with the CI issue, I can try to look at it | 22:08 |
| gary_poster | maybe | 22:08 |
| gary_poster | or I can at least pass it to Nicola for him to look at in the morning | 22:08 |
| gary_poster | :-) | 22:08 |
| gary_poster | heh ok cool hatch | 22:08 |
| hatch | https://code.launchpad.net/~hatch/juju-gui/remove-charmsearch | 22:08 |
| gary_poster | on it | 22:09 |
| gary_poster | oh merged already lol | 22:09 |
| hatch | the original is merged | 22:09 |
| gary_poster | oh right | 22:09 |
| hatch | not the selenium changes | 22:09 |
| hatch | huw's branch plus my changes https://codereview.appspot.com/10241046 | 22:10 |
| gary_poster | I will qa :-) then approve | 22:11 |
| hatch | great - let me know what you think of the right panel styles | 22:11 |
| gary_poster | hatch you included your incremental work on the test_charm_running. conflicts. not sure what you want to do. Probably not making it worse? :-) | 22:14 |
| hatch | where? | 22:14 |
| gary_poster | oh, um. good question. how did I get this? not in your MP.... | 22:15 |
| gary_poster | oh nm. I merged the wrong branch. On irc you said remove-charmsearch but you meant header-design | 22:16 |
| hatch | umm sorry remove-charmsearch has the CI work | 22:17 |
| hatch | header-design has the header and right panel styles | 22:18 |
| gary_poster | hey huwshimi! thanks for changes. hatch had a crazy day trying to get everything to land (sorry hatch) but it is about to land :-) | 22:18 |
| huwshimi | gary_poster: Great! | 22:19 |
| huwshimi | hatch: Hope I didn't cause you too much trouble | 22:19 |
| gary_poster | hatch, LGTM | 22:19 |
| hatch | I wish it was you so I could blame someone ;) | 22:19 |
| gary_poster | good changes hatch | 22:19 |
| hatch | gary_poster: thanks | 22:19 |
| huwshimi | hatch: :) | 22:19 |
| hatch | gary_poster: I have....finally...created a wordpress account :) | 22:21 |
| gary_poster | hatch, lol | 22:21 |
| hatch | gary_poster: so is it ok that I land this branch? Considering I kind of reviewed it too? | 22:22 |
| gary_poster | hatch, yes :-) | 22:23 |
| hatch | she's goin! | 22:23 |
| hatch | huwshimi: i'll ping when this is all submitted for you to pull | 22:23 |
| huwshimi | hatch: Cheers. | 22:23 |
| gary_poster | hatch, should I send an email to Nicola asking him to look at the CI issue, or do you want to give it a bit more of a try and then send him the email when/if you stop? | 22:28 |
| hatch | I'd like to keep at it but I don't think I'll get anywhere | 22:29 |
| gary_poster | ack | 22:29 |
| hatch | I'm pretty much at an impass with my limited python knoweldge | 22:29 |
| gary_poster | will send email | 22:29 |
| gary_poster | np | 22:29 |
| gary_poster | thank you@! | 22:29 |
| hatch | I hope at least my deploy method points him in the right direction :) | 22:29 |
| hatch | huwshimi: she is ready to go | 22:30 |
| huwshimi | hatch: Great, thanks! | 22:30 |
| gary_poster | thanks hatch, huwshimi. g'night | 22:35 |
| hatch | night | 22:35 |
| hatch | o | 22:35 |
| huwshimi | gary_poster: Thanks, talk to you next week | 22:35 |
| hatch | oh yeah, it's tomorrow there | 22:35 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!