| === chriadam|away is now known as chriadam | ||
| dholbach | good morning | 06:09 |
|---|---|---|
| gusch | renato_: still here? | 06:19 |
| dpm | morning oSoMoN. I'm looking at this translatable string in the web browser app: "Open pages %1". Even after reading the translator comment, I'm not sure what it means, could you explain when you've got a minute? | 07:49 |
| oSoMoN | dpm: yeah, I guess it should be "Open pages: %1", or "%1 open pages", it’s not final anyway, there’s a design review happening today and that will probably change | 07:51 |
| dpm | ok, thanks oSoMoN | 07:51 |
| oSoMoN | dpm: I based the original implementation on rough mockups, there was no final visual design at the time… | 07:51 |
| oSoMoN | dpm: I’ll be reviewing your MRs shortly, btw | 07:51 |
| dpm | oSoMoN, no worries, that makes it clear | 07:51 |
| dpm | ah, cool, thanks! | 07:51 |
| === chriadam is now known as chriadam|away | ||
| oSoMoN | gusch: hey, I’ve got a trivial MR up for review, for when you have a spare moment: https://code.launchpad.net/~osomon/webbrowser-app/fix-uastring-regression/+merge/169133 | 08:40 |
| gusch | oSoMoN: ok | 08:43 |
| gusch | oSoMoN: I might have one in a few minutes as well (this time really a small one ;) | 08:43 |
| oSoMoN | gusch: sure, just ping me when you have it ready | 08:45 |
| gusch | oSoMoN: I like it, when it is more explicit, but why didn't it work (anymore)? | 08:51 |
| gusch | oSoMoN: and here is mine btw https://code.launchpad.net/~schwann/gallery-app/gallery-thumbnail-update/+merge/169135 | 08:52 |
| oSoMoN | gusch: tbh I don’t really know, or rather, I don’t really know how it worked before… | 09:00 |
| gusch | oSoMoN: anyway - I'll aprove it (without testing -ok?) | 09:00 |
| oSoMoN | gusch: yup :) | 09:03 |
| oSoMoN | dpm: got a couple of comments on https://code.launchpad.net/~dpm/ubuntu-calendar-app/rename/+merge/168982, otherwise looks good to me | 09:13 |
| dpm | oSoMoN, looking, thanks! | 09:35 |
| AskUbuntu | Changing text on a popover | http://askubuntu.com/q/307661 | 10:03 |
| popey | welcome penk ☻ | 10:09 |
| penk | hello | 10:09 |
| popey | the ratio of "People in Finland" to "People not in Finland" just went up a bit more | 10:10 |
| penk | most of my colleagues here in Helsinki are going to have summer vacation in a week or two though | 10:11 |
| gusch | oSoMoN: yes - unit tests would be nice. But with all those dependencies, it's hard to write some (I slowly start to introduce some first tests) | 10:45 |
| oSoMoN | gusch: yep, which is why I’m not requesting them now, but it would be good to keep those on the radar | 10:48 |
| gusch | oSoMoN: as said - slowly trying to increase (and makeing it easier by reducing dependencies ;) | 10:50 |
| gusch | oSoMoN: but thx | 10:50 |
| nerochiaro | om26er: hi, i need a bit of help when you have some time. there's this branch lp:~amanzi-team/ubuntu-ui-extras/ubuntu-ui-extras-initial that i'm really behind on, that has unit tests and autopilot tests failing for various reasons. it would be quite nice to get any help you can provide on it | 10:52 |
| AskUbuntu | How to retract and develop a ListItem.Standard | http://askubuntu.com/q/307680 | 10:53 |
| om26er | nerochiaro, looking | 10:57 |
| nerochiaro | om26er: i will be back later, thanks for starting to have a look | 11:06 |
| === MacSlow is now known as MacSlow|lunch | ||
| Laney | gusch: So ... picking up from yesterday. If you can show me how to replace the ListModel in http://paste.ubuntu.com/5761199/ with an AlbumCollectionModel then I'll probably be able to take it from there (at least for a bit ...) | 11:52 |
| gusch | Laney: is this inside of gallery, or your own project? | 11:55 |
| Laney | gusch: external | 11:55 |
| gusch | Laney: no chance then - sorry | 11:55 |
| Laney | In the end it's going to be for this: https://wiki.ubuntu.com/Appearance#Phone | 11:55 |
| Laney | oh. That's what I was trying to get at yesterday | 11:55 |
| Laney | can these things be exposed? | 11:55 |
| gusch | Laney: ok - let me see | 11:55 |
| gusch | Laney: so in the end it's about picking an image, right? | 11:57 |
| Laney | right | 11:58 |
| Laney | the spec there talks about interactions with the gallery | 11:59 |
| gusch | Laney: that is something, that we are working on - picking a photo from gallery | 12:00 |
| gusch | Laney: current plan is, that you will get an API, to call something like "getMeAPhotoFromGallery()" | 12:01 |
| Laney | gusch: oh, hmm | 12:01 |
| Laney | gusch: see the second mockup there - will it enable something like that to be written? | 12:01 |
| gusch | Laney: and this will bring up the UI, and after you selected a photo, the UI will close, and you get the filename | 12:01 |
| Laney | or will the last three entries have to be "Gallery images" or something? | 12:02 |
| Laney | mpt: ^^^ we're discussing one of your designs (the appearance panel in system settings) | 12:02 |
| gusch | Laney: I don't know about the exact UI atm. - but it will rather look like the gallery (as gallery will start, and be on top of your app) | 12:03 |
| Laney | so no API to get at the gallery's data directly | 12:03 |
| Laney | is there something I can subscribe to? | 12:03 |
| Laney | bug or BP | 12:03 |
| gusch | Laney: currently it's more like ideas floating around - but let me see | 12:04 |
| mpt | Laney, I drew that only because I couldn't find a design for the "content picker" yet. It is a slight superset of the image mode of the content picker, in that it lets you choose from shipped art as well as from your own photos. | 12:04 |
| Laney | mpt: right, so it sounds like for this we instead will just ask the gallery to do it for us | 12:05 |
| Laney | I don't know anything about the Ubuntu Art stuff though | 12:05 |
| Laney | is that just going to be some well-known directory that we list? | 12:05 |
| gusch | Laney: just ignore that mockup - that most likely will be my part to implement ;) | 12:05 |
| Laney | right | 12:05 |
| Laney | I'll just have a stub for now | 12:05 |
| Kaleo | Laney: mpt: gusch: the design of the content picker is not being worked on at the moment, so we are working from older specs | 12:05 |
| mpt | \o/ | 12:05 |
| Kaleo | Laney: mpt: gusch: nonetheless the API has been defined on paper | 12:05 |
| Laney | interesting | 12:05 |
| Kaleo | Laney: mpt: gusch: and we will have a prototype in a few weeks | 12:06 |
| Laney | so tell me which part I am interested in from the perspective of someone implementing the settings panel :P | 12:06 |
| Laney | like what does the content picker do for me? | 12:06 |
| gusch | Kaleo: guess who's doing the gallery part ;) | 12:06 |
| Kaleo | gusch: I know :) | 12:06 |
| Kaleo | Laney: well, it let's you import pictures from the gallery, ie. copy them into the folder of the settings app | 12:07 |
| gusch | Laney: you call an API function (pickAPhoto() - I don't know the name) | 12:07 |
| gusch | Laney: then gallery kicks in | 12:07 |
| Laney | OK, so it's just the gallery part? | 12:08 |
| gusch | Laney: and you get the result (as filename I guess) | 12:08 |
| Laney | Not the stock artwork bit (or is that handled by the gallery too?) | 12:08 |
| Kaleo | Laney: API looks like | 12:08 |
| Kaleo | peer = ContentHub.defaultSourceForType(ContentType.Pictures) | 12:08 |
| Kaleo | transfer = ContentHub.import(ContentType.Pictures, peer) | 12:08 |
| Laney | aha! | 12:08 |
| Laney | so there could be a ContentType for the other stuff too | 12:08 |
| Kaleo | Laney: possibly, what's the other stuff? | 12:08 |
| gusch | Laney: all the UI, artwork etc. is done by gallery | 12:08 |
| Laney | https://wiki.ubuntu.com/Appearance?action=AttachFile&do=get&target=phone-background-chooser.png | 12:09 |
| Laney | so if I essentially don't really have to care about that screen, then yay | 12:09 |
| gusch | Laney: correct ;) | 12:09 |
| Laney | cool beans | 12:10 |
| Laney | thanks guys | 12:10 |
| gusch | Laney: happy hacking with the rest of that stuff ;) | 12:10 |
| Laney | this makes it rather more simple :P | 12:11 |
| Kaleo | Laney: don't forget to use the ui toolkit | 12:11 |
| Laney | Kaleo: Right, I am mostly - I did write a component to handle switching between images in an UbuntuShape though | 12:12 |
| Laney | mostly because of https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1189884 | 12:12 |
| ubot2` | Ubuntu bug 1189884 in Ubuntu UI Toolkit "[UbuntuShape] Images assigned by a variable don't get rounded corners" [Undecided,New] | 12:12 |
| Laney | the title is a bit more narrow than the bug actually is | 12:14 |
| Kaleo | Laney: switching images in an ubuntushape was something cimi asked about a while back | 12:14 |
| Kaleo | Laney: maybe he has some code | 12:15 |
| Laney | perhaps | 12:15 |
| Laney | I wanted to do crossfading too, which doesn't seem well supported in qml at all currently | 12:15 |
| * Laney goes to #-touch to ask | 12:16 | |
| Kaleo | Laney: crossfading works fine in QML | 12:16 |
| Laney | well, by transitioning the opacity out and in on two Images | 12:17 |
| Kaleo | Laney: sounds good | 12:17 |
| Kaleo | Laney: what was wrong with it? | 12:17 |
| Laney | just seems a bit of an awkward way to do it | 12:17 |
| Laney | rather set the source and have it done automatically | 12:17 |
| Kaleo | Laney: sure, that's why people tend to write CrossfadeImage components | 12:18 |
| Laney | and I don't know how that would interact with the UbuntuShape either because you set the opacity on the shape, not the image contained | 12:18 |
| Kaleo | Laney: which IIRC there is one in the shell | 12:18 |
| Kaleo | Laney: correct | 12:18 |
| Kaleo | Laney: there are 2 ways to tackle that | 12:18 |
| Laney | the thing I wrote crossfades between two UbuntuShapes | 12:18 |
| Kaleo | Laney: either 2 UbuntuShapes that you crossfade | 12:18 |
| Kaleo | Laney: or you write a CrossfadeImage component | 12:18 |
| Kaleo | Laney: that you stuff in the image property of the UbuntuShape | 12:19 |
| Kaleo | Laney: and of course there is a twist for that to work | 12:19 |
| Kaleo | Laney: since UbuntuShape.image only accepts Image and ShaderEffectSource | 12:19 |
| === MacSlow|lunch is now known as MacSlow | ||
| Kaleo | Laney: and CrossfadeImage is not an Image | 12:19 |
| Kaleo | Laney: so you can wrap the CrossfadeImage in a ShaderEffectSource | 12:19 |
| Laney | heh | 12:20 |
| Laney | http://askubuntu.com/questions/306868/how-do-i-get-an-ubuntushape-to-transition-fade-between-different-images BTW | 12:20 |
| Kaleo | Laney: IIRC that's the advice I gave to cimi | 12:20 |
| Laney | probably not the best qml that's ever been written | 12:20 |
| Kaleo | Laney: lp:unity/phablet Components/CrossFadeImage.qml | 12:21 |
| Laney | Kaleo: /me gets | 12:22 |
| Kaleo | Laney: there is unit tests too | 12:22 |
| Kaleo | Laney: and documentation | 12:22 |
| Laney | shouldn't (something like) this be in the ui toolkit? | 12:23 |
| Kaleo | Laney: if we find another user, +1 | 12:23 |
| Kaleo | Laney: let's imagine we found another user | 12:24 |
| Kaleo | Laney: +1 | 12:24 |
| Laney | well I'd use it from the panel | 12:24 |
| Kaleo | Laney: yyep | 12:24 |
| Kaleo | Laney: wanna do your first MR to the toolkit? :) | 12:24 |
| Laney | heh | 12:24 |
| Kaleo | Laney: copy/paste from the shell :) with sanity checks :) | 12:24 |
| Laney | If you think that looks like a decent interface for a reusable component then sure | 12:25 |
| Laney | I'd like to do one for that contained in an UbuntuShape per your earlier guidance too | 12:26 |
| Laney | will try to get to that, thanks Kaleo | 12:26 |
| Kaleo | Laney: actually it's not | 12:27 |
| Kaleo | Laney: the API is wrong :) | 12:27 |
| Kaleo | Laney: but easy to fix | 12:28 |
| Kaleo | Laney: property bool crossFade & property bool fadeInFirst are not used by anybody and should be removed (and default values should be false for both) | 12:28 |
| Kaleo | Laney: property url source should be documented | 12:28 |
| Kaleo | Laney: and properties starting with __ should be moved into a child QtObject | 12:29 |
| Kaleo | Laney: to make them really inaccessible | 12:29 |
| Kaleo | Laney: for the ShaderEffectSource, here is the documentation: http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-shadereffectsource.html | 12:29 |
| Laney | noted, ty | 12:30 |
| t1mp | zsombi: the next small step in the Action changes: https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/actionItem/+merge/169039 | 12:40 |
| t1mp | zsombi: where is ActionSelectionPopover.target used? | 13:06 |
| t1mp | I don't see a use-case. | 13:07 |
| kenvandine | welcome seb128! | 13:58 |
| seb128 | hey | 13:59 |
| seb128 | join I autojoin that one as well? ;-) | 13:59 |
| dpm | oSoMoN, nice work! :-) http://www.iloveubuntu.net/ubuntu-touchs-webbrowser-app-landed-ubuntu-1310-ubuntu-software-center | 14:00 |
| oSoMoN | dpm: cool, thanks for the link | 14:01 |
| dpm | seb128, yeah, I think you should join the party and mark this channel as autojoin ;) | 14:06 |
| seb128 | yeah | 14:06 |
| seb128 | let's see if that channel qualify, I will ask a question and see if I get an useful reply :p | 14:07 |
| seb128 | in system-settings we some | 14:08 |
| seb128 | ListItem.Standard { | 14:08 |
| seb128 | icon: Qt.resolvedUrl(model.icon) | 14:08 |
| seb128 | text: model.displayName | 14:08 |
| seb128 | } | 14:08 |
| seb128 | elements | 14:08 |
| seb128 | can I make the icon: a relative path? | 14:08 |
| seb128 | I would like to install it in the same dir as the qml | 14:08 |
| seb128 | when model.icon is just a name, it's looking in the theme directories | 14:09 |
| seb128 | e.g /usr/share/icons/{gnome,hicolor}/.... | 14:09 |
| seb128 | or it seems from a strace look | 14:09 |
| seb128 | (it's not respecting the theme in use btw, seems like a bug) | 14:09 |
| seb128 | if I use "./icon.png" it fails to find the icon | 14:09 |
| seb128 | if I use /usr/share/...../icon.png that works, but I would prefer hardcoding the /usr/share in there | 14:10 |
| dpm | seb128, this should work: Qt.resolvedUrl("img/text.png") | 14:13 |
| dpm | as in: | 14:13 |
| dpm | ListItems.Standard { | 14:13 |
| dpm | id: itemQrText | 14:13 |
| dpm | text: i18n.tr("Text") | 14:13 |
| dpm | icon: Qt.resolvedUrl("img/text.png") | 14:13 |
| dpm | onClicked: pageStack.push(pageQrText) | 14:13 |
| dpm | progression: true | 14:13 |
| dpm | } | 14:13 |
| dpm | That's a snippet I'm using on an app I'm developing | 14:14 |
| dpm | does that pass the seb128 channel autojoin test? | 14:14 |
| dpm | ;) | 14:14 |
| seb128 | dpm, not really, as said I tried " if I use "./icon.png" it fails to find the icon" | 14:15 |
| seb128 | dpm, but I think mardy might have added some magic there | 14:15 |
| dpm | hm, weird, it works for my app | 14:15 |
| seb128 | because the model.icon seems to be a gicon:path | 14:15 |
| seb128 | that's maybe a special object and not a plain url | 14:15 |
| dpm | aha, gotcha | 14:15 |
| seb128 | dpm, btw, do you have an example of po.pro that I can copy that does full work (build .mo and install them)? | 14:16 |
| seb128 | dpm, I copied the one from ubuntu-weather-app, that gives me a "make pot", but not the .mo part | 14:16 |
| dpm | seb128, I don't. I put the install part in debian/rules as suggested by pitti | 14:21 |
| seb128 | dpm, hum, why is that better? | 14:22 |
| dpm | seb128, I think the idea was that in the packaging qmake was not used anywhere else (the core apps are pure qml and js), so it'd be easier to write the install rule in debian/rules than hooking up qmake with the packaging | 14:23 |
| dpm | But if there is a better way, I'd be happy to change it | 14:23 |
| seb128 | dpm, system-settings has cpp code, it's not pure qml | 14:23 |
| kenvandine | and uses qmake | 14:24 |
| kenvandine | seb128, look at signon-ui | 14:24 |
| seb128 | kenvandine, thanks | 14:25 |
| dpm | seb128, right, I was just talking about the usage for core apps. For system-settings it makes sense to have all the rules in .pro files | 14:25 |
| seb128 | kenvandine, ah, signon-ui is what mardy copied for system-settings, that one does have a "make pot" or any way to generate a template | 14:25 |
| seb128 | kenvandine, QMAKE_EXTRA_TARGETS += potfile | 14:26 |
| seb128 | when I've that in a .pro | 14:26 |
| seb128 | where does the target ends up? | 14:26 |
| seb128 | should "make potfile" works? (it doesn't) | 14:26 |
| kenvandine | you mean where does it get installed? | 14:26 |
| kenvandine | i think it should work... but i've never really figured out how qmake handles it | 14:27 |
| * seb128 googles what QMAKE_EXTRA_TARGETS means | 14:27 | |
| kenvandine | well that adds a target to build | 14:27 |
| kenvandine | so potfile must be a standard qmake target | 14:27 |
| kenvandine | but not included in the build by default | 14:27 |
| seb128 | I see | 14:28 |
| kenvandine | ok, look at friends-app | 14:29 |
| kenvandine | that is probably a better example | 14:29 |
| seb128 | kenvandine, thanks | 14:29 |
| kenvandine | there is a po/po.pro | 14:29 |
| kenvandine | i don't recall where that came from... it might have been from dpm :) | 14:29 |
| seb128 | ok, I've a similar one | 14:30 |
| seb128 | I copied most of https://github.com/VictorThompson/ubuntu-music-app/blob/master/po/po.pro | 14:30 |
| seb128 | which I find with google :p | 14:30 |
| kenvandine | i am reasonably sure the one in friends-app does work | 14:30 |
| dpm | kenvandine, seb128. I think the initial po/po.pro came from the SDK guys, and then I modified it for the core apps. So I'd recommend using the one from the core apps, which supports internationalization of the .desktop file | 14:31 |
| dpm | actually, wait, the .desktop file support is still pending review on a mp | 14:32 |
| kenvandine | someone should add that to friends-app too :) | 14:32 |
| dpm | kenvandine, seb128, actually, it's been merged. So you can take the po.pro file from the weather app: http://bazaar.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/trunk/view/head:/po/po.pro | 14:33 |
| seb128 | dpm, that's what I started from, make pot works great | 14:33 |
| seb128 | but I want "make mo" and "make install" | 14:34 |
| seb128 | e.g something that actually build the .mo and install them | 14:34 |
| seb128 | dpm, the part you hacked in debian/rules for the weather app :p | 14:34 |
| seb128 | http://bazaar.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/trunk/view/head:/debian/rules | 14:34 |
| kenvandine | seb128, friends-app has a generate_mo.sh script | 14:35 |
| kenvandine | and it gets run by qmake | 14:35 |
| * kenvandine thinks qmake should have better integration than this... but oh well | 14:36 | |
| seb128 | yeah | 14:36 |
| seb128 | seems easier with cmake | 14:36 |
| seb128 | I looked at gallery, since I assumed that was the most polished app | 14:36 |
| kenvandine | maybe... but i find cmake more frustrating than any build system i've ever used | 14:36 |
| seb128 | they have a 10 lines CMakeLists.txt | 14:36 |
| dpm | seb128, I'll see if I can add build support in the po.pro file | 14:37 |
| seb128 | kenvandine, I hate all build systems :p | 14:37 |
| * kenvandine does too | 14:37 | |
| seb128 | dpm, I'm on it, I will bounce that to you for review | 14:37 |
| dpm | we're all in agreement, then | 14:37 |
| dpm | seb128, super | 14:37 |
| kenvandine | qmake is my 2nd favorite though... behind autotools | 14:37 |
| kenvandine | but yes, they all suck | 14:37 |
| kenvandine | seb128, while you're at it... why don't you add that desktop file translation stuff to friends-app :) | 14:38 |
| * kenvandine hides | 14:38 | |
| seb128 | kenvandine, rrrriiiight | 14:38 |
| nerochiaro | om26er: did that branch make any sense to you ? | 14:45 |
| om26er | nerochiaro, the problem is cmake no copying any file to the build-area only folders are being copied so import does not work | 14:46 |
| om26er | nerochiaro, I don't have much experience with cmake so we may need a bit help | 14:46 |
| nerochiaro | om26er: ok, maybe i can take care of poking someone more experienced with cmake, but i've seen elsewhere in other projects folders being installed, i think it's just a different command | 14:47 |
| nerochiaro | om26er: in the meantime, maybe you can have a look at the autopilot tests, these were more troublesome | 14:48 |
| om26er | nerochiaro, when I start the Browser.qml it gives me an error | 14:48 |
| om26er | nerochiaro, how do I run the Ui ? | 14:49 |
| nerochiaro | om26er: you don't, it's just a component | 14:50 |
| nerochiaro | om26er: there's a test file i put in the autopilot tests dir | 14:50 |
| nerochiaro | om26er: caller runner.qml | 14:50 |
| nerochiaro | om26er: that will instantiate the component | 14:51 |
| om26er | nerochiaro, is Ubuntu.Components.Extras normal ? | 14:52 |
| om26er | sorry, "Ubuntu.Components.Extras" is not installed | 14:52 |
| nerochiaro | om26er: you need to make sure when you run it you pass -I path_to_src (path_to_src is the path to the src directory in the source tree) | 14:56 |
| nerochiaro | om26er: that should allow it to run even uninstalled (which is what you do in some cases in the autopiot tests) | 14:56 |
| om26er | nerochiaro, I'll be back in two hours and then I'll look into the autopilot issue.. | 15:14 |
| nerochiaro | om26er: ok, thank you | 15:15 |
| gusch | renato_: ping | 15:24 |
| gusch | boiko: ping | 15:47 |
| oSoMoN | gusch: hey, would you be available for a review? | 15:55 |
| gusch | oSoMoN: sure | 15:55 |
| oSoMoN | gusch: https://code.launchpad.net/~osomon/webbrowser-app/remove-forward-button-on-narrow-screens/+merge/169240 | 15:56 |
| oSoMoN | thx | 15:56 |
| gusch | renato_ boiko ping | 15:56 |
| oSoMoN | dpm: have you seen my comments on https://code.launchpad.net/~dpm/ubuntu-calendar-app/rename/+merge/168982 ? | 15:58 |
| oSoMoN | penk: hey, any idea how to (painlessly) get a thumbnail off a given webview? afaik such a functionality is not exposed, maybe you have some experience with that? | 16:04 |
| penk | oSoMoN: back in WebKit1 API days I was using something like webview->page()->mainFrame()->render() | 16:06 |
| penk | oSoMoN: but I have never done that on WebKit2 API | 16:06 |
| oSoMoN | penk: ok, I’m gonna look into that, looking forward to having actual thumbnails instead of just empty placeholders | 16:07 |
| penk | oSoMoN: I recalled snowshoe has thumbnails in their TabsModel too, if you haven't look on that | 16:08 |
| oSoMoN | penk: they don’t, I just checked the code and it’s the same static hardcoded thumbnail for all the pages | 16:08 |
| penk | aha | 16:09 |
| boiko | gusch: pong | 16:09 |
| gusch | boiko: about a review - but tmoenicke is lookign into it (right?) https://code.launchpad.net/~schwann/gallery-app/gallery-video-playback/+merge/169237 | 16:10 |
| oSoMoN | penk: interestingly the "screenshots" on the front page of snowshoe.cc show thumbnails, but I suspect it’s just marketing | 16:10 |
| boiko | gusch: ok, in case he isn't ping me again :) | 16:11 |
| penk | oSoMoN: yeah maybe, and you can always fallback to javascript/canvas .. | 16:11 |
| penk | which has some existing libraries | 16:11 |
| gusch | boiko: I'd need renato_ for another review ... | 16:11 |
| gusch | renato_: would be cool if you could today continue reviewing https://code.launchpad.net/~schwann/gallery-app/gallery-show-video/+merge/168884 | 16:12 |
| oSoMoN | penk: interesting, I hadn’t though of that, do you reckon I could grab a capture of the page with a userscript, or were you suggesting something different? | 16:14 |
| penk | oSoMoN: yeah in userscript, something like http://html2canvas.hertzen.com/ might do the job | 16:14 |
| dpm | oSoMoN, sorry, I was in calls. I saw your comments, thanks for the thorough review. They make sense, I'll merge the two changelog entries into one, that was a mistake | 16:16 |
| oSoMoN | penk: cool, that looks very promising, I’ll experiment with that (sounds way more fun than writing a custom QML element that renders a webview into an image) | 16:17 |
| penk | indeed | 16:17 |
| oSoMoN | looks like it has a good number of limitations though | 16:20 |
| penk | oSoMoN: I'll just use QQuickWindow::grabWindow() and cut the chrome :P | 16:23 |
| penk | but I think thumbnail is too overrated | 16:24 |
| oSoMoN | penk: mmm, I don’t like the look of "Warning: Calling this function will cause performance problems." in grabWindow’s documentation… | 16:28 |
| gusch | oSoMoN: approved | 16:29 |
| oSoMoN | gusch: thanks | 16:29 |
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
