| StevenK | Right | 00:00 |
|---|---|---|
| StevenK | wgrant: But no matter the method name it's still status == WAITING ? | 00:01 |
| wgrant | StevenK: Yes | 00:07 |
| wgrant | It doesn't really make sense to run anything else :) | 00:07 |
| StevenK | wgrant: I've shifted canRun() to is_runnable | 00:42 |
| === tasdomas_afk is now known as tasdomas | ||
| wgrant | StevenK: Most useless attribute title ever. | 06:15 |
| wgrant | "Whether or not this job is ready to be run immediately", possibly. | 06:15 |
| wgrant | :) | 06:15 |
| wgrant | StevenK: https://code.launchpad.net/~wgrant/launchpad/sha256-model/+merge/169345 and http://pastebin.ubuntu.com/5763741/ | 06:18 |
| StevenK | sha256_digester = hashlib.sha256() and friends makes me sad, but you're contining the bad | 06:23 |
| wgrant | StevenK: What is sad about them? | 06:24 |
| wgrant | Besides the slight repetition for md5/sha1/sha256 | 06:24 |
| StevenK | It's repeated in a few places, makes me think it should perhaps be refactored into a helper method | 06:25 |
| StevenK | wgrant: But, r=me, and that script looks excellent. | 06:25 |
| StevenK | wgrant: jobrunner-012's diff has updated | 06:26 |
| === wedgwood_away is now known as wedgwood | ||
| === gmb`` is now known as gmb | ||
| === tasdomas is now known as tasdomas_afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!