| === marlinc is now known as marlinc|away | ||
| === marlinc|away is now known as marlinc | ||
| jppiiroinen | Kaleo_: that is still on my todo list | 06:40 |
|---|---|---|
| dpm | goog morning all | 06:43 |
| dholbach | good morning | 07:30 |
| penk | morning! | 07:32 |
| dpm | morning dholbach, morning penk | 07:37 |
| dholbach | hey dpm | 07:49 |
| dpm | hey :) | 07:53 |
| nerochiaro | om26er: good morning, any news on the tests for the browser component ? | 08:10 |
| om26er | nerochiaro, no, not much luck... didn't look at that much. I am looking at that now... Did you get a fix for the unittests ? | 08:11 |
| nerochiaro | om26er: i was away the past few days, didn't work on it | 08:12 |
| nerochiaro | om26er: but i'll look into the unit tests, and you keep looking into the autopilot | 08:12 |
| nerochiaro | om26er: does that sound good ? | 08:12 |
| om26er | nerochiaro, yes, sure. I started on that already :) | 08:13 |
| nerochiaro | om26er: thank you ! | 08:13 |
| dpm | oSoMoN, I've updated https://code.launchpad.net/~dpm/ubuntu-calendar-app/rename/+merge/169732 to address the points in your review. Could you have a look at it and re-review? :) | 08:14 |
| om26er | nerochiaro, you'r welcome | 08:14 |
| oSoMoN | dpm: sure, on it now | 08:18 |
| dpm | oSoMoN, perfect, thanks. On separating them, they've become quite easy to review I hope | 08:18 |
| oSoMoN | dpm: you’ll need to set a commit message for autolanding to work | 08:19 |
| dpm | argh, it didn't pick up the one from the earlier MP. Thanks, fixing it now | 08:19 |
| dpm | done, description updated as well | 08:21 |
| JamesTait | Good morning all, happy Eat Your Vegetables Day! :-D | 08:36 |
| timp | JamesTait: I *knew* it, I don't have to eat my vegetables *every* day :) | 08:40 |
| JamesTait | timp, mmmmmmaybeeeee.... ;) | 08:41 |
| oSoMoN | dpm: commented on https://code.launchpad.net/~dpm/ubuntu-calendar-app/package-translations/+merge/166029 with a suggestion | 08:46 |
| dpm | thanks! looking | 08:47 |
| om26er | nerochiaro, the problem is that the way we are starting the app, the startup parameter is not working... | 08:48 |
| nerochiaro | om26er: what do you mean ? what startup parameter ? | 08:48 |
| om26er | nerochiaro, the default weblink that we pass is not working... lets say we want to open the browser with 'google.com' in normal cases 'webbrowser-app google.com' will work but in this case its not | 08:49 |
| om26er | nerochiaro, 'qmlscene -I ../../src/ browser/emulators/runner.qml google.com' | 08:50 |
| om26er | that won't open google.com.. so in our autopilot tests we actually provide a default link | 08:51 |
| nerochiaro | om26er: ok, i think we should split the tests in two groups, one is the tests that test the component only, and the one is the test that test the entire application. i would remove the tests for the entire application (which will need to remain as part of webbrowser-app) | 08:51 |
| nerochiaro | om26er: this one you mentioned for example is a test for the entire app | 08:52 |
| om26er | nerochiaro, yeah, makes sense. I am trying to figure out what really needs to be tested with autopilot.. like which components should I write tests for ? | 08:55 |
| nerochiaro | om26er: only the browser component, and the tests are already there, we just need to remove the application-specific ones | 08:56 |
| om26er | nerochiaro, can we do a quick mumble for a few minutes ? | 09:01 |
| nerochiaro | om26er: yeah, let me grab my headphones | 09:01 |
| nerochiaro | om26er: just logged in | 09:03 |
| om26er | nerochiaro, yeah, I am there | 09:03 |
| nerochiaro | om26er: ok, let me try reconnecting | 09:04 |
| om26er | nerochiaro, let me reconnect as well | 09:05 |
| nerochiaro | om26er: no idea, i can hear you but my mic isn't working it seems | 09:06 |
| Laney | is saucy/grouper fixed-ish now? | 09:08 |
| Laney | oops, meant to send that to #ubuntu-touch :P | 09:08 |
| === gusch_ is now known as gusch | ||
| === penk_ is now known as penk | ||
| dpm | oSoMoN, I've added a comment on https://code.launchpad.net/~dpm/ubuntu-calendar-app/package-translations/+merge/166029https://code.launchpad.net/~dpm/ubuntu-calendar-app/package-translations/+merge/166029 if you could have a look when you've got a minute, that'd be great | 09:29 |
| oSoMoN | dpm: sure | 09:30 |
| === penk_ is now known as penk | ||
| dpm | great | 09:33 |
| === chriadam is now known as chriadam|away | ||
| dholbach | JamesTait, dpm, lool, mhall119, beuno: I think it'd make sense to start documenting a few things on the Ubuntu wiki - even if just briefly and in the form of a few bullet points - wiki.u.c/AppStore is unclaimed - shall we start using it or is there any other place you'd rather see decisions/docs/stuff go? | 10:11 |
| dholbach | I'd mail the list afterwards | 10:11 |
| JamesTait | dholbach, +1 from me, the more info we have in public resources the better. | 10:12 |
| dpm | dholbach, if app store is the name we'll be using, sounds good. We might want to put it under Touch/ but I think for now it's best to just get started. We can always set up a redirect if we decide to move it afterwards | 10:12 |
| dholbach | dpm, I thought about Touch/ first, but thought that the idea would be to use it more broadly in a converged world | 10:13 |
| dholbach | not entirely sure though | 10:13 |
| dholbach | but yeah +1 on getting started :) | 10:14 |
| dpm | dholbach, yeah, that sounds good to me. We can always move it later if we decide to | 10:14 |
| dholbach | rock and roll | 10:14 |
| JamesTait | dholbach, yeah, I'm also consciously avoiding references to Touch for that reason. | 10:14 |
| dholbach | I'll set it up and mail the list afterwards | 10:15 |
| JamesTait | Thanks dholbach. | 10:15 |
| oSoMoN | dpm: commented on https://code.launchpad.net/~dpm/ubuntu-calendar-app/package-translations/+merge/166029 | 10:21 |
| dholbach | JamesTait, dpm: https://wiki.ubuntu.com/AppStore (and /Decisions) | 10:26 |
| lool | dholbach: +1000 | 10:27 |
| dholbach | great - that's the +1002 I was looking for | 10:28 |
| lool | dholbach: I'd go for /Click at a nicer toplevel for now, but it's not worth bikeshedding | 10:28 |
| JamesTait | dholbach, :) | 10:28 |
| lool | I'm too late it seems | 10:28 |
| dholbach | and another +1000 if you guys help keeping it up to date ;-) | 10:28 |
| lool | (wasn't there some trademark dispute over the name "appstore"?) | 10:29 |
| dholbach | lool, yeah, that'd be a possibility too, I'm just not sure if we want to advertise "apps", "get apps into the store", "ubuntu app store" as "click" or anything like that | 10:29 |
| dholbach | lool, I'll mention it in my mail to the list | 10:29 |
| lool | cheers | 10:29 |
| dholbach | I'm happy for us to discuss it for a week and then count votes for whatever options come up ;-) | 10:29 |
| dpm | oSoMoN, thanks. I've now updated https://code.launchpad.net/~dpm/ubuntu-calendar-app/package-translations/+merge/166029 | 10:51 |
| oSoMoN | dpm: looks good now, btw is a changelog entry really necessary? | 10:55 |
| dpm | oSoMoN, I thought it was, as the packaging was changed. But I can remove it if necessary | 10:55 |
| oSoMoN | dpm: I don’t know, that’s a genuine question :) in the core apps developed in-house, we don’t add changelog entries anymore, not sure whether the same applies to community developed apps | 10:59 |
| dpm | oSoMoN, for the community apps we just set up a very basic packaging. I'm not sure it's that important until they get into the distro proper, so I think for now I'd choose the path of least effort and leave the changelog entry there other than remove it. If you're ok with that, can you approve and top-approve? | 11:00 |
| oSoMoN | dpm: sure, approving now | 11:03 |
| oSoMoN | gusch, nerochiaro: would one of you be available to review a trivial MR? https://code.launchpad.net/~osomon/webbrowser-app/addressbar-spacing-tweak/+merge/169477 | 11:05 |
| nerochiaro | oSoMoN: from the looks of it it seems it's trivial enough to just approve it as it is | 11:06 |
| oSoMoN | nerochiaro: indeed it is | 11:07 |
| nerochiaro | oSoMoN: i comment approved it | 11:07 |
| oSoMoN | nerochiaro: thx | 11:07 |
| nerochiaro | oSoMoN: do you have any idea in cmake how to copy a binary file into the unit tests directory after building but before running the tests ? I tried using the "install" command but it's run after the tests it seems. and i tried using the file command (with COPY option) but it's run before the build | 11:15 |
| oSoMoN | nerochiaro: no, no idea | 11:16 |
| === MacSlow is now known as MacSlow|lunch | ||
| nerochiaro | oSoMoN: know anyone who might know ? | 11:19 |
| oSoMoN | nerochiaro: try gusch, I don’t know if we have cmake experts around… | 11:19 |
| nerochiaro | gusch: any ideas on the above ? | 11:20 |
| nerochiaro | oSoMoN: i wonder how other applications that do unit tests and have binary plugins do it | 11:20 |
| nerochiaro | if we have any | 11:20 |
| gusch | nerochiaro: sorry - no | 11:20 |
| gusch | nerochiaro: but I might need that as well | 11:21 |
| oSoMoN | nerochiaro: there must be a way, it’s just a matter of finding someone who knows it… | 11:21 |
| nerochiaro | oSoMoN: who was our expert back in the unity-2d days ? | 11:28 |
| oSoMoN | nerochiaro: it was agateau, not sure where he can be pinged those days | 11:30 |
| oSoMoN | s/those/these/ | 11:30 |
| === greyback is now known as greyback|lunch | ||
| === MacSlow|lunch is now known as MacSlow | ||
| kalikiana | Kaleo_, ping whenever you have time to discuss the spreadsheet you made | 12:11 |
| Kaleo_ | kalikiana: sure, which spreadsheet? | 12:11 |
| kalikiana | Kaleo_, aha, you are there, thought you were absent since you weren't in the daily | 12:12 |
| timp | Kaleo_: https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0Av4_up3vZmkvdGNHdW1mWGtwSndPWkRJQkdwNFgtM3c#gid=0 I am also interested in where the priorities come from and whether design has the same priorities | 12:15 |
| Kaleo_ | timp: they come from a variety of places and can be changed | 12:16 |
| Kaleo_ | timp: there was no sync with design on these priorities in a a long time | 12:16 |
| timp | Kaleo: ok. Would be good to have a chat with someone at design to sync our priorities | 12:25 |
| timp | or we leave it to the developer to contact design ahead of working on a component | 12:26 |
| === greyback|lunch is now known as greyback | ||
| oSoMoN | nerochiaro: would you mind top-approving https://code.launchpad.net/~osomon/webbrowser-app/addressbar-spacing-tweak/+merge/169477 ? | 12:41 |
| nerochiaro | oSoMoN: certainly not. done | 12:44 |
| Kaleo | timp: 14:20 < Kaleo_> timp: I'll bring it up with Calum and John | 12:47 |
| timp | Kaleo: ok, great | 12:49 |
| timp | Kaleo: if you said something else in that time period, I may have missed it also | 12:49 |
| timp | 14:24:42 -!- Kaleo_ [boucault20@tom.iiens.net] has quit [Ping timeout: 264 seconds] | 12:49 |
| timp | 14:24:50 -!- Kaleo [boucault20@tom.iiens.net] has joined #ubuntu-app-devel | 12:49 |
| Kaleo | timp: nope, nothing else :) | 12:54 |
| timp | gusch_, zsombi I am preparing a change in the tools API, and I have changes ready for gallery-app to reflect this | 13:09 |
| timp | gusch_: could you have a look and give me your comments? Don't approve because the changes are not in UITK | 13:10 |
| timp | zsombi: ^ if you will be reviewing my UITK MR on this later, you can see in gallery-app already what the changes would be for apps | 13:10 |
| gusch_ | timp: ok - and can I see the changes in the UITK? To check is autopilot will break | 13:11 |
| timp | gusch_: the idea is that eventually, all Actions can show up in the HUD, and their visual representation in the toolbar is a ToolbarButton | 13:11 |
| timp | gusch_: sure, https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/toolbarItems | 13:12 |
| timp | gusch_: I guess autopilot will break, but will become easier to use because you define the buttons now in your own code | 13:12 |
| seb128 | the system settings design have often buttons in lists that are supposed to be the same width than text in a ListItem ... does that seems like a case for a standard widget (should I file a wishlist about it?) | 13:14 |
| seb128 | or should we play with spacing/marging and copy those tweaks around (and update them the day spacing change for listitems) | 13:15 |
| zsombi | (04:10:55 PM) timp: zsombi: ^ if you will be reviewing my UITK MR on this later, you can see in gallery-app already what the changes would be for apps | 13:15 |
| zsombi | timp: ok | 13:16 |
| timp | zsombi: thanks | 13:16 |
| timp | seb128: try this http://developer.ubuntu.com/api/ubuntu-12.10/qml/mobile/qml-ubuntu-components-listitems0-singlecontrol.html | 13:16 |
| timp | seb128: is that what you mean? | 13:16 |
| seb128 | timp, can I turn the separators off? | 13:16 |
| timp | seb128: yes, showDivider: false http://developer.ubuntu.com/api/ubuntu-12.10/qml/mobile/qml-ubuntu-components-listitems0-empty.html#showDivider-prop | 13:17 |
| zsombi | Kaleo: I was thinking to move Arguments stuff under Ubuntu.Services together with Alarms API + some others which would be better to be packaged in a separate module | 13:18 |
| zsombi | Kaleo: opinion? | 13:18 |
| seb128 | timp, sorry, my nm-applet has been unhappy | 13:19 |
| Kaleo | zsombi: not sure about that; in any case not really critical right now | 13:19 |
| seb128 | timp, I was asking if I can disable separators | 13:19 |
| timp | 15:17:30 < timp> seb128: yes, showDivider: false http://developer.ubuntu.com/api/ubuntu-12.10/qml/mobile/qml-ubuntu-components-listitems0-empty.html#showDivider-prop | 13:19 |
| timp | seb128: ^ | 13:19 |
| seb128 | timp, ah, thanks! | 13:19 |
| zsombi | Kaleo: so you would suggest to have the Alarms API also in Ubuntu.Components? | 13:19 |
| seb128 | timp, I was looking at http://developer.ubuntu.com/api/ubuntu-12.10/qml/mobile/qml-ubuntu-components-listitems0-singlecontrol-members.html | 13:20 |
| seb128 | timp, which doesn't have those properties listed | 13:20 |
| timp | seb128: weird. it should be there because SingleControl inherits from Empty, but the docs don't show it | 13:20 |
| seb128 | timp, want a bug report about that? | 13:21 |
| timp | dpm: ^ documentation problem. | 13:21 |
| Kaleo | zsombi: right now yes | 13:21 |
| timp | dpm: the link to Empty is in the documentation I generate locally with 'make docs', but not on the webpage. Will this be fixed automatically the next time the docs are updated? | 13:21 |
| timp | dpm: or is it a different issue and we need to report a bug? | 13:21 |
| timp | seb128: I don't know. Let's ask dpm | 13:22 |
| zsombi | Kaleo: I kinda would like to keep the UI components separated from UI-less ones, especially from the service functionality providers... but... | 13:23 |
| timp | kalikiana: ^ or perhaps you know what's happening with the docs? | 13:23 |
| dpm | timp, we're not updating the docs automatically yet. kalikiana set them up, but his MP is pending on some help that we should get from the Web team to make the breadcrumbs in the docs appear correctly | 13:24 |
| dpm | timp, seb128 I can update the docs manually, but it will have to be in a few hours time | 13:24 |
| timp | dpm: but if it is correct locally when I run 'make docs', does that mean it will be correct after the next docs update? | 13:24 |
| dpm | timp, no, I didn't switch automatic online doc updates yet as it was pending another MP to add the d.u.c headers to the docs. But if I update them manually later on and merge the branches currently in review, they should be ok | 13:27 |
| kalikiana | dpm, so it's simply outdated isn't it? | 13:27 |
| dpm | kalikiana, yeah. Do you know if the mp to add the header and footer landed? Since there were so many doc fixes, I'm not sure if that was coupled with your breadcrumbs branch or if it's already landed | 13:29 |
| kalikiana | dpm, that was separate | 13:29 |
| kalikiana | afair navi is the only unmerged branch | 13:30 |
| seb128 | timp, sorry, my laptop was in weird state, I had to reboot | 13:30 |
| seb128 | hopefully it fixed it | 13:30 |
| nerochiaro | oSoMoN: gusch_: om26er: after battling half a day with cmake this is how i convinced it to copy some files post-build and pre-test to the test directory: add_custom_command( | 13:30 |
| nerochiaro | TARGET ubuntu-ui-extras-plugin | 13:30 |
| nerochiaro | POST_BUILD | 13:30 |
| nerochiaro | COMMAND ${CMAKE_COMMAND} -E copy | 13:30 |
| nerochiaro | $<TARGET_FILE:ubuntu-ui-extras-plugin> | 13:30 |
| nerochiaro | ${CMAKE_BINARY_DIR}/tests/unittests/Ubuntu/Components/Extras/) | 13:30 |
| nerochiaro | hope it helps, for reference | 13:30 |
| gusch_ | nerochiaro: ok - thx - in which package will it be? | 13:32 |
| timp | seb128: ok. you got the links for the online docs, but they are outdated and they don't correctly list that SingleControl inherits the properties from Empty | 13:32 |
| dpm | kalikiana, great, I'll see if I can switch automatic docs later on. timp ^ | 13:33 |
| seb128 | timp, ok, thanks | 13:33 |
| seb128 | I see that dpm is on it | 13:33 |
| kalikiana | +1000 for automatic docs | 13:33 |
| dpm | seb128, in the meantime, you can read the docs from the ubuntu-ui-toolkit-doc package. Those should be up to date | 13:34 |
| nerochiaro | gusch_: ubuntu-ui-extras, new package that will contain browser and later on mediaplayer components | 13:34 |
| seb128 | dpm, timp: file:///usr/share/ubuntu-ui-toolkit/doc/html/qml-ubuntu-components-listitems0-singlecontrol-members.html is correct indeed | 13:34 |
| seb128 | thanks! | 13:34 |
| gusch_ | nerochiaro: ah - ok - thx | 13:35 |
| dpm | super | 13:36 |
| oSoMoN | nerochiaro: thanks for the reference | 13:37 |
| nerochiaro | oSoMoN: wasn't the merge request approved last week ? | 13:43 |
| oSoMoN | nerochiaro: looking at the history, I’m not seeing any commits that looks like this, and there are no pending MRs against notes-app | 13:45 |
| nerochiaro | oSoMoN: ok, so what happened is that i did the translations for share and camera, including desktops, but never went back to notes to do the desktop files | 13:46 |
| timp | gusch_: do you think this API change would be good? http://bazaar.launchpad.net/~tpeeters/gallery-app/toolbarItems/revision/729 do you like it? | 13:46 |
| nerochiaro | oSoMoN: also there was some uncertainity about how the desktop file translations actually worked, for the camera MR. was that resolved ? | 13:46 |
| nerochiaro | gusch_: ^ | 13:47 |
| oSoMoN | nerochiaro: ok, so please do so today if possible | 13:47 |
| oSoMoN | nerochiaro: dunno, I don’t think I was involved in reviewing that one, do you have a link? | 13:47 |
| gusch_ | nerochiaro: yes, resolved. I was wrong (didn't get the magic begind gettext) | 13:48 |
| gusch_ | timp: let me see ... | 13:48 |
| gusch_ | timp: sometimes it's Button, sometime ToolbarButton ? | 13:50 |
| gusch_ | timp: sometimes the anchors.verticalCenter ist set, sometimes not? | 13:51 |
| gusch_ | timp: oh - I see - it's when a real button is used (Cancel for example) | 13:52 |
| timp | gusch_: yes. It is Button on those places where you used to have an itemHint | 13:52 |
| timp | gusch_: ToolbarButton automatically sets anchors, Button does not. But I admit that I don't like that I have to explicitly add the anchor to the Button | 13:53 |
| nerochiaro | oSoMoN: ok, on doing it today | 13:58 |
| gusch_ | timp: looks ok - but I guess it will break autopilot ;) | 13:58 |
| oSoMoN | dpm: is there a specific reason why https://code.launchpad.net/~dpm/ubuntu-calendar-app/rename/+merge/169776 is marked "Work in progress" ? | 13:59 |
| oSoMoN | dpm: or is it safe for me to top-approve it? | 13:59 |
| timp | gusch_: should I include the fixes for autopilot in that branch? | 13:59 |
| timp | gusch_: how do I run the gallery autopilot tests? | 13:59 |
| gusch_ | timp: otherwise it won't integrate ;) | 13:59 |
| gusch_ | timp: got to "cd tests/autopilot; autopilot run gallera_app" | 14:00 |
| dpm | oSoMoN, yeah, I noticed that for some reason after merging the other branch it depended on, the diff now generates conflicts. I couldn't figure it out and today I don't have more time to look at the MPs, so I marked it as WIP and I'll have a look at those merge conflicts tomorrow morning | 14:00 |
| oSoMoN | dpm: it merges fine locally (albeit with a criss-cross warning), it may just be launchpad being confused, shall we give a try at approving it? | 14:04 |
| timp | gusch_: I get a bunch of errors like ImportError: Failed to import test module: gallery_app.tests.test_album_view | 14:04 |
| timp | gusch_: and ImportError: No module named input | 14:05 |
| dpm | oSoMoN, fine by me, thanks for testing it! | 14:05 |
| oSoMoN | np | 14:06 |
| timp | gusch_: do I need autopilot-phablet? | 14:06 |
| gusch_ | timp: libautopilot-qt | 14:07 |
| gusch_ | timp: and libqt5test5 | 14:07 |
| timp | gusch_: from which ppa? | 14:07 |
| gusch_ | timp: http://ppa.launchpad.net/ubuntu-unity/daily-build-next/ubuntu/ raring/main | 14:08 |
| oSoMoN | dpm: do you have credentials to login to the jenkins instance to request a rebuild? | 14:11 |
| oSoMoN | dpm: i.e. http://91.189.93.125:8080/job/ubuntu-calendar-app-ci/31/rebuild | 14:11 |
| timp | gusch_: thanks | 14:11 |
| dpm | oSoMoN, I don't. Either mmrazik or fginther should have | 14:11 |
| gusch_ | timp: "autopilot list gallery_app" gives you the names, to run tests individually (as a full run takes 4 minutes and blocks for computer essentially) | 14:13 |
| oSoMoN | dpm: mmrazik did it, let’s see what jenkins says | 14:13 |
| oSoMoN | nerochiaro: regarding the desktop file in notes app, let me know as soon as you have a MR, and let’s work to ensure it gets merged today | 14:15 |
| dpm | cool, thanks oSoMoN | 14:18 |
| oSoMoN | dpm: the CI job passed, I just top-approved | 14:21 |
| dpm | oSoMoN, awesome, thanks! | 14:23 |
| timp | gusch_: oops.. after adding the ppa and upgrading my packages I don't have a window manager after I log in.. :s | 14:24 |
| gusch_ | timp: did you do a full upgrade? | 14:30 |
| timp | yes, sudo apt-get update && sudo apt-get upgrade | 14:31 |
| timp | ah, a bunch of packages have been kept back | 14:32 |
| gusch_ | timp: oh oh - I do only it as well - but I use KDE | 14:32 |
| timp | gusch_: oh, after dist-upgrade I have windows again :) | 14:36 |
| timp | gusch_: and the gallery_app autopilot tests run :) | 14:37 |
| * timp bbl | 14:37 | |
| oSoMoN | dpm: looking at the last MR in the series, will the qmake/make trick for the po/ folder be automatically picked up and executed, or is it still a manual step for now? | 14:50 |
| dpm | oSoMoN, still a manual step. Right now it is not more than a developer aid. In the future, most probably there should be a proper build system in the apps | 14:51 |
| oSoMoN | dpm: ok, sounds good enough to me | 14:52 |
| oSoMoN | dpm: maybe an entry in the README file to explain how to generate an up-to-date pot file? | 14:53 |
| dpm | oSoMoN, indeed, that's a very good point. I'll add it to my todo and prepare it for the rest of the apps as well | 14:54 |
| nerochiaro | oSoMoN: bfiller: https://code.launchpad.net/~amanzi-team/notes-app/notes-app-desktop-i18n/+merge/169827 | 15:08 |
| nerochiaro | oSoMoN: bfiller: desktop file i18n for notepad | 15:08 |
| oSoMoN | nerochiaro: I’m on it | 15:09 |
| oSoMoN | nerochiaro: commented on the MR | 15:29 |
| nerochiaro | oSoMoN: looking | 15:29 |
| nerochiaro | oSoMoN: see if it's better now | 15:30 |
| oSoMoN | nerochiaro: nope, there’s a lot of extra garbage now because you had files resulting from a previous package build in the debian dir, please run it on a clean tree | 15:32 |
| nerochiaro | oSoMoN: try now | 15:42 |
| oSoMoN | nerochiaro: approved, let’s wait for jenkins to run the CI, and then feel free to top-approve | 15:45 |
| nerochiaro | oSoMoN: ok, thanks | 15:46 |
| === dholbach_ is now known as dholbach | ||
| nerochiaro | oSoMoN: tests seem to fail, but i didn't touch them | 15:51 |
| nerochiaro | oSoMoN: something is odd | 15:51 |
| oSoMoN | nerochiaro: looking into it, please have a look at the logs yourself too | 15:51 |
| nerochiaro | oSoMoN: i am, it seems the app isn't quitting | 15:51 |
| oSoMoN | nerochiaro: please ask om26er about it, I think I recall something related that was discussed last week | 15:52 |
| nerochiaro | oSoMoN: om26er: any ideas why these tests fail on notepad ? https://code.launchpad.net/~amanzi-team/notes-app/notes-app-desktop-i18n/+merge/169827 | 15:54 |
| om26er | nerochiaro, I tried to fix that in my branch (https://code.launchpad.net/~om26er/notes-app/fix_jenkins_failures) but failed.. | 15:55 |
| om26er | nerochiaro, it seems alt-f4 event is not happening in jenkins setup due to some reason | 15:56 |
| om26er | nerochiaro, we need to fix another way to kill the app. | 15:56 |
| nerochiaro | oSoMoN: om26er: yeah. but in the meantime i think oSoMoN we can approve that MR since it has nothing to do with the code i submitted for review | 15:57 |
| om26er | nerochiaro, I think it may make sense to disable these tests for now... | 15:57 |
| om26er | I wonder if the MR will go in till those tests pass... | 15:57 |
| nerochiaro | om26er: you tell me | 15:57 |
| AskUbuntu | Ubuntu/Qt Application | http://askubuntu.com/q/309302 | 15:57 |
| om26er | nerochiaro, Yes. I thought of disabling them as well. I didn't find a way to kill the app.. we could do 'killall qmlscene' | 15:58 |
| om26er | alt-f4 doesn't work on touch anyways so this is a partial solution anyways... | 15:59 |
| nerochiaro | om26er: sounds a bit brutal, but might work. for now i'm disabling these two tests though | 16:00 |
| nerochiaro | oSoMoN: is it ok if i do that in the same MR ? | 16:00 |
| oSoMoN | nerochiaro: don’t comment them out, just skip them | 16:00 |
| oSoMoN | nerochiaro: yes | 16:00 |
| nerochiaro | oSoMoN: how do i skip them ? | 16:00 |
| oSoMoN | nerochiaro: I don’t remember the exact syntax, but I believe there a skipTest decorator for test methods that should not run, and you can pass it a string to explain why the test is being skipped | 16:01 |
| om26er | nerochiaro, import unittest ; use it as decorator a line before the test.. like this: @unittest.skip("Quick is not working") | 16:01 |
| om26er | or you may even want to skip the entire class... | 16:02 |
| nerochiaro | oSoMoN: om26er: any way to skip the tests only when running on device ? it's the only place where they fail,no ? | 16:08 |
| om26er | nerochiaro, they fail in jenkins as well.. | 16:08 |
| nerochiaro | om26er: but they work on desktop | 16:09 |
| om26er | nerochiaro, yes, they are working fine on my desktop as well. but due to some reason unknown they fail in jenkins.. I tried 3-4 experiments but none of them worked.. | 16:09 |
| nerochiaro | om26er: exactly, so my question is: can we leave them enabled on desktop and disable them on jenkins ? | 16:10 |
| om26er | nerochiaro, no, we can't differentiate.. | 16:10 |
| nerochiaro | om26er: ok | 16:10 |
| om26er | nerochiaro, I tried to do this: http://bazaar.launchpad.net/~om26er/notes-app/fix_jenkins_failures/revision/136 that didn't work | 16:11 |
| nerochiaro | om26er: when i add that decorator, are the tests still supposed to appear in autopilot list ? | 16:17 |
| om26er | nerochiaro, yeah, they should | 16:17 |
| om26er | nerochiaro, try running them. the app window will just appear and then disappear quickly | 16:18 |
| nerochiaro | oSoMoN: om26er: i pushed the changes with the disabled tests already, let's see what jenkins does | 16:18 |
| oSoMoN | nerochiaro: would you mind approving this trivial MR? https://code.launchpad.net/~osomon/webbrowser-app/cmakelists-qt-creator/+merge/169845 | 16:32 |
| nerochiaro | oSoMoN: done | 16:33 |
| oSoMoN | nerochiaro: thanks | 16:33 |
| om26er | nerochiaro, so I have fixed 20 tests for the browser component | 16:40 |
| om26er | nerochiaro, others are bit tricky to fix it seems... | 16:41 |
| nerochiaro | om26er: just a moment, can you trigger a rebuild on this MR ? https://code.launchpad.net/~amanzi-team/notes-app/notes-app-desktop-i18n/+merge/169827 | 16:42 |
| nerochiaro | om26er: it seems jenkins isn't running it, or it's taking a long time | 16:42 |
| om26er | nerochiaro, its running already | 16:43 |
| nerochiaro | om26er: ok. regaring the browser component, can you please commit the fixed tests ? | 16:48 |
| nerochiaro | om26er: and why are the tricky ones more tricky ? | 16:48 |
| om26er | nerochiaro, one of them makes sure the app starts chromeless,,, which requires a parameter '--chromeless' which we cannot provide... | 16:50 |
| om26er | nerochiaro, others are related to 'browser history' it seems the dummy database is not being picked by the app in that mode | 16:50 |
| Laney | Kaleo: Hey, last week you told me that UbuntuShape accepts a ShaderEffectSource but I don't see that here - any clues? (Unable to assign QQuickShaderEffectSource to QQuickImage) | 16:54 |
| om26er | nerochiaro, lp:~om26er/+junk/fix-autopilot-tests | 16:55 |
| om26er | nerochiaro, or should I push to your branch ? | 16:56 |
| nerochiaro | om26er: please push to my branch | 16:56 |
| nerochiaro | om26er: all those are ok being tested as part of the webbrowser-app i tink | 16:56 |
| nerochiaro | think | 16:56 |
| om26er | nerochiaro, done | 16:57 |
| om26er | I'll be back later. | 17:01 |
| oSoMoN | nerochiaro: would you have a moment to review https://code.launchpad.net/~osomon/webbrowser-app/target-blank-relative/+merge/169854 ? | 17:01 |
| nerochiaro | oSoMoN: looking | 17:04 |
| oSoMoN | thx | 17:04 |
| nerochiaro | oSoMoN: if the tests pass it looks ok to me | 17:05 |
| nerochiaro | bfiller: FYI since you wanted to be notified: notes-app desktop file i18n approved: https://code.launchpad.net/~amanzi-team/notes-app/notes-app-desktop-i18n/+merge/169827 | 17:06 |
| oSoMoN | nerochiaro: cool, feel free to approve then, I can top-approve once CI succeeds | 17:07 |
| Kaleo | Laney: let me think | 17:13 |
| timp | Laney, Kaleo UbuntuShape does not accept it directly, but its parent class (Shape, made available from c++) does | 17:16 |
| Kaleo | Laney: timp: ahy yes! | 17:17 |
| Kaleo | of course | 17:17 |
| Kaleo | that's a glitch we will have to remedy | 17:17 |
| timp | there is a bug for that https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1089595 | 17:20 |
| ubot2 | Ubuntu bug 1089595 in Ubuntu UI Toolkit "[shape] UbuntuShape should shape more general Item-based components" [Wishlist,Triaged] | 17:20 |
| seb128 | do you guys have a widget to use for cases like https://wiki.ubuntu.com/AboutThisDevice?action=AttachFile&do=get&target=phone-storage.png | 17:37 |
| seb128 | the [ by name ][ by size ] splitted button | 17:38 |
| === francisco is now known as Guest20683 | ||
| timp | seb128: nope | 17:40 |
| seb128 | timp, ok, any planned? | 17:41 |
| timp | seb128: yes it is planned, but I cannot find a bug report for it | 17:42 |
| seb128 | timp, ok, good to know that it's planned ;-) | 17:42 |
| timp | seb128: it is currently low priority and won't arrive before the beta | 17:44 |
| seb128 | timp, I should maybe talk to design to have an alternative UI suggested then | 17:45 |
| seb128 | timp, thanks | 17:45 |
| bfiller | nerochiaro: thanks | 18:04 |
| Laney | timp: Kaleo: hrm, alright then - so I'll be able to propose CrossFadeImage to the toolkit but probably not actually use it just yet until that gets fixed | 18:29 |
| Kaleo | Laney: that's a misunderstanding | 18:47 |
| Kaleo | Laney: you can already use the Shape object | 18:48 |
| Laney | oh yeah? | 18:48 |
| Kaleo | Laney: yes, instead of UbuntuShape use Shape | 18:48 |
| Laney | but then I won't be all UbuntuShapey | 18:48 |
| Laney | or? | 18:48 |
| Kaleo | Laney: like it is dong in UbuntuShape.qml | 18:48 |
| Kaleo | Laney: it will be | 18:48 |
| Kaleo | Laney: it's just that the UbuntuShape got rewritten from QML to C++ in a hurry* | 18:49 |
| Kaleo | Laney: and now we have UbuntuShape.qml as a wrapper for the C++ Shape | 18:49 |
| Laney | well, that file does appear to do some things | 18:50 |
| === marlinc is now known as marlinc|away | ||
| === marlinc|away is now known as marlinc | ||
| === marlinc is now known as Marlinc | ||
| nik90 | Does anybody here know how to solve http://stackoverflow.com/questions/17155915/does-qml-support-converting-to-different-timezone-based-on-timezoneid ? | 20:29 |
| nik90 | or atleast ppoint me in the right direction? | 20:29 |
| === _salem` is now known as _salem | ||
| netcurli | nik90: you have seen this: http://qt-project.org/wiki/Qt-5-QTimeZone | 20:49 |
| netcurli | ? | 20:49 |
| nik90 | netcurli: I am looking at it now | 20:51 |
| nik90 | netcurli: I remember briefly looking at it before. But as I see many of its API for timezone is scheduled for qt 5.1 | 20:52 |
| netcurli | yes.. | 20:52 |
| nik90 | and I am not sure when exactly qt 5.1 will be packaged for ubuntu | 20:53 |
| netcurli | I mean, the data you are looking for is available in the tz database | 20:53 |
| netcurli | it's just a matter of how to access that information | 20:53 |
| nik90 | netcurli: I looked at tz database..and I see that it provide timezone info about a city | 20:54 |
| nik90 | netcurli: but meanwhile I was able to find an online API which gives me that same info | 20:54 |
| nik90 | but it returns it as Europe/Amsterdam or etc.... | 20:54 |
| nik90 | netcurli: I just need to know how to convert that into time | 20:55 |
| netcurli | with the tz database you can get the difference between a timezone by id and utc at some point in the past or future | 20:55 |
| nik90 | and will the difference be in minutes? as in Amsterdam is 120 minutes from UTC | 20:56 |
| nik90 | netcurli: for now in the ubuntu clock app, I am getting the current local time at a place and then subtracting it from my system time to know the diff | 20:58 |
| nik90 | I then can calculate the time at that city by using the diff anytime | 20:58 |
| netcurli | how would you deal with daylight saving time? | 21:17 |
| nik90 | netcurli: my current plan to check with the online api once every day | 21:18 |
| nik90 | netcurli: so that would take care of updating with daylight saving time | 21:18 |
| netcurli | btw: https://github.com/eggert/tz that is the source code of the tz database. and you can try "TZ='Europe/Amsterdam' date" in a terminal | 21:20 |
| nik90 | netcurli: yes I have explored the use of tzdata already present in ubuntu | 21:24 |
| nik90 | but js or qml does not have native capability to read tz files | 21:24 |
| netcurli | that is correct, you could either make a c++ plugin or compile the tz files to json (but you would have to provide updates then) | 21:26 |
| nik90 | netcurli: okay | 21:26 |
| === glebihan__ is now known as glebihan | ||
| === marlinc is now known as marlinc|away | ||
| === marlinc|away is now known as marlinc | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
