| === joeyfreenode is now known as joey | ||
| === Peng__ is now known as Peng | ||
| StevenK | wgrant: http://pastebin.ubuntu.com/5779460/ | 06:17 |
|---|---|---|
| wgrant | + result_set = IStore.using(*origins).find( | 06:18 |
| === tasdomas_afk is now known as tasdomas | ||
| StevenK | wgrant: It's already 833 lines, should I keep going in the same branch? | 06:21 |
| wgrant | Well, landing this one won't work very wel | 06:22 |
| wgrant | l | 06:22 |
| StevenK | Oh? | 06:22 |
| wgrant | IStore is an interface | 06:23 |
| wgrant | Calling .using() on it isn't going to be entirely successful | 06:23 |
| StevenK | Yeah, I fixed that | 06:23 |
| wgrant | Also, I would consider moving IStore and co. to l.s.d.interfaces | 06:24 |
| wgrant | lpstorm is a silly name. | 06:24 |
| StevenK | wgrant: Do you want it all in one branch? The diff is 833 lines, and that's only 20 files. | 06:24 |
| StevenK | There's another 91 to go. | 06:25 |
| wgrant | I'm hardly going to be reviewing the whole thing either way | 06:25 |
| StevenK | Oh? | 06:25 |
| wgrant | That sort of thing is extremely tedious and almost entirely pointless to review | 06:26 |
| wgrant | It's so similar that I would miss any mistakes. | 06:26 |
| StevenK | wgrant: So, do it all in one-shot, and throwing through ec2 should catch a fair bit | 06:30 |
| wgrant | Right, this is the sort of branch that you sed and then throw at ec2. | 06:30 |
| wgrant | Once tests past, read the diff to make sure it makes sense | 06:30 |
| === _mup__ is now known as _mup_ | ||
| === tasdomas is now known as tasdomas_afk | ||
| === tasdomas_afk is now known as tasdomas | ||
| === tasdomas is now known as tasdomas_afk | ||
| === tasdomas_afk is now known as tasdomas | ||
| === wedgwood_away is now known as wedgwood | ||
| === BradCrittenden is now known as bac | ||
| === BradCrittenden is now known as bac | ||
| === tasdomas is now known as tasdomas_afk | ||
| === mgz_ is now known as mgz | ||
| === dpm is now known as dpm-afk | ||
| === Ursinha is now known as Ursinha-afk | ||
| === mwhudson_ is now known as mwhudson | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === wedgwood is now known as wedgwood_away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!