=== rogpeppe1 is now known as rogpeppe [12:00] Makyo, I got a report that the "Firefox only" bug is actually on chrome as well, and verified. urgency is very high. lemme know if you need more resources to help you, or if you need me to get anything out of your way [12:01] gary_poster: jcsackett mentioned you emailed out to people on the shared web asset stuff and I didn't see that email. Was that to the gui list? Or some other list I might not be signed up for? [12:02] rick_h, juju-gui-peeps (bottom left of https://launchpad.net/~juju-gui-peeps). You are listed as subscribed [12:02] https://launchpad.net/~juju-gui-peeps/+mailing-list-subscribers [12:03] gary_poster: cool thanks. I wasn't subscribed to the list. Added. [12:05] rick_h, I had weird dyslexia and thought you were jc. Crazy sometimes :-P [12:05] gary_poster: it's early...more coffee [12:05] :-) [13:00] hey teknico are you investigating CI? [13:08] come on, you know you want to review this code https://codereview.appspot.com/10416044/ it'll make your morning and is equiv to 3 cups of coffee. promise! [13:08] gary_poster: just back from lunch, I wonder how I can discover what those two failures are [13:08] teknico, you watch the videos [13:10] gary_poster: oh, now I can see the FAIL line, thanks [13:19] the service is quite slow at serving videos... [13:19] rick_h: ECHANGETOOBIG, cannot review, sorry ;-P [13:23] teknico: ignore the giant test json file that's 80% of the change :) [13:23] teknico: that's just fixture data pulled from the back end [13:24] +1310 lines - 962 fixture [13:24] rick_h: thanks, highlighting this in the description would be useful [13:25] teknico: agreed, apologies there. [13:26] rick_h: no worries, i just like complaining ;-) [13:36] gary_poster: the failing test does not seem to rely on code my branch changes, and it's under a 250ms timeout, maybe a fluke? [13:37] teknico, maybe so. given the goal of your branch, maybe try at least adding a warning comment about it, and then retrying? [13:39] gary_poster: adding a comment about the failure above the test module entry in index.html? sure [13:39] cool [13:44] rick_h, fwiw you are still not showing up on juju-gui-peeps mailing list https://launchpad.net/~juju-gui-peeps/+mailing-list-subscribers [13:46] gary_poster: ok, so strange. Whenever I click on subscribe I get taken to my +editmails page but it's not liseted there at all [13:48] gary_poster: nvm, I was looking for GUI and it's UI [13:48] gary_poster: updated, and subscribed [13:48] rick_h, :-) cool [13:50] jcsackett: found review. I was looking at the bug off the card. Man I need to wake up today. [13:54] morning [13:56] hi luca__, thanks for the feedback on the feedback box. please have a look at lp:~bac/juju-gui/feedback. your referenced example helped a lot to figure out what to do. [13:57] luca__: recording your thoughts on the review would be helpful: https://codereview.appspot.com/10407044 [13:57] hatch: got a sec to second the review here for jcsackett please? https://codereview.appspot.com/10352045/ [13:58] * rick_h goes to catch him before he gets started with anything, the perfect code-review trap [13:58] rick_h: link for yours? [13:58] hey teknico I need to either start our call late or finish very early. which would you prefer? [13:58] late: maybe 10 minutes [13:58] jcsackett: https://codereview.appspot.com/10416044/ [13:58] that's my preference :-) [13:59] jcsackett: ignore the giant .json test fixture :) [13:59] gary_poster: no problem with late [13:59] thank you [14:03] rick_h: what are "overall related charms"? [14:05] teknico: regardless of if it's a require/provide interface and what interface it's a part of [14:05] teknico: sorry, should have done a screen shot [14:06] rick_h: so is it a superset of all related charms? [14:07] teknico: http://uploads.mitechie.com/lp/related-charms.png is the feature. On the right it lists charms related to this one. Overall means of any related charm. It's the highest ranking subset of all realted charms. [14:07] teknico: based on the weight score from the api. [14:08] teknico: a follow up branch will add a simliar related charm to the interfaces tab, but it will be on each matching interface [14:09] rick_h: ok, thanks [14:10] teknico: np, thanks for asking :() [14:10] err :) [14:16] rick_h: reviewing [14:16] hatch: thanks [14:17] rick_h: done [14:18] teknico: thanks, appreciate it. [14:24] bac: I branched your code and I can't see the tab [14:24] rick_h: done [14:25] bac: never mind! I had the wrong url [14:38] hatch: hi, remember that problem with caching and loadFixture in test/utils? I finally made it work without changing the code around too much, see line 429 of the diff: https://code.launchpad.net/~teknico/juju-gui/test-interdep-cleanup/+merge/170408 [14:39] cool [14:39] be glad to see those GET requests gone [14:41] switching from less to sass.....w0000000t [14:41] rick_h: re: the relatedCharmContainer comment in the review, it was by yourself, not me :-) [14:41] hatch: that's actually kind of sad :-P [14:41] I'll have to install ruby back [14:41] bah! sass is superior [14:41] so? [14:41] apt-get install ruby [14:41] done [14:41] :P [14:41] bac: where can I leave feedback? [14:41] hatch, teknico we would use pysass [14:42] hatch: I know :-P I'd like to avoid inferior prog. languages bloating my machine ;-) [14:42] luca__: https://codereview.appspot.com/10407044 [14:42] gary_poster: I've used https://github.com/Kronuz/pyScss as well with success [14:42] bac: it works perfectly [14:42] teknico: haha well I agree with you on that one :P [14:42] bac: I just want to change the oranges [14:42] gary_poster: *excellent* news! :-D [14:42] luca__: hey, that's the kind of feedback i like [14:42] hatch: no ruby for you! [14:43] rick_h, sorry I meant "a python version of sass" and was going to get recommendations. pyscss does seem like the winner according to google [14:43] hatch: how is sass superior to less, btw? [14:43] gary_poster: ahh I didn't know there was a python port of it. (quick google) do you know which version we are using? [14:43] gary_poster: ah, gotcha. [14:43] ahh [14:44] gary_poster: and are we also going to use the older, indented, bracket-less SASS syntax? pretty please? ;-) [14:44] nooo [14:44] scss [14:44] is my vote [14:44] :-) [14:44] teknico, I don't think so [14:44] scss! [14:44] I know, I know, compatibility and stuff :-P [14:45] gary_poster: my quick googleing hasn't found a pysass version which is maintained....did you have a link? [14:45] hatch, sorry I was using the term as a shorthand [14:46] hatch if everyone who knows/cares recommends pycss, that's a very easy decision [14:46] pyscss [14:46] hatch: I would have loved to review your "Prototype conflict resolution story" branch but, alas, there's no proposal linked from the card, so some other time, maybe ;-) [14:46] jujugui - please review and QA - critical - https://codereview.appspot.com/10309044 [14:47] Makyo: on it [14:47] Makyo: got it [14:47] gary_poster: hmm, my google fu must be failing me today [14:48] Makyo: I removed that code to fix the bouncing issue with the new sidebar [14:48] hatch: it was a not so subtle hint to put the link to rietveld on your card, if you want reviews :-P [14:48] hatch https://pypi.python.org/pypi/pyScss/1.1.5 [14:48] hatch, It's causing problems, please do additional QA around that issue. [14:48] well I know it'll revert haha [14:49] so.... [14:49] https://github.com/Kronuz/pyScss [14:49] cool thanks gary_poster [14:52] jcsackett: updated branch and comments inbound [14:54] Makyo: yup broken... [14:55] so....what to do.... [14:55] hatch, I need more than 'broken'. What do you mean? [14:55] when you deploy a service on rapi it bounces to the middle of the canvas, then when the delta comes in, it bounces back to where the ghost was [14:56] this is because the positioning data was removed [14:56] Oh, I thought you meant the dragging. [14:56] Can we make that a separate card please, instead of lumping it into other branches? [14:57] I'm a little confused, you want to add the regression back in to solve later? [15:00] You introduced a regression as a side-note that broke service dragging on deploy in two browsers. It was marked as a critical bug, and so I fixed it *shrug* [15:00] Adding it as a separate card to complete in the future allows us to have a branch dedicated to that work, a time-boxed task that can be thought through properly. [15:01] +1 previously problematic behavior is much better than currently problematic behavior [15:01] I'd like to get this out the door for our users [15:02] because right now we have a release that is very problematic to use [15:02] so we need a 0.7.1 [15:02] ahh I see what happens [15:02] not sure which is worse haha [15:03] * gary_poster is :-) [15:03] LGTM'd [15:03] How about we land this, and I work on the bounce next? [15:04] LGTM'd too [15:04] +1 Makyo. Maybe make an estimate in 30 minutes to an hour whether you think we should release or wait for that fix? [15:04] gary_poster, got it. [15:04] Thanks folks. [15:04] Thanks [15:05] yeah that relation line issue is probably more annoying [15:05] :) [15:06] looks like pyscss is under active development so....yay! [15:06] hatch: yea, I use it in my own app and the author is great. I've worked with him on a bug before and follow it. [15:06] bac: http://www.surveymonkey.com/s.aspx?PREVIEW_MODE=DO_NOT_USE_THIS_LINK_FOR_COLLECTION&sm=KQGch%2bQZdukeW3lhoxqsXXb2yTDsbkNneEEjHFw4%2bEM%3d ? [15:07] it doesn't support everything in sass, but most of the stuff is there. [15:07] if it wasn't I was going to suggest the node-sass one as it is essentially a binding to libsass [15:07] gary_poster: that's the exact link you want to use? [15:07] bac, no, sorry [15:07] well, i guess we remove the preview [15:07] * teknico reviews other branches, while hatch puts together a Rietvled link to put on his branch's card. It might still happen someday... [15:07] bac, I was wondering if you thought it was better [15:07] or if you had other feedback [15:08] teknico: oh woops [15:08] https://codereview.appspot.com/10397045/ [15:08] gary_poster: it looks good. we have more control over styling, is monolingual (!), and doesn't go straight to the NSA [15:08] :-) cool bac, lemme get you link [15:09] (maybe obvious, don't know) [15:10] bac https://www.surveymonkey.com/s/jujugui [15:10] hatch: third time's the charm, if you finally update the card [15:11] it's updated [15:11] hatch, joining our call, sorry for being late [15:11] np, do we have a link? :) [15:11] much shorter too [15:11] yeah [15:13] hatch: and now it's even in the right field :-) [15:14] bcsaller: when you add a charm how does it determine constraints? is there just a basic spec that is used? [15:16] luca__: you're the designer, but that new hover orange looks a little anemic. #D9722D right? [15:16] bac: that's Ubuntu orange…. :P [15:17] okey doke [15:17] bac: jamie our visual designer gave me them, it's what we use everywhere else. [15:19] gary_poster: when you add a charm how does it determine constraints? is there just a basic spec that is used? [15:19] benji: hatch ^ [15:19] anyone :D [15:20] luca__, #DD4814 ? on call will respond when I can [15:20] luca__: there are generic ones like arch, cpu, memory and potentially provider specific ones [15:21] luca__: there is a pre-defined set of constraints. Specifically ['cpu-power', 'cpu-cores', 'mem', 'arch'] (for the Go backend) [15:21] but when I deploy, do i NEED to set them or are they automatically set? [15:21] you get defaults [15:21] many people will never touch them [15:22] luca__: in http://bazaar.launchpad.net/~canonical-website-editors/ubuntu-brand-guidelines/guideline-assets/view/head:/sass/latest/core-constants.scss ubuntu orange is #dd4814 [15:22] luca__: D9722D is never used in there [15:22] bac: ^ [15:23] rick_h: bad for the tab we are using 2 kinds of orange [15:23] dd4814 is the regular tab, the other is for hover [15:24] luca__: ok, I've not seen the branch you guys are mentioning but they call out "ubuntu orange" as dd4814 [15:24] rick_h: bac does it look weird with those 2 colours? [15:24] rick_h: you are correct [15:24] rick_h: but the other orange is the orange they use on the phone as ubuntu orange [15:25] luca__: ah ok. Just reading ic it read that d9722d was "ubuntu orange", ignore me :) [15:25] irc that is [15:25] luca__: i thought it looked a little funny. let me push my branch and you can see for yourself [15:25] * bac admits he can't match his sox and trousers [15:26] bac: don't worry sec [15:26] bac: getting the values from web team devs [15:30] bac: #df6920 it should be the same colours that are used in the ubuntu.com primary nav [15:31] luca__: ok so dd4814 for normal and df6920 for hover [15:32] * benji starts a band named #df6920. [15:32] bac: brilliant :) [15:33] just use 'green' [15:33] it's close enough [15:33] :P [15:33] no, "brilliant" is #ffffff [15:33] lol [15:33] *slow clap* [15:44] luca__, you all set with constraints? [15:45] gary_poster: yup, thanks [15:45] cool luca__ [15:47] hatch, https://codereview.appspot.com/10444043 /cc gary_poster [15:47] on it [15:48] Makyo: on it [15:48] wow that's confusing [15:48] :) [15:49] Thanks for the fix Makyo! [15:49] LGTM'd just qa'ing now [15:50] jujugui call in 10; kanpan now please [15:55] Makyo, in sandbox, if I create a ghost, move ghost, and then confirm to create service, ghost moves back to center for me when it converts to real service. duping... [15:56] Makyo, and it is still jumping around. :-/ maybe I have something cached. llokking [15:56] gary_poster: in the GUI, there has always been a logout button in the top right, what do you logout out of? [15:56] Boo. Forgot to test sandbox. [15:57] luca__, environment in real use. for jujucharms.com agree that it should not exist [15:58] gary_poster, can't dupe in chrome, but let me try FF. [15:58] jujugui call in 2 [15:58] Makyo I am hoping it is cache craziness...I'm in chrome also [15:59] Makyo: on rapi it appears to be working however it still deploys to the center then bounces back...albeit very fast...any way we can set it to deploy to the real position? [15:59] gary_poster, Is it the fact that the environment view centers on the service once it receives a delta? If I create two services and move the second ghost, it's more visible. [15:59] jcsackett: getting ready to run. I put a conditional LGTM on your branch. If you get a sec to look over mine I'd appreciate it and I can try to get it in later tonight. Thanks for the review! [16:00] Makyo, maybe so. will look more after call [16:00] hatch, That's the transitions we discussed before, so a separate task, I think. [16:00] gotcha [16:03] https://codereview.appspot.com/10401043/ [16:04] gary_poster: so it should be removed from the GUI? [16:05] luca__, users need to be able to log out of their environment. [16:05] Makyo: and how do they login? [16:06] luca__, by viewing the GUI which is deployed to their environment. They are prompted for the password to log in as an admin. [16:06] Makyo: I see, is that the login to their AWS (or other service) account? [16:07] luca__, no, they use the admin secret from their environments.yaml file for their juju env. [16:08] Makyo: and is that tied to any account settings? or is it simply a login/logout? Trying to determine if its appropriate language. [16:08] luca__, yes, in juju-core it's tied to an admin user, and will include other user types in the future (such as read-only users, etc) [16:09] Makyo: I see [16:09] luca__, doesn't make sense for jujucharms.com, of course. [16:10] Makyo: do you mean that it doesn't make sense to have juju charms login in the GUI? [16:11] luca__, No, for the instance of the gui that will be running on jujucharms.com; currently running on uistage. Neither of those are/will be attached to an environment, so there's nothing to log out of in that case. There is very much a need to provide a layer of security around the GUI as deployed to a user's environment, however. [16:11] benji: i meant to ask the rgb of your tshirt orange [16:12] i'm collecting oranges today [16:12] lol [16:12] Makyo: ah right, thats why we want "get juju" instead of "logout" for the sandbox. [16:12] Isn't there something in the Godfather films where every time you see an orange or something orange on-screen something bad happens? [16:12] I've never seen them, so I can't verify that. [16:12] luca__, Correct. Sandbox deployments aren't tied to an environment, so that's a good alternative. [16:19] Makyo: I can't reproduce gary's issue on sandbox or rapi, your fix appears to work as expected [16:24] bcsaller: does the html5 change event work on things like radio buttons and checkboxes? [16:24] hatch: afaik, its designed to work with everything [16:25] ok I wasn't sure if it was for all input types or just the primary ones [16:29] hatch: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#do-not-apply change event is at bottom of table [16:43] bcsaller: replied to review and cards created [16:47] hatch: thank you [16:51] jujugui can I get one more review+qa on https://codereview.appspot.com/10444043 so it can make it into the release? [16:51] Pretty short. [16:51] Makyo: I'll do it. [16:51] anyone know who the travel authorizer is now? [16:51] hatch, Antonio, I think. [16:52] ok wasn't sure if it was changed [16:52] will use him [16:53] benji, Thanks. [16:53] darn, I used Mark Ramm [16:53] I did as well [16:53] I need a bureaucracy cheat sheet. [16:54] lol darn, maybe I'll be denied [16:54] haha [17:00] Makyo: review and QA done, looks good [17:01] Makyo, hatch, Antonio isn't in our chain any more fwiw. ecosystems and gui are peers. Our authorizer is Robbie. I don't *think* there are any problems for now though [17:01] benji, thanks. [17:01] oh great I just sent one to mark ramm [17:01] lol [17:01] I'm never getting approved [17:01] actually [17:02] jujugui, Robbie is the authorizer for our sprints. I am probably the authorizer for your travel. [17:02] well then I hope someone approves this [17:02] lol [17:03] your not in the list [17:03] that form can't keep up with the reorgs [17:03] oh ok. then maybe Robbie? :-/ dunno [17:03] I will try to get info === matsubara is now known as matsubara-lunch [17:10] bcsaller: submitting the conflict code [17:11] so, YUI's NodeList.all() when given no arguments retuns an empty set? I just wasted 30 minuts because I assumed it returned all children. [17:11] nope [17:11] wrong method [17:11] :) [17:11] all() and one() are methods which return the results of a query [17:12] so passing it nothing will return nothing [17:12] feel free to bark YUI questions at me [17:12] it seems more useful for an empty query to return all results; I don't query for "nothing" very often [17:13] that's not very intuitive however [17:14] might be in other languages [17:14] I did it pretty intuitively. [17:14] what is the right way to get all of a node's decendents? [17:15] Node.get('children') [17:15] I think [17:15] lemme check [17:16] that only gives immediate children; I want all of them [17:16] all('*') ? [17:16] 'all' as in every child of child? [17:16] forever [17:17] sounds like a non-ideal pattern though [17:19] benji: I think I need to know what you're end goal is to offer a real solution [17:20] hatch: it's working for the moment, I'll look at making it nicer when I no longer have bigger fish to fry. [17:20] allllllrighty [17:21] bac, feedback tab looks nice & works well, thank you [17:21] conflict resolution branch is landed [17:21] gary_poster: cool [17:21] great hatch === matsubara-lunch is now known as matsubara [18:11] orangesquad: Could you please review https://code.launchpad.net/~abentley/charmworld/label-to-short-url/+merge/170675 ? [18:25] Makyo: sorry for the delay but your second review is done [18:26] man it's friggen pouring here [18:26] my travel has been approved...not sure by who...I'm no closer to knowing who I should have submitted to lol [18:30] bcsaller: are you around? [18:30] on a call, free soon [18:30] just want to make sure you're not working on the ghost inspector panel [18:31] well...if you are that's fine just don't want to duplicate work :) [18:33] bac, thanks! [18:36] gary_poster: chat? [18:36] hatch: off the call. I'm going to make some coffee, then maybe we can sync up on g+? [18:36] sure thing [18:36] bac, I c u [18:36] woof woof [18:37] lol [18:54] * benji books travel. [18:59] yay I'm back [18:59] wasn't sure what was going on there [19:05] my interenet is totally messed up [19:06] orangesquad: Could you please review https://code.launchpad.net/~abentley/charmworld/label-to-short-url/+merge/170675 ? === hatch_ is now known as hatch [19:20] jcsackett, sorry for double ping, but just in case: please see my priv msg :-) [19:28] benji: you around? [19:28] hatch: yep [19:28] can you join guichat real quick? [19:28] just have a question about the drag stuff and ghosts [19:31] benji: you coming? [19:32] I didn't notice your follow on. I'll come over. [19:32] lol [19:45] gary_poster: what was the term you wanted to rename bundles/stacks to? [19:46] jcastro: bundle == deployment template, template for short. stack == ... maybe stack is fine. I like charm group for being simple, boring and descriptive myself. [19:46] i vote for satchel ! [19:47] it is a little confusing [20:11] jc did you need that review? [20:11] a* [20:11] jcsackett: ^ [20:11] * hatch can't type [20:11] hatch: sure. [20:17] jcsackett: done and done! [20:18] great idea [20:19] hatch: not mine, rick_h suggested it and it took awhile before i decided he was right. :-P [20:19] haha [20:20] it's ok sometimes we can't see the forest through the trees [20:20] and the other times rick_h is just wrong [20:20] lol!! [20:22] * jcsackett laughs [20:22] that was cold. funny, but cold. :-P [20:22] lol I try [20:37] rick if you use a comment block with one * like /* */ then lint should ignore it [20:37] if there is two like /** */ then it triggers the doc machine [20:37] jcsackett: ^ I mean [20:45] jcsackett: rick_h ooh, which one of you has pics to the social sharing stuff? [20:45] I saw lp stuff scroll by in my mail client, heh [20:53] My itinerary includes a description "Boeing 737-700 (winglets)". I initially read that as "(wingless)". [20:53] haha [20:53] it's actually a rocket [20:53] I'm going to guess that there is a 737-700 without winglets [20:59] "" the intended effect is always to reduce the aircraft's drag by partial recovery of the tip vortex energy. "" [21:03] Hey Makyo. Try duping this for me if you could. go to http://uistage.jujucharms.com/sidebar/ and add a mysql service. then drag it, about once a second, 20 times. If something odd doesn't happen, reload and try doing it again. if something odd *still* doesn't happen, I won't worry about it for now. :-) [21:04] I hate it when people waste tip vortex energy. [21:04] benji: ugh I know! [21:04] for me the odd thing happens at about drag 9 [21:05] it's not a show-stopper, and not even something to block the inspector work, but it is a bug to file and tackle soonish, assuming you can dupe [21:05] I'd imagine odd things would happen no matter how many times you're in drag. [21:05] :-P [21:06] gary_poster: is the 'odd' thing that it jumps back to a previous position? [21:06] hatch, yes. for me it jumps twice. a previous position, and then the dragged position [21:07] ok in that case I can confirm that I have seen it, however it only happened once and I couldn't repro so I Just throught it was an artifact of what I'm hacking on [21:07] ok thanks hatch, I'll file [21:08] Makyo, also wondering if you are making a release. if not I will later [21:08] * gary_poster steps away for now [21:09] au revoir [21:10] jcastro: it's not on uistage yet. and you owe me text for the sharing widget. :-p [21:11] oh right, the little text snippets, ack. [21:15] jcastro: i sent you an email about it with both the buglink if you want to post them there or you can just reply to it. [21:19] ok [21:31] jcsackett: what's the public transit like there? Can I get to the airport for 8:30am without a cab? [21:31] hatch: public transit sucks. [21:31] there are busses that aren't good. [21:32] oh haha ok so cab it is then! [21:32] hatch: there's supershuttle too. [21:32] could also try and get you to drive me... [21:32] lol [21:34] it's possible...but be warned, i may be less reliable than the busses. :-P [21:35] haha [21:43] gary_poster, I can dupe, but what's the use case? [21:43] gary_poster, also, I wasn't planning on doing the release, not comfortable doing so without a bit more understanding of the process. [21:46] The underlying problem is that annotations are received while you're dragging (the first jump) and then again a second later (from your second drag). The only possible use case I can see is concurrent editing, and we have outstanding questions on all concurrent editing stories. This was one of my interview questions, actually :P [21:58] I guess we could ignore annotation updates if we're currently dragging the service? Might be a surprise to whoever is on the other end :) "Hey! Where'd my squircle go!?" [21:59] squircle lol [21:59] * Makyo thinks out loud in a quiet IRC channel. This can't be healthy. [22:01] it's alright [22:01] hatch, yeah :) Or superellipse. [22:01] I've seen people type their passwords into #node.js when it's quiet [22:01] 800+ people staring at it for hours lol [22:01] Speaking of: http://i.imgur.com/RfAk1lv.jpg [22:01] Haha, ouch! [22:30] Makyo, understanding of release process, you mean? ack on rest, we can talk later [22:31] gary_poster, Yeah. I can try, I just worry about doing something wrong after most everyone's EOD. [22:31] Makyo, me too, though I might give it a try. The biggest challenge is the qa IMO [22:36]