StevenK | wgrant: 7000+ line diff | 05:25 |
---|---|---|
wgrant | StevenK: Exactly my point | 05:27 |
=== tasdomas_afk is now known as tasdomas | ||
StevenK | wgrant: I didn't quite eradicate all of it | 05:36 |
StevenK | wgrant: http://pastebin.ubuntu.com/5782604/ | 05:36 |
StevenK | lib/lp/services/database/doc/storm.txt, lib/lp/services/database/interfaces.py and lib/lp/services/webapp/adapter.py can be ignored since they use and/or implement it | 05:37 |
wgrant | StevenK: Right | 05:37 |
StevenK | wgrant: But killing it from test_login, xx-private-builds and testing/factory would be nice, I just didn't see how to. | 05:38 |
wgrant | StevenK: I'm confused | 05:40 |
wgrant | Why would you kill it from them? | 05:40 |
wgrant | It's not using it in the way that there are replacements for | 05:40 |
wgrant | Their usage of it is not deprecated. | 05:40 |
StevenK | Right | 05:40 |
lifeless | wgrant: StevenK: seen githubs new repository-next UI ? | 05:53 |
lifeless | no longer shows the first para of README.md at the top of the page | 05:53 |
wgrant | Yeah | 06:00 |
wgrant | And they dropped LP 2.0-style facet tabs | 06:00 |
=== wedgwood_away is now known as wedgwood | ||
=== olli__ is now known as olli | ||
=== tasdomas is now known as tasdomas_afk | ||
jtv | There's a branch here that used to be imported from sourceforge, but now the Launchpad version should become the "official upstream." How do I do that? | 16:33 |
=== matsubara is now known as matsubara-lunch | ||
=== matsubara-lunch is now known as matsubara | ||
jelmer | jtv: push up a clone of the imported branch to a new location, then change that to be the development focus, then remove the import | 19:13 |
jelmer | (the latter might be hard because of stacking, but you should be able to rename it) | 19:14 |
jtv | jelmer: OK, thanks! | 21:14 |
=== wedgwood is now known as wedgwood_away | ||
StevenK | wgrant: http://pastebin.ubuntu.com/5785333/ | 23:39 |
wgrant | StevenK: Are you in the right layer? | 23:41 |
StevenK | wgrant: Given the callsite was returning IStoreSelector.get() before I changed it, I guess the component arch is available | 23:42 |
wgrant | StevenK: Other callsites can do it fine | 23:46 |
wgrant | However | 23:46 |
wgrant | I would potentially not port that callsite. | 23:47 |
wgrant | StevenK: Look at that test | 23:47 |
wgrant | The problem is quite clear. | 23:47 |
StevenK | Hah | 23:48 |
StevenK | Right | 23:48 |
StevenK | It has to use IStoreSelector | 23:48 |
wgrant | Or the test needs to be changed | 23:49 |
wgrant | But for that level of infrastructure it makes sense to use IStoreSelector directly. | 23:49 |
StevenK | Yeah. I've reverted that back. | 23:50 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!