/srv/irclogs.ubuntu.com/2013/06/27/#juju-gui.txt

gary_posterhey luca.  I suddenly have 20 minutes free. :-) I have a few follow-up questions about your reply (whicvh I really appreciate).  Do you have a moment, or are you lunching?11:40
lucasure, guicaht?11:41
lucaguichat^11:41
gary_posterluca thanks yes11:45
gary_postersorry didn't see11:45
rick_hluca: got a sec?12:25
frankbanguihelp: I need to retrieve the env object from within a viewlet. Is there a way for viewlets to access their own viewContainer?12:30
rick_hfrankban: shouldn't the view container give the viewlet anything it needs? Pass down cfg or helpers?12:31
bacfrankban: i need to do the same thing and have modified the call to render to accept it.  hold on and i'll paste my changes12:31
bacfrankban: http://paste.ubuntu.com/5804591/12:33
rick_hbac: why not just pass in the db? Seems like this connects the two classes a lot now for testing and such?12:34
frankbanbac: very nice, thank you12:34
frankbanrick_h: how to retrieve, e.g., the env from the db then? However, perhaps we could just pass ViewContainer.options?12:37
rick_hfrankban: yea, I was seeing that. This is added to the root class vs a class that's later inheriting I guess. 12:37
rick_hfrankban: I like the idea of an optional cfg second param instead 12:38
rick_hrender(model, options)12:38
bacfrankban: but i'm passing the viewcontainer.  can't you get options and env from it?12:39
frankbansounds good, also extended to the other viewlet methods I guess. what is options? viewContainer.options?12:39
frankbanrick_h: ^^^12:39
bacfrankban: yeah12:39
rick_hbac: render(model, {db: ciewContainer.get('db')})12:40
bacrick_h: sorry i didn't see your comment12:40
rick_hfrankban: options is just a arg name. 12:40
rick_hfrankban: call it cfg, foobar, whatever. Basically a space for passing in any optional data?12:40
rick_hfrankban: I guess I'm just looking at this diff and not the big picture of how it's working. So ignore me if it doesn't apply I guess. 12:40
bacrick_h: bcsaller, hatch and i discussed this yesterday and thought it may need to be broader, but i see your point12:40
rick_hI just get twitchy when I see something getting the full instance of something else as those two classes are now tied at the hip vs something more generic12:41
frankbanrick_h: AFAICT this is a framework, our render is called for us, so I guess we must decide what to pass as second arg12:41
rick_hfrankban: right, then nvm I guess. I've not used it yet so was looking at things like a Y.View calling another Y.View where it has control over how render is called12:42
rick_hfrankban: is the init custom then?12:42
rick_hfrankban: e.g. could the viewlet be given optional init config and then it's already there for this.render()?12:42
frankbanrick_h: you can pass options to the viewContainer initializer (an Y.View). a viewlet is more a configuration object, with hooks/methods called by the viewContainer. It seems nice to me if the viewlet can receive (or store, as you suggested) those option values. I am also fine with Brad;s solution of passing the whole viewContainer, even if I guess we will be mostly interested in its options12:45
lucarick_h: I'm in a meeting now for an hour but can we catch-up after?13:01
rick_hluca: sent an email on your way. Feel free to reply to that or we can chat after your meeting. 13:02
lucarick_h: ah brilliant, cheers :)13:02
frankbanBradCrittenden, rick_h:  what I described: http://pastebin.ubuntu.com/5804671/13:02
rick_hfrankban: cool. I like that way it's limited to bits of data vs the whole class and the temtation to try to share methods/etc across. Seems less 'dirty'. 13:04
BradCrittendenfrankban: looks good13:07
=== BradCrittenden is now known as bac
teknicoanyone up for a second review of https://codereview.appspot.com/10677043/ ?13:16
gary_posterteknico, any takers?  if not, please invoke j u j u g u i :-)13:28
gary_posterluca, I don't understand this line from inspector behavior:13:29
gary_poster"You can scroll the inspector but the scroll goes underneath the dark grey divider line"13:29
teknicogary_poster: nope, proceeding with deployment of Secret Weapon13:29
gary_postercool teknico :-)13:30
gary_posterluca, and that line seems key :-)13:30
* gary_poster goes to another call, but more explanation would be great13:30
BradCrittendengary_poster: we up?13:30
=== BradCrittenden is now known as bac
bacbrb13:31
gary_posterwe are bac13:31
gary_postercool13:31
teknico`juju deploy jujugui`: anyone up for a second review of https://codereview.appspot.com/10677043/ ?13:31
gary_posterheh13:31
=== benji__ is now known as benji
benjiteknico: hi, I'll take it13:31
=== benji is now known as Guest32120
bacgary_poster: am i in the wrong place?13:32
teknicobenji: I mean, thank you ;-)13:32
teknicowhoops13:32
gary_posterbac, maybe.  1c5347001459ec985658a81e5c3a019abc715e05 ?13:32
gary_posterbac from calendar13:33
bacno, did it change with the new calendar invite?13:33
teknicobenji: thank you13:33
benjirick_h: have a minute for some browser wierdness discussion?13:44
rick_hbenji: sec, finishing up standup13:46
benjil13:46
benjik13:46
benjinow everyone knows I'm using a QWERTY keyboard13:46
rick_hdoh!13:46
gary_posterbac, you still here?14:00
teknicois anyone able to "make code-doc" successfully in trunk?14:00
rick_hteknico: nope14:01
rick_hbenji: free now, guichat?14:02
benjirick_h: I figured it out. Your contribution will be noted for posterity.14:02
rick_hwoot! I love being awesomely helpful by not attending!14:03
rick_hI guess 'by absence' would fit better14:03
gary_posterrick_h, hatch, either of you have idea on what to grep for for that yuidoc failure (http://pastebin.ubuntu.com/5804801/)14:05
gary_poster?14:05
rick_hgary_poster: looking14:07
gary_posterthx14:08
hatchgary_poster: try subapp14:16
hatcher14:16
hatchsubclass14:16
hatchjust thinking14:16
gary_posterhatch you mean grep for subclass?14:17
hatchyeah sorry14:17
hatchit's possible that the class isn't defined if ther is a subclass of juju.something14:17
hatchbrb14:18
hatchgary_poster: any luck?14:24
gary_posterhatch, if you comment this out then yuidoc stops complaining14:24
gary_posterhttp://pastebin.ubuntu.com/5804847/14:24
gary_posterbut14:24
gary_posterthen there is nothing in the yuidoc directory (if you move any old ones aside first)14:24
hatchyeah that's definitely not right14:25
hatchumm can you bisect to find the failure14:25
hatcher...14:25
hatchcheck out the last revno14:25
gary_posterI can't--more mtgs--but maybe teknico? :-)14:25
rick_hI'm looking at where the error is thrown in node_modules/yuidocjs/lib/docparser.js and it makes no sense :/14:26
rick_hconsole.log(modules) [get a nice fancy list] console.log error'ing module [it's not in the previous list...]14:26
rick_hfor some reason it's trying to find a 'juju' module but there isn't a 'juju' module file. 14:28
teknicohatch: when can we have a one-on-one about viewlet/databinding?14:28
hatchnevvvaaaa14:28
tekniconice :-)14:28
hatchok but really pretty soon14:28
hatchjust waiting for the morning rush to slow down around here :)14:28
teknicorick_h: the first doc comment gary_post3r pointed out, in apps/subapps/browser/browser.js , says "@module juju"14:29
hatchbac: are you able to make a branch and commit with that view-container update? I can if you arent' able to14:31
bachatch: frankban has come up with an alternative that looks better14:31
hatchoh? I thought that was pretty clean :) what's the alternative?14:32
bachttp://pastebin.ubuntu.com/5804671/14:32
baci haven't integrated his change yet14:32
rick_hteknico: gotcha. Yea, guess there's not really a juju module to be a part of. Ends up just a namespace. 14:32
rick_hteknico: do the docs go anywhere? 14:34
rick_hI must be blind today14:34
hatchbac: frankban hmm I don't really like that as much because then you don't have access to the viewlet for anything14:34
teknicorick_h: they should go in the top level yuidoc/ dir14:35
teknicorick_h: but it does not get created anymore14:35
abentleysinzui: Can we do a mid-imp review of https://code.launchpad.net/~abentley/charmworld/config-storage/+merge/171801 ?14:35
rick_hteknico: so I changed it to https://pastebin.canonical.com/93510/ and no error14:35
rick_hteknico: but no docs14:35
rick_hhatch: other way around? 14:36
rick_hhatch: isn't this the viewlet getting access to the viewContainer?14:36
bachatch: it gives what we need with less coupling.14:36
hatchyeah.....ok you're right I read this wrong14:36
hatchthe context will still be the viewlet14:36
* hatch goes to grab his coffee14:37
teknicorick_h: yeah, something else is amiss14:37
lucagary_poster: the divider line is the dark grey line under the "upgrade" available notification.14:37
hatchhttp://gizmodo.com/how-a-fridge-full-of-beer-that-only-unlocks-for-candian-59685835314:42
hatchrofl14:42
hatchteknico: ok want to chat now?14:43
hatchI have another call in 15 but we can probably get it done in time14:44
teknicohatch: yes please14:44
hatchguichat is open14:44
adeuringsinzui, abentley, jcsackett, rick_h could one of you review these two small MPs: https://code.launchpad.net/~adeuring/charmworld/1192559-forgotten-jenkins-results/+merge/171825 https://code.launchpad.net/~adeuring/charmworld/1192544-dont-hide-charms-with-processing-errors/+merge/17175614:47
abentleyadeuring: looking.14:47
adeuringthanks14:47
abentleyadeuring: could FailingStoreProviderResults be a function?14:49
abentleyadeuring: You're replacing a function, so that seems intuitive to me.14:50
adeuringabentley: no, when you pass a function to patch.object(), it is called during the call of patch.object()14:50
abentleyadeuring: Not in my experience.14:50
adeuringabentley: well, I tried it...14:51
abentleyadeuring: See test_store.py for some examples.14:51
* adeuring is looking14:51
gary_posterbcsaller, when you are here, could you take bug 1195354?  made card in miscellaneous14:55
_mup_Bug #1195354: Export exports relations incorrectly <juju-gui:Triaged by bcsaller> <https://launchpad.net/bugs/1195354>14:55
gary_posterteknico, is "Broken tests for pyJuju sandbox" landed yet14:55
teknicogary_poster: it is, just yet14:56
teknicomoved the card14:56
adeuringabentley: got it. I misunderstood the parameter "new"14:56
bcsallergary_poster: kapil's email said  relations:                                                                                                                                                                                                                                                                    14:57
bcsaller        - [blog, [db, memcached]]           14:57
bcsallerone line change either way I think14:58
abentleyadeuring: The changes you've made to the tests in 1192544-dont-hide-charms-with-processing-errors look wrong to me.  You should be testing that charms with errors are not hidden, not changing them to refer to store errors.  I believe the store error stuff already has tests.14:58
gary_posterbcsaller, xchat might have eaten what you said, I am afraid, but I think you are saying that this will be easy :-) .  Maybe also that you need to clarify something with Kapil?14:58
bcsallerboth those things. My orig email suggested what the bug says but he offered back that its a list rather than ':' delimited14:59
adeuringabentley: OK, having tests that charms with errors are shown make seinse. But I could not find tests for the store_error case. Maybe I missed them though...14:59
bcsallerI can do either though, like I said, one line change :)14:59
abentleyadeuring: in search.py: test_api_search_charm_with_store_error, test_search_charm_with_store_error.  In models.py, test_find_charms_default15:02
gary_posterhey hazmat, could you connect with bcsaller on list vs bug above?15:03
adeuringabentley: ok, so I'll just change the originals tests that charms with processing errors are not hidden.15:03
abentleyadeuring: +115:03
bacgary_poster: canonicaladmin for you15:04
abentleyadeuring: r=me on 1192559-forgotten-jenkins-results15:04
adeuringabentley: thanks15:04
gary_postersinzui, am I right that manage.jujucharms.com will integrate with SSO?15:05
rick_hgary_poster: it does already. The login function should work for anything in ~charmers15:05
gary_postersinzui, and are there any others on the charm side of the world that you know of?15:05
gary_posterrick_h, when I click on login, I get a 503 Service Unavailable15:06
gary_posterNo server is available to handle this request.15:06
rick_hgary_poster: hmmm wfm15:06
gary_posterrick_h, ok worked that time15:06
rick_hgary_poster: looks like new SSO layout/etc15:06
gary_posteryeah15:06
sinzuigary_poster, I am logged in15:06
gary_posterbac, accepted :-)15:07
bacgary_poster: oh, and another.  my sick day from a while bak15:07
bacback15:07
sinzuigary_poster, I just logged in15:07
sinzuigary_poster, I think the bug here is that we did not test what someone who has not role to login sees15:08
gary_postersinzui, ack works for me now as I said.  could you please add manage.jujucharms.com to bug 118496115:08
gary_posterso it gets an icon15:08
gary_posterdoe SSO15:08
gary_posterfor15:08
sinzuigary_poster, ~charmers and the m.jc.com developers can loggin15:08
sinzuigary_poster, logging in lets you do charm QA.15:09
gary_postersinzui, ack cool thanks.  my main point is that icon bug.  could you add yourself to the bug?15:09
gary_posterI mean, mj.c15:09
lucarick_h: free to talk?15:10
rick_hluca: sure thing15:10
rick_hluca: taking over guichat15:10
sinzuigary_poster, yellow/ui group appear to be the only staff that are NOT in https://launchpad.net/~juju-jitsu/+members15:11
gary_postersinzui, lol15:11
gary_postersinzui, you saw the icon bug request, right? :-D15:12
sinzuigary_poster, I think your people would be helped by membership...and I will look into what happens when you are not permitted to sign in15:12
hazmatbcsaller, re emai. those are separate services..         - [blog, [db, memcached]]    is two relations in one line.. no qualifiers.. qualifiers are done as 'service:rel_name' 15:12
sinzuigary_poster, No I didn't see it15:12
sinzuinumber?15:12
bcsallerhazmat: ah, must have misunderstood, thanks15:12
gary_postersinzui, bug 118496115:12
sinzuithank you. I will look into this.15:13
gary_posterthanks sinzui15:14
sinzuiha ha, the deploy was so fast it happened as I was testing login/logout15:15
sinzuiabentley, your login/logout link staste bug still exists and somewhat confusing when a deploy happens15:16
adeuringabentley: i updated the branch15:16
abentleyadeuring: r=me then.15:17
adeuringabentley: thanks15:17
abentleyadeuring: I had already approved it, conditional on fixing the tests.15:23
abentleysinzui: That's weird.  I couldn't reproduce it.15:25
sinzuiabentley, It happened during the rollout. It was fast. I cannot make it happen now15:26
abentleysinzui: Can we do a mid-imp review of https://code.launchpad.net/~abentley/charmworld/config-storage/+merge/171801 ?15:27
sinzuioh, and it just did... abentley. I just logged out. I had to force reload to see login again15:27
* sinzui reads15:27
teknicogary_poster: jenkins failed but it seems unrelated to my branch, can we retry?15:28
gary_posterteknico I will retry if you look at video and see if you learn anything, and maybe doc in fole. :-)15:29
gary_posterfile15:29
teknicogary_poster: oh, the video, I keep forgetting that. what do you mean by "doc in file"?15:30
teknicoI guess "document in a file anything I learn"15:33
gary_posterteknico, I was thinking like your FIXMEs15:36
gary_posterMakyo, coming to meeting sorry15:36
hatchrick_h: got a minute for a chat?15:41
rick_hhatch: rgr15:44
hatchin guichat15:44
rick_hhatch: trying15:45
Makyojujugui call in 10 kanban now15:50
abentleysinzui: how's that review going?15:56
sinzuiabentley, In the last in your branch (# This is not acceptable to Elasticsearch, because config is a list.) you demonstrate that 'e' was not found. I think it was deleted by the exception block. Should it be? If the config options is already in the right format, I would have indexed it after a no-op15:58
sinzuiOh15:59
sinzuiit was options that was a list15:59
sinzuiabentley, we have configs that that a list?15:59
sinzuido we also have configs that are a string?15:59
frankbanhatch: do you have a minute for a chat after the call?15:59
jcsackettsinzui: can i grab you to chat right after the juju gui standup? probably 15 min?16:00
sinzuijcsackett, yes16:00
jcsackettcool, thanks.16:00
teknicogary_poster: the underlying problem with the Jenkins failure is a timeout with "Charm API server did not respond", so maybe a network hiccup16:02
sinzuiabentley, I think my questions are moot. We don't support config being anything other than a dict with a single item of 'options': {}. Anything else is ignored now. your branch continues to ignore it, but we also get an exception in ingest to document the charm is bad16:03
gary_posterteknico, ah ok.  I think they had a deployment16:03
gary_posterjujugui sorry got lost in irc and mail.  coming16:03
abentleysinzui: I forget what the precise mapping issue I ran into yesterday was.  But we had something that is supposed to be a map in our format, and instead it was a list.16:03
abentleysinzui: This originally just aborted the migration, which is unacceptable.  So I handled it by swallowing the exception.16:04
abentleysinzui: But since this is a migration, any existing document would be in the old format.  So we should not retain it.  We should delete it.16:05
sinzuiabentley, understood and agreed. We let users craft the yaml by hand. I suppose proof should/does callout this issue16:05
abentleysinzui: Right.16:07
sinzuiabentley, the migration script does a print. Shouldn't it be a log because for webops to investigate.16:08
sinzuior maybe you expect webops to check the juju-log16:08
abentleysinzui: I don't think that migrate has logging enabled.  I should check that.16:09
abentleysinzui: yeah, no references to 'log' at all.16:09
sinzuiabentley, I think all stdout is captured by the juju-log. I think I saw the issue in the log when we had migration 007 bow up16:10
sinzuiblow up16:10
abentleysinzui: Right.  I meant that I don't think the migrate script has python logging enabled.16:10
sinzuiokay. I follow. That is a nice to have. I think your branch is in a good state. and +1 for documenting what a DISTRO_CHARM_DATA looks like16:11
* sinzui thinks bzr_branch leaked through, but is nice ti see as an addition16:12
abentleysinzui: Cool.  Yes, DISTRO_CHARM_DATA allows me to justify the changes to the old JSON API.16:12
abentleysinzui: Okay, can we talk about how we would re-implement migration?16:13
sinzuiyeah16:14
hatchfrankban: i'll be right back then we can chat16:20
frankbanhatch: thanks16:20
bacthanks hatch.  i had not merged from trunk and didn't have ghost-inspector yet16:20
bacto look at event handling16:20
jcsackettsinzui: want to join me in tinyurl.com/guichat?16:20
sinzuijcsackett, in a few  minutes, I am in another hangout16:21
jcsackettok.16:21
hatchbac: you'll also want to create your own object similar to the one on line 126 of ghost-inspector.js and then include it into the controller16:23
hatchyou do that by adding it to the array on views/service.js:117616:24
hatchI can outline in more detail if needed16:24
hatchfrankban: guichat?16:24
frankbanhatch: sure16:24
jcsackettsinzui: when you're free ping me and i'll send an invite; guichat was needed. :-)16:25
bachatch: i'm working on the service inspector so i think your point about adding to the array is not right16:26
bac s/right/required16:26
hatchbcsaller: are you around?16:37
hatchcan you join guichat with frankban and I16:37
bcsalleryes16:37
jcsackettsinzui: i've got to run out. i'll ping you when i'm back, see if you're free then.16:39
sinzuiokay. sorry jcsackett16:39
rick_hsinzui: ping, got a sec to chat?16:50
rick_hsinzui: jcsackett can I get reviews on this short branch please? https://codereview.appspot.com/10691043/16:56
bcsallerhatch: that did fix it :-/17:02
frankbanbcsaller: how to add that formatting function for each value in constraints? I'd like to use that to convert undefined to an empty string17:04
bcsallerfrankban: did you try using constraints as the name, I'm not sure that would work but maybe I can make that happen17:05
bcsallerbecause you're right, we don't want to have to repeat that everywhere and we don't always know all the key names in the code anyway17:06
benjirick_h: I have a charm-token-related question for you when you have a minute17:07
frankbanbcsaller: it does not work with just 'constraints', yeah it would be a nice functionality17:08
abentleysinzui: Notes on our chat: https://docs.google.com/a/canonical.com/document/d/1hYCZWzTdtyv9IfZ1wdx82COrYSMwRRfeIRkVTfNMQvw/edit17:08
bcsallerfrankban: ok, I'll look at hacking something up. 17:08
frankbanbcsaller: great17:09
jcsackettsinzui: i am back, are you free?17:12
rick_hbenji: hey, sorry I missed your ping17:15
rick_hbenji: what's up?17:16
hatchbcsaller: darn....oh well those things happen :)17:17
rick_hjcsackett: hatch can you guys peek at this short one please? https://codereview.appspot.com/10694043 fixes a bug that annoys hatch so I can earn brownie points to disagree with something else later on :P17:18
bcsallerhatch: adding support for hierarchical  bindings to deal with nested key paths. So methods on 'constraints' will be used for 'constraints.foo' if that doesn't define the method in question.17:18
benjirick_h: I want to talk about svg icons and .small .medium and .large 17:19
benjiguichat?17:19
rick_hbenji: sure thing17:19
hatchbcsaller: I'm not sure what you're saying17:31
bcsallerhatch: I can explain it in chat or show you in a bit in code17:31
hatchok ummm i'll make a hangout17:32
hatchcalling17:32
hatchnot sure if I picked the right account :)17:32
gary_posterrick_h, LGTM17:36
rick_hgary_poster: ty much17:38
rick_hjcsackett: thanks as well. You caught me trying ot make sure each test failed/passed lol17:40
rick_hI need to do better at that17:41
hatchoh man there is a lot of drama around X and MIR17:52
rick_hhatch: welcome to canonical17:52
hatchwhy are people so resistant to change haha17:52
jcastrook fellas17:53
hatch"RAWR don't event attempt improve my linux RAWR"17:53
jcastroso the drag and drop is pretty much awesome17:53
hatch(thats'a how I read these comment threads)17:53
rick_hjcastro: benji is working on some browser tweaks and such to it now17:54
jcastronod17:54
sinzuihatch. All developers believe it is fine for themselves to introduce change, but distrust anyone else proposing a change that might topple their changes17:54
hatchjcastro: yes that is awesome :)17:54
rick_hjcastro: so send beer his way and hold off if something's not quite right yet17:54
jcastroI was like "ok if this doesn't land it's no big deal"17:54
jcastronow after using it it's like, why would I ever click the add button ever?17:54
hatchsinzui: lol17:54
hatchthese developers need to work on a webapp haha17:54
sinzuihatch, indeed.17:55
rick_hhowdy sinzui can you peek at https://codereview.appspot.com/10691043/ real quick and I wanted to see if you had time to chat on priority/next17:57
* sinzui looks17:57
sinzuiI do have chat time. I am all talk and no action17:57
rick_hwoot17:57
sinzui17px? are you mad. Why choose a prime number of a dimension (other than 2)17:58
rick_hit's what the ratio worked out to be going off the other images. 16.8px actually17:58
rick_h.35 * charm icon size ish17:59
sinzui17 px is a poor input when scaling images designed for 64/128/25617:59
* sinzui looks for crack pipes17:59
rick_h.35 * 48px17:59
rick_hthe large one is 57px :P17:59
rick_hand that came from UX 18:00
benjirick_h: it seems that after('render') is indeed called after render() is called, but not after it is really, really rendered by the browser.18:02
bac"17px? are you mad"  ha!18:02
rick_hbenji: oh shoot me 18:02
benjihowever, if instead of after('render', myFunc) I use setTimeout(myFunc, 1000) it works18:02
benji:/18:02
sinzuirick_h, LGTM.18:03
sinzuirick_h, my daughter only sets the volume of the TV to increments of 5. She sites a study that 57% of the population are bothered by displays that accept odd numbers. I now set the TV to prime numbers only. I like to watch her twitch.18:04
=== matsubara is now known as matsubara-lunch
hatchprime numbers only....so the tv is either very loud or very quiet? haha18:07
rick_hbenji: ah ffs, it's a race since the actual rendering is done off the same event. 18:07
rick_hhatch: go smack someone on YUI around for the widget renderer crap18:07
hatchwhat widget renderer crap?18:07
* hatch gets his pimp hand ready18:08
rick_hhttp://yuilibrary.com/yui/docs/api/files/widget_js_Widget.js.html#l57918:08
rick_h^^ wtf, why is the actual DOM rendering done off the event RENDER?18:08
rick_hI guess so they can enforce the fireOnce-ness of it...ugh.18:08
* benji hands hatch an animal print fedora.18:08
rick_hbenji: ok, hack time. 18:09
benjiyay! I get to add a setTimeout to the code base18:09
* benji greps18:09
rick_hbenji: no no no18:09
benjidarn! I'm not the first one18:09
benji:P18:09
* hatch puts my pimp hand away18:09
hatchactually that's how I'd write it too18:09
hatch:)18:09
hatchwell not exactly18:10
hatchbut close haha18:10
rick_hhatch: I think what we can do is change the event to after(renderedChange)18:10
hatchI don't know what the problem is so I can't say what to do :)18:10
rick_hbenji: http://yuilibrary.com/yui/docs/api/files/widget_js_Widget.js.html#l583 is after the actual rendering, the ATTR for RENDERED ('rendered') is set to TRUE18:10
rick_hbenji: so we can add an event watch for that, since we KNOW it's after the REAL rendering.18:11
rick_hbenji: and then do your work18:11
benjiooh, I like it18:11
benjithat'll be  this.on('renderedChanged', myFunc), right?18:11
rick_hbenji: so to watch for ATTR changes you'll have to use the event syntax renderedChange I believe18:11
* rick_h goes to dbl check attr event watch syntax18:11
* benji wonders where those docs are.18:12
hatchuse after18:12
benjiyep, after would be better18:12
benjiwell, I guess it doesn't matter in this case, but generally "after" is what I want for attribute changes18:12
rick_hbenji: yea, so per http://yuilibrary.com/yui/docs/attribute/#events looks right18:12
sinzuibac, do you have a few minutes to review these my text changes to the juju-gui charm? https://codereview.appspot.com/10698043/18:12
rick_hsinzui: ok, have tmie to chat now, sorry. benji is distracting me :P18:13
benji:)18:13
bacsinzui: y18:13
rick_hsinzui: invite on the way18:13
hatchbenji: 'on' will allow you to prevent the attribute change value, 'after' you can be sure that it hasn't been prevented by anything else18:14
hatchmind if I ask what the issue is?18:14
benjiah, that's a good point18:14
bacsinzui: in HACKING you are telling them to get the released version of the charm to start work, not the devel branch.18:14
benjihatch: this doesn't seem to work for me:18:14
benjithis.addEvent(this.after('renderedChanged', Y.bind(this._addDraggability, this, container)))18:14
bac~juju-gui-charmers is release, ~juju-gui is devel, sinzui18:15
hatchChange18:15
hatchno d18:15
benjiI need to inspect some element dimentions after they are rendered18:15
benjiah!18:15
hatchbenji: this.after('render', function() {}) doesn't work?18:15
hatchthat's kind of the purpose of the after render :)18:16
hatchevent*18:16
benjihatch: nope because that event is (apparently) fired after all the render() methods are called, not when the nodes have actually been rendered by the browser18:16
sinzuibac, I think I am asking them to hack on the dev version18:17
bacsinzui: line 22 of HACKING refers to lp:~juju-gui-charmers18:18
sinzuibac: I think that is wrong then18:18
bacyeah, i think so18:18
hatchbenji: I don't think so, reading the code here18:18
hatchare you sure you used 'after' and not 'on'18:18
hatchafter fires /after/ the defaultFN is run18:19
hatchwhic is aftter the elements are in the dom18:19
benjiif I put a debugger call in the event handler I can't the elements on the screen18:19
benjiand they have no computed style18:19
benji(which is what I really want)18:19
hatchoh, I htink that's because the renderUI isn't attaching the element to the contentBox18:20
hatchcan you see if the content/boundingbox is in the dom?18:20
* benji looks18:21
hatchsorry for the q's I just want to know where the real issue lies18:21
hatchso, this.after('render', function() { debugger; });18:21
hatchthen there should be a yui3-charmtoken element in the dom18:22
benjibasically (there is more in there, than just the debugger call18:22
benjihere is the renderUI funciton: 18:22
benjihttp://paste.ubuntu.com/5805499/18:22
hatchyeah that isn't the proper place to put that18:22
hatchthat's why it's not working18:22
hatchguichat real quick?18:22
benjihatch: sure18:23
hatchcool18:23
rick_hbenji: hatch guichat? I can tell you right where this is18:23
hatchyup18:23
* rick_h just went through the widget source18:23
sinzuibac, I propose reverting my changes to HACKING.md. I think it is fine as it is.18:23
bacsinzui: yep18:24
hatchgreat chat guys :)18:36
rick_hman, that is some crazy stuff18:36
sinzuibac, sorry about the deplay. I reverted the HACKING.md changes: https://codereview.appspot.com/1069804318:58
=== matsubara-lunch is now known as matsubara
hatchbcsaller: reviewing19:48
hatchbcsaller: so am I to understand that by default it will always apply the child binding? and then if no child binding is applied then it'll look for a parent one?19:55
hatchthe code reads like it only applys the parent binding19:55
hatchso curious as to where the child binding is assigned19:55
bcsallerhatch: on call, one sec19:58
hatchnp I put the comment in the review19:59
bachatch, when you have a moment would you grab my branch and see if i've done anything untoward wrt events?  lp:~bac/juju-gui/inspector-settings20:00
hatchsure thing20:00
hatchchecking out20:00
hatchnow that i Know how to do diffs in bzr this is a lot easier haha20:02
hatchbac: don't use ID's - then we won't be able to have multiple inspectors20:04
bachatch: do you even know about 'bzr diff -c'?20:06
bacthat one eluded me for way too long20:07
hatchnope20:07
hatchI use bzr diff --old ../trunk --new branch-name | subl (to pipe to sublime)20:07
bac'bzr diff -c 500' shows you the diff of what was changed in rev 50020:07
hatchohh that's cool but I usually commit to much for that and want to diff from trunk20:07
bacif you're using lightweight checkouts that can be shortened to: diff -r ancestor::parent20:08
hatchohh cool!20:08
hatchI think I am using light weight checkouts because they check out pretty fast20:09
hatchbac: if you're going to change var dd = to var _ = you can just delete the var assignment20:09
bachatch: but then the linter complains20:09
hatchoh I didn't know that20:09
hatchalright20:09
bacyeah "Don't use new for side effects"20:10
bacwhich is what we're doing20:10
hatchyeah I suppose that's....sort of valid heh20:10
hatchok so your code looks good with the exception of the id's20:10
bachatch: so you're suggesting replace the id with a one-off class?20:10
hatchyup20:11
baccool20:11
hatchid clash bugs are damn near impossible to track down hah20:11
benjirick_h and hatch: the "set the dragImage when the drag starts" approach worked!20:25
hatch^5!!!!!20:25
hatchthats the best approach yet! :)20:26
benjiI'm a little surprised it worked because the drag is already happening at the point.  But I'm glad it worked.20:34
benjiNow I just have to rework all the tests and figure out if I can fix chromium's crazy clipping of the category and generic icons.20:35
hatchI am surprised as well for the same reason, can't wait to see the code :)20:39
hatchcmd+w and cmd+s are way to close to eachother20:49
bachatch, benji, bcsaller: I'm going to have to turn-over my critical card (OSCON: Build service settings inspector page) since I'll be out until Tuesday.  Would one of you put your face on it to at least ensure someone takes it?  I can do a call later if anyone volunteers.21:00
hatchbac: what do you anticipate the time to complete to be?21:01
hatchI 'might' be able to pick it up but I'm also out monday21:01
benjibac: I'm afraid I have to run, but if you don't get any other takers you can send me an email with the brain-dump and I'll adopt it.21:01
bacbenji: thanks21:01
bachatch: another day?  the config file control and the expose section are undone21:02
hatchahh ok21:02
hatchwell I can probably take it then21:02
bachatch: feel free to pawn it off on benji or someone else.21:02
hatchpending no more odd issues with the current thing I'm working on21:03
rick_hbenji: yay!!!!!!21:03
bacfat chance21:03
hatchlol21:03
bacok, kthxlater21:03
hatchrick_h: HTC released the source for the One Google Edition yesterday and someone has already compiled it into a usable rom so you can get native android on a HTC One :)21:05
rick_hhatch: cool21:06
hatchthat was the only thing holding me back from buying a new phone21:06
hatchsoooo HTC One next week possibly? :)21:06
hatchhttp://forum.xda-developers.com/showthread.php?t=234139521:07
rick_hContract End Date: 12/15/201321:07
rick_hI'll have to wait until the end of the year to switch my phone off verizon and go with a phone from google21:07
hatchI thought you had an N4?21:07
hatcha*21:07
rick_hhatch: no, galaxy nexus21:07
hatchahh, well by then the new N4 will likely be out21:08
hatchbut not on a contract so it'll probably cost you $400 or something21:08
rick_hyea, hoping to buy the phone straight out and move to a GSM carier 21:08
hatchwe used to be CDMA here but they recently switched to GSM and it's been awesome21:10
rick_hyea, all good. I'll have held onto the GNex for 2 full years and ready to spend $$ for my own phone and hopefully save some $$21:10
hatchunfortunately on my carrier you don't get a discount if you don't get a phone21:10
rick_hI'll keep my verizon mifi though. <3 the LTE and network. Figure worst case I'll use that to help my phone with coverage on a smaller carrier21:10
hatchso might as well get a sub'd phone and root it21:10
rick_hright, why I have to switch carriers. 21:10
rick_hI'm not sticking with verizon. 21:10
hatchthe plan I'm on http://www.sasktel.com/search/controller/_/R-Product_Services_Talk%26%2344%3B_Text_%26amp%3B_Data_Plans the Ultimate 6521:12
hatchpretty good plan imho21:12
hatchhttp://techcrunch.com/2013/06/27/immigration-reform-passes-senate-house-leadership-calls-bill-a-pipe-dream21:18
hatchso.... in the Senate can do all this work to draft and write a bill, which the house then ignores and makes their own?21:18
hatchis that the typical process?21:19
hatchman I friggen love this app21:42
hatchmaybe I'm bias21:42
hatchbut it's friggen cool21:42
bcsallerhatch: got a sec to chat?21:49
hatchoui oui21:49
hatchguichat?21:49
hatchbcsaller: email sent to peeps so you should get it soon22:09
bcsallerhatch: thanks22:10
huwshimiMorning22:23
hatchmorning22:24
hatchmeeting in 5?22:25
hatchjujugui weekly meeting aus edition now?22:29
MakyoIs that in guichat?22:29
huwshimiYeah, I think so22:29
hatchsure thin22:29
hatchI'm live streaming a paul van dyk set in guichat22:30
hatchso join up :)22:30
gary_posterjujugui call now :-)22:30
gary_posterbcsaller, if you can join that would be cool22:32
hatchgary_poster: maybe some combination of the two always-on-sticky-headers with the ability to accordion if wanted :)23:23
gary_posterhatch feel free to follow on in thread :-)23:24
hatchwho's Jamie? Haven't seen that name before :)23:25
hatchahhh gooooo directory23:26
hatchit's Master Chief's real name23:26
huwshimigary_poster: Ready23:34

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!