/srv/irclogs.ubuntu.com/2013/06/27/#launchpad-dev.txt

StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/bulk-eid-to-obj/+merge/171705 should address one of your concerns with export-pu-auditor02:39
wgrantStevenK: Looks pretty good, but needs a few fixes03:31
wgrantStevenK: Also, person merges03:32
StevenKwgrant: Person merges?03:38
wgrantStevenK: Person merges03:39
wgrant.03:40
StevenKwgrant: Repeating yourself does not help with more context/03:43
StevenKs/\//./03:43
wgrantStevenK: Person merges!03:46
wgrantHow do they interact with your branches?03:46
StevenKwgrant: In terms of the eid branch, we can't do anything. If a person is converted to an eid and stored in auditor, and then merged into person, we will return the first person because we store by id03:47
wgrantWhy can't you do anything?03:48
wgrantThere's a well-defined successor to a merged person03:48
wgrantperson.merged03:48
StevenKUgh03:49
StevenKWhy can't we have simple things03:49
StevenKThis function already hurt my brain, and then I had to twist it to the side to understand your issues about its duplication, and now I have to deal with person merges.03:50
wgrantWhat duplication?03:50
StevenK"These are redundant. type_ids[foo] is just obj_id_to_eid[foo].keys()."03:51
wgrantOh, that thing03:51
wgrantDo you understand now?03:51
StevenKYes, I've fixed it.03:51
wgrantThey are equivalent, except that type_ids[foo] has duplicates03:51
wgrantRight03:51
StevenKTests even pass.03:51
StevenKwgrant: http://pastebin.ubuntu.com/5803604/03:52
wgrantAh03:53
wgrantNow that has a slight behaviour change03:53
wgrantWhich you probably want a test for03:53
wgrantWhat happens when you ask for an ID that doesn't exist?03:53
wgrantIn the current version on LP it will give you None03:53
wgrantIn your new version it will omit the key03:53
wgrantIn another version it may crash03:53
StevenKYeah, that was probably why I had it at the top, but you complained.03:54
wgrantAlso, scheme is annoying03:54
wgrantI'd say something like "instance, cls, id = eid.split(':')"03:54
wgrantI think that's what they are03:54
wgrantBut I can't tell right now, because scheme is rather opaque :)03:55
wgrantStevenK: I think omitting them from the response is probably best, so your new behaviour is correct03:55
wgrantBut we likely want a test for that03:55
wgrantSo we don't accidentally start crashing if an object disappears03:55
StevenKBut then auditor client will ask for them and then give KeyError03:56
wgrantIsn't this on the other side of auditorclient?03:56
wgrantWe're parsing its responses03:57
wgrantNot giving it things to ask for03:57
StevenKYes, we're parsing its responses03:57
StevenKSo, we get back lp:PackageUpload:6 as the eid for obj03:58
StevenKThen the auditorclient calls enterpriseids_to_objects() and it omits lp:PackageUpload:6 because it doesn't exist. It then tries to map it to an object and crashes03:58
wgrantYes04:00
wgrantBecause enterpriseids_to_objects cannot know what behaviour the callsite wants04:00
wgrantIt has to be the callsite's responsibility to handle a missing object04:00
StevenKOh, I can use get anyway04:00
wgrantOf course04:01
wgrantThat's probably the correct course of action for that particular case04:01
StevenKwgrant: http://pastebin.ubuntu.com/5803623/04:04
StevenKIn terms of person merges, I have NFI04:06
wgrantStevenK: existant isn't a word, and that assertEqual formatting is odd, but otherwise that looks good04:08
wgrantPerson merges don't belong in this branch04:08
=== tasdomas_afk is now known as tasdomas
StevenKwgrant: That MP is updated.04:19
wgrantStevenK: k04:23
StevenKwgrant: http://pastebin.ubuntu.com/5803648/ should resolve another of your export-pu-auditor issues04:24
StevenKOh, I didn't drop scheme04:25
wgrantI'd also prefer those two maps to be renamed as I said in my first comment, but it's at least a bit less confusing now04:26
StevenKwgrant: scheme death, and maps renamed: http://pastebin.ubuntu.com/5803653/04:28
wgrantRight04:30
StevenKwgrant: One more with feeling for that MP.04:39
StevenKGAH04:41
StevenKYUI 3.10.3 was released 2 days after 3.10.204:41
wgrantAny notable fixes?04:42
wgrantWe don't care about tracking the x.x.1 increments unless they have relevant fixes04:42
StevenKwgrant: The .swf vuln fixed in 3.10.1 snuck back into .204:42
StevenKSo they fixed it again for .304:43
wgrantHah04:46
StevenKI don't think we serve any of the two swfs in our build tree04:47
StevenKBut convoy will probably return them if asked04:47
StevenK3.11 looks to have some nice speedups, too04:48
* StevenK waits for YUI 3.11 JavaScript for Workgroups04:48
StevenKwgrant: Do you approve of the auditorclient diff?05:35
wgrantStevenK: Sounds reasonable05:43
ttxwgrant: applied your requested fixes, except the use of ISpecificationTarget, see my comment at https://code.launchpad.net/~ttx/launchpad/lp1193389/+merge/17149109:42
=== BradCrittenden is now known as bac
=== BradCrittenden is now known as bac
=== benji__ is now known as benji
=== benji is now known as Guest32120
=== wedgwood_away is now known as wedgwood
=== tasdomas is now known as tasdomas_afk
=== matsubara is now known as matsubara-lunch
=== matsubara-lunch is now known as matsubara
=== wedgwood is now known as wedgwood_away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!