| hatch | kewl single inspector stuff is done with a config factory | 00:02 |
|---|---|---|
| gary_poster | hey luca. when you have a moment, I'd love to have a hangout with you on the scrolling behavior. it sounds like you have something in mind that I will like a lot, but I just don't understand it yet. | 12:41 |
| luca | gary_poster: sure, I'll hopefully be free in a bit, trying to get the service blocks done | 12:43 |
| gary_poster | cool thanks luca | 12:43 |
| gary_poster | arosales, we still need to actually release the GUI so the contest's export instructions work. Please let me know ASAP when you all have verified that it works as you need, so we can start the qa for making a release | 12:59 |
| rick_h | gary_poster: it looks like the updated staging isn't updating the css. I'm not getting my changes for the related charms stuff on there atm but it shows up in trunk and works locally. | 13:43 |
| gary_poster | rick_h, hm, ok, I'll dig for a sec | 13:44 |
| gary_poster | rick_h, poking at things and not sure what to look at to see if I did anything. :-) what do I check? | 13:48 |
| rick_h | gary_poster: so a manual force would be to rm build-shared/juju-ui/templates.js && make build-shared/juju-ui/templates.js | 13:50 |
| luca | gary_poster: did you want to discuss scroll bars? | 13:50 |
| gary_poster | rick_h, but what do I need to look on uistage at verify that the update happened? | 13:50 |
| gary_poster | luca, on call for the next 39 min. Will you be available then? | 13:51 |
| luca | gary_poster: sure | 13:51 |
| gary_poster | thanks | 13:51 |
| rick_h | gary_poster: so the trouble. is that the juju-gui.css is out of date. I guess we can verify it's timestamp vs the lib/views/browser/*.less | 13:52 |
| rick_h | gary_poster: there should be a badge_approved_17.png in that combined css file coming from the lib/views/browser/charm-token.less file | 13:54 |
| rick_h | for a quick grep-able bit to look for | 13:55 |
| gary_poster | rick_h, ran out of time just forced. fixed on uistage? | 13:55 |
| hatch | morning | 13:55 |
| rick_h | gary_poster: yes, thanks | 13:56 |
| gary_poster | cool welcome | 13:56 |
| rick_h | morning hatch | 13:56 |
| hatch | gary_poster: re your dec email - none are showing up for me in CA - should I do it or is it broken? :) | 14:10 |
| gary_poster | hatch, we have to add them ourselves in CA | 14:11 |
| hatch | ohh ok, I misunderstood | 14:11 |
| hatch | annnnd done | 14:15 |
| teknico | you can review a 4K lines diff in about 30 seconds! great opportunity, today only, don't miss it! https://codereview.appspot.com/10746043 | 14:16 |
| hatch | teknico: can we really trust you? :) | 14:17 |
| hatch | maybe you put h4x0r code in there | 14:17 |
| hatch | *shifty eyes* | 14:17 |
| teknico | hatch: thaaat's the question, isn't it? ;-) | 14:17 |
| teknico | hatch: you have the tools to catch that, but it will turn the review into a 90 sec one ;-) | 14:18 |
| hatch | haha | 14:19 |
| teknico | hatch: thanks | 14:24 |
| arosales | gary_poster, I have tested a gui only / gui-wordpress-mysql / gui-wordpress-mysql-mongo-ceph | 14:40 |
| arosales | on aws | 14:40 |
| arosales | the yamls look correct, but I haven't yet been able to re-import with deployer just yet | 14:41 |
| arosales | gary_poster, I'll check on HP cloud this morning, and check the status of the deployer with hazmat and then sync up with your on our 1x1. | 14:41 |
| sinzui | orangesquad, I want to have another 15 minute chat in 20 minutes. We can reuse our standup hangout to discuss the big picture for July and maybe August | 14:42 |
| gary_poster | arosales, ok cool. ideally I'd wait till we have that confirmation before we release, but I may start optimistically before then so we have enough qa time before eod. | 14:42 |
| gary_poster | luca, guichat? | 14:43 |
| gary_poster | hopefully fast :-) | 14:43 |
| arosales | gary_poster, agreed, from my testing it is looking good | 14:43 |
| gary_poster | great thanks arosales | 14:43 |
| luca | gary_poster: sure, let me grab a room | 14:43 |
| arosales | thanks for delivering that in a release no less :-) | 14:43 |
| gary_poster | cool thanks | 14:43 |
| gary_poster | arosales glad to help! thanks for promoting gui | 14:44 |
| arosales | literally its our pleasure | 14:44 |
| gary_poster | :-) | 14:44 |
| hatch | gary_poster: could you do me a favour and check out my branch to see if you can actually get the error you brought up? | 14:48 |
| hatch | I thought it wouldn't work either | 14:48 |
| hatch | but I can't make it break | 14:48 |
| gary_poster | hatch on call will try | 14:48 |
| gary_poster | later | 14:48 |
| hatch | thanks - I just want to be sure I'm not missing something obvious | 14:49 |
| gary_poster | jujugui call in 10, kanban now | 14:50 |
| arosales | hazmat, on that note is there a branch I can test the deployer import on charm store charms? | 14:51 |
| hazmat | arosales, ~hazmat/juju-deployer/python-env/ | 14:52 |
| arosales | hazmat, thanks. | 14:52 |
| hatch | jujugui creating relations is broken in trunk | 14:53 |
| Makyo | hatch, works for me.. | 14:54 |
| hatch | really? | 14:54 |
| Makyo | Yes. | 14:54 |
| hatch | hmm | 14:54 |
| * hatch clears caches | 14:54 | |
| hatch | poo | 14:55 |
| hatch | looks like it's my branch and bad cache | 14:55 |
| hatch | darn and my branch doesn't appear to have any reason that would break | 14:57 |
| gary_poster | jujugui call now | 14:59 |
| gary_poster | ish | 14:59 |
| sinzui | rick_h, jcsackett, adeuring, https://plus.google.com/hangouts/_/cf491220dfb7736cee2876baf29110eeb52f5997 | 15:02 |
| Makyo | So. | 15:23 |
| Makyo | Good thing I can hear everyone. | 15:23 |
| Makyo | closer to the new style, gary_poster, just minus some styling and checkboxes. i.e. interaction. | 15:23 |
| rick_h | orangesquad: heads up that they're working on the power around here after the storms last night. Things are flickering and lost it twice now. I might come/go a bit | 15:45 |
| jcsackett | rick_h: ack. | 15:46 |
| hatch | rick_h: above ground power? | 15:52 |
| rick_h | hatch: well when I got back from the vet all the lights were out with trucks around the poles and power's gone out and hit the UPS twice so far. | 15:53 |
| rick_h | hatch: so yea...I guess it's above ground | 15:53 |
| rick_h | or it's the block's below ground, no idea. | 15:53 |
| hatch | ahh - around here the power is under ground in residential areas except where there is the transformers | 15:54 |
| hatch | usually it's those things that go in storms here | 15:54 |
| hatch | hah | 15:54 |
| hatch | ka------boooooooom | 15:54 |
| rick_h | hatch: yea, I mean they're clearly working on local power. We kept it through the storm, but a block away didn't. So I'm not sure what's up. | 15:54 |
| hatch | that video looked like it was a good storm too :) | 15:56 |
| rick_h | yea, I was surprised/happy we kept power tbh | 15:57 |
| jcsackett | rick_h: got a sec to hat on hangout? | 16:01 |
| jcsackett | s/hat/chat/ | 16:01 |
| rick_h | jcsackett: sure thing | 16:02 |
| jcsackett | gary_poster: any chance we can get the templates rebuilt/recompiled on staging? they have not, and so despite the flag being gone the share button will not render. | 16:07 |
| jcsackett | which causes other fun problems for the sharing widget, as you might imagine. :-P | 16:07 |
| gary_poster | jcsackett, tell me what command to run and I will do so. big extra points for figuring out what needs to be fixed in Makefile. I'd look but other priorities atm | 16:07 |
| rick_h | jcsackett: I'd ping bac but I don't think he's around today. I wonder if someone else has access to the staging setup? | 16:07 |
| rick_h | gary_poster: that same command you ran for me needs running. What command is the staging server running on a new version update? | 16:08 |
| rick_h | gary_poster: rm build-shared/juju-ui/templates.js && make build-shared/juju-ui/templates.js | 16:08 |
| gary_poster | rick_h, jcsackett done | 16:09 |
| gary_poster | rick_h, make build-prod | 16:09 |
| hatch | oop another make error....time to switch to grunt /troll | 16:10 |
| rick_h | hatch: well I'm guessing some command wasn't moved to the new location when staging was split up. | 16:10 |
| rick_h | hatch: as it was working well on the old url for a long while | 16:10 |
| hatch | nope this is clearly a make error | 16:10 |
| rick_h | hatch: shush | 16:10 |
| hatch | haha | 16:10 |
| jcsackett | rick_h: huh, it's not fixed. | 16:11 |
| rick_h | before you get assigned to fix it | 16:11 |
| rick_h | jcsackett: yea, looking | 16:11 |
| hatch | so my insurance company lets us renew our insurance online.....but we have to go into the branch to set up an account :/ | 16:11 |
| hatch | convenience gain.... 0 | 16:11 |
| rick_h | gary_poster: any chance the command was on the wrong checkout? | 16:12 |
| rick_h | jcsackett: can you check if the css file has all the rules in your branch that was deployed out? http://uistage.jujucharms.com:8086/juju-ui/assets/juju-gui.css | 16:12 |
| rick_h | jcsackett: I'm guessing something is missing since the share widget has the li dots on it | 16:12 |
| jcsackett | rick_h: i can, but there aren't rules to make the share button not render. | 16:12 |
| gary_poster | rick_h, http://pastebin.ubuntu.com/5808236/ | 16:12 |
| rick_h | jcsackett: right, but just checking if the file's up to date or not. | 16:12 |
| rick_h | gary_poster: thanks, will do a test here with that and see if there's a build step missing. | 16:13 |
| hatch | gary_poster: I'm going to switch to the settings page - so just let me know whwnever you have a moment to do that QA, no rush | 16:13 |
| gary_poster | thanks rick_h | 16:13 |
| gary_poster | hatch if someone else verifies for I am AOK with it | 16:13 |
| jcsackett | rick_h: looks like it. | 16:13 |
| rick_h | jcsackett: looks like it's up to date? or out of date? | 16:14 |
| jcsackett | that is to say, looks like all the rules are there. | 16:14 |
| rick_h | e.g. so the dots should be there? | 16:14 |
| * rick_h is confused | 16:14 | |
| jcsackett | they get cut off by sizing, not decoration. | 16:15 |
| jcsackett | rick_h: and again, no css rules were changed in this branch, so even an out of date css file could have all the rules. | 16:15 |
| hatch | Makyo: bcsaller either of you guys have a moment for a quick QA? | 16:16 |
| hatch | https://codereview.appspot.com/10724043/ | 16:16 |
| === frankban_ is now known as frankban | ||
| gary_poster | luca, try again in guichat? :-) | 16:21 |
| gary_poster | frankban, i privmsg'd you, in case it didn't ping | 16:21 |
| jcsackett | rick_h: what did you do? it's working. | 16:25 |
| rick_h | jcsackett: nothing atm. I don't have access to the staging server. I do see some issues though. Subapp tempaltes aren't part of the makefile's template list. | 16:26 |
| * jcsackett wonders if there's a delay between templates rebuilding us getting them, even with cache clearing... | 16:26 | |
| rick_h | jcsackett: and not sure if there's a cache on the server side? | 16:26 |
| jcsackett | rick_h: there's almost certainly a server side cache, come to think of it. | 16:26 |
| jcsackett | rick_h: probably worth filing a bug about the subapp templates in makefile's template list. | 16:27 |
| rick_h | jcsackett: trying to see if the css files are keyed in the makefile as well since ours are in a subdir | 16:27 |
| rick_h | jcsackett: yea, trying to finish tracking down bits and maybe I can get my find-fu on to fix it. /me is spoiled by zsh **/* | 16:27 |
| rick_h | I never use find any more | 16:28 |
| rick_h | jcsackett: so there's en ETAG on the js file, but that sohuld have changed/updated when the source was updated. | 16:29 |
| teknico | why use find when you can F9-c-f? ;-) | 16:29 |
| rick_h | teknico: huh? | 16:29 |
| teknico | rick_h: no midnight commander, eh? :-) | 16:30 |
| rick_h | teknico: heh, no. ls app/**/*.(handlebars|partial) | 16:30 |
| Makyo | I always forget about midnight commander until I typo `mv` | 16:30 |
| rick_h | teknico: and I don't think out Makefile will be able to run mc | 16:30 |
| rick_h | /out/our | 16:31 |
| teknico | oh, ok, missed the context | 16:31 |
| rick_h | and man I can't wait until we get to scss and can ditch this treating the css files as a template build step. Just call scss on the files in the makefile themselves. | 16:32 |
| teknico | and I'm also going to miss you all for ten days: wish me a happy Europython! :-) | 16:32 |
| rick_h | teknico: jealous! | 16:32 |
| rick_h | jcsackett: well now that it's showing make sure to let jcastro see the sexy he's been wanting :) | 16:33 |
| jcastro | yeah! | 16:33 |
| jcastro | I just realized with the oscon reveal that that means I shouldn't take videos of deploying stuff with the gui? | 16:34 |
| rick_h | jcastro: I'd say not :/ | 16:34 |
| rick_h | jcastro: http://uistage.jujucharms.com:8086/precise/ceph-11/ for your enjoyment | 16:34 |
| jcastro | rick_h: which part is different today? | 16:35 |
| rick_h | jcastro: share button | 16:35 |
| jcastro | I don't see it | 16:36 |
| rick_h | jcastro: next to add? | 16:36 |
| rick_h | jcastro: clear cache maybe? | 16:36 |
| jcastro | ah | 16:36 |
| jcastro | not in FFx | 16:36 |
| jcastro | weird | 16:36 |
| rick_h | jcastro: hmm, in FF here. Bet it's a cache issue | 16:37 |
| jcastro | k | 16:37 |
| rick_h | jcastro: ok, so the template list is incomplete and there's no actual make target on the css files so it doesn't rebuild when that's all that changes. | 16:38 |
| rick_h | oops, jcsackett ^ | 16:38 |
| jcastro | gary_poster: oh hey, that Discourse charm gui bug, I'd like to demo it at oscon | 16:43 |
| jcastro | not a hard requirement, but dang it would be awesome | 16:44 |
| gary_poster | jcastro, I figured, but we haven't gotten to it. probably no time before we have to make a release for you. will see if I can squeeze it in. | 16:45 |
| jcastro | man, this drag and drop | 16:45 |
| jcastro | I am just sitting here dragging shit into the ui | 16:45 |
| jcastro | for no reason other than just doing it | 16:45 |
| hatch | lol | 16:46 |
| hatch | out of curiosity what's the discource gui bug? | 16:46 |
| jcastro | it doesn't deploy from ~marcoceppi/blah blah | 16:46 |
| hatch | ohh the local charm thing | 16:46 |
| jcastro | no I mean from cs:~marcoceppi blah blah | 16:47 |
| jcastro | it does work fine in the uistage though. ;) | 16:47 |
| jcastro | cheatin' uistage! | 16:47 |
| hatch | haha yup | 16:47 |
| hatch | you could demo on sandbox ;) | 16:48 |
| hatch | "look how fast servers spin up with juju" | 16:48 |
| hatch | haha | 16:48 |
| jcastro | hah yeah | 16:48 |
| === matsubara is now known as matsubara-lunch | ||
| sinzui | rick_h, jcsackett, do both of you have time to join my in the stand-up hangout? | 17:06 |
| rick_h | sinzui: rgr | 17:06 |
| gary_poster | jcastro, oh, you want discourse bug fixed for *OSCON*. Yes, definitely plan on it. I read it as fixed for Monday. | 17:08 |
| jcastro | oh ok, thanks! | 17:09 |
| benji | gary_poster: [I was lunching/relocating.] Sure, I'll get those entered before my EOD. | 17:14 |
| gary_poster | benji, cool thanks. we need to countersign/countercountersign before then too. | 17:14 |
| jcsackett | sinzui: sure. | 17:14 |
| benji | gary_poster: oh, in that case I'll do it right now | 17:15 |
| gary_poster | cool | 17:15 |
| benji | gary_poster: is the target date 2014-04-01? | 17:17 |
| gary_poster | benji yes | 17:18 |
| benji | k | 17:18 |
| hatch | bcsaller: do we know what charm data is provided by default by the delta? | 17:20 |
| bcsaller | hatch: I *think* its just the reference id by default in the service data, I'd have to check | 17:22 |
| bcsaller | hatch: I think we use that Id to then go to one of the charm store apis, where that is currently the old one | 17:23 |
| hatch | alright so when we get a delta to create a new service we should go pull the charm data, then show the service in the UI | 17:24 |
| hatch | then we can get rid of the charm.loaded flag | 17:24 |
| benji | gary_poster: https://www.youtube.com/watch?feature=player_detailpage&v=ReJ3RltihME#t=309s | 17:25 |
| benji | I'm ready for simultanious key turn. | 17:25 |
| gary_poster | benji, lol cool | 17:26 |
| benji | I'm both proud and ashamed that it only took me 30 seconds from thinking of that clip to finding it. | 17:27 |
| gary_poster | heh | 17:27 |
| gary_poster | benji, I don't have it. I think allhands is having issues. I'll send an email to P&C about it | 17:27 |
| benji | :/ | 17:27 |
| gary_poster | thank you for entering | 17:28 |
| gary_poster | yeah | 17:28 |
| gary_poster | four people have issues so far | 17:28 |
| benji | "Objective Sheet Submitted" | 17:28 |
| * hatch holds out hand for donations to buy faster machine to run lbox_check tests | 17:45 | |
| hatch | rick_h: I hear you just got a new machine that you aren't using :P | 17:46 |
| rick_h | hatch: hah, I use it to run my lbox_check :P | 17:49 |
| hatch | lol | 17:49 |
| hatch | maybe I can push my changes to your box | 17:49 |
| hatch | lol | 17:49 |
| rick_h | the rick_h lbox service...wonder if I could turn that into a startup | 17:50 |
| hatch | lol | 17:50 |
| hatch | I have to admit I've heard worse startup ideas | 17:51 |
| hatch | bcsaller: mind taking a peek at the new code | 17:57 |
| hatch | the charm.loaded needs to stay - at least for a follow-up to fix the charm system later | 17:57 |
| rick_h | jujugui can I get a couple of sanity checks on the small makefile change please. QA instructions included. https://codereview.appspot.com/10756043 | 18:04 |
| * benji looks. | 18:04 | |
| hatch | gary_poster: if you get a moment mind taking a look at https://codereview.appspot.com/10724043/ for a followup LGTM | 18:21 |
| gary_poster | LGTM hatch | 18:22 |
| === matsubara-lunch is now known as matsubara | ||
| hatch | thanks! | 18:23 |
| * rick_h fears his 3 lines broken benji's computer | 18:29 | |
| rick_h | broke, bah. come on EOD | 18:29 |
| benji | heh | 18:29 |
| benji | I got distracted by trying to get my tests to pass. | 18:29 |
| rick_h | benji: ah ok. I feared things were going bad. | 18:29 |
| benji | rick_h: nope, but the review is done with QA; I had a suggestion on the regex. | 18:30 |
| rick_h | benji: awesome. thanks for the suggestion. | 18:31 |
| benji | my pleasure | 18:31 |
| rick_h | gary_poster: landing the makefile update. Hopefully this fixes the issues we've seen today. Let me know if anyone runs across any others like it. /cc jcsackett | 18:33 |
| gary_poster | yay thanks rick_h | 18:33 |
| Makyo | bcsaller, or hatch, I'm having a hard time binding an event in a viewlet. Either of you have time in ~5min for a quick chat? | 18:40 |
| bcsaller | sure | 18:41 |
| bcsaller | Makyo: in chat now | 18:41 |
| hatch | Makyo: in guichat | 18:50 |
| hatch | come on by | 18:50 |
| Makyo | hatch, just chatted with bcsaller, sorry. Thanks though. | 18:51 |
| hatch | oh heh alright np | 18:51 |
| Makyo | Was defining the event on 'events', needed to be 'viewletEvents' | 18:52 |
| hatch | ahh | 19:09 |
| * hatch remembers now why he doesn't do CSS | 19:09 | |
| gary_poster | sinzui, hi. one more topic. MS asked that uistage.ubuntu.com become comingsoon.jujucharms.com when OSCON starts. May I ask you to add that to your IS coordination list? | 19:20 |
| gary_poster | sinzui, ideally uistage would redirect, but if they simply point to same machine that is OK | 19:20 |
| gary_poster | I suppose we could handle the redirect ourselves if they point to the same machine | 19:20 |
| sinzui | I think I understand | 19:21 |
| sinzui | gary_poster, anyone going to uistage.ubuntu.com -> comingsoon.jujucharms.com...and the reveal one or both domains become jujucharms.com? | 19:22 |
| hatch | do we have a card/ticket for removing all of the old unused css after the switchover? | 19:23 |
| gary_poster | sinzui, anyone going to jujucharms.com goes to stable production GUI. anyone going to comingsoon.jujucharms.com sees equivalent of current uistage.jujucharms.com:8086. (this one is different from what I said before) finally, anyone going to uistage.jujucharms.com is redirected to jujucharms.com (the stable version) | 19:35 |
| gary_poster | sinzui, we could have comingsoon turned on now | 19:35 |
| gary_poster | we could also control the uistage redirect if desired but probably better if dns points to production gui...we can implement a redirect later so that uistage actually changes the url | 19:36 |
| gary_poster | hatch no. I'll make one. | 19:38 |
| sinzui | gary_poster, so as I am asking for the current stable charm and the stable code to be deployed to what will be jujucharmscom. If webops and I see no issues, we should do the DNS change now? | 19:39 |
| gary_poster | sinzui, +1 on comingsoon DNS change now. -1 on the uistage DNS change now, but we can do that at or after OSCON | 19:40 |
| sinzui | okay. Thank you for clarifying. | 19:40 |
| gary_poster | thank you! | 19:40 |
| gary_poster | hey benji, I wanna make a release. I want your branch in it. what's the timeline? | 19:42 |
| hatch | gary_poster: thanks | 19:42 |
| gary_poster | thank you for mentioning it hatch | 19:42 |
| benji | gary_poster: I just submitted it for review; I'm looking over it before soliciting reviews | 19:42 |
| benji | s/just submitted/am submitting/ | 19:42 |
| gary_poster | ok | 19:42 |
| gary_poster | cool | 19:43 |
| gary_poster | let's try to speed it through if we see no probs | 19:43 |
| benji | sounds good | 19:43 |
| gary_poster | Makyo, did frankban hand off to you for his constraints work? | 19:44 |
| Makyo | gary_poster, yes. Still working on getting modifyUnits plugged in, though. I have events properly firing now, at least. I have his code already branched, though. | 19:44 |
| sinzui | orangesquad, gary_poster. The sun was just swallowed by a storm and I cannot hear the music over the thunder. I might loose power/net if this new house problems. | 19:44 |
| gary_poster | sinzui, ack. | 19:45 |
| gary_poster | cool Makyo thanks | 19:45 |
| benji | jujugui: I need two quick reviews so this branch can go into the pending release: https://codereview.appspot.com/10763043 | 19:49 |
| Makyo | benji, on it. | 19:49 |
| benji | thanks | 19:49 |
| hatch | benji: i'll take one | 19:49 |
| benji | thanks hatch | 19:49 |
| hatch | needs QA? | 19:49 |
| hatch | gary_poster: http://www.sublimetext.com/blog/articles/sublime-text-3-public-beta | 19:52 |
| gary_poster | hatch QA yes | 19:53 |
| gary_poster | hatch sublime, already installed but haven't done much with it yet | 19:53 |
| hatch | benji: can I request that you add this functionality to the new deploy method in trunk? | 19:55 |
| benji | hatch: you can request anything your heart desires | 19:55 |
| hatch | well...I am asking becuase if I ask for that I won't lgtm it | 19:55 |
| hatch | :) | 19:55 |
| hatch | so depends if you want the lgtm or not haha | 19:56 |
| hatch | or follow-up | 19:56 |
| benji | I think gary_poster will want it in a follow-up. | 19:56 |
| * gary_poster vites for follow-up :-) | 19:56 | |
| gary_poster | votes | 19:56 |
| hatch | alrighty then :) | 19:56 |
| Makyo | benji, LGTM. | 19:56 |
| Makyo | Closed Reitveld, will LGTM through there in a sec. | 19:57 |
| gary_poster | Oh btw Makyo did you look at those svgs from luca? | 20:00 |
| Makyo | gary_poster, Oh! Yeah! They should be fine, I think. We'll have to re-jigger some of the margins and such, but that should be relatively easy, I think. It helps that they don't have drop-shadows. | 20:00 |
| Makyo | Sorry, will email. | 20:00 |
| gary_poster | cool Makyo. May I make a card and assign you? | 20:01 |
| hatch | lol re-jigger | 20:01 |
| Makyo | Yep! | 20:01 |
| gary_poster | cool Makyo thanks | 20:01 |
| hatch | what show is that from | 20:01 |
| gary_poster | just a word for me | 20:01 |
| Makyo | It's kind of a south/south-central US idiom. Friend from CA laughed at it last time I used it. | 20:01 |
| gary_poster | etymology http://www.etymonline.com/index.php?term=jigger<shrug> | 20:03 |
| gary_poster | http://www.etymonline.com/index.php?term=jigger that is | 20:03 |
| hatch | languages! | 20:03 |
| hatch | I'm gona speak in clicks from now on | 20:04 |
| gary_poster | _The Gods Must Be Crazy_ | 20:04 |
| gary_poster | don't remember the movie but remember liking it | 20:04 |
| gary_poster | (he spoke in clicks) | 20:05 |
| hatch | oh haha | 20:05 |
| hatch | I was wondering where that was going | 20:06 |
| gary_poster | :-) | 20:06 |
| gary_poster | bushman discovers coca cola bottle; hilarity ensues | 20:06 |
| benji | the story of my life | 20:06 |
| gary_poster | lol | 20:06 |
| hatch | benji: fyi there is a conflict with trunk | 20:09 |
| hatch | in the less file | 20:09 |
| * benji looks | 20:09 | |
| benji | hatch: fixed (pushing merged branch now) | 20:10 |
| hatch | yeah it's a super small thing | 20:10 |
| hatch | benji: lgtm'd I included the issues caused by the missing deploy method in the reply | 20:14 |
| gary_poster | benji, I need to be out of here in 20 minutes, fwiw. I can do the release later this evening though. hatch, are those qa issues? | 20:14 |
| * benji reads. | 20:14 | |
| hatch | gary_poster: they are - but can only be fixed by the follow-up branch | 20:14 |
| gary_poster | :-( | 20:15 |
| hatch | unless we delay this branch to add those features | 20:15 |
| hatch | that feature* | 20:15 |
| gary_poster | ack | 20:15 |
| benji | hatch: I haven't QAed the branch after merging with trunk, are you saying that there is a new deploy method that I should be calling instead? | 20:17 |
| hatch | benji: under the flag yes | 20:17 |
| benji | ah | 20:17 |
| hatch | guichat about it? | 20:18 |
| gary_poster | hatch, this breaks the ghost inspector, but is fine outside of the feature flag? or, it doesn't break anything under the feature flag but doesn't work either? | 20:18 |
| hatch | those qa issues were under the feature flag | 20:18 |
| hatch | sorry I wasn't clear there | 20:18 |
| gary_poster | gotcha | 20:19 |
| gary_poster | and it doesn't break anything pre-existing | 20:19 |
| gary_poster | but we need those changes in order to work with the inspector, right? | 20:19 |
| gary_poster | so fine to make a release with this | 20:19 |
| hatch | work with the inspector from deploying by dragging | 20:19 |
| hatch | yes a release is fine | 20:19 |
| gary_poster | right | 20:19 |
| gary_poster | cool | 20:19 |
| gary_poster | thanks | 20:19 |
| hatch | deploy by click still works with the flag | 20:19 |
| gary_poster | cool | 20:20 |
| gary_poster | benji, you good on this? You can make a card and ask someone else to do it if you like :-) | 20:20 |
| benji | I'm cool doing a follow-up branch. | 20:20 |
| gary_poster | cool thanks benji. | 20:21 |
| * gary_poster brb | 20:21 | |
| benji | I'll also address the review suggstions there, since we are in a rush. | 20:21 |
| benji | if that ^^^ is ok with hatch | 20:21 |
| hatch | benji: yep for sure - my comments were super trivial | 20:21 |
| benji | cool | 20:22 |
| * benji lands. | 20:22 | |
| hatch | before the release is rolled someone should probably do a qa on it :) | 20:22 |
| gary_poster | hatch, was going to do that, but will be packing for trip tonight, so if you Makyo or bcsaller were willing to do the pre-release qa that would be much appreciated | 20:23 |
| gary_poster | if not I will do it | 20:23 |
| gary_poster | if you did the release that would be cool too! :-) the docs are pretty good I think | 20:24 |
| hatch | ok don't worry about it, one of us will be able to | 20:24 |
| hatch | I've never done it :) | 20:24 |
| hatch | not sure I want to go alone first time on a friday night haa | 20:24 |
| gary_poster | ok thank you. shoot me a mail telling me how far it got | 20:24 |
| gary_poster | yeah friday is not the best :-/ | 20:24 |
| gary_poster | ugh the resize is broken on the internal pages again :-/ | 20:25 |
| gary_poster | fixed at least once before | 20:25 |
| gary_poster | if not twice | 20:25 |
| gary_poster | forgot what the deal was | 20:25 |
| gary_poster | darn. I was going to talk to jeff and rick about reusing charm widget | 20:28 |
| gary_poster | hatch, guichat for 5? | 20:28 |
| gary_poster | if busy no problem | 20:28 |
| hatch | yup | 20:29 |
| gary_poster | thx | 20:29 |
| * benji waits for lbox sumbit to finish | 20:35 | |
| rick_h | gary_poster: whats up? | 20:40 |
| gary_poster | rick, hey. hatch will share evil plan. must run. :-) thanks | 20:40 |
| rick_h | k | 20:40 |
| * gary_poster runs | 20:40 | |
| hatch | rick_h: guichat plz | 20:40 |
| rick_h | hatch: can you invite me? on the tablet | 20:41 |
| hatch | sure one sec | 20:41 |
| * benji suspects lbox has frozen. | 20:44 | |
| benji | branch landed, follow-up branch began, bug filed: time for EOW | 21:11 |
| benji | Have a good weekend all. | 21:12 |
| hatch | benji: you broke the build lol | 21:36 |
| benji | 21:42 | |
| benji | hatch: I'm looking at the test failure | 21:42 |
| hatch | benji: oh ok I just started on it too | 21:42 |
| benji | I wonder how that happened. | 21:42 |
| hatch | heh thought you went already | 21:42 |
| hatch | it only fails in FF | 21:42 |
| hatch | (repeated locally) | 21:42 |
| benji | hatch: maybe I should leave you to it. Do you prefer one over the other? | 21:43 |
| hatch | I don't really know what the purpose of these asserts are | 21:44 |
| hatch | why does it 'need' to be 0 | 21:44 |
| hatch | benji: I think I have fixed it | 21:53 |
| benji | cool! | 21:53 |
| benji | I am more and more of the opinion that an assert without an explanitory comment is a bug. | 21:54 |
| hatch | yeah sometimes it's just not very clear as to why the assert is necessary | 21:54 |
| hatch | ok yup fixed | 21:56 |
| hatch | proposing | 21:56 |
| hatch | benji: if you wouldn't mind sticking around for a bit to LGTM this for me so I can at least have a single reviewer :D | 21:57 |
| benji | hatch: sure | 21:58 |
| hatch | thanks I'll ping when lbox completes | 21:58 |
| hatch | jujugui could I get some reviews plz https://codereview.appspot.com/10769043 | 22:04 |
| benji | hatch: looking | 22:04 |
| hatch | thanks | 22:04 |
| benji | hatch: oh, that's much better than what I had | 22:04 |
| benji | hatch: review done | 22:05 |
| hatch | haha well it's the same idea, just removed the cruft :) | 22:05 |
| hatch | thanks, landing | 22:05 |
| hatch | lol nice review | 22:06 |
| hatch | ok once that lands I'll QA and try and not screw up the release ;) | 22:07 |
| benji | the release docs are quite good | 22:09 |
| hatch | yeah they look like it | 22:09 |
| benji | ok, I really have to go now; bye! | 22:09 |
| hatch | cya :D | 22:09 |
| arosales | hopefully its just me but are other folks seeing the uistage load | 22:23 |
| arosales | http://uistage.jujucharms.com:8080/ | 22:23 |
| arosales | canvas and charm store nav is not coming up for me. | 22:23 |
| hatch | checking | 22:24 |
| hatch | no store, canvas though | 22:24 |
| hatch | but the store isn't at that url | 22:24 |
| hatch | did you want this one? http://uistage.jujucharms.com:8086/ | 22:24 |
| arosales | ah yes, that works better | 22:25 |
| * arosales was just looking for a working version. | 22:25 | |
| hatch | :) the 8086 is the sekrit version ;) | 22:25 |
| arosales | hatch, thanks | 22:37 |
| arosales | pwd | 22:37 |
| hatch | no problem | 22:37 |
| hatch | jujugui - is the DD supposed to work on rapi? I don't get the (+) on the cursor and it doesn't drop | 22:59 |
| Makyo | DD? | 22:59 |
| hatch | drag and drop | 23:00 |
| Makyo | Oh,. | 23:00 |
| hatch | I'm trying to do the release but I can't release it if that's supposed to work heh | 23:00 |
| bcsaller | Thats very odd as thats just a UI specific way to call deploy, no? | 23:01 |
| hatch | that's what I thought | 23:01 |
| hatch | I'm investigating now | 23:01 |
| hatch | makedragstart handler is never called | 23:02 |
| hatch | hmm | 23:05 |
| hatch | odd | 23:05 |
| hatch | dragstart is fired but it's callback isn't called | 23:05 |
| hatch | that don't make no sense mang | 23:05 |
| hatch | oh | 23:05 |
| hatch | nope that's not it | 23:06 |
| hatch | heh | 23:06 |
| Makyo | Where does createServiceInspector live? | 23:12 |
| Makyo | I can't grep quickly because I have stuff in vim copy buffer. | 23:12 |
| hatch | yup 'drop' never fires | 23:12 |
| hatch | Makyo: environment.js | 23:13 |
| hatch | views/ | 23:13 |
| Makyo | Wow, that sucks. | 23:13 |
| Makyo | Most of today's work is moot. | 23:13 |
| hatch | uh oh, why? | 23:13 |
| Makyo | Just surrounding event stuff, which got weird when I merged with trunk. | 23:14 |
| gary_poster | hey | 23:14 |
| Makyo | I'l ljust GUESS | 23:14 |
| hatch | oh hey gary | 23:14 |
| hatch | glad you're still here :) | 23:14 |
| gary_poster | so you said that dnd doesn't work with improv? | 23:15 |
| hatch | noope, the drop event doesn't fire | 23:15 |
| hatch | that's as far as I've gotten so far | 23:15 |
| gary_poster | wow that's pretty weird | 23:15 |
| hatch | yeah....I'm pretty blown away hah | 23:15 |
| hatch | if I change sandbox to true, I get a drop target, if it's false, I dont' | 23:16 |
| gary_poster | trying to dupe | 23:16 |
| Makyo | I can dupe. | 23:16 |
| gary_poster | ok | 23:16 |
| hatch | it's a D3 issue....it's makyo's fault | 23:16 |
| gary_poster | that sucks :-/ | 23:16 |
| gary_poster | lol | 23:16 |
| * hatch runs away | 23:16 | |
| hatch | haha | 23:17 |
| gary_poster | I doubt that | 23:17 |
| Makyo | Nah, not cool. | 23:17 |
| hatch | yeah actually it's in the YUI section | 23:17 |
| hatch | lol | 23:17 |
| hatch | OHHH | 23:17 |
| hatch | I KNOW!!!! | 23:17 |
| hatch | I KNOW!!!!!!! | 23:17 |
| Makyo | Do tell. | 23:18 |
| gary_poster | yeah I was kinda expecting a follow-up | 23:18 |
| gary_poster | :-) | 23:18 |
| gary_poster | and duped btw | 23:18 |
| hatch | lol | 23:18 |
| gary_poster | it drags very nicely fwiw | 23:18 |
| hatch | well my guess is that we are missing a yui module | 23:18 |
| hatch | oh wait | 23:19 |
| gary_poster | not so much wit hthe drop though | 23:19 |
| hatch | nm | 23:19 |
| hatch | nope the drop whitelist is there | 23:19 |
| hatch | damnnnnn | 23:19 |
| hatch | I was so excited | 23:19 |
| hatch | and now so let down | 23:19 |
| hatch | :'( | 23:19 |
| hatch | well darn | 23:20 |
| gary_poster | it looks so nice in the sandbox... | 23:21 |
| gary_poster | my chromium and chrome are broken for some reason :-( | 23:22 |
| gary_poster | they start flashing and wiggling | 23:22 |
| gary_poster | when I load a page with stuff going on | 23:22 |
| hatch | maybe it's checked out for the week | 23:23 |
| hatch | :) | 23:23 |
| gary_poster | heh, been that way for the whole week | 23:23 |
| hatch | benji is going to be very.....irritated | 23:25 |
| hatch | ahh getting closer | 23:29 |
| hatch | ok I lied | 23:30 |
| hatch | 'dragover' fires | 23:30 |
| hatch | so I suppose that's a little closer | 23:30 |
| gary_poster | I have a suspicion. trying to verify | 23:30 |
| gary_poster | in show_environment | 23:31 |
| gary_poster | in app.js | 23:31 |
| gary_poster | useDragDropImport: true, #this.get('sandbox'), | 23:31 |
| gary_poster | that is, I bet that something is configured in the environment that ben did | 23:31 |
| gary_poster | which benji needs | 23:31 |
| gary_poster | and assumed he already had | 23:31 |
| bcsaller | that would stop it | 23:33 |
| gary_poster | yes, hatch, bcsaller, that is the trick | 23:35 |
| hatch | haha damn | 23:35 |
| hatch | can that be on all the time? | 23:35 |
| bcsaller | so just never tested without | 23:35 |
| gary_poster | yup | 23:35 |
| bcsaller | it has to be now | 23:35 |
| gary_poster | well | 23:35 |
| bcsaller | thats the old version of a feature flag | 23:35 |
| hatch | :) | 23:35 |
| hatch | right on | 23:35 |
| bcsaller | but now its a real feature, all grown up | 23:35 |
| gary_poster | heh | 23:36 |
| hatch | good work gary :)\ | 23:36 |
| gary_poster | thanks :-) | 23:36 |
| hatch | so.....who's gona fix? ;) | 23:36 |
| hatch | I can do it in a bit then do the release pending CI | 23:37 |
| hatch | well and any other obscure issues haha | 23:37 |
| bcsaller | I have to take off in a few minutes for something or I'd offer. | 23:37 |
| hatch | alright I have nothing to do tonight so I'll git-r-dun! | 23:38 |
| Makyo | Man, this reminds me of my last job in some pretty awful ways :P Can I suggest no more Friday afternoon releases? | 23:38 |
| bcsaller | ha, have a good weekend | 23:38 |
| gary_poster | well, bcsaller, hatch, thank you. mm | 23:38 |
| hatch | Makyo: bring it up on Friday | 23:38 |
| hatch | lol | 23:38 |
| bcsaller | ouch | 23:38 |
| gary_poster | Makyo, yeah, this was a extra special request for arosales | 23:38 |
| Makyo | gary_poster, Ah, alright! I'm all for getting things out the door, just maybe not Fridays as standard practice :) | 23:39 |
| gary_poster | Makyo, huge +1 | 23:39 |
| gary_poster | would not have done this otherwise | 23:39 |
| Makyo | Old job was Fridays at 11PM, on call until Monday at 5AM. | 23:39 |
| gary_poster | heh | 23:39 |
| gary_poster | yeah | 23:39 |
| Makyo | They had the QA people sleeping on cots in the bathrooms testing in 6hr shifts. | 23:39 |
| Makyo | It was nuts. | 23:39 |
| gary_poster | wow | 23:39 |
| hatch | ok great so I'll fix that, CI, QA, release 0.6.2 | 23:40 |
| gary_poster | yeah, I was already kind of grimacing about how this might go | 23:40 |
| gary_poster | if this is the worst we've got... | 23:40 |
| gary_poster | we're lucky | 23:40 |
| gary_poster | hatch 0.7.0 pls | 23:40 |
| gary_poster | we actually have two real features that people will care about! | 23:40 |
| gary_poster | :-) | 23:40 |
| gary_poster | dnd and deployer format export | 23:41 |
| hatch | ahhh right ok cool | 23:41 |
| gary_poster | hatch other thoughts (bcsaller if you are around feel free to disagree): | 23:42 |
| gary_poster | (1) consider making card to rename importexport.js to dragdrop.js? | 23:42 |
| gary_poster | (2) consider passing the flag in to the import export module and disable the file part? | 23:43 |
| gary_poster | trying to see if it actually is separate... | 23:43 |
| hatch | 1 - agree, will make a card | 23:46 |
| hatch | 2 - not really sure why/when we would want to disable any of it | 23:46 |
| gary_poster | hatch, well tbh my first concern is that I still don't understand why the import export module needs to be there. it only has two branches to handle a drop | 23:48 |
| gary_poster | and neither of them should be used for the charm drop | 23:48 |
| hatch | hmm | 23:49 |
| gary_poster | hatch, and then my second point is that neither of those branches are actually interesting if you are not using a sandbox | 23:49 |
| gary_poster | wow, yeah | 23:50 |
| gary_poster | you can comment out all of _handleFileDrop | 23:50 |
| hatch | throwing this out there - it might be the preventeDefault/stopPropogation | 23:50 |
| hatch | in _ignore on the dragover/enter | 23:50 |
| hatch | (sorry trying to feed the dogs right now, will test soon) | 23:51 |
| gary_poster | ok trying | 23:51 |
| gary_poster | hatch, yes that appears to be it | 23:52 |
| hatch | hmm that's odd | 23:53 |
| gary_poster | hatch, so all we need to get this to work is the | 23:53 |
| gary_poster | dragenter: '_ignore', | 23:53 |
| gary_poster | dragover: '_ignore', | 23:53 |
| gary_poster | registration | 23:53 |
| gary_poster | I'd prefer to move that out of the importexprt | 23:54 |
| gary_poster | into some generic module | 23:54 |
| hatch | yeah - I would like to know why that's required | 23:54 |
| gary_poster | agreed | 23:54 |
| gary_poster | hatch, you really cool with doing this? I'll take the bullet if you need me to | 23:54 |
| hatch | nope that's fine - I don't have anything better to do :) | 23:55 |
| gary_poster | heh | 23:55 |
| gary_poster | ok hatch | 23:55 |
| gary_poster | thank you | 23:55 |
| gary_poster | I'll try to check in with you later | 23:56 |
| gary_poster | but thank you! | 23:56 |
| hatch | no problem :) have a good one | 23:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!