StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/auditorclient-timeline/+merge/17194200:57
wgrantStevenK: Does that function correctly when given multiple objects, operations or actors?01:02
StevenKwgrant: Sprinkling an assert in the multiple test: reference = None01:03
StevenKactual    = "Object: ['lp-development:Person:243653', 'lp-development:Person:243654']; Operation: ('person-deleted', 'person-undeleted'), Actor: None"01:03
StevenKwgrant: Do you want that assert left in, or you wanted to see it cope?01:04
wgrantOh, by "wanted to see it cope" you meant "wanted to see it as a one off"?01:06
wgrantI don't much care.01:06
StevenKYes, I did01:06
StevenKwgrant: Could I get a review, then?01:17
StevenKOr have you been defeated by connection limits?01:17
wgrants/connection limits/questions/01:19
wgrantStevenK: We would ideally hook into auditorclient more directly, but this will do for now01:20
wgrantI think01:20
wgrantIt might not actually work, though01:20
wgrantYou should test01:20
wgrantThe receive is also wrong01:21
wgrantThe action should finish once auditorclient returns01:21
wgrantNot once everything is dereferenced01:21
wgrantOverlapping actions are generally a bad idea01:21
StevenKwgrant: http://pastebin.ubuntu.com/5806468/01:23
wgrantStevenK: Right01:23
StevenKwgrant: Any other concerns?01:24
wgrantI don't believe so.01:25
StevenKwgrant: That MP has updated.01:33
wgrantAnd is now approved.01:39
StevenKwgrant: Thanks01:40
StevenKwgrant: Do you want to review https://code.launchpad.net/~stevenk/launchpad/export-pu-auditor/+merge/171460 then?04:11
wgrantStevenK: What happens if I reject, accept, reject, and then accept an upload?04:16
StevenKwgrant: The last event's actor will be returned04:21
wgrantStevenK: Are you sure?04:21
wgrantThere's a limit=1 on the single receive call04:22
wgrantBut that doesn't quite work for the bulk one04:22
StevenKLet me write a test04:26
StevenKwgrant: Right04:55
StevenKwgrant: Calling reject, accept, reject with 3 different users results in the following: http://pastebin.ubuntu.com/5806804/04:57
wgrantStevenK: That shows that it happens to work at least sometimes05:07
wgrantI want to know whether it *should* work, or whether that's an accident.05:07
=== joeyfreenode is now known as joey
StevenKwgrant: Adding sleeps between the reject, accept and reject also returns the same returns.05:18
StevenKWhich shows that it isn't just working due to the 2 events having the same timestamp05:18
StevenKs/same returns/same results/05:19
wgrantStevenK: That's not very strong evidence :)05:23
wgrantI'd really like to see eg. the request that goes to auditor, and the SQL behind it05:23
wgrantpostgres will often return things in insert order initially on small tables05:23
wgrantSimply because of the likely physical layout05:23
wgrantI don't see how this works reliably, so I am inclined to believe it does not.05:23
StevenKwgrant: It's auditorfixture, so it's backed on sqlite05:24
=== tasdomas_afk is now known as tasdomas
=== wedgwood_away is now known as wedgwood
=== tasdomas is now known as tasdomas_afk
=== frankban_ is now known as frankban
=== matsubara is now known as matsubara-lunch
=== matsubara-lunch is now known as matsubara
=== wedgwood is now known as wedgwood_away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!