=== asac` is now known as asac [02:18] smspillaz, ping [02:20] bschaefer: gotta go have dinner (I'm in your timezone!) but what's up ? [02:21] I can reply in like [02:21] 30 min [02:21] smspillaz, o awesome [02:21] smspillaz, cool, ill be a round for a bit :), have a nice dinner! [02:21] coolio [02:25] bschaefer: btw the thing I just proposed will fix the jumping around problem you were having [02:25] (but your branch is still relevant) [02:25] smspillaz, I just saw, and was going to start reviewing it :) [03:01] bschaefer: thanks. Please throw it at the wall and see if you can make anything break [03:01] The tests should cover most of it, but there could be some usecase I haven't run into yet [03:01] smspillaz, will do, some tests are failing and hanging though [03:02] also I was able to fix my branch to not resize it self a bunch...which is why I pinged you :) [03:02] bschaefer: ah, re: hanging tests, just wait until your system cools off and try them again [03:02] but if they are failing let me know [03:02] bschaefer: llvmpipe can hang sometimes, dunno why [03:03] smspillaz, yeah, just posted a comment, I still have some more reviewing... [03:03] im actually running in software rending mode...cause some problems with lightdm [03:04] smspillaz, if you take a look: https://code.launchpad.net/~brandontschaefer/compiz/fix-lp.892012/+merge/168519 [03:04] smspillaz, the problems I was running into was to many restoreGeo was being called [03:05] were being* [03:07] bschaefer: hmm, I think your previous approach to determining which save bits to call saveGeometry with was better [03:07] bschaefer: (although technically, it shouldn't really matter) [03:08] smspillaz, possibly..but once I added in the bits for the horz stuff it was no longer working :( [03:08] bschaefer: basically, I don't know if calling restoreGeometry with all the bits set in every case is such a good idea [03:08] in the vertical maximize case, you are still able to move the window horizontally [03:08] so when you restore it, you don't also want to restore the saved X co-ordinate [03:08] smspillaz, right, everything was working when doing V -> H -> F max [03:09] and then restoring [03:09] smspillaz, but the grid plugin does it stuff after the window.cpp stuff right? [03:09] I think it moves the window to the correct position yes [03:09] which is what controls most of the H/V positions [03:10] but that sounds like something that should be handled int the grid plugin and not core [03:10] since vertical maximization in-place is still a valid usecase [03:10] right, and they are? IIRC, at lease for the vert stuff, when you move from right vert to left vert [03:10] and restoring, its handled in the grid plugin [03:10] bschaefer: middle click the maximize button [03:10] it will maximize in place [03:10] * bschaefer needs to re-install that branch [03:11] i've been doing ctrl+super+up [03:11] bschaefer: also works [03:11] also I'm pretty sure the semi-maximize design documents specify that a 3-touch drag allows you to move the window on the horizontal axis [03:11] if you unmaximize from there, it gets restored to the original horizontal position, which is incorrect [03:12] really? Cause it seems design wants it to be at the original pos... [03:12] bschaefer: only for the "I semi maximized a window, didn't move it and then un-semi-maximized it" [03:12] (case) [03:13] smspillaz, hmm right now it restores it to its orig pos [03:14] smspillaz, i might be a bit confused on the current design docs...but sometimes when you go from semi-max to unsemi max it restores half of its position [03:15] if that makes sense... [03:15] so sometimes for Vert semi max -> Un semi max, it'll restore its X | W but leave the Y | H the same as when it was in vert semi max...but I think thats a different problem... [03:16] bschaefer: at the moment if you vertically maximize a window and then move it horizontally (which is permitted) it gets restored to its original Y and Height position but its X and Width stays the same [03:18] smspillaz, hmm at lease with my branch, which is what im on atm...allows the semi maxed window to be dragged along the X axis, leaving its Y | W| H untouched [03:18] is that expected? [03:18] same with Horz, but it just moves along the Y axis, leaving the other 3 untouched [03:19] also my branch seems to fail to restore just a Maxed window :( opps [03:22] bschaefer: yes, dragging along X / Y for V / H is the correct behavior [03:22] bschaefer: so, what I've been thinking is that you can probably get around all this from within grid itself [03:23] smspillaz, the problem is the full max isn't handled in the grid plugin though [03:23] and cool, i was just going to look at testing that on trunk compiz... [03:23] bschaefer: it shouldn't matter [03:23] smspillaz, hmm cause right now the grid plugin *knows* the orig position, the problem is I didn't see where to restore it in there [03:24] err... [03:24] restoring a full max is just like restoring from a V/H right? [03:24] bschaefer: basically - do this. When we semi-maximize a window using a keybinding, write CWX | CWWidth to window->saveMask () [03:24] which should go through the grid plugin... [03:24] and then write the x and width to window->saveWc () [03:24] (both of those return a reference) [03:25] (stupid design, yes, but you can use it to your advantage) [03:25] alright, the xwc is used when restoring [03:25] then when the window gets restored it will be restored to those positions [03:25] which is I overwrite that with the orig position...things should *restore* correctly... [03:25] bschaefer: then when the window is grabbed, use that notification in the grid plugin to unset those bits [03:25] smspillaz, cool, I like that idea a lot more [03:25] so that it restores correctly if its been moved [03:26] otherwise it restores to its original position [03:26] smspillaz, yeah, instead of jumping :) [03:26] smspillaz, cool, Ill give that a shot tomorrow! [03:26] * bschaefer has been working to long today [03:26] smspillaz, were at are in on the coast? [03:27] are you* [03:27] geez...my grammar is falling apart... [03:28] bschaefer: I'm on Vancouver Island at the moment [03:28] smspillaz, nice, thats like 3 hours away, though ive never actually been to Canada... [03:29] i hear its nice over there though === jono is now known as Guest59629 [07:12] didrocks, ready when you are [07:13] Saviq: I'm finishing a MIR review, so in 15 minutes? [07:13] didrocks, sure [07:16] MacSlow: ping [07:18] veebers, poing [07:49] who do i complain to if indicator-session was using 6G of mem? [07:52] Saviq: hey hey, sorry too longer than expected, but wanted to be completely free (of mind!) first :) [07:52] tsdgeos, charles / larsu / ted (in order) [07:52] I would have surely put ted first :p [07:52] didrocks, is fine [07:53] didrocks, so, what do we do? [07:53] Saviq: so, qtubuntu will contain only some API for the shell in the end? [07:53] or some part for apps and other for shell? [07:53] should we just have a shell QPA source? [07:53] charles: larsu: my indicator-session was making things move a bit "slow" eating 6G of RAM :D I have a screenshot as my proof, but can't give you much more info than that [07:54] didrocks, there's four parts to this - app-facing API (if any), shell-facing API, QPA plugin and server QPA plugin [07:54] Saviq: maybe you would prefer a hangout? easier to discuss? [07:54] didrocks, the last one is a new Mir thing [07:54] didrocks, I'm good either way, your call [07:54] Saviq: let's grab some water and hangout, will sned you a list :) [07:54] link* [07:55] didrocks, k [07:55] Saviq: I think if there's anything app-facing required, the SDK is a better place for it [07:57] greyback, +1 [07:57] yep :) [07:59] Saviq: https://plus.google.com/hangouts/_/92830073494505ef6a817bf10fc66b0d469a19df?hl=fr [07:59] or without fr :p [08:05] Saviq, ping [08:05] tvoss, otp [08:05] Saviq, ack [08:16] lol [08:16] i can make the thing segfault if i close it while the infographic is drawing [08:27] tvoss, pong [08:27] tsdgeos, you should never close it :P [08:27] Saviq, cc'ed you on a mail regarding accessibility [08:27] it's so preeeetyyyyy [08:27] tvoss, k [08:28] * tvoss remembers someone from big bang theory falling in love with siri [08:28] seems like tsdgeos is about to take his ubuntu phone out to a date :) [08:35] Hi @all [08:42] Ah ha! [08:42] didrocks: I re-ran indicators with 'check whole PPA' (to use my fixed, reverted unity) and check passed \o/ [08:43] sil2100, oh, are we getting stacks published finally today? ;-) [08:44] seb128: I hope so! Now re-running unity ;) [08:45] sil2100: \o/ \o/ \o/ [08:45] sil2100: nice work on the revert ;) [08:47] didrocks, seb128: btw. my ISP called some minutes ago and informed me that in around 30 minutes I'll have an internet outage for a short while due to some maintainence [08:47] sil2100: at least, they inform you :) [08:48] For the first time actually, but I guess those other times they didn't plan even ;) [08:48] Just wanted to inform everyone that smspillaz created working PPAs of Compiz 0.9.10 for Raring and Saucy [08:48] heh :) [08:48] smspillaz, thanks a lot 4 this ! [08:48] MCR, great, you should perhaps email the ubuntu-desktop list about that? [08:48] smspillaz, ^ or you [08:49] seb128, I am in the process of testing those, have to purge a few PPAs here first... [08:49] but you are right -> we should publish their existence [08:49] ASAP [08:50] I just asked here yesterday for those and do not want that sil2100 or didrocks do redundant work [08:50] by setting up additional PPAs [08:51] we have 84 bugs fixed in 0.9.10 already and a huge load of other improvements [08:51] * MCR is excited [08:53] Compiz 0.9.10 will be *awesome* [08:53] Saviq: FYI: https://code.launchpad.net/~didrocks/qtubuntu/move_android_only/+merge/171965 and seed change done [08:54] rsalveti: do you have some time to have a look at https://code.launchpad.net/~didrocks/qtubuntu/move_android_only/+merge/171965? [08:55] MCR, I hope there is not too many breakages going with it, compiz has an history to break on the right when you fix a bug on the left [08:55] seb128, no breakages expected [08:55] you never expect those [08:55] they just happen... [08:55] we have many users helping us and running trunk already [08:56] good, let's see [08:56] I will opt in for the ppa if you confirm it works [08:56] regressions have highest priority [08:56] they will get fixed immediately [08:56] * MCR hates Compiz regressions [08:56] good to know ;-) [08:56] * MCR will not allow them [08:57] what's the ppa btw? [08:57] seb128, please give me 30 minutes to test first... [08:58] k [08:58] * MCR has to edit his sources.list for PPA-purge to work, then purge 3 PPAs, then test the new one [08:58] ~30 min [08:59] MCR: the qt regression is fixed you mean? :) [09:00] qt regression ? [09:00] could you point me to the bug [09:00] ? [09:02] didrocks, here you find the list of 0.9.10 milestones: https://launchpad.net/compiz/+milestone/0.9.10.0 [09:02] Saviq: https://code.launchpad.net/~didrocks/unity-api/better-package-description/+merge/171968 btw [09:05] MCR: I'm unsure it's https://bugs.launchpad.net/compiz/+bug/1171314, andyrocks would know [09:05] Launchpad bug 1171314 in Compiz "Window stacking order messed up for dialogs/overlays" [High,In progress] [09:06] didrocks, AFAIK Sam works on that @ the moment [09:06] MCR: yeah, I think it's that one, we need to wait for the fix before releasing anyway [09:06] a branch is linked already, but not merged yet [09:10] didrocks: ready for some ACKs before I get disconnected ;p ? [09:10] sil2100: sure! [09:11] didrocks: http://10.97.0.1:8080/view/cu2d/view/Head/view/Settings/job/cu2d-settings-head-3.0publish/lastSuccessfulBuild/artifact/packaging_changes_ubuntu-system-settings-online-accounts_0.2~+13.10.20130628-0ubuntu1.diff <- settings [09:12] sil2100: ack [09:12] Do you know the shortest computer-specialist joke ? [09:12] didrocks: http://10.97.0.1:8080/view/cu2d/view/Head/view/WebCreds/job/cu2d-webcred-head-3.0publish/lastSuccessfulBuild/artifact/packaging_changes_account-plugins_0.11+13.10.20130628-0ubuntu1.diff <- webcreds [09:12] It's fixed in a minute. [09:13] didrocks: http://10.97.0.1:8080/view/cu2d/view/Head/view/Platform/job/cu2d-platform-head-3.0publish/lastSuccessfulBuild/artifact/packaging_changes_platform-api_0.18.1+13.10.20130628-0ubuntu1.diff <- platform [09:13] sil2100: good good :) [09:13] wait for the last one :p [09:13] sil2100: the latest isn't good! who dared doing it? [09:13] oh me! [09:13] sil2100: ok ack :p [09:14] :D [09:14] Saviq: is there a way of getting to the history of merged branches? [09:14] mzanetti, lp:unity/phablet [09:14] mzanetti, if that's what you mean [09:14] mzanetti, or if you mean a merge history [09:14] mzanetti, then `bzr qlog` [09:14] Saviq: no. the launcher-api merge to unity-api [09:14] ah ok [09:14] * mzanetti tries [09:15] mzanetti, and then expand the merge in question [09:15] didrocks: http://10.97.0.1:8080/view/cu2d/view/Head/view/OIF/job/cu2d-oif-head-3.0publish/lastSuccessfulBuild/artifact/packaging_changes_libgrip_0.3.7+13.10.20130628-0ubuntu1.diff <- oif [09:15] sil2100: good to me :) [09:39] didrocks, did you manage to build qtubuntu? [09:40] didrocks, http://pastebin.ubuntu.com/5807278/ [09:40] Saviq: I didn't try, see #ubuntu-touch with my phone issues (just fixed), let me look [09:40] Saviq: did you move anything? [09:41] didrocks, nope, that's a `bzr bd -S` and a subsequent `pbuild` from lp:qtubuntu with your MR merged [09:42] didrocks, checking on straight lp:qtubuntu, but feels it's gonna be the same... [09:42] Saviq: and that makes sense, I didn't change one thing (it's weird for a package with one binary to have a .install file) [09:42] didrocks, yeah [09:42] .install [09:42] Saviq: but it's not merged to trunk, right? [09:42] didrocks, no [09:42] didrocks, I was trying to confirm it works [09:43] Saviq: let me fake the arch to build on amd64 [09:43] didrocks, with my changes to the unity8 packaging things [09:43] and build [09:43] Saviq: time my phone will charge is inifinite :p [09:43] didrocks, :/ [09:43] Saviq: I really started to be afraid, it was like it was bricked [09:43] seb128, the PPA for Raring is named: "ppa:smspillaz/compiz-dev-raring" [09:44] MCR, thanks ... so it works fine for you? [09:44] now I know with this "deep hibernation" mode that you have to press for 60s the power button [09:44] I would never have found it :/ [09:44] https://code.launchpad.net/~smspillaz/+archive/compiz-dev-raring [09:44] MCR, did you try on raring or saucy ? [09:44] didrocks, I have that with my N9 - if I let it discharge completely [09:44] didrocks, it needs an hour or so on the juice just to come back up [09:44] seb128, raring -> works -> but some problems with mousepoll (investigating) [09:44] Saviq: ah, but here, even trying to recharge was rejected into that mode apparently [09:45] didrocks, mhm [09:45] so the plugins using mousepoll have problems (ezoom, showmouse, wizard) [09:45] I think I know what the problem is already [09:45] a minor issue I think [09:46] all other stuff should work [09:47] seb128, I won't be running Saucy on my main machine for now, but a PPA has been set up for Saucy as well: "ppa:smspillaz/compiz-dev" [09:48] MCR, ok [09:49] Saviq: rev 146, works well in my pbuilder (faking the arch then) [09:49] Saviq: I think we should remove the transitional package and the .install file, but that's another story [09:50] didrocks, yup [09:50] I filed bug #1195659 about mousepoll and am investigating the issue [09:50] bug 1195659 in Compiz "Regression: Compiz mousepoll plugin fails in trunk (Plugin version mismatch)" [Critical,New] https://launchpad.net/bugs/1195659 [09:53] seb128, it would be helpful if you could test the PPA also... [09:53] MCR, I'm on saucy, will do [09:53] seb128, thx [09:55] smspillaz, are you here ? [09:57] smspillaz, FYI (if you read this later): Somewhere between r3732 and r3747 we have introduced a mousepoll problem :( [09:59] didrocks, don't we need a Replaces: qtubuntu or something? [10:03] Saviq: argh, I'm totally not on my plate today, sorry :/ [10:03] Saviq: taking some medecines and fixing [10:03] didrocks, :) [10:09] Saviq: rev 148 should be finally the right one, sorry for all this, I need to take some rest/enjoy the week-end for sure to do this stupid oversee… [10:10] didrocks, that's fine [10:16] seb128, I already have the fix for the mousepoll regression [10:16] MCR, cool [10:16] preparing the MP [10:26] didrocks, this is already tested and you can trust me, but I do not want to approve it without 2 other eyes looking at it: https://code.launchpad.net/~mc-return/compiz/compiz.merge-fix1195659-mousepoll-version-mismatch/+merge/171994 [10:29] it is critical, because the missing COMPIZ_MOUSEPOLL_ABI breaks all other plugins, which need to get the actual mouse position [10:30] seb128, the fix ^^ [10:30] k [10:43] Saviq, mind taking a look at my branch while design gets back to me about some stuff? [10:43] lp:~nicolas-doffay/+junk/option-selector [10:43] What should I do about the surrounding edges etc? [10:44] Saviq, you can run /modules/Ubuntu/Components/ListItems/test.qml [10:45] didrocks, is there a tool that we could run in CI that would say "there's an ABI break here, was this intentional?" [10:46] or at least locally [10:47] mhr3: the symbol file? :) [10:47] didrocks, it doesn't check the ABI, just exported symbols afaict [10:47] mhr3: yeah, so a part of the ABI [10:48] yea, something that checks the rest? [10:48] mhr3: but ABI checker, apart from testing, I think there is nothing reliable [10:48] i know seb128 once posted a link where each lib version was checked against the previous and it gave exact breakage [10:49] i just don't remember where was it [10:50] found it [10:50] http://upstream-tracker.org/ [10:50] nic-doffay, can you just build an example into the toolkit gallery? [10:51] didrocks, mhr3: I think tvoss and lool have been looking at how we can checks ABI to assure we don't break those (or at least discussing the topic) [10:51] nic-doffay, I can't even build the toolkit... [10:51] didrocks, mhr3: not sure if that went anywhere yet, so much going on... [10:51] seb128, are we talking c++ or c? [10:52] mhr3, ^ for what component are you asking? [10:52] in general [10:52] so both [10:52] mhr3, the idea was to run the tests from version n against the libs from version n+1 [10:53] yeah, it's not a tool to detect that :) [10:53] (and that's what we are doing with integration tests ;)) [10:53] yea, that doesn't sound overly useful [10:53] mhr3, under the assumption that we have decent test-coverage that should show breakage [10:53] mhr3, why not? [10:53] tvoss, because of that assumption [10:54] Saviq, where's the toolkit gallery? [10:54] tvoss, seen http://upstream-tracker.org/versions/dee.html ? [10:54] no tests needed and it works :) [10:54] nic-doffay, ./gallery.sh [10:55] mzanetti, looks stuck, right http://10.97.2.10:8080/job/unity-phablet-qmluitests-saucy/249/console ? [10:55] mhr3, nice one, for c++, too? [10:55] if yes, we should have that tool [10:55] I have found http://upstream-tracker.org/versions/dee.html [10:56] argh, http://ispras.linuxbase.org/index.php/ABI_compliance_checker [10:56] tvoss, apparently, that's what they're using [10:57] nic-doffay, hello [10:58] Saviq: did you just kill it? [10:58] mzanetti, yes [10:58] mzanetti, didn't know you were looking :) [10:58] didrocks, mind quickly integrating http://ispras.linuxbase.org/index.php/ABI_compliance_checker [10:58] with our infrastructure? ;) [10:58] didrocks, sorry about that ^ :P [10:59] hey katie [10:59] mzanetti, looks like for some reason it used the real Unity plugin [10:59] yeah... autopilot tests are broken too... [11:01] mzanetti, ok, will debug locally - must've been the changes I made [11:02] Saviq: for both, autopilot too? [11:02] mzanetti, potentially [11:08] tvoss: well "quickly" will go as fast as all the requests we have [11:08] didrocks, it was more or less a joke :) [11:08] tvoss: I'm not sure jumping on the first project we find is a good answer, maybe open a discussion on ubuntu-devel ML first? [11:08] tvoss: so that other have maybe hints [11:08] IIRC, agateau used that one [11:09] tvoss: in fact, I wonder if we can integrate it in a way similar to symbols files, and have it run by debhelper [11:09] like you have the old .xml, the new one generated [11:09] and see if things go wrong [11:10] didrocks, that sounds good :) I need to test something real quick, back in a few ... hopefully [11:13] Saviq, after running . export_modules_dir.sh what does echo QML2_IMPORT_PATH print out for you? [11:14] "changes in calling stack, v-table changes and data-type handling" is really what miss from the symbols file. [11:14] nic-doffay, empty [11:14] nic-doffay, ah wait [11:14] nic-doffay, $PWD/modules, as it should [11:17] hmm [11:23] Saviq, after running the script from source I get this: http://pastebin.ubuntu.com/5807488/ [11:24] Saviq: ok... I fixed autopilot. works again after your changes and mine combined [11:26] nic-doffay, huh? [11:26] nic-doffay, `source export_modules_dir.sh; echo $QML2_IMPORT_PATH` [11:27] Saviq, yeah but OptionSelector still isn't available. [11:27] When I run the gallery. === MacSlow is now known as MacSlow|lunch [11:28] mzanetti, did you --overwrite or something? [11:28] Saviq: no [11:28] mzanetti, where are my commits, then... [11:28] Saviq: I made a change, wanted to push. says it diverged [11:29] mzanetti, pull first, please [11:29] Saviq: I did a merge, which merged your changes in, but somehow killed your commit [11:29] mzanetti, yeah, it merged the commits into your merge, weird that didn't require overwriting... [11:29] Saviq: yeah... I was confused too [11:29] Saviq: for the case I already have comitted changed [11:30] Saviq: is there something like pull --rebase? [11:30] mzanetti, there's no rebasing in bzr unfortunately [11:30] mzanetti, I usuall uncommit, shelve, pull, commit, push [11:30] uh... [11:30] ok... [11:33] Saviq, bzr rebase? [11:34] nic-doffay, the bzr rewrite plugin has been deprecated [11:34] nic-doffay, and I never had much luck with it [11:36] mzanetti, your change shouldn't affect qmluitests, though, right? [11:36] Saviq: nope [11:36] mzanetti, I'm not seeing why mine should, either... [11:36] unless it's simply sheer luck that it worked before [11:38] Saviq, the problem was the component wasn't added to qmldir [11:38] Saviq: hmm... they pass locall [11:38] y [11:39] mzanetti, yeah, but the ScopeView test doesn't use mocks [11:39] just saw that [11:39] we need to clean this shit up... [11:39] it's unmaintainable [11:41] mzanetti, I could have access to the qmluitests VM to check the fix? [11:41] Saviq: sure [11:42] mzanetti, or maybe I could download the VM image from somewhere? [11:42] mzanetti, and run locally? [11:43] Saviq, the Component in the gallery looks nothing like what it does when I run QML test. Some bugs coming from who knows where. [11:43] Saviq: hmm... don't think so... that takes too long, because we don't have a certain image but always use the ubuntu server install "cd" and run some scripts to set up stuff [11:43] Sorry qmlscene not test. [11:43] but those scripts run for 2h+ [11:43] mzanetti, k [11:44] Saviq: its the 76 [11:44] nic-doffay, it needs to look right in the gallery [11:44] Saviq, yeah I assumed as much. [11:44] mzanetti, "the 76"? [11:48] Ok Saviq example ready with bug I can't identify the reason behind. [11:48] lp:~nicolas-doffay/+junk/option-selector [11:48] Just run ./gallery.sh it's under OptionSelector. [11:48] nic-doffay, I won't be able to look at it for some time [11:48] Saviq, np I'll continue working on this with qmlscene. [11:49] Basically the only issue is that the labels and everything else are repeated for some reason. [11:49] This doesn't occur with qmlscene. [12:06] tsdgeos, ping [12:06] dandrader: hi [12:06] tsdgeos, hi [12:06] tsdgeos, would you have time to review this one? https://code.launchpad.net/~dandrader/unity8/ddaScenePos/+merge/171902 it's pretty straightforward [12:07] i guess i can [12:07] I've split my work into 4 palatable patches [12:07] this is the first of them [12:07] it's ok if i do it in say 2 or 3 hours? or need it now? [12:07] tsdgeos, great! thanks! [12:08] tsdgeos, anytime today is fine [12:08] oka [12:15] Saviq, Would you have time to review this really short one? https://code.launchpad.net/~dandrader/unity8/ddaDraggingFix/+merge/171904 it's only about revision 55 (http://bazaar.launchpad.net/~dandrader/unity8/ddaDraggingFix/revision/55). [12:15] * dandrader is hunting for reviewers [12:17] dandrader, you wrapped ;) === Pendulum_ is now known as Pendulum [12:20] dandrader, Saviq: I can review if you want [12:20] Saviq, erm... I wrapped what? [12:20] mzanetti, fine by me! :D [12:20] would have simple one you guys too https://code.launchpad.net/~mzanetti/unity8/edge-hinting-tweaks/+merge/172014 [12:21] dandrader, you wrapped a line in the tests ;) [12:21] mzanetti, ok you can take the vm back [12:21] Saviq: ack. success? [12:21] mzanetti, should pass with my latest commit [12:21] cool [12:21] mzanetti, yeah, it was missing an import path [12:21] mzanetti, that was added in main.cpp before [12:22] Saviq, where? I need more hints! :) [12:22] we'll see if there isn't more of that... [12:22] dandrader, the test, line 525/526 [12:22] Saviq, ah, yeah [12:23] Saviq, is that a bad thing/ [12:23] ? [12:23] dandrader, ideally we shouldn't have unneeded wrapping, but I've happroved [12:25] hmm, right. it would be 107 chars long without wrapping [12:25] which is still below the 120 limit [12:25] 106 actually [12:27] Saviq, I wonder it CI will merge https://code.launchpad.net/~dandrader/unity8/ddaDraggingFix/+merge/171904 even though its prerequisite branch isn't merged... [12:28] s/it CI/if CI [12:28] dandrader, it won't [12:28] ok. great [12:30] mzanetti, I can review https://code.launchpad.net/~mzanetti/unity8/edge-hinting-tweaks/+merge/172014 after I'm done with https://bugs.launchpad.net/unity8/+bug/1195617 [12:30] Launchpad bug 1195617 in Unity 8 "DragHandle test isn't run as part of CI" [High,In progress] [12:31] dandrader: cool, thanks [12:38] dandrader, hope it's ok I just went and assigned the bug to you, felt more trackable than trying to grab you on IRC :) [12:38] and remember about it first === MacSlow|lunch is now known as MacSlow [12:47] Saviq, well, that bug was an easy one [12:47] dandrader, I know :) [12:48] mzanetti, "pending - Waiting for next available executor on ps-saucy-server-amd64-2||ps-saucy-server-amd64-1" ← is that condition on purpose? shouldn't it include -3, too? [12:48] Saviq: no... the -3 is the one where not everything needed is installed [12:48] Saviq: good point actually... whats the state there? [12:48] Saviq: should we switch to the more empty images? [12:48] mzanetti, I thought fginther already did :) [12:49] Saviq: no, -1 and -2 are still like before and -3 is a bit too empty [12:49] mzanetti, for sure the -1 and -2 don't have libunity{-core} installed [12:49] mzanetti, 'cause we'd know ;) [12:49] mzanetti, and if not - I thought we switched already [12:49] actually I'm not entirely sure what the state is. [12:49] fginther: can you shed some light here please? [12:50] Saviq: today morning I disabled -3 again because tests were failing on it [12:50] mzanetti, mhm [12:50] startx not found and such [12:51] mzanetti, right, I thought initx was added somewhere to the job configuration to be installed? [12:52] Saviq: only in the -fginther test job. not in the production one [12:52] mzanetti, ah [13:00] mzanetti, how do I get a "locked" greeter. "./run --pinlock" (if that's the thing) doesn't seem to make any difference... [13:00] dandrader: thats a bit tricky right now [13:01] dandrader: edit run and in the if $FAKE change the LD_LIBRARY_PATH to point to "full" instead of "single" at the end [13:01] dandrader: then ./run -f [13:01] then you can drag it bigger (tablet-form-factor) and select a user with password [13:14] mzanetti, can you file a bug against ubuntu-ui-toolkit about https://code.launchpad.net/~saviq/unity8/simple-theming/+merge/171812/comments/383322 [13:15] Saviq: that question was rather, why do we use the button if we dont want to show it [13:15] mzanetti, a Button is more than just a MouseArea (or at least should / will be) [13:15] mzanetti, Saviq, I *thought* -2 and -3 were the minimal environment, but since -3 didn't working, my thinking was wrong. I just need to take the time to get them all updated and working... [13:16] mzanetti, i.e. it should also do keyboard handling [13:16] fginther: ok, cool, thanks. right now we are running on -1 and -2 and it seems to work [13:16] Saviq: right... the keyboard handling makes sense. altough I'm not sure we need keyboard handling in this place [13:16] mzanetti, not yet [13:17] mzanetti, but we will, and once we get to that point, it's better IMO to just get it for free from the SDK [13:17] Saviq: no, I mean forever... afaik no searchfield lets me put keyboard focus on the clear button in there [13:17] Saviq: that a button in general needs to do keyboard handling is clear, I agree there [13:18] Saviq: but the X in the searchfield... not sure about that [13:18] mzanetti, right, but still I think I'd rather use a Button, just as an abstraction from a MouseArea [13:18] it is, after all, a button :) [13:19] Saviq: yeah.. but open your browser (doesn't matter which one), hit Ctrl + L, Tab, Tab, Tab [13:19] you will go from address field to search field to content, not stopping at any X in there [13:19] or any other element === _salem is now known as salem_ [13:20] mzanetti, sure, that button might have keyboard handling disabled :) [13:20] so its a mouseara, isn't it? [13:20] dandrader, sorry about the draghandle noise [13:20] :P [13:20] mzanetti, no, it's a button [13:20] Saviq, that's why I said it was an easy bug :) [13:20] even if mousearea == button in that case [13:21] yeah... but why waste the resources of transparent button elements if they are not needed. and why make SDK people implement buttons that look and behave exactly like mouseareas when we could just use a MouseArea [13:22] that's my point... I see yours too... Just thinking a bit more pragmatic here instead of "the theoretically correct" way I guess [13:31] mhr3: around? [13:31] mhr3: I think intel tests are hanging [13:31] (and you have one hour free ;)) [13:31] didrocks, k, will look [13:31] and finally run my tiny script :) [13:31] mhr3: the -intel job seems hanged [13:31] mzanetti, nic-doffay, dednick standup [13:32] mzanetti, ignore [13:32] The -ati machine isn't much better, so many test failures ;/ I wonder what's wrong [13:32] mterry, standup? [13:32] mhr3: \o/ [13:32] sil2100: let's blame on mhr3? :p [13:35] didrocks, having trouble attaching to it :/ [13:35] another super leak that depleted memory? [13:36] mhr3: probably, not sure if jibel is already connected by any chance? ^ [13:37] didrocks, mhr3 I am not connected to any machine in the lab, which one died? [13:37] jibel, can't attach to the running container on intel [13:40] mzanetti, the mediumtests runner doesn't install recommends, does it? [13:40] Saviq: hmm... it probably does [13:40] mzanetti, https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/421/testReport/unity8.tests.testhud/TestHud/test_hide_hud_click_Nexus_4_/ suggests it doesn't [13:41] mzanetti, home scope not found [13:41] Saviq: it creates a local repository with the packages and does an apt-get install on them [13:41] hmm [13:41] Saviq: not sure why that would differ from normal behavior [13:41] mzanetti, yeah, shouldn't [13:42] ah that's because we're not recommending it!? [13:42] tedg: ping! [13:44] hmm am I still there? [13:45] mumble died? [13:45] Saviq: i think mumble just died [13:45] dednick, yeah looks like it [13:45] Saviq, seems so [13:45] ok THANKS GUYS! [13:45] oh well, ncie weekend everybody! [13:45] Saviq: no need to shout [13:45] greyback, I wanted everyone to hear [13:46] mumble just crashed after stand-up.. [13:46] greyback, didn't know how well that would work over IRC [13:46] lolz [13:46] paulliu, yeah, the server seems to have gone away [13:46] paulliu: me too [13:46] *sigh* [13:46] mhr3, OOM killer again. Leave the machine as it is, I'll report a bug and ping the kernel team [13:47] ok, didrocks: cc ^ [13:47] mhr3, didrocks do you need it now? If you dont I'll collect info right now otherwise, I4ll just reboot it and will report it later [13:48] I'll [13:48] didrocks, why removed the recommends of unity-scope-home and unity-lens-applications? [13:48] sil2100, Howdy [13:48] jibel: better to collect what you can I guess, I think sil2100 wanted to relaunch a test suite [13:49] didrocks, ack, give me 15min [13:49] Saviq: hum, can you be more explicit, you mean about http://bazaar.launchpad.net/~unity-team/unity-scope-home/trunk/revision/127? [13:49] ;/ [13:50] can anyone spot what when wrong in CI here? https://code.launchpad.net/~dandrader/unity8/dragHandleStretchAndHint/+merge/171908/comments/383653 [13:50] didrocks, no, I mean that you removed Recommends: unity-scope-home, unity-lens-applications from unity8 [13:51] didrocks, in https://code.launchpad.net/~unity-team/unity/unity8-packaging-cleanup/+merge/171537 [13:52] dandrader, Connecting to localhost (localhost)|127.0.0.1|:8080... connected. [13:52] HTTP request sent, awaiting response... 500 Internal Server Error [13:52] 2013-06-28 01:17:54 ERROR 500: Internal Server Error. [13:52] didrocks, too late the machine rebooted [13:52] dandrader, feels like a jenkins failure [13:52] Saviq, hmm, ok. will ask yet another rebuild [13:53] mzanetti, can you do a review of https://code.launchpad.net/~saviq/unity8/simple-theming/+merge/171812 ? [13:53] mzanetti, would be good to get in today [13:54] Saviq: yeah.. I still disagree on the button vs mousearea thing. the rest looks good to me. But I will test it once I'm done with my current task [13:54] mzanetti, thanks [13:55] mzanetti, about the disagreement... file a bug with ubuntu-ui-toolkit and we'll see where we get [13:55] sil2100, mhr3 ap machines are all yours as all evidences of memory problems have been wiped with the reboot. Ping me when it happens again [13:55] Saviq: ok [13:56] didrocks, lost you? [13:57] didrocks, shall we recommend the master scopes thing instead? [13:58] didrocks, somehow unity8 (or -autopilot) needs to pull in the home scope [13:58] Saviq: there are some master scopes change instead, I'm just trying to find the right commit [13:59] Saviq: yep, so I would recommend we do a similar one than for unity7 [13:59] having that perl parsing the master scope definition file [13:59] (I was in the middle of this transition and was interrupted when doing it) [14:00] didrocks, then we should have a special client-scopes.json for phone [14:00] ehm, for unity8 :) [14:00] yep, does it makes sense to you mhr3? [14:00] sure [14:00] mhr3: you did approve my libunity branch, right? [14:00] didrocks, yep [14:00] didrocks, r3182 in lp:unity? [14:01] didrocks, just not sure how to do the magic in libunity, we now need the same file installed and put it in two separate binary pkgs [14:01] mhr3: well, we can provide the definition and have the conflict [14:01] mhr3: so just installing on or the other [14:02] didrocks, buuut... the list for unity8 is different than for unity7, does that work? [14:02] Saviq: yep :) [14:02] didrocks, yea, pkg-wise sure, but upstream-wise i'm not sure how it'll look [14:02] Saviq: we are going to produce another json file [14:02] mhr3: a configure flag? :p [14:02] didrocks, ok, I'm in your hands, whatever you say :) [14:03] didrocks, can we rename files in the .install file? [14:03] didrocks, would prefer to just have client-scopes-desktop.json and client-scopes-phone.json, and rename them when putting into the pkg [14:04] mhr3: we can do that! I'll charge more though :) [14:04] Saviq: ok, doing the libunity side, then yours ;) [14:04] didrocks, thanks [14:04] didrocks, ok, thx [14:05] mhr3: want some help or you do the first proposal and I continue on this? [14:06] didrocks, ok, i'll do the phone-specific .json [14:06] should have a mail somewhere with the scopes that we want there [14:07] tedg: what do you think? Is it safe to release the indicators stack without unity? [14:07] Saviq: it will be more flexible, I can prepare the unity8 side meanwhile [14:07] and it's Friday, I can touch perl :p [14:09] sil2100, I can't think of anything we're changing that should effect Unity. [14:14] didrocks, should be it http://paste.ubuntu.com/5807887/ [14:15] didrocks, i mean this one http://paste.ubuntu.com/5807892/ :) [14:15] mhr3: you don't rename client-scopes.json to client-scopes-desktop.json ? [14:16] didrocks, i'd rather keep it, so source install works too [14:16] mhr3: ok, but client-scopes-phone.json will need to be renamed to client-scopes.json, right? [14:16] didrocks, yep [14:17] mhr3: ok, mind pushing that somewhere? I'll handle the packaging change [14:17] didrocks, feel free to change the name if it'll make things simpler [14:17] I'm fine with those :) [14:18] need to overwrite my branch cause pstolowski didn't ack my test changes yet (nudge, nudge) :P [14:19] :p [14:19] didrocks, lp:~mhr3/libunity/phone-scopesjson [14:19] mhr3: thx! [14:19] https://code.launchpad.net/~mhr3/libunity/phone-scopes-json [14:19] weird, terminal lost a dash [14:20] I noticed :p [14:21] dednick, since you've already reviewed the DragHandle, you're probably the best candidate for reviewing this one: https://code.launchpad.net/~dandrader/unity8/dragHandleStretchAndHint/+merge/171908 [14:21] dednick, the DirectionalDragArea changes that might show up if the diff belong to other merge proposals === dandrader is now known as dandrader|afk [14:22] dandrader|afk: pushed the tests... that was a nasty thing :D [14:25] dandrader|afk: what does stretch do? [14:27] sil2100: just to confirm, no unity stack release today, right? [14:28] * didrocks needs to edit libunity changelog [14:30] I've a problem playing with the model... [14:30] basically I am at index 0, and I want to prepend an item (insert at index 0) [14:31] I want to do this only when I am at index 0 [14:31] so basically it's: if index == 0, model.insert (0, …) [14:31] but I believe that it then switches to this new item inserted and loops [14:32] mhr3: hum, can't build your branch [14:32] UnityExtras-7.0.gir:-1: In PreviewPlayer: error: type reference 'ExtrasPreviewPlayerClass' not found [14:32] didrocks: I guess... well, I re-ran unity right now and it *would* be nice to release it (as otherwise we'll have to run indicators with 'check with whole PPA' all the time to dodge the autopilot showdesktop issue) [14:32] didrocks, valac-0.18! [14:32] i mean, use that ^ [14:32] But it all depends on whether we get some nice results this time ;/ [14:33] mhr3: I hate vala, reconfigured to use it [14:33] sil2100: hum, we'll maybe have some changelog conflict, let's see [14:33] didrocks, how so? doing vala patches in debian is sooo much fun! ;) [14:33] :p [14:35] Saviq: this has not been merged yet: https://code.launchpad.net/~fboucault/ubuntu-ui-toolkit/simple_theming/+merge/171645 [14:35] mzanetti, doesn't have to [14:35] mzanetti, we're effectively removing the theming we used (which wasn't much) [14:35] Saviq: ah right... only the other one needs to be merged before ours [14:35] Saviq: ok... good [14:38] there it was again [14:38] indicator session at 4G [14:38] mhr3: https://code.launchpad.net/~unity-team/libunity/phone-scope-json-definitions/+merge/172049 [14:42] mhr3: https://code.launchpad.net/~didrocks/unity/change-libunity-common-dep/+merge/172052 [14:44] Saviq: bug reported: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1195764 [14:44] Launchpad bug 1195764 in Ubuntu UI Toolkit "[Button] There should be an AbstractButton" [Undecided,New] [14:44] mzanetti, cheers [14:44] Saviq: I don't think that will have any impact on our discussion whether we should use it or not. because th requested one in this bug still handles keyboard focus etc while we would disable even that [14:44] Saviq: anyways, I tested and approved the merge [14:45] and I have to go now. Have a nice weekend! see you all on Monday [14:45] didrocks, shouldn't unity dep on the virtual pkg? [14:45] mhr3: not for build-deps [14:46] there will be nothing "preparing the env" on the buildds [14:46] mzanetti, o/ [14:46] mzanetti, have fun, thanks [14:46] didrocks, ah, the diff doesn't show it's build-deps [14:47] Saviq: ok, pushed rev 77 to ~unity-team/unity/unity8-packaging-cleanup, will be only ready once https://code.launchpad.net/~unity-team/libunity/phone-scope-json-definitions/+merge/172049 is merged in [14:47] didrocks, libunity acked [14:47] mhr3: thanks :) [14:47] so now? ;) [14:48] mhr3: wait for it to be merged :p [14:48] mhr3: please review unity to not explode on Monday ;) [14:48] mhr3: Saviq: I still think it's not the full convergence story yet (we need to ship both files and generate the recommends based on packages), but I need to give it more thought and I think we need to find a way to still ship both definition files for building [14:49] right now, let's focus on unity7 -> desktop, unity8 -> phone, and think about it clearly on Monday :) [14:49] didrocks, sure [14:49] mhr3, commands.scope for the phone? ;) [14:50] Saviq, oh seb128 didn't inform you? phone has to support alt+f2 :) [14:50] mhr3, ;) [14:50] Saviq, but don't worry those will be the only buttons on the phone [14:51] fginther, did you hook up the cleaned-up VMs? https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/257/console :) === dandrader|afk is now known as dandrader [14:52] fginther, you're on it, AFAICS [14:53] Saviq, looking... [14:54] dednick, instead of moving the parent, it stretches it (changes its height) [14:54] dednick, try it out with make tryDragHandle [14:55] dednick, there are two buttons yellow on the lower left corner [14:55] Saviq, yes, that VM wasn't ready to go yet :-(. I've removed it from the job until I get it fixed [14:55] dandrader: i c [14:55] fginther, thanks [14:55] dednick, to enable/disable hinting and switch between move and stretch modes [15:02] dpm: ping [15:02] or mhall119 ping [15:04] jibel: hm, unity otto check jobs failed to start: [15:04] http://10.97.0.1:8080/job/autopilot-saucy-daily_release/266/label=autopilot-ati/console [15:04] jibel: will a re-run help? [15:04] dpm: hi! Really sorry for the libunity release delay ;/ [15:05] sil2100, try a re-run if it fails I'll have a look [15:08] Saviq, do you know where/how the grid unit value is calculated? [15:10] dandrader, it's set per-device [15:10] mzanetti, the trailing whitespace in tst_Launcher.qml line 156 is still there [15:24] seb128, any regressions found ? [15:24] sil2100, want some free Compiz karma ? [15:25] ! [15:25] Free karma? Always [15:25] ;) [15:25] sil2100, https://code.launchpad.net/~mc-return/compiz/compiz.merge-fix1195659-mousepoll-version-mismatch/+merge/171994 ;) [15:26] sil2100, it is tested -> you can close your eyes if you like [15:26] MCR: it looks really sane, so approved [15:26] MCR, I didn't have time to try yet [15:27] sil2100, do you know about the PPAs already ? [15:27] I do not remember when you disconnected [15:27] seb128, k [15:32] sil2100, regarding Compiz: more than 80 bugs fixed, countless other improvements are to be found in these PPAs: https://answers.launchpad.net/compiz/+question/229711 [15:34] && thx 4 the approval, btw ;) [15:41] Saviq: do you know if there's a way to create an enumeration type in qml? [15:42] dednick, unfortunately there isn't [15:42] dednick, look at notification.js in tests/qmltests/Unity/Notifications, though [15:42] dednick, that's the only way to fake one [15:43] Saviq: will that be in the Unity.Nofication namespace? [15:45] dednick, Unity.Notifications.Notification [15:46] dednick, Unity.Notifications.Notification [15:47] Saviq: ta. might be able to fudge mine the same way [15:47] dednick, it only helps if it's the only thing you need from the component [15:48] Saviq: yeah. just realised it's not. i need it to be in the model [15:48] Saviq: might just move the enums into a sep class which is imported by the tests. [15:48] dednick, if it doesn't cause conflicts, sure [15:53] mhr3, shouldn't that say client-scopes-phone.json? http://bazaar.launchpad.net/~unity-team/unity/unity8-packaging-cleanup/revision/77/debian/rules [15:53] Saviq, nope, the packaging renames it [15:53] mhr3, ah k [15:54] mhr3, how does it know which of the two to install? [15:55] Saviq, they are in two separate binary pkgs, one conflicts with the other [15:55] mhr3, so basically the seed decides? [15:56] no, that can't be... [15:56] pretty much [15:56] * Saviq no likey [15:56] but i think right now unity8 deps on the phone one, and unity7 on the desktop one [15:56] ah libunity-scopes-json-def-phone, [15:56] ok [15:56] but clearly that will have to change [15:57] bla-bla-bla-bla-phone [15:57] works for me [16:28] Kaleo, ping [16:31] Saviq, can I consider the GRID_UNITY_PX environment variable a public API? (ie. something that won't be changed without notice etc) [16:31] I mean GRID_UNIT_PX :) [16:31] ;) [16:31] dandrader, not sure we should rely on it... it'd be better if units. exposed the value [16:31] dandrader, why do you need? [16:32] Saviq, to it in DirectionalDragArea.cpp to set its default values [16:32] use it [16:32] Otherwise Ubuntu.Gestures would have to depend on Ubuntu.Components [16:33] I don't even know if it's possible to declare a dependency between qml modules [16:34] dandrader, I'd go for simple QML wrappers around the C++ types [16:34] dandrader, importing both .Gestures and .Components [16:34] dandrader, and just using units.gu() [16:35] damn, found that someone is using the nick "dandrader" (https://twitter.com/dandrader) [16:36] Saviq, having that wrapper in Components/DirectionalDragArea. yeah, that sounds alright [16:36] dandrader, yup [16:36] dandrader, new nick time? ;) [16:36] there will be a time when we need to use password generators just to find a nickname :D [16:36] that's fairly unique [16:36] I should have trademarked it or something! :) [16:37] indeed [16:37] dandrader, I have a variation when needed: http://twitter.com/Savicq ;) [16:38] :D [16:38] Saviq, you also lost http://www.saviq.org/ [16:39] dandrader, damn :D [16:39] anti-aging bee venom! [16:39] "how to use saviq" :D [16:39] dandrader, at least you're in the first results for yours [16:40] \o/ bigger net footprint [16:40] * Saviq needs some web positioning ;) [16:41] dandrader: thanks for the review. I fixed all your comments [16:41] mzanetti, I had pedantic mode on [16:42] :) [16:42] dandrader: no... you were absolutely right (except the wrapping on the line where I absolutely don't agree, but lets leave that now...) === salem_ is now known as _salem [16:44] mzanetti, dandrader is angry that we force semicolons on JS :D [16:44] mzanetti, he'll get over it :D [16:44] yeah.. [16:44] hehehe [16:44] which is probably similarly useless [16:44] mzanetti, you yourself was for them ;) [16:45] yeah... I regret it now :D [16:45] mzanetti, and then there's an actual technical reason somewhere [16:45] that I can't be bothered to look for now [16:46] yikes that's bad https://jenkins.qa.ubuntu.com/job/unity8-ci/ https://jenkins.qa.ubuntu.com/job/unity-8.0-ci/ === dandrader is now known as dandrader|lunch [16:52] dandrader|lunch, conflict https://code.launchpad.net/~dandrader/unity8/dragHandleStretchAndHint/+merge/171908 [17:03] Saviq: what's bad? [17:04] mzanetti, our most recent CI history [17:04] mzanetti, but it seems it's getting better now :) [17:04] Saviq: yeah well... we lots of copyright + whitespace issues today [17:04] mzanetti, and then the VMs [17:04] mzanetti, and the packaging [17:05] fortunately qmluitests are being green again === _salem is now known as salem_ [17:41] mfisch: pong [17:52] mhall119: there are a couple small issues in the guide [18:00] ok [18:01] mhall119: I'll email you [18:02] anyone know how do i run the qmltests? [18:02] mzanetti, ^? [18:03] mhr3: cd builddir && make qmltests [18:03] who would expect that? :) [18:03] wtf just happened [18:03] mhr3: you can run each test standalone with "make testXXX". example: make testLockscreen [18:04] this is awesome, i'll be running it 24/7 [18:04] mhr3: you mean the windows popping up doing the tests? [18:04] yep [18:04] yeah, its quite fun to watch [18:05] mhr3: actually, in the source dir there is a script, runtests. that executes all tests and prints you a coverage statistic too [18:08] mzanetti, might not work here, i don't have standard builddir layout [18:17] mfisch: fixed the 2 things from your email [18:18] mhall119: thanks === dandrader|lunch is now known as dandrader [18:37] smspillaz, if you are around, doing it in the grid plugin seems to work, just some kinks to work out :) === hggdh_ is now known as hggdh === jhodapp_ is now known as jhodapp|afk === salem_ is now known as _salem