| hatch | gary_poster: just FYI - looked at the docs, and you MUST prevent dragover to be able to drop. What a stupid spec *facepalm* | 00:12 |
|---|---|---|
| gary_poster | hatch heh, bizarre. so are you moving that to somewhere more general? | 00:27 |
| hatch | I'm renaming that file to dragdrop | 00:28 |
| hatch | and unflagging it | 00:28 |
| gary_poster | I don't think that's an ideal solution but I am OK with it | 00:28 |
| gary_poster | particularly under the circumstances ;-) | 00:28 |
| gary_poster | thanks, stepping away again | 00:28 |
| hatch | there is some funky business going on with the relations and positioning in /trunk | 00:38 |
| hatch | that turned out to be a lot more work than I thought, going to just copy the prevent defaults into the other file | 00:50 |
| gary_poster | hatch, funky business with relations and positioning? | 00:55 |
| hatch | https://bugs.launchpad.net/juju-gui/+bug/1195934 | 00:56 |
| _mup_ | Bug #1195934: Deploying service from dd & add causes positioning issues <juju-gui:New> <https://launchpad.net/bugs/1195934> | 00:56 |
| hatch | see photo | 00:56 |
| gary_poster | ugh | 00:56 |
| hatch | that combined with the relation line issue caused by the menu makes this feel broken | 00:57 |
| gary_poster | agree :-( | 00:57 |
| hatch | kind of don't want to release...tbh | 00:57 |
| gary_poster | relation line caused by menu? | 00:57 |
| gary_poster | wait, I thought that was only on feature flag? | 00:57 |
| hatch | nope that's everywhere | 00:57 |
| gary_poster | !! misunderstood | 00:57 |
| hatch | featureflag has the fix by turning off the menu | 00:57 |
| hatch | and requring long click | 00:58 |
| gary_poster | I see | 00:58 |
| gary_poster | I thought that was unique to new inspector stuff | 00:58 |
| gary_poster | hatch, scratch the release. thank you for trying. | 00:58 |
| hatch | that was the original idea but Makyo said it was a known bug that has somehow been reagrivated at the same time as the new inspector stuff | 00:58 |
| gary_poster | I'll send an email to antonio and peeps and make cards and ask Makyo and benji to investigate | 00:59 |
| gary_poster | on Monday | 00:59 |
| hatch | alright - include in the email that he just needs to copy those two events and the ignore method over for the drop to start working on rapi | 01:00 |
| hatch | broken trunk :-( | 01:01 |
| Makyo | How? | 01:01 |
| gary_poster | ack hatch. where did you think it was best to move the two events over? | 01:01 |
| gary_poster | Makyo don't worry about it unless you want to. not anything to do with you except you will be able to fix it fastest | 01:01 |
| gary_poster | I will send a card | 01:02 |
| gary_poster | in sum, though, three things | 01:02 |
| Makyo | YEah, was just wondering if 'broken trunk :-(' meant something other than the cards already discussed. Hard to tell without further explanation. | 01:02 |
| gary_poster | 1) the drag drop issue we found with improv. we discovered the reason and fix, but not yet in trunk. | 01:02 |
| gary_poster | 2) bug 1195934 | 01:02 |
| hatch | well in renaming the inport/export file, I think it would make sense to move the drop handler for the service into there | 01:02 |
| _mup_ | Bug #1195934: Deploying service from dd & add causes positioning issues <juju-gui:New> <https://launchpad.net/bugs/1195934> | 01:02 |
| gary_poster | 3) relation line gets confused when you start it from the menu now | 01:03 |
| gary_poster | hatch how do you dupe 3? | 01:03 |
| hatch | umm one sec I'll run through again just to be sure | 01:03 |
| gary_poster | hatch can't dupe 3 fwiw | 01:04 |
| gary_poster | on sandbox anyway | 01:04 |
| Makyo | gary_poster, I've seen that one. The mouse coordinates are being taken from the position relative to the upper-left-hand-corner of the menu. I thooought we were passing the vis to d3.mouse, but maybe not! I think you need to pan to reproduce, gets worse the more you pan/drag | 01:04 |
| hatch | ahh right - I was panning but didn't even click that I was doing that | 01:05 |
| Makyo | Because then the relative position is further away from the absolute origin of the SVG scene. | 01:05 |
| hatch | I deploy two services, pan them into the middle, then try and create a relation from the popup menu | 01:05 |
| hatch | then the line is all "hey I'm over here....where are you?" | 01:05 |
| gary_poster | ack hatch, duped thanks | 01:05 |
| hatch | I think that all 3 need to be fixed then we can release :) | 01:09 |
| gary_poster | agreed. | 01:09 |
| hatch | I really wanted to release but it just looks bad :) | 01:10 |
| gary_poster | absolutely. correct call. | 01:10 |
| hatch | were you able to dupe #2? | 01:11 |
| gary_poster | I think so. definitely saw something bad. lemme try the exact instructions... | 01:11 |
| gary_poster | hatch duped and got variation. recorded on bug. | 01:17 |
| hatch | ok great thanks | 01:18 |
| hatch | So I suppose it's finally EOD then heh I suppose at least it was a good QA session | 01:19 |
| gary_poster | yes. thanks again hatch. have a good night and weekend. You too Makyo | 01:19 |
| Makyo | You too. | 01:19 |
| hatch | you too! cya | 01:19 |
| === gary_poster is now known as gary_poster|away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!