| === Zhenech_ is now known as Zhenech | ||
| === TheMuso` is now known as TheMuso | ||
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| veebers | MacSlow: ping | 07:17 |
|---|---|---|
| MacSlow | veebers, pong | 07:19 |
| veebers | MacSlow: morning, this is the branch containing the autopilot additions, but I stumbled when it came to the packaging: lp:~veebers/unity-notifications/adding_autopilot_tests | 07:20 |
| jibel | didrocks, mhr3 I definitely disabled recordmydesktop for unity testsuite (the whole testsuite only it is still enabled for the others) as it is clearly one of the cause of memory fragmentation and OOM issues we have. We'll see how it goes without it. | 07:24 |
| didrocks | ok | 07:24 |
| tsdgeos | Saviq: mzanetti: any idea why the sudden surge of failing tests? | 07:28 |
| Saviq | tsdgeos, not yet, will investigate after the QA sync | 07:28 |
| Saviq | ah, there's actually a PASS? | 07:30 |
| tsdgeos | ? | 07:34 |
| Saviq | tsdgeos, can you have a look at http://s-jenkins:8080/job/unity-phablet-qmluitests-saucy/354/testReport/junit/%28root%29/ListViewWithPageHeaderTestSection/testInsertItemsBeforeValidIndex/ | 07:55 |
| Saviq | tsdgeos, to see if we maybe need to improve that test's reliability | 07:56 |
| Saviq | the others stopped failing suddenly... | 07:56 |
| tsdgeos | oh | 07:57 |
| tsdgeos | sure | 07:57 |
| tsdgeos | let me see | 07:57 |
| * Saviq is going to be back in 20, gotta clean my fans... | 08:00 | |
| mzanetti | lol | 08:03 |
| MacSlow | still needing some review-love... -> https://code.launchpad.net/~macslow/unity8/snap-decision-expansion/+merge/172091 | 08:05 |
| MacSlow | any takers? | 08:05 |
| fginther | mzanetti, morning | 08:11 |
| mzanetti | fginther: hi | 08:12 |
| mzanetti | MacSlow: can do | 08:13 |
| fginther | mzanetti, all of the VMs should have the right set of packages on them now | 08:13 |
| MacSlow | mzanetti, that would be great... thanks! | 08:13 |
| mzanetti | fginther: yep, I've seen you enabled all 3 VMs | 08:13 |
| mzanetti | fginther: we had some weird test failures yesterday evening where we couldn't figure the reason yet. I don't think its related to the VM setup tho | 08:14 |
| mzanetti | fginther: but just to let you know. We'll keep an eye on them | 08:14 |
| mzanetti | fginther: thanks for fixing the VMs | 08:15 |
| fginther | mzanetti, no problem, please let me know if anything else is needed (or if we need more). | 08:16 |
| mzanetti | fginther: yep. I will. | 08:16 |
| dandrader | are autopilot tests working for you guys when run locally? | 08:24 |
| dandrader | tsdgeos, ^ | 08:24 |
| dandrader | for me, there are long periods of "nothing happening". | 08:24 |
| MacSlow | dandrader, any test in particular? | 08:25 |
| dandrader | sometimes the mouse pointer moves but there's not even a unity8 window open | 08:25 |
| dandrader | MacSlow, no, I guess I big bunch of them | 08:25 |
| mzanetti | MacSlow: is there any way to generate notifications when running unity8 with ./run? | 08:28 |
| mzanetti | dandrader: hmm.... I've seen some weirdness too yesterday. sometimes it was clicking outside the window for me | 08:28 |
| mzanetti | dandrader: but I haven't seen the long periods nothing happening | 08:29 |
| MacSlow | mzanetti, I use the exmaples from lp:unity-notifications... | 08:29 |
| mzanetti | MacSlow: tell me more | 08:30 |
| Saviq | mzanetti, pkill notify-osd | 08:30 |
| Saviq | mzanetti, and run any of http://bazaar.launchpad.net/~unity-api-team/unity-notifications/trunk/files/head:/examples/ | 08:30 |
| MacSlow | mzanetti, and speaking of that... I didn't push the "more-than-2-actions" snap-decisions to lp:unity-notifications... but I'll push a branch with updated examples... one sec | 08:30 |
| nic-doffay | Saviq, it appears in the gallery preview that the components heights are being restrained, which is the cause of the bug I'm running into. Any ideas? | 08:30 |
| Saviq | nic-doffay, wtym restrained? | 08:31 |
| dandrader | mzanetti, hmm... then maybe there might be something wrong/missing in my new setup. I installed saucy from scratch (usb stick) a week or so ago | 08:31 |
| nic-doffay | Saviq, because on my components expansion it's height is modified by the code. This works as it should in a qmlscene, however in the gallery the height is never changed for some reason, even though the code is called. | 08:31 |
| nic-doffay | onHeightChanged doesn't log anything. | 08:32 |
| nic-doffay | Only at startup. | 08:32 |
| dandrader | mzanetti, ideas on how to debug, what to check, are welcome :) | 08:33 |
| mzanetti | dandrader: hmm... I still have a quantal installation upgraded to raring, then to saucy. But tbh I don't think that should make a difference | 08:33 |
| mzanetti | dandrader: well, it depends on what's happening. I would probably start hammering some prints into the autopilot tests to understand what exactly is hanging | 08:33 |
| tsdgeos | dandrader: works here | 08:33 |
| tsdgeos | dandrader: is your user part of the autopilot group? | 08:33 |
| dandrader | tsdgeos, yes | 08:34 |
| dandrader | tsdgeos, some tests do work. I see the unity8 window there and mouse moves things around | 08:34 |
| tsdgeos | ok, then no clue what may be wrong .-/ | 08:34 |
| dandrader | tsdgeos, but then there are some long periods of nothing showing up at all in between those | 08:34 |
| dandrader | :) | 08:34 |
| tsdgeos | that happened to me when my user wasn't part of the autopilot group | 08:35 |
| MacSlow | mzanetti, bzr branch lp:~macslow/unity-notifications/snap-decision-with-many-actions | 08:35 |
| tsdgeos | Saviq: had a look at that test and tbh unless it is running in an ultra slow machine, i can't see how it'd be failing :-/ | 08:35 |
| mzanetti | tsdgeos: :( | 08:36 |
| Saviq | tsdgeos, k, let's see what's gonna happen | 08:36 |
| MacSlow | mzanetti, there try unity-notifications/examples/sd-example-incoming-call.py | 08:36 |
| tsdgeos | Saviq: i mean the only thing that was done before it failing was "scroll down", and then i check that we are where we should | 08:36 |
| mzanetti | btw. jenkins machine is currently at 90% idle with 3 - 6% IO wait. | 08:37 |
| MacSlow | mzanetti, of course the stand-alone and interactive qmltest work too | 08:37 |
| Saviq | tsdgeos, k | 08:37 |
| Saviq | mzanetti, http://s-jenkins:8080/job/unity-phablet-qmluitests-saucy/ looks like we're back in business... | 08:38 |
| mzanetti | Saviq: a bit unsatisfying tho that we have no clue what actually happened | 08:38 |
| mzanetti | but at least it works again | 08:38 |
| Saviq | mzanetti, I put it down to the fact the machine was just hogged overnight | 08:39 |
| tsdgeos | but yeah something may be wrong :-/ | 08:39 |
| tsdgeos | https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/345/console failed too | 08:39 |
| tsdgeos | and that's not even moving | 08:39 |
| tsdgeos | it's just inside the "verify position after showing" | 08:39 |
| * Saviq goes on and restarts all the failed MPs | 08:39 | |
| Saviq | nic-doffay, the gallery is just a Column { Repeater { } }, really, no height restriction I can see | 08:41 |
| nic-doffay | Saviq, I can't think of any other reason this would work as a child in another column (in my qmlscene) but not in the gallery. | 08:42 |
| nic-doffay | Mouse clicks are detected etc. | 08:43 |
| Saviq | nic-doffay, I can see you disabled some of the behaviours in your branch now, can you bring it back to a state where it exposes the issue you're seeing so that I can have a look? | 08:44 |
| nic-doffay | Saviq, the issue is still there. If you run modules/Ubuntu/Components/ListItems/test.qml you'll see it working correctly in a qmlscene. If you run the gallery you'll see it broken. | 08:45 |
| Saviq | nic-doffay, there's no expansion going on in the gallery, though (it doesn't react to mouse clicks) - is that your issue? | 08:46 |
| Saviq | mzanetti, https://code.launchpad.net/~mzanetti/unity8/launcher-follow-unity-api/+merge/172557/comments/385956 | 08:46 |
| nic-doffay | Saviq, yeah but the mouse clicks are detected and the selectors.expanded bool changes accordingly. | 08:47 |
| mzanetti | Saviq: d'oh | 08:47 |
| Saviq | nic-doffay, ok, will have a look | 08:47 |
| MacSlow | mzanetti, updated the branch... and also commented with some additional info. | 09:15 |
| mzanetti | MacSlow: approved | 09:15 |
| MacSlow | mzanetti, thanks | 09:17 |
| Saviq | mzanetti, yeah, looking good http://s-jenkins:8080/job/unity-phablet-qmluitests-saucy/ | 09:17 |
| mzanetti | Saviq: \o/ | 09:18 |
| mzanetti | Saviq: btw. when porting the launcher code to the unity-api i realized that we generate .pc files for each plugin | 09:18 |
| mzanetti | Saviq: thing is, all of them set include_dir to /usr/include which makes them somehow useless | 09:19 |
| Saviq | mzanetti, but Version will be different | 09:19 |
| mzanetti | Saviq: wouldn't it make sense to actually point directly to /usr/include/unity/shell/launcher/ ? | 09:19 |
| Saviq | mzanetti, we need per-API Version | 09:19 |
| mzanetti | ah, right... | 09:19 |
| Saviq | mzanetti, we could point there indeed | 09:19 |
| Saviq | mzanetti, I don't think I have any objections to that | 09:20 |
| Saviq | mzanetti, except maybe that #includes will be less expressive | 09:20 |
| mzanetti | hmm... also true... | 09:20 |
| === dandrader is now known as dandrader|afk | ||
| Saviq | nic-doffay, dude, you got me chasing there... | 10:10 |
| Saviq | nic-doffay, you only have a single value for the OptionSelector in ListItems.qml | 10:11 |
| nic-doffay | Saviq, you mean in test.qml? | 10:13 |
| Saviq | nic-doffay, no | 10:13 |
| Saviq | nic-doffay, in ListItems.qml | 10:13 |
| Saviq | nic-doffay, where you added the OptionSelector | 10:13 |
| Saviq | nic-doffay, you have values: [i18n.tr("Value 1")] | 10:13 |
| Saviq | nic-doffay, so there's no expansion going on, 'cause there's only one value to select from! | 10:14 |
| nic-doffay | Saviq, yeah, but I've been trying with four too. | 10:14 |
| Saviq | nic-doffay, anyway | 10:14 |
| Saviq | nic-doffay, I have a bunch of other changes, just preparing the diff | 10:14 |
| nic-doffay | Saviq, but I just remembered that it was before I made some other changes to the Selector >_< | 10:15 |
| Saviq | nic-doffay, http://pastebin.ubuntu.com/5839891/ | 10:17 |
| nic-doffay | Saviq, line 24 in the diff? | 10:18 |
| Saviq | nic-doffay, Header is ambiguous | 10:18 |
| === dandrader|afk is now known as dandrader | ||
| Saviq | nic-doffay, so to use it we need to import "." (current dir) under a namespace | 10:19 |
| dandrader | dednick, seems good to go: https://code.launchpad.net/~dandrader/unity8/panelDragHandle/+merge/172142 | 10:19 |
| Saviq | nic-doffay, obviously visually and behaviourally there's still work to do | 10:20 |
| Saviq | nic-doffay, like the fact that the other items should get dimmed | 10:20 |
| nic-doffay | Saviq, yeah def. | 10:20 |
| Saviq | nic-doffay, and that the whole list should move into view | 10:20 |
| Saviq | nic-doffay, and the OptionSelector's height needs to be limited | 10:21 |
| Saviq | nic-doffay, btw, you should not have removed ValueSelector | 10:21 |
| Saviq | nic-doffay, it's in use by apps, we'll need to phase it out | 10:21 |
| Saviq | nic-doffay, (or replace it with the OptionSelector - but that's a decision the SDK team needs to make) | 10:21 |
| nic-doffay | Saviq, I'll move it onto another branch when I'm done with it. | 10:22 |
| nic-doffay | So it exists with the deprecated ValueSelector. | 10:22 |
| Saviq | nic-doffay, yup | 10:23 |
| Saviq | nic-doffay, if you have any questions about the diff, let me know | 10:23 |
| nic-doffay | Saviq, seems pretty straight forward aside from that ambiguous header. | 10:23 |
| nic-doffay | ta | 10:23 |
| Saviq | mhr3, https://code.launchpad.net/~mhr3/unity8/use-dee-filtermodel/+merge/171846/comments/386003 | 10:24 |
| dednick | dandrader: taking a look now | 10:27 |
| mhr3 | Saviq, thx, pushed fix | 10:30 |
| mhr3 | and made a note to run make test next time as well :) | 10:31 |
| Saviq | mhr3, :) | 10:33 |
| pstolowski | Trevinho: ping | 10:33 |
| Saviq | mhr3, you could also install our shiny commit hook :D | 10:33 |
| mhr3 | Saviq, oh? where is it? | 10:33 |
| Saviq | mhr3, .bazaar | 10:33 |
| mhr3 | hmm, now i'll have to commit from inside jhbuild shell | 10:35 |
| mhr3 | ah, actually it won't work in jhbuild setup :/ | 10:36 |
| nic-doffay | Saviq, one question. Selected is set twice, what are the reasons for that? Even if they are separate components... | 10:40 |
| Saviq | nic-doffay, might've been an omission on my side | 10:40 |
| nic-doffay | Saviq, nm | 10:40 |
| Saviq | didrocks, https://code.launchpad.net/~unity-team/unity8/packaging-cleanup/+merge/172578/comments/386016 | 10:40 |
| nic-doffay | my mistake. | 10:40 |
| nic-doffay | I see one was removed further down. | 10:40 |
| didrocks | Saviq: ah, I think there is a missing dep, one sec | 10:41 |
| mhr3 | Saviq, i wish the ci bots were doing what you are :) | 10:42 |
| Saviq | mhr3, ;) | 10:42 |
| nic-doffay | Saviq, what are your thoughts on the OptionSelector being repeated four times in the gallery? Is that correct behaviour? | 10:49 |
| nic-doffay | The contained values I can understand. | 10:49 |
| Saviq | nic-doffay, it's just a gallery, it's supposed to show you the interaction | 10:49 |
| nic-doffay | But the entire thing? | 10:49 |
| nic-doffay | Yeah but four version with labels Saviq ? | 10:49 |
| Saviq | nic-doffay, you wouldn't be able to show the dimming otherwise, for example | 10:49 |
| nic-doffay | Surely one would be enough? | 10:49 |
| Saviq | nic-doffay, because the dimming is only supposed to affect the immediate neighbours | 10:49 |
| Saviq | nic-doffay, it's the same as with the others, it just shows four of them to show how they interact | 10:50 |
| Saviq | nic-doffay, having just one would be somewhat lonely :) | 10:50 |
| nic-doffay | Saviq, fair enough. | 10:50 |
| nic-doffay | Saviq, soo, further behaviour mods. | 10:51 |
| Saviq | dandrader, as for your autopilot issues, I sometimes find that the unity8 window isn't created | 10:51 |
| Saviq | dandrader, even when using ./run | 10:51 |
| nic-doffay | What do you think still should be added to this component? | 10:51 |
| nic-doffay | Dimmed items. | 10:51 |
| didrocks | Saviq: I'll look in a bit, it seems that it was expanded to nothing in my trial, will debug it | 10:52 |
| Saviq | nic-doffay, add a set of contained: false to the gallery | 10:52 |
| nic-doffay | Saviq, waiting on assets too. I'll chase that up now. | 10:53 |
| Saviq | nic-doffay, yup, and make sure you talk to the guys about the visuals for the SDK | 10:53 |
| Saviq | nic-doffay, and there's the "non-full-width" case | 10:54 |
| Saviq | nic-doffay, btw, that's what "contained" stands for, no? | 10:54 |
| nic-doffay | Saviq, yeah the ubuntu shape. | 10:54 |
| nic-doffay | Saviq, contained is whether it's always expanded or not. | 10:54 |
| Saviq | nic-doffay, I beg to differ :) http://design.ubuntu.com/apps/building-blocks/option-selector | 10:55 |
| Saviq | nic-doffay, or at least ckpringle does ;) | 10:55 |
| nic-doffay | Saviq, I assumed that was set manually by the person using the component. | 10:56 |
| Saviq | nic-doffay, it is | 10:56 |
| nic-doffay | Saviq, I was working off this: https://docs.google.com/a/canonical.com/document/d/1cg9ruHiEpRynEr_Ipf39Z0MQINEWoChIN-d111yx-Qw/edit#heading=h.cpfn81n0c0rr | 10:57 |
| Saviq | nic-doffay, I just mean that the "property bool contained" is used wrong | 10:57 |
| nic-doffay | See page 67 | 10:57 |
| nic-doffay | On the left... | 10:57 |
| Saviq | nic-doffay, it should be "property bool expanded" instead | 10:57 |
| Saviq | nic-doffay, which says that it is supposed to be expanded all the time | 10:57 |
| nic-doffay | Saviq, there's already an expanded boolean on the selector which deals with temporary expansion. | 10:58 |
| nic-doffay | Which is why I made another. | 10:58 |
| Saviq | nic-doffay, simply rename the internal one, then | 10:59 |
| nic-doffay | Saviq, yeah that's what I've done now. | 10:59 |
| Saviq | nic-doffay, what we want to expose as the API needs to be as close to the design docs as possible | 10:59 |
| Saviq | nic-doffay, so that we don't confuse people (and ourselves) | 10:59 |
| nic-doffay | Saviq, gotcha | 11:00 |
| Saviq | dandrader, also, what you might be seeing is (I'm seeing it now after libusermetrics support was merged) | 11:02 |
| Saviq | dandrader, is that the libusermetrics plugin blocks for a long time on startup... | 11:02 |
| Saviq | we need to fix that | 11:02 |
| Saviq | dandrader, UserMetricsOutput::UserMetrics::getInstance(); takes a good 15s on startup (probably waiting for something on DBus that's never showing up) | 11:03 |
| dandrader | Saviq, well, that behavior I explained was without the libusermetrics patch | 11:03 |
| Saviq | dandrader, k | 11:04 |
| Cimi | mzanetti, https://code.launchpad.net/~cimi/ubuntu-settings-components/calendar-newmodel/+merge/172598 | 11:07 |
| mzanetti | Cimi: ack | 11:07 |
| nic-doffay | Saviq, fixed this up now. Throwing in the assets then I plan on getting a review from design. | 11:07 |
| Saviq | nic-doffay, there's one thing you might want to investigate | 11:08 |
| nic-doffay | Thanks for taking a look. Btw I couldn't find any information on the "interactive" property on the ListView. | 11:08 |
| Cimi | mzanetti, I should not clear and repopulate the model onMinimumDateChanged and onMaximumDateChanged | 11:08 |
| didrocks | Saviq: ok, the main issue is in libunity, let me fix it | 11:08 |
| Cimi | mzanetti, something smarter would be better | 11:08 |
| Saviq | nic-doffay, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-flickable.html#interactive-prop | 11:08 |
| Saviq | nic-doffay, when you switch from Value 1 to Value 4 | 11:08 |
| Cimi | mzanetti, however, I do something else now because I'm sick of this calendar for a while :) | 11:08 |
| Cimi | didn't find bugs so far and tests are better | 11:09 |
| Saviq | nic-doffay, the list contracts faster than the item gets into position | 11:09 |
| === MacSlow is now known as MacSlow|lunch | ||
| nic-doffay | Saviq, yeah I noticed that. | 11:09 |
| Saviq | nic-doffay, you might want to positionViewAtIndex first | 11:09 |
| Saviq | nic-doffay, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-listview.html#positionViewAtIndex-method | 11:09 |
| Saviq | tsdgeos, do you know what speed is used when using the ListView::position* methods? | 11:10 |
| Saviq | tsdgeos, or when the ListView takes care of it itself by positioning the current item in view? | 11:11 |
| tsdgeos | not really, i can check | 11:11 |
| Saviq | tsdgeos, you're our ListView expert, so you're going to be the fastest to do so :) | 11:12 |
| Saviq | ah | 11:13 |
| nic-doffay | Saviq, it looks good. | 11:13 |
| Saviq | nic-doffay, actually | 11:13 |
| Saviq | nic-doffay, it could be enough to just use http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-listview.html#highlightMoveDuration-prop | 11:13 |
| Saviq | nic-doffay, and set it to SnapDuration | 11:13 |
| Saviq | tsdgeos, ↑ found it (I think | 11:13 |
| Saviq | hmm or maybe not | 11:13 |
| tsdgeos | Saviq: that may work for current index changes | 11:14 |
| tsdgeos | not sure if positionAtViewBeginning is the same | 11:14 |
| Cimi | Saviq, I start having a look at unity theming now.. | 11:14 |
| Saviq | tsdgeos, and anyway that concerns the highlight, not the view itself | 11:14 |
| Saviq | tsdgeos, so it probably doesn't anyway | 11:14 |
| didrocks | pstolowski: hey, mind having a look? https://code.launchpad.net/~didrocks/libunity/rename-while-installing/+merge/172788 | 11:15 |
| Saviq | Cimi, thanks | 11:16 |
| nic-doffay | Saviq, highlightMove didn't do the job. | 11:18 |
| Saviq | nic-doffay, yeah, thought as much | 11:18 |
| nic-doffay | Stayed with the positionViewAtIndex. | 11:18 |
| Saviq | nic-doffay, yup | 11:18 |
| pstolowski | didrocks: hi, looking | 11:18 |
| Saviq | didrocks, why that? didn't it work via the .install file? | 11:19 |
| tsdgeos | Saviq: i'd have to do a test, but my guess right now is 200ms | 11:20 |
| tsdgeos | Saviq: do you have a test file i can trace where the code goes? | 11:20 |
| Saviq | tsdgeos, will have one in 2 | 11:20 |
| === alan_g is now known as alan_g|afk | ||
| didrocks | Saviq: no, it's creating a directory with the name | 11:21 |
| didrocks | and put the file in it | 11:21 |
| didrocks | (even without trailing /) | 11:21 |
| Saviq | didrocks, uh | 11:21 |
| Saviq | tsdgeos, http://pastebin.ubuntu.com/5840020/ | 11:24 |
| Saviq | didrocks, so we'll have to wait for another release of libunity... :/ | 11:25 |
| nic-doffay | Saviq, the issue with positionViewAtIndex is that it always positions it at the first index for some reason. | 11:25 |
| Saviq | nic-doffay, meaning? | 11:26 |
| tsdgeos | Saviq: ok, may take a while, just realized i had a weird mixup in my qt selfcompiled sources | 11:26 |
| tsdgeos | git submodules suck | 11:26 |
| Saviq | tsdgeos, ignore | 11:26 |
| Saviq | tsdgeos, leave it | 11:26 |
| tsdgeos | or more likely, my knowledge of git submodules suck :D | 11:26 |
| tsdgeos | Saviq: ok | 11:27 |
| nic-doffay | Saviq, it shows the first index the whole time when positionViewAtIndex is used after it collapses. | 11:27 |
| Saviq | nic-doffay, can you push? I'm not sure I get what you mean | 11:27 |
| nic-doffay | Saviq, pushed. | 11:28 |
| === alan_g|afk is now known as alan_g | ||
| pete-woods | didrocks: hi! | 11:33 |
| Saviq | nic-doffay, right, so it actually doesn't do anything useful | 11:33 |
| Saviq | nic-doffay, interesting... | 11:33 |
| Saviq | nic-doffay, it might be because the list is able to contain all the items at this point | 11:34 |
| Saviq | nic-doffay, just leave it for now | 11:34 |
| Saviq | pete-woods, hey, it seems that UserMetricsOutput::UserMetrics::getInstance() blocks for quite some time | 11:37 |
| Saviq | pete-woods, like it's maybe waiting for the DBus service that never shows up? | 11:37 |
| pete-woods | Saviq: it does block on the service | 11:38 |
| Saviq | pete-woods, could it not? | 11:38 |
| pete-woods | Saviq: but the service should be there? (Id have thought) | 11:38 |
| Saviq | pete-woods, it should never block on any service | 11:38 |
| Saviq | pete-woods, even if it's there, or coming up | 11:38 |
| didrocks | hey pete-woods :) | 11:38 |
| pete-woods | Saviq: okay, should it return null or something when there's no service? | 11:38 |
| didrocks | Saviq: as soon as pstolowski ack it, I'll republish libunity | 11:38 |
| didrocks | (well, once merged of course :p) | 11:39 |
| Saviq | pete-woods, ideally it should return straight away | 11:39 |
| Saviq | pete-woods, and wait for the service in another thread, if it needs to block | 11:39 |
| Saviq | pete-woods, and just update itself when the service comes up | 11:39 |
| pete-woods | didrocks: I was looking to make a new release of the libusermetrics | 11:39 |
| Saviq | or, if possible in the same thread, just wait for the service to come up and update then | 11:39 |
| pstolowski | didrocks: I approved your MP 10 mins ago | 11:40 |
| pete-woods | Saviq: I'll have a look at it | 11:40 |
| Saviq | pete-woods, thanks | 11:40 |
| didrocks | pete-woods: it's in the indicator stack, check with cyphermox who is responsible for it. It seems though that indicator-client is failing to biuld rejecting the whole stack then | 11:42 |
| didrocks | pete-woods: it was published yesterday FYI | 11:43 |
| pete-woods | didrocks: yes, but I fixed an important bug just after release :/ | 11:44 |
| pete-woods | didrocks: I will speak to the correct person, thanks! :) | 11:44 |
| didrocks | pete-woods: yw :) | 11:44 |
| Saviq | pete-woods, ah, but usermetricsservice only runs in the LightDM session, does it? | 11:50 |
| Saviq | pete-woods, btw, http://pastebin.ubuntu.com/5840105/ | 11:53 |
| Saviq | pete-woods, sorry for the PL in there, let me know if I can translate something :D | 11:53 |
| pete-woods | Saviq: whoops! looks like I need to fix the removal script! | 11:57 |
| pete-woods | (I like I get the idea) | 11:58 |
| pete-woods | like->think | 11:58 |
| mhr3 | didrocks, dee-qt is not part of unity stack releases? | 11:58 |
| didrocks | mhr3: I think it was put on the platform stack | 11:59 |
| didrocks | hum, no sdk stack | 11:59 |
| === MacSlow|lunch is now known as MacSlow | ||
| pete-woods | Saviq: I can't seem to reproduce that package purging error (just tried purging my install), what was the exact command you ran? | 12:15 |
| Saviq | pstolowski, https://code.launchpad.net/~stolowski/unity8/activation-and-previews/+merge/172102/comments/386086 | 12:15 |
| Saviq | pete-woods, the usual - apt-get purge | 12:15 |
| Saviq | pete-woods, but the service was running under user 119 | 12:15 |
| pstolowski | Saviq: ok, fixing | 12:15 |
| Saviq | pete-woods, and that resulted in the error, I believe | 12:16 |
| Saviq | pete-woods, right, 119 is the usermetrics user | 12:17 |
| Saviq | pete-woods, http://pastebin.ubuntu.com/5840153/ | 12:17 |
| === dandrader is now known as dandrader|lunch | ||
| Saviq | pete-woods, so it somehow needs to stop the service first | 12:18 |
| pete-woods | Saviq: there's a prerm script that is supposed to be doing that | 12:21 |
| didrocks | pstolowski: I'm puzzled, this pass both builders and failed in the ppa: mv debian/libunity-scopes-json-def-phone/usr/share/unity/client-scopes-phone.json debian/libunity-scopes-json-def-phone/usr/share/unity/client-scopes.json | 12:22 |
| didrocks | mv: cannot stat 'debian/libunity-scopes-json-def-phone/usr/share/unity/client-scopes-phone.json': No such file or directory | 12:22 |
| didrocks | (the local pbuilder worked as well | 12:22 |
| didrocks | wth is happening? | 12:22 |
| pstolowski | didrocks: weird... I built it locally with no problems.. | 12:22 |
| pstolowski | didrocks: I built with dpkg-buildpackage (not pbuilder) | 12:22 |
| === ChrisTownsend1 is now known as ChrisTownsend | ||
| didrocks | pstolowski: I retried trunk and it's fine as well :/ | 12:24 |
| didrocks | wth? | 12:24 |
| pstolowski | Saviq: fixed | 12:27 |
| pstolowski | didrocks: just guessing.. is it possible that it builds e.g. twice but unpackas it only once, and the file is no longer there on 2nd build? | 12:34 |
| didrocks | pstolowski: I checked the logs and it doesn't seem so… | 12:34 |
| didrocks | pstolowski: and anyway dh_install is run just before, so we would have it in debian/tmp/ | 12:35 |
| pstolowski | uhm | 12:35 |
| didrocks | hum, pbuilder fails now on the tests, grrr | 12:36 |
| didrocks | it's probably a race, it's passsing on i386 | 12:36 |
| didrocks | but what? | 12:36 |
| === greyback is now known as greyback|lunch | ||
| Saviq | pstolowski, cheers | 12:46 |
| === greyback|lunch is now known as greyback | ||
| MacSlow | Saviq, did this show up before yet... https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/381/testReport/junit/(root)/ListViewWithPageHeaderTestSection/testCreationDeletion | 12:59 |
| Saviq | MacSlow, nope, I've restarted, let's see what happens | 13:02 |
| tsdgeos | pstolowski: you have a conflict now, can you fix it? | 13:03 |
| tsdgeos | ah, see Saviq already said so | 13:03 |
| Saviq | tsdgeos, it should be fixed already | 13:03 |
| pstolowski | tsdgeos: yes, it's fixed | 13:03 |
| tsdgeos | i'm confused by https://code.launchpad.net/~aacid/unity8/remove28403workarounds/+merge/172608 | 13:04 |
| tsdgeos | wyh everything is success but the topone is failure? | 13:04 |
| paulliu | I have a MouseArea, and with onClicked and onDoubleClicked. But when I double clicked it, it brings up onClicked first, and then onDoubleClicked. Is that correct? | 13:04 |
| tsdgeos | Saviq: answered your question about the clip | 13:06 |
| tsdgeos | paulliu: think that's the default behaviour yes | 13:06 |
| tsdgeos | otherwise all the clicks would have to be delayed a noticeable number of ms | 13:06 |
| mzanetti | hey ho. here's a MP ready for review: https://code.launchpad.net/~mzanetti/unity8/launcher-improve-flicking-behavior/+merge/172648 | 13:07 |
| paulliu | tsdgeos: hmm, so how to implement two different actions. I mean I don't want the onClicked triggered if it is a double-click. | 13:07 |
| tsdgeos | paulliu: well, usually the click and double click are "not exclusive" | 13:09 |
| tsdgeos | i.e. click selects and double click opens | 13:09 |
| tsdgeos | so it's not a problem doing click and then double click | 13:09 |
| tsdgeos | paulliu: what does click and double click do? | 13:09 |
| paulliu | In App lens, it seems to me that the click opens the preview, and double click "activates" it. | 13:09 |
| mzanetti | and this one too: https://code.launchpad.net/~mzanetti/unity8/launcher-follow-unity-api/+merge/172557 | 13:10 |
| paulliu | ok.. then I have to use onPress and onRelease to implement that by hand. | 13:11 |
| tsdgeos | paulliu: afaics it "can't be done", other than making the click wait a bit to see if double click is going to happen or not | 13:11 |
| tsdgeos | which is baaaaaaaad imho | 13:11 |
| tsdgeos | and will give us a weird usability | 13:11 |
| mzanetti | +1 for what tsdgeos said | 13:12 |
| mzanetti | paulliu: tsdgeos: well.. what I guess could be done is this: | 13:13 |
| paulliu | tsdgeos, mzanetti: oh? but what's so weird? I mean isn't double-click always have a delay threshold? | 13:13 |
| tsdgeos | wooooo, Qt 5.1 is out | 13:14 |
| tsdgeos | paulliu: the wierd is that i do a single click | 13:14 |
| mzanetti | actually... true... tsdgeos: if you double, tap, I'm not sure if the clicked signal is even emitted | 13:14 |
| tsdgeos | and then you wait 300ms to see if it is really a single click or a double one | 13:14 |
| paulliu | tsdgeos: yeah, that's it. | 13:14 |
| Saviq | paulliu, that's not right anymore | 13:14 |
| tsdgeos | that 300ms will drive me crazy | 13:14 |
| Saviq | tsdgeos, there's no dbl-click for apps | 13:15 |
| paulliu | Saviq: https://docs.google.com/a/canonical.com/document/d/1qjnUirxkswgCvWRT5ervfQoR03zs-7HIIMI2e3Lvuqs/edit | 13:15 |
| tsdgeos | mzanetti: it has to, otherwise everything is delayed by the "valid double click interval", no? | 13:15 |
| paulliu | Saviq: in Installing the apps, it is double click, isn't it? | 13:15 |
| tsdgeos | or maybe it is and the "valid double click interval" is too short my mind doesn't realize? | 13:16 |
| tsdgeos | s/too/so | 13:16 |
| mzanetti | tsdgeos: yeah true, but I'm not sure if we aren't used to that delay yet... And I think its less than 300ms | 13:16 |
| * mzanetti tries | 13:16 | |
| Saviq | pstolowski, where was sabdfl's comment about the dbl click in apps scope? | 13:17 |
| Saviq | paulliu, I know, but I think that's outdated | 13:17 |
| paulliu | Saviq: ok... | 13:17 |
| mzanetti | tsdgeos: nah... you get both... clicked on the first one, and doubleClicked on the second | 13:18 |
| tsdgeos | makes sense | 13:18 |
| pstolowski | Saviq: comment on dbl click? not sure, I only know of this - https://bugs.launchpad.net/unity/+bug/1189088 - comment #20; so we won't be showing previews for installed apps on single left-click inunity7 | 13:20 |
| ubot5` | Launchpad bug 1189088 in unity (Ubuntu) "Unity Dash, left mouse button starts preview instead of directly the application" [High,In progress] | 13:21 |
| Saviq | pstolowski, yeah, I meant https://bugs.launchpad.net/unity/+bug/1189088/comments/20 | 13:21 |
| Saviq | paulliu, ↑ | 13:21 |
| paulliu | ok.. | 13:21 |
| === dandrader|lunch is now known as dandrader | ||
| === _salem is now known as salem_ | ||
| greyback | mterry: http://s-jenkins:8080/job/ubuntu-touch-phablet-image-saucy-mir/ <- grab the preinstall from there and sideload it on to your flipped saucy device | 13:44 |
| mterry | greyback, thanks, will try | 13:45 |
| greyback | mterry: I'm using yesterday's image, which works fine. I'm a tiny bit worried the MESA problems that hit me yesterday are in that image, but hopefully not | 13:45 |
| greyback | mterry: don't "apt-get update" :) | 13:45 |
| fginther | mzanetti, I see the qmluitests are running better now, may I asked what led to the improvement? | 13:46 |
| dandrader | greyback, can you point me to that unity8+mir image you talked about? | 13:55 |
| greyback | dandrader: http://s-jenkins:8080/job/ubuntu-touch-phablet-image-saucy-mir/ grab the preinstall image | 13:56 |
| dandrader | greyback, thanks | 13:57 |
| mzanetti | fginther: good news: yeah, they seem ok now | 14:10 |
| mzanetti | fginther: bad new: we have no clue what was wrong | 14:10 |
| mzanetti | fginther: we decided to blame it on machine load | 14:10 |
| fginther | mzanetti, yeah, that always gives me a bad feeling too | 14:10 |
| fginther | mzanetti, thanks for the update. glad it's working again | 14:11 |
| pstolowski | Saviq: can you top-approve my MP? | 14:14 |
| Saviq | pstolowski, oh, didn't I already? | 14:14 |
| Saviq | pstolowski, sorry | 14:14 |
| mzanetti | tsdgeos: may I ask you for this one? https://code.launchpad.net/~mzanetti/unity8/launcher-improve-flicking-behavior/+merge/172648 | 14:14 |
| Saviq | pstolowski, done | 14:14 |
| tsdgeos | mzanetti: okidoki | 14:14 |
| pstolowski | Saviq: ty | 14:15 |
| mzanetti | Saviq: and I fear you're the right person for this one: https://code.launchpad.net/~mzanetti/unity8/launcher-follow-unity-api/+merge/172557 | 14:15 |
| Saviq | mzanetti, yeah, now I'm past indicators-client I'll definitely do more :) | 14:15 |
| Saviq | mzanetti, one thing I didn't like in the WIP one for launcher backend | 14:16 |
| * mzanetti tries to avoid asking Saviq for reviews as he does way too many of them already | 14:16 | |
| Saviq | mzanetti, was the fact that you hardcoded /usr/share/applications | 14:16 |
| mzanetti | Saviq: gone already | 14:16 |
| Saviq | mzanetti, cool | 14:16 |
| Saviq | mzanetti, does the backend look at XDG_DATA_DIRS or does the .desktop file parser? | 14:16 |
| mzanetti | Saviq: dunno... I defined a method called QString desktopFile(appId) which I expect Wellark to fill :P | 14:17 |
| Saviq | mzanetti, re: me doing too many reviews, all of you guys have been very helpful in that field recently | 14:18 |
| Saviq | mzanetti, so I can't complain | 14:18 |
| Saviq | mzanetti, :D | 14:18 |
| dandrader | Saviq, yeah. now it takes a long time for the unity8 window to finally show up :( | 14:20 |
| Saviq | dandrader, -f | 14:20 |
| Saviq | dandrader, pete-woods is already noticed we can't be doing that (blocking on a service to show up) | 14:20 |
| pete-woods | Saviq: I have a fix in for the service actually starting now - haven't done the blocking fix yet | 14:21 |
| Saviq | pete-woods, that's fine | 14:21 |
| dandrader | ok, "./run --fake" bring back the old "./run" behavior | 14:21 |
| Saviq | pete-woods, mterry, btw, we have a separate, private qml import path for the shell, feels like a separate one for lightdm (or $greeter) would be good to have, too? | 14:22 |
| mterry | Saviq, maybe... the greeter might just want to share the shell's though | 14:22 |
| mterry | depends on what's in there | 14:22 |
| Saviq | mterry, yup | 14:23 |
| mterry | I imagine my split branch shares the same import path unless we explicitly do something different | 14:23 |
| mterry | (just because it uses the same main.cpp with a few minor DEFINE changes) | 14:23 |
| Saviq | mterry, otoh most of the interfaces will need to be proxied through the accounts service or whatever forwards things from the user session to the greeter session | 14:23 |
| mterry | Saviq, true, but does that change logic about the private import path? | 14:25 |
| tsdgeos | Mirv: do we have a timeframe for Qt 5.1 in saucy now that it's officially released? | 14:25 |
| Saviq | mterry, if there's different plugins for greeter (talking to accounts service) and shell (directly talking to whatever they want to talk to) | 14:32 |
| Saviq | mterry, we could have separate plugins for shell and greeter implementing the exact same API | 14:32 |
| Saviq | mterry, reducing the need to adapt between the shell and greeter, where applicable | 14:33 |
| tsdgeos | mzanetti: why are dragLauncherIntoView and waitUntilLauncherDisappears in a different UnityTestCase? | 14:33 |
| mterry | Saviq, oh hmm, sure, alternatively we might call them different names. But regardless, we can solve that when we come to it | 14:33 |
| mzanetti | tsdgeos: because I need it for multiple different test cases | 14:33 |
| tsdgeos | ah | 14:34 |
| mzanetti | tsdgeos: and it needs to be inside a testcase because it uses compare() | 14:34 |
| tsdgeos | ok | 14:34 |
| mterry | Saviq, truly, even for things like accountsservice, accountsservice can be considered the source data, and even the session would pull data from it | 14:34 |
| mzanetti | tsdgeos: could have left it in one of the others, but I decided its better structured this way | 14:34 |
| Saviq | mterry, sure, that would be possible as well | 14:35 |
| mzanetti | tsdgeos: I see this quite frequently: https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/390/testReport/junit/%28root%29/ListViewWithPageHeaderTestSection/growWindowAtBottom/ | 14:35 |
| Saviq | mterry, that doesn't preclude a separate greeter-only set of plugins | 14:35 |
| mterry | Saviq, yup | 14:35 |
| Saviq | mterry, that override those that would normally be used by the shell | 14:36 |
| mterry | Saviq, we may indeed want our own set of plugins. But not yet I don't think | 14:36 |
| tsdgeos | mzanetti: that's bad | 14:36 |
| Saviq | mterry, sure, I wasn't saying right now | 14:36 |
| mterry | yar | 14:36 |
| tsdgeos | mzanetti: let me finish your review and then see if i can loop it and see how it goes | 14:37 |
| Saviq | mterry, although the fact that we need --fake now to get the shell to run did trigger me thinking about this :) | 14:37 |
| mzanetti | tsdgeos: ok | 14:37 |
| Saviq | mterry, are we supposed to be able to just consume the usermetricsservice from a user session, btw? | 14:37 |
| === alan_g is now known as alan_g|tea | ||
| mterry | Saviq, I believe that's what the libusermetricsinput1 library is for (vs the libusermetricsoutput1 library that the greeter consumes) | 14:38 |
| Saviq | pete-woods, maybe a "you" question - should we be able to use libusermetricsoutput1 from a user session? | 14:39 |
| Saviq | pete-woods, i.e. is that the reason why we're failing to connect to the service? is it only accessible from the greeter session? | 14:39 |
| pete-woods | Saviq: definitely | 14:40 |
| pete-woods | Saviq: no, the reason you can't connect is to do with dbus being very strict, I think | 14:40 |
| Saviq | pete-woods, ok, so for some reason we can't (it's blocking for like 15s) | 14:40 |
| Saviq | pete-woods, let me know if we can help debugging that | 14:40 |
| pete-woods | Saviq: basically I say "only this user can own the service", but when the config files get put in /etc/dbus-1/... the user doesn't exist yet | 14:41 |
| tsdgeos | mzanetti: what's the expected startup position for the Laucnher? | 14:41 |
| tsdgeos | at bottom? | 14:41 |
| pete-woods | Saviq: so you have to "touch /etc/dbus-1/system.d/com.canonical.UserMetrics.conf" | 14:41 |
| mzanetti | the side where the Home button is should be unfolded | 14:41 |
| tsdgeos | ok | 14:41 |
| pete-woods | Saviq: I have added it to the packaging rules in 1.0.3 | 14:41 |
| Saviq | pete-woods, indeed, so fixed already, thanks! | 14:42 |
| Saviq | mzanetti, are you sure you saw https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/390/testReport/junit/%28root%29/ListViewWithPageHeaderTestSection/growWindowAtBottom/ more than once? | 14:43 |
| Saviq | mzanetti, first time I saw it | 14:43 |
| Saviq | mzanetti, tsdgeos there's two other failures in there, though | 14:43 |
| Saviq | https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/381/testReport/junit/%28root%29/ListViewWithPageHeaderTestSection/testCreationDeletion/ | 14:43 |
| Saviq | https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/354/testReport/junit/%28root%29/ListViewWithPageHeaderTestSection/testInsertItemsBeforeValidIndex/ | 14:43 |
| Saviq | but all three of them I only saw once | 14:43 |
| tsdgeos | mzanetti: that timer looks spooky | 14:43 |
| mzanetti | tsdgeos: yeah... any better idea? | 14:44 |
| mzanetti | tsdgeos: actually its sort of invokeMethod(Qt::QueuedConnection) | 14:44 |
| mzanetti | tsdgeos: as the interval 1 makes it run the next time the event loop idles. Its not that I wait for a random time until hopefully everything is done | 14:45 |
| mzanetti | tsdgeos: also, there is a test which tests this. It doesn't seem to fail in jenkins so its kinda a confirmation that its not a problem on slow systems | 14:46 |
| tsdgeos | mzanetti: is there? | 14:47 |
| tsdgeos | i commented the code and test still passed :D | 14:47 |
| mzanetti | noooooo | 14:47 |
| mzanetti | really? | 14:47 |
| tsdgeos | yeah | 14:47 |
| mzanetti | damn | 14:47 |
| * mzanetti fixes | 14:47 | |
| tsdgeos | mzanetti: http://paste.kde.org/~tsdgeos/788318/ | 14:48 |
| mzanetti | tsdgeos: ah yeah... you never set it to snapped now | 14:49 |
| mzanetti | tsdgeos: in that case it starts up as it should, but later snapping is not working | 14:49 |
| mzanetti | tsdgeos: but try to set snapping directly in the beginning, or in onCompleted. that will make the test fail | 14:49 |
| tsdgeos | is there a way we can make the tests fail if no snapping is set? | 14:50 |
| tsdgeos | i.e. flick a bit and check x,y coords of something | 14:50 |
| mzanetti | tsdgeos: hmm... well, I guess I could compare(listView.snapping, true | 14:52 |
| tsdgeos | that'd be cheating :D | 14:52 |
| mzanetti | tsdgeos: by the time the test runs that init logic should have happened already | 14:52 |
| mzanetti | tsdgeos: no, in combination with the initUnfolded test its not I'd say | 14:52 |
| tsdgeos | mzanetti: so why is snapping from the beginning a problem exactly? | 14:53 |
| mzanetti | tsdgeos: set it and you'll see | 14:53 |
| === alan_g|tea is now known as alan_g | ||
| Saviq | yay! we're flipping! | 14:54 |
| mzanetti | tsdgeos: also the comment on the timer should explain it, I hope. If not, I need to improve it | 14:54 |
| tsdgeos | well, it says "if i snap to the beginning it fails" | 14:55 |
| tsdgeos | doesn't tell me why | 14:55 |
| tsdgeos | anyway i did http://paste.kde.org/~tsdgeos/788324/ and tests are still passing :-S | 14:55 |
| tsdgeos | mzanetti: ↑↑ | 14:55 |
| * mzanetti -> pacepalm | 14:55 | |
| mzanetti | tsdgeos: ok... will check again in a minute... | 14:56 |
| tsdgeos | thanks | 14:56 |
| rsalveti | didrocks: well, noticed you already merged the qtubuntu one :-) | 14:59 |
| mzanetti | tsdgeos: regarding the comment... I think it says quite more than "if i snap to the beginning it fails" | 14:59 |
| mzanetti | tsdgeos: I mean line 45 in the diff | 14:59 |
| rsalveti | didrocks: any other pending mr? | 14:59 |
| tsdgeos | mzanetti: sure it does say a lot more, but tbh the jump from "snapping from the beginning" to "might cause the first item to be half folded at the beginning" is a bit of a "leap of faith" to me | 15:01 |
| mzanetti | tsdgeos: ok. I'll improve it | 15:01 |
| didrocks | rsalveti: yeah, I merged it once ogra has sent his email | 15:01 |
| didrocks | rsalveti: I'm just building it as part of dailies and then will update the seed + upload | 15:02 |
| tsdgeos | mzanetti: thanks :-) Also having the test fail would be cool :-) | 15:02 |
| didrocks | this will free Saviq (libunity is already testing) | 15:02 |
| Saviq | didrocks, I'm fixing the branch, too | 15:02 |
| rsalveti | didrocks: cool | 15:06 |
| mzanetti | tsdgeos: ok... the reason why the test wasn't failing is because I resized the window after writing the test... | 15:26 |
| mzanetti | tsdgeos: unluckily the new size did not trigger the snapping | 15:26 |
| mzanetti | tsdgeos: so I'll add a verify() that the launchers height is in fact one that causes the issue | 15:27 |
| tsdgeos | cool | 15:27 |
| mzanetti | tsdgeos: bad news is, I'm hitting a bug somewhere and I guess it'll take me a bit to figure it out | 15:27 |
| tsdgeos | ok, no worries | 15:28 |
| mzanetti | tsdgeos: problem is, if I set the snapping some inner logic in QML is updated to fold the icon while the painting part is not | 15:28 |
| mzanetti | tsdgeos: try this: do a ./run and reveal the launcher | 15:28 |
| mzanetti | tsdgeos: you will see the launcher looks as it should | 15:28 |
| mzanetti | tsdgeos: but then try to click on an icon if you're careful enough you'll notice the whole view jumping a bit | 15:29 |
| tsdgeos | wow | 15:29 |
| tsdgeos | i'm not that fast :D | 15:29 |
| tsdgeos | need a faster set of eyes | 15:29 |
| tsdgeos | launcher hides too quickly | 15:30 |
| mzanetti | tsdgeos: if you click on the phone app you will notice that the list is flicked upwards instead of launching the phone-app | 15:30 |
| tsdgeos | ah | 15:30 |
| mzanetti | tsdgeos: thats because the inner logic says, yep, it is folded for more than 12 degrees | 15:30 |
| mzanetti | tsdgeos: while the UI still painted it as non-folded | 15:30 |
| tsdgeos | trueth | 15:31 |
| tsdgeos | test++! | 15:31 |
| mzanetti | tsdgeos: tbh I'm a bit lost | 15:31 |
| mzanetti | tsdgeos: how the heck can I make sure this thing is unfolded in the beginning while still keeping the highlight area in the middle of the view and have snapping to that enabled? | 15:32 |
| tsdgeos | mzanetti: why the highlight in are is in the middle? | 15:33 |
| tsdgeos | E_CANT_TYPE | 15:33 |
| mzanetti | tsdgeos: because design requirement is that folding is symmetrical | 15:33 |
| Saviq | mzanetti, hmm hanging http://10.97.2.10:8080/job/unity-phablet-qmluitests-saucy/393/console ? | 15:42 |
| mzanetti | Saviq: maybe... but if yes, I'd say because of an endless loop in the test | 15:43 |
| tsdgeos | phew, not me :D | 15:43 |
| Saviq | mzanetti, it feels like it's not using the fake Unity plugin | 15:44 |
| mzanetti | Saviq: right... that might be | 15:45 |
| Saviq | mzanetti, otoh I'm getting the same errors locally, so maybe not in the end | 15:45 |
| Saviq | or not, the scopes are not installed at all | 15:46 |
| tsdgeos | mzanetti: i'm confused :D So the phone item (the one at the bottom) is index 0 but i can't find where you tell the list you'll be bottomup instead topbottom :-S | 15:46 |
| mzanetti | tsdgeos: hehe | 15:46 |
| mzanetti | tsdgeos: LauncherPanel.qml | 15:47 |
| mzanetti | tsdgeos: inverted: true | 15:47 |
| tsdgeos | mzanetti: but that only affects the delegate not the list | 15:48 |
| tsdgeos | are you basically painting the delegate somewhere else it thinks it is? | 15:48 |
| tsdgeos | or¿? | 15:48 |
| mzanetti | tsdgeos: no... the listView is rotated | 15:48 |
| tsdgeos | arg | 15:48 |
| tsdgeos | right | 15:48 |
| tsdgeos | why that instead ListView.BottomToTop? | 15:49 |
| mzanetti | tsdgeos: Saviq: what's also really weird. I have a MouseArea and onClicked I call listView.flick(). That _always_ works and flicks 4 items | 15:49 |
| tsdgeos | ah because we don't want bottomtotop | 15:49 |
| tsdgeos | obviously | 15:49 |
| mzanetti | tsdgeos: but when I call mouseArea.clicked() programmatically, which should do the same, it's not strong enough to flick the list over the snapping | 15:49 |
| mzanetti | Saviq: ^ | 15:49 |
| Saviq | mzanetti, "not strong enough"? wth? | 15:50 |
| mzanetti | yeah exactly | 15:50 |
| tsdgeos | mzanetti: both under qmltestrunner? | 15:50 |
| mzanetti | qmlscene | 15:50 |
| Saviq | mzanetti, shit, it's hanging here, too http://10.97.2.10:8080/job/unity-phablet-qmluitests-saucy/393/console | 15:51 |
| tsdgeos | mzanetti: weird :S | 15:51 |
| Saviq | uh | 15:51 |
| Saviq | or does it | 15:51 |
| mzanetti | tsdgeos: Saviq: lp:~mzanetti/unity8/dafuq-is-happening | 15:52 |
| Saviq | mzanetti, lol | 15:52 |
| mzanetti | reveal the launcher and make the phone-app icon half-folded | 15:52 |
| Saviq | pstolowski, merged! | 15:54 |
| Saviq | pstolowski, jeez that took ages | 15:54 |
| pstolowski | Saviq: yeah, seen that. finally :) | 15:55 |
| Saviq | mzanetti, now it hangs at the finish here http://10.97.2.10:8080/job/unity-phablet-qmluitests-saucy/394/console ? | 15:57 |
| tsdgeos | mzanetti: at least i can tell you why clicking on the phone makes it do weird stuff | 15:57 |
| Saviq | mzanetti, awesome! | 15:57 |
| Saviq | mzanetti, it's alive :D | 15:57 |
| * mzanetti is listening | 15:57 | |
| mzanetti | Saviq: huh? | 15:57 |
| tsdgeos | mzanetti: priv.distanceFromEdge is -22 and that's why you get a -30 as angle | 15:58 |
| tsdgeos | now, why priv.distanceFromEdge is -22 that's something you need to find out :D | 15:58 |
| * Saviq makes a video | 15:58 | |
| mzanetti | Saviq: ah, you mean the flicks in the launcher? | 15:58 |
| mzanetti | Saviq: yeah, thats a timer that clicks on the mousearea every few seconds | 15:58 |
| mzanetti | Saviq: to demonstrate that if you click it manually it works, but if the timer does it, its not strong enough | 15:59 |
| Saviq | mzanetti, we wanted a heartbeat, we have a heartbeat :) | 15:59 |
| Saviq | mzanetti, actually it does, I think | 15:59 |
| Saviq | mzanetti, it flattens out completely here | 15:59 |
| mzanetti | Saviq: all the time? | 15:59 |
| mzanetti | Saviq: here it fails to flatten in most of the cases | 16:00 |
| Saviq | mzanetti, it takes two clicks, but yeah | 16:00 |
| mzanetti | hmm... doesn't work here :/ | 16:01 |
| Saviq | mzanetti, ok got it to fail when swipied | 16:02 |
| Saviq | swpied | 16:02 |
| Saviq | swiped | 16:02 |
| Saviq | ! | 16:02 |
| Saviq | http://10.97.2.10:8080/job/unity-phablet-qmluitests-saucy/394/console | 16:02 |
| Saviq | urgh | 16:02 |
| Saviq | http://ubuntuone.com/67BJJcwJaj5ut99P1Lf6J9 | 16:03 |
| Saviq | mzanetti, if I click to move the list, it works | 16:03 |
| Saviq | mzanetti, but not if I swipe | 16:03 |
| Saviq | mzanetti, so it feels like the overshot influences that | 16:03 |
| Saviq | mzanetti, wth http://10.97.2.10:8080/job/unity-phablet-qmluitests-saucy/394/console :/ | 16:04 |
| Saviq | mzanetti, it's like that for 10 minutes now | 16:04 |
| mzanetti | Saviq: yeah... already investigating in the qmltests | 16:04 |
| mzanetti | Saviq: does that hang all the time? | 16:05 |
| mzanetti | or just sometimes? | 16:06 |
| Saviq | mzanetti, first two times I noticed | 16:06 |
| Saviq | mzanetti, and it hangs in a different place now | 16:06 |
| Saviq | mzanetti, the second and third jobs here v | 16:07 |
| Saviq | http://s-jenkins:8080/job/unity-phablet-qmluitests-saucy/ | 16:07 |
| Saviq | dednick, there's a bunch of conflicts in indicators-client I'm afraid | 16:07 |
| dednick | grrraw! | 16:07 |
| tsdgeos | mzanetti: something that i think will help you debug your problem with the angle, just comment out the whole onClicked in the delegate | 16:08 |
| tsdgeos | and click on the phone icon | 16:08 |
| tsdgeos | see that it gets angled | 16:08 |
| mzanetti | Saviq: oh, now I see what you mean with 394... thats weird | 16:08 |
| mzanetti | fginther: help please! | 16:09 |
| fginther | mzanetti, you called? | 16:09 |
| mzanetti | fginther: seen this before? http://10.97.2.10:8080/job/unity-phablet-qmluitests-saucy/394/console | 16:09 |
| mzanetti | tsdgeos: yeah, seems like qml is out of sync somehow | 16:09 |
| tsdgeos | mzanetti: my understanding is that clicking on it makes it the currentitem and some bad things happen with the contentY that break your angle calculations | 16:09 |
| tsdgeos | i.e. the list "moves" when clicking in it | 16:10 |
| tsdgeos | and that is what makes your angle change | 16:10 |
| mzanetti | tsdgeos: no... I don't think it makes it the current item | 16:11 |
| tsdgeos | mzanetti: well, the contentY of the list is changing | 16:11 |
| tsdgeos | something makes it change | 16:11 |
| fginther | mzanetti, does this appear stuck to you as well? | 16:11 |
| mzanetti | tsdgeos: as I said, I think qml is somehow out of sync because the snapping wants the list somewhere else then it actually is | 16:12 |
| mzanetti | fginther: yeah... sits there for like 10 mins | 16:12 |
| mzanetti | fginther: and we have some other jobs that are hanging too | 16:12 |
| fginther | mzanetti, *maybe* it's coping files to archive, but that's just a guess | 16:12 |
| fginther | mzanetti, I'll hope on the VM and see if ps doesn't help | 16:12 |
| fginther | s/hope/hop/ | 16:12 |
| mzanetti | fginther: the other jobs are hanging somewhere else | 16:12 |
| fginther | gah! | 16:13 |
| mzanetti | fginther: http://10.97.2.10:8080/job/unity-phablet-qmluitests-saucy/393/console | 16:13 |
| mzanetti | fginther: seems like the VM's are frozen and jenkins still keeping the pipe open waiting for more data | 16:13 |
| mzanetti | ok. someone killed it now | 16:13 |
| fginther | mzanetti, I didn't kill it, Saviq did you kill it? | 16:14 |
| Saviq | fginther, nope | 16:14 |
| mzanetti | maybe timeout | 16:15 |
| mzanetti | IIRC they are killed after 1.5 hours or so | 16:15 |
| mzanetti | oh yeah: Build timed out (after 60 minutes). Marking the build as failed. | 16:15 |
| fginther | 393 only ran for 1 hour | 16:15 |
| fginther | ok, that's it then | 16:15 |
| Saviq | yeah, it timed out | 16:15 |
| Saviq | the other one SUCCESSed | 16:16 |
| Saviq | 394 | 16:16 |
| Saviq | after having hung (hanged?) for 15 mins or so at "closing log"... | 16:16 |
| mzanetti | hmm... maybe related to the other VM going down | 16:16 |
| mzanetti | freed up some resource that made this one continue | 16:16 |
| tsdgeos | mzanetti: right the index is not changing | 16:17 |
| tsdgeos | mzanetti: but contentY is | 16:17 |
| mzanetti | tsdgeos: yeah... but I actually think the issue is this | 16:17 |
| mzanetti | tsdgeos: I set contentY somehow (with that timer for example) | 16:17 |
| tsdgeos | mzanetti: i can try to debug it tomorrow with my compiled 5.1 and see who is changing contentY if you want | 16:17 |
| mzanetti | tsdgeos: that does not work well with the defined snapping | 16:17 |
| mzanetti | so what happens is that contentY is set, but not all the other states updated accordingly | 16:18 |
| Saviq | I triggered a rebuild of the one that timed out | 16:18 |
| Saviq | let's see | 16:18 |
| Saviq | mzanetti, fginther ↑ | 16:18 |
| mzanetti | tsdgeos: once there is interaction from the mouse, contentY is adjusted to what it should be according to the other states | 16:18 |
| fginther | mzanetti, after looking at the files archived, I don't think that was the problem (there was nothing huge). Perhaps the VM host was overwhelmed, it is close to capacity | 16:18 |
| mzanetti | tsdgeos: does that make somehow sense to you? | 16:18 |
| fginther | Saviq, will watch | 16:18 |
| mzanetti | ack | 16:19 |
| mzanetti | fginther: btw... I told this mmrazik some time ago already but I fear someone else needs to catch up with this: | 16:19 |
| Saviq | fginther, /me too | 16:19 |
| mzanetti | fginther: some time back I monitored naartjie for its usage because we were struggling with having 4 VM's there | 16:20 |
| fginther | mzanetti, and now we have a bazillion? | 16:20 |
| mzanetti | fginther: turns out the machine's CPU is 95% idle all the time, the memory consumption is like 10% of it | 16:20 |
| mzanetti | fginther: BUT: disk IO waits are more than 10% | 16:20 |
| tsdgeos | mzanetti: not sure tbh, bit tired atm, talk tomorrow, ok? | 16:21 |
| mzanetti | fginther: so imho we are wasting 95% of naartjies resources waiting for its HDD | 16:22 |
| mzanetti | tsdgeos: ok, sure | 16:22 |
| mzanetti | tsdgeos: thanks a bunch already | 16:22 |
| fginther | mzanetti, the sys admin has already mentioned the need to rework the hardware resources... I'll ping him again and see if the solution is already in the works. | 16:22 |
| fginther | mzanetti, thanks for the reminder | 16:23 |
| fginther | mzanetti, what tool were you using to collect your data? | 16:23 |
| mzanetti | fginther: just sitting there and watching top for a while | 16:23 |
| fginther | mzanetti, ack | 16:24 |
| mzanetti | fginther: try to do anything on your machines, you won't be able to get disk IO's > 1% unless you really badly mess with the system | 16:24 |
| mzanetti | fginther: watch top on naartjie and there is everything close to 0 except big IO waits | 16:24 |
| mzanetti | fginther: and you feel the VM's getting lots slower whenever the IO waits are bigger than like 3% | 16:25 |
| fginther | mzanetti, I'll check it out | 16:26 |
| dednick | mzanetti: ping | 16:40 |
| mterry | pete-woods, can you propose https://pastebin.canonical.com/93700/ ? I don't remember why that was a proposed change, besides to "fix things" | 16:44 |
| nic-doffay | Saviq, would the parent view of the OptionSelector handle scrolling if the OptionSelector expands below the view bounds? | 16:47 |
| mzanetti | dednick: pong | 16:51 |
| dednick | mzanetti: hey. was just wondering how CI runs the autopilot tests. where does it get the commands from? | 16:52 |
| dednick | eg autopilot run unity8 | 16:52 |
| mzanetti | dednick: job parameters | 16:52 |
| mzanetti | dednick: actually... I think jenkins doesn't support multiple test suites (yet) | 16:52 |
| dednick | mzanetti: ok. i htink i'll just leave it as a single target for now then | 16:53 |
| mzanetti | dednick: I could create a test job for you | 16:53 |
| mzanetti | dednick: shouldn't be too hard to hack support for multiple targets in | 16:54 |
| mzanetti | dednick: do you have a branch that would do everything already? | 16:54 |
| dednick | mzanetti: or the other option is to create multiple targets + a global one, | 16:54 |
| mzanetti | dednick: jenkins doesn't run make autopilot | 16:55 |
| dednick | mzanetti: ah right | 16:55 |
| mzanetti | dednick: it installs the autopilot package into the system and runs "autopilot run $test_suite" | 16:55 |
| dednick | so it would be running 'autopilot run unity8'? | 16:55 |
| dednick | i c | 16:55 |
| mzanetti | yeah. thats what it does | 16:55 |
| mzanetti | so to have a single target we would need one python autopilot test suite that calls the others | 16:56 |
| dednick | mzanetti: my indicators-client branch has a indicators_client ap suite. | 16:56 |
| dednick | hm | 16:56 |
| dednick | mzanetti: doesnt REALLY matter right now. it is a very simple siute, but i want to get started on some more fairly soon | 16:57 |
| mzanetti | dednick: ok. I'll have a test run | 16:59 |
| mterry | pete-woods, I filed https://code.launchpad.net/~unity-team/unity8/older-months/+merge/172860 -- please fill out with your infographic smarts | 16:59 |
| mhr3 | pete-woods, hilfe - unity/source/libusermetrics/src/libusermetricsinput/MetricImpl.cpp:56:50: error: ‘logic_error’ was not declared in this scope | 17:00 |
| mhr3 | pete-woods, where is that supposed to come from? | 17:01 |
| mhr3 | hm, stdexcept, who would have expected that | 17:02 |
| === alan_g is now known as alan_g|EOD | ||
| mzanetti | dednick: do you have a jenkins run on your branch that created packages for the multiple autopilot test suites? | 17:14 |
| mzanetti | dednick: I think I should have a job now that can do that | 17:15 |
| dednick | there's only a single package | 17:15 |
| dednick | but 2 suites | 17:15 |
| mzanetti | dednick: doesn't matter. should work | 17:15 |
| mzanetti | dednick: do you have a link perhaps? | 17:19 |
| dednick | mzanetti: https://code.launchpad.net/~unity-team/unity8/indicators-client | 17:19 |
| mzanetti | dednick: it has conflicts | 17:23 |
| mzanetti | dednick: and no recent ci run that would have built the packages | 17:23 |
| mzanetti | dednick: please fix the conflicts and ping me when CI as run over it. then I can grab the package and run through my testing job | 17:24 |
| dednick | mzanetti: ah. sorry, i pushed latest to wrong branch | 17:24 |
| Saviq | veebers, ping | 17:24 |
| Saviq | right, won't answer on 5am ;) | 17:25 |
| Saviq | mzanetti, ideas about traceback-1 from https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/597/testReport/junit/unity8.tests.testlockscreen/TestLockscreens/test_unlock_wrong_Pinlock_/ ? | 17:32 |
| dednick | sigh.. bring back the days when it took 3 seconds to build unity8 | 17:34 |
| mzanetti | Saviq: code-wise: lightdm didn't respond to the authenticate() call | 17:34 |
| mzanetti | Saviq: did anything change when loading the libs? | 17:35 |
| Saviq | mzanetti, no, I meant the python traceback | 17:35 |
| Saviq | mzanetti, not the test failure | 17:35 |
| Saviq | mzanetti, TypeError: on_test_end() takes no arguments (2 given) | 17:35 |
| mzanetti | oh... traceback-1 | 17:35 |
| Saviq | mzanetti, re: the failure, not that I know of, restarted and will check again (it might be) | 17:35 |
| Saviq | we've moved all the libs around enough for this to break... | 17:36 |
| mhr3 | how do i get some useful info from make test? | 17:36 |
| mzanetti | Saviq: hmm...the on_test_end(). no, haven't seen that before | 17:36 |
| Saviq | mhr3, CTEST_OUTPUT_ON_FAILURE=1 | 17:36 |
| Saviq | mzanetti, it's everywhere here https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/597/testReport/? | 17:37 |
| mhr3 | Saviq, dzenkuje | 17:37 |
| Saviq | mhr3, ę | 17:37 |
| Saviq | mhr3, but proszem | 17:37 |
| mhr3 | don't have that here :) | 17:37 |
| Saviq | Není zač | 17:38 |
| mhr3 | meh, google translate cheating :P | 17:40 |
| Saviq | -translate ;) | 17:40 |
| Saviq | just google | 17:40 |
| mhr3 | you guys are making it harder and harder to run this on precise | 17:42 |
| sergiusens | mzanetti: what do you mean by multiple test suites in jenkins? | 17:42 |
| mzanetti | sergiusens: hi. how come you know of this? :P | 17:43 |
| mzanetti | sergiusens: unity8-autopilot installs multiple test suites now. unity8, indicators_client | 17:43 |
| sergiusens | mzanetti: read the back log ;-) | 17:43 |
| mzanetti | sergiusens: I just modded the job to run a for-loop over $test_suites instead of just calling it on $test_suite | 17:44 |
| sergiusens | mzanetti: so from a jenkins perspective you should be able to collect them | 17:44 |
| mzanetti | sergiusens: so a space separated list should do | 17:44 |
| sergiusens | mzanetti: ah, great | 17:44 |
| Saviq | mhr3, hum? ;) | 17:47 |
| mhr3 | Saviq, https://code.launchpad.net/~mhr3/unity8/use-dee-filtermodel/+merge/171846 you know you want to ack it, right? :) | 18:02 |
| Saviq | mhr3, I do, assuming I will review it first :) | 18:03 |
| Saviq | mterry, shite, I missed the powerd meeting (my calendar hates me, as usual) | 18:03 |
| mhr3 | Saviq, oh you do actual reviews? i thought you just copy hidden bot messages around ;) | 18:04 |
| Saviq | mhr3, when there's no more hidden bot messages, yes! | 18:04 |
| mterry | Saviq, you saw the notes? | 18:05 |
| Saviq | mterry, yeah, reading now | 18:06 |
| Saviq | mterry, anything else I should know? or maybe provide input for? | 18:06 |
| mterry | Saviq, from my end, no. It sounds like powerd will be able to provide the interface for blanking, so I'll wait on that for the final 'show greeter on blank' fix | 18:07 |
| Saviq | mterry, k | 18:08 |
| mzanetti | dednick: http://s-jenkins:8080/job/generic-mediumtests-runner-testing/ | 18:10 |
| mzanetti | dednick: this will run your branch now with 2 test suites | 18:10 |
| * mzanetti crosses fingers | 18:10 | |
| Saviq | mterry, would those failures suggest LD_LIBRARY_PATH is not set correctly http://10.97.2.10:8080/job/generic-mediumtests-saucy/671/ ? | 18:12 |
| Saviq | yes it does... | 18:13 |
| Saviq | seb128, if you're still around... any idea how to find the multiarch libdir in a python script? | 18:15 |
| Saviq | ah sysconfig! | 18:16 |
| mterry | Saviq, yeah, could be pointing at 'single' instead of 'single-pin' or some such | 18:17 |
| Saviq | mterry, yeah, it points at a non-existing dir after we've moved stuff around | 18:17 |
| mterry | Saviq, or even maybe QML_IMPORT_PATH is wrong and we're using real LightDM plugin | 18:17 |
| mterry | Saviq, ah | 18:17 |
| pete-woods | mterry: sorry, just got back from re-attaching the exhaust pipe to my car :/ | 18:20 |
| pete-woods | mterry: have added details to that commit | 18:24 |
| mterry | pete-woods, thanks man | 18:25 |
| mterry | pete-woods, you can't use wild animals as exhaust pipes, they'll just keep running off on you | 18:25 |
| pete-woods | mterry: :p | 18:26 |
| pete-woods | mhr3: sorry for not getting back sooner, have you managed to compile libusermetrics now? | 18:26 |
| pete-woods | I'm a bit puzzled why built-in C++ classes wouldn't be visible | 18:26 |
| mzanetti | dednick: looks good. just one small mistake but I think the next run should succeed | 18:43 |
| === seb128_ is now known as seb128 | ||
| === bschaefer_ is now known as bschaefer | ||
| === jhodapp is now known as jhodapp|holiday | ||
| mhall119 | so when I have a lot of apps open on my Nexus 7, the unity8 process consistently runs at about 10% - 30% CPU utilization when sitting on the Apps lens | 21:47 |
| mhall119 | since all of those apps should have their process suspended, I would expect more CPU idle than this | 21:48 |
| mhall119 | it doesn't appear that any of the app processes are active, so something just with unity8 | 21:49 |
| mhall119 | Saviq: ^^ what can I do to help determine why this is? | 21:50 |
| Saviq | mhall119, we had a report like this some days ago, just didn't mention that apps need to be running | 21:50 |
| Saviq | mhall119, if we can reproduce we'll have a look | 21:51 |
| Saviq | mhall119, obviously it should be idle | 21:51 |
| mhall119 | Saviq: I have 17 apps open, all of them QML apps using qmlscene | 21:51 |
| Saviq | mhall119, 17!? and they're not killed? | 21:51 |
| Saviq | mhall119, nice one ;D | 21:51 |
| mhall119 | which, granted, multi-tasking 17 apps on a nexus 7 is pretty damn impressive on it's own | 21:51 |
| Saviq | mhall119, regardless, should be idle | 21:52 |
| Saviq | mhall119, we'll have a look tomorrow | 21:52 |
| mhall119 | ok, let me know if there's some extra data I can get you | 21:52 |
| Saviq | mhall119, will try and reproduce now | 21:54 |
| mhall119 | Saviq: looks like a combination of unity8 and surfaceflinger | 22:01 |
| mhall119 | if that helps any | 22:01 |
| Saviq | mhall119, yeah, I expect something to be pinging the shell unnecessarily | 22:02 |
| Saviq | mhall119, resulting in UI updates | 22:02 |
| === salem_ is now known as _salem | ||
| Saviq | mhall119, can't reproduce on neither manta or maguro :/ | 22:38 |
| Saviq | mhall119, several apps, unity8 goes down to 0.naught CPU | 22:38 |
| Saviq | to the point where htop is at the top with 5% | 22:38 |
| Saviq | mhall119, will ask the guys tomorrow to try on all the devices we have around | 22:42 |
| mhall119 | Saviq: like I said, I'm happy to provide whatever data I can from my N7 | 23:10 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!