| gary_poster | huwshimi, sorry went in and out with other obligations. qa is good, code looks good. could you lbox propose again so rietveld shows the new changes? I will then give LGTM. YOu can land yourself, right? | 00:02 |
|---|---|---|
| gary_poster | Or do you need me to? | 00:02 |
| huwshimi | Will do. I can land (assuming it works). | 00:03 |
| gary_poster | huwshimi, cool thanks. btw did you mean to hide the search when you minimize? | 00:03 |
| gary_poster | that functionality isn't ready yet maybe? | 00:03 |
| huwshimi | gary_poster: Yeah, the search doesn't work yet (so removed it). | 00:03 |
| huwshimi | gary_poster: It also looks from that prototype that the search will be for the canvas when the sidebar is minimised. | 00:04 |
| gary_poster | huwshimi yeah I asked luca about that. he said he simply wanted the priorities reversed | 00:04 |
| gary_poster | so | 00:04 |
| gary_poster | when the sidebar or fullscreen is open | 00:04 |
| gary_poster | you get charm search results first, and canvas/environment service results second | 00:05 |
| gary_poster | when it is minimized | 00:05 |
| gary_poster | services are first and charms are second | 00:05 |
| huwshimi | Ah I see | 00:05 |
| gary_poster | I wouldn't be surprised if what you have now is what we can deliver for OSCON in this regard | 00:05 |
| gary_poster | but we'll see | 00:06 |
| huwshimi | gary_poster: We have no autocomplete at all at the moment | 00:07 |
| gary_poster | huwshimi, yeah. I'm not sure if autocomplete is required or not for that. | 00:08 |
| huwshimi | gary_poster: Changes should be there now... | 00:08 |
| gary_poster | huwshimi, yes, looking thank you | 00:09 |
| gary_poster | huwshimi, LGTM | 00:12 |
| huwshimi | gary_poster: Thankyou. | 00:12 |
| gary_poster | thank you huwshimi! | 00:12 |
| gary_poster | have a good week | 00:13 |
| huwshimi | gary_poster: Thanks you too | 00:13 |
| gary_poster | hatch fwiw trunk will be ready for 0.7.2 once huwshimi's branch lands, I think :-) | 00:13 |
| huwshimi | gary_poster, hatch: Merged. | 00:23 |
| * hatch walks into an empty office | 14:02 | |
| === _mup__ is now known as _mup_ | ||
| rick_h | benji: still need anything? | 19:48 |
| hatch | hey rick_h | 20:31 |
| huwshimi | Morning | 22:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!