wgrantStevenK: Why shouldn't bug #941926 crash?06:25
_mup_Bug #941926: InvalidTransition: Transition from Completed to Waiting is invalid. <oops> <package-copies> <queue-page> <Launchpad itself:Triaged> <https://launchpad.net/bugs/941926>06:25
StevenKwgrant: I just thought it should actually give a nice error message rather than an OOPS06:27
wgrantStevenK: Why shouldn't it OOPS?06:27
StevenKBecause we have a policy06:28
StevenKWHERE "auditor_auditor"."object" IN (foo) GROUP BY (object), (operation), "auditor_auditor"."object", "auditor_auditor"."operation", "auditor_auditor"."date"06:28
StevenKDear Django, I HATE you06:28
wgrantBut I could fulfill the word of that policy with an unconditional except:06:28
wgrantThat displays an error page06:28
wgrantTurning data corruption into an error message rather than OOPS is the opposite of progress06:29
StevenKwgrant: It can happen when data isn't corrupted, though06:29
wgrantStevenK: How?06:29
wgrantComplete job with unaccepted queue entry sounds like data corruption to me06:30
StevenKacceptFromQueue() doesn't check, it just forces it to be accepted06:30
StevenKwgrant: Archive Admin A and B both load +queue, A accepts the sync, while B goes to make a coffee. B comes back, the job has completed and submits the form -- OOPS.06:30
wgrantRight, so you're papering over a real and dangerous bug06:31
wgrantSurely the problem is the double accept06:31
wgrantIf acceptFromQueue can today be called on a DONE or ACCEPTED entry, we have a data corruption bug06:32
wgrantThat is the bug here, not the InvalidTransition OOPS06:32
StevenKOh, screw you Django06:34
StevenKwgrant: Hm, we already check06:38
StevenKwgrant: Hm, it will croak on ACCEPTED, but not DONE06:50
=== tasdomas` is now known as tasdomas_afk
=== tasdomas_afk is now known as tasdomas
=== mbarnett` is now known as mbarnett
=== tasdomas is now known as tasdomas_afk
cjohnstonUrsinha: ping16:59
Ursinhacjohnston, pong17:29
cjohnstonhey Ursinha.. Was there any further progress ever on exporting all subscribers for blueprints?17:29
Ursinhacjohnston, not really, I guess we need to start a discussion somewhere to figure out the impact and what to do (I guess that's what was said, iirc)17:30

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!