| === _mup__ is now known as _mup_ | ||
| abentley | sinzui: How's it coming with staging? | 13:13 |
|---|---|---|
| sinzui | abentley, ghastly | 13:13 |
| abentley | sinzui: Anything I can do to help? | 13:13 |
| sinzui | abentley, Two efforts to create apache have failed | 13:13 |
| abentley | sinzui: Yikes. | 13:14 |
| sinzui | abentley, Both deploys never got an IP, the agent state is pending | 13:14 |
| abentley | sinzui: Is it the IP address shortage? That would cause machines to fail to spin up at the nova level. | 13:14 |
| sinzui | abentley, and somehow I lost my branch that sanitises categories | 13:15 |
| sinzui | abentley, I have been using w3m and can confirm charmworld + mongodb + elasticsearch are happy | 13:16 |
| rick_h | sinzui: one trick there is to expose the charmworld app and it'll be present on the port 6543 I think? or 2464, whatever we default to now. | 13:16 |
| abentley | sinzui: Well, we could tranfer the external IP address to the charmworld app server if necessary. | 13:17 |
| sinzui | abentley, as rick_h wrote, the port will be 6543 | 13:17 |
| sinzui | abentley, Note I still see 645b2404-9179-4a8b-8136-7f238964aa6b | juju staging instance 4 | 13:18 |
| sinzui | ^ that is the zombie Juju thinks it destroyed | 13:18 |
| * sinzui ponders nova as a means to decommission the instance | 13:18 | |
| abentley | sinzui: You used terminate-machine? I am not sure whether it is reliable. | 13:19 |
| abentley | sinzui: The problem with terminating via nova is that the IP address famine means someone could take the address of that machine and we'd be unable to start a replacement. | 13:20 |
| sinzui | abentley, right | 13:21 |
| abentley | sinzui: Perhaps we should move staging to lcy01, but we'll need a new external IP address, so we'll need to re-map DNS. | 13:21 |
| sinzui | While I can use nova to suspend/resume, I cannot so anything that permits us to gain access to what runs in the vm. | 13:22 |
| abentley | sinzui: Rebooting doesn't help? | 13:22 |
| sinzui | abentley, we cannot ssh into it | 13:22 |
| abentley | sinzui: We cannot ssh into it in order to reboot it, or we cannot ssh into it after we reboot? | 13:23 |
| sinzui | before | 13:23 |
| sinzui | I could not ssh into it to see what was up and fallback to reboot | 13:23 |
| sinzui | I didn't see an alternate means to get into the instance using nova | 13:24 |
| abentley | sinzui: There is a "nova reboot" command. | 13:24 |
| sinzui | Didn't do anything for me yesterday. | 13:25 |
| abentley | sinzui: what about get-vnc-console? | 13:25 |
| sinzui | I don't know about that | 13:25 |
| sinzui | oh. | 13:26 |
| * sinzui checks backscroll | 13:27 | |
| sinzui | abentley, we might have a chance now | 13:27 |
| === teknico1 is now known as teknico | ||
| sinzui | reboot failed yesterday (while the instance was running), I destroyed two services since then and the reboot says I have an agent | 13:27 |
| abentley | sinzui: woot! | 13:28 |
| sinzui | We are now waiting for the third replacement apache to start and join charmworld | 13:29 |
| === teknico is now known as teknico-phone | ||
| hatch | morning | 14:14 |
| rick_h | party on hatch | 14:14 |
| hatch | looks like haswells are starting to make it into the lenovo's http://www.engadget.com/2013/07/09/lenovos-t440s-thinkpad-coming-soon/ | 14:15 |
| abentley | sinzui: The options migration failed deployment. I've rolled back to r298. Should be simple to fix, so I won'd do a rollback. | 14:22 |
| hatch | it will probably still only have an HDMI out making it useless for me heh | 14:22 |
| abentley | sinzui: i.e. I won't land a revert for now. | 14:22 |
| sinzui | abentley, understood | 14:22 |
| rick_h | luca: gary_poster has there been talk about any limitations to the autocomplete results? For example, only reviewed charms? | 14:29 |
| jcsackett | sinzui: chat? | 14:33 |
| sinzui | yes | 14:33 |
| jcsackett | sending invite. | 14:34 |
| luca | rick_h: not along those lines, gary_poster might have a plan but I'm not sure | 14:34 |
| hatch | rick_h: luca he is away today | 14:35 |
| luca | rick_h: hatch want to talk it through in about 10 mins? | 14:36 |
| hatch | well isn't it trivial to add filters to the ac results? | 14:36 |
| rick_h | luca: that's ok. I just wanted to double check as the approach is a bit different each way. | 14:36 |
| rick_h | hatch: well, basically it comes down to using a full model and token widgets to display the completion suggestions vs not. | 14:37 |
| hatch | ohh - ok well I would say use the token widget and then if we need to use ones with less information we can handle that in the GUI | 14:38 |
| rick_h | hatch: right, there's a bunch of logic on which icon to display, the reviewed badge, etc that would need to be duped and I'm trying to think through a DRY around all that. | 14:38 |
| rick_h | hatch: but, if we're only completing reviewed charm none of that logic matters so figured I'd ask :) | 14:38 |
| hatch | what makes a charm 'reviewed' | 14:39 |
| hatch | how long do they sit unreviewed? | 14:39 |
| rick_h | hatch: they're reviewed by a couple of the ~charmers team and most will probably never be reviewed. | 14:39 |
| hatch | never be reviewed? | 14:40 |
| rick_h | hatch: yea, if you fork the mysql charm and upload it to use it, it'll never really be reviewed as there's an official reviewed mysql charm out there. | 14:40 |
| hatch | ohh hmm | 14:41 |
| hatch | so the AC will only show 'approved' charms but the full search results will show all of them? | 14:41 |
| rick_h | hatch: yea, that's kind of the question. A/C is a method to shortcut to a selected charm. | 14:41 |
| rick_h | luca: hatch yea, let's chat if that's ok. I'd like to talk it out. | 14:42 |
| hatch | haha ok give me a few minutes | 14:42 |
| hatch | rick_h: luca in guichat | 14:44 |
| Makyo | luca, I've got a question when you have a moment. | 14:52 |
| luca | hatch: rick_h do we need to talk about search? I'll have a prototype to show you in roughly 5 mins? | 14:57 |
| hatch | sure pop in real quick | 14:57 |
| rick_h | abentley: got a sec to chat? | 15:10 |
| abentley | rick_h: Okay. | 15:10 |
| rick_h | luca: can you join in this call real quick? https://plus.google.com/hangouts/_/8e337c1da033485408fb4e6723267db4247e4f42?hl=en | 15:12 |
| luca | rick_h: sure | 15:13 |
| Makyo | jujugui, Can I add libpeerconnection.log to .bzrignore? It seems to be an empty file generated on test-server. | 15:17 |
| bac | SGTM | 15:17 |
| rick_h | sinzui: can you join the hangout ^^ please? Have a sec that is? | 15:18 |
| teknico | Makyo: ok to me | 15:18 |
| hatch | Makyo: let er rip | 15:19 |
| Makyo | Thanks. Will be in review in a mo'., | 15:19 |
| jcastro | augh, everytime I have to go to old jujucharms.com do to something I get disgusted. | 15:20 |
| jcastro | new GUI is sooooo nice | 15:20 |
| * hatch is glad that was before his time | 15:21 | |
| hatch | ;) | 15:21 |
| abentley | orangesquad: Could you please review https://code.launchpad.net/~abentley/charmworld/config-storage-2/+merge/173757 > | 15:38 |
| sinzui | I can | 15:39 |
| sinzui | abentley, r-me | 15:39 |
| sinzui | r=me | 15:40 |
| rick_h | Makyo: looking at your branch. Are you only dealing with the icon if it's got one and not going to display the fallbacks then? | 15:43 |
| Makyo | rick_h, for this branch, yes. I need to get on to a first pass at updating the service block SVGs today. | 15:44 |
| rick_h | Makyo: ok. | 15:44 |
| Makyo | luca, need to ask you about those when you have a chance. | 15:45 |
| rick_h | Makyo: if you get to the fallbacks let me know. I'm finding that maybe that work should be abstracted out of the template file in charm-token.handlebars and more into a model or helper somewhere. | 15:45 |
| Makyo | rick_h, alright. I didn't dig too much into that, but I will. | 15:45 |
| rick_h | Makyo: yea, it's not in an easy place for you to reuse like this atm. | 15:46 |
| luca | Makyo: I'm free now if you are | 15:46 |
| Makyo | luca, the email you sent had the black squircles with the connectors slightly extended. however, in the UX/styling demo, it's that black outline surrounding the original service block. Which direction should I head in? | 15:48 |
| abentley | sinzui: did you set the revno to 300? | 15:48 |
| sinzui | abentley, I did not | 15:49 |
| abentley | sinzui: Hmm. Maybe tarmac's back, then. | 15:49 |
| rick_h | abentley: yea, I assumed it came back up when I got the 'jenkins is back to normal' email | 15:49 |
| luca | Makyo: the normal state should be this: https://docs.google.com/a/canonical.com/file/d/0B7XG_QBXNwY1QkNacGhCX0hXNW8/edit?usp=sharing | 15:49 |
| luca | Makyo: clicked/hover state: https://docs.google.com/a/canonical.com/file/d/0B7XG_QBXNwY1eUIzbFNjZjdyMEU/edit?usp=sharing | 15:50 |
| Makyo | luca, alright. Was just curious after seeing https://dl.dropboxusercontent.com/u/10004366/juju-gui/index.html | 15:50 |
| luca | Makyo: When it's just been added to the canvas it should show the charm icon instead of the health circle | 15:50 |
| Makyo | luca, the charm icon branch is in review right now. | 15:51 |
| luca | Makyo: yeah, Ant hasn't implemented the block stuff yet | 15:51 |
| luca | Makyo: nice :) | 15:51 |
| abentley | rick_h: Oh. I don't get those. | 15:51 |
| Makyo | luca, alright, cool. Will aim to have that for today. | 15:51 |
| luca | Makyo: nice, thanks | 15:51 |
| abentley | sinzui: second time's the charm with prepare-upgrade. | 15:52 |
| Makyo | jujugui call in 8 | 15:52 |
| Makyo | Kanban now. | 15:52 |
| hatch | what he said! | 15:52 |
| luca | sinzui: who do I talk to about "Useful links"? | 15:54 |
| hatch | 15:54 | |
| hatch | *snicker* | 15:54 |
| Makyo | Brat :) | 15:55 |
| luca | rofl | 15:55 |
| sinzui | luca, me I think. | 15:56 |
| luca | sinzui: ah, well, they are being moved to a section in the summary tab | 15:56 |
| luca | sinzui: the designs will be finished tomorrow | 15:56 |
| sinzui | understood luca | 15:56 |
| luca | sinzui: cool, thanks :) | 15:57 |
| sinzui | luca, jcastro, jcsackett. I just tested what users see when sharing a juju-gui URL using G+ itself. It was a private post with you so that we can see what the experience is like. | 15:58 |
| hatch | jujugui guichat now | 15:59 |
| jcastro | sinzui: oh yeah, there's some metadata G+ expects | 16:00 |
| jcastro | we should make it so the charm's icon is automatically in there | 16:01 |
| jcastro | I was just looking this up the other day, investigating | 16:01 |
| sinzui | +1 | 16:01 |
| jcastro | sinzui: here it is | 16:02 |
| jcastro | https://support.google.com/webmasters/answer/176035?hl=en | 16:02 |
| jcastro | http://schema.org/docs/gs.html#microdata_how | 16:02 |
| jcastro | https://www.google.com/webmasters/tools/richsnippets | 16:02 |
| luca | sinzui: can we discuss sharing? | 16:05 |
| teknico | Makyo: one thing I noticed is that the install hook does not install the python-cheetah package, which it indirectly uses | 16:08 |
| Makyo | teknico, hmm. Okay, will poke around there. | 16:09 |
| teknico | Makyo: thanks | 16:09 |
| Makyo | teknico, what I'm seeing from the GUI is it's not passing the cs: schema when it tries to deploy, so I get juju.charm.errors.CharmURLError: Bad charm URL u\'~marcoceppi/precise/discourse-18\': a URL with a user must specify a schema\n | 16:10 |
| rick_h | Makyo: that might need tweaking when converting from BrowserCharm to Charm models during deploy | 16:11 |
| rick_h | Makyo: that cs: url is in the BrowserCharm.code_source object I believe. | 16:11 |
| Makyo | rick_h, ah, alright. I'll poke around the deploy stuff where it does that conversion. | 16:11 |
| rick_h | Makyo: sorry, BrowserCharm.url is where it's at | 16:11 |
| rick_h | that's the cs: url | 16:11 |
| rick_h | http://manage.jujucharms.com/api/2/charm/precise/apache2-2 shows an example json dump that turns into the model Makyo | 16:12 |
| Makyo | \o/ thanks | 16:12 |
| Makyo | rick_h, teknico, in app/views/charm-panel.js line 873, the deployer is only getting the id attribute; is that where it would need the URL? | 16:16 |
| Makyo | Deployer's the wrong word. The deploy function that's passed to the browser. | 16:16 |
| rick_h | Makyo: so yea, that charm model should have a url attribute. I'm not sure what you're doing the cs: stuff for so can't say what's up with _setPanel() | 16:18 |
| teknico | Makyo: no, if the passed-in function is the one at line 760, it only needs the charm id | 16:21 |
| luca | jcastro: sinzui rick_h who do I need to talk to about sharing? | 16:21 |
| sinzui | I am one of them | 16:22 |
| jcastro | luca: I am also one | 16:22 |
| luca | jcastro: | 16:22 |
| jcastro | I did the little text for the twitter section | 16:22 |
| luca | jcastro: wrong person | 16:22 |
| luca | jcastro: oops | 16:22 |
| luca | sinzui: lets talk quickly on a hangout? | 16:22 |
| luca | jcastro: ^ | 16:22 |
| sinzui | okay | 16:22 |
| Makyo | teknico, ah, okay. Either way, it looks like the id is ~marcoceppi/precise/discourse, and it should have a schema on the beginning when it actually deploys. | 16:23 |
| teknico | Makyo: right | 16:23 |
| rick_h | Makyo: right, but we don't consider the schema part of the id in the model and the api. | 16:23 |
| rick_h | Makyo: so the id will never have that, it's the url | 16:23 |
| Makyo | rick_h, Yeah, so we should be able to just change that, I think. Which is maaaaybe line 605? | 16:24 |
| Makyo | var url = charm.get('id'); | 16:24 |
| luca | sinzui: https://plus.google.com/hangouts/_/2302ec8be280f94a7841473e1dbbc7e8e43cb204?authuser=1&hl=en | 16:24 |
| luca | jcastro: https://plus.google.com/hangouts/_/2302ec8be280f94a7841473e1dbbc7e8e43cb204?authuser=1&hl=en | 16:24 |
| rick_h | Makyo: looks ok from there, but not familiar enough to say 'go for it' | 16:24 |
| jcastro | luca: I am EODing in a minute, only working a half day today and I have a charm championship page to do still | 16:26 |
| jcastro | luca: whatever you guys decide just lmk | 16:26 |
| teknico | uhm, how do we get the schema in there? I cannot see it | 16:27 |
| Makyo | teknico, just change it to var url = charm.get('url'), looks like. | 16:29 |
| Makyo | I set a breakpoint there and checked charm.getAttrs() | 16:29 |
| teknico | oh, good to know, thanks | 16:29 |
| rick_h | Makyo: teknico right, the url is the url not the id now. Should be good to pull from the model url. | 16:29 |
| teknico | Makyo: I wonder why it is only a problem with this specific charm, though | 16:29 |
| rick_h | teknico: no, I think it's a change in the old charm model data vs the new. | 16:30 |
| Makyo | teknico, I'm thinking it's a problem with all user charms due to the change. | 16:30 |
| rick_h | Makyo: the one thing I worry about is if an old instance can get in here, but since it's in deploy side I don't think it can | 16:30 |
| teknico | Makyo: oh, ok then | 16:30 |
| Makyo | rick_h, yeah. I think the only way would be if they were to deploy from the old panel, which is now mutually exclusive from the browser. | 16:31 |
| rick_h | Makyo: right, so I'm pretty sure you're safe with your one-liner change. | 16:31 |
| rick_h | Makyo: but want to make sure it's clear what the diff is and how it might cascade around a little bit | 16:31 |
| Makyo | rick_h, Yeah. I think it'd be good to go through a bunch of different types of charms and ways of deploying (DnD and add button) to make sure we're always getting the same sort of info. | 16:32 |
| rick_h | Makyo: yea, anything that goes through the Browser code will be an instance of BrowserCharm cast into a Charm and that's what's in here. | 16:32 |
| rick_h | and the api promises that the url will be there. | 16:33 |
| Makyo | Cool, that should help, yeah. | 16:33 |
| bcsaller | bac: I made review changes and reproposed if you have time to look that branch over again: https://codereview.appspot.com/11013043/ | 16:36 |
| bcsaller | hatch: you might want to look at the method renamings in that branch and see if you're still happy with them | 16:39 |
| hatch | yup reading it now | 16:39 |
| hatch | well reading the replies | 16:39 |
| hatch | I have come to love rebind :) | 16:39 |
| hatch | what's POJO? | 16:40 |
| teknico | Makyo: great, thanks a lot for the help! | 16:40 |
| Makyo | teknico, cheers | 16:41 |
| hatch | bcsaller: I can't deploy a service and then view it using the new service inspector | 16:47 |
| bcsaller | hatch: Plain Old Java(Script) Objects, comes from java but means plain Object derivatives | 16:48 |
| hatch | ohh | 16:48 |
| hatch | DD ceph, click deploy, click it to view inspector...console error | 16:48 |
| bcsaller | so something without the .get method in the case referenced | 16:48 |
| bcsaller | hmm | 16:48 |
| hatch | it was a fresh checkout/make of your branch | 16:49 |
| hatch | Uncaught TypeError: Object [object Array] has no method 'toArray' service.js:1210 | 16:49 |
| teknico | and that charm is also tasteless, that is, it's testless ;-) and written in bash :-P | 16:50 |
| bcsaller | hatch: able to reproduce locally, looking into it | 16:52 |
| bcsaller | there is another error past that one | 16:52 |
| sinzui | rick_h, jcsackett: Did this icon come from the old api (the <charm>/json url) or the new api http://uistage.jujucharms.com:8086/~nextrevision/precise/openvpn-3/ | 16:53 |
| rick_h | sinzui: the icons comes because it has a category of 'application' which is invalid. It needs to be applications (s) | 16:53 |
| rick_h | sinzui: so the icon comes because of a broken sprite | 16:54 |
| sinzui | rick_h, I know that... | 16:54 |
| hatch | bcsaller: alrighty | 16:54 |
| jcsackett | sinzui: i'm with rick_h, i don't think i understand what you're asking. | 16:54 |
| rick_h | sinzui: ok, so everything on this page is from the new api | 16:54 |
| rick_h | sinzui: I'm not 100% following the question I guess. | 16:54 |
| sinzui | rick_h, Did it get the category from api 2 or /json | 16:54 |
| rick_h | sinzui: api2 | 16:54 |
| sinzui | rock. This is fixed on staging | 16:55 |
| * sinzui is still scouring the network requests to convince himself the /json url was not called | 16:55 | |
| rick_h | sinzui: ah, yea. Use chrome, load the page with the network tab open, then click the 'xhr' button on the bottom of the tools | 16:56 |
| sinzui | thank you for reminding me about the filter. I am incompetent rick_h | 16:57 |
| bcsaller | hatch: ahh, shallow, the changes around model handling didn't propagate through the modellist handler properly, it was calling selectBindModel on its own product | 16:57 |
| rick_h | sinzui: cool, darn handy tool in our network waterfall for sure. | 16:58 |
| hatch | bcsaller: ahhh | 17:06 |
| bcsaller | hatch: I'm now able to create the error we talked about before where an old inspector (two services on canvas, switch to second) is still running in the background. Not related to this branch, but an issue | 17:07 |
| hatch | crud I thought your branch would solve that | 17:08 |
| hatch | arg | 17:08 |
| hatch | *I hoped* | 17:08 |
| hatch | I just got rank burnt by order of operations | 17:10 |
| * hatch goes to grab the aloe and a grade 4 text book | 17:10 | |
| bcsaller | hatch: I think I see the fix though, its just not calling the right things in the inspector singleton mgmt code | 17:12 |
| bcsaller | trying a fix now | 17:13 |
| hatch | cool thanks | 17:13 |
| luca | hatch: Makyo who do we need to talk about relations and building them? | 17:19 |
| Makyo | luca, Sure. At this point, I think we'll be able to implement most things reasonably quickly, just need a direction to head in. | 17:20 |
| hatch | luca: I hear there are a lot of good dating sites in London | 17:20 |
| Makyo | :P | 17:21 |
| hatch | haha ok sorry | 17:21 |
| hatch | yeah I am pretty confident the code is all there it's just the interaction we want to narrow down | 17:21 |
| hatch | narrow/peg down | 17:21 |
| hatch | right now the 'long click' isn't discoverable | 17:22 |
| hatch | thenagain, neither was the menu | 17:22 |
| luca | Makyo: we will join guichat in 2 mins :) | 17:22 |
| Makyo | luca, alright | 17:23 |
| hatch | can I join in on this too? | 17:23 |
| Makyo | Sure | 17:23 |
| hatch | cool | 17:23 |
| hatch | http://jsbin.com/evehit/6 | 17:23 |
| hatch | pretty cool :) | 17:24 |
| hatch | it looks/feels the best in firefox | 17:24 |
| hatch | that's just because it has easing on it's scrolling | 17:24 |
| Makyo | hatch, we're starting. | 17:25 |
| hatch | sorry guichat was having issue connecting | 17:25 |
| bcsaller | hatch: I pushed fixes to the outstanding issues, it properly unbind now | 17:33 |
| hatch | awesome! | 17:33 |
| hatch | thanks | 17:33 |
| * Makyo runs out to pick up dogs. | 17:36 | |
| hatch | jcsackett: I saw your reply on the bug - are you in Chrome as well? | 17:37 |
| rick_h | hatch: what version of chrome are you running? Maybe a version thing? | 17:37 |
| hatch | OSX - 27.0 | 17:37 |
| rick_h | hatch: k, 29 here so shouldn't be a version issue then | 17:38 |
| hatch | odd my Ubuntu Chrome is 28 | 17:38 |
| hatch | are you running the beta channel? | 17:38 |
| rick_h | dev channel | 17:39 |
| hatch | ahh gotcha | 17:39 |
| hatch | so many chrome versions haha | 17:39 |
| rick_h | should only be 3 :) | 17:39 |
| rick_h | stable, beta, dev | 17:39 |
| hatch | yeah then for each OS | 17:39 |
| hatch | haha | 17:39 |
| rick_h | but they're released together | 17:39 |
| hatch | who knows, maybe my osx hasn't made the rounds yet | 17:40 |
| rick_h | 27 would be stabel, 28 beta, 29 dev | 17:41 |
| hatch | yeah my Ubuntu is on stable I thought | 17:41 |
| hatch | who knows | 17:41 |
| rick_h | I'd guess not | 17:41 |
| hatch | bcsaller: QA'ing again | 17:41 |
| hatch | bcsaller: heh you're gona be maaaaad at me | 17:42 |
| hatch | I found another bugt | 17:42 |
| bcsaller | doh | 17:42 |
| hatch | hmm can't repro now... | 17:43 |
| hatch | possible cache issue | 17:43 |
| hatch | ok nope there it is | 17:43 |
| hatch | DD ceph, deploy, inspector, click <- S, E, D, Units | 17:44 |
| hatch | then the toArray error shows in the console | 17:44 |
| hatch | I think the error occurs when a change comes in on the delta | 17:45 |
| hatch | it's very odd I can't seem to repro all the time | 17:45 |
| hatch | ahh if you follow those steps | 17:46 |
| hatch | then just let it sit | 17:46 |
| hatch | it'll eventually error | 17:46 |
| bcsaller | hatch: I'd seen something like that as well, thought it was fixed, but looking into it now | 17:49 |
| hatch | great | 17:49 |
| bcsaller | I see the real issue | 17:50 |
| benji | hatch: are you available for a short chat about transitions in a couple of minutes | 18:07 |
| hatch | i am | 18:11 |
| hatch | ^ benonsoftware | 18:11 |
| hatch | benji: | 18:11 |
| hatch | damn autocomplete | 18:11 |
| hatch | benji: whenever you're ready | 18:11 |
| benji | hatch: hatch I'm in guichat | 18:12 |
| bcsaller | hatch: the model list handler was way too aggressive, I'm surprised we didn't see that issue sooner, tough it would have been hard to spot. It was calling render/update on way too many things including non-model list viewlets | 18:19 |
| bcsaller | hatch: pushed the revision | 18:19 |
| hatch | ohh heh so this code is way better now then | 18:24 |
| hatch | haha | 18:24 |
| bcsaller | hatch: there is still an issue in the updates, but yes as so as I have it properly resolved it will be | 18:27 |
| hatch | ahh ok | 18:54 |
| hatch | (sorry was on call with benji) | 18:54 |
| bcsaller | hatch: a fix is pushed if you can verify it as well when you have time | 18:57 |
| bcsaller | seems to be working fine here | 18:57 |
| hatch | ok will pull down | 18:59 |
| hatch | bcsaller: looks good | 19:02 |
| hatch | propose? | 19:02 |
| bcsaller | hatch: I'll push it up again, just takes so long :( | 19:05 |
| hatch | ohhh I know | 19:06 |
| hatch | it would be cool if we could have some super powerful box sitting around we could get to pull down the branch and build | 19:06 |
| hatch | I have a spare server that's probably faster but not by enough that it would make a difference having to 'build' to run the tests | 19:09 |
| bcsaller | hatch: proposed again, quite a lot of fixes on that branch now | 19:16 |
| hatch | haha yeah... | 19:17 |
| hatch | bcsaller: do you think there should be tests for the edge cases which you just solved? | 19:23 |
| bcsaller | hatch: ideally yes :-/ | 19:25 |
| hatch | you just want to land this branch don't you? | 19:26 |
| hatch | ;) | 19:26 |
| hatch | tbh I'd like to see this land so I can get on wit my branch | 19:28 |
| hatch | followup with tests? | 19:28 |
| abentley | orangesquad: Could you please review https://code.launchpad.net/~abentley/charmworld/autocomplete/+merge/173799 ? | 19:30 |
| bcsaller | hatch: I'll make a carc | 19:30 |
| bcsaller | hatch: I'll make a card | 19:30 |
| * sinzui looks | 19:30 | |
| hatch | bcsaller: lgtm'd | 19:34 |
| bcsaller | jujugui: one more +1 needed for https://codereview.appspot.com/11013043/ | 19:34 |
| benji | bcsaller: looking | 19:34 |
| bcsaller | thanks | 19:35 |
| hatch | careful....there be dragons | 19:35 |
| hatch | now I fully expect my branch to explode after merging it in :) | 19:35 |
| sinzui | abentley, what do you think will happen if the autocomplete query is for 'fo%20'. I think this becomes 'fo ' and it doesn't match anything and it doesn't break anything. | 19:38 |
| sinzui | but maybe some smart function strips the trailing space | 19:39 |
| abentley | sinzui: My guess is that it would match any charms whose names began with 'fo ', but we don't have any. | 19:39 |
| sinzui | I think the gui needs to be certain to strip whitespace. A leading space will be confusing | 19:40 |
| hatch | it would be cool if you could do a forEach on an array in reverse | 19:40 |
| hatch | (without tricks) | 19:40 |
| sinzui | abentley, r=me | 19:41 |
| abentley | sinzui: Thanks. | 19:41 |
| sinzui | abentley, This is my thoughts about the svg problem: http://pastebin.ubuntu.com/5859420/ | 19:45 |
| abentley | sinzui: I find the notion of a 96x96 vector graphic confusing. Don't they just need to be square? | 19:47 |
| sinzui | abentley, Yes in the big picture. The template svg specifies the default rendering is 96x96 | 19:48 |
| sinzui | we can detect if the default template was not used. I don't want to enforce the template | 19:49 |
| sinzui | abentley, svgs DO have width and height attributes and even if the template is not used, detecting unsupported dimensions is trivial | 19:51 |
| abentley | sinzui: Ok. | 19:52 |
| sinzui | abentley, Do we care about file size? DoSing the gui is bad. Well, I think we know something about this because the wikimedia icon contains a fat png | 19:54 |
| abentley | sinzui: I was going to just use python-magic and reject anything that wasn't svg. Going so far as to validate images doesn't seem like it should be our problem. Maybe proof should do that? | 19:54 |
| sinzui | abentley, I think proof should do that. proof is run after we build the CharmFileSet | 19:54 |
| sinzui | We can call magic as we build the set | 19:55 |
| abentley | sinzui: As an advocate for the backend, my only concern about file size would be on the ingest side. On output, we have solid caching. | 19:56 |
| abentley | sinzui: In terms of the GUI, it shouldn't be an issue, because only promulgated charms are going to show their icons. | 19:57 |
| sinzui | abentley, apache2 and wikimedia are both promulgated. | 19:57 |
| sinzui | one has a png and the other has an embedded png | 19:58 |
| sinzui | abentley, we wouldn't be treating this issue as a bug of the mistakes in the icons were fixed in April when we discovered the problem | 19:59 |
| abentley | sinzui: Right, but the maintainers aren't malicious. I assume the svg-with-embedded-PNG is a legitimate wikipedia logo that just happens to be big. It's not a DoS, though, and is only going to affect those who encounter that charm. | 20:00 |
| abentley | sinzui: If you want to cap file size, it's fine by me. | 20:01 |
| sinzui | abentley, I think you prefer that we do the minimum to ingest to deal with this issue (use magic to reject liars). Update proof to demand the issue be fixed | 20:01 |
| sinzui | I can update proof. I have other fixes I want to add to it | 20:01 |
| abentley | sinzui: I think that's accurate. | 20:02 |
| * sinzui ponders how proof could be taught to report that the maintainer is wrong because the branch owner is different | 20:02 | |
| sinzui | well that is not a good idea | 20:02 |
| sinzui | Teams will often own charms, but they will rarely have email addresses | 20:03 |
| abentley | sinzui: I don't think proof can know what the branch owner will be. | 20:04 |
| abentley | sinzui: Unless we tell it, I suppose. | 20:04 |
| sinzui | I really want to set my own juju agenda. The package-origin and maintainer-owner problems lead to confusion and are vulnerabilities that no one is talking about | 20:05 |
| abentley | sinzui: Maybe we should overwrite maintainer with branch owner at ingest time? | 20:06 |
| abentley | sinzui: I don't see a lot of value in having them vary. | 20:06 |
| sinzui | That hides errors. But we could record that we know there is something wrong. Write now, we know it because we few can see the problem | 20:07 |
| sinzui | right now ^ | 20:07 |
| abentley | sinzui: I go back and forth on whether the maintainer field has any value. The fact that it's so often wrong suggests it's not important. | 20:08 |
| sinzui | abentley, rick_h brought up the author/owner issue in regards to the charm token today. User do need to see both, and they need to know that something is wrong when they differ | 20:08 |
| sinzui | abentley, juju certainly doesn't require it. | 20:09 |
| abentley | sinzui: Author is a third thing. That's something you get from bzr metadata :-) | 20:09 |
| sinzui | The field is flawed since teams can own branched, but not have email addresses | 20:09 |
| sinzui | indeed | 20:09 |
| sinzui | abentley, I think the charm/branch owner is who juju and the community cares about. The maintainer field is a means for a the owner to provide the preferred contact address. This too is unneeded if juju and juju-gui could point to Lp about how to contact or contribute | 20:13 |
| abentley | sinzui: Makes sense. | 20:15 |
| abentley | rick_h: autocomplete is implemented on staging. | 20:19 |
| abentley | sinzui: I am ready for new work and assume it should be versions. Chat? | 20:21 |
| sinzui | abentley, yes and yes | 20:21 |
| bcsaller | hatch: that should be landed and ready for you to merge | 20:39 |
| hatch | bcsaller: thanks yas | 21:18 |
| hatch | bcsaller: Makyo I think you can drag your branches into the done column :) | 21:34 |
| Makyo | hatch, yep, thnks | 21:34 |
| hatch | Makyo: you aren't going to make us QA this SVG code are you? ;_ | 21:36 |
| hatch | ;) | 21:36 |
| Makyo | hatch, I totally am. Lucky for you, all it requires is for you to deploy a service. | 21:37 |
| hatch | *phew* | 21:38 |
| Makyo | Well, preferably two services, and create a relation. | 21:39 |
| hatch | welllll O K | 21:40 |
| hatch | :) | 21:40 |
| hatch | reviewing | 21:40 |
| hatch | Makyo: rgb color? | 21:42 |
| Makyo | hatch, yanked from the demo. | 21:42 |
| hatch | I don't care either way, we should probably stick with one or the other :) | 21:42 |
| Makyo | hatch, I can see about converting, though. | 21:42 |
| Makyo | hatch, yeah. | 21:42 |
| hatch | colorpicker.com | 21:42 |
| hatch | is what I use :) | 21:42 |
| Makyo | Thanks. | 21:42 |
| hatch | rgb(a) kind of makes more sense for our support matrix buuuuuuuut whichever :) | 21:43 |
| Makyo | Yeah | 21:43 |
| hatch | I care so litle about it I'm not even going to comment on the review :D | 21:43 |
| hatch | twice today I've run 'make' in the root dir and wondered why there were no 'make targets' | 21:44 |
| hatch | today is just not a good day for me | 21:44 |
| hatch | heh | 21:44 |
| hatch | Makyo: hmm....I kind of like the icon in there instead of the little circle :) | 21:47 |
| hatch | although the functionality of it would be way less heh | 21:47 |
| Makyo | I think that's the direction we're heading eventually. | 21:47 |
| hatch | lgtm'd with a super trivial comment | 21:49 |
| bcsaller | Makyo: is there a reason to not use the icon post ghosting? was that talked about or just an artifact or wires possibly not being updated? | 21:58 |
| hatch | I dont' think it SHOULD be there because then the status indicators are gone | 21:58 |
| hatch | and tha'ts the most important part :) | 21:58 |
| bcsaller | 'it' being the icon? | 21:59 |
| hatch | yeaaah | 22:00 |
| hatch | hmm my a key is sticking | 22:00 |
| bcsaller | I thought it was icon and centered under that the status color bar, but I've seen so many wires I can't keep it straight | 22:00 |
| hatch | ohh...hmm I didn't that one existed | 22:01 |
| hatch | lol I'm in the same boat I guess haha | 22:01 |
| hatch | jcastro: what is an 'Ubuntu Member' ? Could I be one and not know it? | 22:02 |
| Makyo | We don't have any designs for that either way, bcsaller hatch. I just have the two cards and don't want to put too much effort into trying to outguess london :) | 22:04 |
| hatch | probably a good idea ;) | 22:04 |
| hatch | I definitely don't have a good track record of anticipating their next move lol | 22:04 |
| bcsaller | never try to outguess London ;) | 22:04 |
| hatch | the new twitter app for android has a different font | 22:06 |
| Makyo | Haha | 22:07 |
| Makyo | Better, hatch? | 22:07 |
| hatch | what's better? | 22:07 |
| hatch | my coffee is still empty | 22:08 |
| Makyo | Twitter font. | 22:08 |
| hatch | ohh | 22:08 |
| hatch | was gona say, if you were filling my coffee...then no | 22:08 |
| Makyo | I only use it occasionally, but I like seeing what they do with design. | 22:08 |
| hatch | wrt the twitter font - then yes :D | 22:08 |
| Makyo | hatch, Gladly., as long as espresso's good | 22:08 |
| hatch | sure - I usually just drink 'normal' which I think is called an americano | 22:09 |
| hatch | because I'm sure a watered down espresso is the same as drip :) | 22:09 |
| Makyo | Bah. I think they taste totally different. | 22:09 |
| Makyo | read: I totally like Americanos better. | 22:10 |
| hatch | I'm not much of a connoisseur I guess | 22:10 |
| rick_h | abentley: thanks! | 22:10 |
| hatch | I just take whatever the drip is....black | 22:10 |
| Makyo | Reflux made me appreciate tasty coffee that doesn't make me sick all that much more. Espresso machine seems to be the best bet. | 22:14 |
| Makyo | And tastiest. | 22:14 |
| Makyo | Never got into cold-brew. | 22:14 |
| rick_h | moka pot ftw is my new thing | 22:14 |
| rick_h | that and a nespresso frother. best camping trip evar! | 22:14 |
| hatch | frothed milk makes me kind want to hurl | 22:15 |
| Makyo | I looove the coffee from those things, rick_h, but still a little too much for my stomach in the morning. | 22:15 |
| rick_h | it doesn't froth soy very well, more that it warms it up to coffee temp so that it's not cold milk into hot coffee | 22:15 |
| Makyo | Good post-breakfast coffee, though. | 22:15 |
| rick_h | Makyo: yea, I've never been a home-coffee person but some vanilla soy into my moka pot brew has me saving the starbucks $$ | 22:16 |
| rick_h | and a LOT less than an espresso machine | 22:16 |
| bcsaller | ugh, you're all making me want more Espresso, back to the kitchen with me | 22:16 |
| Makyo | rick_h, Definitely! I'm more almond milk, myself, but yeah :) | 22:16 |
| Makyo | \o/ | 22:16 |
| rick_h | Makyo: I want to try some of that next. I wish they had smaller containers at the store :/ | 22:17 |
| Makyo | rick_h, Yeah, half-gallons are all I can find. Makes good white russians, though, so we tend to go through it quickly enough. | 22:17 |
| rick_h | hah! | 22:18 |
| rick_h | lovely, chrome won't open on the laptop :( | 22:20 |
| hatch | uh oh | 22:25 |
| rick_h | looks like it might be the new hangouts app installed on there. I'll have to look up how to start sans-apps/extensions and try to remove it | 22:27 |
| hatch | time to format, install Windows | 22:29 |
| * hatch runs | 22:29 | |
| hatch | hehe | 22:29 |
| rick_h | heh, or use Firefox...ahhhhh! | 22:30 |
| hatch | haha - I have noticed that FF is actually a rather enjoyable browsing experience | 22:30 |
| hatch | chrome is still faster | 22:30 |
| hatch | but ff is 'smoother' heh | 22:30 |
| rick_h | hmmm, fails in incognito mode too :( | 22:31 |
| hatch | uh oh | 22:31 |
| rick_h | dev tools for me | 22:31 |
| rick_h | chrome dev tools ftw | 22:31 |
| hatch | delete and reinstall? | 22:31 |
| hatch | oh yeah it's devtools are superior for suuure | 22:31 |
| rick_h | ok, so starting with a fresh profile works so yea. Just time to reset it up and try to clear what's in it I guess. | 22:35 |
| huwshimi | Morning | 23:00 |
| hatch | mornin huwshimi | 23:00 |
| hatch | I'm so close to getting this sticky header thing done I don't think I'll quit until it's working | 23:01 |
| huwshimi | hatch: Did you look how Ant did it in the prototype? | 23:03 |
| hatch | and did it in the prototype already? | 23:03 |
| hatch | lol damn | 23:03 |
| hatch | have a link? | 23:03 |
| hatch | huwshimi: I'm asking because the dropbox one doesn't implement this scrolling | 23:06 |
| huwshimi | hatch: It might not happen in the inspector but does in the sidebar browser | 23:07 |
| huwshimi | That's if you have the right link | 23:07 |
| hatch | pass the link you mean plz | 23:07 |
| hatch | :) | 23:07 |
| huwshimi | just finding it | 23:07 |
| hatch | https://dl.dropboxusercontent.com/u/10004366/juju-gui/index.html# | 23:08 |
| hatch | is the one I have | 23:08 |
| huwshimi | hatch: Yeah, that's the one | 23:10 |
| hatch | ok then no different scrolling :) | 23:10 |
| hatch | huwshimi: http://jsbin.com/evehit/7 the bottom stickyness requires overscolling (my calculations are wrong) | 23:10 |
| hatch | but scroll up and down to see how it works :) | 23:11 |
| huwshimi | hatch: Are you not trying to make the current heder on the inspector stick to the top as you scroll the inspector content down? | 23:11 |
| huwshimi | hatch: Oh, you're trying to make them all stick. Are you sure that's correct? | 23:12 |
| hatch | it better be | 23:12 |
| hatch | lol | 23:12 |
| hatch | but yeah that's what Gary said at least | 23:13 |
| hatch | imho I think this is awesome | 23:13 |
| huwshimi | hatch: It's just different to how the sticky headers work in the sidebar | 23:14 |
| huwshimi | I can't tell from these mockups how that's supposed to work... | 23:15 |
| hatch | ohh right yeah | 23:15 |
| hatch | I'm pretty sure that's intentional | 23:15 |
| hatch | my guess is that at some point they will want a 'click to scroll' functionality | 23:16 |
| hatch | so you can click to scroll to the heading | 23:16 |
| hatch | all I know.....you have to refresh jsbin every once and a while else it lags | 23:16 |
| hatch | heh | 23:16 |
| huwshimi | hatch: If you have the time you could add an option to make all the headers sticky or just one. Otherwise I can do it once your code lands so I can re-use it for the browser and charm details page. | 23:19 |
| hatch | so once the second header gets to the top it would push the first one away? | 23:19 |
| huwshimi | hatch: Yep | 23:20 |
| hatch | that coudl be an option probably | 23:20 |
| hatch | this is all raw js too so it'll be portable :) | 23:20 |
| hatch | well for modern browsers | 23:20 |
| hatch | old browsers can just deal with normal scrolling... | 23:20 |
| hatch | huwshimi: http://jsbin.com/evehit/8/ done :) | 23:25 |
| huwshimi | hatch: Nice work | 23:26 |
| hatch | well | 23:26 |
| hatch | done my requirement | 23:26 |
| hatch | yours might take a bit of work yet | 23:26 |
| hatch | thanks :) | 23:26 |
| hatch | man that was a friggen pita | 23:26 |
| hatch | huwshimi: ok so a single sticker header is probably going to be super easy | 23:29 |
| huwshimi | hatch: Yay! | 23:29 |
| hatch | I'm not sure it should be the same code though | 23:29 |
| hatch | it would probably be a more basic implementation | 23:30 |
| hatch | how soon does that need to be done? | 23:30 |
| hatch | I'd like to get some other stuff landed first :) | 23:30 |
| huwshimi | hatch: Well I would like to try and get something landed for the upcoming deadline, but if it's entirely different code I can write something myself if need be... | 23:34 |
| hatch | well that's probably a little unncessary | 23:34 |
| hatch | you 'could' even throw in a position sticky polyfil and be done | 23:34 |
| hatch | uggggh conflicts | 23:39 |
| hatch | sometimes bzr is so smart....othertimes....heh daymn | 23:42 |
| * hatch spoiled by source control | 23:42 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!