[00:13] huwshimi: so thought about it and viewNavigate isn't needed. Home is just the hard coded path of either /sidebar or /fullscreen based on the isFullscreen param [00:13] huwshimi: so I'd just make the template have those links and not try to fire custom stuff [00:14] that is what we mean by "Home" right? [00:18] rick_h: Well, the sidebar needs to be able to navigate back from the search results or a category without closing the charm panel... [00:20] bcsaller: still around? [00:20] rick_h: yes [00:20] bcsaller: looking at your branch with the icon, does that work? We never have an icon value so wondering where it's binding to/from? [00:21] huwshimi: right, so on search results, home would purely be a link to /sidebar or /fullscreen. [00:21] The ghost inspector sets it from the charm data onto the service so it works in that single case [00:21] huwshimi: or what is the 'charm panel'? [00:22] we have notes that we need a more general solution [00:22] rick_h: I think it would need to be "/sidebar/precise/ceph-12/" [00:22] bcsaller: right, I'm with you on notes. Known issue and Makyo hit it with his work to include an icon but wasn't sure how this fit [00:22] huwshimi: ah, gotcha. [00:22] bcsaller: ok, so you're getting it from Makyo's work then which is getting it from the Store if it has it. Cool [00:23] rick_h: yes, its based on that work [00:23] bcsaller: cool, that helps. Thanks. [00:28] huwshimi: so it sounds like the only thing we're changing is clearing search. So yea, a viewNavigate with a change object of {search: false; query: {};hash: undefined} would reset it [00:29] or query: undefined I guess is simpler [00:29] rick_h: Ah, that sounds promising. [00:30] that would leave the viewmode and the charmid alone which are the two parts you want to keep consistent [00:32] rick_h: I was thinking of building this inside charm-search.js. But inside that file, and its corresponding template it doesn't have the isFullscreen variable. Any idea how I might get access there? [00:33] huwshimi: sec [00:33] huwshimi: I was thinking it would be part of the sidebar/fullscreen views and that has it. It could go in subapp/views/view.js [00:33] and be shared between them. [00:34] Now I guess, when does "home" show up? Is it always there? Or only during a search? [00:34] rick_h: It only apears during a search (including viewing a category), or if you're viewing a charm in full-screen mode [00:34] huwshimi: who's rendering the html link I guess? [00:35] rick_h: The HTML needs to exist in that header (hence me wanting to put it in charm-search.js) [00:35] huwshimi: oh, in the charm-search widget? [00:35] rick_h: Yeah [00:36] huwshimi: ah, so the *right* way to do that then is to create a new event in the widget, like the "search changed" event now that's a "GO_HOME" event. Then anyone that creates a new Search() widget needs to bind to that event and fire the viewNavigate when it happs. [00:36] huwshimi: just like the SEARCH_CHANGED event works now [00:36] rick_h: OK. [00:37] huwshimi: hmmm...so then the trick is that you need to supress that link from the widget when it's not a search/charm details view. :/ [00:37] rick_h: I'll still need to know when to hide/show that control, but I guess I can do that in the parent view [00:37] heh [00:38] huwshimi: yea, thinking. We've not really had conditional stuff like that. [00:38] rick_h: Yeah, there are a few other cases I'm going to need to do similar stuff to change headers etc. depending on the particular view [00:38] huwshimi: ok, so the subapp/browser/views/view.js has a charmID attribute. So if that's set you're looking at a charm. [00:39] (stuff outside the view content) [00:39] huwshimi: that gets you part way there. [00:39] huwshimi: so you'd need to add a flag in the _renderSearchWidget based on if there's a charmID...and then the other one is if you're in search mode or not. [00:39] huwshimi: well, you want 1) "isFullscreen and charmID is set...show the link" [00:40] 2) "Search results are being shown" [00:40] 1) you're set on [00:40] 2) I'm looking [00:40] huwshimi: you can check the filters object. [00:40] huwshimi: the same View has a filters ATTR, if those are set to something you should be in a search. [00:41] huwshimi: the only problem with that is we still have default filters set. We've not removed them in a branch yet [00:41] huwshimi: so those have to go as well. [00:42] then if any fitler is set, you're doing a search. [00:42] huwshimi: because in the filters is the query being search, or the category selected when viewing a category [00:42] rick_h: This is looking like a job that would probably take a day. So might not be feasible once I've gotten through my other list of things... [00:43] huwshimi: k, yea. It's not as simple as I'd hoped because of the new conditional rules. [00:43] :( [00:43] huwshimi: the other thing is to always show a home link to start out [00:43] and add the conditions as follow ups [00:44] rick_h: I'm guessing the search/categories bug I filed is probably not trivial either? [00:46] huwshimi: I don't think it's hard. I think the category links need a more specific viewNavigate change object. [00:46] huwshimi: it's not clearing out enough stuff. [00:47] rick_h: OK, I might take a look at that later if I get a chance. [00:52] huwshimi: yea, basically in browser/browser.js in the _getStateUrl it's merging the filters where it sounds like it should replace the data. [00:52] line 81, this._filter.update(change.filter); [00:53] it wasn an update so that as you changed yuor checkboxes in the filter it would add/subtract one item at a time. [12:29] bac: I have finished walking through the email quagmire and am soon to reach the caffeine castle. Once that journey is complete I can help you battle the CSS dragon. [12:30] benji: the css quagmire was holding up the branch you reviewed yesterday. the problem was a setting being inherited from bootstrap. [12:30] benji: thanks, though. [12:31] oh, good! [12:31] I'll have to find a different dragon then. [12:32] benji, other dragons available. ping me :-) [12:33] will do [12:36] please review and land Huw's most recent branch ASAP: https://codereview.appspot.com/11209043/ [12:40] i'm reviewing the above [12:41] I'll do a review too. [12:47] thanks [12:58] jujugui: it is known that dragging of service inspectors is completely broken? [12:58] I thought it was just the branch I am reviewing, but it happens on trunk too [12:59] luca__, rick_h I am swamped with meetings this morning. I just sent out an email about the priorities for today. Please review. Also, could you please discuss together the home/back button issue and the search interaction issue between categories and text? For each of these I would like an expedient solution we can implement today in an hour and land, which may require discussion. [13:00] rick_h, luca, I think these experiences are broken ATM, and my goal is to not be broken for this release. [13:00] benji, service inspectors are not draggable in Luca's design. We may want them to be draggable to demo variation ideas from MS. "Flexible" [13:00] benji: http://uistage.jujucharms.com:8086/:flags:/serviceInspector/ is really borked [13:00] is goal [13:01] gary_poster: sure, I'll get in touch with Rick [13:01] gary_poster: in that case they are broken on the trunk because they are partially draggable ;) [13:01] ok thanks [13:11] benji: do you see the inspectors being completely broken on huw's branch? no content for most 'tabs'. [13:12] gary_poster: will do, I'm afk a little bit this morning but will try to meet up with luca [13:12] bac: nope, I didn't click on any of the tabs; let me look real quick [13:12] bac: yep, very broken [13:12] benji: i'm unsure what we're supposed to be looking for. luca__ do you know? [13:20] sinzui: I'm still getting setup at the dealer here and might not make the standup. My branch for autocomplete is updated ready for final review by you and hatch. [13:20] sinzui: will try to get into the call as there's some important stuff flying around atm. [13:24] thank you rick_h [13:28] benji: bac inspectors are not supposed to be dragable [13:29] 8086 is also working as expected here [13:29] hatch: some content drags and snaps back. is that expected? [13:31] bac: did you find out if the empty inspector tab issue was introduced on this branch or pre-existing in trunk? If not I can test it quickly. [13:31] benji: i did not yet [13:31] bac: I'll take a look. [13:31] benji: it's a known issue - it happens when you open the inspector too quick after deployment [13:32] ah, ok [13:32] race conditions are fun [13:32] run faster! [13:33] gary_poster: me and Ale have just had a meeting with MS and he's very happy with the inspector [13:33] gary_poster: there are some content changes but overall he was pretty positive [13:33] luca__, awesome :-) [13:33] gary_poster: said the new Juju looks f'ing amazing [13:33] lol :-) [13:34] bac: the dragging is not expected - that's not a known bug :) [13:34] bac: gary_poster do I need to look at anything? [13:34] luca__: benji and i are looking at huw's branch https://codereview.appspot.com/11209043 [13:35] luca__: the description references some visual changes you requested but doesn't state what they are. if you know and can verify the fix that would be helpful [13:35] bac: I can try to bar it [13:36] bac: bzr [13:38] bac: checking it now against the list of bugs I sent off [13:39] luca__, I need to have some help from you with the expedient plans for home/back and search interaction, but I'm swamped and rick_h is afk. I will ping asap, 'cause these are biggest risks remaining IMO [13:39] I'm swamped on calls I mean [13:39] gary_poster: ok, I'm available most of the afternoon [13:39] thank you luca__ [13:39] luca__: gary_poster hopefully I can be free in the next hour [13:39] thanks rick_h [13:41] bac: gary_poster I can confirm that all of the bugs I submitted yesterday have been fixed in visual-update-5 apart from the 2 that have been stated in gary's email [13:41] luca__, great, thank you! [13:41] bac could you land when you are satisfied please? [13:43] gary_poster: if there are small issues with the branch you want me to just fix them then land, i assume. [13:43] bac yes please [13:43] cool. i'll wait for benji's input (if it isn't there yet) [13:44] bac: I just posted (not LGTM, unfortunately; big problem with the test runner) [13:44] benji: rt [13:44] bac: "rt"? [13:45] benji: 'roger that'. i think i've referenced my helicopter pilot fantasy before? [13:45] heh [13:57] gary_poster: I'm ready for a dragon quest. Should I take up that NPM cache issue? [13:57] bac, did you mention to luca about whatever different assets we need for the zoom widget? [13:57] benji no one sec [13:57] k [14:01] benji, oscon tasks have highest priority today. I sent email and have new "urgent" kanban section. If bac could use help in fixing Huw's branch, that would be best use of time. Otherwise see urgent section of kanban [14:01] gary_poster: what we have may work, though limited to a fixed size slider. [14:02] gary_poster: will do [14:02] bac: I described the problem with the body styling and test runner in the review, but I could easily work up a patch. [14:02] gary_poster: this page has an example using very similar assets. http://yuilibrary.com/yui/docs/slider/slider-from-markup.html the issue is the lack of separate images for the rail and end caps [14:03] benji: i'll ping you if that'll be more efficient [14:03] k [14:04] bac, ack. luca, ^^^ is that enough info to ask jaime for what we need? AIUI, as a convenience it would be great if he could simply slice the images per the example above [14:04] sorry, luca__ ^^^ [14:05] gary_poster: there is also the possible issue of the thumb image being a sprite with embedded shadow. unsure how much of this YUI skinning should be pushed to jamie [14:05] bac, when you say "unsure how much" you mean we possibly/probably should not push it to him, because we will be better able to identify what we need? [14:06] and it is simply a matter of slicing? [14:06] gary_poster: i'm saying YUI skinning has very specific requirements and it is unclear who should ferret them out. [14:08] bac ok. luca__ scratch that scrollbar request for now :-) thank you [14:09] jujugui: head's up, i have an appliance repair dude showing up at 11, so i'll be absent for the retrospective. i don't see any cards i have a strong feeling about, so you shouldn't feel my loss very keenly. :-P [14:09] * benji feels a vague sense of loss. [14:11] * jcsackett laughs [14:15] gary_poster: I would ideally tackle one of the two criticals that have yet to be claimed. They both list needing to be discussed, have they been? [14:16] benji: how do i reproduce the test failure you saw? [14:17] bac: its not so much a test failure, but a failure of the tests. Run the tests, wait for them to end, try to scroll up, feel frustrated and listless. [14:18] benji: i ran 'make test-server' and i can scroll around a-ok in chrome. what am i missing? [14:18] benji: but i do feel listless [14:18] bac: let me replicate it again, one second [14:19] lol [14:20] gary_poster: was dealing with something, is there anything you need? [14:21] luca__: I think the 'reviewed' icons look like 'favourite' buttons [14:21] just sayin :) [14:21] hatch: your not the only one to say that, we are testing it on monday and tuesday with 10 users from the inductry [14:22] rick_h: and I decided a better symbol would be two lions fighting over a steak with a shark jumping overhead [14:22] hatch: +1 I'll get jamie to mock something up :D [14:23] lol [14:24] so huw's branch added overflow: hidden to the body, but something added overflow: auto to the element [14:24] causing the scroll bar to re-appear [14:25] benji, they have not yet been discussed. not ready [14:25] k [14:26] luca__, nothing I need right now thanks, till Rick is ready [14:26] luca__: ping for when you get time to chat [14:26] ooh ooh! [14:26] gary_poster: too since it makes him so happy :) [14:27] :-) [14:27] I will join if I can but I have another call for now. Very excited about possibility of getting a reasonable quick resolution to those issues though :-) [14:27] bac: I can't reproduce the error now. I don't know what happened. So you can disregard the patch part of that comment, but the part about removing the now-redundant code still applies. [14:27] hatch: would really appreciate if you can re-look at the AC branch this morning so I can get that in/up. [14:27] benji: done [14:28] gary_poster: heh, don't get your hopes way way way way up :P [14:28] :-/ [14:28] ok [14:29] sinzui: while I wait to get some time with luca__ did you want to chat for a sec for anything hangout related? [14:30] rick_h: I'm free you need anything [14:30] luca__: ok, will send an invite one sec [14:30] rick_h: hatch is this better for the reviewed icon? https://docs.google.com/a/canonical.com/file/d/0B7XG_QBXNwY1WWwyd2cyLWtrWWc/edit?usp=sharing [14:30] luca__, LOL! [14:30] BAHAHAHAHAHA [14:31] hehe [14:31] luca__: https://plus.google.com/hangouts/_/0c7a8746abe1e765bf1f06cd256f317702da126d?hl=en [14:31] antdillon hey https://plus.google.com/hangouts/_/b00dc841a3b70c4f357210452e531a462a28841a [14:31] do it do it!!!! [14:31] luca__: O...M...G on the icon [14:31] * gary_poster still giggling [14:32] gary_poster, Im there [14:32] jujugui: what are the steps to use lbox to submit another's branch? how does it link my local branch to huw's MP? [14:33] bac: are you going to land huw's branch that you NLGTM'd? [14:33] bac, -adopt, I think [14:33] hatch: catch up man. I changed my vote. [14:33] ohh lol ok well one second [14:33] Makyo: is that really all that is requried [14:34] there is a breaking change in my QA [14:34] bac, no clue :D [14:34] bac, the docs for lbox are...well... [14:34] what...there are docs for lbox? ;) [14:34] Makyo: i branched trunk into a 'review' branch then merged his branch in. can lbox really link it all together? [14:35] 'lbox submit -h' isn't too clear on what happens. guess i can try. [14:35] hatch: so i'm waiting on a review from you? [14:35] bac: I just qa'd see my comments as one thing needs to be fixed before it lands in trunk [14:36] hatch: the overflow issue is resolved per benji's review suggestion [14:36] bac, I've never had the chance to try, I juist know the option exists. [14:37] Makyo: ditto. i'll report back. [14:37] bac: ohh ok - I thought that would do the exact opposite of what we wanted [14:37] the bigger issue is the small charm config when not under the flag [14:38] hatch: i don't understand what you mean. wanna chat? might be fastest [14:39] sure [14:39] in guichat [14:44] hatch: rejoining [14:44] bac sorry it all crashed, rebooting [14:46] bac: so when I did his stuff I just created a branch under my name, merged his stuff in, pushed to my account, and re-lbox'd it references his codereview url in a self-LGTM as the dicussion was over there and then submitted it [14:46] sinzui: ok, off that call, shifting up what I'm working on based on emails and such. Let me know if we need to sync up. [14:46] rick_h: sweet, thanks for the details [14:47] but now i'm super curious about -adopt [14:47] rick_h, I see you have already claimed one of the important issues on the board [14:47] sinzui: so I put back those as they're considered lower priority than fixing the home button according to luca and gary_poster's email [14:48] yep, I saw you do that [14:48] the other things lower on the priority list are all dependant on removing the filters UI and the default filter settings. So they're nice to have but will be more work than EOD will allow [14:48] kanban doesn't tell you who is watching [14:48] * rick_h feels stalked [14:48] :P [14:49] bac: ok I'm back now but I have to set my env back up - were you able to reproduce with mysql? [14:49] hatch: no, it looks good to me [14:50] ok one minute I'll set this back up [14:50] jujugui call in 10 kanban now [14:50] hopefully my lbox submit finishes before then :( [14:51] jsbin is down :( [14:52] rick_h, hey, you still talking? [14:52] gary_poster: done talking atm [14:52] gary_poster, Oh forgot to say, I am off on Monday (its my stag do this weekend) I will be starting on Tues [14:53] antdillon, oh cool, congrats and have fun. :-) see you Tuesday then. Maybe we'll have more for you to work with by then :-) [14:54] rick_h, mind joining guichat real quick to summarize plans for me? [14:54] gary_poster: yep one sec [14:54] hatch: you still rebooting? [14:54] thanks [14:54] bac: yup just booting up the env [14:54] (i really gota setup a script for this) [14:57] gary_poster: joining [14:57] jujugui call in 3 [15:00] bac take a look at my screen for the bug [15:03] hatch: sinzui https://codereview.appspot.com/11126043/ is updated, comments replied to, tests updated. let me know if there's anything else needed. [15:04] benji: you still have huw's branch marked bad. do you want another pass or just land with your dissent? [15:04] bac: I'll re-mark now [15:04] but it'll be a lie! :) [15:04] rick_h, criss-crossed. You got my LGTM [15:07] gary_poster: that sounds like a good check for 'charm proof' [15:21] abentley: could you please have another look at https://code.launchpad.net/~adeuring/charmworld/get-file-content-from-bzr/+merge/173987 ? [15:22] adeuring: Sure. [15:24] adeuring: I don't understand "I chose to return the branch's directory instead of the branch itself because the directory is needed as an entry in the charm_data dictionary during test setup". You can get the directory from the branch, as I explained. [15:24] abentley: I know, but that's not what is needed in tests -- it's the directory [15:26] adeuring: So you're saying it was for convenience? [15:27] abentley: yes [15:27] OK [15:28] adeuring: at 103, you are patching BZR_EMAIL into the environment, but bzr_isolation should do that for you. [15:28] abentley: ouch, forgot hat... I'll fix it [15:44] adeuring: r=me. [15:44] abentley: thanks [16:01] Bugger. webops are creating unversioned tarballs. [16:04] gary_poster, or bac: Webops asked that we add an upgrade hook to the juju-gui stable charm to handle cases where we want to deploy a new release of the app. This seams easy enough, but now I see the webops scripts create unversioned tarballs. There is never a config change to indicate to the backend to unpack the tarball. [16:05] sinzui, the tarballs are always named the same? [16:05] yes [16:05] :-/ [16:05] yes, :( [16:05] I see other problems with their script [16:05] sinzui, easiest solution is to add revid to the tarball name [16:05] if unversioned [16:05] the source is hardcoded. They need to edit the script each deploy. [16:06] I'll propose a replacement script that makes it easy for them and us to do a deploy of just the app [16:07] sinzui, cool, thanks. is this documented on your wiki page? [16:07] No. [16:08] I got a pastebin copy of the script. https://pastebin.canonical.com/94228/ [16:08] The version was changed yesterday to my request, but the script will need to be edited again for the next request :( [16:09] luca__: around? [16:12] bcsaller, could you let me know what you think about in terms of difficulty of getting those export issues addressed? [16:13] when you've had time, of course [16:18] gary_poster: I'm reviewing them now, there are some questions, like qualified charm name, precise/mysql-1 or cs:precise/mysql, including rev, etc? Just not sure yet, making notes on some of the bugs [16:21] Makyo: what browser were you using when you saw bug 1200412? [16:21] <_mup_> Bug #1200412: drag-and-drop: dropping a service on a non-drop target leaves the token appended to the body [16:21] benji, Chrome v28 [16:24] Makyo: hmm, I'm running the same and I can't reproduce the symptoms listed in the bug. [16:24] luca__: take two, would love a sec to chat. [16:24] Checking.. [16:25] rick_h: sure [16:25] rick_h: got a hangout? [16:25] couple of ? for you luca. Hangout? [16:28] benji, hmm, quick chat so I can screenshare? [16:28] Makyo: sure, guichat is open [16:41] sorry was dc'd [16:42] reposting - bcsaller: re your 250ms comment - I'm OK with either approach just curious if you were planning on changing to rate limiting vs debounce or leave it for now? [16:42] hatch_: I left it for now, I think it will be fine the way it is, but we can keep an eye on it [16:42] alright sounds good :) [16:44] why do I have to add my ssh key to be able to pull from our bzr repo...did it get locked down by accident? :) [16:55] hazmat: ping [16:56] bcsaller, pong [16:56] hazmat: can you check the comment in https://bugs.launchpad.net/juju-gui/+bug/1200625 and see if that export matches your needs [16:56] <_mup_> Bug #1200625: gui export is exporting invalid config options / not respecting type when serializng === hatch_ is now known as hatch [16:56] that includes service output, annotations and config changes [16:56] hmm [16:56] i was going against uistage.jujucharms.com:8086 [16:56] maybe that's not on a cron [16:57] bcsaller, might be some noise then.. your comment export looks good to me, [16:57] * hazmat checks trunk [16:57] hazmat: that export is from my current branch, I didn't change the options handling but the other things were changed, I have to propose this [16:57] oh [16:57] gotcha [16:58] if it looks good then it should be ready [16:58] but the options handling seemed sane out of the box [17:00] bcsaller, the yes/no thing correspond to booleans in yaml [17:00] but the type is a string [17:01] ie when that gets passed to juju core it will barf on debug setting [17:01] sounds like an import error ;) [17:01] since it per the charm config schema it should be a string, but comes in as a bool [17:01] not really [17:01] its two bugs [17:01] sorry phone call [17:01] exporting default === matsubara is now known as matsubara-lunch [17:02] its going out as a string here, the parse side translates it to a bool in implicit conversion which is wrong [17:03] wait, you don't want me to export if its the default value on the charm? more work but I can do that [17:08] gary_poster, http://comingsoon.jujucharms.com/ is up [17:08] awesome thanks sinzui! [17:09] hey luca, you really here? :-) [17:09] gary_poster: just leaving [17:10] gary_poster: if you send me an email ill pick it up [17:10] cool thanks luca ttyl [17:23] rick_h: https://bugs.launchpad.net/charmworld/+bug/1200704 [17:23] <_mup_> Bug #1200704: charm search autocomplete has slow options request times [17:23] hatch: cool, will put on the board. Thanks. [17:27] rick_h: I LGTM'd the branch pending the css fix as everything else looked good - the clickoutside if you can't fix we can follow-up with a fix on that [17:28] hatch: ok, will look into it in a little bit. Almost done with this home branch. A 'testing' we shall go...a testing we shall go... [17:28] curses, luca left [17:28] high ho the dairy o a testing we shall go [17:29] not sure what a dairy o is [17:29] it's probably something horrible [17:29] gary_poster: I've got the home link branch up here. lp:~rharding/juju-gui/home-link I was hoping to get luca to look before he left but :( [17:30] gary_poster: I also found a decent fix for the search/category issue and have fixed it in there. I'm working on tests to support the changes but if anyone wants to QA in luca's place I'd love to hear it's what's expected. [17:31] rick_h, home link: thank you! shoot him a mail. he said he would be checking. I'm sending him a couple too. I'll look soon too, though if you are happy with it then I'm +1 on starting the review process. search/category: even more awesome! I guess I'm the only one who can at this point unless you get luca's reply. [17:32] I will do so asap, though I have two emails I'm trying to plow through before then [17:32] gary_poster: ok, will shoot him an email. Tests will add a little time but trying to get it going and up for review asap. [17:32] cool thanks you! [17:32] gary_poster: understood, just a heads up on where we're at and such. [17:32] great [17:37] rofl https://twitter.com/horse_yui/status/355741939955544065 [17:43] :-) [17:45] hey jcsackett , one of our goals that I'd forgotten about was that, when on jujucharms.com, instead of seeing "log out," you would see ...something else that I forgot. A link to somewhere. Did you do that as part of your default view work? [17:45] time to acquire food, brb [17:51] gary_poster, could you or bac add additional details to https://bugs.launchpad.net/charm-tools/+bug/1200713 when you have an opportunity [17:51] <_mup_> Bug #1200713: Charm Proof: Ensure the default configs match the defined type [18:00] arosales, bac, added === matsubara-lunch is now known as matsubara [18:05] gary_poster thank you. [18:06] bcsaller, yes re default [18:06] arosales: done too [18:06] hazmat: thats fine but it only masks this issue, doesn't prevent it [18:06] bcsaller, re serialization in general, it would be good to cast to the specified config type as well. arguably its a bug in core and one in the charm [18:07] yeah, re core [18:12] bcsaller: I see when you added the icon to the inspector you used the databinding for the header information [18:12] that information is not supposed to be in a viewlet [18:12] can you think of a way to bind to the fields without requirng a viewlet? [18:13] hatch: VC owns databinding, its can either add a slot for header with the viewlet or add the databinding with addBinding directly [18:13] I think a slot and a viewlet make sense, its just a slot we always show [18:15] hmm [18:16] yeah slot probably does make the most sense as far as separation of concerns is.....concerned [18:16] will do that, thx [18:18] jujugui: small branch to fix a drag and drop issue: https://codereview.appspot.com/11138044 [18:18] benji: i'll do one [18:18] thanks [18:18] benji: got it [18:18] great [18:19] position fixed on the body eh? heh [18:19] I foresee issues in the future [18:20] benji: why is that overflow still in service.js? it should've been removed in trunk [18:20] bac: it may have been a race with me branching. I should have merged in trunk before proposing. I'll do that now. [18:21] benji: doesn't lbox produce a diff against trunk? [18:21] i mean, you shouldn't have had to do anything. [18:21] [18:22] I'm re-proposing the merged branch now. [18:23] benji: I'm doing a QA, which revno are you on? [18:23] just to make sure I have the right one [18:23] lbox produces a diff against :parent, which points to a revision of trunk. [18:23] That way new code doesn't show up as deleted. [18:24] hatch: 824; it's still in the process of proposing [18:24] hatch: ok, it's finished proposing [18:25] got it thx [18:25] benji: cool, your diff is much smaller now [18:25] good [18:27] benji: QA fails spectacularly [18:27] hatch: how so? [18:27] drag and drop (so fixed gets applied) [18:27] then d click on the inspector [18:27] dclick on the service [18:27]