| frankban | gary_poster: morning, here is a prototype: http://bazaar.launchpad.net/~juju-gui/juju-gui/server/view/head:/proto.py . would you like to have a quick call with me and teknico? | 13:08 |
|---|---|---|
| gary_poster | frankban, would love to! 10 min? | 13:08 |
| frankban | gary_poster: sure, we are in http://tinyurl.com/emily-code | 13:09 |
| rick_h | jujugui jcsackett code reviews pls https://codereview.appspot.com/11348043/ (see the note that it can't land yet until charmworld is updated) | 14:08 |
| rick_h | hatch: http://jsbin.com/utitov/3/edit | 14:13 |
| rick_h | http://jsbin.com/utitov/3/edit | 14:14 |
| rick_h | jujugui need a second review of Huw's work under here: https://codereview.appspot.com/11352043 I had to make two updates per his old review https://codereview.appspot.com/11332043/ | 14:35 |
| luca | gary_poster: there seems to be a bug that if you add to canvas a charm that uses a category charm icon that it doesn't show in the service block. | 14:36 |
| luca | gary_poster: is this a known issue? | 14:36 |
| rick_h | luca: yes, fix inbound | 14:36 |
| rick_h | well kinda | 14:36 |
| gary_poster | luca, yes, but thank you! rick_h and Makyo working on that and related issues now | 14:36 |
| rick_h | luca: work is in progress to update and make it work :) | 14:36 |
| luca | rick_h: hehe just noticed from the testing | 14:36 |
| luca | gary_poster: no worries :) | 14:36 |
| abentley | sinzui: I can has review? https://code.launchpad.net/~abentley/charmworld/support-bundles/+merge/175038 | 14:46 |
| Makyo | "has anyone really been far even as decided to use even go want to SVG?" | 14:53 |
| abentley | benji: lp:~abentley/charmworld/support-bundles | 15:04 |
| rick_h | jujugui another review please, fixes two of arosales's bugs https://codereview.appspot.com/11355043 | 15:08 |
| rick_h | jcsackett: ^^ | 15:08 |
| arosales | rick_h, :-) | 15:12 |
| bac | rick_h: done | 15:16 |
| rick_h | bac: ty | 15:16 |
| jcastro | rick_h: I thought we were hiding the social buttons behind a share link? | 15:34 |
| jcastro | so we don't look like a NASCAR | 15:34 |
| arosales | jcastro, 3 buttons looks decent | 15:38 |
| luca | jcastro: we decided not to hide them behind a share link | 15:39 |
| jcastro | ok | 15:40 |
| rick_h | jcastro: no, it's been redesigned | 15:54 |
| rick_h | gary_poster: http://rickyrosario.com/blog/converting-a-url-into-a-link-in-javascript-linkify-function/ with updates to check for ['"] around the link should owrk | 15:54 |
| Makyo | sinzui, https://code.launchpad.net/~makyo/charmworld/icon-api/+merge/175052 | 15:55 |
| rick_h | gary_poster: follows your idea https://codereview.appspot.com/11357045 quick change if you want to peek and make sure it's a decent first step to those bugs | 17:22 |
| jcastro | hey is the "box should be getting bigger when I add units" been replaced with something else? | 17:25 |
| jcastro | or is it a bug? | 17:25 |
| jcastro | the progress bar is cool btw | 17:25 |
| bcsaller | progress or status? | 17:27 |
| jcsackett | jujugui: i have a very tiny branch i need looked at. mostly deletions. https://codereview.appspot.com/11370043 | 17:30 |
| bac | jcsackett: ok | 17:31 |
| jcsackett | thanks, bac. | 17:31 |
| jcsackett | can i get one more taker? | 17:31 |
| Makyo | jcsackett, on it. | 17:34 |
| ahasenack | hi guys, I just got introduced to the restart icon in juju-gui, lower right | 17:37 |
| gary_poster | jcastro, replaced | 17:37 |
| ahasenack | is that the final choice? Because I must say, it looks a lot like reload to me | 17:37 |
| ahasenack | http://i.imagebanana.com/img/aue03yt0/Selection_004.png | 17:38 |
| === matsubara is now known as matsubara-lunch | ||
| gary_poster | jcastro, bug 1201860: already fixed, maybe? Don't see what you reported when I go to http://uistage.jujucharms.com:8086/fullscreen/search/precise/node-app-7/#bws-interfaces | 18:29 |
| _mup_ | Bug #1201860: Horizontal scroll bar if the related charm has a long string <juju-gui:New> <https://launchpad.net/bugs/1201860> | 18:29 |
| gary_poster | ellipsis now for mwe | 18:29 |
| gary_poster | me | 18:29 |
| gary_poster | ahasenack, yeah that's been the icon since the spring. filed https://bugs.launchpad.net/juju-gui/+bug/1201921 for you fwiw | 18:31 |
| _mup_ | Bug #1201921: Landscape restart link looks like browser reload <juju-gui:New> <https://launchpad.net/bugs/1201921> | 18:31 |
| jcastro | gary_poster: yep, looks fixed here too | 18:34 |
| gary_poster | thanks jcastro | 18:37 |
| jcastro | gary_poster: am I keeping you guys busy over there? :) | 18:46 |
| gary_poster | jcastro, ecosystems is, and we appreciate it a lot :-) | 18:47 |
| rick_h | woot! | 18:49 |
| rick_h | makes the pretty prettier | 18:50 |
| jcastro | gary_poster: dang, I think I found a pretty serious one | 19:03 |
| jcastro | unless it's like this by design | 19:03 |
| gary_poster | jcastro, uh-oh, whatcha got | 19:03 |
| jcastro | but http://uistage.jujucharms.com:8086/fullscreen/search/precise/memcached-6/?categories=applications&text=memcached | 19:03 |
| jcastro | so I searched for memcached | 19:03 |
| rick_h | jcastro: in chrome? known bug | 19:03 |
| jcastro | clicking on the result should take me to memcached's page right? | 19:03 |
| jcastro | oh ok | 19:03 |
| rick_h | jcastro: yea, known bugs | 19:03 |
| gary_poster | jcastro, yeah, if you are on a charm and then you search for the same charm then click on the charm, then that doesn't work right now. Rick and I have talked about it, and this will be difficult to fix. We felt that this was enough of an edge case that it was not a showstopper. Do you disagree? | 19:05 |
| gary_poster | jcastro, not super difficult to fix, but more time than I'd prefer to take before OSCON. Fixing it is an option, but throws out schedule for the week out. | 19:06 |
| jcastro | Well if I know it's there I can avoid it during the charm school. :) | 19:06 |
| gary_poster | heh | 19:06 |
| rick_h | jcastro: 1200743 | 19:07 |
| rick_h | jcastro: #1200743 that is | 19:07 |
| _mup_ | Bug #1200743: complex search/view interactions in fullscreen fail to work <charmbrowser> <juju-gui:Triaged> <https://launchpad.net/bugs/1200743> | 19:07 |
| jcastro | ta | 19:07 |
| === matsubara-lunch is now known as matsubara | ||
| jcastro | did the "doesn't deploy discourse" bug get fixed? I can't seem to find it on LP | 19:08 |
| rick_h | jcastro: yea, should be fixed | 19:10 |
| Makyo | hatch, lp:~makyo/juju-gui/use-icon-api | 19:11 |
| jcastro | hmm, discourse icon is busted | 19:13 |
| jcastro | but it's svg | 19:13 |
| rick_h | jcastro: linky? | 19:17 |
| rick_h | jcastro: so it's not reviewed. Unreviewed charms never get an icon | 19:18 |
| rick_h | jcastro: we don't trust people :) | 19:18 |
| jcastro | ugh | 19:18 |
| jcastro | seriously? | 19:18 |
| marcoceppi | rick_h: what about openvpn-as ? | 19:18 |
| rick_h | marcoceppi: what about it? | 19:19 |
| marcoceppi | rick_h: what about openvpn-as ? | 19:19 |
| marcoceppi | rick_h: http://i.imgur.com/nhSv7vA.png | 19:19 |
| rick_h | http://uistage.jujucharms.com:8086/sidebar/precise/openvpn-as-2/ | 19:19 |
| marcoceppi | That's not what I see | 19:19 |
| marcoceppi | it has an icon and it's not rendering | 19:19 |
| rick_h | marcoceppi: browser? | 19:20 |
| rick_h | marcoceppi: which browser/version? | 19:20 |
| marcoceppi | Chrome 28.0.1500.71 | 19:20 |
| jcastro | doesn't render here either in chrome 28 | 19:20 |
| rick_h | marcoceppi: so looks like maybe a cache issue according ot the room | 19:21 |
| rick_h | right-click the icon and choose to open in a new tab | 19:21 |
| rick_h | marcoceppi: and you should see the icon | 19:21 |
| arosales | 26.0.1410.63 also doesn't render openvpn-as-2 | 19:21 |
| rick_h | and test it in FF | 19:21 |
| jcastro | works in firefox though | 19:21 |
| marcoceppi | rick_h: doesn't work in porno-mode | 19:21 |
| rick_h | marcoceppi: so the suggestion here is to force clear your cache | 19:21 |
| rick_h | marcoceppi: hmm, then maybe a browser svg issue? | 19:21 |
| arosales | rick_h, in a new tab in chrome 26 I see the valid icon | 19:21 |
| rick_h | marcoceppi: it works in chrome 29, FF | 19:22 |
| rick_h | and according to arosales 26, so I'm guessing it's a chrome 28 bug. | 19:22 |
| marcoceppi | rick_h: renders if I visit the URL directly. Might be a browser quirk. https://manage.jujucharms.com/api/2/charm/precise/openvpn-as-2/file/icon.svg | 19:22 |
| rick_h | someone with 28 says once htey opened it in the new tab it worked | 19:22 |
| rick_h | marcoceppi: rgr | 19:22 |
| marcoceppi | OMG | 19:22 |
| marcoceppi | wait, this API | 19:23 |
| marcoceppi | is it like psuedo api or could I throw queries against it? | 19:23 |
| rick_h | marcoceppi: huh? | 19:23 |
| rick_h | marcoceppi: what api are we speaking about here? | 19:23 |
| marcoceppi | rick_h: *tear to my eye* https://manage.jujucharms.com/api/2/charm/precise/openvpn-as-2/ | 19:23 |
| rick_h | marcoceppi: yea, sec. I'll get you docs link | 19:23 |
| marcoceppi | amazing, it's like everything I've ever needed but had to branch lp to get the information | 19:24 |
| rick_h | marcoceppi: http://bazaar.launchpad.net/~juju-jitsu/charmworld/trunk/view/head:/docs/api.rst | 19:24 |
| rick_h | marcoceppi: this is the charmworld (juju-gui data source) api we've created. It's vesioned though so watch out for changes as things progress | 19:24 |
| marcoceppi | rick_h: and it's versioned, I could probably seriously cry | 19:24 |
| rick_h | marcoceppi: so everything in the browser is working on that api | 19:25 |
| rick_h | marcoceppi: hey, we've not been building houses of cards here :P | 19:25 |
| marcoceppi | where will the permenant endpoint be once launched? jujucharms.com? | 19:25 |
| rick_h | marcoceppi: manage.jujucharms.com is the permanent api endpoint | 19:25 |
| marcoceppi | \o/ | 19:25 |
| rick_h | jujucharms.com will be a juju gui install pointed at manage.jujucharms.com for its data | 19:25 |
| marcoceppi | amazing, definintely a game changed | 19:25 |
| rick_h | marcoceppi: cool, hope it's useful | 19:25 |
| marcoceppi | changer* | 19:25 |
| jcastro | Scumbag rick, full API, no icons. | 19:26 |
| marcoceppi | w/e I'll take API over weird rendering issue in Chrome any day | 19:27 |
| arosales | I see rick_h's point the any one could commit a crazy icon and have it load in the charm store unfiltered | 19:27 |
| rick_h | arosales: yea, we discussed it and we decided it's nice to only have the reviewed charms have the pretty icons | 19:27 |
| rick_h | it helps in search results/etc | 19:27 |
| marcoceppi | Good guy Rick, can't help rendering issue on a specific browser, but has a full api to data | 19:27 |
| arosales | +1 on that rick_h | 19:27 |
| jcastro | I'd rather have the icon but black and white or something | 19:28 |
| jcastro | I don't buy that people would take advantage of it, if that was the case people would be posting porn on github and launchpad all the time | 19:28 |
| marcoceppi | jcastro: b+w icon would probably be more work than nessiary | 19:28 |
| rick_h | jcastro: yea, we've had these discussions a few times now | 19:29 |
| arosales | jcastro, hey if you want your charm have an icon just get it into the charm store ;-) | 19:30 |
| arosales | it not like were saying no, | 19:30 |
| arosales | just that you need to be in the charm store | 19:30 |
| jcastro | yeah but our issue is pre-beta software shouldn't be in the store | 19:30 |
| jcastro | so we keep it in ~marcoceppi on purpose | 19:30 |
| arosales | agreed, so get those reviews in and make non beta | 19:31 |
| jcastro | no I mean the upstream | 19:31 |
| marcoceppi | upstream is pure alpha right now | 19:31 |
| marcoceppi | and changing fast | 19:31 |
| jcastro | I guess we'll demo Liferay and something else then | 19:32 |
| jcastro | I don't wanna demo a non-icon | 19:32 |
| marcoceppi | whew | 19:32 |
| marcoceppi | I mean, that's too bad | 19:32 |
| jcastro | :) | 19:32 |
| * arosales looking at charm review guildlines . . . | 19:32 | |
| arosales | jcastro, I don't see @ https://juju.ubuntu.com/docs/authors-charm-policy.html | 19:33 |
| arosales | where it states a charm will be ack'ed if upstream is still not fully GA | 19:33 |
| marcoceppi | arosales: jcastro we should probably head back over to #juju | 19:33 |
| marcoceppi | leave these nice people alone :P | 19:33 |
| rick_h | :P | 19:33 |
| * arosales moves to #juju :-) | 19:33 | |
| arosales | rick_h, gary_poster et all keep up the good work | 19:34 |
| arosales | Charm Browser/Gui looking good! | 19:34 |
| gary_poster | thanks arosales :-) | 19:34 |
| jcastro | I promise no frantic voicemail this time gary_poster | 19:34 |
| jcastro | I remember last time like calling Rick from the show floor | 19:35 |
| gary_poster | lol | 19:35 |
| gary_poster | I hope not :-) | 19:35 |
| rick_h | jcastro: if you get a sec please check ou uistage for updates to your two bugs about the newline issues. | 19:38 |
| rick_h | jcastro: one I think is fixed (description) and hte changelog we've submitted some small tweaks to, so not marked it fixed but curious if that 'helps' | 19:38 |
| jcastro | yeah better | 19:40 |
| jcastro | I think that we should do debian/changelog format for the changelog, but good enough for OSCON for now | 19:40 |
| jcastro | For description I think we should trim down the descriptions since that's in the yaml and instead encourage people to put the formatting in README | 19:40 |
| rick_h | jcsackett: http://paste.mitechie.com/show/982/ | 19:42 |
| arosales | rick_h, gary_poster configuration looking better and quality tab moved to the right :-) | 19:53 |
| arosales | rick_h, gary_poster: do you guys think inserting a horizontal line between config parameters would help with the readability? | 19:55 |
| arosales | ie http://uistage.jujucharms.com:8086/sidebar/search/precise/mysql-25/#bws-configuration has a few | 19:55 |
| arosales | as does http://uistage.jujucharms.com:8086/sidebar/search/precise/mongodb-15/#bws-configuration?series=precise&text=mongodb#bws-configuration | 19:55 |
| rick_h | arosales not sure. I think it'd be nice if we could dedent the config name part of the display to make it easier to jump from config-key to key | 20:01 |
| arosales | rick_h, ya I didn't have any super strong opinions. It just looked like it needed something to break it up, but not a biggie. | 20:01 |
| rick_h | arosales: yea, it'll have to go through UX tbh | 20:02 |
| arosales | rick_h, roger that. What were saying earlier, make the pretty prettier | 20:02 |
| arosales | sounds like one of these cases | 20:02 |
| arosales | commit # landed, quality tab moved, configuration formatting fixed -- its like christmass in july | 20:04 |
| rick_h | just wait until icons lands tomorrow | 20:05 |
| arosales | we should probably have a count down meter :-) | 20:06 |
| rick_h | hah | 20:07 |
| jcastro | hey rick_h | 20:14 |
| jcastro | for post OSCON | 20:14 |
| jcastro | I want `juju set juju-gui icons=true` so when I demo to people we get glorious colored icons | 20:14 |
| jcastro | just an idea. :) | 20:14 |
| rick_h | jcastro: not going to happen. The logic is moved to the data store today and no way to force. :/ | 20:17 |
| jcastro | boo! | 20:17 |
| rick_h | jcastro: so the api won't ever show them. | 20:17 |
| marcoceppi | rick_h: damn | 20:18 |
| rick_h | marcoceppi: jcastro when we remove the filters and stop searching for only reviewed charms it'll make more sense. | 20:19 |
| rick_h | showing icons would suck in the ^^ case | 20:19 |
| marcoceppi | I don't mean to back seat drive, but would it have made more sense to just not show the icon if the api says the charm wasn't reviewed? Leave it to application logic and not a hard req in the api | 20:20 |
| marcoceppi | having only just learned of this magic api, I'm merely interjecting | 20:20 |
| rick_h | marcoceppi: so the api has access tothe file under the files api calls | 20:21 |
| rick_h | marcoceppi: but the icon api call goes through the 'should it be displayed' logic | 20:21 |
| rick_h | marcoceppi: so it's not that there's no way to access the icon and we'll continue to see the icon in the manage.jujucharms.com for review purposes and such | 20:21 |
| rick_h | marcoceppi: so that's why we did it this way. There's two paths to use and any apps using the icon path will get the one considered safe | 20:22 |
| marcoceppi | rick_h: ah, okay | 20:22 |
| rick_h | we did think about all this stuff, I promise. Lots of talks about it | 20:22 |
| marcoceppi | rick_h: I seriously don't doubt that! | 20:22 |
| marcoceppi | It was literally the first question that popped in my mind | 20:23 |
| rick_h | :) | 20:23 |
| rick_h | yea | 20:23 |
| rick_h | I completely understand. News to you guys and that sucks :( | 20:23 |
| marcoceppi | I already love the api though, (I could care less about icons ;) | 20:23 |
| marcoceppi | couldn't* | 20:23 |
| rick_h | marcoceppi: cool, abentley did a great job with the docs and implementation of that so send him a cookie if it's useful :) | 20:24 |
| * marcoceppi preheats oven | 20:24 | |
| sinzui | bac: https://code.launchpad.net/~sinzui/charmworld/stale-metadata/+merge/175126 | 20:34 |
| bac | done | 20:43 |
| rick_h | sinzui: http://staging.jujucharms.com/api/2/charm/precise/hadoop-13 | 21:05 |
| gary_poster | rick_h, http://bazaar.launchpad.net/~marcoceppi/charms/precise/discourse/trunk/view/head:/metadata.yaml | 21:25 |
| rick_h | jujugui https://codereview.appspot.com/11387043 eyeballs please to fix a new bug. jcsackett as well please | 21:36 |
| bac | rick_h: done | 21:41 |
| rick_h | bac: ty much | 21:44 |
| marcoceppi | Sorry about the discourse trouble. The original repo is in github and my bi-directional lp <-> gh plugin is really touchy. | 21:50 |
| rick_h | arosales: http://uistage.jujucharms.com:8086/precise/ceph-13/#bws-configuration little better? | 21:56 |
| jcastro | rick_h: much better | 21:59 |
| rick_h | jcastro: cool | 21:59 |
| rick_h | jcastro: check out uistage and drag some charms into the canvas :) | 21:59 |
| rick_h | jcastro: best examples are ones with category icons and such | 21:59 |
| jcastro | they are like spring loaded now | 22:00 |
| rick_h | and icon pretty | 22:00 |
| * arosales now taking a look at uistage . . . | 22:06 | |
| arosales | rick_h, ah, much better. Amazing what a little indentation does. | 22:07 |
| arosales | rick_h, my only feedback on the configuration would be to keep the keyword bold (ie auth-supported) and unbold & italic the type (ie string) | 22:13 |
| arosales | for the http://uistage.jujucharms.com:8086/precise/ceph-13/ example | 22:13 |
| rick_h | arosales: ah, good point. | 22:14 |
| huwshimi | Morning | 23:01 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
