| hatch | morning huwshimi | 00:31 |
|---|---|---|
| gary_poster | benji, you reviewing frankban's branch? | 11:41 |
| bac | ahoy sinzui | 12:07 |
| gary_poster | jujugui two reviews of https://codereview.appspot.com/11804043/ please? | 12:07 |
| bac | gary_poster: o/ (which translates to i'll do one) | 12:08 |
| gary_poster | thanks bac. we need that landed, and tehn a release today | 12:08 |
| gary_poster | benji, hi, you reviewing frankban's branch? | 12:08 |
| benji | gary_poster: hi | 12:09 |
| gary_poster | :-P | 12:09 |
| benji | I can review a branch; once I wake up a little, apparently | 12:09 |
| gary_poster | benji :-) sorry, cool about frankban's branch. I misremembered. I need a review of https://codereview.appspot.com/11804043/ so I can start a release | 12:11 |
| benji | gary_poster: I'll review https://codereview.appspot.com/11804043/ | 12:11 |
| gary_poster | thank you | 12:13 |
| gary_poster | bac or benji, I'm sorry, but we need one more for frankban's giganto branch. could one of you volunteer for that as well? https://codereview.appspot.com/11725044/ | 12:14 |
| benji | gary_poster: I'm up for a giganto review | 12:15 |
| gary_poster | thanks benji | 12:15 |
| benji | https://www.youtube.com/watch?v=7AtSHp35xUg | 12:16 |
| frankban | thanks benji and gary_poster, and sorry for the giganto giant | 12:18 |
| * frankban lunches | 12:18 | |
| benji | we all create monstrosities every know and then | 12:19 |
| bac | gary_poster: how do i qa your branch? | 12:22 |
| gary_poster | bac, thanks sorry for not clarifying in cover. qa for primary issue is that you have to start a juju core environment and deploy puppet | 12:24 |
| gary_poster | bac, I did that with Francesco and Mark Mims | 12:24 |
| gary_poster | bac, for other issues: | 12:25 |
| bac | gary_poster: are you saying the subordinate issue is sufficiently qa'd? | 12:25 |
| gary_poster | bac, yeah, I'm comfortable with it. | 12:25 |
| gary_poster | - create a service in sandbox. from environment, click on menu and then destroy. verify that styling is same as before (jujucharms.com). verify that charm browser looks ok. verify that zoomer looks ok. | 12:26 |
| bac | ok, and the sam-skin issue is fixed | 12:26 |
| bac | i see that | 12:26 |
| gary_poster | - you could try subordinates with the inspector. they are...better than they were before. :-/ :-D | 12:27 |
| bac | gary_poster: lgmt + qa-ok | 12:27 |
| gary_poster | bac, cool, thank you | 12:27 |
| bac | gary_poster: i'm having a brain block on subordinates. what is the canonical one to try? i tried rsyslog but it won't build relations to anyone | 12:27 |
| gary_poster | bac, puppet is a good one | 12:27 |
| bac | ok | 12:27 |
| bac | gary_poster: fwiw, testing destroy, i killed a service that had an inspector open. the service went away but the inspector stayed. oopsie. | 12:28 |
| gary_poster | bac, yeah, have seen :-/ | 12:28 |
| bac | rt | 12:29 |
| gary_poster | will make card and/or bug | 12:29 |
| bac | actually gary_poster doing qa on your branch i see some weird styling issues on the inspector. the X for closing has dropped from the upper portion of the section to the bottom of it | 12:31 |
| gary_poster | bac, huh. maybe it needs sam too? will investigate. ty | 12:32 |
| bac | gary_poster: reverting your branch puts it back to the right place | 12:33 |
| gary_poster | bac, cool. I suspect I need to put that sam thing on something. | 12:33 |
| benji | if anyone (like me) missed the GUI part of the keynote yesterday, you can enjoy it at https://www.youtube.com/watch?v=ZqmFXalqKic&t=714 | 12:45 |
| gary_poster | hey hatch_, when you are around lemme know. fun new bug to address asap :-P | 12:45 |
| bac | thanks benji, i forgot to watch | 12:54 |
| bac | hey, we made a whiteboard! | 12:54 |
| bac | new catchphrase: Juju GUI Export -- throw it up on metal! | 12:57 |
| gary_poster | lol | 12:58 |
| bac | huh, 2 of 3 comments on the video are about the codec support OSCON chose. | 13:04 |
| bac | hi sinzui -- seems my branch fixed 2 of the reports but the third is still broken. http://staging.jujucharms.com/reports/charm-contributors.json | 13:05 |
| bac | sinzui: can you get a traceback? | 13:05 |
| bac | teknico: would it be ok if you and i switched our 1:1 call times with gary as i have another call. it would mean your call with him would be in 24 minutes. | 13:06 |
| teknico | bac: that's ok for me | 13:07 |
| sinzui | bac: https://bugs.launchpad.net/charmworld/+bug/1204899 | 13:07 |
| _mup_ | Bug #1204899: ValueError in report json <oops> <charmworld:Triaged> <https://launchpad.net/bugs/1204899> | 13:07 |
| bac | thanks teknico | 13:07 |
| gary_poster | bac, teknico thanks. bac, one sec | 13:08 |
| bac | thanks sinzui | 13:08 |
| sinzui | bac: I was just extracting the TB from my email when you pinged. | 13:08 |
| === teknico1 is now known as teknico | ||
| ahasenack | guys, I deployed juju-gui with the config " juju-gui-source: trunk", and I still get the old look | 13:40 |
| ahasenack | and some sort of "IO error" in the alert box | 13:40 |
| ahasenack | "Could not retrieve charms: Error: IO data failure" | 13:40 |
| teknico | gary_poster: I'm in the 1:1 hangout: https://plus.google.com/hangouts/_/9042d8b55d7f3f374fcd41e731d334ff529957f1?authuser=1 | 13:41 |
| ahasenack | in /var/lib/juju/agents/unit-juju-gui-0/charm/release I have "juju-gui-0.3.1+build.595" | 13:41 |
| gary_poster | teknico, finishing up, there soon | 13:42 |
| ahasenack | javascript console has: | 13:42 |
| ahasenack | Failed to load resource: the server responded with a status of 500 (Internal Server Error) | 13:42 |
| ahasenack | https://manage.jujucharms.com/search/json?search_text=series%3Aprecise%20owner%3Acharmers <-- "Internal Server Error" | 13:43 |
| gary_poster | ahasenack, looking one sec | 13:44 |
| gary_poster | ahasenack, was this an upgrade? | 13:45 |
| gary_poster | ahasenack, I suggest trying | 13:45 |
| ahasenack | gary_poster: no, fresh juju gui depl | 13:45 |
| ahasenack | gary_poster: still, the server shouldn't 500 | 13:45 |
| gary_poster | really! | 13:45 |
| ahasenack | I don't know that this means too, it's in the console | 13:46 |
| ahasenack | XMLHttpRequest cannot load https://manage.jujucharms.com/search/json?search_text=series%3Aprecise%20owner%3Acharmers. Origin https://10.0.3.108 is not allowed by Access-Control-Allow-Origin. | 13:46 |
| ahasenack | 10.0.3.108 is the juju-gui's unit ip | 13:46 |
| gary_poster | ahasenack, agreed, but not the problem that worries me most atm. that's an old API. the question is, why are you getting it. | 13:46 |
| gary_poster | ahasenack, oh I know | 13:46 |
| gary_poster | ahasenack, | 13:46 |
| gary_poster | juju set juju-gui juju-gui-source=stable | 13:47 |
| gary_poster | or juju set juju-gui juju-gui-source=0.8.0 | 13:47 |
| ahasenack | gary_poster: ok, so trunk doesn't work with manage.jujucharms.com, is that it? | 13:47 |
| gary_poster | ahasenack, trunk is a bad name I'm afraid. it is the last release made on the "trunk" series | 13:48 |
| gary_poster | ahasenack, we don't release those except for tests | 13:48 |
| ahasenack | gary_poster: what about lp:juju-gui? | 13:48 |
| gary_poster | ahasenack, if you actually want to use trunk, yes: | 13:48 |
| gary_poster | juju set juju-gui juju-gui-source=lp:juju-gui | 13:48 |
| gary_poster | ahasenack, sorry for confusion. We'll clarify in docs | 13:49 |
| ahasenack | ok, np, I'll try lp:juju-gui, and then stable | 13:49 |
| gary_poster | cool thanks ahasenack. stable is what is always supposed to work fwiw. lp:juju-gui is about to have a nice fix for juju core subordinates | 13:50 |
| ahasenack | gary_poster: what I'm trying to debug is why my juju-gui deployment ("stable" last time I tried, will verify now) does not show that extra icon for subordinate charms, the one that looks like an electrocardiogram | 13:50 |
| ahasenack | oh, I wonder if that's what is happening | 13:50 |
| gary_poster | ahasenack, ok, that's a bug I have fixed in a branch that will land within an hour and be released today | 13:50 |
| ahasenack | ah, good | 13:50 |
| gary_poster | sorry, late for call, running :-) | 13:51 |
| antdillon | gary_poster, Hi, someone just pointed out there seems to be an issue viewing the readme's of some charms. Is this a known issue? | 13:55 |
| hatch_ | gary_poster: hey I'm here | 13:56 |
| === hatch_ is now known as hatch | ||
| gary_poster | antdillon, on call, but if it is that sometimes the markdown is not processed properly, yes, that typically means the markdown is broken. is that what you mean, or something else? | 14:00 |
| gary_poster | one other issue is that the markdown processor does not honor html comments | 14:00 |
| gary_poster | but that's all I know about | 14:00 |
| antdillon | gary_poster, When you are in browse mode and checking out the details of an app and click readme it loads then jumps back to the search results | 14:01 |
| gary_poster | hatch, hey. calls. take a look at http://paste.ubuntu.com/5911233/ and see if you get the gist :-) | 14:01 |
| bac | gary_poster: i see you're on another call. let me know if you want to reschedule | 14:02 |
| gary_poster | bac, no you are next call. be there very soon. | 14:02 |
| bac | ok | 14:02 |
| gary_poster | antdillon, remember seeing something like that but can't dupe. can you give step by step dupe instructions starting from jujucharms.com? | 14:03 |
| antdillon | gary_poster, Sure, go to https://jujucharms.com/ | 14:03 |
| antdillon | gary_poster, Search "cinder" | 14:04 |
| gary_poster | hatch, if you have test ideas lemme know. that was from another report of app spinning forever. they had turned off cookies. could dupe in FF | 14:04 |
| antdillon | gary_poster, Click the cinder app for more details | 14:04 |
| antdillon | gary_poster, Then click read me and it fades back to the search results | 14:04 |
| gary_poster | antdillon, got it! thank you, that's new. we'll get on it. thanks a lot! | 14:05 |
| hatch | gary_poster: ahh ok looking | 14:05 |
| antdillon | gary_poster, No probs | 14:05 |
| gary_poster | jcsackett, sinzui ^^^ see what ant reported. any chance of a quick fix in next hour? | 14:05 |
| sinzui | gary_poster, doubtful. I know that bug | 14:06 |
| sinzui | gary_poster, that is the bug I showed you when we QAed 0.8.0 for release | 14:08 |
| gary_poster | oh, another variant? | 14:08 |
| sinzui | yep | 14:08 |
| gary_poster | sinzui, ok thanks. will investigate asap | 14:09 |
| sinzui | jcsackett, do you know how to reproduce the bug where you choose a charm's readme and instead are returned to search results? | 14:09 |
| sinzui | gary_poster, jcsackett: I search for apache, choose apache, choose readme, then see search results again, and all navigation is broken. I use my back button to get back to the charm | 14:10 |
| rick_h | sinzui: gary_poster it looks like it's due to the interaction with the tab widget #bws-readme getting appended to the url which causes the url to 'appear' changed | 14:11 |
| rick_h | gary_poster: sinzui and then we're smack back into the bug I hope to fix tomorrow #1200743 | 14:11 |
| _mup_ | Bug #1200743: complex search/view interactions in fullscreen fail to work <charmbrowser> <juju-gui:Triaged> <https://launchpad.net/bugs/1200743> | 14:11 |
| sinzui | rick_h, were did you get the wifi from? | 14:12 |
| rick_h | sinzui: the dealership has wifi :) | 14:12 |
| frankban | benji: I am glad you survived the monster, thanks a lot for your review! | 14:12 |
| sinzui | I hope you are working on bookie then | 14:12 |
| rick_h | just hopped on after looking at pretty airstreams for a bit | 14:12 |
| benji | frankban: my pleasure | 14:12 |
| rick_h | sinzui: :) sure thing | 14:12 |
| hatch | gary_poster: we can normalize the set/get credentials methods to both return a value then we can clobber the window.seessionStorage property and test that they both return the desired values | 14:13 |
| jcsackett | jujugui: can I get two reviews on https://codereview.appspot.com/11831043/ ? | 14:16 |
| Makyo | jcsackett, sure. | 14:17 |
| jcsackett | thanks, Makyo. | 14:17 |
| hatch | no it | 14:17 |
| hatch | on even | 14:17 |
| teknico | frankban: I'll review your branch too, if only because your card had just one name in the tags ;-) | 14:18 |
| frankban | heh | 14:18 |
| gary_poster | hatch, window.sessionStorage does not allow clobbering on FF at least | 14:19 |
| gary_poster | rick_h, sinzui ack thanks | 14:20 |
| hatch | gary_poster: ok then we need to change how we assign sessionStorage here so that we can assign it to something else during testing `var sessionStorage = window.testSessionStorage || window.sessionStorage` | 14:22 |
| gary_poster | hatch, have a plan. day is horribly busy though. one sec, will get diff in 3 min | 14:23 |
| gary_poster | hatch, http://paste.ubuntu.com/5911344/ | 14:30 |
| hatch | looking | 14:30 |
| gary_poster | hatch, with that you can test behavior of stub, test whether the verifySessionStorage is called by the module, test verifySessionStorage itself, and even test whether module.sessionStorage is actually used by getCredentials/setCredentials | 14:31 |
| gary_poster | hatch, maybe we don't need all of that :-P but we could | 14:31 |
| hatch | haha well this is more in depth than I was thinking | 14:32 |
| hatch | but it does open up more possibilities for testing | 14:32 |
| bac | sinzui: you free to chat? | 14:32 |
| hatch | :) | 14:32 |
| benji | abentley: here's my MP: https://code.launchpad.net/~benji/charmworld/bundle-indexing/+merge/176956 | 14:42 |
| abentley | benji: looking... | 14:42 |
| hatch | rick_h: I found two incorrectly changed classes from the view-container switchover.....such a minor bug - not bad all things considered :D | 14:43 |
| hatch | jcsackett: I found svg social icons http://zurb.com/playground/social-webicons maybe we want to use those? | 14:47 |
| abentley | benji: You've got some conflicts. | 14:49 |
| benji | abentley: doh! I'll resolve and re-push. | 14:49 |
| benji | abentley: fixed and pushed | 14:52 |
| abentley | benji: Thanks! | 14:52 |
| jcsackett | hatch: they look cool, but given we only need three of the services, and only one resolution, I don't know that it's worth switching to those. | 14:54 |
| hatch | yeah maybe not :) | 14:54 |
| hatch | maybe we can use them as charms? | 14:54 |
| hatch | deploy facebook | 14:54 |
| jcsackett | but I've bookmarked them for the future. | 14:54 |
| * jcsackett laughs | 14:55 | |
| hatch | oh it's PHP, nm | 14:55 |
| jcsackett | :-p | 14:55 |
| hatch | haha | 14:55 |
| hatch | http://www.engadget.com/2013/07/25/dell-officially-unveils-precision-m3800-workstation-at-siggraph/?utm_medium=feed&utm_source=feedly | 14:59 |
| hatch | finally a MBP competitor....maybe | 14:59 |
| hatch | I just hope it doesn't only have HDMI out | 15:01 |
| sinzui | gary_poster, arosales: We are testing an alternate redirects to manage.jujucharms.com. I think we will have this sorted in production in a few hours. | 15:12 |
| sinzui | gary_poster, I have a cunning idea | 15:13 |
| arosales | sinzui, ah great to hear :-) | 15:13 |
| gary_poster | sinzui, k | 15:13 |
| sinzui | gary_poster, We rejected the redirect rule for /~user and /charmers. I think I can write a rule that appends -0 to the url, so that the gui loads the charm | 15:14 |
| sinzui | bac, do you want to talk about search and api3? | 15:18 |
| bac | sinzui: yes | 15:19 |
| bac | sinzui: orange hangout? | 15:19 |
| jcsackett | hatch: i don't mind the HDMI out, but wish there was a 13in option for that. | 15:19 |
| sinzui | yes, the standup one | 15:19 |
| * bac gets tea. one sec | 15:20 | |
| gary_poster | bac fwiw, I didn't have time to resolve CSS issue so Jeff will tackle it as part of his current inspector styling branch. benji, bac, thank you for reviews | 15:28 |
| benji | any time | 15:29 |
| hatch | oooo only one conflict | 15:30 |
| hatch | sometimes bzr impresses me | 15:30 |
| teknico | hatch: other times it represses you ;-) | 15:32 |
| hatch | gary_poster: looks like my branch preemptively fixed the x bug | 15:34 |
| gary_poster | hatch lol cool | 15:34 |
| frankban | bcsaller: I already have two reviews for my branch, I'll be happy to wait for yours if you want to | 15:45 |
| bcsaller | frankban: no need, it looked good, the test were just having strange issues for me | 15:45 |
| frankban | bcsaller: cool, thanks | 15:46 |
| hatch | jcsackett: I hope it's a 15" and not a 17" :) but I need something better than HDMI because my monitor is 2560x1600 | 15:46 |
| hatch | Makyo: you didn't put the time your landing in LHR on the spreadsheet :) | 15:49 |
| gary_poster | jujugui call in 8; kanban now | 15:52 |
| Makyo | hatch, alright, will do. Was just going to take the train, figured it didn't matter much. | 15:54 |
| teknico | hatch: look at the keyboard, no numeric keypad, can't be a 17" | 15:54 |
| hatch | teknico: oh is that the sign? | 15:55 |
| teknico | hatch: I mean, the keyboard would be larger and include a keypad if it were a 17" | 15:55 |
| hatch | yeah I suppose | 15:55 |
| teknico | unless they went for giant keys :-) | 15:56 |
| hatch | lol | 15:56 |
| jcsackett | hatch: in the article linked within the engadget article, they say it's a 15. | 15:57 |
| hatch | ohh ok | 15:57 |
| hatch | http://www.dell.com/learn/us/en/04/campaigns/precision-m3800-workstation?c=us&l=en&s=bsd | 15:58 |
| hatch | it shows the sides of the machine but I can't tell what the ports are haha | 15:58 |
| Makyo | jujugui call in 2 | 15:58 |
| gary_poster | :-) thx | 15:59 |
| gary_poster | bcsaller call | 16:01 |
| bcsaller | just finishing up coffee | 16:01 |
| jcsackett | freaking google plus ... | 16:02 |
| hatch | yeah free stuff.....damn them!! | 16:02 |
| sinzui | abentley, I have a zany idea to support old charm urls pointing to jujucharms.com | 16:07 |
| jcsackett | hatch: it's not free. i'm giving them all my data. :-P | 16:08 |
| hatch | lol | 16:08 |
| abentley | sinzui: Oh? | 16:08 |
| sinzui | I can add a rewrite rule that matches the /~ or /charms and append -0 or -HEAD to it so that juju-gui sees a URL it can load | 16:09 |
| bac | benji: can you paste your review url so i can ensure we're not overlapping? | 16:09 |
| sinzui | abentley, do you have any idea regarding how to ask for the tip of a charm? | 16:09 |
| benji | bac: https://code.launchpad.net/~benji/charmworld/bundle-indexing/+merge/176956 | 16:10 |
| bac | thx | 16:10 |
| abentley | sinzui: In code, or via URLs? | 16:10 |
| bac | benji: yep, that's some of what i was going to do | 16:11 |
| benji | bac: heh, I'm glad we didn't duplicate work | 16:11 |
| bac | we were trying to decide on what to call superset(charms, bundles). i see you picked items | 16:11 |
| sinzui | abentley, in URLs. gui only knows how to handle versioned charms, and passes that to charmworld to get information. | 16:11 |
| benji | I can't say I put a lot of thought into "items". | 16:12 |
| sinzui | abentley, A rewrite rule that adds a version makes the old URLs work (me just tested this). I don't think we want to pass a real version. | 16:14 |
| abentley | sinzui: once we support versioning, I don't think we have URLs for tip. We could add them. bzr uses -1 for tip, but that would give /api3/charm/~foo/bar/baz--1 | 16:14 |
| sinzui | yep | 16:14 |
| sinzui | I imagined that | 16:14 |
| frankban | gary_poster: holiday filed | 16:14 |
| bac | benji, i'm going to lunch nowish. when do you get back from yours? | 16:15 |
| benji | bac: lunch now sounds good; I'll do the same | 16:15 |
| bac | fried chicken? | 16:15 |
| sinzui | abentley, this is just to support historic URLs. I don't think we want to suggest that users always make versionless links to charms | 16:15 |
| gary_poster | frankban, thanks, approved | 16:16 |
| * sinzui ponders though that the charm details view needs to state that there are newer revisions | 16:16 | |
| frankban | thanks | 16:16 |
| abentley | sinzui: We could provide a route that redirects to tip-- /tips/~foo/bar/baz or something could redirect to /~foo/bar/baz-$LATEST | 16:17 |
| sinzui | abentley, this is hacked URL allows askubuntu users to see the charm: https://jujucharms.com/~christophe.sauthier/precise/zentyal-HEAD | 16:17 |
| sinzui | abentley, to be clear, this is about juju gui showing the charm. It needs a version component, and this hack works because charmworld currently shows tip for ever version | 16:18 |
| sinzui | every | 16:18 |
| abentley | sinzui: Right. | 16:18 |
| sinzui | abentley, this does work: https://jujucharms.com/~christophe.sauthier/precise/zentyal-$latest | 16:19 |
| abentley | sinzui: so does this: https://jujucharms.com/~christophe.sauthier/precise/zentyal-moo/ | 16:19 |
| sinzui | yep | 16:19 |
| sinzui | If we guarantee that a token in the revision permission always returns tip, I can fix all the cahrm redirects today | 16:21 |
| sinzui | ^ abentley do you have a preferred token to mean tip? | 16:21 |
| abentley | sinzui: HEAD or TIP are my faves. | 16:22 |
| sinzui | I will use HEAD since it came up in another conversation today | 16:23 |
| teknico | hatch: btw, that notebook's display size is noted in the specs below the text, and it's 15.6" | 16:36 |
| hatch | looking for reviews https://codereview.appspot.com/11843043/ | 16:37 |
| hatch | teknico: ahh ok | 16:37 |
| gary_poster | sinzui, you saw email from jcastro? | 16:42 |
| sinzui | check your email for my reply | 16:43 |
| hazmat | gary_poster, sorry had messed up config on nginx for comingsoon, it should be working now | 16:44 |
| gary_poster | thanks hazmat! looks good on quick fly by | 16:44 |
| hatch | bcsaller: review done | 16:49 |
| hatch | jujugui lf reviews https://codereview.appspot.com/11843043/ | 16:54 |
| * gary_poster would but trying to get test passing for deployment. will look soon if no one else has | 16:55 | |
| gotwig | howdy | 17:02 |
| gotwig | the "view" page for already deployed, running charms is not nice :(! | 17:02 |
| gary_poster | gotwig, I think we know and are working on it, but just to be clear, could you give us details? screenshot might help. To give you an idea of what we will release soon, we will make an inspector that you can see from the environment view itself | 17:06 |
| gary_poster | I can give you preview if you'd like | 17:06 |
| gotwig | yeah | 17:07 |
| gotwig | please | 17:07 |
| gotwig | I like this widget like view | 17:08 |
| gotwig | for getting a quick overview of charms that you wanna add | 17:08 |
| gotwig | or the initial charm setup widget thing at the right, is superb | 17:08 |
| gotwig | but after its deployed, setting it up or configuring it is such a huge mess | 17:08 |
| gary_poster | gotwig, understanding that this has lots of work needed still, incuding styling, which is why we are not releasing it and working on it, go to http://comingsoon.jujucharms.com/:flags:/serviceInspector/ | 17:09 |
| gotwig_ | howdy.. sry, one notebook batery died | 17:09 |
| jcsackett | jujugui: can i get reviews on https://codereview.appspot.com/11845043 please? | 17:09 |
| gotwig_ | so much custom styles :/ | 17:09 |
| gary_poster | gotwig, deploy something (clunky) and then click on service again (less clunky) | 17:09 |
| gotwig_ | gary_poster: yip | 17:10 |
| hatch | the clunky ness of the deploy something (clunky) will be better soon too :) | 17:10 |
| gary_poster | :-) | 17:10 |
| gotwig_ | hatch: dont use soo much custom styles ;P | 17:10 |
| hatch | jcsackett: I'll swap you a review for my review? | 17:10 |
| gary_poster | gotwig, what do you mean? | 17:10 |
| jcsackett | hatch: if you mean the one you posted above, i've already looked at yours. :-) | 17:11 |
| gotwig_ | right now the styling is different all the time | 17:11 |
| gotwig_ | there should be some sort of consistecy | 17:11 |
| gotwig_ | like in the overview page for exploring charms | 17:11 |
| hatch | jcsackett: darn....lol ok I'll do yours | 17:11 |
| jcsackett | hatch: thanks. :-) | 17:12 |
| hatch | gotwig_: yes it is moving towards a consistent style across the whole application | 17:12 |
| gotwig_ | but still, juju is now nice enough for me to dig some time into ;X | 17:12 |
| gary_poster | gotwig, cool :-) | 17:12 |
| hatch | :) | 17:12 |
| gotwig_ | I think about doing a meteorJS charm | 17:12 |
| jcsackett | gotwig_: i would like to see that. :-) | 17:13 |
| gotwig_ | realtime javascript framework, very similar to nodeJS | 17:13 |
| gotwig_ | it uses a lot of handlebar design patters, more info on #meteorJS | 17:13 |
| hatch | gotwig_: did you see about the charm competition? | 17:13 |
| gotwig_ | *patterns | 17:13 |
| gotwig_ | hatch: haha, I am a student xD | 17:13 |
| gotwig_ | I am not a pro in all this, this is very complex to me | 17:13 |
| hatch | https://github.com/juju/charm-championship | 17:14 |
| hatch | hey everyone has to start somewhere :) | 17:14 |
| gary_poster | gotwig_, as to styles, ack. we are releasing incrementally, which is part of what you are seeing. we think it is better to release good stuff with some style issues gradually. also inspector should make what you describe better--we will get rid of all internal pages then. | 17:14 |
| gary_poster | gotwig_, charm sounds great. ought to try championship anyway. :-) | 17:14 |
| gotwig_ | IMHO this is better suited for some ultra smart cloud developers ;X | 17:15 |
| gotwig_ | thats too much money ;D | 17:15 |
| gary_poster | heh | 17:15 |
| gary_poster | ok | 17:15 |
| hatch | that could be your too much money :) | 17:16 |
| gotwig_ | I still am going to work on JuJu, it looks like fun | 17:16 |
| gary_poster | well, meteorJS sounds like a great charm anyway | 17:16 |
| gary_poster | great | 17:16 |
| gotwig_ | I already worked with lenses and scopes in the past, trough that stuff I got my Ubuntu Membership in one week :> | 17:16 |
| gotwig_ | I know this is a whole other category here ;D | 17:16 |
| benji | bac: I'm ready to coordinate when you are. | 17:16 |
| hatch | gotwig_: that's great :) | 17:17 |
| gotwig_ | you guys are so nice :D | 17:17 |
| gary_poster | we like making users happy, if we can :-) | 17:17 |
| hatch | you just caught us between sprints | 17:17 |
| gary_poster | lol | 17:17 |
| hatch | :P | 17:17 |
| gary_poster | bcsaller, "databings"? :-) | 17:20 |
| gary_poster | that's not detailed :-) , but we are releasing incrementally. when inspector is ready we will get rid of all of internal bits | 17:20 |
| gary_poster | last sentence should have been... | 17:20 |
| gary_poster | Databings clean ups + wildcard support | 17:20 |
| gary_poster | This branch adds support for wildcards to databings, it | 17:20 |
| bcsaller | hey, it was late | 17:20 |
| gary_poster | lol | 17:20 |
| gotwig_ | do you think about responsive webdesign? | 17:20 |
| gotwig_ | does ubuntu.com have resposive webdesign? | 17:20 |
| hatch | jcsackett: review done | 17:21 |
| gary_poster | gotwig_, yes we think about it, but we don't have it; IIRC yes, ubuntu.com has it or will soon | 17:21 |
| gotwig_ | gary_poster: are you part of Canonical? | 17:21 |
| gary_poster | gotwig_, yes | 17:21 |
| gotwig_ | gary_poster: :O | 17:21 |
| gotwig_ | nowadays you guys are everywhere | 17:22 |
| gary_poster | heh | 17:22 |
| gotwig_ | even following me on Google + ;P | 17:22 |
| gotwig_ | lol | 17:22 |
| gary_poster | mwa ha ha ha? | 17:22 |
| gotwig_ | I sort of know michael hall good.. he woks on Unity | 17:23 |
| gary_poster | cool, yeah | 17:23 |
| gotwig_ | *works | 17:23 |
| gotwig_ | sorry, my notebook keyboard is sort of lame | 17:23 |
| gotwig_ | Its a shame my Zenbook from ASUS broke, due to UEFI | 17:23 |
| gotwig_ | the UEFI destroyed the BIOS chip, and with that the whole motherboard :/ | 17:24 |
| gotwig_ | I just bought it 3 months ago :X | 17:24 |
| gary_poster | yuck :-/ | 17:24 |
| gary_poster | jujugui https://codereview.appspot.com/11849043 | 17:24 |
| gotwig_ | UEFI is such a mess | 17:24 |
| Makyo | On it. | 17:24 |
| Makyo | gary_poster, ^^^ | 17:24 |
| gary_poster | hatch I'll look at yours now unless you already have two? | 17:24 |
| gary_poster | thanks Makyo ! | 17:24 |
| hatch | gary_poster: nope only have one | 17:26 |
| gary_poster | hatch ok on it | 17:26 |
| hatch | thanks | 17:26 |
| gary_poster | we really need to relook at the CSS rule generation flags in the makefile :-/ | 17:29 |
| gary_poster | make clean && make devel again | 17:29 |
| jcsackett | hatch: when a test case finishes everything declared inside it should be destroyed right? assuming they weren't globally declared. | 17:29 |
| hatch | jcsackett: well a view renders a container and attaches events | 17:29 |
| hatch | if the destructor is never called those will linger | 17:30 |
| jcsackett | hatch: what i'm asking is isn't the desctructor called as view falls out of scope then the 'it' block finishes? | 17:30 |
| bcsaller | gary_poster: that session storage pretends to work, but doesn't in the case we use it for, a reload, right? Our code only expects to find the value in SS so we force it down that path then? | 17:31 |
| gary_poster | hatch I cleaned build and cache and I'm getting something that doesn't look like what I expect you wanted :-) . I merged your branch into trunk fwiw. http://ubuntuone.com/34o3fKV6ESZt2KorbYbdoD | 17:32 |
| hatch | jcsackett: nope the destructor is purely a framework construct not part of the language | 17:32 |
| gary_poster | is that right? | 17:32 |
| hatch | woah | 17:32 |
| hatch | no thats definitely wrong | 17:32 |
| hatch | I'll merge again see what's up | 17:32 |
| gary_poster | bcsaller, right, if they have cookies and session storage turned off, they will have to log in again | 17:33 |
| bcsaller | yeah, the larger flaw is that SS isn't optional, but this quickly masks it | 17:33 |
| hatch | gary_poster: can you clear your cache - I can't repro | 17:34 |
| gary_poster | hatch, I did for the day. doing again for the week... | 17:34 |
| gary_poster | hatch I get the same | 17:35 |
| gary_poster | bcsaller, yeah. I figured it was ok, since I figure these users will be small percentage of base, and it only really bites them in the Landscape scenario | 17:35 |
| gary_poster | hatch, wanna hangout so you can show me the error of my ways? :-) | 17:36 |
| gary_poster | oh meh | 17:36 |
| hatch | did it fix? | 17:37 |
| gary_poster | hatch no, but I need to get this landed, have a call with ben, have lunch, and start the release process all in the past seven minutes ;-) | 17:37 |
| gary_poster | this meaning my cookie branch | 17:37 |
| hatch | ok I can repro in ubuntu chrome | 17:38 |
| hatch | hmm | 17:38 |
| hatch | good catch! | 17:38 |
| gary_poster | :-) sorry there's more work but glad you could repro | 17:38 |
| andreas__ | gary_poster: bug about juju-core subordinate charms in juju-gui confirmed fixed, I see the extra subordinate icon in the UI now | 17:39 |
| === andreas__ is now known as ahasenack | ||
| bac | oh, sorry benji, didn't see your message | 17:40 |
| hatch | there is a massive font-size difference between osx and ubuntu chrome | 17:48 |
| hatch | in the inspector | 17:48 |
| benji | bac: let me know when you want to chat | 17:50 |
| gotwig_ | how long do I have to wait for the eye candy :>? | 17:50 |
| gotwig_ | (to be ready) | 17:50 |
| benji | gotwig_: the GUI is usable now, if that's what you're asking | 17:51 |
| gotwig_ | benji: the new gui :> | 17:51 |
| benji | gotwig_: we did a release last week; is that new enough for you? ;) | 17:52 |
| gotwig_ | benji: you know, the charm view after you already deployed the charm, to configuer stuff, sucks :> IMHO. I cant save changes? | 17:53 |
| gotwig_ | benji: I go into the deployed charm click on settings or something like this, and e.g try to change the port. how can I save these changes? | 17:53 |
| hatch | gotwig_: are you using any flags? | 17:54 |
| gotwig_ | I am from Germany , no xD | 17:54 |
| gotwig_ | I use a standard setup | 17:54 |
| benji | ah; that new view is not quite ready. It is getting closer though. You can get a sneak peak by inserting /:flags:/serviceInspector/ in the URL | 17:54 |
| hatch | benji: I think he is referring to the unflagged settings page where the scroll bar is broken | 17:54 |
| hatch | I thought that was fixed | 17:54 |
| gotwig_ | yeah | 17:54 |
| gotwig_ | the scroll bar is broken.. | 17:55 |
| benji | that is fixed on trunk, but I don't know if there has been a release that includes the fix | 17:55 |
| hatch | comingsoon still shows the issue | 17:55 |
| hatch | but the charm page is fixed | 17:55 |
| hatch | so maybe we missed the settings page | 17:55 |
| hatch | ^ gary_poster were you the one on that? | 17:55 |
| gary_poster | ahasenack, fantastic! thanks for checking and following up | 17:55 |
| hatch | sorry to interrupt your busy day :) | 17:55 |
| gary_poster | hatch yeah I fixed charm page | 17:56 |
| gotwig_ | yeah, I like Fun with Flags .D | 17:56 |
| gary_poster | did not notice settings page | 17:56 |
| hatch | gotwig_: haha BBT quote! | 17:56 |
| gotwig_ | yup | 17:57 |
| gotwig_ | (Ich bin ein Bavarian..) (Und ich bin eine Brezel) :D | 17:57 |
| gary_poster | :-) | 17:57 |
| gotwig_ | mothe calls me ;X g2g | 17:58 |
| gotwig_ | *mother | 17:58 |
| gotwig_ | btw. are you part of Canonicals design team? | 17:58 |
| gary_poster | no, we work with them | 17:58 |
| gotwig_ | because I like your blog... | 17:58 |
| gotwig_ | oh :X | 17:58 |
| hatch | gary_poster: proposing the fix for the bug you found | 17:58 |
| gary_poster | thx :-) ttyl | 17:58 |
| gary_poster | hatch great | 17:59 |
| hatch | gary_poster: it appears that chrome on ubuntu renders input boxes and html entities at a different font size? | 17:59 |
| hatch | very odd | 17:59 |
| bac | benji, chat? | 18:02 |
| benji | bac: I'll head over there. | 18:03 |
| hatch | gary_poster: ok fix up - let me know if its fixed when you have a moment....heh | 18:03 |
| hatch | jcsackett: that change caused the tests to fail? Did it fail in the browser too? | 18:09 |
| gary_poster | hatch on it | 18:16 |
| gary_poster | hatch if you can fix settings page really quickly that would be awesome. :-P code should already be there IIRC, so something going wrong | 18:18 |
| hatch | gary_poster: yeah I can add the fix into this branch | 18:19 |
| gary_poster | awesoem thanks | 18:20 |
| gary_poster | hatch fix looks great thx :-) | 18:20 |
| jcsackett | hatch: didn't check. reverted it and pushed up the test cleanup. | 18:24 |
| hatch | oh u suck | 18:24 |
| hatch | :P | 18:25 |
| jcsackett | hatch: i suck? that's a little harsh. :-P | 18:25 |
| hatch | gary_poster: can you lgtm? I'll be submitting with the one liner to fix the settings page too | 18:25 |
| jcsackett | jujugui: can i get one more review on https://codereview.appspot.com/11845043/ | 18:25 |
| hatch | jcsackett: haha | 18:25 |
| gary_poster | hatch, one bug, getting you a patch | 18:25 |
| hatch | oh ok | 18:25 |
| gary_poster | hatch see http://paste.ubuntu.com/5912043/ , only app/templates/ghost-config-viewlet.handlebars and app/views/environment.js | 18:31 |
| gary_poster | hatch also another bug for a card, because it is too big: | 18:31 |
| gary_poster | there are two cancel/confirm buttons now | 18:31 |
| gary_poster | one static at bottom | 18:32 |
| gary_poster | the other in scroll area | 18:32 |
| gary_poster | the one from scroll area is the one that the config view uses | 18:32 |
| gary_poster | so removing not trivial | 18:32 |
| hatch | ohh it's snake cased...I just pulled that from the trunk merge | 18:32 |
| gary_poster | so I suggest you stick with this as incremental | 18:32 |
| gary_poster | hatch no other way | 18:32 |
| gary_poster | hatch, the isSubordinate thing was something I added | 18:33 |
| gary_poster | it used to be used in the -wrapper | 18:33 |
| gary_poster | now that section is in the -viewlet | 18:33 |
| gary_poster | where the pre-existing value is already named is_subordinate | 18:34 |
| gary_poster | so rip out the isSubordinate from the top section because we no longer use it there | 18:34 |
| hatch | if we do that then the number of units input box shows up | 18:34 |
| gary_poster | and use is_subordinate in the -viewlet because that's what it is called there (rpobably because of getAttrs call) | 18:34 |
| hatch | ohh ok | 18:35 |
| gary_poster | hatch, no it was showing up in your branch without my fix | 18:35 |
| gary_poster | hatch, this hides it again | 18:35 |
| hatch | ok so just to be clear https://codereview.appspot.com/11843043/diff/7001/app/templates/ghost-config-viewlet.handlebars isSubordinate should be is_subordinate | 18:35 |
| hatch | You'll see that the wrapper no longer has that https://codereview.appspot.com/11843043/diff/7001/app/templates/ghost-config-wrapper.handlebars | 18:38 |
| gary_poster | hatch just gave you specifics in LGTM review. Agreed that the wrapper doesn't have it, but you also need to remove the now-unused definition in environment.js | 18:39 |
| hatch | gotcha | 18:39 |
| gary_poster | and we are in a bad way with tests :-( | 18:39 |
| gary_poster | hatch, after you land that could you start release/qa process? if you would like qa help from anyone in jujugui (notice what I did there!) please ask 'em | 18:40 |
| hatch | sounds good | 18:41 |
| gary_poster | than kyou hatch | 18:41 |
| hatch | gary_poster: 0.8.1 ? | 18:43 |
| gary_poster | hatch hard call but yes | 18:43 |
| hatch | I don't think we have any 'features' landing | 18:44 |
| gary_poster | hatch not really. barely. :-) | 18:45 |
| hatch | heh - I found a bug in the header styling - if you deploy a service with a long cs:..... url it blows it all up | 18:45 |
| hatch | will also fix that | 18:46 |
| gary_poster | cool thank you | 18:46 |
| hatch | for the moment I'll just make it wrap | 18:47 |
| hatch | well.....elipsis looks a lot better | 18:48 |
| hatch | does anyone know what's a commonly used subordinate? | 18:52 |
| gary_poster | hatch, puppet | 18:56 |
| hatch | hmm this search is broken | 18:58 |
| hatch | will have to try and make a repro | 18:59 |
| abentley | sinzui: chat? | 19:04 |
| hatch | jcsackett: is it known that the browser search box doesn't do fuzzy querys? when I search for 'rabbit' I don't get 'rabbitmq' | 19:04 |
| sinzui | abentley, you is psychic | 19:04 |
| sinzui | yes | 19:04 |
| hatch | gary_poster: what did you mean we are in a bad way with tests? Are some failing? | 19:20 |
| gary_poster | hatch on call, but simply an absence of tests for ghosts | 19:20 |
| hatch | and more curious....why haven't we gotten a failing CI email in a while? did that get turned off? | 19:20 |
| hatch | ohh right | 19:20 |
| hatch | jujugui is there anyone who has any bug fixes they want to get into the 0.8.1 release before I start? | 19:29 |
| Makyo | hatch, I say go ahead, so we don't have to QA new things super quick and potentially miss anything. | 19:29 |
| hatch | yeah I was only going to grab the bug fixes :) | 19:30 |
| hatch | going once, twice......sold! | 19:30 |
| Makyo | hatch, I just want to say. | 19:31 |
| Makyo | Good luck. We're all counting on you. | 19:31 |
| hatch | are you? | 19:31 |
| hatch | is this like some epic quest, one release to rule them all? | 19:31 |
| Makyo | ...no. | 19:32 |
| Makyo | Good luck all the same :D | 19:32 |
| Makyo | Let me know if you want me QAing anythign. | 19:32 |
| jcsackett | hatch: looks api doesn't support fuzzy; we'll look into that. but not a problem on the jujugui code side. | 19:34 |
| hatch | yeah I figured as much | 19:39 |
| gary_poster | hatch I how is it going? | 19:57 |
| gary_poster | s/I// ;-) | 19:57 |
| hatch | good just qaing while lunch is cookin | 19:58 |
| hatch | no unknown bugs so far | 19:59 |
| gary_poster | great hatch thanks | 19:59 |
| gary_poster | hey bcsaller, please don't put docs off for databinding past the hook up with conflict res ux. both reviewers asked for 'em which felt like a pretty compelling request | 20:00 |
| * gary_poster steps away for a few | 20:01 | |
| gary_poster | bcsaller, that was not clear: I was trying to say, I was ok with your stated plan, but nervous that it might not be actually followed (that the docs might not actually be produced soon). | 20:02 |
| bcsaller | gary_poster: I only mean the context in which you use the wildcards is going to be more clear after the next branch it its worth documenting 'that' rather than the lower level wiring which as they noted is a little spare by itself | 20:03 |
| hatch | man the GUI looks awesome with all these icons | 20:03 |
| hatch | annnnd of course I spoke to soon | 20:04 |
| hatch | found a bug :/ | 20:04 |
| hatch | jujugui the settings page (unflagged) on rapi shows no settings, any ideas before I investigate? | 20:10 |
| Makyo | I see settings. | 20:11 |
| Makyo | Oh, rapi, just a sec. | 20:11 |
| hatch | charm.get('options') is undefined | 20:12 |
| hatch | but only on rapi..... | 20:12 |
| hatch | service.js:539 | 20:13 |
| Makyo | hatch, confirmed | 20:13 |
| hatch | I wonder if this is some odd side effect to the work jcsackett was doing | 20:13 |
| hatch | charm.getAttrs() shows an almost entirely empy charm model | 20:14 |
| hatch | so it's not pulling in the extra data any longer.... | 20:14 |
| Makyo | It's pulling the data, but not storing it, looking at ws frames | 20:16 |
| Makyo | Or not storing it properly. | 20:16 |
| Makyo | jujugui ^^^ Ideas? | 20:16 |
| gary_poster | Makyo, hatch, I'm going to take another 30 min but will look after that if it is still an issue | 20:19 |
| hatch | sure I gota run and eat my fooods soon heh | 20:19 |
| hatch | trying one thing first | 20:19 |
| gary_poster | :-) k | 20:19 |
| hatch | Makyo: in model-controller.js getCharm() is where I am at | 20:21 |
| hatch | seeing if the promse is returing properly | 20:21 |
| Makyo | Okay | 20:21 |
| jcsackett | hatch: i am looking now. i don't recall touching model-controller in anything that's landed, but my memory has been faulty before. | 20:21 |
| hatch | Makyo: jcsackett the promise is returning, but the load call is not returning the proper data | 20:22 |
| jcsackett | hatch: you mean charm.load? | 20:22 |
| hatch | you can see this by putting a debugger statement on line 89 of model-controller.js and executing db.charms.getById(charmId).getAttrs() | 20:23 |
| hatch | lots of undefineds | 20:23 |
| hatch | I gota go eat, but that's where I ended up - so next step would be to see why the load is failing | 20:23 |
| hatch | brb | 20:23 |
| jcsackett | hatch: if you haven't already left, what path in the app do i go through to trigger? | 20:24 |
| Makyo | jcsackett, http://localhost:8888/:gui:/service/mediawiki/config/#/:gui:/service/mediawiki/config/ ish | 20:25 |
| jcsackett | Makyo: thanks. | 20:26 |
| Makyo | jcsackett, Double click on a service, click on settings | 20:26 |
| Makyo | But only in a non-sandbox, it seems like. | 20:26 |
| jcsackett | Makyo: yeah. given this is occurs with environment, and appears to be a load/promise issue, i'm betting charm.sync is somehow to blame. | 20:34 |
| Makyo | jcsackett, Alright, will start poking around /cc hatch | 20:34 |
| jcsackett | Makyo: when you're running in rapi, do you get the canvas to populate at all? just going to "/"? | 20:35 |
| jcsackett | i'm getting the spinny circle of sad. | 20:35 |
| Makyo | jcsackett, YEah. | 20:35 |
| Makyo | jcsackett, I get that before the websocket has started with rapi | 20:36 |
| jcsackett | yeah, restarting my devel resolved it. thanks. | 20:37 |
| abentley | orangesquad, benji or bac, could you please review https://code.launchpad.net/~abentley/charmworld/versioned-ids/+merge/177039 | 20:41 |
| bac | abentley: sure | 20:42 |
| abentley | bac: Thanks, just don't mark the status approved, because it needs follow-ons before it can land. | 20:42 |
| bac | ok | 20:43 |
| jcsackett | Makyo: what's the schema that should be in use for querying from an environment? | 20:49 |
| Makyo | jcsackett, digging, it's a getCharm call somewhere. | 20:50 |
| Makyo | Haven't worked with this since the promises. | 20:51 |
| benji | abentley: I addressed your review of https://code.launchpad.net/~benji/charmworld/bundle-indexing/+merge/176956 and I think it's ready to land. Please approve if you concur. | 20:52 |
| * gary_poster back reading backlog | 21:06 | |
| Makyo | Something is happening to the config attr of the received json in app/models/charm.js, parse(), line 180 | 21:06 |
| hatch | back | 21:06 |
| hatch | looking there | 21:07 |
| gary_poster | Makyo, ok, I'll start things... | 21:07 |
| hatch | Makyo: that parse method is never being called | 21:09 |
| Makyo | It's being called for me, once per charm. | 21:09 |
| Makyo | once per service, sorry. | 21:09 |
| Makyo | On load, not on clicking config. | 21:09 |
| hatch | wait nm cache issue | 21:09 |
| hatch | Makyo: ahh yes that loop is stripping out all the data | 21:10 |
| hatch | but only for rapi.... | 21:10 |
| Makyo | Haven't tried it outside of rapi. | 21:10 |
| hatch | Makyo: it works properly on sandbox | 21:11 |
| hatch | so we aren't duplicating work here....did you want me to take over? or do you want to continue? | 21:12 |
| Makyo | hatch, That's as far as I got. Up to you. | 21:14 |
| hatch | ok I can take over | 21:14 |
| gary_poster | self.attrAdded is the problem, yeah? | 21:14 |
| hatch | thanks for taking over while I ate :) | 21:14 |
| Makyo | gary_poster, kind of looks like. Maybe the difference between config.options and the attr options? | 21:15 |
| gary_poster | yeah maybe so | 21:16 |
| gary_poster | the reason why we don't see it on sandbox | 21:16 |
| gary_poster | is that sandbox always starts with charms populated from store | 21:16 |
| gary_poster | these are charms populated from environment | 21:16 |
| Makyo | Yeah, that sounds like it might be at least part of it? Not sure when that line came up | 21:17 |
| hatch | yeah looks like it's attrAdded | 21:19 |
| hatch | anyone remember why we need that? | 21:19 |
| gary_poster | hatch, config was changed to options. I think we need to either special case 'config' in this loop or add it to ATTRS | 21:20 |
| hatch | adding to attrs it is | 21:20 |
| gary_poster | hatch, not convinced... | 21:20 |
| gary_poster | hatch you want to hang out? | 21:22 |
| hatch | yeah that didn't fix it | 21:22 |
| hatch | sure | 21:22 |
| jcsackett | gary_poster: if Charm recieves a "config" in its cfg, it will pull options out of it; so that being passed differently shouldn't be the issue. | 21:25 |
| gary_poster | jcsackett, not in parse | 21:25 |
| gary_poster | Hey Makyo, do you have a healthy Juju Core hanging around? | 21:31 |
| jcsackett | gary_poster: ah....well, shit. i can see where it needs to be changed, assuming you don't have a fix. | 21:33 |
| hatch | jcsackett: yup fixed | 21:33 |
| gary_poster | jcsackett, http://paste.ubuntu.com/5912662/ | 21:34 |
| Makyo | gary_poster, yes, just a sec. | 21:34 |
| gary_poster | Makyo, awesome | 21:34 |
| gary_poster | thank you | 21:34 |
| jcsackett | gary_poster: yup. same thought. | 21:35 |
| jcsackett | sorry for missing that in the original branch. | 21:35 |
| Makyo | didn't upload tools, be about two or three minutes. | 21:35 |
| gary_poster | jcsackett, np. we should probably qa with improv | 21:35 |
| gary_poster | cool thanks Makyo | 21:35 |
| jcsackett | gary_poster: agreed. | 21:35 |
| Makyo | gary_poster, wss://ec2-54-234-123-238.compute-1.amazonaws.com/ws | 21:39 |
| Makyo | dbf1302885039d04aafb7502b40fcf51 | 21:40 |
| gary_poster | awesome thanks Makyo. Would you be willing to juju set juju-gui juju-gui-source=lp:~gary/juju-gui/fix-0.8.1 and then qa this issue, subordinates, and other random good qa? | 21:42 |
| gary_poster | hatch lp:~gary/juju-gui/fix-0.8.1 | 21:42 |
| Makyo | gary_poster, +1 | 22:08 |
| Makyo | (screwed up the set, sorry. | 22:08 |
| Makyo | )_ | 22:08 |
| hatch | Makyo: so it's all good? | 22:09 |
| Makyo | Seems good with core, yeah | 22:12 |
| Makyo | https://ec2-54-234-144-212.compute-1.amazonaws.com/:gui:/service/juju-gui/config/ | 22:12 |
| Makyo | Gah, sorry. | 22:13 |
| hatch | proposing the fix w/ tests | 22:13 |
| hatch | jujugui can I get two quick reviews plz https://codereview.appspot.com/11877043/ | 22:17 |
| Makyo | On it | 22:17 |
| bcsaller | on it | 22:17 |
| hatch | thanks | 22:17 |
| hatch | looks like it's chunk missmatching | 22:17 |
| Makyo | Getting chu-yeah. CAn review from MP | 22:17 |
| hatch | lol | 22:18 |
| Makyo | LGTM | 22:18 |
| hatch | thanks | 22:18 |
| hatch | DroidEdit Pro just updated on my tablet - added GIT support.....oooo | 22:19 |
| ahasenack | hi guys, the navigation in the new jujucharms.com site is a bit broken, I think someone said something about it earlier today | 22:19 |
| ahasenack | is there a fix in sight? | 22:19 |
| ahasenack | tried with both chrome and firefox | 22:19 |
| ahasenack | firefox "lasts" longer in the site, but eventually breaks too | 22:20 |
| ahasenack | for example | 22:20 |
| ahasenack | search for nfs | 22:20 |
| ahasenack | click on it | 22:20 |
| ahasenack | then click on "interfaces" | 22:20 |
| ahasenack | it takes you back to the search results, and then clicks don't work anymore basically | 22:20 |
| hatch | ahasenack: as far as I understand we know about it and I think a fix is under development | 22:21 |
| ahasenack | ok | 22:21 |
| hatch | if not in the release (that I'm doing right now) | 22:21 |
| hatch | you can see on comingsoon.jujucharms.com if it's fixed | 22:21 |
| hatch | Makyo: bcsaller thanks for the reviews | 22:23 |
| hatch | submitting | 22:23 |
| huwshimi | Morning | 22:25 |
| hatch | ahoy | 22:25 |
| ahasenack | hatch: doesn't look fixed there | 22:25 |
| ahasenack | click on browse, search for nfs, click on result, click on interface, back to search result | 22:25 |
| hatch | ok trying now | 22:25 |
| ahasenack | this on chrome | 22:25 |
| ahasenack | chrome 28.0.1500.71-r209842 in my case | 22:26 |
| hatch | hmm | 22:26 |
| ahasenack | I could try an incognito window | 22:26 |
| hatch | fullscreen browser mode right? | 22:26 |
| ahasenack | no, same thing | 22:26 |
| ahasenack | hatch: well, fullscreen/ gets appended to the url at some point | 22:26 |
| hatch | ahh there we go | 22:26 |
| ahasenack | yeah, when you click on "browse" on the top left | 22:27 |
| hatch | ok yeah I believe the guys were working on that but doesn't look like it's making it into todays release | 22:27 |
| ahasenack | is the old charm browser available somewhere? | 22:27 |
| hatch | I don't believe so | 22:29 |
| hatch | I'm just taking a look at the bug right now, see if it's something I can fix quickly | 22:29 |
| ahasenack | hatch: do you have a number? | 22:32 |
| hatch | the ticket number? no haven't looked it up | 22:32 |
| gary_poster | ahasenack, we are aware of this. someone is slated to work on it tomorrow. I'm told it is tricky, with an easy layer over a hard layer. | 22:33 |
| gary_poster | ahasenack, we will have a fix next week | 22:33 |
| gary_poster | ahasenack, and yes, the old site is manage.jujucharms.com | 22:33 |
| hatch | ohh woops | 22:33 |
| gary_poster | huwshimi, coming | 22:33 |
| hatch | *the more you know | 22:34 |
| hatch | :) | 22:34 |
| huwshimi | gary_poster: OK :) | 22:34 |
| ahasenack | gary_poster: ah, phew, I can look the interfaces up there then, thanks | 22:34 |
| === _mup__ is now known as _mup_ | ||
| hatch | I might have a fix for this but yeah I don't think I can get it resolved and write tests and get the release out tonight :) | 22:34 |
| gary_poster | hatch, could you file a bug for that variation | 22:35 |
| hatch | certainly | 22:35 |
| gary_poster | bcsaller, Makyo hatch call now in jujugui with huwshimi | 22:35 |
| hatch | coming | 22:35 |
| Makyo | Shoot, sorry, coming | 22:35 |
| hatch | huwshimi: put the times your landing in London in the spreadsheet plz :) | 22:35 |
| huwshimi | hatch: sure | 22:36 |
| ahasenack | gary_poster: did links change too? A nfs charm has this link in its readme, for example | 22:38 |
| ahasenack | https://jujucharms.com/interfaces/mount/ | 22:38 |
| ahasenack | that brings up an "alert" | 22:39 |
| gary_poster | ahasenack, yes, redirects are coming tomorrow | 22:39 |
| ahasenack | ok | 22:39 |
| dpb1 | gary_poster: when you click on that alert and interact with it, the interface get very... angry | 22:42 |
| gary_poster | on call | 22:42 |
| hatch | huwshimi: when you're done with gary I'll show you what I meant with the markup/styling changes - it'll only take a couple mins | 23:20 |
| huwshimi | hatch: Ready | 23:39 |
| hatch | ok one minute | 23:39 |
| hatch | just grabbin my milk | 23:39 |
| hatch | :) | 23:39 |
| huwshimi | sure | 23:40 |
| hatch | huwshimi: ok in guichat | 23:40 |
| gary_poster | hatch, you releasing, or holding off? | 23:47 |
| hatch | gary_poster: yup I'll release tonight - qa was good so far so it's just the mechanical bits | 23:48 |
| hatch | pending of course any wako issues heh | 23:48 |
| gary_poster | great | 23:48 |
| gary_poster | :-) | 23:48 |
| gary_poster | ok thanks hatch. I'll check back in a little later | 23:48 |
| hatch | first I need to redeem myself from the broken demo I just tried to give huwshimi | 23:50 |
| gary_poster | lol | 23:53 |
| gary_poster | hatch, ahasenack filed https://bugs.launchpad.net/juju-gui/+bug/1205136 just in case it is new. charmbrowser guys will look tomorrow | 23:54 |
| _mup_ | Bug #1205136: more charm browser navigation issues <charmbrowser> <juju-gui:Triaged> <https://launchpad.net/bugs/1205136> | 23:54 |
| hatch | ok huwshimi I fixed it | 23:58 |
| hatch | in guichat | 23:58 |
| huwshimi | hatch: coming | 23:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!