/srv/irclogs.ubuntu.com/2013/07/26/#juju-gui.txt

hatchgary_poster: so good news is that I was able to replicate what I had in my head - bad news is that it won't work for what design wants00:13
hatchthe issue huw is having is a tough one for sure00:14
gary_posterhatch, lol, ok, darn.  I wonder if it approximates enough of what they want to be a benefit?  a good solution might be better than a perfect solution...never?00:18
hatchwell the issue isn't that it's not possible, it's that it doesn't work with the current markup00:18
hatchso it's not just a case of adding some transitions00:18
hatchit'll take some markup and styling refactoring00:18
hatchgary_poster: if you're still around can you clarify the subordinate changes that were made in jujucore - were those only in the flagged ui or were respective changes also made for unflagged00:25
* hatch is going through the bzr log00:25
gary_posterhatch, across the board00:26
hatchthx00:26
gary_posterhatch, subordinate support should be good unflagged, better than it was flagged00:26
hatchahh ok00:27
hatchgary_poster: release is complete00:50
hatchI'm going to guess however this doesn't auto push to jujucharms.com?00:50
gary_posterhatch awesome thanks.  correct, we need to ask IS to release first thing tomorrow morning, and hope that is enough time for us to deal with any issues.  we made a pact not to release on Friday...maybe this isn't quite the same?  dunno. :-)01:05
hatchgary_poster: haha, well maybe we should roll up the release EOD Wednesday so we have Friday to iron out any bugs noticed on Thursday :D01:33
gary_posterhatch, I'll send out http://ec2-54-226-124-150.compute-1.amazonaws.com/ for anyone to qa tomorrow.  it looks good to me01:37
teknicobuongiorno, dò un'altra occhiata al tuo branch09:31
teknicooops :-)09:31
=== teknico1 is now known as teknico
frankbangary_poster: morning, would you like to take a look at https://codereview.appspot.com/11841043/diff/16001/server/guiserver/tests/test_apps.py before I submit? Added that test file thanks to your comment.11:55
gary_posterfrankban, yes, I saw the email, thank you!  sure, looking.12:17
gary_posterfrankban, LGTM!  thanks again12:21
frankbangary_poster: cool thanks12:33
* frankban lunches12:33
gary_posterrick_h, hey.  you are here today?  want to see if you want to follow up on Huw's branch email or have someone else do it; and I want to see if #1205136 is another instance of an existing/known bug12:35
_mup_Bug #1205136: more charm browser navigation issues <charmbrowser> <juju-gui:Triaged> <https://launchpad.net/bugs/1205136>12:35
rick_hgary_poster: I'm looking at huw's branch currently. 12:35
gary_postercool, thanks rick_h 12:35
* rick_h goes to check out the bug12:35
gary_posterrick_h, also, did http://ec2-54-226-124-150.compute-1.amazonaws.com/look good to you?12:36
gary_posterhttp://ec2-54-226-124-150.compute-1.amazonaws.com/12:36
rick_hgary_poster: yea, that's the same bug as before. Doing a search, clicking on something, url updates, end up back at search results and state doesn't 'change' from there12:41
gary_posterrick_h, ack, thanks.  so you are on a precursor to that bug, and that bug itself, today and ff IIRC?12:41
rick_hgary_poster: the ec2 url looks good. yay :flags:/ac and looks ok on a general run through12:42
rick_h'and ff' ?12:42
gary_posterand following12:42
rick_hyes, I'll be working on trying to solve all these once I get huw's stuff figured out12:42
gary_postercool perfect thanks rick_h 12:42
rick_hbut I'm getting test failures on trunk and I'm seeing huw's test failures out of no where so working on getting to it12:42
gary_posterrick_h, the "ff" came up from the subconscious--had to look it up :-P http://en.wiktionary.org/wiki/ff.12:43
gary_poster(was checking whether I was crazy or not :-P )12:43
rick_hgary_poster: heads up, beowolf from the U1 team and myself did some chatting about the JS help email thread. I wanted to check with you and team before we volunteer us as "JS peeps" 12:43
gary_posteranswer: only mildly crazy12:43
rick_hgary_poster: heh, I'm so FF == follow friday or feature flag12:43
gary_posterheh12:44
rick_hI couldn't line either up with the sentence12:44
gary_posterrick_h, JS help mail: cool.  already followed up encouraging people to come by #juju-gui.  I figure you'll ask hatch if he wants to speak up.  After that wasn't planning on doing anything unless a reply from David inspires something12:45
rick_hgary_poster: k, beowulf started #js and I brought up the old canonical-javascripters team that's there but not really up to date12:46
rick_hI wasn't sure on people jumping in here so cool if that works12:46
gary_posterrick_h, not sure either but firgured we could offer it, and ask for something different if it doesn't work out.  :-)12:47
gary_posteror maybe they will counter with a request12:47
gary_posterwe'll see12:47
rick_hyea, I figure just spreading the word that there are people out there will help12:48
rick_hcanonical-silos :)12:48
gary_posterheh12:48
gary_posteryeah12:48
hatchmorning13:12
hatchreplying to js email13:12
gary_postercool thanks :-)13:14
bacabentley can we chat after the call about how to construct put_mapping for bundles?  specifically how to tease out the good parts of the services dict.13:27
abentleysinzui: Staging is down.  I assume due to the lcy02 migration.  We still control the staging IP address, but we seem to have no instances at all.13:28
abentleybac: sure.13:28
sinzui:(13:28
bacsinzui, gary_poster: y'all coming?13:31
bacyay13:31
gary_posterthanks bac13:32
marcoceppihey gary_poster can you let benji know the charm school on testing is postponed. We'll be covering a different topic instead today14:06
MakyoHuh, ISP turned off their DNS servers last night.  Oh well!14:13
sinzuijujugui 0.8.1 is live14:13
sinzuijujugui redirect for unversioned charms are live14:13
bacMakyo: 8.8.8.814:14
Makyobac, Yeah, switched to that14:14
jcsackettrick_h: can you look at https://codereview.appspot.com/11845043/14:23
rick_hjcsackett: yep, loading14:24
rick_hhatch: when you get a sec I'd like to do a quick hangout14:24
hatchrick_h: sure14:24
hatchin guichat?14:24
rick_hhatch: sure14:24
hatchin there14:25
gary_postermarcoceppi, will do thanks14:37
rick_hhatch: and can you bring this up on the review call today?14:49
hatchyup14:49
rick_hhatch: because I think I've seen this before of checking a node is an 'object' 14:49
hatchprobably my fault14:49
rick_hhatch: I wonder how many other places we've had the potential for a test that never worked :)14:49
gary_posterjujugui, could I have comments on this blog post, which I will be sending out as an email soon?  I'm particularly interested in whether anyone has any suggested improvements/clarifications to the third para14:52
rick_hhatch: added the card14:52
gary_posterhttp://jujugui.wordpress.com/2013/07/26/jujucharms-com-update/14:52
MakyoLGTM gary_poster 14:53
rick_hgary_poster: LGTM14:53
gary_posterthank you both14:53
hatchELGEETEEEM14:53
gary_poster:-)14:53
gary_posterjujugui call in 714:53
hatchYES! http://canadipsum.com/14:54
bacgary_poster: seems fine14:54
gary_posterthanks bac14:54
teknicogary_poster: wrt the caching problem, I quite like the checksumming approach Tornado uses, I wonder if we could use it: http://www.tornadoweb.org/en/stable/overview.html#static-files-and-aggressive-file-caching14:55
gary_posterteknico, we can use it with the tornado server :-)14:55
teknicoexactly :-)14:56
gary_postermeanwhile, I'm not sure what we are doing wrong with the Apache static file config :-(14:56
gary_posterjujugui call in 114:59
frankbangary_poster, teknico: I believe etags are already enabled in the guiserver, i see "304 Not Modified" responses after the first access15:00
rick_hjcsackett: in test_charm_view.js can we not just load our data/browsercharm.json instead of modifying the existing charmResults?15:03
jcsackettrick_h: the charm results was already there, i wanted to keep the tests as close to the previous form as possible.15:03
jcsackettalso: this whole thing is being blown away once the inspector is live, so didn't seem worth further refactoring.15:03
rick_hjcsackett: yea, it just seems like it's a pre-built lie in the tests now. It works because it's setup to work. 15:04
rick_hjcsackett: but cool, understand15:04
jcsackettrick_h: it's a worthwhile concern. i'll do a quick replace and if it doesn't open a can of worms do it. or if the can of worms is of the sort that indicates there's something else that needs fixing.15:06
rick_hjcsackett: yea, hobble along. I'll try to be good and look away a little bit. Though as I put in my comments, I don't get how the tests work w/o a render call15:07
jcsackettrick_h: render is called in the view's init. which seems wrong, but i'm tampering as little as possible.15:07
* rick_h runs away15:07
* jcsackett laughs15:07
rick_hjcsackett: can you note that then vs the render? comment line please15:07
* jcsackett nods15:07
adeuringorangesquad: could one of you revierw this mp: https://code.launchpad.net/~adeuring/charmworld/charm-revision-files/+merge/177160 ?15:18
* sinzui looks15:18
hatchhazmat: phantomjs@1.9.1-0 and mocha-phantomjs@2.0.015:50
hatchhazmat: that's the most recent phantomjs but mocha-phantomjs is currently at 3.1 on npm15:51
* hazmat downgrades mocha-phantomjs15:52
hazmathatch, thanks that fixes it15:55
hatchexcellent15:56
hatchI'll update the docs15:56
hatchhazmat: you wouldn't happen to have a copy of the error message still?15:56
hazmathatch, incidentally which docs.. HACKING or docs/hacking.rst15:56
hatchI was going to do docs/hacking.rst - maybe we should remove HACKING15:57
hazmathatch, https://github.com/metaskills/mocha-phantomjs/issues/76  " TypeError: 'undefined' is not an object (evaluating 'Mocha.process.stdout')"15:57
hatchthanks15:57
hatchjujugui - thoughts on removing HACKING in favour of hacking.rst?15:57
teknicohatch: docs/hacking.rst is a symlink to HACKING15:58
teknicoit's the same file :-)15:58
hatchteknico: oh haha - I was just looking at it in sublime15:58
teknicohazmat: ^^15:58
hatchthanks :D15:58
gary_posterhatch, fwiw, HACKING is the expected unix-y location, & docs is where we want it for our generated docs15:59
teknicohatch: yeah, sublime should have a way of showing that15:59
hatchgary_poster: alright - I'm creating a card as well to upgrade the various mocha dependencies to the most recent15:59
gary_posterthanks hatch16:00
hazmathatch, gary_poster symlink16:00
hazmatah16:00
hazmatcool16:00
gary_poster(yeah, is now)16:01
hatchgary_poster: https://canonical.leankit.com/Boards/View/102529849/10631562416:04
hatchjujugui does anyone have any other additions/modifications they would like to see in the hacking docs before I commit this?16:17
hazmathatch, i'd suggest moving the improv stuff far down16:17
hazmathatch, its not really required anymore16:17
hazmatits really only useful for pyjuju testing.. maybe split it out into a separate file16:18
gary_posterhatch, hazmat, important for hacking for as long as we have to support pyjuju.  keep it in same file till we don't need to any more (13.10?_16:21
gary_poster)16:21
gary_posterhatch, ack on mocha card thx16:22
hazmatgary_poster, is that 13.10 or 2017.04 ;-)16:22
hazmatjk16:22
gary_posterhazmat, :-P here's hoping 13.10 :-)16:22
hazmatgary_poster, so the thing is .. its basically describing how to do a dev environment in HACKING.. really for py or go.. for testing/dev we really just do the same process of deploying the charm against a branch16:23
hazmatthe whole improv thing was a dev tool which afaik we don't really use anymore in favor of in memory env16:24
hazmatwhoops16:24
gary_posterhazmat if you mean we only use it for qa, yeah, you are right16:24
hazmatreally for py or go.. we test (or should be) against a real env16:24
hatchok so I'll just make the single line change about the mocha stuff for now16:26
hatchgary_poster: what treadmil do you have? Do they make ones without the uprights?16:35
gary_posterhazmat, for go we do for obvious reasons. :-) for py, improv is great for branch qa, and it helps find and dupe issues fast.  I've never had improv approve something that pyjuju rejected.  for release qa, agree on py env.  so anyway, I still think it has a place, for as long as we care about py.  16:35
gary_posterhatch, "sole" something or other16:35
hatchso how do these work without the tops? heh16:35
hazmatgary_poster, fair enough16:35
gary_posterhazmat, tops, you mean the handles?  they are beneath my desk16:35
gary_postercontrols are somewhat awkward to see16:35
gary_posterbut buttons are on the handles so I can control by sound16:35
hatchoh so the screen thing goes behind the desk?16:35
hazmatgary_poster, what brand did you go with?16:35
hatchhttp://www.soletreadmills.com/16:35
gary_posterhatch, yes. hazmat, treadmill is sole, and desk is trekdesk16:35
hatchohhh very cool haven't heard of these guys16:35
hatchI always thought you needed to take the top off16:35
hatch(of the treadmill)16:35
* hazmat wonders the same16:35
hatchwayyy cheaper than the height adjustable desks16:35
hatchbut plus treadmill :)16:35
hazmatthe controls are in the top and handles for the tread.. does the desk fit over that, or is that a something you rigged16:35
gary_posterhazmat fits over.  I have maybe a foot clearance.  it does push against the back display but has not been a problem for me with length.  advice I read for treadmill desk treadmill is to look for long deck16:35
hatchI think I'd like a treadmill desk but what if I want to sit down heh16:35
hatchmaybe put the chair on the treadmill lol16:38
jcastrosinzui: \o/ thanks for sorting out those links16:38
gary_posterhatch, yeah.  either (a) use a laptop and a chair now and then, (b) get a stool and put it on the treadmill when you need to, or (c) don't sit down. :-)16:38
hatchvery quick single line review https://codereview.appspot.com/11918044/16:38
gary_posterI usually opt for (c) with a side of (a)16:38
sinzuijcastro, np16:38
gary_posterhatch LGTM land it16:39
gary_posterhatch self-review would have been fine16:39
hatchlanding16:39
hatchalright :) I QA'd to make sure the command worked to copy/paste/run too16:39
hatchgary_poster: so a large part of ben's branch is separating the viewlets out into their own separate files17:25
hatchso maybe I'll try and land that today17:25
hatchas of right now it's very broken17:25
hatchso this was probably just a first pass is what I'm guessing17:25
gary_posterok thanks hatch17:41
=== matsubara is now known as matsubara-lunch
hatchMakyo: thanks for the branch :) I'll take one of the reviews18:24
Makyohatch, Cool.  I was getting chunk mismatches on it, so I just reproposed.18:25
hatchI see you only fixed your little(big) monkey patch ....copying the new code caused issues?18:25
hatchcode looks good - reviewing18:27
Makyohatch, yeah, down that path lay madness.18:27
hatchlol alright18:27
MakyoThink I  might come up with a better layout this weekend since we no longer need to take radius into account.18:28
hatchs/reviewing/qaing18:28
=== schwuk is now known as schwuk_away
hatchMakyo: it no longer pops up to ask if I want mysql to be a slave/master18:37
hatchwhen linking wordpress and mysql18:37
hatchoh...actually jujucharms doesn't ask either18:38
hatchbug?18:38
Makyohatch, there are no ambiguous relations between those two services.18:38
Makyohatch, try mediawiki and mysql.18:38
hatchahhh sorry18:38
hatchI thought it was wordpress18:38
MakyoOr, if you're feeling brave, hadoop and hadoop.18:39
hatchI don't see anything wrong with the QA18:39
hatchjust gona check the flagged now18:39
hatchMakyo: lgtm'd with a doc request18:46
MakyoCool, thanks.18:46
hatchohh one question18:47
hatchbzr ignore - isn't that going to stop the files from being versioned?18:47
hatchor does bzr ignore work differently than gitignore?18:48
Makyohatch, It works the same.18:49
Makyowe're ignoring the stuff pulled down from npm18:49
hatchso won't that stop the new files from being added into the repo?18:49
hatchohh18:49
MakyoWhich are now named d3.js instead of d3.v2.js18:49
Makyohatch, would this be an @module?18:54
MakyoIt'd be nice to have it show up in generated docs until it goes away.18:55
Makyojujugui one more review, please, mostly mechanical, but QA would be nice: https://codereview.appspot.com/11938044/18:56
bacMakyo: i'll do it18:57
Makyobac, thanks.18:57
bacsinzui: can you review https://code.launchpad.net/~bac/charmworld/indexer/+merge/17720118:57
* sinzui looks18:58
sinzuibac: the refactoring looks good. I am confused though by one addition to the rules.19:08
bacwhich?19:08
sinzuibac line 51: 'bundle_properties['config']' starts a block that appears to describe a charm's options dict19:09
sinzuithe default and description attrs are indexed for charms.19:09
sinzuiI don't think bundles have that19:09
sinzuiThey do have services though19:09
sinzuiDo i misunderstand what  *properties['config'] does for charms and bundles?19:11
bacsinzui: no you're correct about that19:11
baci'll delete it19:11
bacregarding services, i talked to aaron and he indicated the services would be indexed and did not need to be listed in the exact index section19:11
bacsinzui: we also discussed the fact the rules could be tweaked next week since bundle searching will not be used anywhere yet.19:12
sinzuibac: I think we can add services later. It looks valuable, but benji and abentley might say the info is to arbitrary to be trusted19:12
sinzuitoo arbitrary19:13
bacright19:13
sinzuiokay, bac, I have no other concerns, so r=me with the removal of that block19:13
bacrt19:14
bacthx19:14
sinzuibac. I am not certain that tarmac will be happy. staging is dead at the moment because of upgrades to canonistack. We can let it try to do the merge. We will rebuild/deploy staging next week.19:17
bacsinzui: i'm confused.  if tarmac is dead shouldn't i just merge it manually?  or you think it is only hobbled?19:18
sinzuistaging is dead19:19
sinzuiI don't think tarmac is on canonistack. Am I wrong?19:19
baci have no idea19:20
bacis diogo running your tarmac?19:20
hazmathow can you tell if a charm is a subordinate in the left hand side/browesr?19:23
hazmatalso why doesn't rsyslog-forwarder show up on a search for rsyslog.. that sounds like missing tokenization on name19:24
hatchhazmat: yeah I brought up the search issue yesterday19:27
hatchhazmat: I think jc said that it was a search issue and not a gui issue19:31
sinzuihazmat, we are not doing substring matching. We were getting bogus results19:32
sinzuihazmat, substring matching is address with autocomplete, which is feature flagged on comingsoon19:33
bacsinzui: my branch just merged so tarmac must be doing its thing19:36
hazmatsinzui, this isn't substring matching per se.. its tokenization when indexing19:36
sinzuibac: fab19:36
hazmatsinzui, ie rsyslog-forwarder when tokenized results in two words.. rsyslog and forwarder 19:37
sinzuiah19:38
gary_posterhazmat, subordinates: I don't think there is way, in sidepanel or fullscreen.  I'll get it in the overview--after location and before links19:38
sinzuihazmat, expand filters an uncheck reviewed cahrms19:39
* sinzui is not sure why the approved rsyslog-forwarder is not appearing for the search for rsyslog19:41
sinzuimaybe it is text matching content not in the charm name19:41
hazmatsinzui,  that sounds like missing tokenization on name19:42
sinzuihazmat, we are explicit about doing exact matching on name19:44
hazmatsinzui, you still want to tokenize that field19:46
hazmatsinzui, this is not about substring/wildcard query19:46
hazmatits about properly splitting a word19:47
* hazmat peeks at src19:47
sinzuihazmat, try this url http://comingsoon.jujucharms.com:8086/:flags:/ac/19:49
hazmatso line 193 of search.py .. its doing the schema for the charm.. its not analyzing title or name19:50
sinzuiI think it is solving your concern.19:50
sinzuiNo it is not19:50
sinzuiplease my urls19:50
sinzuiplease try my urls19:50
hazmatautocomplete makes it a little better, but doesn't actually address the issue19:53
sinzuihazmat, I think your issue is for users who paste search terms or are using the API to get data19:54
hazmatsinzui, this is a bug in the indexing.. title and name should be analyzed19:54
hazmattitle is especially bad.. its never going to match unless they do an exact search on the whole sentence19:55
sinzuifile a bug then. We are playing with search next week so we can make changes to suit you.19:56
hazmatits not about suiting me.. its about making it work better.19:56
sinzuihazmat, I agree it will be better.19:57
hazmatoh.. its just title for the bundle.20:01
hazmatbug filed. 120547720:02
hatchhttp://gawker.com/canadian-man-sorry-for-chugging-eight-beers-and-swimmin-88828322520:06
hatchbahahaha20:06
gary_posterhazmat, filed 1205479 and scheduled for next week20:07
gary_posterjujugui have to run.  have a great weekend20:07
hatchyou too!20:07
MakyoYou too20:07
bacMakyo: sorry, i got distracted.  doing qa now.  it all looks good so far20:08
Makyobac, cool, thanks.20:08
bacdone20:08
* bac early dog walk. bbiab.20:27
* Makyo dogwalks. The pups are restless.20:52
jcsacketthatch: you still around?21:36
hatchof course21:37
jcsackettgot a second to chat?21:37
hatchsure21:37
hatchin guichat21:37
jcsackettheading there now.21:37
bacbye y'all.  have a good weekend.22:02
hatchcya bac22:04

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!