| === schwuk_away is now known as schwuk | ||
| === schwuk is now known as schwuk_away | ||
| === schwuk_away is now known as schwuk | ||
| gary_poster | teknico, bcsaller could you please make sure that you have your London tickets approved, purchased, and entered on https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AtC9etoysSQldFRfYU0zZjE5WThuNUVWRXlEVmQwOVE#gid=8 by EoD today? (Same goes for me) | 12:26 |
|---|---|---|
| bac | hi benji, i landed my branch that borrowed from yours and then made some changes. you may see mild conflicts. | 12:47 |
| benji | bac: ok, thanks for the heads-up | 12:47 |
| teknico | gary_poster: will do. got a sec for a quick call re: vacation? | 12:55 |
| gary_poster | teknico, sure, come on by guichat | 12:57 |
| teknico | gary_poster: travel request submitted, waiting for approval and booking code | 13:11 |
| gary_poster | teknico, approved | 13:13 |
| teknico | gary_poster: got the code, thank you | 13:14 |
| teknico | ehi jujugui! tired of all that javascript? there's a nice and long python diff waiting for you at https://codereview.appspot.com/12022044 but hurry, only two seats left! ;-) | 13:14 |
| gary_poster | jujugui, we have one critical task that I'd like someone to focus on: try to figure out why redeploys of the jujugui charm to jujucharms do not successfully inform browsers to clear their caches, and fix it. this is a "drop what you are doing" sort of task unless you are near tying something up, that should be wrapped up tomorrow so we can deploy Wed. | 13:23 |
| gary_poster | jujugui, meanwhile, in addition to Nicola's review request (https://codereview.appspot.com/12022044) we also have Kapil's (https://codereview.appspot.com/11966044/) and Huw's (https://codereview.appspot.com/11999043/) | 13:24 |
| benji | gary_poster: I'm merging a branch now and could take this up. I'm also annoyed at the cache issue, so there's anger I can harness ;) | 13:25 |
| gary_poster | jujugui, finally, another urgent task is that IE 10 unit tests are failing, . | 13:25 |
| gary_poster | benji, cool thanks :-) | 13:25 |
| gary_poster | I'll put your head in the card benji | 13:25 |
| gary_poster | on | 13:25 |
| benji | k | 13:25 |
| bac | teknico: i'll do your review. have an orange stand up in a few minutes though | 13:26 |
| gary_poster | bac, I don't think you do. combined standups start today | 13:26 |
| rick_h | bac: do we? Are we trying the joint standups this week? | 13:27 |
| bac | gary_poster: oh, right. cool! | 13:27 |
| * bac fixes calendar | 13:27 | |
| teknico | bac: thank you | 13:27 |
| teknico | hazmat: looking at your proposal, unclear on how to review it :-) (also, I cannot find its card, is there one?) | 13:29 |
| gary_poster | teknico, no card, please create in maintenance | 13:30 |
| gary_poster | teknico, you should try finding a charm with a bool | 13:30 |
| gary_poster | in the congig, make an environment with it, export it | 13:30 |
| gary_poster | old version should have issue described by related bug, new should not. extra credit if you try running it through the deployer | 13:31 |
| teknico | gary_poster: yeah, but even before QAing it, I was wondering how to understand the change by looking at it :-) | 13:33 |
| teknico | it'd be nice to be able to look at a diff on non-minimized code | 13:34 |
| gary_poster | teknico, first line of the compressed file should tell you where to find the diff source, and related yaml parser issue. if it is insufficiently clear, that's something for the review. after you've tried to figure it out, if you are still unclear let me know and I'll try to clarify. I don't want to spoil your blank-slate impressions though: we should be aiming for clarity for someone in your shoes | 13:36 |
| teknico | gary_poster: oh, right, thanks, I'll try to put together the change | 13:37 |
| gary_poster | cool teknico | 13:37 |
| adeuring | gary_poster: when/where is the standup? I don't see it in my google calendar | 13:39 |
| gary_poster | adeuring, thank you for reminding me. I just invited orange squad to the meetings. Friday is a different time than the others. we always meet in http://tinyurl.com/guichat . Look good? | 13:42 |
| hatch | morning all | 13:43 |
| gary_poster | morning hatch | 13:43 |
| adeuring | gary_poster: sure | 13:43 |
| gary_poster | cool adeuring | 13:43 |
| hatch | gary_poster: in a few minutes I can start on huw's review | 13:50 |
| gary_poster | thanks hatch | 13:51 |
| gary_poster | trying to disconnect/reconnect for better network; back in a sec, hopefully | 13:52 |
| gary_poster | nope, no real improvement | 13:52 |
| gary_poster | :-/ | 13:52 |
| hatch | it didn't show you dc/rc :) | 13:53 |
| hatch | it got to 10C last night....summer is over :( | 13:54 |
| * hatch straps his snowboard on and sits on the stairs waiting | 13:56 | |
| gary_poster | heh | 13:57 |
| gary_poster | teknico, doing your second review | 13:58 |
| teknico | gary_poster: thank you | 13:59 |
| bac | teknico: your branch looked good. doing a QA deploy now. | 14:01 |
| hatch | rick_h: saw your q in #yui, any progress? | 14:01 |
| rick_h | hatch: yea, some progress. I'm buried into the ns-routing code atm | 14:03 |
| rick_h | wheee! lucky monday! | 14:03 |
| hatch | oh alright - keep in mind that the majority of that code is the yui router code with some stuff injected into it | 14:03 |
| rick_h | hatch: yea, but I'm into how we parse/split/combine urls atm | 14:03 |
| rick_h | hatch: so all our own doing :) | 14:03 |
| hatch | ahh - | 14:04 |
| rick_h | have the bug fixed now but getting #bws-configuration#bws-configuration in the url :) | 14:04 |
| rick_h | hatch: but thanks for checking in | 14:04 |
| hatch | np - I may be able to lend a hand with the routing stuff if you run into any 'wtf' areas :) | 14:05 |
| rick_h | hatch: just hard to trace. still have double dispatch along with a couple of passes through the code for the orig url vs incoming and such. #needmoarcoffee | 14:05 |
| hatch | my coffee is watered down for some reason....not impressed - might have to take a walk to a coffee shop | 14:06 |
| hatch | gary_poster: as far as QA'ing Huw's branch goes - is this supposed to be an incremental branch? I have found a few 'bugs' but they aren't critical | 14:10 |
| gary_poster | hatch, not sure it is supposed to be incremental, but we can treat it as such. +1 on getting this landed and then either shooting Huw/list an email with qa issues, or if they are trivial putting something together quickly yourself | 14:11 |
| hatch | gary_poster: we should have a "sprite all the things" card so that we don't forget in the future :) because all of these new icons are being added un-sprited | 14:20 |
| gary_poster | hatch, oh suck. :-/ ok, will do. I assume you'll mention that to Huw as well, so that in future branches he does these with sprites | 14:21 |
| gary_poster | done fwiw, in maintenance: high | 14:22 |
| adeuring | sinzui: could you have another at my MP from friday? | 14:23 |
| hatch | yup will do | 14:23 |
| sinzui | adeuring, I am just giving your my r=me | 14:24 |
| adeuring | sinzui: coll, thanks! | 14:24 |
| rick_h | woooooooooooo! it works! | 14:25 |
| sinzui | adeuring, you can approve the review to merge it. | 14:25 |
| adeuring | sinzui: ack | 14:26 |
| sinzui | orangesquad. I think we need to build a new staging env | 14:26 |
| gary_poster | rick_h, yay!!! :-) | 14:27 |
| gary_poster | teknico, LveryGTM with comments | 14:27 |
| teknico | gary_poster: thanks, replying | 14:29 |
| sinzui | adeuring, I would like you to work on https://bugs.launchpad.net/charmworld/+bug/1199780 | 14:31 |
| _mup_ | Bug #1199780: search requests errors when a charm has no last_change <charmworld:Triaged> <https://launchpad.net/bugs/1199780> | 14:31 |
| adeuring | sinzui: I started already ;) | 14:31 |
| sinzui | :) | 14:31 |
| sinzui | adeuring, I am moving the card to the juju-gui board | 14:32 |
| adeuring | sinzui: ok | 14:32 |
| hatch | gary_poster: reviewed/replied to huw's branch - I can fix the code issues and take a stab at the qa ones to get it landed if you like | 14:32 |
| hatch | I could also investigate the IE10 failures | 14:33 |
| gary_poster | hatch, big +1 on landing Huw's branch with fixes, thank you. IE10: you ok with that, or would you rather someone else look at it? You've certainly paid your dues there :-) | 14:34 |
| hatch | haha well there looks like there is a CI failure and an intermitant IE failure | 14:35 |
| hatch | I don't know how long the fixes in huw's branch will take (shouldn't be too long though) so if someone else can pick it up first that'll be fine :) | 14:35 |
| Makyo | I just started the IE10 stuff, but haven't gotten much farther than turning on the VM | 14:35 |
| gary_poster | hatch cool, thanks. Makyo, awesome, thanks. | 14:36 |
| Makyo | Mocha desperately needs a stop button. | 14:41 |
| gary_poster | heh | 14:42 |
| gary_poster | yes | 14:42 |
| * rick_h runs make test-debug and ducks | 14:45 | |
| hatch | rick_h: so in your new branch the #'s will be gone? | 14:48 |
| hatch | from the tabview | 14:48 |
| rick_h | hatch: no | 14:48 |
| rick_h | hatch: they'll be there still since we need them for the charm browser side | 14:49 |
| hatch | ahh, hmm | 14:49 |
| rick_h | hatch: but the big lesson here is that the tabview doesn't add the #, the Y.App does | 14:49 |
| rick_h | which took me a LONG time to figure out and quit blaming the wrong code | 14:49 |
| hatch | ohh from the <a>'s? | 14:49 |
| rick_h | hatch: riiiiight | 14:49 |
| rick_h | which is why all of this is a routing issue, not a tabview/browser subapp issue | 14:49 |
| hatch | see a's are bad | 14:50 |
| hatch | :P | 14:50 |
| rick_h | oh hush | 14:50 |
| hatch | lol | 14:51 |
| hatch | sorry coudln't resist | 14:51 |
| hatch | rick_h: I'm guessing that has something to do with the pjax stuff | 14:52 |
| rick_h | hatch: well, it's the Y.App wanting to update the url without a reload | 14:52 |
| rick_h | hatch: ah, yea...that might be part of it as well I guess. using hash for content/page id | 14:52 |
| hatch | yeah - pjax listens to all a's and then updates the url directly without clicking | 14:53 |
| hatch | without redirecting i mean | 14:53 |
| rick_h | right | 14:54 |
| hatch | so i'd say first place to start would be monkey patching pjax out of there | 14:54 |
| hatch | I remember we left it in because it didn't appear to cause us issues | 14:54 |
| hatch | we were wrong :) | 14:54 |
| rick_h | heh, no. The fix is actually not bad. I've got it all working just needs tests. | 14:54 |
| hatch | oh cool | 14:54 |
| rick_h | https://code.launchpad.net/~rharding/juju-gui/routing-issues/+merge/177401 for diff | 14:54 |
| rick_h | that and hash comes after QS in a url | 14:55 |
| rick_h | doing it the other way is un-good | 14:55 |
| hatch | while this is a good fix its really just bandaiding the real problem | 14:55 |
| rick_h | Hmmm, I'm not 100% sold ont hat | 14:56 |
| rick_h | err that | 14:56 |
| hatch | because that hash shouldn't be added to the url at all | 14:56 |
| hatch | we don't use pjax | 14:56 |
| rick_h | yes it should! | 14:56 |
| rick_h | we want to generate a unique url so you can link directly to the readme of a charm | 14:57 |
| rick_h | it's part of the UX design. | 14:57 |
| hatch | ohh, hmm that should probably be /precise/ceph-13/readme then | 14:58 |
| hatch | at least imho | 14:58 |
| rick_h | that we can debate perhaps, but it's not a different resource to view the readme | 14:58 |
| rick_h | only a small section of content changes | 14:58 |
| rick_h | which is what anchor tags are for | 14:58 |
| hatch | that's arguable because webapp not website | 14:59 |
| rick_h | I agree it's arguable | 14:59 |
| rick_h | just don't agree with your side :) | 15:00 |
| hatch | lol | 15:00 |
| bac | teknico: i tried to deploy the charm with your changes and got an install error. investigating still. | 15:00 |
| hatch | this is the url from the inspector though :8888/#bws-readme which is no good | 15:00 |
| rick_h | hatch: agree, and it's an easy fix. | 15:01 |
| rick_h | we just have to catch the click event when deployed via the inspector and halt | 15:01 |
| rick_h | hatch: but only when done through the inspector, so we need an init flag for it | 15:01 |
| teknico | bac: uhm, I run "make ftest" before proposing without errors... | 15:01 |
| hatch | sure - so why wouldn't we remove the pjax and then enable it, instead of disable it | 15:01 |
| hatch | it's a side effect that we just happen to be using in a single place in the app | 15:02 |
| rick_h | hatch: either we disable it and add it for browser or leave it and disable it for inspector. | 15:02 |
| rick_h | either way we have to work around this stuff. | 15:02 |
| hatch | I'm saying we manually add the hash when we need to | 15:02 |
| hatch | look how long it took you to find the source and you wrote the code haha | 15:02 |
| rick_h | and none of that is the router code's fault? That is improperly parsed QS and hashes? | 15:03 |
| rick_h | and I didn't write the router code :P | 15:03 |
| hatch | well when I 5why it I get to pjax | 15:04 |
| rick_h | because the hash is added via pjax. Then we improperly hanled hashes in our routing | 15:04 |
| teknico | bac, gary_poster: reproposed with changes that address your remarks | 15:04 |
| rick_h | if you remove pjax, we're still handling them wrong in routing. | 15:05 |
| hatch | that's not how 5why's works | 15:05 |
| hatch | lol | 15:05 |
| rick_h | I thought 5why was a typo :/ | 15:05 |
| hatch | I'm not saying we handle them properly (although I don't know what the issue in router is) | 15:05 |
| * rick_h hits the web for wtf 5why is | 15:05 | |
| hatch | oh hahaha | 15:05 |
| hatch | 5why's is a technique for determining the root cause of a problem | 15:06 |
| hatch | it also exposes issues along the way | 15:06 |
| rick_h | yea, I see. I'll write up my 5why's later after I get these tests in | 15:07 |
| hatch | on a different angle....should we pass the viewlets container to the render method? | 15:07 |
| hatch | https://codereview.appspot.com/11999043/diff/1/app/views/viewlets/charm-details.js | 15:08 |
| hatch | see that as to why I think so... | 15:08 |
| rick_h | hatch: so isn't that the slot name? Or is it not? | 15:09 |
| rick_h | the viewletManager should handle this I'd think when you show/hide a slot | 15:09 |
| rick_h | and not the viewlet itself | 15:09 |
| rick_h | though the way things work 'render' !== 'show' | 15:09 |
| rick_h | :/ | 15:09 |
| hatch | yeah hmm ok this method should be slightly refactored then | 15:11 |
| rick_h | hatch: +1 | 15:11 |
| hatch | render should handle generating the content | 15:11 |
| hatch | should only* | 15:11 |
| rick_h | hatch: yea, I'd look to the viewletManager for controlling the slot visibility imo if possible | 15:11 |
| rick_h | as part of the showSlot() stuff | 15:11 |
| hatch | yep and it does | 15:11 |
| rick_h | hideSlot | 15:11 |
| rick_h | oh, then why is this necessary? | 15:12 |
| * rick_h isn't caught up. | 15:12 | |
| hatch | not sure | 15:12 |
| hatch | haha | 15:12 |
| rick_h | but agrees with refactor of it | 15:12 |
| * hatch looks further | 15:12 | |
| adeuring | rick_h: about bug 1199780: How is charm['code_source'] dictionary used? Can we simply drop charm['code_source']['revision'] and charm['code_source']['last_log'] if it is not avaliable, should we set it to None/null? (Note that this can also happen with the data for related charms) | 15:13 |
| _mup_ | Bug #1199780: search requests errors when a charm has no last_change <charmworld:Triaged> <https://launchpad.net/bugs/1199780> | 15:13 |
| rick_h | adeuring: sec, looking to be sure | 15:14 |
| rick_h | adeuring: so we'd have to refactor to add sanity checks it exists. We don't have a 'if model.get('code_source') as it seemed you'd have to have source to have a branch/pushed/etc. | 15:15 |
| adeuring | rick_h: right, but we can have charms whose LP brnach is deleted. And then we have this situation | 15:16 |
| hatch | rick_h: if you're going to leave pjax in can you put a comment in the tabview code which explains where the hashes are coming from | 15:16 |
| hatch | I figure that's the logical place someone might look in the future | 15:16 |
| rick_h | adeuring: right, so we'd have to update the front end to handle it being option. Right now it doesn't. | 15:16 |
| rick_h | hatch: sure | 15:16 |
| adeuring | rick_h: OK... What about js using the text "not available"? | 15:17 |
| rick_h | adeuring: it's expecting a nested object. So no matter what it's changed to we need to adjust | 15:17 |
| rick_h | adeuring: if we don't have it then I'd say we leave the value out. | 15:17 |
| Makyo | jujugui: IE10-able folks, need some reviews/test runs for a fix https://codereview.appspot.com/12033043/ | 15:17 |
| rick_h | then we can look if we can provide a decent default that prevents too much work | 15:17 |
| adeuring | rick_h: OK | 15:17 |
| bac | Makyo: i can review. can run tests with some pain if really necessary. | 15:20 |
| hatch | Makyo: I can run the tests | 15:20 |
| hatch | .....and are you serious? this was the cause....ugh IE | 15:20 |
| Makyo | bac, how about hatch runs the tests, and you sanity check? :) | 15:20 |
| bac | sure | 15:21 |
| hatch | Makyo: is the flags fix because window.flags was undefined at that part? | 15:21 |
| Makyo | hatch, yeah, for running that suite in isolation. | 15:21 |
| hazmat | for folks working on charmworld.. with elastic search.. came across this library this weekend, made working with elasticsearch much more pleasant and pythonic. http://elasticutils.readthedocs.org/en/latest/ | 15:22 |
| hazmat | builds on top of the py connector library we're already using. | 15:23 |
| hatch | Makyo: I wonder if we should have a follow-up branch which adds window.flags to every suite and then cleans it up after every suite | 15:24 |
| Makyo | hatch, I put that in the MP. | 15:24 |
| hatch | oh.... /me learns to read | 15:25 |
| bac | Makyo: nm my comment about the same. | 15:25 |
| * bac learns to read too | 15:25 | |
| hatch | Makyo: sorry, windows 8 keeps crashing | 15:26 |
| hatch | I just did an update so,.....ya know | 15:26 |
| Makyo | hatch, I feel your pain, yeah | 15:26 |
| hatch | hey Windows....nice of you to boot up | 15:30 |
| hatch | I used to be afraid to do Linux updates, now I'm afraid to do Windows ones, my how the times have changed | 15:31 |
| hatch | make test-server | 15:32 |
| hatch | blarg | 15:32 |
| sinzui | jcsackett, I am looking at the charmworld board. I think card 3.1 is done and card 3.2 is coding and already represented on the juju gui board. | 15:36 |
| jcsackett | sinzui: you're right; i've moved 3.1 to the done-done. | 15:37 |
| jcsackett | sinzui: do you want us updating this board as well? | 15:37 |
| sinzui | jcsackett, thank. you. I am dismantling the board. moving work to jujugui when it isn't already there | 15:42 |
| hatch | Makyo: lgtm'd | 15:43 |
| Makyo | hatch, thanks | 15:44 |
| jcsackett | sinzui: dig. | 15:45 |
| jcastro | how long after I feature/unfeature should it show up on the site? | 15:48 |
| rick_h | jcastro: pretty quick. We might hit a cache on the production site but the 'change' is instant as far as the data is concerned | 15:49 |
| sinzui | jcastro, I think the squid cache is the factor in play | 15:49 |
| jcastro | ok | 15:50 |
| gary_poster | jujugui, orangesquad, call in 8. please update kanban now for a quick overview call. | 15:53 |
| gary_poster | 7, that is :-P | 15:53 |
| hatch | woah....new board | 15:53 |
| hatch | gary's been workin | 15:53 |
| gary_poster | heh | 15:58 |
| gary_poster | jujugui orangesquad call in 2 | 15:59 |
| gary_poster | in guichat | 15:59 |
| rick_h | jujugui I can haz critical review please? https://codereview.appspot.com/12036043 | 16:00 |
| gary_poster | Makyo, you here? | 16:01 |
| hatch | rick_h: critical as in negative? :P | 16:01 |
| rick_h | critical as it bugs are marked critical | 16:01 |
| hatch | yup I'll take one | 16:02 |
| hatch | teknico: I heard that there is no Alfredo sauce in Italy? And that you don't put chicken in pasta.....true? | 16:05 |
| rick_h | jcsackett: can you link the branch? I tried to click the bug in the card to get to the review but failed | 16:07 |
| bac | jcsackett: where is your mp for that card? | 16:07 |
| jcsackett | rick_h: yeah, i haven't been good about linking to bugs. | 16:07 |
| bac | :) | 16:07 |
| jcsackett | rick_h: one sec, i'll go find it. | 16:08 |
| rick_h | jcsackett: ty | 16:08 |
| jcsackett | rick_h: https://codereview.appspot.com/12031043/ | 16:08 |
| teknico | hatch: what?!? and, what?!? | 16:10 |
| hatch | a friend of a friend has a friend from Italy and they claim that there is no 'Alfredo' sauce and that you don't put chicken in your pasta | 16:11 |
| jcsackett | 10 minutes on a call with that many people. nice! | 16:11 |
| hatch | we pro! | 16:11 |
| hatch | bcsaller: rick_h making hangout | 16:11 |
| bac | jcsackett: done, thx | 16:13 |
| hatch | that's so odd - the camera was reversed during that call compared to the guichat ones | 16:24 |
| teknico | hatch: I know of no "Alfredo" sauce and of no recipe for putting chicken in pasta | 16:33 |
| hatch | crazystuffs | 16:34 |
| hatch | here - Italian pasta has Alfredo sauce and chicken lol | 16:34 |
| rick_h | sinzui: gary_poster any preference on next task priority? Pick a bug any bug? | 16:35 |
| teknico | hatch: I'm not a food tradition purist, and I've been eating no pasta for years now, so I'm not offended | 16:35 |
| hatch | rick_h: issue with the QA | 16:40 |
| hatch | when I follow https://bugs.launchpad.net/juju-gui/+bug/1205468 | 16:40 |
| _mup_ | Bug #1205468: fullscreen charmbrowser tabs are broken <charmbrowser> <juju-gui:In Progress by rharding> <https://launchpad.net/bugs/1205468> | 16:40 |
| hatch | and then hit the back button | 16:40 |
| hatch | it stays in the same page | 16:41 |
| hatch | because it puts a history entry for the hash | 16:41 |
| rick_h | ah crap...double dispatch fml | 16:41 |
| rick_h | oh wait, back just removes the hash? | 16:41 |
| hatch | yeah | 16:41 |
| hatch | trying on serviceInspector which has no double dispatch | 16:41 |
| hatch | same | 16:42 |
| rick_h | right, that's kind of 'working as intended' because it does dispatch when you click a tab | 16:42 |
| hatch | pjax must also add a browser entry | 16:42 |
| * rick_h is thinking | 16:42 | |
| hatch | so when it's removed it should dispatch then and go back to summary | 16:42 |
| rick_h | hatch: so I'd propose this is a low priority follow up bug to worry about the back button history atm. It fixes 4 bugs in the system currently. | 16:43 |
| rick_h | one critical and one high | 16:44 |
| hatch | I'd tend to agree | 16:44 |
| rick_h | hatch: because fixnig that isn't easy as the hash is part of the app 'state' and the state comes from the App dispatching. The fix is to not 'dispatch' but then we dont' get our app state change atm | 16:44 |
| rick_h | so it'll take some thought/testing | 16:45 |
| rick_h | and jcsackett :P | 16:46 |
| jcsackett | wait,what? | 16:46 |
| rick_h | jcsackett: your comment in your LGTM | 16:46 |
| jcsackett | aaaah. | 16:47 |
| jcsackett | i was suddenly concerned you were throwing work at me, and i couldn't figure out how. e.g. "it'll take some thought, testing, and jcsackett". | 16:47 |
| rick_h | lol, +1! | 16:47 |
| jcsackett | this is not me endorsing the plan that work should be thrown at me. :-P | 16:48 |
| hatch | rick_h: found a real bug | 16:50 |
| hatch | shall I reply with repo steps on the commit? | 16:50 |
| rick_h | stop doing that | 16:50 |
| rick_h | hatch: yes please | 16:50 |
| hatch | just finding the quickest repro | 16:51 |
| rick_h | ok, well food fetching while you do that and will look back | 16:52 |
| hatch | ok replied | 16:54 |
| rick_h | hatch: thanks, easy fix. Appreciate it | 16:57 |
| hatch | excellent | 17:00 |
| * hatch wishes for a parent css selector | 17:05 | |
| hatch | bcsaller: so...any ideas for anything better than this._slots[viewlet.slot].container.ancestor('.slot') | 17:06 |
| hatch | i'd add a slot class to the slot | 17:07 |
| hatch | or could make it an attribute | 17:07 |
| hatch | which would probably be nicer | 17:07 |
| hatch | but container.ancestor() still sucks | 17:07 |
| bcsaller | yeah, thats not great | 17:07 |
| hatch | I could go container.get('parentElement') | 17:08 |
| hatch | but that isn't very robust | 17:08 |
| bcsaller | chat real quick? | 17:08 |
| hatch | sure | 17:09 |
| hatch | in guichat | 17:09 |
| gary_poster | hey rick_h, you still looking for something to do? I've got ideas if so | 17:21 |
| gary_poster | sorry was lunching | 17:21 |
| rick_h | gary_poster: I will be. Working on a last bug/issue in getting the other branch landed | 17:22 |
| hatch | rick_h: so in this branch of huw's when I close the left panel after viewing some of the tabs it leaves the #'s in the url | 17:26 |
| gary_poster | rick_h, cool. Looking for choices. First one is this. Trivial but important: https://bugs.launchpad.net/juju-gui/+bug/1202636 | 17:26 |
| _mup_ | Bug #1202636: Charm Details Page Under Providers Change Openstack to HP Cloud <juju-gui:Triaged> <https://launchpad.net/bugs/1202636> | 17:26 |
| hatch | rick_h: interestingly enough, when I realod the page, that hash gets stripped lol | 17:27 |
| rick_h | hatch: yea, it's not what I thought it was. | 17:27 |
| rick_h | hatch: when I dupe it works when I click the juju, but then fails when I change viewmode. There's some hidden bit somewhere I'm missing | 17:27 |
| hatch | re the QA bug? | 17:28 |
| rick_h | hatch: yea | 17:28 |
| hatch | hmm I can't really be of any help there | 17:29 |
| rick_h | hatch: yea, all good. | 17:29 |
| rick_h | thought that's what you were talking about | 17:29 |
| hatch | I haven't spent much time in your homebrew routing code ;) | 17:29 |
| hatch | oh no sorry | 17:29 |
| rick_h | there's an existing bug for chrome that clears the url out when manually hitting a url :( | 17:29 |
| rick_h | that's not part of this fix | 17:29 |
| hatch | ohhhhhh | 17:29 |
| hatch | ok that must be waht I'm hitting now | 17:29 |
| hatch | no prob doesn't effect this branch negatively | 17:30 |
| hatch | the status bar plays tricks on my eyes | 17:30 |
| hatch | the red/green bars look different heights | 17:30 |
| hatch | even though I know they can't be :) | 17:30 |
| rick_h | hatch https://launchpad.net/bugs/1199392 | 17:30 |
| _mup_ | Bug #1199392: can't view fullscreen charm details from url <charmbrowser> <juju-gui:Triaged> <https://launchpad.net/bugs/1199392> | 17:30 |
| hatch | we have too many router technologies acting in one place | 17:31 |
| hatch | :) | 17:31 |
| gary_poster | sinzui, I'd like to triage https://bugs.launchpad.net/charmworld/+bug/1206158 as high. We're having multiple questions about this on sales calls, so this would be a (presumably easy?) thing to add for good sales win. Is that ok with you? Am I badly underestimating the effort involved? I hoped it would be a day or two max for one engineer. | 17:33 |
| _mup_ | Bug #1206158: On manage.jujucharms.com show download breakdown by last 30 days, last week <charmworld:Triaged> <https://launchpad.net/bugs/1206158> | 17:33 |
| sinzui | gary_poster, okay | 17:33 |
| gary_poster | sinzui, what do you think about effort? | 17:33 |
| sinzui | gary_poster, a single branch that adds the model properties and and template presentation | 17:34 |
| gary_poster | sinzui, so day or two max? | 17:37 |
| sinzui | yep | 17:37 |
| hatch | taking off for lunch, call cell is ya need me | 17:38 |
| rick_h | gary_poster: so in reading that bug does that maen that we're going to start testing on 'openstack' somewhere? Or just not going to have that visible? | 17:45 |
| gary_poster | rick_h, we're not going to have it visible. apparently, according to mramm and others, openstack installations are too different | 17:45 |
| gary_poster | so in the futrue | 17:45 |
| gary_poster | we may have results for HPCloud | 17:46 |
| gary_poster | and some other OpenStack provider | 17:46 |
| rick_h | k | 17:46 |
| gary_poster | and we will not be at all surprised when they have different results | 17:46 |
| gary_poster | hatch, when you are back, no rush, but is this inspector card/task no longer valid? "Add mutation observer to viewlet to rebind viewlets when updated out of band" | 18:03 |
| bcsaller | gary_poster: That one was from me, its still an option but its an optimization not a requirement | 18:11 |
| rick_h | hatch: also when you're back, branch updated for a second run through QA. | 18:11 |
| gary_poster | bcsaller, ok cool, thanks. clean uptask, then? | 18:12 |
| rick_h | hatch: think I've caught it all there. One other QA point found during this was to sidebar, open a charm, click a tab, then minimize the browser, and bring it back up. | 18:12 |
| bcsaller | yeah, pretty much | 18:12 |
| rick_h | and now my head hurts...ugh routing/state FML | 18:13 |
| benji | is anyone else having problems building (NPM downloads failing) | 18:20 |
| gary_poster | benji, I had to make clean; didn't look closely | 18:22 |
| gary_poster | rick_h, playing around with your branch. lots of fixes, cool. this one is not supposed the query string related bugs, right? for instance, http://localhost:8888/fullscreen/search/precise/ceph-13/?series=precise&text=ceph&type=approved#bws-readme does not load properly. I already saw you say that back arrow bugs were for later, I think, which I agree with. | 18:27 |
| gary_poster | "this one is not supposed the query string related bugs, right" -> this branch is not supposed to fix the query string related bugs, right? | 18:27 |
| gary_poster | rick_h, those are the only bugs I can find. Way better. thank you! | 18:29 |
| rick_h | gary_poster: looking | 18:29 |
| rick_h | gary_poster: right, it doesn't fix the chrome removing the query string bug | 18:29 |
| rick_h | gary_poster: I did not run into that cause in my list. | 18:30 |
| rick_h | oh hmm, that happened to me on FF as well. Thought it was a chrome-only bug. | 18:30 |
| rick_h | gary_poster: but yea, that's still out there on our board. | 18:30 |
| gary_poster | rick_h, cool, thanks! | 18:30 |
| rick_h | gary_poster: but it should hit 4 bugs currently in the tracker. | 18:31 |
| gary_poster | rick_h, I saw, sweet :-) maybe even more | 18:31 |
| rick_h | the back button I think we could chat on. I keep going back/forth on how that 'should' work since we're treating tabs as unique urls, vs 'back button, ignore tabs' | 18:32 |
| gary_poster | I see | 18:36 |
| jcsackett | rick_h: qs is removed in both ff and chrome,but in ff the correct view is shown | 18:37 |
| jcsackett | so it's partially an FF bug. | 18:37 |
| rick_h | jcsackett: ah, in nightly it went back to search just like chrome | 18:37 |
| rick_h | jcsackett: in FF nightly that is. | 18:37 |
| jcsackett | rick_h: interesting. | 18:37 |
| jcsackett | rick_h: i'm not sure what that suggests,but it certainly suggests something. :P | 18:37 |
| rick_h | jcsackett: but yea, that's a routing/double dispatch bug I think. | 18:37 |
| rick_h | jcsackett: yea, suggests there's work to be done to fix that bug...for someone... | 18:38 |
| jcsackett | if it's still around when i get done with charmstore-apocalypse i'll be happy to look. | 18:38 |
| hatch | back | 18:41 |
| hatch | rick_h: ok will re-qa | 18:42 |
| gary_poster | bcsaller, hey. did you see my September/London flight request? please get that done today (which means, you propose via form, I approve, you go to travel provider, they get you flight, and you enter details on spreadsheet) | 18:42 |
| bcsaller | gary_poster: yeah, I saw it, I have it on my calendar to do it today as well. | 18:43 |
| gary_poster | cool bcsaller thanks | 18:44 |
| gary_poster | hazmat what I was trying to say in last reply to review is that I'm happy for you to give this to us to land if you want. we appreciate very much the work you've already done | 18:49 |
| hatch | gary_poster: CI is broken....can't deploy charm | 18:51 |
| gary_poster | hatch, may be because canonistack is broken. :-/ sinzui did you say that you can't get a juju env on canonistack any more? | 18:51 |
| sinzui | gary_poster, hatch. I am in #is now diagnosing why we cannot build a new env. If CI was in, or use anything in, canonistack, then it is dead | 18:53 |
| gary_poster | ack sinzui thanks. hatch ^^^ :-/ | 18:53 |
| hatch | ahh darn, alright | 18:53 |
| hazmat | gary_poster, ack | 18:54 |
| hatch | rick_h: when changing tabs and then hitting back, the hash changes but the tabs never do | 18:57 |
| rick_h | hatch: rgr, duplicates here | 18:58 |
| hatch | rick_h: you fixing now? | 19:00 |
| rick_h | hatch: back isn't hitting the subapp at all. It's not dispatching to the subapp so not sure how to fix that atm | 19:01 |
| benji | ok, that's weird; I changed all the "https" to "http" in npm-shrinkwrap.json and now npm install works | 19:02 |
| hatch | rick_h: well all of the routes get collapsed into the parent app, so my guess is it's something to do with your custom routing stuff | 19:02 |
| rick_h | hatch: custom routing stuff? | 19:03 |
| hatch | like how everything goes into routeDefault and routeView | 19:03 |
| hatch | it's possible something in there is clobbering it up | 19:03 |
| hatch | because every time the url changes it should dispatch | 19:03 |
| rick_h | hatch: no, I'm saying is that none of the subapp routes get touched. Right now it doesn't appear ns-routing is hit during a back button right now | 19:03 |
| hatch | oh really? | 19:04 |
| hatch | so routeDefault isn't called? (it's a * so it should be called no matter what) | 19:04 |
| rick_h | hatch: yes, ns router.parse() isn't getting hit (put a debugger in there) on back, but it is on every click/forward call | 19:04 |
| rick_h | hatch: checking routeDefault | 19:04 |
| rick_h | hatch: correct, routeDefault is not touched | 19:05 |
| rick_h | hatch: so calling this one bigger than subapp at the moment. | 19:05 |
| hatch | well that's just friggen weird | 19:05 |
| rick_h | hatch: not if something in Y.App or something isn't re-dipatching on anchor change from back? | 19:06 |
| rick_h | I'm not sure what to say without doing a lot more looking and hitting EOD soon | 19:06 |
| hatch | so the pjax stuff is not causing a re-dispatch on back | 19:06 |
| hatch | because the navigate stuff triggers the re-dispatch (as it should) | 19:06 |
| rick_h | well someone is not, I'm not clear enough to say who | 19:07 |
| rick_h | hatch: but yea, something up. Back works on non-#hash changes | 19:07 |
| hatch | well it's pjax that's adding the hash right? | 19:07 |
| hatch | oh I bet I know why | 19:07 |
| hatch | checking... | 19:07 |
| hatch | ok I 'think' that becuase we use html5: true in the app, it only dispatches on real paths, not hashes | 19:09 |
| rick_h | hatch: so calling it not related to this branch. Up for a secondary bug :) | 19:09 |
| hatch | ok simply switching that flag didn't do it | 19:11 |
| rick_h | hatch: yea, worst case we'd have to detect and manuall fire a navigate event to force it if there's not a good 'natural' fix for that. | 19:12 |
| hatch | or we switch to using a /path for it :) | 19:13 |
| gary_poster | +1 if that's easy fwiw | 19:13 |
| rick_h | hatch: or stop tracking the tab, in the url, or 100 other things. However, I'd really like to land this as it fixes a real 'cannot use the gui' issue while the back is slightly annoying but not as big | 19:13 |
| gary_poster | +1 also | 19:14 |
| === schwuk is now known as schwuk_away | ||
| rick_h | The bug I'm on will be quick, I can get back to 'back button' issues later tomorrrow. | 19:14 |
| hatch | yeah I'm pretty sure everything is qa'ing ok | 19:15 |
| rick_h | cool | 19:15 |
| hatch | few more things to check | 19:15 |
| hatch | and yeah I still want this landed, that fix can be pushed to later | 19:15 |
| rick_h | ok, I was trying to pick up the irc vibe on if this was heading towards blocker for your vote to land. Sorry. | 19:15 |
| rick_h | :) | 19:15 |
| hatch | each irc line needs a body language colour | 19:16 |
| gary_poster | or smell! | 19:16 |
| hatch | lol | 19:17 |
| hatch | I thought someone made something that could make smells in your computer | 19:17 |
| gary_poster | yeah I saw something like that. didn't click through :-) | 19:17 |
| gary_poster | ah leankitkanban...you make me want to write a kanban board sometimes... | 19:18 |
| rick_h | lol | 19:18 |
| hatch | rick_h: curious as to why you relocated the initState method | 19:21 |
| rick_h | hatch: it's no longer private | 19:21 |
| hatch | ohh | 19:21 |
| hatch | gotcha | 19:21 |
| rick_h | grouped with the non-private methods alphabetically | 19:21 |
| hatch | rick_h: just typing out the lgtm, did you want me to create a card for the hash-no-dispatchy ? | 19:30 |
| rick_h | hatch: sure thing, thanks | 19:31 |
| * Makyo de-net-problems. | 19:32 | |
| hatch | rick_h: letr-rip | 19:33 |
| hatch | Makyo: .NET? | 19:33 |
| hatch | :) | 19:33 |
| hatch | rick_h: I tagged the bug charmbrowser because of the approach I think we should take to resolve it not because of the cause just FYI | 19:34 |
| Makyo | Pff. | 19:34 |
| rick_h | hatch: all good | 19:34 |
| hatch | now I have to figure out how to propose huw's branch to the same reitveld | 19:35 |
| rick_h | gary_poster: so landing this now. I'm not sure what the release schedule and such is for things right now. | 19:35 |
| rick_h | hatch: don't. I just push to my branches and re-submit it | 19:35 |
| rick_h | then in the comments link/note the original reitveld for tracking purposes | 19:35 |
| hatch | ahh ok | 19:36 |
| rick_h | because reitveld is per google account you can't update his | 19:36 |
| hatch | ahh unfortunate | 19:36 |
| hatch | but understandable | 19:36 |
| rick_h | yea, we tested a way to try to use group owned branches in LP but still fell short. | 19:36 |
| gary_poster | rick_h, planning on wednesday. minimally we want this, we want Kapil's export branch, and we need benji's charm cache fix. everything else is gravy | 19:36 |
| rick_h | gary_poster: ok cool then. | 19:36 |
| gary_poster | benji, have you been able to dupe? | 19:37 |
| benji | gary_poster: not yet | 19:37 |
| benji | are there any more details about the problem somewhere? | 19:37 |
| benji | I didn't see a bug linked to the card. | 19:37 |
| gary_poster | benji, :-( boo hoo. when you can let me know and I will be happy, because I bet a solution will not be far behind. Did you start with 0.8.0 and then go to 0.8.1? no bug, want to chat in 10 minutes? | 19:38 |
| benji | gary_poster: chat in 10 sounds good | 19:38 |
| gary_poster | cool talk to you soon | 19:38 |
| hatch | shadowrun returns is now available on steam http://store.steampowered.com/app/234650/ but no Linux unfortunately | 19:39 |
| hatch | I'll probably be picking up Expeditions: Conquistador tonight though http://store.steampowered.com/app/237430 | 19:40 |
| hatch | which is avail for all 3 platforms | 19:40 |
| bcsaller | hatch: dota2 ;) | 19:41 |
| hatch | oh crud I didn't think it was avail for Linux | 19:42 |
| hatch | did you pick it up? | 19:42 |
| hatch | free to play eh | 19:42 |
| * hatch is skeptical | 19:42 | |
| hatch | :) | 19:42 |
| hatch | bcsaller: can you review https://codereview.appspot.com/12054043/ (it's Huws with the mods we discussed) | 19:46 |
| bcsaller | hatch: yes, I'll start shortly | 19:54 |
| hatch | thank yas | 19:54 |
| hatch | gary_poster: is there anything specific you would like me to jump on now? | 19:55 |
| gary_poster | hatch, hi. mm...no. I have been adding cards on board. any of those are good. hook up retry/resolve/replace? fix small issues I identify in ghost inspector? | 19:59 |
| gary_poster | hatch, hideous yellow cards are kind of mini-story markers that have sub-cards following them | 20:00 |
| gary_poster | benji, come on by guichat? | 20:00 |
| benji | sure | 20:00 |
| gary_poster | hatch do you need another review of Huw's baranch or are you good to go | 20:01 |
| hatch | ahh ok, nope, I reviewed his so one more should be fine | 20:02 |
| hatch | my changes were fairly small but somewhat of a refactor | 20:02 |
| === schwuk_away is now known as schwuk | ||
| hatch | gary_poster: you say those ugly yellow ones have sub-cards....am I totally missing how to view those cards from the ugly-yellow ones? | 20:11 |
| hatch | or are you just using the title as the 'marker' | 20:12 |
| hatch | I think I'll work on the ghost inspector | 20:13 |
| hatch | bcsaller: replies made | 20:20 |
| gary_poster | benji #1206260 | 20:31 |
| _mup_ | Bug #1206260: GUI charm does not handle browser cache properly <juju-gui:In Progress by benji> <https://launchpad.net/bugs/1206260> | 20:31 |
| benji | thanks | 20:31 |
| gary_poster | welcome | 20:31 |
| gary_poster | on kanban too | 20:31 |
| gary_poster | hatch, sorry, ugly yellow card is supposed to precede associated cards, going left to right, top to bottom | 20:32 |
| hatch | ahh got it | 20:32 |
| hatch | bzr diff | vim - has changed my life | 20:42 |
| hatch | yay for sprints | 20:42 |
| hatch | lol | 20:42 |
| gary_poster | heh | 20:42 |
| gary_poster | Makyo big +1 on the thrust of your flags-cleanup branch. I guess you decided to postpone the post-test flag cleanup to another day? | 20:44 |
| gary_poster | (because your branch exposes some tests for not being very hygenic with their flags | 20:44 |
| gary_poster | ) | 20:44 |
| Makyo | gary_poster, yeah, I just want a direction to aim in, for the most part. | 20:44 |
| Makyo | Running into LP problems, reproposing. | 20:45 |
| gary_poster | Makyo, cool. direction is good. I don't think you'll have any detractors. | 20:45 |
| hatch | Makyo: so this is a codereview for discussion not to land? | 20:45 |
| Makyo | hatch, to land, as an incremental step. | 20:46 |
| hatch | bcsaller: because codereview is slow - if fillslot is a impl detail under showviewlet then it should be _fillSlot :) | 20:46 |
| Makyo | LP fixed itself \o/ | 20:46 |
| gary_poster | heh | 20:46 |
| bcsaller | hatch: I'm fine with that | 20:47 |
| hatch | bcsaller: I'm re-proposing right now with the test fixed and other code left the same - but we can definitely open up discussion later on | 20:47 |
| hatch | or in a follow-up? | 20:47 |
| bcsaller | yes, later is fine for the rest, the slots change doesn't belong in that branch at all and was just a possible cleanup | 20:47 |
| hatch | alright - it's updated now | 20:48 |
| sinzui | jujugui, orangesquad. http://staging.jujucharms.com is coming up. | 20:50 |
| bac | yay | 20:50 |
| jcsackett | sinzui: hoo-ray | 20:50 |
| gary_poster | great sinzui! is there anything we need to know to be able to have healthy use of canonistack for jujugui jenkins tests? | 20:51 |
| sinzui | jujugui, orangesquad. anyone who wants to access the server will need to update their .ssh/config per the new lcy02 rules | 20:51 |
| gary_poster | sinzui, ah! ok thanks. we will need to do that fo jujugui then | 20:51 |
| hatch | icy what? | 20:52 |
| hatch | :) | 20:52 |
| gary_poster | do you have alink for those, sinzui? | 20:52 |
| bac | sinzui: if using sshebang it should just work | 20:52 |
| bac | well, after pulling new one | 20:52 |
| sinzui | bac, sshbang destroyed by last config I wont be using it. | 20:53 |
| sinzui | It was easier to past the rule into my config. | 20:53 |
| sinzui | https://pastebin.canonical.com/95172/ | 20:53 |
| hatch | ugh I can't get our make to use the npm cache on osx | 20:53 |
| bac | sinzui: i have heard such stories. i've been lucky, i guess (and backed up my config dir first) | 20:54 |
| sinzui | Now I will return to nrpe in juju-gui. I am diligently avoiding the many levels of indirection used by other charms to make it work in prodstack | 20:55 |
| sinzui | gary_poster, ^ my pastbin link was all that I need. just change the YOU part | 20:57 |
| === schwuk is now known as schwuk_away | ||
| hatch | are the canonistack docs going to be updated with these details? | 20:57 |
| hatch | s/docs/wiki | 20:57 |
| gary_poster | thank you sinzui! | 20:57 |
| hatch | benji: where did you happen to find the docs for npm install --cache-min ? | 21:00 |
| * bac walks dog. returns a sweaty mess. | 21:00 | |
| benji | hatch: https://npmjs.org/doc/config.html | 21:01 |
| hatch | benji: so since it's no longer there am I to assume that it's no longer supported? | 21:02 |
| benji | hatch: could be | 21:03 |
| gary_poster | Makyo, LGTM with a lot of small-ish repetitive comments and requests | 21:03 |
| hatch | benji: I'm just asking because on my desktop it doesn't appear to be working | 21:03 |
| benji | it would be unfortunate for them to have removed it; maybe there is another way to achieve the same effect | 21:04 |
| gary_poster | hatch how much work is #1206239? deciding how to triage | 21:04 |
| _mup_ | Bug #1206239: Router does not dispatch url hash changes <charmbrowser> <juju-gui:New> <https://launchpad.net/bugs/1206239> | 21:04 |
| hatch | gary_poster: TWAG 1-1.5day | 21:05 |
| gary_poster | ack thanks hatch | 21:05 |
| Makyo | gary_poster, I don't necessarily see your point about before/after vs. after/afterEach. Is the concern that the tests may modify flags? Judging by the tests we have, an entire suite would need the flags. However, I'm a solid 0 on that, so I can go ahead and move them to the *Each methods if you want :) | 21:06 |
| hatch | benji: found it https://npmjs.org/doc/misc/npm-config.html#cache-min :) | 21:06 |
| benji | good | 21:07 |
| hatch | doesn't explain why it doesn't work haha | 21:07 |
| gary_poster | Makyo, as a general rule, we want test isolation, not test suite isolation. so, yes, in many cases, it seems tests are modifying flags. That's step one in my argument: we actually need it there in some cases. A second step is that this is the most paranoid, and the most likely-to-be-correct, place to reset flags generally. The last step in my argument is that I'd rather have us follow the same rule every time, s | 21:11 |
| gary_poster | o we get in a good habit. | 21:11 |
| Makyo | gary_poster, thus the disagreement with me removing the resetting flags in suites where neither the suite nor the code touch flags? If that's the case, then -1 on setting window.flags to {} in index.html - it's pointless and offers a false sense of security. | 21:12 |
| gary_poster | Makyo, it never had any security. I thought you were doing it so that tests read better, basically. | 21:13 |
| Makyo | That does raise the question of when should we ever use before/after, but maybe that's a debate for another day :) | 21:13 |
| gary_poster | Makyo, if the suite never touches flags, then that's just legacy | 21:13 |
| gary_poster | fine with removing that | 21:13 |
| gary_poster | if that's what some of those, were, sorry for the misunderstanding | 21:14 |
| Makyo | gary_poster, misleading, then. Putting it there gives a new test author the false sense of security that window.flags will always equal {} rather than undefined. | 21:14 |
| gary_poster | ah. | 21:14 |
| gary_poster | mm | 21:14 |
| Makyo | gary_poster, they were legacy, yes, but it just sounds like we're arguing for putting that in every suite's *Each. | 21:14 |
| gary_poster | Makyo, only if they use flags | 21:14 |
| gary_poster | I'm not worried about it otherwise | 21:15 |
| Makyo | gary_poster, Alright, sounds good! The legacy ones will remain, but the others will be moved to *Each methods. That closer to what you were asking? | 21:15 |
| Makyo | Sorry. Rephrase.. | 21:15 |
| Makyo | The diff on the legacy ones will remain: suites that don't use flags will no longer reference flags. | 21:15 |
| gary_poster | yes, +1 | 21:16 |
| Makyo | Cool, on it. | 21:16 |
| gary_poster | cool thanks Makyo | 21:16 |
| * gary_poster running | 21:16 | |
| gary_poster | ttyl, guys! have a great evening! | 21:16 |
| hatch | you too | 21:17 |
| hatch | *when lbox fails AFTER lbox.check* | 22:15 |
| hatch | arg! | 22:18 |
| hatch | 3rd time is the charm | 22:19 |
| hatch | jujugui looking for some reviews on http://bazaar.launchpad.net/~hatch/juju-gui/remove-extra-buttons/revision/907 the codereview link is https://codereview.appspot.com/12071043 but it doesn't appear to have any diff | 22:30 |
| hatch | jujugui ok the diff has appeared on https://codereview.appspot.com/12071043 for review | 22:33 |
| huwshimi | Morning | 22:58 |
| hatch | hey huwshimi, got a few things for ya | 23:10 |
| hatch | s/things/tasks :) | 23:11 |
| huwshimi | hatch: Hey | 23:11 |
| hatch | huwshimi: I landed your branch with a few changes https://codereview.appspot.com/12054043 | 23:11 |
| hatch | in the description there are a couple outstanding issues | 23:11 |
| hatch | I gota run for about an hour or so. I can answer any q's you have about those issues when I get back | 23:13 |
| huwshimi | hatch: Thanks, just taking a look | 23:13 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!