[00:37] gary_poster: Are you around? [00:37] huwshimi, unfortunately :-P [00:37] not for your sake, for the sake of staring at my branch :-) [00:38] :) [01:17] hey hatch, if you are around could you give https://codereview.appspot.com/12306043 a once over? I'm going to ask Francesco to review, land, qa and release the gui his tomorrow morning. then I'll ask benji and curtis to coordinate testing the charm upgrade and the GUI upgrade. [01:42] email sent [01:43] I'm outta here. Bye all. I'll check email occasionally === gary_poster is now known as gary_poster|away [05:31] gary_poster|away: sorry I was out - I'll give it a review now. cya! [10:57] frankban: seen the emails. If there's anything I can help with please let me know. [10:59] rick_h: thank you. I just landed a branch that should fix the service menu bug. I am going to QA now for the release, more QA eyes can help [10:59] frankban: rgr, will pull it down. [11:20] rick_h: everything seems to work here, except for a bug also present in the current release: destroying a service from the service detail view does not work [11:21] frankban: hmm, works here. That's the popup menu when you click on a service? [11:22] frankban: ah, I see, when you click on it in details. My bad [11:22] rick_h: no, double click a service, and then click the destroy button, yes [11:22] yea, the "are you sure" dialog pops up and the immediately closes [11:23] rick_h: exactly, I don't think this is a release blocker [11:24] ok, I'll file a bug for the moment on that then. Looking into the reason right now [11:24] rick_h: cool, please ping me if you think there is a really quick solution for the problem [11:25] frankban: yea, it's showing as -hidden so something in the code is running a .hide(). I'm not familiar with the detail view. Will go with a bug for now if it's not a blocker. [11:25] rick_h: I assume it's not a blocker b/c it's not a new bug [11:26] ah, interesting. I'd agree then. And there's a workaround to destroy from the service icon [11:33] frankban: one line fix [11:34] rick_h: great! [11:34] frankban: http://paste.mitechie.com/show/986/ [11:34] frankban: can you apply please? My trunk is a little messed up due to an accidental commit to trunk and I need to clean it up [11:35] rick_h: sure, thank you [11:38] rick_h: charmbrowser QA seems great to me, could you please confirm? [11:39] frankban: yes, I've not been able to break it. +1 [11:40] rick_h: do you have time to write a quick changelog for this release, so that I can put that in the changes.yaml file? if not, no worries. [11:41] frankban: sec. /me looks [11:41] frankban: should just be able to go through the releasable cards right? [11:42] rick_h: yes, or here: http://bazaar.launchpad.net/~juju-gui/juju-gui/trunk/changes [11:42] frankban: k, working on it [11:42] rick_h: thanks [11:45] frankban: http://paste.mitechie.com/show/987/ I think works going at it a little quickly. Rest of the cards are charmworld or not really 'changelog' items [11:47] rick_h: nice, thanks! [11:57] frankban: how goes the release? [11:58] benji: QA is done. Now starting the release process. I am also running the CI tests, just in case. [11:58] cool [12:16] benji: are you going to work on the iom demo today? i've created cards and reference the google doc. [12:17] bac: I have some availability, but my main priority is upgrading the charm. I should have some time but I don't know for how long. [12:17] I'll help any way I can. [12:18] benji: ok, i didn't know how far you'd gotten on the charm [12:18] it is ready to go; I'm waiting on the release now [12:19] well, my changes are ready to merge, that's what I'm doing now [12:37] * bac loves the yaml. deployer example config had one line missing an indentation space and it went nuts. [12:39] yeah, significant whitespace will never catch on [12:39] hey, that's different! :) [12:40] benji: and the py interpreter gives a better error message than 'expected key missing' [12:40] there is that; I guess every good idea can be done badly [12:55] guihelp: CI tests fail during the charm installation :-/ (make distfile): http://pastebin.ubuntu.com/5939960/ [13:04] guihelp: I assume there is an error in deploying the charm using a branch as juju-gui-source? Should we consider this a release blocker? [13:05] frankban: uhm, no idea [13:06] frankban: I am not aware of that bug (but I haven't tried it recently either) [13:11] abentley: could you have a look at this mp? https://code.launchpad.net/~adeuring/charmworld/1206158-dl-count-by-week-half-year/+merge/178265 [13:11] adeuring: sure. [13:15] adeuring: r=me. [13:16] benji: I am trying to dupe using juju-core. I'll also check if this is a regression introduced after the last stable release. If so, I don't think we should go on, otherwise, I'll proceed with the release. Sounds good? [13:16] frankban: hmm, I just did a fresh checkout/build and didn't hit that. [13:16] rick_h: yeah. Build works locally here too. What nodejs version are you using? [13:16] frankban: 0.10.8 [13:17] frankban: sounds good; note that I merged my changes to juju-gui-charmers trunk within the last hour so it is possible that I caused any problems with those changes (but I don't see how) [13:17] benji: gary_poster's branch yesterday updated a npm file with a bunch of 'mechanical' looking changes [13:17] I wonder if anything in there wasn't good [13:17] abentley: thanks [13:18] benji: CI uses cs:~juju-gui/precise/juju-gui . That's a different charm, right? [13:19] bac, benji: Can we do a hangout on bundles? [13:19] frankban: I don't know exactly how it works, but my understanding is that the juju-gui-charmers trunk is the source for the official gui charm. My understanding is that within 15-20 minutes of landing to trunk the new charm should be in force [13:20] frankban: looking at https://codereview.appspot.com/12306043/patch/1/1004 some of the grunt items were version updated? contextify was updated from 0.1.5 to 0.1.6 [13:20] abentley: sure [13:20] abentley: I'm consumed with release things at the moment [13:20] rick_h: I have v0.10.5 locally. The charm (precise) installs v0.8.23. Perhaps this is relevant? [13:20] frankban: ouch! [13:20] frankban: yea, that's not good if it's that far behind. [13:20] yeah, I guessed so :-/ [13:21] doesn't hacking still require going through a nodejs ppa? [13:21] I would have expected the charm to also pull the sudo add-apt-repository ppa:chris-lea/node.js ppa [13:21] ? [13:22] as it's what we dev against [13:22] sinzui: around? did IS change/frown on this? [13:23] rick_h, that wont work [13:23] rick_h: IS generally want to use only things in the main archive or the precise-cat archive (or whatever series is appropriate). [13:24] frankban: I'm going to guess we've got bigger issues then. I'm not sure how we released before tbh with a 0.8 nodejs [13:24] rick_h, frankban. I think all packages need to be installed in "cat" which is mad available via the exec.d hack [13:24] rick_h: this can be a very old regression [13:24] we need an rt to place a package in cat. [13:25] PS there is 1 webops today. He has 2.5h before EOD. I hope to monopolise him to move charmworld's mongodb [13:26] rick_h: I believe the charm takes npm from https://launchpad.net/~juju-gui-charmers/+archive/stable [13:26] ugh, friday release fail [13:27] s/npm/nodejs/ [13:27] frankban: oh hmm, and that's an old release from that ppa it appears. [13:27] frankban: so yea, I've no idea how this works I guess :/ We're running 2 large versions ahead in dev, just updated the revisions of some deps, and things went boom on production. [13:27] frankban, rick_h, webops make fat charms. they don't deploy the ones we give them. The can update their scripts to pull a branch of need dep, then add it to the charm. [13:28] sinzui: well at this point I'm confused. If we've been running an old version for a known reason for a while then I don't want to suggest updating it [13:28] I'm guessing we're on 0.8 for a reason then? However, it seems devs are all on 0.10 [13:28] yes [13:28] I know hatch has tinkered with nodejs versions so we'll bug him [13:28] ...starting now [13:29] lol [13:29] sinzui, rick_h: I also believe webops deploy from releases. This bug only affects deployment using branches (e.g. juju-gui-source=lp:..). node/npm are only required to create releases from branches. [13:29] frankban, correct [13:29] frankban: ah, that's what you mean by 'old regression' then? Maybe deployment from branches has had issues for a while but only now seeing? [13:30] reading backlog [13:30] rick_h, My branch is lp:~ya-bo-ng/juju-gui/typography-charm-details [13:30] rick_h: exactly, especially considering the functional test in the charm uses a fake branch [13:30] frankban: is g++ installed? [13:30] rick_h, the webops script retrieves the tarball from lp and places it in the charm, [13:30] frankban: k, then I guess it sounds like it's a non-blocker if we can get a release build? [13:31] antdillon: thanks, I'll create a card on the board for it and try to get some eyeballs on it after we get teh release issues worked through . [13:32] rick_h: yes, that's what I am checking with juju-core. Even like that, I am nervous making a release without being able to run the CI tests (and they are broken in canonistack for quite a while) [13:32] rick_h, Awesome thank you! [13:32] frankban: yes, agreed there [13:32] rick_h: g++? is that a new requirement for the charm? [13:32] sorry, hatch ^^^ [13:32] frankban: yes [13:33] I'm not sure why though [13:33] I just know that gary had an issue attempting to deploy when it wasn't installed [13:33] http://nooooooooooooooo.com/ [13:33] lol [13:34] npm dep requiring c-speedups? w..t..f [13:34] there is no mention of g++ in the charm sources, nor in our ppa (https://launchpad.net/~juju-gui-charmers/+archive/stable) [13:35] can't we just add apt-get install g++ ? [13:35] to see if that fixes it? [13:36] I suppose we can [13:36] * rick_h runs and gets more coffee... [13:36] I can't look [13:38] hmm I think this shrinkwrap is busted [13:38] it's changed a ton of versions [13:42] on trunk I can no longer run make [13:42] make: *** No rule to make target `app/assets/javascripts/d3.v2.js', needed by `build-shared/juju-ui/assets/modules.js'. Stop. [13:43] d3.v2 was removed.... [13:45] hatch: make clean [13:45] hatch: we switched to d3 v3 [13:45] yeah... I did a fresh checkout [13:45] hoping that fixes it [13:45] yeah must have had something hanging around [13:46] frankban: is it attempting to build now with g++? [13:47] * benji reboots [13:48] sinzui: staging.jujucharms.com is broken when trying to view a specific charm [13:48] sinzui: can i get login access to staging? [13:48] hatch: right now I am trying to understand what revision introduced this regression. rick_h: this is not an old bug, juju set -e go juju-gui juju-gui-source=lp:juju-gui:897 worked well [13:49] bac, sure. It is just a special nova file to source [13:49] frankban: I'd assume it was gary's branch that changed the shinkwrap.json? [13:49] sinzui: i noticed staging was dead after i pushed my bundle branch. sadly i didn't check it before so i don't know if that is the culprit [13:50] bac. mongo is angry [13:50] OperationFailure: !loc.isNull() [13:50] rick_h: I am testing revision 917. then I will go with 918, which is Gary's branches I merged this morning. [13:50] abentley: seems that the mongodb on staging is badly broken. Try to access any charm deital page... [13:50] File "/home/webops_deploy/charmworld/local/lib/python2.7/site-packages/pymongo/mongo_client.py", line 789, in __check_response_to_last_error [13:50] raise OperationFailure(details["err"]) [13:50] OperationFailure: !loc.isNull() [13:50] frankban: rgr [13:51] "Friday, never hesitate..." [13:51] adeuring: looking. [13:52] frankban: I thought it was "Friday, never again"? [13:52] oh well [13:52] sinzui: adeuring says staging mongodb is badly broken. I am investigating. [13:53] abentley, well that is bad, because I switched it last night [13:53] sinzui: Right. [13:53] and production switched 10 minutes ago [13:53] sinzui: it has a relation error. [13:53] rick_h: 917 fails with the same error. That's not Gary's branch [13:53] * sinzui not see that [13:54] ah, yes I do see that [13:54] * rick_h goes to look at 917 [13:54] * rick_h looks at hatch [13:54] abentley: not sure if you saw my message, but this seems to have happened after i pushed a bundle branch to launchpad. [13:55] abentley: trying to ingest locally i get http://paste.ubuntu.com/5940134/ [13:55] ha-ha, hatch broke the world ;-) [13:55] frankban: ok, so something between 897 and 917? [13:55] rick_h: yes, trying to re-run the config-changed hook after installing g++ [13:55] bac: Weren't we going to test locally before pushing? [13:55] frankban: can you try 915? I wonder if the scss stuff which broke some things is still there [13:56] (sorry hatch, just teasing you :-) ) [13:56] frankban: I wonder if there's more deps than just the scss package still in the npm file that won't work. [13:56] sinzui: well, managae.jujucharms.com does not seem to be affected: http://manage.jujucharms.com/charms/precise/apache2 works,m while http://staging.jujucharms.com/charms/precise/apache2 fails [13:56] abentley: we talked about testing the deployer file against the deployer locally, which i did, but not about ingesting a local file. once it was pushed on LP staging found it. [13:57] adeuring, agreed. the staging errors do not appear until 5 hours ago. We have seen this happen 3 weeks ago [13:57] * sinzui off to present [13:57] bac: I thought getting a working deployer file was my responsibility. [13:57] abentley: if the staging errors happened 5 hours ago then it isn't related [13:58] frankban: let me know if adding g++ fixes [13:58] sinzui: I believe the error is due to a stale charm-- it's running scripts/worker, which was supplanted by ingest-queued. [13:58] abentley: afaik, we never assigned tasks until this morning when i made kanban cards. i sent a message here about it. [13:58] abentley, oh dear. [13:59] orangesquad: per https://docs.google.com/a/canonical.com/document/d/1AoMhTdrominYLBS8iHbZLW_Ji2OH3mNhUzoHjetnD9w/edit , you can see I ran /srv/deploymgr/charmworld restart [14:00] ^ I left a copy of all the commands run [14:01] hatch: sure. rick_h: I'll try 915 later. Anyway, the real bug here is that our devenvs and our production env are really different [14:01] frankban: +1, I'll add a discuss card I guess. [14:01] rick_h: the reason for the shrinkwrap updates is because those modules specify loose deps so when shrinkwrap was re-run it updated those loose versioned deps [14:01] rick_h: yes, please, thanks [14:02] hatch: yea, gotcha. just trying to find something that 'changed' recenly and that's hitting close to home [14:02] only other recent npm change I can think of is the scss work [14:03] well node-gyp requires gcc and g++ on OSX so I'm going to assume that it's also missing on 12.04 [14:03] and for some reason it's exposed itself now... [14:04] so what needs node-gyp [14:04] yea, node-gyp is a native build tool, so something wants to build a native package compiling on the target. Why do we need that now all of a sudden? [14:05] one theory is that it included a bin in contextify@0.1.5 but removed in 0.1.6 [14:05] but that's all I got [14:05] :) [14:05] bac: I have concerns that we may not be adequately filtering out bundles for API 2 that I wanted to discuss before pushing a bundle. [14:06] abentley: shall i delete the branch? [14:06] rick_h: also the reason we are using node sass and not pysass is because the node stuff is automatically hooked up to our watch system [14:06] where the python stuff isn't [14:06] bac: if it's older than 15 minutes, it doesn't matter. [14:07] abentley: let's talk when you get a chance [14:09] grrr, I can't find anything that 'deps' on node-gyp. Just that it's installed globally and deps on npm [14:09] bac: sure. [14:10] hatch: ok, yuea. It's in the contextify build [14:11] cool I was right [14:11] lol [14:11] my hypothesis has now been confirmed [14:11] benji, hatch, rick_h : installing g++ seems to fix the problem, I'll add the dependency in the charmers charm, then I'll merge the charmers charm into our juju-gui charm, and then I'll try CI again... [14:11] * hatch waits for his interviews [14:11] frankban: sorry about my timezone, I could have told you that sooner ;) [14:12] frankban: I'm glad you figured it out. Do be careful with the merge. It is my understanding that the charmers charm is old an disused. [14:12] sinzui: The charm is not stale; the "scripts/ingest" script is broken. [14:12] sinzui: Other methods of ingesting should work. [14:13] hatch: we encountered this problem right before you arrived. We spent the Friday morning fixing other things, so do not excuse yourself for being in Canada [14:13] lol [14:13] hatch: ok, so that's the d3 update [14:13] hatch: d3 requires jsom which requires contextify [14:14] frankban: so it all comes down to our d3 upgrade which was recent and probably broke it [14:15] rick_h: yes, it seems so, double checking with CI [14:15] this is my biggest gripe with node/npm [14:15] hatch: so that would explain why gary ran into the issue [14:15] packages are like the wild friggen west [14:15] where we're going - we don't NEEED stability [14:16] hatch: well, you'd expect that to be in giant letters in a changelog or something for going from 2-3. That's a big req change [14:16] that's what I mean [14:16] authors update deps with no testing [14:16] then claim it works with every version of node by using the > [14:17] npm is awesome - but I think it needs less features to restrict people to do the right thing [14:17] sooooo many packages broke when 0.10 came out simply because they said they worked in >=0.8.x [14:18] everyone fights it though. Even python/pypi just recently stopped serving beta/alpha packages out as the most recent package by default. [14:18] hah, yea when you know that anything > 0.8 would be an api break. It's the point of using big version numbers [14:19] right [14:20] so many people in the community release things using 0.x forever [14:20] things never hit 1.0 release [14:20] I think it's so they don't have to provide a stable product lol [14:21] meh, just ignore the 0. 0.7 to 0.8 to 0.10 == breaks [14:21] benji: charms updated (fix added to charmers, and then merged charmers into juju-gui) [14:21] awesome [14:21] rick_h: rumor has it 0.12 will be 1.0 so we can hope :) [14:22] hatch: fine, then 1.0 to 1.1 will break :P [14:22] frankban: great! let me know when the GUI release is done [14:22] benji: I'll let you know IF the release will be done [14:22] rick_h: nope it's a 1.0 release, no api breaking changes allowed! [14:22] frankban: lol [14:23] be optomistic :) [14:23] heh, I guess that will work too [14:23] optimistic even [14:23] I really need to get an irc client with spell check [14:24] jujugui looking for a second person to help review/qa antdillon's changes https://codereview.appspot.com/12343044 [14:25] rick_h: I'll take a look [14:25] thanks benji [14:25] benji, rick_h Thank you [14:25] sinzui: Could you please review https://code.launchpad.net/~abentley/charmworld/ingest-uses-ingest-queued/+merge/178310 ? [14:26] what's going on with the typography.less file? [14:26] the type class name has no relation to the contents within it [14:26] rick_h, antdillon: I don't see a diff, only "error: old chunk mismatch" [14:26] bac: Let's chat. [14:26] benji: hmm, working for me :/ [14:26] benji, Working for me [14:27] hmm [14:27] abentley, r=me [14:27] benji, This not working? https://codereview.appspot.com/12343044/patch/1/1005 [14:28] rick_h, antdillon: apparently only the side-by-side diffs are broken; the stright-up diffs are fine; I'll look at those [14:29] benji: ah, reitveld fail [14:29] apparently [14:30] rick_h: frankban on my tasklist is to attempt to update our packages and node to be up to date next week (re your card in discuss) [14:30] hatch: yea, but the larger issue is more the diff in dev vs production [14:30] we should have hit this issue when d3 was upgraded, not a week later during a deploy attempt [14:31] oh well prod will then need to be updated as it'll fall over hard :) [14:31] hatch: and it sounds like this g++ issue was hit, but not brought up. [14:32] hatch: cool, thanks [14:33] somehow I ended up working on two branches at once [14:34] abentley: ok, can you set up a hangout? i need to move rooms. [14:36] bac: https://plus.google.com/hangouts/_/b3e9170262ba4b41f761dee440dcbb9ac111cf3d?hl=en-GB [14:48] antdillon: landing your branch. It won't be in the release today, but will be on comingsoon later today. [14:51] guihelp: http://pastebin.ubuntu.com/5940316/ I presume this only means that the unit tests in ie are particularly slow... Please confirm my impression [14:52] rick_h: please don't land GUI branches [14:53] frankban: :/ sorry. Figured it was -r locked. It just completed [14:53] rick_h: no worries. Does antdillon change need to be QA'd? [14:53] frankban: as to the test run, yea it says they passed, there's the skipped. Not sure why it said it can't complete. [14:53] rick_h, Cool thanks [14:54] frankban: no, it was qa'd as part of review. Small css font changes to the browser [14:54] rick_h, antdillon: so it will be included in the release. guihelp: please don't land GUI branches [14:55] frankban: yes we have a number of unit tests which are skipped - they shouldn't be causing it to be incomplete though [14:55] bac: The URL structure is http://manage.jujucharms.com/api/3/bundle/~sinzui/mysql-5/tiny as described here: https://docs.google.com/a/canonical.com/document/d/1H1PH0q9Mr8pSvTmRnEgptrlC-OQZK7i-Le-1SzpJG5Y/edit [14:56] hatch: that can be a problem in CI tests, but it does not block the release. unit tests passed in firefox [14:56] ok great [14:57] I have huw's branch to land so let me know when it's ok :) [14:58] sinzui: r325 and later should not be deployed to production. [14:59] abentley, understood. Since webops are off in 1h and I am away next week. I think we have little opportunity to shoot ourselves in the foot [15:03] sinzui: Tarmac is no longer setting the revno of charmworld after landing. The value is currently -1. Suspect it's related to the lcy02 changes. diogo isn't around. [15:03] call today? Maybe it is at 11 since we'll not be doing a retrospective since Gary is out. [15:03] benji: I was thinking at 10 [15:03] in 1h [15:03] just the standup [15:04] the retro was yesterday [15:04] :) [15:04] cool, 11 it is ;P [15:04] haha [15:04] damn it abentley. I swear that lazy service goes on holiday every time Diogo takes off work [15:05] abentley, surely tarmac needs it ssh config changed [15:05] sinzui: Yes, I expect that's the problem. [15:09] rick_h: do you use vim in multiple terminal panels (using tmux or the like) or use some vim pane manager? [15:10] hatch: I use a tiling window manager + vim [15:10] tmux and such is just gravy and kept seperate [15:10] hatch: vim comes with 'pane managers' called splits. http://lococast.net/archives/111 [15:10] and buffers really [15:11] we do charm schools with both vim and tmux splits [15:12] right now I work in tmux splits but each window is it's own terminal so I always forget to add my ssh key or osmething to one [15:12] which just irritates me heh [15:12] so that's why I was wondering :) [15:12] hatch: use an ssh-agent [15:12] hatch: then you init your ssh key on boot and never worry about it again [15:12] there is some wakoness to osx > ubuntu sshing [15:13] I have to run `exec ssh-agent bash` every time [15:13] http://fromanegg.com/post/45733384142/nfs-between-ubuntu-vm-and-osx-host [15:13] https://help.github.com/articles/working-with-ssh-key-passphrases says that on OSX they can be saved in the keychain [15:14] it's not the passphrase [15:14] it's that the env variables for ssh-agent don't exist [15:14] I haven't spent the time to track that down [15:14] but I'd need to run some auto commands from tmux to fix [15:14] or something [15:14] bac: I've done everything I can do and am in a holding pattern at the moment; is there anything I can do for you? [15:15] jujugui lf one review of https://codereview.appspot.com/12320044/ re-propose of huws branch with minor change [15:15] hatch: on it [15:15] benji: quick chat? [15:15] thanks benji [15:15] bac: sure [15:15] guichat? [15:21] frankban: can I merge into trunk yet? [15:21] hatch: no [15:21] ccccmmmmoooooooonnnnnnn [15:22] ;) [15:22] guihelp, please do not land GUI branches, I'll ping you later [15:23] frankban: is there anything I can help with? [15:24] hatch: not at the moment, thanks [15:25] alright well let me know if you run into something that needs another set of hands [15:33] guihelp: juju-gui 0.8.2 released \o/ Please feel free to restart landing branches. I'll live test it with juju-core. [15:34] yay [15:34] thanks a lot frankban you rock! [15:34] benji: release work done [15:34] jujugui - submitting branch [15:34] frankban: yay! thanks for bearing through all that [15:35] sinzui: so is there a chance of a jujucharms deploy or it sounds like nadda IS help available? [15:35] thank you for the help [15:35] frankban: great! I'll proceed with my work now. [15:35] rick_h, slim chance. .5 hours left [15:36] benji: ^ [15:36] in case that effects your work on the next step [15:36] sinzui: .5 hours left until what? [15:36] No webops [15:37] arg! [15:37] I'll see what I can do quickly [15:37] (without making things worse) [15:37] frankban: what is the release's version number? [15:37] I did 0.8.2 in the changelog [15:38] awesome, I was hoping it wasn't 0.9.0 :) [15:38] benji: 0.8.2 [15:38] that doesn't sound right, but we can argue about that when we have more time ;) [15:38] thanks [15:38] hatch: inspector should be 0.9 imo :) [15:40] yeah! [15:40] reliable CI should be 0.9 imho ;-) [15:40] lol!! [15:40] rick_h: I was also thinking a double bump to 0.10 ;) [15:40] haha [15:40] frankban: hah! what is that? [15:40] heh [15:41] sinzui: we are go for upgrade [15:42] benji, 0.8.2? [15:42] sinzui: yep [15:42] jujugui branch landed - anyone else is free to submit [15:51] jujugui guichat in 10 [15:51] kanban it up! [15:51] the anticipation grows [15:51] just wait [15:51] it'll be huge! [15:58] jujugui guichat in 2 [16:09] jujugui 0.8.2 is deployed [16:09] yay! [16:09] sinzui: rock on! [16:13] benji: http://hg.python.org/peps/rev/82e24ac40255 [16:13] * benji looks [16:13] rick_h: you can probably hold off on reviewing bcsaller's branch [16:13] hatch: ok [16:13] there is a QA failure [16:13] ha, great :( [16:13] hatch: ok, will ignore then. bcsaller ping when you're ready [16:14] * rick_h is just happy he finds the qa stuff in other people's branches too :P [16:14] haha [16:16] bcsaller: review and qa done - I'm guessing there is a merge issue from trunk or something [16:16] hatch: I can merge trunk and test it local [16:26] bcsaller: were you able to reproduce? [16:26] hatch: no, I have settings, thats working fine. The new branch throws the styles off though so the placement of the indicators is wrong now, cleaning that up [16:27] hmm [16:27] hatch: I did have to take trunks version of viewlet-manager.handlebars in the merge though [16:27] does bzr status show a conflict for you? [16:28] cleaned it out and trying again [16:32] rick_h: I'm still not happy with docstrings being 72 characters, but those changes dull most of the pain :) [16:33] benji: yea, I've not done that one myself. I don't think the pep8 tool complains [16:33] benji: but yea, I like that it's less of "pep8 encourages longer lines" and more "pep8 lets you be stupid if you want to be, but don't expect us to use it that way" [16:34] bcsaller: ok it all qa's fine now....sorry I must have broken something somehow [16:34] although the styling on the settings panel is a little broken for some reason [16:34] hatch: yeah, thats what I'm fixing now, thats a merge conflict [16:34] it really makes no sense to me, especially for the first line of a docstring which often has to be carefully constructed to convey what a funciton/method/class is about and still be less than 80 chars, now having to be even shorter will be highly irritating [16:35] plus, line wrapping tools have to be smarter because different chunks of the files have different rules [16:35] benji: yea [16:36] hatch, rick_h: latest jenkins failures seem different: now the tests are started, and there is the ie failure in unittests (added a card). so, it seems the charm fix (g++) has been relevant for CI. [16:37] frankban: looking, I honestly hit delete assuming it was more of the same [16:37] lol so did I [16:38] :D [16:38] oops [16:38] we are horrible [16:38] haha [16:41] hatch, rick_h: I believe CI was right and we ignored it pretending it was a canonistack failure. That confirms we are horrible people and that maybe we really need to switch to ec2 or hp... [16:42] haha [16:42] frankban: yea, I thought we were getting permission to go to ec2 for it [16:42] frankban: not sure where that dropped off [16:42] rick_h: frankban yeah EC2 is in the pipe but we need to figure out account details [16:42] whos gota pay yo! [17:07] for friday funnyness http://yuireactions.tumblr.com/post/55786097549/watching-yeti-run-unit-tests-chrome-safari [17:17] bcsaller: have a minute to guichat about these retry/replace/resolve buttons? [17:17] yes [17:17] ok heading to guichat === schwuk is now known as schwuk_away [17:30] bcsaller: I'm still curious about the setTimeout in inspector.js [17:37] rick_h: you can review now....everything looks merged in properly [17:37] hatch: bcsaller's branch? /me goes to look [17:37] yup [17:38] bcsaller: lgtm'd [17:47] hatch: bcsaller what was with the timeout? [17:48] bcsaller: no tests for this? [17:51] not sure [17:56] grabbing lunch [18:04] rick_h: hatch, sorry was out for a minute, the idea with the timeout was to remove the style after the transition has run, its supposed to display a background and then fade it out, after its gone I didn't want the style to remain on the node [18:05] I think properly a transition helper that binds the transitioned event as noted is proper [18:05] but I know other work is being thought about wrt animations [18:05] bcsaller: yea, I'm looking at the Y module for it to help catch the event. [18:05] bcsaller: but not gotten it all setup right atm. [18:06] rick_h: no, me either, I'm happy to look into a transition helper though [18:07] bcsaller: in that case can the animation be set with the style change? /me didn't qa since hatch was. Are the two classes incompatible? [18:07] jujugui, does anyone have time to review https://code.launchpad.net/~sinzui/charms/precise/juju-gui/nagios/+merge/177588 [18:08] rick_h: you add the class to trigger the transition, but I wanted the class off the node at the end, not sure I really understand the question though [18:09] bcsaller: so instead of using the class resolved, can the animation be between .conflict and without? [18:09] so that removing the .conflicted triggers the animation, I'm looking at the css closer trying ot see [18:17] bcsaller: is there any qa instructions to generate a conflict to look at this? [18:17] rick_h: on the CR/MP [18:17] console tricks [18:18] ah sorry got it [18:22] bcsaller: the instructions aren't working for me. I'm getting an error on line 324: Simulate a conflict from the console: [18:22] bah [18:23] Simulate a conflict from the console: [18:23] error is that the object has no method 'get' for getting the 'model' [18:23] rick_h: you deployed glance? [18:23] hmm [18:24] bcsaller: yea, trying again. I originally deployed ceph and then went back and added glance [18:24] rick_h: I think you hit the 'expose' bug, thats long standing [18:24] bcsaller: ah, yea I did touch that [18:24] ok, will start clean and go again [18:25] rick_h: yeah, those instructions modify service[0] with a key in glances config [18:25] I could change item(0) to getById('glance') but... [18:26] bcsaller: all good. working on it [18:28] bcsaller: I can't get the animation to go. It's when I select one value over the other right? [18:29] then the checkbox goes away and there's a background color animation? [18:29] rick_h: no, its not working properly :( [18:29] I tried a few things, but I didn't get it to work [18:30] bcsaller: ok, so should we pull that out then? [18:30] or did you want to give it a go to fix it before landing? [18:31] I could take one more pass at it. I sort of figured we'll get a better general answer to doing that type of thing in the near term [18:32] bcsaller: well, everything I've got going is specific per location of use [18:32] there's not really an "import animation...go" module coming from what I've gotten to work [18:33] maybe I'll take a stab at it then. node.transition('class', transitioned_cb) [18:34] the cb could be used to do chaining if needed [18:34] bcsaller: well I note using single classes and duping them up [18:34] what I had hoped to test was that if we could add the transition to the .xxx.conflict [18:34] and then when .conflict was removed it would animate the background change [18:34] but having a hard time setting it up/getting that tested. [18:35] yeah, I'll poke at it again and write some tests since the general UX seems ok to people at this point [18:36] basically use .conflict as a base css and then add a .pending .resolved or something to help with the tweaks. [18:37] you got me thinking, I think I have something that might work [18:40] bcsaller: cool, does this work for all field types as well? checkbox and such? [18:47] rick_h: input/text area are tested currently, haven't checked with checkboxes, I don't think we use them for config/constraints which is what this is for [18:48] bcsaller: ok, I know hatch had some stuff that dealt with boolean types and wanted to check if boolean config would come into play as a checkbox vs an input box for resolution UX [18:49] rick_h: I think that was the 'use defaults or not' toggle and isn't part of the databinding [18:49] bcsaller: so in mediawiki for example, there's a 'debug' setting that's a checkbox in the config [18:49] exposed is realtime, when you flip it, it sends the rpc and the delta will update it in place [18:49] * bcsaller checks [18:50] for me it says boolean -> false in the box, not a checkbox [18:50] bcsaller: ok, yea in the old UI it was a checkbox. [18:51] good line of questioning though [18:51] bcsaller: just checked it with the inspector and correct, there are only input boxes now. Hmm, so does that cast/work well? I'm wondering if that's a rabbit hole of 'FALSE' 'F', etc? [18:52] ugh, seems like a downgrade, but doesn't effect this then if everything's a text box. [18:52] looks like the template tries to do it properly with type=checkbox [18:52] so some untested regression maybe [18:53] and then I have to add support for this somehow [18:53] the other issue is that a textarea with tons of content will give a bad UX with this design [18:54] bcsaller: yea, was going to ask about a textarea next. :/ [18:54] I know we had some with the expanding textarea that were large config bits [18:55] bac: can you think of a good demo charm for a large bit of data in the config file? [18:55] yeah, and it should work as it does now, but no max height it set or overflow: scroll-y or anything like that [18:55] bcsaller: right [18:55] is it 'usable' I guess. [18:55] at least to start [18:56] the whole use case is pretty rare, so as a starting point I'm not that worried [18:56] right [18:57] ok, well I'm going to run away. Have a good weekend everyone. [18:58] bcsaller: mediawiki was a checkbox yesterday [18:58] heh [18:58] had* [18:58] yeah on comingsoon [18:58] too [18:59] areyou guys saying that's a text input now? [18:59] hatch: looks that way currently [18:59] BUG WARNING [19:00] :P [19:00] hatch: ahh I see [19:00] the ghost has it, the main doesn't [19:00] isBool handling or whatever isn't common [19:01] rick_h: haproxy was the charm that initially had the problem with multi-line settings input [19:02] bcsaller: ahh - they are using the same template so there is definitely a bug there somewhere [19:02] I see that it's not your branch though [19:02] filing bug [19:03] https://bugs.launchpad.net/juju-gui/+bug/1207870 [19:04] <_mup_> Bug #1207870: Boolean values aren't checkboxes on deployed services [19:04] bcsaller: I also noticed that the 'scale units' input value does not change as the simulator runs, known issue? (not caused by your branch) [19:18] that used to work, for a long time [19:19] sinzui: thanks for that list [19:19] hatch: I didn't know that no. sometimes I feel like our testing misses the mark [19:19] everything owned by charmers in precise is now README.md, I converted some from RST [19:19] I ignored personal branches and oneiric [19:19] bcsaller: sometimes? ;) [19:20] I was being nice [19:24] bcsaller: https://gist.github.com/hatched/0ef6c3898dab4e3e1626 - don't shate the DOM tree ;) [19:24] shake* [19:24] no I'm not going to leave it like that :D [19:26] hatch: no, thats bad, even an _nodes in there, ha [19:30] yeah I do what I can lol [20:07] bcsaller: so should the simulator be able to react to these env commands? [20:08] hatch: the simulator randomly sets unit agent states, it has nothing to do with resolving errors as hooks don't actually run in the sandbox [20:09] oh right - so should we hook it up to react to them? [20:10] its not the simulator that would matter. The result of resolved is just that the agent state should clear out of pending on core. So for example after the hook is retried the agent will update its state if it works [20:11] resolve, means I resolved this async to the UI (gui or cli) and I'm telling the agent to try to continue with new hooks [20:11] retry mean basically the same thing + run the hook that failed putting the unit into error [20:12] the states coming from the simulator don't mean anything and there are no transitions happening relative to a given unit [20:13] so the way to test this is to make sure that if I click on the button it ends up being sent to fakebackend [20:13] for testing purposes [20:15] orangesquad or benji or bac: Could you please review https://code.launchpad.net/~abentley/charmworld/polish-ingest-bundle/+merge/178376 ? [20:16] abentley: I'll take a look [20:33] benji: How's the review going? [20:33] abentley: sorry, I was talking to Brad about his branch. I'm looking though. [20:34] abentley: it looks good to me [20:35] benji: thanks. [20:43] bac, benji: I think bundle ingest might now be working. I'm pushing a bundle branch to find out. [20:43] cool [20:49] benji: this one? [20:49] this one works :) [20:49] abentley: turns out since the URL we're serving up on was /api/ we already had support from the work we did in raleigh [20:50] if you look in views/api.py there is a bundle() method. it isn't listed in routes [20:51] bac: Oh, and that gives the bundle text, not metadata? [20:52] abentley: it does now. :) [20:58] bac: the output is missing the outer mapping [20:58] bac: see http://paste.ubuntu.com/5941515/ [20:58] the first is the output from the app, the second was the input [20:59] benji: yeah i saw that [20:59] oh, and _id shouldn't be in the output [21:10] benji: trying the deployer on http://paste.ubuntu.com/5941555/ [21:11] benji: it seems happy. :) [21:11] yay! [21:12] do all the relations get added and everything? [21:13] benji: don't know yet. it ate the config without burping and is doing it's business now [21:13] benji: i think it parses it at the beginning so if it were going to be unhappy it would've complained early [21:14] may take about 30 minutes since i have to fetch the charms locally and then push to ec2 [21:14] yeah, I would think so [21:14] benji, abentley: i've updated my branch at lp:~bac/charmworld/jam-bundle [21:14] i suggest replicating what i've done with the canonistack instance [21:15] benji: we also need to get gary to run it beforehand so charm fetching will not be necessary [21:15] that's a good point [21:15] so if this all works out the next thing we should do is write up a script for Gary to follow [21:15] bac: I'm not sure what you mean, but the canonistack instance is already fetching charms. [21:15] and include prep notes like that one [21:16] abentley: when you run juju-deployer it has to fetch all of the necessary charms [21:16] it may not be a big deal for him but it is for me since my ISP is so slow [21:16] we might also include usage instructions so he can build his own, I'm thinking he might want to make a more impressive bundle to deploy [21:17] benji: well, perhaps one with the gui in it [21:17] benji: I think that's gravy. [21:17] If I were demoing it I would have the gui-pre-deployed so the audience can watch the bundle deploy [21:17] bac: So are you saying you'd like me to install your branch on the canonistack instance? [21:18] abentley: tasty, tasty gravy [21:18] abentley: yes and then run 'jam' on whatever bundle y'all decide upon [21:18] benji: yes, good point about having the gui up first [21:18] remember the bundle filename will be the basket name in the URL so make it meaningful [21:21] bac: Your branch is in place. [21:22] abentley: great. can you grab the bundle, rename it, and then run 'jam'? [21:22] bac: I've already run jam on that instance. [21:22] oh, so what is the basket and bundle name? [21:23] abentley: can you see the json at /api/2/bundle// ? [21:25] bac: Yes. http://162.213.34.16/api/2/bundle/mediawiki/intranet [21:26] so, we should be able to run 'juju-deployer -e ENV -c http://162.213.34.16/api/2/bundle/mediawiki/intranet' [21:26] bac: Yes, I think so. [21:27] i've just done it locally and it seems to have worked. would like to see someone else try [21:27] make sure you have lp:juju-deployer/darwin [21:27] bac: I can't because that would dump it into the same env as 162.213.34.1 [21:27] bac: I'll run it [21:28] benji: to ec2? [21:28] yep [21:28] is that ok? [21:28] yeah, great [21:28] that's what i did [21:28] bac, benji: We've successfully ingested a bundle on staging: http://staging.jujucharms.com/api/2/bundle/~abentley/wiki-bundle-1/wiki [21:29] first I'll deploy the GUI so I can watch it work [21:29] abentley: cool! [21:29] abentley: from launchpad? [21:29] bac: Yes. [21:29] cool [21:29] abentley: is that my latest branch running? i see _id in the output but it should be stripped [21:30] oh, that's on staging [21:30] oi [21:30] man, i'm surprised it works at all [21:31] bac: revno 336 [21:33] bac: 336 is what's on 162.213.34.16 [21:33] abentley: ok, that makes more sense. thanks [21:37] abentley: i'm confused by that data representation. it doesn't match the code in r336 and won't work with the deployer [21:39] abentley: i see a problem. i didn't properly delete '_id'. i just pushed r337 which does [21:39] having it in there doesn't seem to hurt anything [21:40] bac: Updated. [21:40] but the json shown on staging does not have the bundle name as the outer key [21:41] and it is showing the bundle representation not just the ['data'] portion [21:42] bac: AFAIK you have not landed your code on trunk, so it is not running your code. [21:42] abentley: ok, that makes sense. i thought you said staging had been manually updated to 336 [21:43] bac: No, I meant the other instance. [21:43] gotcha [21:43] benji: any progress? [21:43] benji: i need to step out for 30-40 minutes. that ok? [21:43] I have the GUI up and am running deployer now [21:43] bac: yep, I have to go get the smallest York right now anyway [21:44] benji: url for the gui? [21:44] bac: https://ec2-54-227-91-238.compute-1.amazonaws.com/ [21:44] thanks. bbiab [21:44] bac: In theory, I could force your code onto staging. I was actually surprised you weren't targetting trunk. [21:45] abentley: it hasn't been reviewed [21:45] it is a bit hacky [21:47] bac: I'm running "deployer/bin/juju-deployer -e ENV -c http://162.213.34.16/api/2/bundle/mediawiki/intranet" now [21:47] (I had to put the path on the command to get it to work.) [21:47] bac: 2013-08-02 16:47:01 Deployment name must be specified. available: ('intranet',) [21:47] now running "deployer/bin/juju-deployer -e ENV -c http://162.213.34.16/api/2/bundle/mediawiki/intranet intranet" [21:49] bac: error 2013-08-02 16:48:02 Error getting status, is it bootstrapped? [21:49] I have ot go now, back in 30 or so minutes [21:52] does the GUI know about the landscape URL? [21:59] hmm the env commands are getting to rapi but the updates aren't updating the UI [22:29] heh, I trusted the copy-paste too much "-e ENV" bit me. Trying again with no -e option [22:31] benji: do you know if rapi is supposed to react to resolve commands? [22:31] it receives them and says it responds [22:31] but the resulting dataset never changes [22:31] I'm afraid I don't know. [22:32] alright - I'm just trying to figure out if my code is broken or rapi :)