| hatch | figured as much but haven't looked yet | 00:03 |
|---|---|---|
| huwshimi | hatch: https://codereview.appspot.com/12494043/ if you want to review | 00:08 |
| hatch | done | 00:10 |
| huwshimi | hatch: Thanks! | 00:11 |
| hatch | no probs | 00:13 |
| hatch | huwshimi: being a css guy I figured you might be interested in my latest blog post http://fromanegg.com/post/57464448123/css-selectors-the-next-level | 00:14 |
| hatch | lemme know what you think (or if I have any errors ;) ) | 00:14 |
| huwshimi | hatch: Nice. | 00:16 |
| huwshimi | hatch: I think the second code example should be ".dog::first-letter" | 00:17 |
| hatch | checking | 00:18 |
| hatch | yup | 00:18 |
| hatch | :) thanks | 00:18 |
| huwshimi | :) | 00:18 |
| huwshimi | Other than that it's a handy guide | 00:18 |
| hatch | thanks, glad you like it :) | 00:19 |
| === schwuk_away is now known as schwuk | ||
| antdillon | gary_poster, Morning just landed a branch with updated zoom slider styles: lp:~ya-bo-ng/juju-gui/zoom-slider-update | 11:26 |
| rick_h | antdillon: do you need help getting this into review and such then? | 11:30 |
| === schwuk is now known as schwuk_away | ||
| antdillon | rick_h, Not sure Gary wanted me sending stuff for review | 11:42 |
| antdillon | rick_h, But I just do lbox propose -cr right? | 11:42 |
| === antdillon is now known as ant-lunch | ||
| rick_h | ant-lunch: https://codereview.appspot.com/12523043 | 11:48 |
| rick_h | ant-lunch: added a card to the board. Will get it reviewed and such. | 11:49 |
| rick_h | ant-lunch: comment/question on the images in the code review for you https://codereview.appspot.com/12523043/ | 11:55 |
| === ant-lunch is now known as antdillon | ||
| antdillon | rick_h, Will sprite them now | 12:33 |
| rick_h | antdillon: thanks | 12:33 |
| antdillon | rick_h, Done, want me to do a mp? | 13:08 |
| rick_h | antdillon: do just push an update to your branch and I'll pull it down and resync it with the code review in progress | 13:08 |
| antdillon | rick_h, Thanks | 13:09 |
| rick_h | orangesquad, is there a way to check for errors on a charm? https://jujucharms.com/sidebar/~pavel-pachkovskij/precise/rack-4/ shows no readme but there is one in the source. | 13:10 |
| abentley | rick_h: You can look at the ingest logs. | 13:10 |
| abentley | orangesqad, bac or benji: Could you please review https://code.launchpad.net/~abentley/charmworld/restore-questions/+merge/178753 ? | 13:27 |
| bac | abentley: sure | 13:27 |
| benji | abentley: I'll take a look. | 13:27 |
| === schwuk_away is now known as schwuk | ||
| benji | or not if bac is dying to do it (abently: do you need one or two reviews?) | 13:27 |
| abentley | bac: Thanks. benji, I don't need two reviews. | 13:28 |
| abentley | benji: But thanks anyway. | 13:28 |
| * benji and bac thumb wrestle; bac wins. | 13:28 | |
| bac | \o/ | 13:28 |
| * bac hops up and down, rocky style | 13:29 | |
| bac | abentley, benji: how did gary's demo go yesterday? | 13:29 |
| abentley | bac: The server was down, but he said it went well anyway. | 13:30 |
| benji | non-esistent; the server was down so he did the "demo" with hand waves | 13:30 |
| bac | darn | 13:30 |
| rick_h | antdillon: sorry, think we had a miscommunication there | 13:33 |
| rick_h | antdillon: any png in the assets/images directory is turned into a sprite automatically. we can use that with the css "sprite filename". | 13:33 |
| rick_h | antdillon: if you look around you can see it used in a bunch of places | 13:34 |
| rick_h | antdillon: so I was more just looking for the css styles to be onthe divs you used vs the image links themselves. | 13:34 |
| antdillon | rick_h, Ah ok, on it | 13:34 |
| rick_h | antdillon: sorry, didn't mean to make you sprite up the images you added on their own. | 13:34 |
| antdillon | rick_h, I've put the images as backgrounds of the divs instead of images | 13:34 |
| rick_h | antdillon: it's why we've got that 'non-sprites' directory. For images that don't need ot go into the auto-sprite | 13:35 |
| rick_h | antdillon: right, and that's what the sprite tooling in place does | 13:35 |
| bac | abentley: the text in iter_categories() is user-visible i assume. did you grab that from somewhere else or make it up? i ask because there are some grammar issues but i don' t want to spend a lot of time on them if they are not user visible nor under our control. | 13:37 |
| abentley | bac: I grabbed it from the original migration that produced the questions. It is user-visible. | 13:37 |
| abentley | bac: The original: http://bazaar.launchpad.net/~juju-jitsu/charmworld/trunk/view/243/migrations/versions/001_load_qa_questions.py | 13:39 |
| bac | abentley: ok, some just look clunky but perhaps read correctly in context. | 13:40 |
| bac | abentley: and 'user' is only members of ~charmers, right? | 13:40 |
| bac | as in 'user visible' | 13:41 |
| abentley | bac: The user is anyone who looks at the QA ratings. | 13:41 |
| bac | oh, ok | 13:41 |
| abentley | bac: There are definitely grammar problems. Some questions refer to the subject as singular "passes tests...", while others refer to it as plural "Contain a suite..." | 13:44 |
| bac | abentley: done | 13:44 |
| bac | abentley: if you could make a pass at those it would be nice. | 13:44 |
| antdillon | rick_h, Ok to keep the button and hover images together? Or should I separate them all and change the background image | 13:45 |
| rick_h | antdillon: no, split them up back like they were. Just don't link directly to them. Use the sprite css classes to load them into the backgroud of your divs | 13:45 |
| antdillon | rick_h, Got ya | 13:45 |
| abentley | bac: The content of those questions is the ~charmers' choice AIUI. We can certainly point out the issues. | 13:46 |
| rick_h | antdillon: run `bzr grep "sprite "` to get an idea of uses there | 13:47 |
| antdillon | rick_h, Cheers | 13:49 |
| hatch | morning | 13:54 |
| hatch | frankban: looks like you fixed CI :) | 14:07 |
| hatch | yay! | 14:07 |
| frankban | guihelp: we ignored that poor jenkins guy for so long... but (for) now he's back to sanity! | 14:07 |
| hatch | thanks for doing that :) | 14:07 |
| bac | yay, frankban | 14:07 |
| frankban | :-) | 14:07 |
| teknico | frankban: he's such a jenk, you know ;-) | 14:08 |
| gary_poster | yay, frankban, thanks! | 14:08 |
| gary_poster | jujugui, fwiw, I'm going to work on Huw's proposed branch for a break. :-) | 14:09 |
| hatch | gary_poster: this one https://codereview.appspot.com/12506044/ ? | 14:09 |
| gary_poster | hatch yeah | 14:09 |
| hatch | ok I'm also in the process of reviewing | 14:09 |
| bac | teknico: doing your 2nd review | 14:09 |
| gary_poster | hatch oh ok. you do it then. did you already fix the destroy service duplication and the expose issues? | 14:10 |
| gary_poster | hatch, if not I'll do it :-) | 14:10 |
| hatch | negative | 14:10 |
| teknico | bac: thanks, you may want to hold off qa though, I'll fix the problem frankban pointed out first | 14:10 |
| bac | ok | 14:10 |
| hatch | gary_poster: so far the main issue I've found is that he moves the viewlet-manager-footer into the service-configuration.partial | 14:11 |
| gary_poster | hatch, that's per request | 14:11 |
| hatch | which isn't really semantically correct | 14:11 |
| gary_poster | hatch oh | 14:11 |
| hatch | I know the button should move...just that we should keep the footer class in the wrapper :) | 14:11 |
| rick_h | abentley: got a sec to help me debug what's up with this charm please? | 14:12 |
| gary_poster | got it. hatch, may I work on the expose issues and the destroy issue duplication? :-) I need a little fun | 14:12 |
| hatch | haha you bet | 14:12 |
| abentley | rick_h: Sure. Is it the one you mentioned earlier? | 14:12 |
| gary_poster | :-) thanks | 14:12 |
| hatch | how was the flight? | 14:13 |
| gary_poster | very long hatch, three legs. :-/ | 14:13 |
| gary_poster | but fine otherwise | 14:13 |
| hatch | I suppose that's the best you can hope for :) | 14:13 |
| rick_h | abentley: yea, I finally setup my ssh to get into staging. On staging I'm seeing http://paste.mitechie.com/show/994/ in the logs a ton in app.log | 14:13 |
| rick_h | abentley: but having a hard time seeing where this error comes from. The log line says "update_charm" but update_charm doesn't do a warning, and the error format has "error" in the name so it's from elsewhere and trying to chase it. | 14:14 |
| abentley | rick_h: The exception is being raised by Bazaar. | 14:14 |
| rick_h | abentley: greeping for part of that message comes up with no results so guessing it's coming out of something else? | 14:14 |
| abentley | rick_h: It looks like the user uncommitted that revision, because I can't see it on the Launchpad branch. | 14:18 |
| rick_h | abentley: ah, ok. /me didn't realize you could uncommit a revision | 14:18 |
| rick_h | abentley: what's the way I can suggest he moves forward? Can he get back the uncommitted revision and move forward from there? | 14:19 |
| abentley | rick_h: So, the uncommitted revision is actually on Launchpad, but because it's not part of the current history, it's not being fetched. He's just committed a new revision, so we should stop caring about the old one soon if we haven't already. | 14:21 |
| rick_h | abentley: yea, I thought maybe he was hitting the proof error of no revision file so he pushed an updated version with a revision file and we waited for ingest to pick it up | 14:21 |
| abentley | rick_h: The new revision is from 48 minutes ago. Do you have any errors more recently than 30 minutes ago? | 14:22 |
| rick_h | abentley: m.j.c. pulled the revision enough that the changelog is updated, but the config/readme and other files seem stuck pre this issue http://manage.jujucharms.com/~pavel-pachkovskij/precise/rack | 14:22 |
| rick_h | abentley: yes, latest is from 3min ago | 14:23 |
| rick_h | abentley: looks like this error is hit every ingest cycle | 14:23 |
| abentley | rick_h: m.j.c is on revno 5. | 14:23 |
| rick_h | log files is spammed to death | 14:23 |
| rick_h | abentley: well app.log | 14:24 |
| abentley | rick_h: Okay, so I guess the charm store is slow. | 14:24 |
| rick_h | abentley: yea, that's the latest rev in bzr. he went from r4 to r5 today as part of working this out | 14:24 |
| teknico | bac: bug fixed, qa may proceed, thanks again :-) | 14:24 |
| antdillon | rick_h, Do you need to use js to add the hovered class to display the hovered image? | 14:25 |
| rick_h | antdillon: I'd assume we could use a :hover css selector? | 14:25 |
| rick_h | antdillon: oh wait, so there's a hover on the sprite image? | 14:25 |
| rick_h | antdillon: if so then yes, we'd need to change the css class on mouse in/out | 14:26 |
| antdillon | rick_h, I think I will because changing the background pos isnt working | 14:26 |
| abentley | rick_h: So, the charm store still is using pavel.pachkovskij@altoros.com-20130301074156-vkto1nnhg3pujiyq. Once it updates, we'll update: https://store.juju.ubuntu.com/charm-info?charms=cs:~pavel-pachkovskij/precise/rack-4 | 14:26 |
| rick_h | abentley: ok, will tell him to hold on and keep an eye on it. Thanks for the help | 14:27 |
| rick_h | abentley: and I'll check with him about the uncommit usage to verify that's what caused it to become a mess | 14:27 |
| abentley | rick_h: Technically, that URL should be https://store.juju.ubuntu.com/charm-info?charms=cs:~pavel-pachkovskij/precise/rack so it tracks head. | 14:27 |
| rick_h | abentley: ok | 14:28 |
| antdillon | rick_h, Unless I can plus or minus from current bk pos :) | 14:28 |
| rick_h | antdillon: huh? I'm not following. | 14:28 |
| rick_h | antdillon: what are we hovering? | 14:28 |
| antdillon | rick_h, So the sprite system is putting the sprites in the middle sprite sheet so I can't use hover to move the bk to the corrent hover pos. I'll add classes with js | 14:30 |
| antdillon | rick_h, Hovering the plus and minus buttons on the zoom | 14:30 |
| rick_h | antdillon: ok, right. We'd have to use js to change the css class to the hover image title | 14:31 |
| rick_h | antdillon: it's a good idea anyway to avoid flicker while the hover image is loaded on the first runs | 14:31 |
| hatch | gary_poster: there is one other issue in https://codereview.appspot.com/12506044/ that you could also fix ;) The inspector height is always the full allowable height regardless of the content | 14:37 |
| gary_poster | ack hatch, thanks, will discuss with luca et al. Wondering about interaction with charm panel. | 14:37 |
| rick_h | gary_poster: I *thought* we set both the height of the left breakout along with the inspector height in the 'recalculateHeight' method | 14:38 |
| rick_h | gary_poster: so they should be kept in sync | 14:38 |
| * rick_h reads link to catch up | 14:38 | |
| gary_poster | rick_h, right. the question is whether the desire to have a nice full charm side panel overrides the desire to have a short charm panel when needed. | 14:39 |
| hatch | gary_poster: ahh right I forgot about that change | 14:39 |
| hatch | frankban: teknico do either of you live here? https://plus.google.com/u/0/103804991882843552936/posts/5SANwPcSYrG :D | 14:48 |
| hatch | gary_poster: how do we respond to the jujugui documentation doc? | 14:52 |
| frankban | hatch: no we don't. that's near Naples, there are beautiful places in that area. | 14:54 |
| hatch | yeah - I would imagine expensive to live there too? | 14:54 |
| bcsaller | anyone have a few minutes to help me diagnose some test failures, it looks like I have a crossed wire. lp:~bcsaller/juju-gui/conflict-ux/ | 14:56 |
| hatch | bcsaller: you bet | 14:56 |
| frankban | hatch: well, I guess buying an house there is more expensive than the average in Itay, and the average here is ... expensive. | 14:56 |
| bcsaller | thank you, this thing is driving me crazy, hopefully shallow with another set of eyes | 14:56 |
| hatch | bcsaller: it's because you're up to early | 14:57 |
| hatch | you should sleep in for another hour | 14:57 |
| hatch | :) | 14:57 |
| bcsaller | oh, this is from yesterday too though | 14:57 |
| hatch | frankban: haha yeah? what's the avg per square foot? | 14:57 |
| gary_poster | hatch, jujugui documentation doc: could comment on it? | 14:58 |
| hatch | gary_poster: ok can do - I just wasn't sure if there was a discussion thread somewhere or not | 14:58 |
| frankban | hatch: you are asking too many unit conversions here ;-) | 14:58 |
| hatch | frankban: oh right...sorry per sq/m :) | 14:59 |
| gary_poster | hatch, nope. some verbal discussions here, but nick is out this week | 14:59 |
| hatch | ahh | 14:59 |
| hatch | bcsaller: first issue.... :8084/test/test_conflict_ux.js 404 (Not Found) | 15:00 |
| hatch | :) | 15:00 |
| bcsaller | hatch: added, sorry and pushed | 15:00 |
| hatch | :D | 15:00 |
| bcsaller | those tests are not the one with the issue though | 15:00 |
| bcsaller | wait till you see this one... :-/ | 15:01 |
| hatch | waiting......... | 15:01 |
| * hatch needs faster computer | 15:01 | |
| * hatch starts indigogo campaign for new MBP | 15:01 | |
| bcsaller | http://0.0.0.0:8084/test/index.html?grep=Inspector%20Constraints is the short cut in this case | 15:01 |
| hatch | 5 failures so far | 15:02 |
| bcsaller | oh, I only get 4 in that module | 15:02 |
| hatch | allllmost doneeee | 15:02 |
| hatch | alllllmmmoooossssttttt | 15:02 |
| hatch | and done | 15:02 |
| hatch | 75s | 15:02 |
| hatch | oh man haha | 15:02 |
| hatch | it's 50s slower in the console | 15:02 |
| hatch | er faster | 15:03 |
| hatch | ok investigating now | 15:03 |
| hatch | I get the 4 errors you speak of, and an error in Inspector Conflict UX | 15:04 |
| hatch | should indicate conflict and allow resolution of constraints | 15:04 |
| hatch | if you were wondering what the other error was | 15:04 |
| frankban | hatch: http://www.immobiliare.it/Salerno/casa-Positano.html it's in italian but you can easily find the important bits of info, e.g. € 680.000 | 85 m² ;-) | 15:04 |
| bcsaller | hatch: oh, that last test is new, I'll add a skip, was trying to figure out what happened with the rest | 15:05 |
| hatch | bcsaller: oh ok cool | 15:05 |
| hatch | frankban: haha yep that's expensive :D | 15:05 |
| hatch | bcsaller: your asserts are backwards | 15:07 |
| hatch | just fyi | 15:07 |
| bcsaller | hatch: I didn't write those, but I agree | 15:07 |
| hatch | expected is the second param | 15:07 |
| hatch | confusing...I know | 15:07 |
| hatch | ohh | 15:07 |
| bcsaller | existing tests that now break | 15:08 |
| bcsaller | but in such a strange way | 15:08 |
| hatch | yeah I see that | 15:08 |
| bcsaller | subscribers seem to be getting crossed | 15:08 |
| hatch | ok grabbing my coffee then I'll dig in deeper | 15:08 |
| bcsaller | oh me too, me too | 15:08 |
| rick_h | bcsaller: so I got failures on that section when I had left over dom elements from an earlier test | 15:08 |
| rick_h | bcsaller: when I did proper html cleanup it went away | 15:09 |
| rick_h | bcsaller: so I'd start out with debugger; in there before those tests run and peek at Y.one('body').get('innerHTML') | 15:09 |
| bcsaller | rick_h: thats good to know, but even running them in isolation seems to cause it | 15:09 |
| bcsaller | rick_h: container seems to populate alright and I made selection of the nodes in the callbacks goto the viewlet container rather than the viewlet-manager container (its ancestor) | 15:10 |
| rick_h | bcsaller: by isolation you mean with a .only? or by commenting out the rest of the test files? | 15:10 |
| bcsaller | rick_h: with only/grep | 15:10 |
| rick_h | bcsaller: I only figured this out after commenting out the actual index.html references and going through them debugging. | 15:10 |
| rick_h | bcsaller: ah ok | 15:11 |
| teknico | hatch: I've been there, it's as steep as it looks like :-) | 15:11 |
| bcsaller | rick_h: maybe I'll give that a quick try | 15:11 |
| Makyo | jujugui call in 10, kanban now | 15:20 |
| hatch | oh yeah it's Tuesday thanks Makyo | 15:20 |
| hatch | :) | 15:20 |
| * hatch goes to review board | 15:20 | |
| * Makyo on autopilot | 15:21 | |
| hatch | haha | 15:21 |
| === teknico1 is now known as teknico | ||
| Makyo | jujugui call in 1 | 15:29 |
| hatch | teknico: guichat now | 15:31 |
| hatch | bcsaller: so somehow button.save-constraints was hitting button.confirm ....I'm a little concerned here :) | 15:49 |
| rick_h | ugh, bug trackers, where idea go to die. | 15:51 |
| hatch | rick_h: heh not ALL bug trackers | 15:52 |
| bcsaller | hatch: yeah, me too, we should have that talk at some point, the distance is definition and invocation of callbacks is all messed up | 15:52 |
| hatch | sure - can we bench it until after the chat with Gary? | 15:53 |
| bcsaller | absolutely, thats why I said at some point | 15:53 |
| hatch | bcsaller: do you need another review? | 15:56 |
| bcsaller | hatch: you have looked at this branch before, but if you have bandwidth another look would be good | 15:56 |
| rick_h | antdillon: how are we doing? Need a hand with it? | 15:56 |
| antdillon | rick_h, Almost there, just trying to workout how to get the sprites.css to have the hover styles after the normal style | 15:57 |
| rick_h | antdillon: k, going to do this user testing call and afterwards I'll ping you and we can do a hangout and get it straightened out if that's cool? | 15:58 |
| antdillon | rick_h, Cool, let me know | 15:58 |
| adeuring | abentley: could you please have a look here https://code.launchpad.net/~adeuring/charmworld/etag-for-charm-api-view/+merge/178792 ? | 15:58 |
| abentley | adeuring: Sure thing. | 15:59 |
| hatch | gary_poster: call now? | 15:59 |
| antdillon | rick_h, Done it, just updated my branch | 16:00 |
| rick_h | antdillon: ok, will pull down after this call and check it out. Thanks for working through it | 16:02 |
| antdillon | rick_h, Thanks | 16:02 |
| bac | gary_poster: meeting? | 16:04 |
| abentley | adeuring: This approach to hashing doesn't seem to distinguish between a list with ['a', 'b'] and a dict with {'a': 'b'}. | 16:06 |
| adeuring | abentley: oh, good catch. | 16:07 |
| abentley | adeuring: Maybe just serialize to json and hash that? | 16:07 |
| adeuring | abentley: nice idea, simple and reliable. I'll do this | 16:07 |
| abentley | adeuring: Cool. You'll want to specify sort_keys=True. Other than that, I think it's a stable representation. | 16:08 |
| adeuring | abentley: right | 16:08 |
| abentley | adeuring: Also, you can simplfy "if x in y: del[x]" as "y.pop(x, None)" | 16:10 |
| adeuring | abentley: ah, right | 16:10 |
| gary_poster | jujugui, sorry I was pulled away. can we start the call in 5 minutes, at 25 after the hour? | 16:19 |
| hatch | we are already in it haha | 16:19 |
| gary_poster | :-) ok cool. will join then | 16:20 |
| abentley | adeuring: I think it's reasonable to call _charm_result(Charm(charm_data)) rather than _charm_results([charm_data])[0] | 16:22 |
| adeuring | abentley: yeah, I thought too that thisa bit more complicated than necessary, but did not want to change existing stuuf... | 16:23 |
| abentley | adeuring: Cool. | 16:23 |
| hatch | gary_poster: so it looks like your laptop has a very directional mic - when luca was talking we could barely hear him if it wasn't pointed at him | 17:09 |
| hatch | that's pretty cool | 17:09 |
| bcsaller | hatch: we still need to have that other event selector call but I could use a break from video for a bit | 17:09 |
| hatch | a-greed | 17:09 |
| hatch | 20mins? | 17:09 |
| bcsaller | hatch: sounds good | 17:11 |
| benji | abentley: any hints as to why "bin/migrations upgrade --init" would generate this exception? migrations.migrate.MissingExodusIndex: Exodus index "charms_pending_010" does not exist. | 17:11 |
| rick_h | benji: pyc file left around? | 17:12 |
| benji | rick_h: It's a fresh branch (I don't colocate dev branches, they are all unique snowflakes that deserve their own HD space) | 17:13 |
| gary_poster | hatch, ack will try to remember | 17:14 |
| hatch | gary_poster: oh and one more thing - are you going to be landing huw's branch or am I taking over at some point (just because it's getting late there already) | 17:14 |
| rick_h | jujugui can I help get a second review for ant's branch? https://codereview.appspot.com/12523043 | 17:21 |
| hatch | sure | 17:21 |
| hatch | you forgot a G in your lgtm :) | 17:21 |
| rick_h | hatch: hah | 17:22 |
| rick_h | ugh, and he's gone | 17:23 |
| hatch | rick_h: so now that we are pulling the CSS into our own stylesheet we can drop the yui3-skin-sam and just go with the .yui3-slider-y | 17:23 |
| rick_h | hatch: but I thought the sam skin was put on a container of the slider | 17:23 |
| rick_h | so we need to match the specific-ness to override the default | 17:23 |
| rick_h | hatch: oh hmm, not on the slider then. | 17:24 |
| hatch | well yeah we could now stop loading the yui css and then just rely on our own styling | 17:25 |
| hatch | rick_h: done - w/QA | 17:29 |
| rick_h | hatch: cool | 17:30 |
| bcsaller | hatch: whenever you want to have that chat | 17:36 |
| === schwuk is now known as schwuk_away | ||
| hatch | rick_h: with all of those styles being overridden it probably isn't much of a stretch to copy over the remaining required styles and then stop loading the yui css for the slider | 17:37 |
| hatch | bcsaller: ok guichat? | 17:37 |
| rick_h | hatch: yes, we've had this discussion. However, I've lost my day to helping land this branch and chasing a charm bug. At this point, I'm letting this go, not making anything worse in the current app, and letting there remain the todo to clean up skin-sam to another day. | 17:44 |
| abentley | benji: Sounds like you didn't run prepare-upgrade first. | 17:46 |
| benji | ahh; let me try that | 17:47 |
| benji | abentley: that worked. Thanks! | 17:48 |
| abentley | benji: np | 17:50 |
| hatch | rick_h: alright - I'd like to create a task/card to go through the app and remove all of the yui css entirely | 18:09 |
| hatch | rick_h: you landed the branch without the user select classes :/ | 18:10 |
| hatch | rules* | 18:10 |
| rick_h | hatch: ? /me goes to look again | 18:10 |
| hatch | unless I'm on the wrong diff | 18:11 |
| rick_h | hatch: it's here, /me checks the diff | 18:11 |
| hatch | oh woops | 18:11 |
| hatch | sorry | 18:11 |
| hatch | I was on the wrong diff | 18:11 |
| hatch | my bad | 18:11 |
| rick_h | hatch: ah ok. cool. Had me nervous I was editing and submitting two different things :/ | 18:12 |
| rick_h | hatch: card added | 18:12 |
| hatch | thanks | 18:15 |
| * benji takes a really late lunch. | 18:59 | |
| hatch | rick_h: bcsaller jcsackett thought you guys would find this interesting https://github.com/yui/yui3/pull/1063 | 19:37 |
| jcsackett | hatch: that is fantastic. | 19:39 |
| hatch | yeah could really help simplify some of our routing | 19:39 |
| bcsaller | yeah, not bad, function or regex makes sense to me there, but regex is a good start | 19:47 |
| hatch | bcsaller: yeah - his argument against supporting functions was that at that point you should use middleware | 19:48 |
| hatch | which I suppose is valid | 19:48 |
| rick_h | hmm, I guess it can help clean up our 3 different view route points, but at the expense of complicating up the routes themselves | 19:50 |
| rick_h | so 1/2 one and 1/2 another imo | 19:50 |
| hatch | yeah I actually think that the subapp routes can be distilled into a cascading series of routes instead of how it's currently done | 19:53 |
| hatch | (which is how they are supposed to work) | 19:53 |
| hatch | even a bunch of our primary routes could do the same | 19:53 |
| hatch | well I suppose we are removing like 90% of our primary routes haha | 19:53 |
| rick_h | yea, if we could verify we hit once and only hit the first matching route we'd be in good shape, but those aren't the rules | 19:58 |
| hatch | well how routes are 'supposed' to work is that they are supposed to cascade | 19:58 |
| hatch | so you 'build up' your data set as you step through routes and then show the UI on the final one | 19:59 |
| hatch | I've never successfully developed that system from the start of an app | 20:00 |
| hatch | but always ends up being where they logically progress to in the end | 20:00 |
| bac | abentley: on friday you had a bundle ingested to staging from launchpad, correct? i'm trying to view the json but get no_such_bundle | 20:10 |
| bac | abentley: is it still there? shouldn't this be the url: | 20:11 |
| bac | http://staging.jujucharms.com/api/2/bundle/wiki-bundle/wiki | 20:11 |
| abentley | bac: Yes. You are missing the revision. http://staging.jujucharms.com/api/2/bundle/~abentley/wiki-bundle-1/wiki | 20:11 |
| bac | worse, i was missing the fact it wasn't promulgated! | 20:12 |
| hatch | bcsaller: so it appears that nested describes execute the code in their parents even when run in .only() mode.....very interesting | 20:21 |
| * hatch is trying to organize tests like you do | 20:21 | |
| abentley | orangesquad, bac or benji: Could you please review https://code.launchpad.net/~abentley/charmworld/separate-qa/+merge/178841 ? | 20:26 |
| benji | abentley: I'll take a look | 20:27 |
| abentley | benji: Thanks. | 20:27 |
| bcsaller | hatch: I tend to do that to reuse test code where I think it makes sense, but I like the simple hierarchy by itself | 20:27 |
| hatch | yeah I like how it can say these are the ghosts tests and these are the sections to which it's testing | 20:27 |
| hatch | make them easier to find/organize | 20:28 |
| benji | abentley: your branch looks good | 20:56 |
| abentley | benji: Thanks. | 20:57 |
| bac | benji or abentley: Branch for review for bug 1208035 -- should be quick. https://code.launchpad.net/~bac/charmworld/bug-1208035/+merge/178849 | 20:57 |
| _mup_ | Bug #1208035: TypeError Bundle takes exactly 2 arguments <charmworld:In Progress by bac> <https://launchpad.net/bugs/1208035> | 20:57 |
| abentley | bac: I'll get it. | 20:57 |
| bac | abentley: thanks for the help earlier. i am able to access staging now. | 20:58 |
| abentley | Woot. | 20:58 |
| abentley | bac: Why are there two test_no_paths? | 20:59 |
| bac | one charms one bundles | 20:59 |
| abentley | bac: r=me. | 20:59 |
| bac | thanks abentley | 21:00 |
| hatch | I get nervous when a tests doesn't fail | 21:02 |
| hatch | rick_h: somehow the slider sprites got broked http://comingsoon.jujucharms.com/ | 21:06 |
| hatch | just realized it's past your EOD too :) | 21:07 |
| hatch | jujugui anyone available for a review? https://codereview.appspot.com/12567043/ | 21:36 |
| bcsaller | hatch: I'll look | 21:36 |
| hatch | thanks! | 21:36 |
| hatch | wb gary_poster | 21:36 |
| hatch | isn't it reeeaaaal late there? :) | 21:37 |
| gary_poster | hey hatch :-) | 21:37 |
| gary_poster | 10:37 :-) | 21:37 |
| hatch | oh ok so not too bad | 21:37 |
| hatch | bcsaller: the ghost_inspector file changes only add a describe wrapper | 21:39 |
| hatch | but bzr doesn't handle indentation changes well | 21:40 |
| hatch | bcsaller: thanks for the review - re-sending the commands at scale - did you mean env should throttle these or core should accept a list? | 21:53 |
| bcsaller | hatch: it could take a list, which at scale is still a race, or it could support things like 'retry units in state x' as a server side operation | 21:54 |
| bcsaller | I think that style API makes more sense when you have 1k units that need replacing for example | 21:54 |
| hatch | yeah I'd like to offload the list to the server, but we can batch the requests to the server right now to get around that in the mean time | 21:55 |
| hatch | if you think it's necessary | 21:56 |
| hatch | I think I'll make a ticket regardless | 21:56 |
| gary_poster | bcsaller, hatch, +1 on fixing the bug you emailed me about. However, I'd like it to happen after the conflict resolution and scale up/down work. We could then carve out a few days with a strong expectation that tests and docs for these things would be significantly improved during that time. Then bcsaller and/or Makyo could work on the charmbrowser bundle code (or prototype) and then bcsaller could help luca prototype the dragging thing. | 22:00 |
| hatch | that sounds like a plan - today ended up getting bogged down with some reviews/discussions and whatnot so I'm behind anyways :/ | 22:01 |
| gary_poster | ack hatch | 22:01 |
| hatch | gary_poster: you may also have input on this https://bugs.launchpad.net/juju-gui/+bug/1209015 | 22:02 |
| _mup_ | Bug #1209015: Unit action buttons could lock up the UI at scale <juju-gui:New> <https://launchpad.net/bugs/1209015> | 22:02 |
| bcsaller | gary_poster: that sounds like what we expected, thanks | 22:04 |
| gary_poster | hatch, thanks. I don't think it is a burning issue, but will be one to chip away at in the coming months. Thanks for highlighting it. | 22:04 |
| hatch | bcsaller: actually caught it :) | 22:04 |
| bcsaller | nick complete made that read funny :) | 22:05 |
| hatch | haha woops | 22:05 |
| hatch | I have filed 26 bugs since I started....look at me go | 22:07 |
| hatch | about to be 27 | 22:07 |
| hatch | https://bugs.launchpad.net/juju-gui/+bug/1209016 | 22:09 |
| _mup_ | Bug #1209016: Right hand zoom slider handles sprited improperly <juju-gui:Triaged by rharding> <https://launchpad.net/bugs/1209016> | 22:09 |
| hatch | boom | 22:09 |
| hatch | jujugui need one more review on https://codereview.appspot.com/12567043/ | 22:09 |
| gary_poster | hey hatch, what should I do to fix viewlet-manager-footer in huwshimi's branch? Can you give me a quick patch? | 22:14 |
| hatch | umm | 22:14 |
| hatch | one sec | 22:14 |
| gary_poster | hatch should I just dupe the style and give it a new class name? that looks like the heart of your issue IIUC | 22:15 |
| hatch | yeah the footer style should be reverted and it moved back to where it was in the wrapper | 22:16 |
| hatch | then a new styles on that element | 22:16 |
| hatch | s/a// | 22:16 |
| gary_poster | cool, on it hatch, thanks | 22:16 |
| benji | later all | 22:16 |
| hatch | np | 22:16 |
| hatch | asd | 22:16 |
| hatch | a | 22:17 |
| hatch | sorry I broke my client | 22:17 |
| hatch | did you get my last msg about reverting the style? | 22:18 |
| hatch | oh valuechange event why won't you fire for me | 22:41 |
| bcsaller | hatch I had to deal with that as well | 22:43 |
| bcsaller | hatch: there is a work-around on the tests of my branch | 22:44 |
| bcsaller | that took me a while to figure out as well | 22:44 |
| hatch | well it works fine in chrome but not in phantom for some reason | 22:45 |
| hatch | looking at your branch | 22:45 |
| hatch | ahhhh simulate focus | 22:45 |
| hatch | niiice | 22:45 |
| hatch | I was .focus() | 22:45 |
| hatch | that has to be a bug with YUI | 22:46 |
| hatch | thanks for figuring that out | 22:48 |
| gary_poster | hatch, https://codereview.appspot.com/12506044/ has my comments to Huw. review if you get a chance, otherwise np. I want to review your branch, but it needs qa, and I really should get to bed. | 22:51 |
| gary_poster | so will leave it for someone tomorrow. Sorry :-/ | 22:51 |
| hatch | sure np :) have a good night | 22:51 |
| gary_poster | ttyl, all | 22:51 |
| gary_poster | thanks :-) | 22:51 |
| hatch | bcsaller: so setting the id of the ghost automatically updates the element in the DOM in the app, but it's not updating the DOM in the tests | 22:54 |
| hatch | the callback is being called | 22:54 |
| hatch | the value is being set on the ghost inspector | 22:55 |
| hatch | ghostService | 22:55 |
| hatch | i mean | 22:55 |
| bcsaller | hatch: is it in a textarea? | 22:55 |
| hatch | nope it's an input but the change callback is being called and setting the id on the ghostService instance | 22:55 |
| hatch | so whatever is listening to that change event isn't connecting | 22:56 |
| hatch | do you know where that's listening? | 22:56 |
| huwshimi | Morning | 23:00 |
| hatch | morning huw | 23:02 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!