| hatch | ok well past EOD | 00:08 |
|---|---|---|
| hatch | cya in the am | 00:08 |
| hatch | friggen CI failures | 00:52 |
| rick_h | valuechange sucks for CI | 00:53 |
| hatch | well IE passed but now FF is failing on two different tests | 00:53 |
| hatch | well ok not two totally different | 00:53 |
| hatch | but different none the less | 00:54 |
| hatch | some which shouldn't have even been changed... | 00:54 |
| hatch | like the textarea autosize plugin?? | 00:54 |
| hatch | wth | 00:54 |
| rick_h | timing sensitive based since it's based on valuechange | 00:55 |
| rick_h | remember when we were tinkering with the 50ms poll time? | 00:55 |
| hatch | remember when I jsut deleted the tests from VC history like they never existed.... | 00:56 |
| hatch | oh I wish | 00:56 |
| rick_h | lol | 00:56 |
| hatch | bzr branch trunk friggen-damn-ci-failures | 00:58 |
| hatch | umm what | 01:02 |
| hatch | TypeError: can't convert undefined to object | 01:02 |
| hatch | bcsaller: still around? | 01:13 |
| bcsaller | hatch: yes | 01:13 |
| hatch | so in inspector.js you had created a wrapper for handlers.push called watch | 01:13 |
| hatch | yeah....firefox didn't like that... | 01:13 |
| hatch | lol wth | 01:13 |
| bcsaller | hatch: is watch a reserved word in 'future js'? | 01:15 |
| hatch | negative | 01:16 |
| hatch | I'll try and create a repro | 01:16 |
| bcsaller | I guess that is the type of thing CI should catch, but why would we expect that to fail | 01:16 |
| hatch | see if it's something else in our code | 01:16 |
| hatch | or FF just being wako | 01:16 |
| bcsaller | that was just an alias IIRC, I guess just call the push directly when its used | 01:17 |
| hatch | yup that's what I did | 01:17 |
| hatch | yeah it was just an alias | 01:18 |
| hatch | probably to save chars | 01:18 |
| hatch | bcsaller: http://jsbin.com/ipehec/1/edit | 01:19 |
| hatch | updating FF to see if it fixes it | 01:20 |
| hatch | nope 23 does the same | 01:21 |
| bcsaller | handlers.push is fine | 01:23 |
| bcsaller | not sure that even works in chrome | 01:23 |
| bcsaller | console.log(handlers) | 01:23 |
| bcsaller | hatch: ^ | 01:24 |
| hatch | whatabout it? | 01:24 |
| bcsaller | its empty in the jsbin | 01:25 |
| hatch | right | 01:25 |
| hatch | console.dir(handlers) | 01:25 |
| hatch | shows you the prototype | 01:25 |
| hatch | you can't alias any protoype methods on an array in FF | 01:26 |
| hatch | http://jsbin.com/ipehec/2/edit | 01:26 |
| bcsaller | not working in chrome for me either, I think it was failing silently | 01:28 |
| hatch | odly enough it works just fine with objects | 01:28 |
| hatch | http://jsbin.com/ipehec/4/edit | 01:28 |
| hatch | interesting | 01:29 |
| hatch | ignore the comments | 01:29 |
| hatch | i just forgot to remove them | 01:29 |
| bcsaller | the sad part is I didn't really need the alias | 01:30 |
| hatch | haha right | 01:30 |
| hatch | that's some interesting stuffs | 01:30 |
| bcsaller | handlers.push it is | 01:30 |
| hatch | yup | 01:31 |
| hatch | I've already got it fixed and proposing | 01:31 |
| hatch | wana give it a review once it's done so I can get it in tonight? :) | 01:32 |
| hatch | probably be a few minutes before lbox is done | 01:33 |
| hatch | bcsaller: https://codereview.appspot.com/12640043 | 01:36 |
| bcsaller | hatch: LGTM, thanks | 01:37 |
| hatch | great thanks | 01:38 |
| hatch | CI back to normal....awww yeahh | 03:14 |
| rick_h | hah | 03:14 |
| hatch | huwshimi: you around? | 04:08 |
| huwshimi | hatch: Yeah, I was, sorry I missed your message. Guessing you're gone now? | 05:23 |
| gary_poster | hey frankban. :-) good news: we do not need to support pyjuju for bundles. | 08:37 |
| teknico | gary_poster: good news indeed :-) | 08:40 |
| gary_poster | teknico, :-) . Also, mramm expects that we can stop supporting pyjuju at 13.10 | 08:41 |
| gary_poster | but that's not official yet | 08:41 |
| teknico | mourning its untimely demise already ;-) | 08:42 |
| gary_poster | :-) | 08:42 |
| frankban | gary_poster: great! so, IIUC, we don't need to add a pyAPIenv to the deployer, correct? | 08:46 |
| === schwuk_away is now known as schwuk | ||
| adeuring | abentley: could you please have a look here: https://code.launchpad.net/~adeuring/charmworld/1204899-report-json-value-error/+merge/179181 ? | 13:28 |
| abentley | adeuring: sure. | 13:30 |
| abentley | adeuring: Are you planning to update the staging revno so that you can QA your previous branch? | 13:31 |
| adeuring | abentley: can you helpme to set up the juju environment? | 13:32 |
| abentley | adeuring: Okay, how can I help? | 13:33 |
| adeuring | abentley: for a start: what do I need to put into environments.yaml? | 13:34 |
| abentley | adeuring: You should have a mail from me called "Accessing staging". That has the environments.yaml that you need. | 13:34 |
| adeuring | abentley: ah, thanks, need to look again... | 13:34 |
| hatch | jujugui looking for 2 more reviews/qa's on this branch https://codereview.appspot.com/12627043/ | 13:37 |
| benji | hatch: looking | 13:37 |
| hatch | thanks! | 13:38 |
| hatch | it'll need a deep qa | 13:38 |
| hatch | in fact I'll merge trunk into it again | 13:38 |
| hatch | proposing with the newest trunk merged in now | 13:39 |
| abentley | adeuring: Is it possible for start_date or end_date to be bogus? If so, what happens? | 13:40 |
| adeuring | abentley: that should be set by our code. The worst I can imagine is that the end date is in the past.. | 13:41 |
| abentley | adeuring: What if the start date is after all the subsequent dates? | 13:41 |
| adeuring | abentley: without looking too close, I'd say that we get an empty report. but let me check... | 13:42 |
| hatch | benji: updated | 13:42 |
| benji | k | 13:42 |
| adeuring | abentley: yes, we get an empty report. Basically, it boils down to a call of range(-3) or similar to generate the "buckets" | 13:44 |
| abentley | adeuring: However, IIUC, the start_date and end_date is typically not supplied, so we should get a range of 2011/05/1 to now. | 13:46 |
| adeuring | abentley: right, and that looks reasonable | 13:46 |
| abentley | adeuring: I thought it might come from user-supplied data, in which case we'd need another bug report. | 13:47 |
| === schwuk is now known as schwuk_away | ||
| benji | hatch: the code changes look fine, doing QA now | 13:49 |
| abentley | adeuring: r=me. | 13:51 |
| adeuring | abentley: thanks | 13:51 |
| === schwuk_away is now known as schwuk | ||
| rick_h | jujugui review time. qa instructions are included. https://codereview.appspot.com/12621043 | 13:56 |
| rick_h | hatch: I'll peek. | 13:57 |
| hatch | thanks | 13:57 |
| hatch | I'd really like to get it landed asap | 13:57 |
| hatch | so we can start working with the new yui finally | 13:58 |
| rick_h | ugh, I get nervous when shrinkwrap updates things | 13:58 |
| hatch | rick_h: you can thank module authors for not locking down their dependencies for that :/ | 13:59 |
| gary_poster | jujugui, we can stop supporting pyjuju as soon as we stop testing it in CI :-) | 14:01 |
| hatch | for reals? | 14:01 |
| hatch | wow! | 14:01 |
| frankban | gary_poster: let's fix CI! ;-) | 14:01 |
| hatch | oh c'mon I just got it working again last night | 14:02 |
| hatch | lol | 14:02 |
| frankban | heh | 14:02 |
| gary_poster | hatch, for IE 10 drag target bug, sinzui suggested making the "drag a charm here" thing in the middle disappear when you start a drag | 14:02 |
| gary_poster | I like that | 14:02 |
| hatch | gary_poster: yeah - I was also going to look into why it's not a drop target | 14:02 |
| hatch | also, are you ok with the odd drag proxy? | 14:02 |
| hatch | it may not be supported in IE10 like in chrome | 14:03 |
| frankban | bcsaller: ServiceUpdate is in juju-core trunk | 14:03 |
| gary_poster | hatch, yes | 14:08 |
| gary_poster | frankban, did you see me (try to) tell you that you don't need to support pyjuju in deployer at all? | 14:09 |
| frankban | gary_poster: yes, a good news | 14:09 |
| gary_poster | cool frankban | 14:09 |
| rick_h | hatch: the confirm button in the service inspector (after editing a config setting) isn't working? known issue? | 14:09 |
| rick_h | hatch: also saw the expose button one, but you said that was expected. | 14:10 |
| hatch | rick_h: yeah I think it was introduced by huws branch | 14:10 |
| hatch | I made a comment in his review but he must have left it | 14:10 |
| rick_h | hatch: hmm, yea neither cancel/confirm work | 14:10 |
| hatch | https://codereview.appspot.com/12506044/#msg8 | 14:10 |
| rick_h | hatch: ok, but sounds like we don't have a card/anyone on it then? Should I add a card to inspector? | 14:11 |
| hatch | rick_h: I'll create a ticket and a card | 14:12 |
| rick_h | hatch: cool thanks | 14:12 |
| hatch | qaing your branch now | 14:13 |
| rick_h | hatch: thanks | 14:13 |
| hatch | rick_h: I see the options requests are still slow :) | 14:18 |
| adeuring | abentley: I'm getting the error "exceptions.ValueError: Missing config 'username', 'password', 'project-name' required for userpass auth | 14:21 |
| rick_h | hatch: yes, bug is still out on that | 14:21 |
| abentley | adeuring: It sounds like you might not have sourced the openstack config-- the novarc in the credentials I gave you. | 14:22 |
| adeuring | abentley: maybe. When did you send it? | 14:24 |
| benji | hatch: sorry, unity crash caused me to delay my QA a bit; still looking | 14:25 |
| * hatch thinks benji needs new hardwares | 14:25 | |
| hatch | :) | 14:25 |
| rick_h | says the man that needs new hardwares... | 14:26 |
| abentley | adeuring: I believe I gave you the openstack credentials on a USB stick at the Oakland sprint, but I can mail them to you now. | 14:26 |
| hatch | rick_h: hey mine doesn't crash :D | 14:26 |
| hatch | it's just slow lol | 14:26 |
| adeuring | abentley: OK, THANKS | 14:26 |
| benji | unfortunately I think my issues (computer-wise at least) are all software-induced | 14:28 |
| abentley | adeuring: Please associate GPG keys with your canonical acccount. | 14:28 |
| frankban | gary_poster: IIRC, we try to avoid installing packages from pypi in the charm, correct? | 14:31 |
| gary_poster | frankban, y | 14:32 |
| frankban | gary_poster: ok thanks | 14:32 |
| hatch | yui 3.11 being merged in to trunk | 14:35 |
| hatch | jujugui ^ | 14:35 |
| adeuring | abentley: ? There is a key associated with my LP account. What do you mean? | 14:35 |
| benji | is that Canadian for "hold onto your butts"? | 14:35 |
| hatch | lol | 14:35 |
| hatch | gary_poster: on the IE DD task now | 14:37 |
| gary_poster | hatch, cool thx | 14:37 |
| hatch | gary_poster: also curtis's branch is hanging out in maintenance review - could you ask him next time you see him what's up with it? | 14:38 |
| rick_h | hatch: where's "above the click handlers" that you wanted a comment? | 14:38 |
| abentley | adeuring: Not your lp account. Your canonical email account, abel.deuring@canonical.com. It needs to be listed on your GPG key so that programs can pick that key automatically when sending mail to that account. Right now, only your gmx.net and satzbau-gmbh.de accounts are listed. | 14:39 |
| hatch | rick_h: well I'm assuming the a's had another click handler on them else where would they link to? | 14:39 |
| rick_h | hatch: well, it's in the Y.Views and such. | 14:39 |
| hatch | ohh right pjax garbage | 14:39 |
| adeuring | abentley: ah, right, I'll do it | 14:39 |
| rick_h | hatch: and this is only overriding this in the context of the widgets in the autocomplete results | 14:39 |
| rick_h | hatch: huh? pjax garbage? no, it's Views listening to events from widgets | 14:40 |
| gary_poster | hatch, benji said he approved it if he added a test for the nagios external master script. Neither he nor anyone in webops knows how to write that test. | 14:40 |
| hatch | oh haha ok, what should we do with the card? :) | 14:41 |
| * benji looks at it. | 14:41 | |
| hatch | rick_h: so there is a view which is navigating on clicking those a's? | 14:41 |
| rick_h | hatch: the charm-token widget is used EVERYWHERE so some places watch for that click to open the charm details/etc | 14:41 |
| rick_h | hatch: in this view, clicking on the charm triggers teh autocomplete selection event and we don't want to do anything else with it | 14:42 |
| rick_h | hatch: the tokens render with a <a> and a link in there. We just have to kill that for autocomplete to work. | 14:43 |
| hatch | ok I gota pop this open again | 14:43 |
| hatch | one sec | 14:43 |
| benji | gary_poster/hatch: they either misunderstood my request or have suffered a collective brain aneurysm. The test is not of the script but of the endpoint the script gets as a liveness test. I.e., it would asssure that the URL the script hits stays there and continues to contain the text that the script expects. | 14:43 |
| gary_poster | benji, cool thanks, sinzui says he can do that! | 14:44 |
| hatch | rick_h: ohh now I see, it has a path in the href | 14:44 |
| rick_h | hatch: right | 14:44 |
| rick_h | hatch: so we're killing that, that's all | 14:44 |
| hatch | could that be removed in favour of the charmid ? | 14:44 |
| hatch | (not in this branch) | 14:45 |
| Makyo | jujugui emergency vet trip in a few, but will bring laptop. Still aiming to land the go-sandbox-deltas branch today | 14:45 |
| hatch | uh oh! Hope puppy is ok | 14:45 |
| rick_h | hatch: then we get into special casing, adding css for acting like a hover/clickable, etc | 14:45 |
| BradCrittenden | Makyo: good luck | 14:45 |
| === BradCrittenden is now known as bac | ||
| Makyo | Conjunctivitis, nothing too bad, but sure is gross :P | 14:45 |
| benji | heh | 14:45 |
| rick_h | hatch: I don't think killing link clicks in a specific case is bad. | 14:45 |
| hatch | no but it's impossible to find out where it's being blocked if you want it to | 14:46 |
| hatch | that's what my comment was about | 14:46 |
| rick_h | but we don't want to. How in the world would an autocomplete option have an <a> you want to follow? | 14:46 |
| rick_h | I'm missing how this causes any grief for later on trying to figure out "why is my click blocked"? | 14:47 |
| sinzui | benji, gunoy deployed your changes. Do they looks good? | 14:47 |
| benji | sinzui: cool! looking | 14:48 |
| benji | Cache-Control: max-age=0, public, must-revalidate | 14:48 |
| benji | perfect | 14:48 |
| benji | gary_poster: ^ | 14:48 |
| hatch | we probably wouldn't want to follow an a in an autocomplete (at least in this case) | 14:49 |
| rick_h | hatch: I've updated the comment to call out the <a> part to help | 14:49 |
| hatch | but prevented events in the middle of a script aren't clear when you're stepping through the code trying to find out wth is going on | 14:49 |
| rick_h | hatch: but I want to keep the same css, :hover, dom structure as other charm tokens and would prefer to not tweak the template on it. | 14:49 |
| rick_h | hatch: understand. | 14:50 |
| hatch | so that's why I was commenting about putting a note on the real listener | 14:50 |
| hatch | s | 14:50 |
| hatch | but those don't exist | 14:50 |
| hatch | heh | 14:50 |
| rick_h | and been there done that | 14:50 |
| rick_h | hatch: trust me, it took me a bit yesterday to figure out why things kept navigating :) | 14:50 |
| hatch | ugh anchors!! | 14:51 |
| hatch | semantic this!! | 14:51 |
| rick_h | hah | 14:51 |
| hatch | I still think the search is broken | 14:51 |
| rick_h | stop calling it search | 14:52 |
| rick_h | then it'll stop being broken | 14:52 |
| rick_h | :P | 14:52 |
| rick_h | it's not search | 14:52 |
| hatch | then don't have a description that says 'Search for charms' | 14:52 |
| hatch | :P | 14:52 |
| rick_h | and when you complete your search it works just like you expect | 14:52 |
| hatch | 'Autocomplete charm name here' | 14:52 |
| sinzui | benji, The release was delayed because the stable branch diverged when the developer branch was merged. r69 was replaced with an identical but different revision and bzr choked. | 14:53 |
| hatch | sorry you aren't going to convince me this time :) | 14:53 |
| benji | sinzui: yes, yes... I understand some of those words | 14:53 |
| rick_h | hatch: that's ok. It's good to be completely wrong somtimes and carry that with a badge of honor on your chest :) | 14:53 |
| hatch | rick_h: http://yuilibrary.com/yui/docs/autocomplete/ look at the example image even! | 14:53 |
| hatch | this is even used on Yahoo's own homepage! | 14:54 |
| rick_h | hatch: and they do evvvvverything right :P | 14:54 |
| sinzui | We need to think about the process to ensure we merge into stable, not replace stable. Your weren't involved in the mixup BTW. It just happened and it block your request | 14:54 |
| * hatch can't wait for the first public bug that the search is broken | 14:54 | |
| hatch | rick_h: ok I'm a little confused by your response about the empty left column | 14:58 |
| rick_h | hatch: k | 14:58 |
| hatch | I type ceph into the input | 14:58 |
| hatch | hit enter | 14:58 |
| hatch | it clears out the left column | 14:58 |
| rick_h | hatch: you've done a search now | 14:58 |
| rick_h | for the term "ceph" | 14:58 |
| rick_h | it's showing you the search results | 14:58 |
| hatch | oh man even I'm confused about this interaction, so it's a dual purpose input? | 14:59 |
| hatch | it autocompletes from the start of a string and acts as a search box? | 14:59 |
| rick_h | no, it's a search input. | 14:59 |
| rick_h | it's always been a search box | 14:59 |
| rick_h | you've just autocompleted a search term for the user | 15:00 |
| rick_h | this is why autocomplete != search | 15:00 |
| hatch | but you haven't because if I click that it opens the charm not fills in the input | 15:00 |
| rick_h | if I use google autocomplete on their search box "hatch is" it gives me suggestions, and then when I select one it does that search for me | 15:00 |
| rick_h | hatch: second, need more details then. It should fill in the input, do a search, and show you the details | 15:01 |
| rick_h | hatch: it's search autocomplete | 15:01 |
| hatch | ohhh NOW i see | 15:01 |
| hatch | there is a bug in here somewhere | 15:01 |
| rick_h | ok, I'm willing to admit there might be :/ | 15:02 |
| hatch | it was causing the sidebar to be emptied and then just showed the charm | 15:02 |
| hatch | like....empty as in nothing in it | 15:02 |
| rick_h | yea, that shouldn't happen | 15:02 |
| hatch | ok now how did I get it to do that | 15:02 |
| hatch | man that was confusing for both of us there lol | 15:02 |
| hatch | you thought I was an idiot, I thought you had gone crazy | 15:03 |
| hatch | haha | 15:03 |
| rick_h | "doctor it hurts when I do this." "stop doing that" | 15:03 |
| teknico | and you both were right! ;-) | 15:03 |
| hatch | lol!!! | 15:03 |
| hatch | rick_h: ok I don't know what's up here but probably 20% of the time it has an empty sidebar ..... ugh worst bugs ever | 15:05 |
| rick_h | hatch: ok, working on other parts of your review now. I'll peek at it in a sec | 15:06 |
| rick_h | hatch: watch the network tab in the debugger and see if the search call is going out/has response | 15:06 |
| hatch | yeah now I can't get it to do it at all | 15:07 |
| adeuring | abentley: new problem:; "File "/usr/lib/python2.7/dist-packages/juju/providers/common/connect.py", line 43, in run | 15:07 |
| adeuring | client = yield self._internal_connect(share) | 15:07 |
| adeuring | Error: [('PEM routines', 'PEM_read_bio', 'no start line')]" | 15:07 |
| hatch | at least when it's working it makes sense :P | 15:08 |
| abentley | adeuring: My guess is the paths to the included PEM files are wrong. You should extract the contents of orangesquad.zip to a single directory and source the script from there. | 15:09 |
| abentley | adeuring: No, wait... | 15:09 |
| abentley | adeuring: Yes, look into the PEM file paths. | 15:09 |
| adeuring | abentley: yeah, thanks!" | 15:10 |
| adeuring | abentley: did not help; the files which the env vars point to exists... | 15:14 |
| abentley | adeuring: Do the sha1 sums match? http://pastebin.ubuntu.com/5962937/ | 15:17 |
| adeuring | abentley: yes | 15:18 |
| hatch | jujugui call in 10 kanban now | 15:19 |
| abentley | adeuring: That's very weird. I don't know what to suggest. I don't know how it could claim those files have no start line. | 15:19 |
| abentley | I've only seen that when the path was wrong. | 15:19 |
| * Makyo returns. | 15:24 | |
| adeuring | abentley: sooo... could you update staging for me? | 15:26 |
| abentley | adeuring: Sure. What revno? | 15:26 |
| adeuring | abentley: 339 please | 15:27 |
| rick_h | hatch: updates to the other issues uploading now. If you can dupe please let me know and I'll try to fix. I'm working on trying to dupe it now. | 15:27 |
| hatch | rick_h: ok after call | 15:27 |
| rick_h | hatch: rgr | 15:27 |
| abentley | adeuring: config changed. Should be updated in a minute. | 15:28 |
| hatch | jujugui guichat in 2 | 15:28 |
| adeuring | tahnks | 15:28 |
| hatch | rick_h: \o/ | 15:43 |
| rick_h | hatch: yea, autocomplete/click a category, then go and autocomplete a charm not in that category | 15:43 |
| rick_h | hatch: and you end up with empty results because the search for that charm name + category (from earlier) has no results | 15:44 |
| abentley | hatch: are jujugui and guichat the same thing? | 15:44 |
| Makyo | abentley, yes, but jujugui pings in irc. | 15:44 |
| rick_h | abentley: yes, just that the second one doesn't ping the channel so easier for others not using it | 15:44 |
| bac | but when you use both in the same message it is moot | 15:45 |
| rick_h | lol | 15:45 |
| hatch | abentley: there are jujugui and guihelp which ping the whole channel (if you set it up in your configs) and we changed to using guichat to reference the guichat boardroom so we woudln't ding everyone with it's old name (jujugui) | 15:45 |
| Makyo | And now you have three pings \o/ | 15:46 |
| rick_h | will someone please smack him? | 15:46 |
| hatch | rick_h: CHOO CHOOO | 15:46 |
| Makyo | Ffffff | 15:46 |
| hatch | rofl | 15:46 |
| hatch | rick_h: lgtm'd | 15:49 |
| rick_h | hatch: thanks | 15:50 |
| hatch | I'm really glad you were able to dupe the bug haha | 15:50 |
| rick_h | yea, better to catch it now while my head is in the code | 15:50 |
| hatch | that was a pretty obscure one too | 15:50 |
| hatch | rick_h: this was me trying to repro that error http://nodejsreactions.tumblr.com/post/57620383823/var-result-fs-readfile-data-json-function | 15:54 |
| rick_h | lmao, that's awesome | 15:55 |
| rick_h | man, I can leave that running all day | 15:56 |
| hatch | haha yeah I laughed | 15:56 |
| rick_h | hatch: ok, bug fix upload fyi | 15:56 |
| hatch | heh such a easy fix | 15:58 |
| Makyo | gary_poster, ping for docs/vids meeting? | 16:03 |
| hatch | he forgot about us :'( | 16:09 |
| Makyo | gary_poster, we ducked out, ping if it's moved. | 16:20 |
| hatch | man native drag and drop is needlessly complex | 16:22 |
| gary_poster | jujugui, Makyo, hatch, sorry. Was suddenly called into meeting with Mark. I'm exhausted so that's ok that we will not be calling. :-P Lots more to talk about...our schedule will be changing more. :-) CLI work is huge. Will give more details soon. | 16:31 |
| hatch | no problem :) | 16:32 |
| hatch | right now I'm trying to decide if I hate virtualbox or windows 8 | 16:33 |
| hatch | one is buggy | 16:33 |
| hatch | haha | 16:33 |
| gary_poster | heh | 16:36 |
| hatch | [object Object] THANKS IE! | 16:37 |
| rick_h | go IE go! | 16:39 |
| rick_h | isn't IE12 out yet to make dev work not suck? | 16:39 |
| hatch | with all the praise IE11 is getting you know it's gona suck somehow | 16:40 |
| hatch | it's the same hype they had with IE10 | 16:40 |
| hatch | I actually got IE to drop on that empty canvas element | 16:42 |
| hatch | but only by causing a type error | 16:42 |
| hatch | lol | 16:42 |
| gary_poster | teknico, ping? | 16:46 |
| rick_h | thanks for the review bcsaller | 16:49 |
| bcsaller | np | 16:49 |
| hatch | why does the media wiki icon always take way longer to load? :) | 16:49 |
| rick_h | gary_poster: landing updated autocomplete now. Would love to get UX to look at if it's passible enough to un-feature flag it while we tweak the ui a little bit more. | 16:49 |
| rick_h | since people love it so much, let em have it :) | 16:50 |
| gary_poster | rick_h, cool, let me know when it is on comingsoon and I'll call 'em over. will that be good, or do you want me to merge? | 16:50 |
| rick_h | gary_poster: yea, I'll let you know | 16:50 |
| gary_poster | cool | 16:50 |
| rick_h | go my little lboxes go! | 16:51 |
| gary_poster | rick_h, if you could prep me with answers to "why does this not look like UX?" | 16:51 |
| gary_poster | that would probably help the conversation along ;-) | 16:51 |
| rick_h | gary_poster: sure thing, basically 'it's not in a google doc and rick couldn't find the place the mockup was at' | 16:52 |
| gary_poster | heh | 16:52 |
| rick_h | gary_poster: that + 'rick hasn't figured out how to do a seperator cleanly | 16:52 |
| rick_h | should sum it up | 16:52 |
| gary_poster | ok | 16:52 |
| gary_poster | rick_h, heh :-) cool | 16:52 |
| hatch | *sigh* | 16:56 |
| Makyo | We can switch to this: http://tinysubversions.com/gaunt/ | 17:02 |
| hatch | lol | 17:05 |
| frankban | Makyo: that should work beautifully as a template engine for whitespace: http://compsoc.dur.ac.uk/whitespace/ | 17:07 |
| Makyo | frankban, Hah: https://twitter.com/tinysubversions/status/365478093630095360 | 17:10 |
| frankban | heh | 17:12 |
| hatch | lol! | 17:12 |
| hatch | bcsaller: is the drap/drop import script supposed to support IE10? | 17:18 |
| bcsaller | hatch: uhh sure, I guess. I don't remember if that was verified as that feature was never officially published | 17:19 |
| bcsaller | hatch: I'm going to be changing the import stuff to be deployer format files in the next day or so if all goes well | 17:20 |
| bcsaller | but that was my only plan there, at that point though I think it will be a 'real' feature | 17:20 |
| hatch | ok because IE10 doesn't support custom strings in getData() | 17:21 |
| hatch | and that's causing other stuff to fall over | 17:21 |
| hatch | var dataType = evt._event.dataTransfer.getData('dataType'); | 17:21 |
| hatch | so that needs to be 'Text' | 17:21 |
| hatch | but then I think that'll break the actual functionality in modern browsers? | 17:21 |
| hatch | ya know what though...it might not matter | 17:25 |
| hatch | getting D&D to work with multiple drop targets in IE breaks it in chrome | 17:25 |
| hatch | ooo I got it dropping now in chrome and ie | 17:31 |
| hatch | now ff? | 17:31 |
| rick_h | you wish! | 17:31 |
| hatch | hey I didn't say the drop worked....just that it's actually 'dropping' lol | 17:32 |
| hatch | but you are correct | 17:32 |
| hatch | it doesn't work in FF at all | 17:32 |
| hatch | oh wait | 17:32 |
| hatch | it never did work in FF here | 17:32 |
| * hatch switched to other FF | 17:33 | |
| hatch | yusss | 17:33 |
| hatch | errors in all 3 browsers | 17:33 |
| rick_h | hah, you broke them all now? | 17:35 |
| hatch | yup! | 17:36 |
| hatch | DD WORKS IN ALL 3 DD WORKS IN ALL 3!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | 17:44 |
| hatch | it took 3 hours and probably broke every test we have but its working! | 17:44 |
| rick_h | lies! | 17:45 |
| hatch | well I'm going to take this time to review bc's branch | 17:45 |
| hatch | bcsaller | 17:45 |
| hatch | autocomplete fail | 17:46 |
| hatch | bcsaller: .... slice = [].slice does that actually work? ;) | 17:47 |
| bcsaller | hatch: with call it gets context | 18:01 |
| bcsaller | or apply | 18:01 |
| abentley | bac: Do you have a minute to hang out? I'd like to make sure we're not treading on each others' feet. | 18:01 |
| bac | hi abentley, yes i was just about to ask you the same | 18:09 |
| abentley | bac: guichat open. | 18:10 |
| hatch | bcsaller: I was referencing the FF issues of yesterday | 18:10 |
| hatch | :) | 18:10 |
| bac | abentley: i just saw you then you disappeared! | 18:10 |
| hatch | rick_h: https://plus.google.com/u/0/109440437666972345229/posts/SN6PnrYV3d6 | 18:15 |
| hatch | man I'm so pumped DD works in all 3 browsers now | 18:29 |
| rick_h | guihelp anyone a master of :nth css fun? | 18:29 |
| hatch | rick_h: http://fromanegg.com/post/57464448123/css-selectors-the-next-level ;) | 18:30 |
| rick_h | k, hatch volunteers to help | 18:30 |
| rick_h | yay hatch | 18:30 |
| rick_h | I really want a :last-with-class :/ | 18:32 |
| rick_h | hatch: got a sec for guichat? | 18:32 |
| hatch | rick_h: nth-last-of-type | 18:32 |
| hatch | sure | 18:32 |
| hatch | guichat is busy | 18:32 |
| rick_h | hatch: k, invite otw | 18:33 |
| * hatch lunching | 19:07 | |
| abentley | bac: Could you please review https://code.launchpad.net/~abentley/charmworld/separate-text-queries/+merge/179261 ? | 19:16 |
| bac | abentley: sure | 19:16 |
| bac | abentley: r=me | 19:18 |
| abentley | bac: Should land in 5 minutes. | 19:19 |
| abentley | bac: Delayed due to testing of https://codereview.appspot.com/12634045 | 19:35 |
| === schwuk is now known as schwuk_away | ||
| benji | abentley: I'm struggling to understand why UpdateCharmJob.run() has this line of code payload['_id'] = payload['branch_spec'] | 20:02 |
| benji | I would have expected the _id to be consistent with (if not actually use) construct_charm_id() | 20:02 |
| abentley | benji: construct_charm_id would cause the charm id to include the revision. That's the plan, but we're not there yet. | 20:03 |
| benji | hmm | 20:04 |
| benji | abentley: so... construct_charm_id doesn't actually construct an ID for a charm? | 20:05 |
| abentley | benji: It will. I landed it first because other branches needed it. | 20:06 |
| benji | I'll add a comment to that effect. | 20:06 |
| * hatch shakes fist | 20:30 | |
| hatch | damnnn you multi dispatch | 20:30 |
| hatch | 6 out of 1104 tests failing....not bad....not bad at all | 21:00 |
| hatch | bcsaller: are you still hanging around? | 21:02 |
| bcsaller | hatch: yeah | 21:02 |
| hatch | have a few minutes to look at my dd ie work? | 21:02 |
| bcsaller | hatch: sure | 21:02 |
| hatch | https://code.launchpad.net/~hatch/juju-gui/ie-dd-fix commented out code still needs to be added back in and the tests need to be fixed | 21:03 |
| hatch | just wanted to see if you had any negative comments about the approach taken | 21:03 |
| bcsaller | hatch: pulling it down now and looking at diff | 21:05 |
| bcsaller | hatch: chat for a sec, its basically fine but I wanted to mention something | 21:09 |
| hatch | sure | 21:09 |
| * Makyo dogwalks. | 21:14 | |
| hatch | *warning your site may look like absolute garbage if the user accidentally turns on 'compatibility mode'* | 22:19 |
| hatch | jujugui looking for 2 reviews and a qa in IE https://codereview.appspot.com/12683044/ plz and thx | 22:45 |
| huwshimi | Morning | 22:59 |
| hatch | morning huwshimi | 23:29 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!